buildbot failure in on apr-x64-macosx-trunk
The Buildbot has detected a new failure on builder apr-x64-macosx-trunk while building . Full details are available at: https://ci.apache.org/builders/apr-x64-macosx-trunk/builds/177 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: svn-x64-macosx-dgvrs Build Reason: forced: by IRC user on channel #apr: None Build Source Stamp: HEAD Blamelist: BUILD FAILED: failed Build Sincerely, -The Buildbot
buildbot failure in on apr-util-x64-macosx-1.6.x
The Buildbot has detected a new failure on builder apr-util-x64-macosx-1.6.x while building . Full details are available at: https://ci.apache.org/builders/apr-util-x64-macosx-1.6.x/builds/3 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: svn-x64-macosx-dgvrs Build Reason: forced: by IRC user on channel #apr: None Build Source Stamp: HEAD Blamelist: BUILD FAILED: failed Test Sincerely, -The Buildbot
buildbot failure in on apr-x64-macosx-1.6.x
The Buildbot has detected a new failure on builder apr-x64-macosx-1.6.x while building . Full details are available at: https://ci.apache.org/builders/apr-x64-macosx-1.6.x/builds/1 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: svn-x64-macosx-dgvrs Build Reason: forced: by IRC user on channel #apr: None Build Source Stamp: HEAD Blamelist: BUILD FAILED: failed Test Cleanup (after build) Sincerely, -The Buildbot
buildbot success in on apr-x64-macosx-1.6.x
The Buildbot has detected a restored build on builder apr-x64-macosx-1.6.x while building . Full details are available at: https://ci.apache.org/builders/apr-x64-macosx-1.6.x/builds/3 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: svn-x64-macosx-dgvrs Build Reason: forced: by IRC user on channel #apr: None Build Source Stamp: HEAD Blamelist: Build succeeded! Sincerely, -The Buildbot
Re: buildbot failure in on apr-x64-macosx-trunk
On 17.11.2018 15:24, build...@apache.org wrote: > The Buildbot has detected a new failure on builder apr-x64-macosx-trunk while > building . Full details are available at: > https://ci.apache.org/builders/apr-x64-macosx-trunk/builds/177 > > Buildbot URL: https://ci.apache.org/ > > Buildslave for this Build: svn-x64-macosx-dgvrs > > Build Reason: forced: by IRC user on channel #apr: None > Build Source Stamp: HEAD > Blamelist: > > BUILD FAILED: failed Build > > Sincerely, > -The Buildbot This is a Python3 compatiblity bug in build/gen-build.py: UnicodeDecodeError: 'ascii' codec can't decode byte 0xef in position 4731: ordinal not in range(128) We shouldn't assume source files contain only ASCII. -- Brane
buildbot success in on apr-util-x64-macosx-1.6.x
The Buildbot has detected a restored build on builder apr-util-x64-macosx-1.6.x while building . Full details are available at: https://ci.apache.org/builders/apr-util-x64-macosx-1.6.x/builds/4 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: svn-x64-macosx-dgvrs Build Reason: forced: by IRC user on channel #apr: None Build Source Stamp: HEAD Blamelist: Build succeeded! Sincerely, -The Buildbot
Re: buildbot failure in on apr-x64-macosx-trunk
> On 17 Nov 2018, at 14:49, Branko Čibej wrote: > > This is a Python3 compatiblity bug in build/gen-build.py: > > UnicodeDecodeError: 'ascii' codec can't decode byte 0xef in position > 4731: ordinal not in range(128) > > We shouldn't assume source files contain only ASCII. What source file is it complaining about? And is the issue under our control or in library code from Python? -- Nick Kew
buildbot success in on apr-util-x64-macosx-1.7.x
The Buildbot has detected a restored build on builder apr-util-x64-macosx-1.7.x while building . Full details are available at: https://ci.apache.org/builders/apr-util-x64-macosx-1.7.x/builds/1 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: svn-x64-macosx-dgvrs Build Reason: forced: by IRC user on channel #apr: None Build Source Stamp: HEAD Blamelist: Build succeeded! Sincerely, -The Buildbot
buildbot failure in on apr-x64-macosx-1.7.x
The Buildbot has detected a new failure on builder apr-x64-macosx-1.7.x while building . Full details are available at: https://ci.apache.org/builders/apr-x64-macosx-1.7.x/builds/1 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: svn-x64-macosx-dgvrs Build Reason: forced: by IRC user on channel #apr: None Build Source Stamp: HEAD Blamelist: BUILD FAILED: failed Test Sincerely, -The Buildbot
Re: buildbot failure in on apr-x64-macosx-trunk
On 17.11.2018 16:30, Nick Kew wrote: >> On 17 Nov 2018, at 14:49, Branko Čibej wrote: >> >> This is a Python3 compatiblity bug in build/gen-build.py: >> >> UnicodeDecodeError: 'ascii' codec can't decode byte 0xef in position >> 4731: ordinal not in range(128) >> >> We shouldn't assume source files contain only ASCII. > What source file is it complaining about? > And is the issue under our control or in library code from Python? The difference is that Python3 converts file contents to Unicode strings by default, whereas Python2 uses byte strings. I suspect the non-ASCII character comes from one of the system headers on macOS. It works for me (with Python3) on my laptop, but not on the buildslave — the former is macOS 10.14, the latter is 10.13. If fixed this by explicitly specifying UTF-8 conversion with codecs.open() instead of plain open(). However I'm not sure this is a good enough fix; it would probably be better to parse headers as raw strings in both Python 2 and 3, any kind of conversion makes too many assumptions. For now, though, the build works on the buildslave — and exposes a bug in shared memory handling on trunk and 1.7.x. -- Brane P.S.: I was a bit surprised that the Linux build slaves don't exercise the test suite at all, just the build.
Re: buildbot failure in on apr-x64-macosx-trunk
On 17.11.2018 18:21, Branko Čibej wrote: > On 17.11.2018 16:30, Nick Kew wrote: >>> On 17 Nov 2018, at 14:49, Branko Čibej wrote: >>> >>> This is a Python3 compatiblity bug in build/gen-build.py: >>> >>> UnicodeDecodeError: 'ascii' codec can't decode byte 0xef in position >>> 4731: ordinal not in range(128) >>> >>> We shouldn't assume source files contain only ASCII. >> What source file is it complaining about? >> And is the issue under our control or in library code from Python? > The difference is that Python3 converts file contents to Unicode strings > by default, whereas Python2 uses byte strings. I suspect the non-ASCII > character comes from one of the system headers on macOS. It works for me > (with Python3) on my laptop, but not on the buildslave — the former is > macOS 10.14, the latter is 10.13. > > If fixed this by explicitly specifying UTF-8 conversion with > codecs.open() instead of plain open(). However I'm not sure this is a > good enough fix; it would probably be better to parse headers as raw > strings in both Python 2 and 3, any kind of conversion makes too many > assumptions. > > For now, though, the build works on the buildslave — and exposes a bug > in shared memory handling on trunk and 1.7.x. > > -- Brane > > P.S.: I was a bit surprised that the Linux build slaves don't exercise > the test suite at all, just the build. FWIW, this is the current status: https://ci.apache.org/waterfall?tag=apr-trunk&tag=apr-branch-1.6&tag=apr-branch-1.7
Re: buildbot failure in on apr-x64-macosx-trunk
On 17.11.2018 18:21, Branko Čibej wrote: > P.S.: I was a bit surprised that the Linux build slaves don't exercise > the test suite at all, just the build. Hah. My bad. The tests are run but that's not immediately obvious from the waterfall display. Fixed.
New warnings on trunk in maintainer mode
I see the following new-ish warnings on trunk, on macOS: .../jose/apr_jose_decode.c:21:14: warning: no previous prototype for function 'apr_jose_flatten' [-Wmissing-prototypes] apr_status_t apr_jose_flatten(apr_bucket_brigade *bb, apr_jose_text_t *in, 13 of these, the above is just a sample ... prototypes (and docstrings) are missing from include/apr_jose.h. and: .../atomic/unix/builtins.c:71:53: warning: passing 'const void *' to parameter of type 'void *' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers] return (void*) __sync_val_compare_and_swap(mem, cmp, with); -- Brane
Re: New warnings on trunk in maintainer mode
On 17.11.2018 23:16, Branko Čibej wrote: > .../atomic/unix/builtins.c:71:53: warning: passing 'const void *' to > parameter of type 'void *' discards qualifiers > [-Wincompatible-pointer-types-discards-qualifiers] > return (void*) __sync_val_compare_and_swap(mem, cmp, with); I think the prototype for apr_atomic_casptr is just wrong; it should be void* apr_atomic_casptr(void *volatile *, void *, void *); not void* apr_atomic_casptr(void *volatile *, void *, const void *); Thoughts? Can we fix this in 2.x? -- Brane
