[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993224#comment-15993224 ] ASF subversion and git services commented on ARIA-138: -- Commit 29bc84be8cd0f05e1a741d39b6a1b8d3825fe108 in incubator-ariatosca's branch refs/heads/ARIA-140-version-utils from [~Mxmrlv] [ https://git-wip-us.apache.org/repos/asf?p=incubator-ariatosca.git;h=29bc84b ] ARIA-138-Make-logging-more-informative > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > Fix For: 0.1.0 > > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991672#comment-15991672 ] ASF subversion and git services commented on ARIA-138: -- Commit 29bc84be8cd0f05e1a741d39b6a1b8d3825fe108 in incubator-ariatosca's branch refs/heads/ARIA-139-attributes from [~Mxmrlv] [ https://git-wip-us.apache.org/repos/asf?p=incubator-ariatosca.git;h=29bc84b ] ARIA-138-Make-logging-more-informative > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > Fix For: 0.1.0 > > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976642#comment-15976642 ] ASF GitHub Bot commented on ARIA-138: - Github user asfgit closed the pull request at: https://github.com/apache/incubator-ariatosca/pull/104 > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976641#comment-15976641 ] ASF subversion and git services commented on ARIA-138: -- Commit 29bc84be8cd0f05e1a741d39b6a1b8d3825fe108 in incubator-ariatosca's branch refs/heads/master from [~Mxmrlv] [ https://git-wip-us.apache.org/repos/asf?p=incubator-ariatosca.git;h=29bc84b ] ARIA-138-Make-logging-more-informative > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976605#comment-15976605 ] ASF subversion and git services commented on ARIA-138: -- Commit 29bc84be8cd0f05e1a741d39b6a1b8d3825fe108 in incubator-ariatosca's branch refs/heads/ARIA-138-Make-logging-more-informative from [~Mxmrlv] [ https://git-wip-us.apache.org/repos/asf?p=incubator-ariatosca.git;h=29bc84b ] ARIA-138-Make-logging-more-informative > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976575#comment-15976575 ] ASF subversion and git services commented on ARIA-138: -- Commit ccdd32741db37322a97284247119ebb74a67f0c4 in incubator-ariatosca's branch refs/heads/ARIA-138-Make-logging-more-informative from [~Mxmrlv] [ https://git-wip-us.apache.org/repos/asf?p=incubator-ariatosca.git;h=ccdd327 ] ARIA-138-Make-logging-more-informative > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976565#comment-15976565 ] ASF GitHub Bot commented on ARIA-138: - Github user mxmrlv commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/104#discussion_r112435493 --- Diff: aria/cli/commands/executions.py --- @@ -141,12 +143,19 @@ def start(workflow_name, logger.info('Starting {0}execution. Press Ctrl+C cancel'.format('dry ' if dry else '')) execution_thread.start() + +log_iterator = cli_logger.ModelLogIterator(model_storage, workflow_runner.execution_id) try: while execution_thread.is_alive(): -# using join without a timeout blocks and ignores KeyboardInterrupt +execution_logging.log_list(log_iterator) execution_thread.join(1) + except KeyboardInterrupt: -_cancel_execution(workflow_runner, execution_thread, logger) +_cancel_execution(model_storage, workflow_runner, execution_thread, logger) --- End diff -- move model_storage later > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976566#comment-15976566 ] ASF GitHub Bot commented on ARIA-138: - Github user mxmrlv commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/104#discussion_r112435567 --- Diff: aria/cli/commands/logs.py --- @@ -12,13 +12,12 @@ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. - -from .. import utils -from ..core import aria +from ..logger import ModelLogIterator +from .. core import aria --- End diff -- ? > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976563#comment-15976563 ] ASF GitHub Bot commented on ARIA-138: - Github user mxmrlv commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/104#discussion_r112435593 --- Diff: aria/cli/commands/logs.py --- @@ -12,13 +12,12 @@ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. - -from .. import utils -from ..core import aria +from ..logger import ModelLogIterator +from .. core import aria --- End diff -- should also be before logger > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976562#comment-15976562 ] ASF GitHub Bot commented on ARIA-138: - Github user mxmrlv commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/104#discussion_r112436004 --- Diff: aria/orchestrator/workflows/core/engine.py --- @@ -40,6 +40,7 @@ class Engine(logger.LoggerMixin): def __init__(self, executor, workflow_context, tasks_graph, **kwargs): super(Engine, self).__init__(**kwargs) +self.logger.addHandler(logger.NullHandler()) --- End diff -- ??? > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976564#comment-15976564 ] ASF GitHub Bot commented on ARIA-138: - Github user mxmrlv commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/104#discussion_r112435477 --- Diff: aria/cli/commands/executions.py --- @@ -161,11 +170,13 @@ def start(workflow_name, model_storage.execution.delete(execution) -def _cancel_execution(workflow_runner, execution_thread, logger): +def _cancel_execution(model_storage, workflow_runner, execution_thread, logger): logger.info('Cancelling execution. Press Ctrl+C again to force-cancel') +log_iterator = cli_logger.ModelLogIterator(model_storage, workflow_runner.execution_id) --- End diff -- use existing > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976525#comment-15976525 ] ASF subversion and git services commented on ARIA-138: -- Commit 18f9f18e48b0ca128671909504537bb8b3daa02d in incubator-ariatosca's branch refs/heads/ARIA-138-Make-logging-more-informative from [~Mxmrlv] [ https://git-wip-us.apache.org/repos/asf?p=incubator-ariatosca.git;h=18f9f18 ] ARIA-138-Make-logging-more-informative > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976523#comment-15976523 ] ASF subversion and git services commented on ARIA-138: -- Commit 52c64f593bc22f718e16deb60fa51b86714d087a in incubator-ariatosca's branch refs/heads/ARIA-138-Make-logging-more-informative from [~Mxmrlv] [ https://git-wip-us.apache.org/repos/asf?p=incubator-ariatosca.git;h=52c64f5 ] ARIA-138-Make-logging-more-informative > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976516#comment-15976516 ] ASF subversion and git services commented on ARIA-138: -- Commit 59d5301fc0598c9e27458388d02e89d7b9a3f2bc in incubator-ariatosca's branch refs/heads/ARIA-138-Make-logging-more-informative from [~Mxmrlv] [ https://git-wip-us.apache.org/repos/asf?p=incubator-ariatosca.git;h=59d5301 ] ARIA-138-Make-logging-more-informative > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976435#comment-15976435 ] ASF GitHub Bot commented on ARIA-138: - Github user ran-z commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/104#discussion_r112417076 --- Diff: aria/cli/commands/executions.py --- @@ -19,6 +19,8 @@ from .. import table from .. import utils from ..core import aria +from .. import logger as cli_logger --- End diff -- move above the previous import > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976436#comment-15976436 ] ASF GitHub Bot commented on ARIA-138: - Github user ran-z commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/104#discussion_r112417099 --- Diff: aria/cli/commands/logs.py --- @@ -12,13 +12,12 @@ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. - -from .. import utils -from ..core import aria +from ..logger import ModelLogIterator +from ..cli import aria --- End diff -- this line is wrong > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976428#comment-15976428 ] ASF GitHub Bot commented on ARIA-138: - Github user mxmrlv commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/104#discussion_r112405930 --- Diff: aria/cli/commands/executions.py --- @@ -144,17 +144,17 @@ def start(workflow_name, logger.info('Starting {0}execution. Press Ctrl+C cancel'.format('dry ' if dry else '')) execution_thread.start() -log_consumer = cli_logger.ModelLogConsumer(model_storage, workflow_runner.execution_id) +log_iterator = cli_logger.ModelLogIterator(model_storage, workflow_runner.execution_id) try: while execution_thread.is_alive(): -for log in log_consumer: -execution_logging.load(log).log() +execution_logging.drain(log_iterator) --- End diff -- join > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976429#comment-15976429 ] ASF GitHub Bot commented on ARIA-138: - Github user mxmrlv commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/104#discussion_r112408993 --- Diff: aria/cli/execution_logging.py --- @@ -14,53 +14,68 @@ # limitations under the License. import os +from StringIO import StringIO from . import logger from .env import env DEFAULT_FORMATTING = { -logger.NO_VERBOSE: {'main_msg': '{item.msg}'}, +logger.NO_VERBOSE: {'message': '{item.msg}'}, logger.LOW_VERBOSE: { -'main_msg': '{created_at} | {item.level[0]} | {item.msg}', -'created_at': '%H:%M:%S' -} +'message': '{timestamp} | {item.level[0]} | {item.msg}', +'timestamp': '%H:%M:%S' +}, +logger.MEDIUM_VERBOSE: { +'message': '{timestamp} | {item.level[0]} | {item.msg} | {implementation}', +'timestamp': '%H:%M:%S' +}, +logger.HIGH_VERBOSE: { +'message': '{timestamp} | {item.level[0]} | {item.msg} | {implementation}({inputs})', +'timestamp': '%H:%M:%S' +}, } -class load(object): +def _str(item, formatting=None): +# Only NO_VERBOSE and LOW_VERBOSE are configurable formats. configuring +# the low verbose level should affect any higher level. +formats = formatting or DEFAULT_FORMATTING +formatting = formats[env.logging.verbosity_level] +msg = StringIO() -def __init__(self, item, formats=None): -self._item = item -self._formats = formats or DEFAULT_FORMATTING +kwargs = dict(item=item) --- End diff -- rename > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976430#comment-15976430 ] ASF GitHub Bot commented on ARIA-138: - Github user mxmrlv commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/104#discussion_r112408517 --- Diff: aria/orchestrator/workflows/events_logging.py --- @@ -24,23 +24,31 @@ from .. import events +def _get_task_name(task): +if hasattr(task.actor, 'source_node'): --- End diff -- isinstance > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976431#comment-15976431 ] ASF GitHub Bot commented on ARIA-138: - Github user mxmrlv commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/104#discussion_r112406038 --- Diff: aria/cli/commands/executions.py --- @@ -144,17 +144,17 @@ def start(workflow_name, logger.info('Starting {0}execution. Press Ctrl+C cancel'.format('dry ' if dry else '')) execution_thread.start() -log_consumer = cli_logger.ModelLogConsumer(model_storage, workflow_runner.execution_id) +log_iterator = cli_logger.ModelLogIterator(model_storage, workflow_runner.execution_id) try: while execution_thread.is_alive(): -for log in log_consumer: -execution_logging.load(log).log() +execution_logging.drain(log_iterator) except KeyboardInterrupt: _cancel_execution(workflow_runner, execution_thread, logger) -for log in log_consumer: -execution_logging.load(log).log() +# It might be the case where some logs were written and the execution was terminated, thus we +# need to drain the remaining logs. +execution_logging.drain(log_iterator) --- End diff -- 177 : add logging > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976427#comment-15976427 ] ASF GitHub Bot commented on ARIA-138: - Github user mxmrlv commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/104#discussion_r112410679 --- Diff: aria/cli/execution_logging.py --- @@ -14,53 +14,68 @@ # limitations under the License. import os +from StringIO import StringIO from . import logger from .env import env DEFAULT_FORMATTING = { -logger.NO_VERBOSE: {'main_msg': '{item.msg}'}, +logger.NO_VERBOSE: {'message': '{item.msg}'}, logger.LOW_VERBOSE: { -'main_msg': '{created_at} | {item.level[0]} | {item.msg}', -'created_at': '%H:%M:%S' -} +'message': '{timestamp} | {item.level[0]} | {item.msg}', +'timestamp': '%H:%M:%S' +}, +logger.MEDIUM_VERBOSE: { +'message': '{timestamp} | {item.level[0]} | {item.msg} | {implementation}', +'timestamp': '%H:%M:%S' +}, +logger.HIGH_VERBOSE: { +'message': '{timestamp} | {item.level[0]} | {item.msg} | {implementation}({inputs})', +'timestamp': '%H:%M:%S' +}, } -class load(object): +def _str(item, formatting=None): +# Only NO_VERBOSE and LOW_VERBOSE are configurable formats. configuring +# the low verbose level should affect any higher level. +formats = formatting or DEFAULT_FORMATTING +formatting = formats[env.logging.verbosity_level] +msg = StringIO() -def __init__(self, item, formats=None): -self._item = item -self._formats = formats or DEFAULT_FORMATTING +kwargs = dict(item=item) -def __repr__(self): -# Only NO_VERBOSE and LOW_VERBOSE are configurable formats. configuring -# the low verbose level should affect any higher level. -formats = self._formats[min(env.logging.verbosity_level, logger.LOW_VERBOSE)] +if item.task: +kwargs['implementation'] = item.task.implementation +kwargs['inputs'] = dict(i.unwrap() for i in item.task.inputs.values()) +else: +kwargs['implementation'] = item.execution.workflow_name +kwargs['inputs'] = dict(i.unwrap() for i in item.execution.inputs.values()) -kwargs = dict(item=self._item) -if 'created_at' in formats: -kwargs['created_at'] = self._item.created_at.strftime(formats['created_at']) -if 'level' in formats: -kwargs['level'] = formats['level'].format(self._item.level) -if 'msg' in formats: -kwargs['msg'] = formats['msg'].format(self._item.msg) +if 'timestamp' in formatting: +kwargs['timestamp'] = item.created_at.strftime(formatting['timestamp']) +else: +kwargs['timestamp'] = item.created_at -if 'actor' in formats and self._item.task: -kwargs['actor'] = formats['actor'].format(self._item.task.actor) -if 'execution' in formats: -kwargs['execution'] = formats['execution'].format(self._item.execution) +# If no format was supplied just print out the original msg. +msg.write(formatting.get('message', '{item.msg}').format(**kwargs)) --- End diff -- use default > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974793#comment-15974793 ] ASF GitHub Bot commented on ARIA-138: - Github user mxmrlv commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/104#discussion_r112218544 --- Diff: aria/orchestrator/workflows/core/engine.py --- @@ -40,6 +41,7 @@ class Engine(logger.LoggerMixin): def __init__(self, executor, workflow_context, tasks_graph, **kwargs): super(Engine, self).__init__(**kwargs) +self.logger.addHandler(logging.NullHandler()) --- End diff -- look up NullHandlers in code and make sure it makes sense > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974795#comment-15974795 ] ASF GitHub Bot commented on ARIA-138: - Github user mxmrlv commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/104#discussion_r112213890 --- Diff: aria/cli/commands/executions.py --- @@ -141,13 +143,19 @@ def start(workflow_name, logger.info('Starting {0}execution. Press Ctrl+C cancel'.format('dry ' if dry else '')) execution_thread.start() + +log_consumer = cli_logger.ModelLogConsumer(model_storage, workflow_runner.execution_id) --- End diff -- Iterator > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974792#comment-15974792 ] ASF GitHub Bot commented on ARIA-138: - Github user mxmrlv commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/104#discussion_r112217210 --- Diff: aria/orchestrator/context/common.py --- @@ -38,43 +38,44 @@ class BaseContext(object): """ class PrefixedLogger(object): -def __init__(self, logger, prefix='', task_id=None): -self._logger = logger -self._prefix = prefix +def __init__(self, base_logger, task_id=None): +self._logger = base_logger self._task_id = task_id def __getattr__(self, item): --- End diff -- , attr... > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974796#comment-15974796 ] ASF GitHub Bot commented on ARIA-138: - Github user mxmrlv commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/104#discussion_r112213856 --- Diff: aria/cli/commands/__init__.py --- @@ -1,3 +1,4 @@ + --- End diff -- remove > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974791#comment-15974791 ] ASF GitHub Bot commented on ARIA-138: - Github user mxmrlv commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/104#discussion_r112219717 --- Diff: aria/orchestrator/workflows/core/engine.py --- @@ -20,6 +20,7 @@ import time --- End diff -- visit dry.py and check output > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974794#comment-15974794 ] ASF GitHub Bot commented on ARIA-138: - Github user mxmrlv commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/104#discussion_r112216372 --- Diff: aria/cli/execution_logging.py --- @@ -0,0 +1,66 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +import os + +from . import logger +from .env import env + +DEFAULT_FORMATTING = { +logger.NO_VERBOSE: {'main_msg': '{item.msg}'}, +logger.LOW_VERBOSE: { +'main_msg': '{created_at} | {item.level[0]} | {item.msg}', +'created_at': '%H:%M:%S' +} +} + + +class load(object): + +def __init__(self, item, formats=None): +self._item = item +self._formats = formats or DEFAULT_FORMATTING + +def __repr__(self): +# Only NO_VERBOSE and LOW_VERBOSE are configurable formats. configuring +# the low verbose level should affect any higher level. +formats = self._formats[min(env.logging.verbosity_level, logger.LOW_VERBOSE)] + +kwargs = dict(item=self._item) +if 'created_at' in formats: +kwargs['created_at'] = self._item.created_at.strftime(formats['created_at']) +if 'level' in formats: --- End diff -- no need > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974790#comment-15974790 ] ASF GitHub Bot commented on ARIA-138: - Github user mxmrlv commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/104#discussion_r112215420 --- Diff: aria/cli/execution_logging.py --- @@ -0,0 +1,66 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +import os + +from . import logger +from .env import env + +DEFAULT_FORMATTING = { +logger.NO_VERBOSE: {'main_msg': '{item.msg}'}, +logger.LOW_VERBOSE: { +'main_msg': '{created_at} | {item.level[0]} | {item.msg}', +'created_at': '%H:%M:%S' +} +} + + +class load(object): --- End diff -- remove class > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974747#comment-15974747 ] ASF GitHub Bot commented on ARIA-138: - GitHub user mxmrlv opened a pull request: https://github.com/apache/incubator-ariatosca/pull/104 ARIA-138-Make-logging-more-informative You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/incubator-ariatosca ARIA-138-Make-logging-more-informative Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-ariatosca/pull/104.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #104 commit d90194dcfa35b4cf0e833449c58de10336c79971 Author: max-orlov Date: 2017-04-19T14:14:15Z ARIA-138-Make-logging-more-informative > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974746#comment-15974746 ] ASF subversion and git services commented on ARIA-138: -- Commit d90194dcfa35b4cf0e833449c58de10336c79971 in incubator-ariatosca's branch refs/heads/ARIA-138-Make-logging-more-informative from [~Mxmrlv] [ https://git-wip-us.apache.org/repos/asf?p=incubator-ariatosca.git;h=d90194d ] ARIA-138-Make-logging-more-informative > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974745#comment-15974745 ] ASF GitHub Bot commented on ARIA-138: - Github user asfgit closed the pull request at: https://github.com/apache/incubator-ariatosca/pull/103 > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974733#comment-15974733 ] ASF GitHub Bot commented on ARIA-138: - Github user mxmrlv commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/103#discussion_r112209176 --- Diff: aria/cli/commands/executions.py --- @@ -141,13 +143,19 @@ def start(workflow_name, logger.info('Starting {0}execution. Press Ctrl+C cancel'.format('dry ' if dry else '')) execution_thread.start() + +log_consumer = cli_logger.ModelLogConsumer(model_storage, workflow_runner.execution_id) --- End diff -- Iterator > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974735#comment-15974735 ] ASF GitHub Bot commented on ARIA-138: - Github user mxmrlv commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/103#discussion_r112196903 --- Diff: aria/cli/commands/__init__.py --- @@ -1,3 +1,4 @@ + --- End diff -- remove > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974736#comment-15974736 ] ASF GitHub Bot commented on ARIA-138: - Github user mxmrlv commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/103#discussion_r112205367 --- Diff: aria/cli/execution_logging.py --- @@ -0,0 +1,66 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +import os + +from . import logger +from .env import env + +DEFAULT_FORMATTING = { +logger.NO_VERBOSE: {'main_msg': '{item.msg}'}, +logger.LOW_VERBOSE: { +'main_msg': '{created_at} | {item.level[0]} | {item.msg}', +'created_at': '%H:%M:%S' +} +} + + +class load(object): --- End diff -- rename > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974734#comment-15974734 ] ASF GitHub Bot commented on ARIA-138: - Github user mxmrlv commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/103#discussion_r112209345 --- Diff: aria/cli/commands/executions.py --- @@ -141,13 +143,19 @@ def start(workflow_name, logger.info('Starting {0}execution. Press Ctrl+C cancel'.format('dry ' if dry else '')) execution_thread.start() + +log_consumer = cli_logger.ModelLogConsumer(model_storage, workflow_runner.execution_id) try: while execution_thread.is_alive(): -# using join without a timeout blocks and ignores KeyboardInterrupt -execution_thread.join(1) +for log in log_consumer: +execution_logging.load(log).log() + except KeyboardInterrupt: _cancel_execution(workflow_runner, execution_thread, logger) +for log in log_consumer: --- End diff -- add comment > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974528#comment-15974528 ] ASF subversion and git services commented on ARIA-138: -- Commit aaac6f6018c878bdec6036dd2f9ab5e0662140c6 in incubator-ariatosca's branch refs/heads/ARIA-138-Make-logging-more-informative from [~Mxmrlv] [ https://git-wip-us.apache.org/repos/asf?p=incubator-ariatosca.git;h=aaac6f6 ] ARIA-138-Make-logging-more-informative > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974417#comment-15974417 ] ASF subversion and git services commented on ARIA-138: -- Commit 2f038276ea1aa01b5bdaf7e908aafe398f75b53d in incubator-ariatosca's branch refs/heads/ARIA-138-Make-logging-more-informative from [~Mxmrlv] [ https://git-wip-us.apache.org/repos/asf?p=incubator-ariatosca.git;h=2f03827 ] ARIA-138-Make-logging-more-informative > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974334#comment-15974334 ] ASF GitHub Bot commented on ARIA-138: - GitHub user mxmrlv opened a pull request: https://github.com/apache/incubator-ariatosca/pull/103 ARIA-138-Make-logging-more-informative You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/incubator-ariatosca ARIA-138-Make-logging-more-informative Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-ariatosca/pull/103.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #103 > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974333#comment-15974333 ] ASF subversion and git services commented on ARIA-138: -- Commit b180485c492f1c7ad0fd17cc502db7d0755cbd13 in incubator-ariatosca's branch refs/heads/ARIA-138-Make-logging-more-informative from [~Mxmrlv] [ https://git-wip-us.apache.org/repos/asf?p=incubator-ariatosca.git;h=b180485 ] ARIA-138-Make-logging-more-informative > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971256#comment-15971256 ] ASF subversion and git services commented on ARIA-138: -- Commit e23f5df8d26a026c0ba98c6e7818d12a67282055 in incubator-ariatosca's branch refs/heads/misc_fixes_for_os_plugin from [~Mxmrlv] [ https://git-wip-us.apache.org/repos/asf?p=incubator-ariatosca.git;h=e23f5df ] ARIA-138-Make-logging-more-informative > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971252#comment-15971252 ] ASF subversion and git services commented on ARIA-138: -- Commit e23f5df8d26a026c0ba98c6e7818d12a67282055 in incubator-ariatosca's branch refs/heads/ARIA-138-Make-logging-more-informative from [~Mxmrlv] [ https://git-wip-us.apache.org/repos/asf?p=incubator-ariatosca.git;h=e23f5df ] ARIA-138-Make-logging-more-informative > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971242#comment-15971242 ] ASF subversion and git services commented on ARIA-138: -- Commit 105bad2064d4488eeb7fd6c7c8441a38401a83e9 in incubator-ariatosca's branch refs/heads/ARIA-138-Make-logging-more-informative from [~Mxmrlv] [ https://git-wip-us.apache.org/repos/asf?p=incubator-ariatosca.git;h=105bad2 ] ARIA-138-Make-logging-more-informative > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-138) CLI output verbosity levels
[ https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967628#comment-15967628 ] ASF subversion and git services commented on ARIA-138: -- Commit 9e2b70cf1b239ada4de20dad27cf7a6e81ddb8f7 in incubator-ariatosca's branch refs/heads/ARIA-138-Make-logging-more-informative from [~Mxmrlv] [ https://git-wip-us.apache.org/repos/asf?p=incubator-ariatosca.git;h=9e2b70c ] ARIA-138-Make-logging-more-informative > CLI output verbosity levels > --- > > Key: ARIA-138 > URL: https://issues.apache.org/jira/browse/ARIA-138 > Project: AriaTosca > Issue Type: Story >Reporter: Maxim Orlov >Assignee: Maxim Orlov > > The CLI should support the display of the following logging levels: > default: execution logs: simple representation of executed operations > -v : execution logs: representation with time stamps and logging levels > -vv: execution logs: retrieve the stacktrace of any failed operation. > -vvv : all configured loggers should be set to {{debug}} level; any CLI > errors should be logged and printed with their stack trace as well. > (both the default and the first level of logging format should be > configurable). > Note that all of the operations logs should be saved in the storage. This > issue relates only to the way the logs are displayed in the CLI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)