[jira] [Commented] (ARIES-1712) Blueprint maven plugin: common code in transaction factories
[ https://issues.apache.org/jira/browse/ARIES-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15962414#comment-15962414 ] David Jencks commented on ARIES-1712: - With some packaging finesse you could include a helper class or superclass in all jars. I don't know if it would be worth it, but duplicate code might well produce more long-term problems than unusual packaging. > Blueprint maven plugin: common code in transaction factories > > > Key: ARIES-1712 > URL: https://issues.apache.org/jira/browse/ARIES-1712 > Project: Aries > Issue Type: Improvement > Components: Blueprint >Reporter: Andrei Shakirin > > blueprint maven plugin uses following factories to proceed different kind of > transaction annotations: JavaxTransactionFactory, CdiTransactionFactory, > CdiTransactionFactory. > Basically factories implement very similar functionality triggered by > different kind of annotation classes. > Currently these transacation factories are decoupled one from other, but they > repeat a lot of code: namespace handling, attribute writer, etc. > Proposal: refactor common functionality either to delegate helper or to > abstract class. In case if proposal sounds reasonable for you, I will provide > the patch. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIES-1712) Blueprint maven plugin: common code in transaction factories
[ https://issues.apache.org/jira/browse/ARIES-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15962213#comment-15962213 ] Dominik Przybysz commented on ARIES-1712: - It was designed in such way to keep pluggable architecture of blueprint maven plugin. Each annotations processors sets should be split to separate jars, which should be independent to each other. It is of course melody of future. We could extract common code for javax and javax.cdi transaction factories, but spring transaction factory should be kept independent. > Blueprint maven plugin: common code in transaction factories > > > Key: ARIES-1712 > URL: https://issues.apache.org/jira/browse/ARIES-1712 > Project: Aries > Issue Type: Improvement > Components: Blueprint >Reporter: Andrei Shakirin > > blueprint maven plugin uses following factories to proceed different kind of > transaction annotations: JavaxTransactionFactory, CdiTransactionFactory, > CdiTransactionFactory. > Basically factories implement very similar functionality triggered by > different kind of annotation classes. > Currently these transacation factories are decoupled one from other, but they > repeat a lot of code: namespace handling, attribute writer, etc. > Proposal: refactor common functionality either to delegate helper or to > abstract class. In case if proposal sounds reasonable for you, I will provide > the patch. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (ARIES-1712) Blueprint maven plugin: common code in transaction factories
Andrei Shakirin created ARIES-1712: -- Summary: Blueprint maven plugin: common code in transaction factories Key: ARIES-1712 URL: https://issues.apache.org/jira/browse/ARIES-1712 Project: Aries Issue Type: Improvement Components: Blueprint Reporter: Andrei Shakirin blueprint maven plugin uses following factories to proceed different kind of transaction annotations: JavaxTransactionFactory, CdiTransactionFactory, CdiTransactionFactory. Basically factories implement very similar functionality triggered by different kind of annotation classes. Currently these transacation factories are decoupled one from other, but they repeat a lot of code: namespace handling, attribute writer, etc. Proposal: refactor common functionality either to delegate helper or to abstract class. In case if proposal sounds reasonable for you, I will provide the patch. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
