[jira] [Commented] (ARIES-1573) RSA discovery from ConfigAdmin
[ https://issues.apache.org/jira/browse/ARIES-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347932#comment-15347932 ] ASF subversion and git services commented on ARIES-1573: Commit 51f3c34740766e7e9b5c53724de2fe4000316213 in aries-rsa's branch refs/heads/master from [~dpishchukhin] [ https://git-wip-us.apache.org/repos/asf?p=aries-rsa.git;h=51f3c34 ] [ARIES-1573] Integration tests > RSA discovery from ConfigAdmin > -- > > Key: ARIES-1573 > URL: https://issues.apache.org/jira/browse/ARIES-1573 > Project: Aries > Issue Type: Improvement > Components: Remote Service Admin >Affects Versions: rsa-1.8.0 >Reporter: Dmytro Pishchukhin >Assignee: Christian Schneider > Fix For: rsa-1.9.0 > > > There is an idea to discover import services from CA configurations. > It's a separate module that registers ManagedServiceFactory and creates > EndpointDescription(s) from configuration. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1573) RSA discovery from ConfigAdmin
[ https://issues.apache.org/jira/browse/ARIES-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347933#comment-15347933 ] ASF subversion and git services commented on ARIES-1573: Commit b33cdf31082beb9e55c56da31696b8faea840881 in aries-rsa's branch refs/heads/master from [~ch...@die-schneider.net] [ https://git-wip-us.apache.org/repos/asf?p=aries-rsa.git;h=b33cdf3 ] [ARIES-1573] Refactored tests to avoid duplications > RSA discovery from ConfigAdmin > -- > > Key: ARIES-1573 > URL: https://issues.apache.org/jira/browse/ARIES-1573 > Project: Aries > Issue Type: Improvement > Components: Remote Service Admin >Affects Versions: rsa-1.8.0 >Reporter: Dmytro Pishchukhin >Assignee: Christian Schneider > Fix For: rsa-1.9.0 > > > There is an idea to discover import services from CA configurations. > It's a separate module that registers ManagedServiceFactory and creates > EndpointDescription(s) from configuration. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1573) RSA discovery from ConfigAdmin
[ https://issues.apache.org/jira/browse/ARIES-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346004#comment-15346004 ] Dmytro Pishchukhin commented on ARIES-1573: --- Theoretically we can merge. The initial idea was to make it independently from local discovery because it's not a spec implementation (hope it appears in RSA spec some day). > RSA discovery from ConfigAdmin > -- > > Key: ARIES-1573 > URL: https://issues.apache.org/jira/browse/ARIES-1573 > Project: Aries > Issue Type: Improvement > Components: Remote Service Admin >Affects Versions: rsa-1.8.0 >Reporter: Dmytro Pishchukhin >Assignee: Christian Schneider > Fix For: rsa-1.9.0 > > > There is an idea to discover import services from CA configurations. > It's a separate module that registers ManagedServiceFactory and creates > EndpointDescription(s) from configuration. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1573) RSA discovery from ConfigAdmin
[ https://issues.apache.org/jira/browse/ARIES-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345986#comment-15345986 ] Christian Schneider commented on ARIES-1573: I also wonder if we should maybe merge the local discovery and the config module. The config module does not have any additional requirements and I think it does not hurt to have it installed by default. WDYT? > RSA discovery from ConfigAdmin > -- > > Key: ARIES-1573 > URL: https://issues.apache.org/jira/browse/ARIES-1573 > Project: Aries > Issue Type: Improvement > Components: Remote Service Admin >Affects Versions: rsa-1.8.0 >Reporter: Dmytro Pishchukhin >Assignee: Christian Schneider > Fix For: rsa-1.9.0 > > > There is an idea to discover import services from CA configurations. > It's a separate module that registers ManagedServiceFactory and creates > EndpointDescription(s) from configuration. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1573) RSA discovery from ConfigAdmin
[ https://issues.apache.org/jira/browse/ARIES-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342358#comment-15342358 ] Christian Schneider commented on ARIES-1573: Thx. Yes you can reuse the issue. > RSA discovery from ConfigAdmin > -- > > Key: ARIES-1573 > URL: https://issues.apache.org/jira/browse/ARIES-1573 > Project: Aries > Issue Type: Improvement > Components: Remote Service Admin >Reporter: Dmytro Pishchukhin >Assignee: Christian Schneider > > There is an idea to discover import services from CA configurations. > It's a separate module that registers ManagedServiceFactory and creates > EndpointDescription(s) from configuration. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1573) RSA discovery from ConfigAdmin
[ https://issues.apache.org/jira/browse/ARIES-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342353#comment-15342353 ] Dmytro Pishchukhin commented on ARIES-1573: --- sure. I can create itests. should I use the same issue id? > RSA discovery from ConfigAdmin > -- > > Key: ARIES-1573 > URL: https://issues.apache.org/jira/browse/ARIES-1573 > Project: Aries > Issue Type: Improvement > Components: Remote Service Admin >Reporter: Dmytro Pishchukhin >Assignee: Christian Schneider > > There is an idea to discover import services from CA configurations. > It's a separate module that registers ManagedServiceFactory and creates > EndpointDescription(s) from configuration. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1573) RSA discovery from ConfigAdmin
[ https://issues.apache.org/jira/browse/ARIES-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342346#comment-15342346 ] Christian Schneider commented on ARIES-1573: I added some small fixes for warnings and merged the PR. Many thanks for the contribution and for going to the review. It would be great if you could also create an itest but I can also take care of it. > RSA discovery from ConfigAdmin > -- > > Key: ARIES-1573 > URL: https://issues.apache.org/jira/browse/ARIES-1573 > Project: Aries > Issue Type: Improvement > Components: Remote Service Admin >Reporter: Dmytro Pishchukhin >Assignee: Christian Schneider > > There is an idea to discover import services from CA configurations. > It's a separate module that registers ManagedServiceFactory and creates > EndpointDescription(s) from configuration. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1573) RSA discovery from ConfigAdmin
[ https://issues.apache.org/jira/browse/ARIES-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342339#comment-15342339 ] ASF subversion and git services commented on ARIES-1573: Commit 7c73a3710580859323550fb8a2ea91cc3ddf875e in aries-rsa's branch refs/heads/master from [~ch...@die-schneider.net] [ https://git-wip-us.apache.org/repos/asf?p=aries-rsa.git;h=7c73a37 ] [ARIES-1573] Fix warnings. closes #7 > RSA discovery from ConfigAdmin > -- > > Key: ARIES-1573 > URL: https://issues.apache.org/jira/browse/ARIES-1573 > Project: Aries > Issue Type: Improvement > Components: Remote Service Admin >Reporter: Dmytro Pishchukhin >Assignee: Christian Schneider > > There is an idea to discover import services from CA configurations. > It's a separate module that registers ManagedServiceFactory and creates > EndpointDescription(s) from configuration. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1573) RSA discovery from ConfigAdmin
[ https://issues.apache.org/jira/browse/ARIES-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341819#comment-15341819 ] Dmytro Pishchukhin commented on ARIES-1573: --- Hi Christian, I changed to a new PR: https://github.com/apache/aries-rsa/pull/7 could you check, pls? > RSA discovery from ConfigAdmin > -- > > Key: ARIES-1573 > URL: https://issues.apache.org/jira/browse/ARIES-1573 > Project: Aries > Issue Type: Improvement > Components: Remote Service Admin >Reporter: Dmytro Pishchukhin >Assignee: Christian Schneider > > There is an idea to discover import services from CA configurations. > It's a separate module that registers ManagedServiceFactory and creates > EndpointDescription(s) from configuration. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1573) RSA discovery from ConfigAdmin
[ https://issues.apache.org/jira/browse/ARIES-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341501#comment-15341501 ] Dmytro Pishchukhin commented on ARIES-1573: --- OK. Will do it today. > RSA discovery from ConfigAdmin > -- > > Key: ARIES-1573 > URL: https://issues.apache.org/jira/browse/ARIES-1573 > Project: Aries > Issue Type: Improvement > Components: Remote Service Admin >Reporter: Dmytro Pishchukhin >Assignee: Christian Schneider > > There is an idea to discover import services from CA configurations. > It's a separate module that registers ManagedServiceFactory and creates > EndpointDescription(s) from configuration. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1573) RSA discovery from ConfigAdmin
[ https://issues.apache.org/jira/browse/ARIES-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341494#comment-15341494 ] Christian Schneider commented on ARIES-1573: Would be great and make sure you do the commits in the form [ARIES-1573] Your text. I propose to also squash the commits into one commit with message: [ARIES-1573] Configuration from properties You can also continually squash your commits into one on the branch and do a push -f. This is ok for a PR branch and makes it easier to apply and also looks good in the later log. > RSA discovery from ConfigAdmin > -- > > Key: ARIES-1573 > URL: https://issues.apache.org/jira/browse/ARIES-1573 > Project: Aries > Issue Type: Improvement > Components: Remote Service Admin >Reporter: Dmytro Pishchukhin >Assignee: Christian Schneider > > There is an idea to discover import services from CA configurations. > It's a separate module that registers ManagedServiceFactory and creates > EndpointDescription(s) from configuration. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1573) RSA discovery from ConfigAdmin
[ https://issues.apache.org/jira/browse/ARIES-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341488#comment-15341488 ] Dmytro Pishchukhin commented on ARIES-1573: --- Thank, Christian. If you want me to change to branch, I can do it w/o any problem. > RSA discovery from ConfigAdmin > -- > > Key: ARIES-1573 > URL: https://issues.apache.org/jira/browse/ARIES-1573 > Project: Aries > Issue Type: Improvement > Components: Remote Service Admin >Reporter: Dmytro Pishchukhin >Assignee: Christian Schneider > > There is an idea to discover import services from CA configurations. > It's a separate module that registers ManagedServiceFactory and creates > EndpointDescription(s) from configuration. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1573) RSA discovery from ConfigAdmin
[ https://issues.apache.org/jira/browse/ARIES-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341481#comment-15341481 ] Christian Schneider commented on ARIES-1573: Will look into your pull request now. Btw. Some hints about creating pull requests: 1. You should not do your changes on master. Create a branch named like the issue and do your changes there. Then create a pull request from this branch. This makes it easier to work on more than one PR 2. You can keep a pull request open if you have changes. Simply do the commit on the branch and the existing pull request will automatically update > RSA discovery from ConfigAdmin > -- > > Key: ARIES-1573 > URL: https://issues.apache.org/jira/browse/ARIES-1573 > Project: Aries > Issue Type: Improvement > Components: Remote Service Admin >Reporter: Dmytro Pishchukhin >Assignee: Christian Schneider > > There is an idea to discover import services from CA configurations. > It's a separate module that registers ManagedServiceFactory and creates > EndpointDescription(s) from configuration. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1573) RSA discovery from ConfigAdmin
[ https://issues.apache.org/jira/browse/ARIES-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15337590#comment-15337590 ] Dmytro Pishchukhin commented on ARIES-1573: --- a new pull request https://github.com/apache/aries-rsa/pull/5 is added. it contains implementation with tests, karaf feature and readme. p.s. tested with several projects already > RSA discovery from ConfigAdmin > -- > > Key: ARIES-1573 > URL: https://issues.apache.org/jira/browse/ARIES-1573 > Project: Aries > Issue Type: Improvement > Components: Remote Service Admin >Reporter: Dmytro Pishchukhin >Assignee: Christian Schneider > > There is an idea to discover import services from CA configurations. > It's a separate module that registers ManagedServiceFactory and creates > EndpointDescription(s) from configuration. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1573) RSA discovery from ConfigAdmin
[ https://issues.apache.org/jira/browse/ARIES-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331156#comment-15331156 ] Dmytro Pishchukhin commented on ARIES-1573: --- I added an initial pull request. If creates an EndpointDescription from config properties as is, without filtering and type validation. In the next pull request, I'll add filtering (filter ConfigAdmin specific properties), and type validation and transformation: e.g. for objectClass. > RSA discovery from ConfigAdmin > -- > > Key: ARIES-1573 > URL: https://issues.apache.org/jira/browse/ARIES-1573 > Project: Aries > Issue Type: Improvement > Components: Remote Service Admin >Reporter: Dmytro Pishchukhin >Assignee: Christian Schneider > > There is an idea to discover import services from CA configurations. > It's a separate module that registers ManagedServiceFactory and creates > EndpointDescription(s) from configuration. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1573) RSA discovery from ConfigAdmin
[ https://issues.apache.org/jira/browse/ARIES-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330052#comment-15330052 ] Dmytro Pishchukhin commented on ARIES-1573: --- I have an initial version of the module that tested with Karaf. How can I contribute it to the project? > RSA discovery from ConfigAdmin > -- > > Key: ARIES-1573 > URL: https://issues.apache.org/jira/browse/ARIES-1573 > Project: Aries > Issue Type: Improvement > Components: Remote Service Admin >Reporter: Dmytro Pishchukhin > > There is an idea to discover import services from CA configurations. > It's a separate module that registers ManagedServiceFactory and creates > EndpointDescription(s) from configuration. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
