[jira] [Commented] (ARIES-1792) blueprint-maven-plugin slows down compilation
[ https://issues.apache.org/jira/browse/ARIES-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456298#comment-16456298 ] Dominik Przybysz commented on ARIES-1792: - [~xroussel] Thank you too > blueprint-maven-plugin slows down compilation > - > > Key: ARIES-1792 > URL: https://issues.apache.org/jira/browse/ARIES-1792 > Project: Aries > Issue Type: Improvement >Affects Versions: blueprint-maven-plugin-1.9.0 >Reporter: Xavier Roussel >Priority: Major > > We have a maven project with 20+ modules all using BMP to generate blueprint > file. > During compilation, BMP is executed on each module and represents more than > 70% of the project's compilation time. > We specify a scanPath for each module as a parameter to BMP but it seems that > it scan the module and also all the dependencies so because the modules are > linked together, the whole project is scanned again and again for each module. > It could be useful to add an option to exclude dependencies so that BMP only > scan the current module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARIES-1792) blueprint-maven-plugin slows down compilation
[ https://issues.apache.org/jira/browse/ARIES-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456289#comment-16456289 ] ASF subversion and git services commented on ARIES-1792: Commit 1830338 from [~alien11689] in branch 'aries/trunk' [ https://svn.apache.org/r1830338 ] [ARIES-1792] Add exclude and include artifact filters for bean search > blueprint-maven-plugin slows down compilation > - > > Key: ARIES-1792 > URL: https://issues.apache.org/jira/browse/ARIES-1792 > Project: Aries > Issue Type: Improvement >Affects Versions: blueprint-maven-plugin-1.9.0 >Reporter: Xavier Roussel >Priority: Major > > We have a maven project with 20+ modules all using BMP to generate blueprint > file. > During compilation, BMP is executed on each module and represents more than > 70% of the project's compilation time. > We specify a scanPath for each module as a parameter to BMP but it seems that > it scan the module and also all the dependencies so because the modules are > linked together, the whole project is scanned again and again for each module. > It could be useful to add an option to exclude dependencies so that BMP only > scan the current module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARIES-1792) blueprint-maven-plugin slows down compilation
[ https://issues.apache.org/jira/browse/ARIES-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456086#comment-16456086 ] Xavier Roussel commented on ARIES-1792: --- It works like a charm (y) Thank you Dominik for your great work, you saved us a lot of time, 20s of compilation now instead of 2m40s ! > blueprint-maven-plugin slows down compilation > - > > Key: ARIES-1792 > URL: https://issues.apache.org/jira/browse/ARIES-1792 > Project: Aries > Issue Type: Improvement >Affects Versions: blueprint-maven-plugin-1.9.0 >Reporter: Xavier Roussel >Priority: Major > > We have a maven project with 20+ modules all using BMP to generate blueprint > file. > During compilation, BMP is executed on each module and represents more than > 70% of the project's compilation time. > We specify a scanPath for each module as a parameter to BMP but it seems that > it scan the module and also all the dependencies so because the modules are > linked together, the whole project is scanned again and again for each module. > It could be useful to add an option to exclude dependencies so that BMP only > scan the current module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARIES-1792) blueprint-maven-plugin slows down compilation
[ https://issues.apache.org/jira/browse/ARIES-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16450276#comment-16450276 ] Dominik Przybysz commented on ARIES-1792: - [~xroussel] I see your point. It should be correct now: https://github.com/alien11689/aries/tree/ARIES-1792_exclude > blueprint-maven-plugin slows down compilation > - > > Key: ARIES-1792 > URL: https://issues.apache.org/jira/browse/ARIES-1792 > Project: Aries > Issue Type: Improvement >Affects Versions: blueprint-maven-plugin-1.9.0 >Reporter: Xavier Roussel >Priority: Major > > We have a maven project with 20+ modules all using BMP to generate blueprint > file. > During compilation, BMP is executed on each module and represents more than > 70% of the project's compilation time. > We specify a scanPath for each module as a parameter to BMP but it seems that > it scan the module and also all the dependencies so because the modules are > linked together, the whole project is scanned again and again for each module. > It could be useful to add an option to exclude dependencies so that BMP only > scan the current module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARIES-1792) blueprint-maven-plugin slows down compilation
[ https://issues.apache.org/jira/browse/ARIES-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449616#comment-16449616 ] Xavier Roussel commented on ARIES-1792: --- I understand the ClassLoader needs to access the classes but the ClassFinder doesn't needs to scan all the artifacts for annotation, that's why you can ( and need ) to add all the artifacts to the ClassLoader but only filtered artifacts to the ClassFinder. It doesn't make sense to add the artifact to the include pattern because following this logic all the artifacts linked to my module are required by my module so I will have to add all of them to the includepattern and the filers will be useless ... More if I add the artifact(s) to the includepattern it will be scanned by the ClassFinder for annotations, which is exactly what consume time during compilation. Try out my branch, you will see that everything works fine like that. > blueprint-maven-plugin slows down compilation > - > > Key: ARIES-1792 > URL: https://issues.apache.org/jira/browse/ARIES-1792 > Project: Aries > Issue Type: Improvement >Affects Versions: blueprint-maven-plugin-1.9.0 >Reporter: Xavier Roussel >Priority: Major > > We have a maven project with 20+ modules all using BMP to generate blueprint > file. > During compilation, BMP is executed on each module and represents more than > 70% of the project's compilation time. > We specify a scanPath for each module as a parameter to BMP but it seems that > it scan the module and also all the dependencies so because the modules are > linked together, the whole project is scanned again and again for each module. > It could be useful to add an option to exclude dependencies so that BMP only > scan the current module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARIES-1792) blueprint-maven-plugin slows down compilation
[ https://issues.apache.org/jira/browse/ARIES-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449567#comment-16449567 ] Dominik Przybysz commented on ARIES-1792: - If you exclude an artifact which is needed then it cannot work. BMP still needs to get classes via reflection and if your classes use classes com/fasterxml/jackson/databind/Module then you cannot exclude the artifact. You just need to add artifact with class com/fasterxml/jackson/databind/Module to includeArtifacts patterns. I will merge my branch to trunk. > blueprint-maven-plugin slows down compilation > - > > Key: ARIES-1792 > URL: https://issues.apache.org/jira/browse/ARIES-1792 > Project: Aries > Issue Type: Improvement >Affects Versions: blueprint-maven-plugin-1.9.0 >Reporter: Xavier Roussel >Priority: Major > > We have a maven project with 20+ modules all using BMP to generate blueprint > file. > During compilation, BMP is executed on each module and represents more than > 70% of the project's compilation time. > We specify a scanPath for each module as a parameter to BMP but it seems that > it scan the module and also all the dependencies so because the modules are > linked together, the whole project is scanned again and again for each module. > It could be useful to add an option to exclude dependencies so that BMP only > scan the current module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARIES-1792) blueprint-maven-plugin slows down compilation
[ https://issues.apache.org/jira/browse/ARIES-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449553#comment-16449553 ] Xavier Roussel commented on ARIES-1792: --- I have the same error message as before when I try to include/exclude artifacts : *Execution default of goal org.apache.aries.blueprint:blueprint-maven-plugin:1.9.1-SNAPSHOT:blueprint-generate failed: A required class was missing while executing org.apache.aries.blueprint:blueprint-maven-plugin:1.9.1-SNAPSHOT:blueprint-generate: com/fasterxml/jackson/databind/Module* I think it's because the artifact's urls are not added to the ClassRealm. I tried to add ALL the artifact's urls to the ClassRealm and only filtered urls to the ClassFinder ( as in the branch [https://github.com/xroussel/aries/tree/ARIES-1792_exclude_2] ) and it works fine. Apart from that the exclude and include patterns seems to works fine ! > blueprint-maven-plugin slows down compilation > - > > Key: ARIES-1792 > URL: https://issues.apache.org/jira/browse/ARIES-1792 > Project: Aries > Issue Type: Improvement >Affects Versions: blueprint-maven-plugin-1.9.0 >Reporter: Xavier Roussel >Priority: Major > > We have a maven project with 20+ modules all using BMP to generate blueprint > file. > During compilation, BMP is executed on each module and represents more than > 70% of the project's compilation time. > We specify a scanPath for each module as a parameter to BMP but it seems that > it scan the module and also all the dependencies so because the modules are > linked together, the whole project is scanned again and again for each module. > It could be useful to add an option to exclude dependencies so that BMP only > scan the current module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARIES-1792) blueprint-maven-plugin slows down compilation
[ https://issues.apache.org/jira/browse/ARIES-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448856#comment-16448856 ] Dominik Przybysz commented on ARIES-1792: - I've implemented described solution on my own branch and it works ok. https://github.com/alien11689/aries/tree/ARIES-1792_exclude [~xroussel] Can you check it on your project? > blueprint-maven-plugin slows down compilation > - > > Key: ARIES-1792 > URL: https://issues.apache.org/jira/browse/ARIES-1792 > Project: Aries > Issue Type: Improvement >Affects Versions: blueprint-maven-plugin-1.9.0 >Reporter: Xavier Roussel >Priority: Major > > We have a maven project with 20+ modules all using BMP to generate blueprint > file. > During compilation, BMP is executed on each module and represents more than > 70% of the project's compilation time. > We specify a scanPath for each module as a parameter to BMP but it seems that > it scan the module and also all the dependencies so because the modules are > linked together, the whole project is scanned again and again for each module. > It could be useful to add an option to exclude dependencies so that BMP only > scan the current module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARIES-1792) blueprint-maven-plugin slows down compilation
[ https://issues.apache.org/jira/browse/ARIES-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443673#comment-16443673 ] Xavier Roussel commented on ARIES-1792: --- Yes I think it would be perfect like that > blueprint-maven-plugin slows down compilation > - > > Key: ARIES-1792 > URL: https://issues.apache.org/jira/browse/ARIES-1792 > Project: Aries > Issue Type: Improvement >Affects Versions: blueprint-maven-plugin-1.9.0 >Reporter: Xavier Roussel >Priority: Major > > We have a maven project with 20+ modules all using BMP to generate blueprint > file. > During compilation, BMP is executed on each module and represents more than > 70% of the project's compilation time. > We specify a scanPath for each module as a parameter to BMP but it seems that > it scan the module and also all the dependencies so because the modules are > linked together, the whole project is scanned again and again for each module. > It could be useful to add an option to exclude dependencies so that BMP only > scan the current module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARIES-1792) blueprint-maven-plugin slows down compilation
[ https://issues.apache.org/jira/browse/ARIES-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443138#comment-16443138 ] Dominik Przybysz commented on ARIES-1792: - Thanks [~xroussel] I think that we need two properties to make the solution fully configurable: 1) list of exclude patterns - by default exclude none 2) list of include patterns - by default include all If one of them is provided then it filter the artifact list. If both are provided than list of artifacts is filtered by include patterns and then filtered by exclude patterns. > blueprint-maven-plugin slows down compilation > - > > Key: ARIES-1792 > URL: https://issues.apache.org/jira/browse/ARIES-1792 > Project: Aries > Issue Type: Improvement >Affects Versions: blueprint-maven-plugin-1.9.0 >Reporter: Xavier Roussel >Priority: Major > > We have a maven project with 20+ modules all using BMP to generate blueprint > file. > During compilation, BMP is executed on each module and represents more than > 70% of the project's compilation time. > We specify a scanPath for each module as a parameter to BMP but it seems that > it scan the module and also all the dependencies so because the modules are > linked together, the whole project is scanned again and again for each module. > It could be useful to add an option to exclude dependencies so that BMP only > scan the current module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARIES-1792) blueprint-maven-plugin slows down compilation
[ https://issues.apache.org/jira/browse/ARIES-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440760#comment-16440760 ] Xavier Roussel commented on ARIES-1792: --- I modified the code to always include artifacts with the same group id and it work perfectly like this on my project . [DEBUG] Finding artifacts urls: 10ms [DEBUG] Create class loader: 0ms [DEBUG] Building class finder: 143ms [DEBUG] Creating package scope class finder: 153ms [DEBUG] Finding bean classes: 40ms [DEBUG] Creating blueprint model: 94ms The modification is on the same branch [https://github.com/xroussel/aries/tree/ARIES-1792_exclude_2] > blueprint-maven-plugin slows down compilation > - > > Key: ARIES-1792 > URL: https://issues.apache.org/jira/browse/ARIES-1792 > Project: Aries > Issue Type: Improvement >Affects Versions: blueprint-maven-plugin-1.9.0 >Reporter: Xavier Roussel >Priority: Major > > We have a maven project with 20+ modules all using BMP to generate blueprint > file. > During compilation, BMP is executed on each module and represents more than > 70% of the project's compilation time. > We specify a scanPath for each module as a parameter to BMP but it seems that > it scan the module and also all the dependencies so because the modules are > linked together, the whole project is scanned again and again for each module. > It could be useful to add an option to exclude dependencies so that BMP only > scan the current module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARIES-1792) blueprint-maven-plugin slows down compilation
[ https://issues.apache.org/jira/browse/ARIES-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440723#comment-16440723 ] Xavier Roussel commented on ARIES-1792: --- I tried the new version but the Classloader returned an error when I tried to exclude the dependencies and it still needs a few time to build. I did some tests and by using a ClassRealm and adding the URLs after construction it seems to work well and be very fast. I have to following results : [DEBUG] Finding artifacts urls: 6ms [DEBUG] Create class loader: 0ms [DEBUG] Building class finder: 34ms [DEBUG] Creating package scope class finder: 40ms [DEBUG] Finding bean classes: 46ms [DEBUG] Creating blueprint model: 108ms You can find the code here if it can help : [https://github.com/xroussel/aries/tree/ARIES-1792_exclude_2] The only problem left is that I need to specify the artifacts to exclude one by one and pay attention not to include a pattern matching a module required by blueprint which is very tricky and I don't know how to optimize that. Maybe an include pattern would be better than an exclude ? Or a combinaison of both ? > blueprint-maven-plugin slows down compilation > - > > Key: ARIES-1792 > URL: https://issues.apache.org/jira/browse/ARIES-1792 > Project: Aries > Issue Type: Improvement >Affects Versions: blueprint-maven-plugin-1.9.0 >Reporter: Xavier Roussel >Priority: Major > > We have a maven project with 20+ modules all using BMP to generate blueprint > file. > During compilation, BMP is executed on each module and represents more than > 70% of the project's compilation time. > We specify a scanPath for each module as a parameter to BMP but it seems that > it scan the module and also all the dependencies so because the modules are > linked together, the whole project is scanned again and again for each module. > It could be useful to add an option to exclude dependencies so that BMP only > scan the current module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARIES-1792) blueprint-maven-plugin slows down compilation
[
https://issues.apache.org/jira/browse/ARIES-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439799#comment-16439799
]
Dominik Przybysz commented on ARIES-1792:
-
[~xroussel] [~soundcrac...@gmail.com] I've found a project with huge amount of
dependencies and have started testing the plugin against it.
I've added the excludeArtifacts option to the plugin configuration.
{code:java}
.*(cats|cxf|jackson|jackrabbit|guava|spring|paranamer|commons|activemq|stax|geronimo|validation-api|jaxb|jetty).*
{code}
The exclude patterns are tested against an artifact name, e. g.:
{code:java}
org.apache.cxf:cxf-rt-frontend-jaxws:jar:3.0.2:provided{code}
The code is available on another branch here:
https://github.com/alien11689/aries/tree/ARIES-1792_exclude
Can you check it?
> blueprint-maven-plugin slows down compilation
> -
>
> Key: ARIES-1792
> URL: https://issues.apache.org/jira/browse/ARIES-1792
> Project: Aries
> Issue Type: Improvement
>Affects Versions: blueprint-maven-plugin-1.9.0
>Reporter: Xavier Roussel
>Priority: Major
>
> We have a maven project with 20+ modules all using BMP to generate blueprint
> file.
> During compilation, BMP is executed on each module and represents more than
> 70% of the project's compilation time.
> We specify a scanPath for each module as a parameter to BMP but it seems that
> it scan the module and also all the dependencies so because the modules are
> linked together, the whole project is scanned again and again for each module.
> It could be useful to add an option to exclude dependencies so that BMP only
> scan the current module.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARIES-1792) blueprint-maven-plugin slows down compilation
[ https://issues.apache.org/jira/browse/ARIES-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439434#comment-16439434 ] Daniel Estermann commented on ARIES-1792: - I can confirm - xbean-finder-shaded:4.7 doesn't improve the build time > blueprint-maven-plugin slows down compilation > - > > Key: ARIES-1792 > URL: https://issues.apache.org/jira/browse/ARIES-1792 > Project: Aries > Issue Type: Improvement >Affects Versions: blueprint-maven-plugin-1.9.0 >Reporter: Xavier Roussel >Priority: Major > > We have a maven project with 20+ modules all using BMP to generate blueprint > file. > During compilation, BMP is executed on each module and represents more than > 70% of the project's compilation time. > We specify a scanPath for each module as a parameter to BMP but it seems that > it scan the module and also all the dependencies so because the modules are > linked together, the whole project is scanned again and again for each module. > It could be useful to add an option to exclude dependencies so that BMP only > scan the current module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARIES-1792) blueprint-maven-plugin slows down compilation
[ https://issues.apache.org/jira/browse/ARIES-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439419#comment-16439419 ] Xavier Roussel commented on ARIES-1792: --- I tried to upgrade the xbean-finder-shaded plugin dependency to 4.7 but it didn't fix the problem [DEBUG] Creating package scope class finder: 13400ms [DEBUG] Finding bean classes: 46ms [DEBUG] Creating blueprint model: 85ms [DEBUG] Writing blueprint: 71ms > blueprint-maven-plugin slows down compilation > - > > Key: ARIES-1792 > URL: https://issues.apache.org/jira/browse/ARIES-1792 > Project: Aries > Issue Type: Improvement >Affects Versions: blueprint-maven-plugin-1.9.0 >Reporter: Xavier Roussel >Priority: Major > > We have a maven project with 20+ modules all using BMP to generate blueprint > file. > During compilation, BMP is executed on each module and represents more than > 70% of the project's compilation time. > We specify a scanPath for each module as a parameter to BMP but it seems that > it scan the module and also all the dependencies so because the modules are > linked together, the whole project is scanned again and again for each module. > It could be useful to add an option to exclude dependencies so that BMP only > scan the current module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARIES-1792) blueprint-maven-plugin slows down compilation
[ https://issues.apache.org/jira/browse/ARIES-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439391#comment-16439391 ] Dominik Przybysz commented on ARIES-1792: - [~xroussel] Can you check your project with newer xbean-finder-shaded? [https://mvnrepository.com/artifact/org.apache.xbean/xbean-finder-shaded/4.]7 > blueprint-maven-plugin slows down compilation > - > > Key: ARIES-1792 > URL: https://issues.apache.org/jira/browse/ARIES-1792 > Project: Aries > Issue Type: Improvement >Affects Versions: blueprint-maven-plugin-1.9.0 >Reporter: Xavier Roussel >Priority: Major > > We have a maven project with 20+ modules all using BMP to generate blueprint > file. > During compilation, BMP is executed on each module and represents more than > 70% of the project's compilation time. > We specify a scanPath for each module as a parameter to BMP but it seems that > it scan the module and also all the dependencies so because the modules are > linked together, the whole project is scanned again and again for each module. > It could be useful to add an option to exclude dependencies so that BMP only > scan the current module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARIES-1792) blueprint-maven-plugin slows down compilation
[ https://issues.apache.org/jira/browse/ARIES-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439197#comment-16439197 ] Xavier Roussel commented on ARIES-1792: --- I also tried the optimization and the problem is still here, the plugin still needs more than 10 sec ( same as before ) for one module. Here are the logs for one module, it's the same most of the others: [DEBUG] Creating package scope class finder: 12286ms [DEBUG] Finding bean classes: 30ms [DEBUG] Creating blueprint model: 68ms [DEBUG] Writing blueprint: 52ms I added a few more debug and It seems that all the time is consumed by the fonction which scan the classes when the classloader is created ( readClassDef in org.apache.xbean.finder.AbstractFinder ). Which is normal I think because it reference all the project dependency, even camel,osgi,jetty,spring etc ... [DEBUG] Adding urls ( ClassFinder constructor ) : 2304ms [DEBUG] ReadClassDef ( ClassFinder constructor ) : 10131ms [DEBUG] Creating PackageScopeClassFinder: 12438ms [DEBUG] Finding bean classes: 37ms [DEBUG] Creating blueprint model: 72ms [DEBUG] Writing blueprint: 85ms > blueprint-maven-plugin slows down compilation > - > > Key: ARIES-1792 > URL: https://issues.apache.org/jira/browse/ARIES-1792 > Project: Aries > Issue Type: Improvement >Affects Versions: blueprint-maven-plugin-1.9.0 >Reporter: Xavier Roussel >Priority: Major > > We have a maven project with 20+ modules all using BMP to generate blueprint > file. > During compilation, BMP is executed on each module and represents more than > 70% of the project's compilation time. > We specify a scanPath for each module as a parameter to BMP but it seems that > it scan the module and also all the dependencies so because the modules are > linked together, the whole project is scanned again and again for each module. > It could be useful to add an option to exclude dependencies so that BMP only > scan the current module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARIES-1792) blueprint-maven-plugin slows down compilation
[ https://issues.apache.org/jira/browse/ARIES-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439178#comment-16439178 ] Daniel Estermann commented on ARIES-1792: - The fix didn't work for me unfortunately. Here is the log: https://paste.fedoraproject.org/paste/iBmXy-C65Nj5I2-ehhcfMA > blueprint-maven-plugin slows down compilation > - > > Key: ARIES-1792 > URL: https://issues.apache.org/jira/browse/ARIES-1792 > Project: Aries > Issue Type: Improvement >Affects Versions: blueprint-maven-plugin-1.9.0 >Reporter: Xavier Roussel >Priority: Major > > We have a maven project with 20+ modules all using BMP to generate blueprint > file. > During compilation, BMP is executed on each module and represents more than > 70% of the project's compilation time. > We specify a scanPath for each module as a parameter to BMP but it seems that > it scan the module and also all the dependencies so because the modules are > linked together, the whole project is scanned again and again for each module. > It could be useful to add an option to exclude dependencies so that BMP only > scan the current module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARIES-1792) blueprint-maven-plugin slows down compilation
[ https://issues.apache.org/jira/browse/ARIES-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439039#comment-16439039 ] Xavier Roussel commented on ARIES-1792: --- Hello Dominik and thanks for your work ! I don't know exactly which dependencies BMP scan and which ones are the more time consuming but by looking at the code it seems that BMP scan all the module and all the artifacts referenced in the module. Currently we have an api/spi module but because of some specific Implementation we still have dependencies between the modules but I will check if I can optimize that. I will try your optimization today and provide you the logs. > blueprint-maven-plugin slows down compilation > - > > Key: ARIES-1792 > URL: https://issues.apache.org/jira/browse/ARIES-1792 > Project: Aries > Issue Type: Improvement >Affects Versions: blueprint-maven-plugin-1.9.0 >Reporter: Xavier Roussel >Priority: Major > > We have a maven project with 20+ modules all using BMP to generate blueprint > file. > During compilation, BMP is executed on each module and represents more than > 70% of the project's compilation time. > We specify a scanPath for each module as a parameter to BMP but it seems that > it scan the module and also all the dependencies so because the modules are > linked together, the whole project is scanned again and again for each module. > It could be useful to add an option to exclude dependencies so that BMP only > scan the current module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARIES-1792) blueprint-maven-plugin slows down compilation
[ https://issues.apache.org/jira/browse/ARIES-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437653#comment-16437653 ] Dominik Przybysz commented on ARIES-1792: - Yes, a kind of. The diffrence lies in the level - we cannot filter out dependencies, but can filter the classes. > blueprint-maven-plugin slows down compilation > - > > Key: ARIES-1792 > URL: https://issues.apache.org/jira/browse/ARIES-1792 > Project: Aries > Issue Type: Improvement >Affects Versions: blueprint-maven-plugin-1.9.0 >Reporter: Xavier Roussel >Priority: Major > > We have a maven project with 20+ modules all using BMP to generate blueprint > file. > During compilation, BMP is executed on each module and represents more than > 70% of the project's compilation time. > We specify a scanPath for each module as a parameter to BMP but it seems that > it scan the module and also all the dependencies so because the modules are > linked together, the whole project is scanned again and again for each module. > It could be useful to add an option to exclude dependencies so that BMP only > scan the current module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARIES-1792) blueprint-maven-plugin slows down compilation
[ https://issues.apache.org/jira/browse/ARIES-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437605#comment-16437605 ] Daniel Estermann commented on ARIES-1792: - [~alien11689] I will test your optimization on monday, when I'm back in my office. This looks like a kind of an optimization, which I asked for in ARIES-1772 > blueprint-maven-plugin slows down compilation > - > > Key: ARIES-1792 > URL: https://issues.apache.org/jira/browse/ARIES-1792 > Project: Aries > Issue Type: Improvement >Affects Versions: blueprint-maven-plugin-1.9.0 >Reporter: Xavier Roussel >Priority: Major > > We have a maven project with 20+ modules all using BMP to generate blueprint > file. > During compilation, BMP is executed on each module and represents more than > 70% of the project's compilation time. > We specify a scanPath for each module as a parameter to BMP but it seems that > it scan the module and also all the dependencies so because the modules are > linked together, the whole project is scanned again and again for each module. > It could be useful to add an option to exclude dependencies so that BMP only > scan the current module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARIES-1792) blueprint-maven-plugin slows down compilation
[ https://issues.apache.org/jira/browse/ARIES-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437572#comment-16437572 ] Dominik Przybysz commented on ARIES-1792: - [~xroussel] I have added an optimization on my github fork [https://github.com/alien11689/aries/tree/ARIES-1792] Can you use run it with your project? I have also added there some debug logs to measure which part of plugin execution is the longest. Can you provide also the logs? I would like to know how your modules are connected. Your 20+ bundles are all bundles with implementation and the maven dependencies are between impls? If so, then I would suggest, that you can create some bundles with only api/spi and depend on them in your bundles. It works great in our project at work - we haven't spotted any significant slow downs caused by BMP. > blueprint-maven-plugin slows down compilation > - > > Key: ARIES-1792 > URL: https://issues.apache.org/jira/browse/ARIES-1792 > Project: Aries > Issue Type: Improvement >Affects Versions: blueprint-maven-plugin-1.9.0 >Reporter: Xavier Roussel >Priority: Major > > We have a maven project with 20+ modules all using BMP to generate blueprint > file. > During compilation, BMP is executed on each module and represents more than > 70% of the project's compilation time. > We specify a scanPath for each module as a parameter to BMP but it seems that > it scan the module and also all the dependencies so because the modules are > linked together, the whole project is scanned again and again for each module. > It could be useful to add an option to exclude dependencies so that BMP only > scan the current module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARIES-1792) blueprint-maven-plugin slows down compilation
[ https://issues.apache.org/jira/browse/ARIES-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437427#comment-16437427 ] Dominik Przybysz commented on ARIES-1792: - [~xroussel] If I understand you correctly, BMP scans all the dependencies on the classpath, not only your own modules which are on the classpath? [~soundcrac...@gmail.com] The build fails because provided dependencies do not comes to the build with their's transitive dependencies and you receive ClassNotFound. > blueprint-maven-plugin slows down compilation > - > > Key: ARIES-1792 > URL: https://issues.apache.org/jira/browse/ARIES-1792 > Project: Aries > Issue Type: Improvement >Affects Versions: blueprint-maven-plugin-1.9.0 >Reporter: Xavier Roussel >Priority: Major > > We have a maven project with 20+ modules all using BMP to generate blueprint > file. > During compilation, BMP is executed on each module and represents more than > 70% of the project's compilation time. > We specify a scanPath for each module as a parameter to BMP but it seems that > it scan the module and also all the dependencies so because the modules are > linked together, the whole project is scanned again and again for each module. > It could be useful to add an option to exclude dependencies so that BMP only > scan the current module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARIES-1792) blueprint-maven-plugin slows down compilation
[ https://issues.apache.org/jira/browse/ARIES-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437311#comment-16437311 ] Daniel Estermann commented on ARIES-1792: - Please see the linked issue opened by me. In my projects this plugin not only consumes the compile time (I even didn't mention it), it also makes my builds fail. > blueprint-maven-plugin slows down compilation > - > > Key: ARIES-1792 > URL: https://issues.apache.org/jira/browse/ARIES-1792 > Project: Aries > Issue Type: Improvement >Affects Versions: blueprint-maven-plugin-1.9.0 >Reporter: Xavier Roussel >Priority: Major > > We have a maven project with 20+ modules all using BMP to generate blueprint > file. > During compilation, BMP is executed on each module and represents more than > 70% of the project's compilation time. > We specify a scanPath for each module as a parameter to BMP but it seems that > it scan the module and also all the dependencies so because the modules are > linked together, the whole project is scanned again and again for each module. > It could be useful to add an option to exclude dependencies so that BMP only > scan the current module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
