[jira] [Commented] (ARIES-1866) URI binding conflict resolution appears incorrect in jaxrs-whiteboard
[
https://issues.apache.org/jira/browse/ARIES-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709753#comment-16709753
]
ASF subversion and git services commented on ARIES-1866:
Commit 03ef7192ee840b8d82c88509de888a701c8d7e94 in aries-jax-rs-whiteboard's
branch refs/heads/master from [~csierra]
[ https://gitbox.apache.org/repos/asf?p=aries-jax-rs-whiteboard.git;h=03ef719 ]
[ARIES-1866] Delegate to JAX-RS ordering
when both service.rankings are missing or equal
> URI binding conflict resolution appears incorrect in jaxrs-whiteboard
> -
>
> Key: ARIES-1866
> URL: https://issues.apache.org/jira/browse/ARIES-1866
> Project: Aries
> Issue Type: Bug
> Components: jax-rs-whiteboard
> Environment: I'm using jax-rs whiteboard 1.0.1 on Windows, within
> apache karaf.
>
>Reporter: Tom Quarendon
>Assignee: Carlos Sierra
>Priority: Major
> Attachments: TestResource.java, TestResource2.java
>
>
> I'm seeing different behaviour in the URI resource binding conflict
> resolution when using tje jax-rs whiteboard as then using "plain" cxf.
> Attached are two resource class implementations. One has a class level @Path
> of "test", with then a subresource locator with an @Path of "\{a}" returning
> another resource class that has a @GET with an @Path of "\{b}".
> The other resource class has a class level @Path of "test/a/b".
> Given a GET request for "/test/a/b" it should match the second of these
> resource classes as being the most specific match. Instead it matches the
> first. Indeed it seems that the presence of the first resource class stops
> anything going to the second. If I change the @Path for the second resource
> class to be "test2/a/b" then appropriate requests get routed there.
> I have run a "plain" cxf test by adapting the CXF provided "basic" jax-rs
> test with the same resource classes, and it routes as I would expect.
> I had intended to try and adapt the example in the aries jaxrs whiteboard
> project, but I get test errors when I run an "mvn install",and it isn't
> obvious to me how the jax-rs._example_-run/_example_.jar file mentioned in
> the readme would get created.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARIES-1866) URI binding conflict resolution appears incorrect in jaxrs-whiteboard
[
https://issues.apache.org/jira/browse/ARIES-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703016#comment-16703016
]
Timothy Ward commented on ARIES-1866:
-
We've had confirmation from the OSGi EEG that this fix matches the intent of
the spec, and that an erratum will be issued to clarify that this is what
should be done by the implementation.
> URI binding conflict resolution appears incorrect in jaxrs-whiteboard
> -
>
> Key: ARIES-1866
> URL: https://issues.apache.org/jira/browse/ARIES-1866
> Project: Aries
> Issue Type: Bug
> Components: jax-rs-whiteboard
> Environment: I'm using jax-rs whiteboard 1.0.1 on Windows, within
> apache karaf.
>
>Reporter: Tom Quarendon
>Assignee: Carlos Sierra
>Priority: Major
> Attachments: TestResource.java, TestResource2.java
>
>
> I'm seeing different behaviour in the URI resource binding conflict
> resolution when using tje jax-rs whiteboard as then using "plain" cxf.
> Attached are two resource class implementations. One has a class level @Path
> of "test", with then a subresource locator with an @Path of "\{a}" returning
> another resource class that has a @GET with an @Path of "\{b}".
> The other resource class has a class level @Path of "test/a/b".
> Given a GET request for "/test/a/b" it should match the second of these
> resource classes as being the most specific match. Instead it matches the
> first. Indeed it seems that the presence of the first resource class stops
> anything going to the second. If I change the @Path for the second resource
> class to be "test2/a/b" then appropriate requests get routed there.
> I have run a "plain" cxf test by adapting the CXF provided "basic" jax-rs
> test with the same resource classes, and it routes as I would expect.
> I had intended to try and adapt the example in the aries jaxrs whiteboard
> project, but I get test errors when I run an "mvn install",and it isn't
> obvious to me how the jax-rs._example_-run/_example_.jar file mentioned in
> the readme would get created.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARIES-1866) URI binding conflict resolution appears incorrect in jaxrs-whiteboard
[
https://issues.apache.org/jira/browse/ARIES-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699451#comment-16699451
]
Tom Quarendon commented on ARIES-1866:
--
[~csierra] Yes, this fix seems to work, and my endpoints now get matches as I
expect.
Thanks again for the fix. Happy for this to be closed.
> URI binding conflict resolution appears incorrect in jaxrs-whiteboard
> -
>
> Key: ARIES-1866
> URL: https://issues.apache.org/jira/browse/ARIES-1866
> Project: Aries
> Issue Type: Bug
> Components: jax-rs-whiteboard
> Environment: I'm using jax-rs whiteboard 1.0.1 on Windows, within
> apache karaf.
>
>Reporter: Tom Quarendon
>Assignee: Carlos Sierra
>Priority: Major
> Attachments: TestResource.java, TestResource2.java
>
>
> I'm seeing different behaviour in the URI resource binding conflict
> resolution when using tje jax-rs whiteboard as then using "plain" cxf.
> Attached are two resource class implementations. One has a class level @Path
> of "test", with then a subresource locator with an @Path of "\{a}" returning
> another resource class that has a @GET with an @Path of "\{b}".
> The other resource class has a class level @Path of "test/a/b".
> Given a GET request for "/test/a/b" it should match the second of these
> resource classes as being the most specific match. Instead it matches the
> first. Indeed it seems that the presence of the first resource class stops
> anything going to the second. If I change the @Path for the second resource
> class to be "test2/a/b" then appropriate requests get routed there.
> I have run a "plain" cxf test by adapting the CXF provided "basic" jax-rs
> test with the same resource classes, and it routes as I would expect.
> I had intended to try and adapt the example in the aries jaxrs whiteboard
> project, but I get test errors when I run an "mvn install",and it isn't
> obvious to me how the jax-rs._example_-run/_example_.jar file mentioned in
> the readme would get created.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARIES-1866) URI binding conflict resolution appears incorrect in jaxrs-whiteboard
[
https://issues.apache.org/jira/browse/ARIES-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699346#comment-16699346
]
Timothy Ward commented on ARIES-1866:
-
{quote}BTW, what kind of release timetable would there be to getting a
non-snapshot release with this in?
{quote}
We were planning one this week, but will now spend a little more time trying to
iron out the recently identified bugs. Assuming nothing catastrophic emerges I
would expect to see a release in Maven Central before the end of the year,
hopefully in the next couple of weeks.
> URI binding conflict resolution appears incorrect in jaxrs-whiteboard
> -
>
> Key: ARIES-1866
> URL: https://issues.apache.org/jira/browse/ARIES-1866
> Project: Aries
> Issue Type: Bug
> Components: jax-rs-whiteboard
> Environment: I'm using jax-rs whiteboard 1.0.1 on Windows, within
> apache karaf.
>
>Reporter: Tom Quarendon
>Assignee: Carlos Sierra
>Priority: Major
> Attachments: TestResource.java, TestResource2.java
>
>
> I'm seeing different behaviour in the URI resource binding conflict
> resolution when using tje jax-rs whiteboard as then using "plain" cxf.
> Attached are two resource class implementations. One has a class level @Path
> of "test", with then a subresource locator with an @Path of "\{a}" returning
> another resource class that has a @GET with an @Path of "\{b}".
> The other resource class has a class level @Path of "test/a/b".
> Given a GET request for "/test/a/b" it should match the second of these
> resource classes as being the most specific match. Instead it matches the
> first. Indeed it seems that the presence of the first resource class stops
> anything going to the second. If I change the @Path for the second resource
> class to be "test2/a/b" then appropriate requests get routed there.
> I have run a "plain" cxf test by adapting the CXF provided "basic" jax-rs
> test with the same resource classes, and it routes as I would expect.
> I had intended to try and adapt the example in the aries jaxrs whiteboard
> project, but I get test errors when I run an "mvn install",and it isn't
> obvious to me how the jax-rs._example_-run/_example_.jar file mentioned in
> the readme would get created.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARIES-1866) URI binding conflict resolution appears incorrect in jaxrs-whiteboard
[
https://issues.apache.org/jira/browse/ARIES-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699240#comment-16699240
]
Carlos Sierra commented on ARIES-1866:
--
hey [~tomq42],
it looks like the whiteboard specification is a bit broad to this regard and
the expected behaviour in this case it is not very well defined.
I have pushed a proposed fix in which resource services that do not specify
{{service.ranking}} are considered equal and, thus, not ordered among
themselves so JAX-RS rules should apply.
Before this fix the default {{ServiceReference}} order was applied, so service
resource NEVER clashed because the {{ServiceReference}} ordering was applied.
We have also filed a proposal to ammend the spec and narrow down this expected
behavior.
I have incorporated your tests to the JAX-RS test suite.
I have also released a new snapshot containing this fix. Could you please check
this works for you?
Bests.
Carlos.
> URI binding conflict resolution appears incorrect in jaxrs-whiteboard
> -
>
> Key: ARIES-1866
> URL: https://issues.apache.org/jira/browse/ARIES-1866
> Project: Aries
> Issue Type: Bug
> Components: jax-rs-whiteboard
> Environment: I'm using jax-rs whiteboard 1.0.1 on Windows, within
> apache karaf.
>
>Reporter: Tom Quarendon
>Assignee: Carlos Sierra
>Priority: Major
> Attachments: TestResource.java, TestResource2.java
>
>
> I'm seeing different behaviour in the URI resource binding conflict
> resolution when using tje jax-rs whiteboard as then using "plain" cxf.
> Attached are two resource class implementations. One has a class level @Path
> of "test", with then a subresource locator with an @Path of "\{a}" returning
> another resource class that has a @GET with an @Path of "\{b}".
> The other resource class has a class level @Path of "test/a/b".
> Given a GET request for "/test/a/b" it should match the second of these
> resource classes as being the most specific match. Instead it matches the
> first. Indeed it seems that the presence of the first resource class stops
> anything going to the second. If I change the @Path for the second resource
> class to be "test2/a/b" then appropriate requests get routed there.
> I have run a "plain" cxf test by adapting the CXF provided "basic" jax-rs
> test with the same resource classes, and it routes as I would expect.
> I had intended to try and adapt the example in the aries jaxrs whiteboard
> project, but I get test errors when I run an "mvn install",and it isn't
> obvious to me how the jax-rs._example_-run/_example_.jar file mentioned in
> the readme would get created.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARIES-1866) URI binding conflict resolution appears incorrect in jaxrs-whiteboard
[
https://issues.apache.org/jira/browse/ARIES-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699182#comment-16699182
]
ASF subversion and git services commented on ARIES-1866:
Commit 21ab76135c3a031ec19cdc59e5829bf72264bfb5 in aries-jax-rs-whiteboard's
branch refs/heads/master from [~csierra]
[ https://gitbox.apache.org/repos/asf?p=aries-jax-rs-whiteboard.git;h=21ab761 ]
[ARIES-1866] Add comparator opt-in comparator
only kicks in if the service references specify a `service.ranking` property,
otherwise let JAX-RS resolve the conflict.
> URI binding conflict resolution appears incorrect in jaxrs-whiteboard
> -
>
> Key: ARIES-1866
> URL: https://issues.apache.org/jira/browse/ARIES-1866
> Project: Aries
> Issue Type: Bug
> Components: jax-rs-whiteboard
> Environment: I'm using jax-rs whiteboard 1.0.1 on Windows, within
> apache karaf.
>
>Reporter: Tom Quarendon
>Assignee: Carlos Sierra
>Priority: Major
> Attachments: TestResource.java, TestResource2.java
>
>
> I'm seeing different behaviour in the URI resource binding conflict
> resolution when using tje jax-rs whiteboard as then using "plain" cxf.
> Attached are two resource class implementations. One has a class level @Path
> of "test", with then a subresource locator with an @Path of "\{a}" returning
> another resource class that has a @GET with an @Path of "\{b}".
> The other resource class has a class level @Path of "test/a/b".
> Given a GET request for "/test/a/b" it should match the second of these
> resource classes as being the most specific match. Instead it matches the
> first. Indeed it seems that the presence of the first resource class stops
> anything going to the second. If I change the @Path for the second resource
> class to be "test2/a/b" then appropriate requests get routed there.
> I have run a "plain" cxf test by adapting the CXF provided "basic" jax-rs
> test with the same resource classes, and it routes as I would expect.
> I had intended to try and adapt the example in the aries jaxrs whiteboard
> project, but I get test errors when I run an "mvn install",and it isn't
> obvious to me how the jax-rs._example_-run/_example_.jar file mentioned in
> the readme would get created.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARIES-1866) URI binding conflict resolution appears incorrect in jaxrs-whiteboard
[
https://issues.apache.org/jira/browse/ARIES-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699181#comment-16699181
]
ASF subversion and git services commented on ARIES-1866:
Commit 71d88fe0153b3659f67bd8f558078421cf134dd9 in aries-jax-rs-whiteboard's
branch refs/heads/master from [~csierra]
[ https://gitbox.apache.org/repos/asf?p=aries-jax-rs-whiteboard.git;h=71d88fe ]
[ARIES-1866] Add tests showing tie problem
> URI binding conflict resolution appears incorrect in jaxrs-whiteboard
> -
>
> Key: ARIES-1866
> URL: https://issues.apache.org/jira/browse/ARIES-1866
> Project: Aries
> Issue Type: Bug
> Components: jax-rs-whiteboard
> Environment: I'm using jax-rs whiteboard 1.0.1 on Windows, within
> apache karaf.
>
>Reporter: Tom Quarendon
>Assignee: Carlos Sierra
>Priority: Major
> Attachments: TestResource.java, TestResource2.java
>
>
> I'm seeing different behaviour in the URI resource binding conflict
> resolution when using tje jax-rs whiteboard as then using "plain" cxf.
> Attached are two resource class implementations. One has a class level @Path
> of "test", with then a subresource locator with an @Path of "\{a}" returning
> another resource class that has a @GET with an @Path of "\{b}".
> The other resource class has a class level @Path of "test/a/b".
> Given a GET request for "/test/a/b" it should match the second of these
> resource classes as being the most specific match. Instead it matches the
> first. Indeed it seems that the presence of the first resource class stops
> anything going to the second. If I change the @Path for the second resource
> class to be "test2/a/b" then appropriate requests get routed there.
> I have run a "plain" cxf test by adapting the CXF provided "basic" jax-rs
> test with the same resource classes, and it routes as I would expect.
> I had intended to try and adapt the example in the aries jaxrs whiteboard
> project, but I get test errors when I run an "mvn install",and it isn't
> obvious to me how the jax-rs._example_-run/_example_.jar file mentioned in
> the readme would get created.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
