Re: char types in c and ipc in java
hi Nicki Micah's patch for #1 is in progress here https://github.com/apache/arrow/pull/85 I believe Steven Phillips is working on a patch toward reconciling the Java implementation with the current working version of the spec. We need to be able to verify that memory can be passed between Java and C++ with full fidelity (using files / memory maps as the exchange medium to start); these integration tests will help enable other Arrow implementations validate their compatibility as well. It would be great to have some additional help here cheers Wes On Thu, Jun 2, 2016 at 7:10 AM, Nicole Nemerwrote: > Good Morning Micah, > How is 1 please? anything that I can do to help? > > Anyone with more insight on 2 please? > > Thanks, > nicki > ‹ > Nicole Nemer, PhD > Technical Architect/Dev Manager > > 303-641-3340 > > > > > > > On 5/27/16, 9:51 AM, "Micah Kornfield" wrote: > >>Hi Nicki, >>1. I'm currently working on the char/string support for C++. I've >>been a little bit backlogged on it. If I don't make substantial >>progress this weekend, I'm happy to relinquish the task. >> >>2. I'll let someone more knowledgable about the java implementation >>chime in, but I think the answer is a qualified yes. We were just >>talking about trying to make the first integration test that proves >>C++/Java compatibility [1] >> >>3. Yes it is easy to become a contributor. The general workflow is >>to chime in on jira item [2] (or someone on the PMC? can make you a >>contributor so you can assign a ticket to yourself), and submit a pull >>request via github with "ARROW-:" as the start of the >>pull request title. In addition to the items mentioned below there is >>a pretty substantial backlog of items to work on if you are interested >>in contributing generally. >> >>Thanks, >>Micah >> >>[1] >>http://mail-archives.apache.org/mod_mbox/arrow-dev/201605.mbox/%3CCAK7Z5T8 >>X2OiWfSoQ0S-3vu0D4zgkuAO-SD_Q%3DF2Pu%3D4GhaTFbQ%40mail.gmail.com%3E >>[2] >>https://issues.apache.org/jira/browse/ARROW/?selectedTab=com.atlassian.jir >>a.jira-projects-plugin:issues-panel >> >> >> >>On Fri, May 27, 2016 at 7:35 AM, Nicole Nemer >>wrote: >>> >>> 1. does cpp/ipc support char/string types? If not - when please? >>> 2. Is there a java implementation of the ipc feature please? If not >>>- when please? >>> 3. Is it easy to join and help as a contributor? I would love to >>>help with these 2 items if they are planned for the near future. >>> >>> Thanks, >>> Nicki >>> - >>> Nicole Nemer, PhD >>> Technical Architect/Dev Manager >>> >>> >>> >
Re: [JAVA] Figuring out whats shifted from Drill/Java
Hi Steven, Is the patch focused on the alignment/padding. Or are there other issues as well? Thanks, Micah On Tue, Jun 7, 2016 at 11:22 PM, Steven Phillipswrote: > I am currently working on a patch that addresses this, as well as removing > some of the residual code from Drill that isn't really needed in Arrow, > (such as the Drill types, MaterializedField, etc.) > > I will be posting this within a few days. > > On Tue, Jun 7, 2016 at 5:54 PM, Leif Walsh wrote: > >> I am also interested in this. >> On Tue, Jun 7, 2016 at 17:37 Holden Karau wrote: >> >> > Hi Everyone, >> > >> > I'm looking to help get started with Arrow & Spark and to that end I'd >> like >> > to start with getting the Java implementation closer to the spec / C >> > implementation. I'm wondering what places people know the differences are >> > between the two? >> > >> > Cheers, >> > >> > Holden :) >> > >> -- >> -- >> Cheers, >> Leif >>
[jira] [Resolved] (ARROW-212) [C++] Clarify the fact that PrimitiveArray is now abstract class
[ https://issues.apache.org/jira/browse/ARROW-212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wes McKinney resolved ARROW-212. Resolution: Fixed Issue resolved by pull request 87 [https://github.com/apache/arrow/pull/87] > [C++] Clarify the fact that PrimitiveArray is now abstract class > - > > Key: ARROW-212 > URL: https://issues.apache.org/jira/browse/ARROW-212 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Reporter: Micah Kornfield >Assignee: Micah Kornfield >Priority: Minor > > Follow up from ARROW-206 based on [~xhochy] feedback. > Make the constructor protected and point to the approriate method in > construct.h -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (ARROW-200) [Python] Convert Values String looks like it has incorrect error handling
[ https://issues.apache.org/jira/browse/ARROW-200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wes McKinney resolved ARROW-200. Resolution: Fixed Issue resolved by pull request 88 [https://github.com/apache/arrow/pull/88] > [Python] Convert Values String looks like it has incorrect error handling > - > > Key: ARROW-200 > URL: https://issues.apache.org/jira/browse/ARROW-200 > Project: Apache Arrow > Issue Type: Bug > Components: Python >Reporter: Micah Kornfield >Assignee: Micah Kornfield > > In pyarrow/adapters/pandas.cc: > There looks like there are at least a couple of instances of code of this sort > `693 out_values[i] = make_pystring(data, length); > 694 if (out_values[i] == nullptr) { > 695 return Status::OK(); > 696 }` > I believe this should be returning an error status. [~wesmckinn]? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARROW-213) Exposing static arrow build
[ https://issues.apache.org/jira/browse/ARROW-213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320146#comment-15320146 ] Uwe L. Korn commented on ARROW-213: --- Already had a lock at that but I realised that parquet-cpp is not delivering correct static builds (i.e. we build 4 shared libraries but only install one). I'll try to get that fixed in parquet-cpp before any work on arrow is done as we then would have a working template. > Exposing static arrow build > --- > > Key: ARROW-213 > URL: https://issues.apache.org/jira/browse/ARROW-213 > Project: Apache Arrow > Issue Type: Improvement >Reporter: Philipp Moritz >Assignee: Philipp Moritz > Original Estimate: 10m > Remaining Estimate: 10m > > I'd like to be able to link arrow statically into my application. > At the moment, arrow can be built as a static library using the > 'LIBARROW_LINKAGE' variable in CMakeLists.txt. I'd like to configure this > behavior from the command line. Are there any objections of exposing the > variable as a cached variable? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [JAVA] Figuring out whats shifted from Drill/Java
I am currently working on a patch that addresses this, as well as removing some of the residual code from Drill that isn't really needed in Arrow, (such as the Drill types, MaterializedField, etc.) I will be posting this within a few days. On Tue, Jun 7, 2016 at 5:54 PM, Leif Walshwrote: > I am also interested in this. > On Tue, Jun 7, 2016 at 17:37 Holden Karau wrote: > > > Hi Everyone, > > > > I'm looking to help get started with Arrow & Spark and to that end I'd > like > > to start with getting the Java implementation closer to the spec / C > > implementation. I'm wondering what places people know the differences are > > between the two? > > > > Cheers, > > > > Holden :) > > > -- > -- > Cheers, > Leif >