Liya Fan created ARROW-6458: ------------------------------- Summary: [Java] Improve the performance and code structure for ApproxEqualsVisitor Key: ARROW-6458 URL: https://issues.apache.org/jira/browse/ARROW-6458 Project: Apache Arrow Issue Type: Improvement Components: Java Reporter: Liya Fan Assignee: Liya Fan
As discussed in https://github.com/apache/arrow/pull/5195#issuecomment-526157961, there are some problems with the current ways of comparing floating point vectors, we solve them in this PR: 1. there are if statements/duplicated members in ApproxEqualsVisitor, making the code redundant and less clear. 2. the comparion of float4 and float8 are based on wrapped objects Float and Double, which may have performance penalty. -- This message was sent by Atlassian Jira (v8.3.2#803003)