Re: [DISCUSSION] Automatically adding a the URL of the corresponding JIRA ticket as a comment in GitHub pull-request

2019-08-28 Thread Krisztián Szűcs
On Sat, Aug 24, 2019 at 6:12 PM Wes McKinney  wrote:

> Seems like a nice idea to me. We could also prompt contributors to
> open a JIRA and prefix to the PR title if they have not already.
>
Sounds good to me, we could even create a ticket and ask the user to fill
it.

>
> The ursabot process is already getting notified about all pull
> requests so the implementation there may not be that difficult. Note
> that parts of the ursabot codebase are a slight IP quagmire due to
> derivative works from Buildbot (which is GPLv2) -- we don't need to
> distribute this code with any Arrow releases but keep in mind that
> such code can't be brought under ASF governance.
>
We can make the GitHub event handlers pluggable, so keeping the arrow
specific event handlers in arrow is also possible.

>
> On Fri, Aug 23, 2019 at 10:53 PM Kenta Murata  wrote:
> >
> > I frequently do the following little bit bothersome steps for opening
> > JIRA tickets when I watch a GitHub pull-request:
> >
> > 1. Select the "ARROW-" text in the title and copy it
> > 2. Open JIRA if I haven't open it
> > 3. Select a ticket to open it
> > 4. Alter the URL by pasting text that copied at the step-1
> > 5. Hit the enter key
> >
> > I think it is better if these steps become easier.
> >
> > We already have a mechanism to inject a GitHub pull-request URL into
> > the corresponding JIRA ticket. How about making the similar mechanism
> > for the reverse link?  I guess it is possible to automate making a
> > comment of JIRA ticket URL to the pull-request when the "ARROW-"
> > text is injected in the title field by using GitHub Actions.
> >
> > I consulted this idea to Kou, he said ursabot may be appropriate to
> > implement such the feature.  And he promote me to ask to Krisztian
> > about this.
> >
> > Krisztian, what do you think this automation?
> >
> > Regards,
> > Kenta Murata
>


Re: [DISCUSSION] Automatically adding a the URL of the corresponding JIRA ticket as a comment in GitHub pull-request

2019-08-24 Thread Wes McKinney
Seems like a nice idea to me. We could also prompt contributors to
open a JIRA and prefix to the PR title if they have not already.

The ursabot process is already getting notified about all pull
requests so the implementation there may not be that difficult. Note
that parts of the ursabot codebase are a slight IP quagmire due to
derivative works from Buildbot (which is GPLv2) -- we don't need to
distribute this code with any Arrow releases but keep in mind that
such code can't be brought under ASF governance.

On Fri, Aug 23, 2019 at 10:53 PM Kenta Murata  wrote:
>
> I frequently do the following little bit bothersome steps for opening
> JIRA tickets when I watch a GitHub pull-request:
>
> 1. Select the "ARROW-" text in the title and copy it
> 2. Open JIRA if I haven't open it
> 3. Select a ticket to open it
> 4. Alter the URL by pasting text that copied at the step-1
> 5. Hit the enter key
>
> I think it is better if these steps become easier.
>
> We already have a mechanism to inject a GitHub pull-request URL into
> the corresponding JIRA ticket. How about making the similar mechanism
> for the reverse link?  I guess it is possible to automate making a
> comment of JIRA ticket URL to the pull-request when the "ARROW-"
> text is injected in the title field by using GitHub Actions.
>
> I consulted this idea to Kou, he said ursabot may be appropriate to
> implement such the feature.  And he promote me to ask to Krisztian
> about this.
>
> Krisztian, what do you think this automation?
>
> Regards,
> Kenta Murata