Re: [ANNOUNCE] New Committer: Sharmadha Sainath

[Hemanth Yamijala]

Congrats, Sharmadha!

Well deserved and good luck on your new role.

From: Madhan Neethiraj 
Sent: Friday, September 08, 2017 5:19 AM
To: dev@atlas.apache.org
Cc: sharmad...@apache.org
Subject: [ANNOUNCE] New Committer: Sharmadha Sainath

Atlas community,



Apache Atlas PMC has asked Sharmadha Sainath to become a committer and we are 
pleased to announce that she has accepted.



Welcome Sharmadha, great to have you on board.



On behalf of Apache Atlas PMC,



Madhan

[ANNOUNCE] New Committer: Sharmadha Sainath

[Madhan Neethiraj]

Atlas community,

 

Apache Atlas PMC has asked Sharmadha Sainath to become a committer and we are 
pleased to announce that she has accepted.

 

Welcome Sharmadha, great to have you on board.

 

On behalf of Apache Atlas PMC,

 

Madhan

 

 

 

Re: Review Request 61200: ATLAS-1996: Log4J Default Configuration Updated

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61200/#review184916
---




addons/hive-bridge/src/main/resources/atlas-hive-import-log4j.xml
Lines 35 (patched)


To limit the number of log files, set maxBackupIndex; I think 20 would be a 
good value - this would result in max space taken by Atlas log files to 2gb (20 
* 100mb).


- Madhan Neethiraj


On Sept. 7, 2017, 5:30 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61200/
> ---
> 
> (Updated Sept. 7, 2017, 5:30 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-1996
> https://issues.apache.org/jira/browse/ATLAS-1996
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Problem**
> Existing log4J configuration did not include max size parameter. This caused 
> logs to grow making it hard for human log readers.
> 
> Another contributing factor to log size growth is TitanDB's 
> _IndexSerializer_. When this is used, the query conversion from graph query 
> to indexed query is written as info log entry.
> 
> With the recent changes, many more index queries are used, thus contributing 
> to growth of log files.
> 
> **Solution**
> 
> Added maxFileSize parameter.
> Changed _com.thinkaurelius.titan_ log level to _warn_.
> 
> **Additional Info**
> Defaults need to be set in _Ambari_ so that they reflect correctly as part of 
> deployment.
> 
> 
> Diffs
> -
> 
>   addons/hive-bridge/src/main/resources/atlas-hive-import-log4j.xml c1184e5 
>   distro/src/conf/atlas-log4j.xml a0ef6a9 
>   typesystem/src/main/resources/atlas-log4j.xml c30403e 
> 
> 
> Diff: https://reviews.apache.org/r/61200/diff/2/
> 
> 
> Testing
> ---
> 
> **Functional tests**
> Observed configuration changes in the logs generated.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Review Request 62175: [ATLAS-2119]: Implement update and delete operations for RelationshipREST

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62175/
---

Review request for atlas.


Bugs: ATLAS-2119
https://issues.apache.org/jira/browse/ATLAS-2119


Repository: atlas


Description
---

* Implement update and delete relationship in RelationshipREST
* Add propagateTags information to each relationship instance


Diffs
-

  intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java 
ec6161c0 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
020dd457 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java
 227f7cd1 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java
 9b273193 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
 b0940f67 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
 f6aa7bbf 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1Test.java
 94cc5b93 


Diff: https://reviews.apache.org/r/62175/diff/1/


Testing
---

validated using POSTMAN Rest client.

Integration/Unit Tests in progress


Thanks,

Sarath Subramanian

[jira] [Updated] (ATLAS-2119) Implement update and delete operations for RelationshipREST

[Sarath Subramanian (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-2119:
--
Attachment: ATLAS-2119.1.patch

> Implement update and delete operations for RelationshipREST
> ---
>
> Key: ATLAS-2119
> URL: https://issues.apache.org/jira/browse/ATLAS-2119
> Project: Atlas
>  Issue Type: Task
>  Components:  atlas-core
>Affects Versions: 0.9-incubating
>Reporter: Sarath Subramanian
>Assignee: Sarath Subramanian
> Fix For: 0.9-incubating
>
> Attachments: ATLAS-2119.1.patch
>
>
> * Implement update and delete relationship in RelationshipREST
> * Add propagateTags information to each relationship instance



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (ATLAS-2119) Implement update and delete operations for RelationshipREST

[Sarath Subramanian (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-2119:
--
Description: 
* Implement update and delete relationship in RelationshipREST
* Add propagateTags information to each relationship instance

> Implement update and delete operations for RelationshipREST
> ---
>
> Key: ATLAS-2119
> URL: https://issues.apache.org/jira/browse/ATLAS-2119
> Project: Atlas
>  Issue Type: Task
>  Components:  atlas-core
>Affects Versions: 0.9-incubating
>Reporter: Sarath Subramanian
>Assignee: Sarath Subramanian
> Fix For: 0.9-incubating
>
>
> * Implement update and delete relationship in RelationshipREST
> * Add propagateTags information to each relationship instance



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (ATLAS-2119) Implement update and delete operations for RelationshipREST

[Sarath Subramanian (JIRA)]

Sarath Subramanian created ATLAS-2119:
-

 Summary: Implement update and delete operations for 
RelationshipREST
 Key: ATLAS-2119
 URL: https://issues.apache.org/jira/browse/ATLAS-2119
 Project: Atlas
  Issue Type: Task
  Components:  atlas-core
Affects Versions: 0.9-incubating
Reporter: Sarath Subramanian
Assignee: Sarath Subramanian
 Fix For: 0.9-incubating






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 61940: ATLAS-2090 : UI - Cache busting for static content (css, js)

[Ashutosh Mestry]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61940/#review184874
---


Ship it!




Ship It!

- Ashutosh Mestry


On Aug. 28, 2017, 1:22 p.m., keval bhatt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61940/
> ---
> 
> (Updated Aug. 28, 2017, 1:22 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, 
> Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2090
> https://issues.apache.org/jira/browse/ATLAS-2090
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Grunt task is updated to handle Cache busting issue, so now after every 
> successful build grunt task will add new time as the query string for static 
> content i.e .CSS and .JS
> 
> 
> Diffs
> -
> 
>   dashboardv2/gruntfile.js 900ee40 
>   dashboardv2/package.json 6068c79 
>   dashboardv2/public/index.html f572049 
>   dashboardv2/public/index.html.tpl PRE-CREATION 
>   dashboardv2/public/js/main.js 63e9abc 
> 
> 
> Diff: https://reviews.apache.org/r/61940/diff/1/
> 
> 
> Testing
> ---
> 
> Build the atlas code and checked the query string for static content i.e.CSS 
> and .JS, its working as expected.
> 
> 
> Thanks,
> 
> keval bhatt
> 
>

Re: Review Request 61940: ATLAS-2090 : UI - Cache busting for static content (css, js)

[Ashutosh Mestry]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61940/#review184873
---




dashboardv2/public/index.html.tpl
Lines 75 (patched)


Support _require.js_ with _bust_.

```javascript

```


- Ashutosh Mestry


On Aug. 28, 2017, 1:22 p.m., keval bhatt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61940/
> ---
> 
> (Updated Aug. 28, 2017, 1:22 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, 
> Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2090
> https://issues.apache.org/jira/browse/ATLAS-2090
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Grunt task is updated to handle Cache busting issue, so now after every 
> successful build grunt task will add new time as the query string for static 
> content i.e .CSS and .JS
> 
> 
> Diffs
> -
> 
>   dashboardv2/gruntfile.js 900ee40 
>   dashboardv2/package.json 6068c79 
>   dashboardv2/public/index.html f572049 
>   dashboardv2/public/index.html.tpl PRE-CREATION 
>   dashboardv2/public/js/main.js 63e9abc 
> 
> 
> Diff: https://reviews.apache.org/r/61940/diff/1/
> 
> 
> Testing
> ---
> 
> Build the atlas code and checked the query string for static content i.e.CSS 
> and .JS, its working as expected.
> 
> 
> Thanks,
> 
> keval bhatt
> 
>

Re: Review Request 61200: ATLAS-1996: Log4J Default Configuration Updated

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61200/#review184848
---


Ship it!




Ship It!

- Sarath Subramanian


On Sept. 7, 2017, 10:30 a.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61200/
> ---
> 
> (Updated Sept. 7, 2017, 10:30 a.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-1996
> https://issues.apache.org/jira/browse/ATLAS-1996
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Problem**
> Existing log4J configuration did not include max size parameter. This caused 
> logs to grow making it hard for human log readers.
> 
> Another contributing factor to log size growth is TitanDB's 
> _IndexSerializer_. When this is used, the query conversion from graph query 
> to indexed query is written as info log entry.
> 
> With the recent changes, many more index queries are used, thus contributing 
> to growth of log files.
> 
> **Solution**
> 
> Added maxFileSize parameter.
> Changed _com.thinkaurelius.titan_ log level to _warn_.
> 
> **Additional Info**
> Defaults need to be set in _Ambari_ so that they reflect correctly as part of 
> deployment.
> 
> 
> Diffs
> -
> 
>   addons/hive-bridge/src/main/resources/atlas-hive-import-log4j.xml c1184e5 
>   distro/src/conf/atlas-log4j.xml a0ef6a9 
>   typesystem/src/main/resources/atlas-log4j.xml c30403e 
> 
> 
> Diff: https://reviews.apache.org/r/61200/diff/2/
> 
> 
> Testing
> ---
> 
> **Functional tests**
> Observed configuration changes in the logs generated.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 61200: ATLAS-1996: Log4J Default Configuration Updated

[Ashutosh Mestry]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61200/
---

(Updated Sept. 7, 2017, 5:30 p.m.)


Review request for atlas and Madhan Neethiraj.


Changes
---

Update includes:
- Changed _DailyRollingFileAppender_ to _RollingFileAppender_. This honors max 
size.


Bugs: ATLAS-1996
https://issues.apache.org/jira/browse/ATLAS-1996


Repository: atlas


Description
---

**Problem**
Existing log4J configuration did not include max size parameter. This caused 
logs to grow making it hard for human log readers.

Another contributing factor to log size growth is TitanDB's _IndexSerializer_. 
When this is used, the query conversion from graph query to indexed query is 
written as info log entry.

With the recent changes, many more index queries are used, thus contributing to 
growth of log files.

**Solution**

Added maxFileSize parameter.
Changed _com.thinkaurelius.titan_ log level to _warn_.

**Additional Info**
Defaults need to be set in _Ambari_ so that they reflect correctly as part of 
deployment.


Diffs (updated)
-

  addons/hive-bridge/src/main/resources/atlas-hive-import-log4j.xml c1184e5 
  distro/src/conf/atlas-log4j.xml a0ef6a9 
  typesystem/src/main/resources/atlas-log4j.xml c30403e 


Diff: https://reviews.apache.org/r/61200/diff/2/

Changes: https://reviews.apache.org/r/61200/diff/1-2/


Testing
---

**Functional tests**
Observed configuration changes in the logs generated.


Thanks,

Ashutosh Mestry

[jira] [Updated] (ATLAS-1996) split the atlas application log file if it grows big

[Ashutosh Mestry (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashutosh Mestry updated ATLAS-1996:
---
Attachment: ATLAS-1996.patch

> split the atlas application log file if it grows big
> 
>
> Key: ATLAS-1996
> URL: https://issues.apache.org/jira/browse/ATLAS-1996
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 0.9-incubating
>Reporter: Deepak Sharma
>Assignee: Ashutosh Mestry
> Fix For: 0.9-incubating
>
> Attachments: ATLAS-1996.patch
>
>
> application log size is growing in GB's for atlas
> some times it goes till 100 GB.
> it is better to split it if it grows more than around 100-200MB.
> for eg: some instance are seen with 20GB log file



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (ATLAS-1996) split the atlas application log file if it grows big

[Ashutosh Mestry (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashutosh Mestry updated ATLAS-1996:
---
Attachment: (was: ATLAS-1996.patch)

> split the atlas application log file if it grows big
> 
>
> Key: ATLAS-1996
> URL: https://issues.apache.org/jira/browse/ATLAS-1996
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 0.9-incubating
>Reporter: Deepak Sharma
>Assignee: Ashutosh Mestry
> Fix For: 0.9-incubating
>
>
> application log size is growing in GB's for atlas
> some times it goes till 100 GB.
> it is better to split it if it grows more than around 100-200MB.
> for eg: some instance are seen with 20GB log file



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ATLAS-2118) Basic search - Contains clause issues

[Apoorv Naik (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157230#comment-16157230
 ] 

Apoorv Naik commented on ATLAS-2118:


Surprisingly the right hand counterparts were working fine with the index, I 
think the regex sees the left hand versions and then starts expecting a right 
hand one for the the same and errors out. 

I'll run some more tests to make sure that it works as intended.

> Basic search - Contains clause issues
> -
>
> Key: ATLAS-2118
> URL: https://issues.apache.org/jira/browse/ATLAS-2118
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.8-incubating, 0.9-incubating, 0.8.1-incubating
>Reporter: Apoorv Naik
>Assignee: Apoorv Naik
> Fix For: 0.8-incubating, 0.9-incubating, 0.8.1-incubating
>
> Attachments: 
> 0001-ATLAS-2118-Issues-with-contains-in-Basic-search.patch
>
>
> If the contains clause attribute value contains any of the special regex 
> chars like 
> "+", "|", "(", "{", "[", "*", "?", "$", "/", "^"
> then the graph query fails with Invalid pattern exception
> Solution: Escape all occurrences of the special characters 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ATLAS-2118) Basic search - Contains clause issues

[Graham Wallis (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156952#comment-16156952
 ] 

Graham Wallis commented on ATLAS-2118:
--

Do you also need the right-hand versions of the various bracket/parenthesis 
characters? (i.e. ')', '}' and ']')

> Basic search - Contains clause issues
> -
>
> Key: ATLAS-2118
> URL: https://issues.apache.org/jira/browse/ATLAS-2118
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.8-incubating, 0.9-incubating, 0.8.1-incubating
>Reporter: Apoorv Naik
>Assignee: Apoorv Naik
> Fix For: 0.8-incubating, 0.9-incubating, 0.8.1-incubating
>
> Attachments: 
> 0001-ATLAS-2118-Issues-with-contains-in-Basic-search.patch
>
>
> If the contains clause attribute value contains any of the special regex 
> chars like 
> "+", "|", "(", "{", "[", "*", "?", "$", "/", "^"
> then the graph query fails with Invalid pattern exception
> Solution: Escape all occurrences of the special characters 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 62110: ATLAS-2115: Fix Regression on Basic search

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62110/#review184815
---




repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
Lines 108 (patched)


given classification filter is already added to 'query' in line #107, it is 
necessary to add a predicate for the same in 'graphQueryPredicate'?



repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
Lines 124 (patched)


Shuldn't this be: "graphQueryPredicate = attributePredicate;"



repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
Lines 129 (patched)


given state filter is already added to 'graphQuery' in line #126, it is 
necessary to add a predicate for the same in 'graphQueryPredicate'?



repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
Lines 142 (patched)


This predicate should be added to 'filterGraphQueryPredicate' and not 
'graphQueryPredicate'.


- Madhan Neethiraj


On Sept. 6, 2017, 11:11 p.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62110/
> ---
> 
> (Updated Sept. 6, 2017, 11:11 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2115
> https://issues.apache.org/jira/browse/ATLAS-2115
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1880 introduced regression in call timings for the basic search GET 
> implementation
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java
>  0daab030 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
>  a4a638af 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> d5e39236 
>   repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
> fc973e6f 
> 
> 
> Diff: https://reviews.apache.org/r/62110/diff/2/
> 
> 
> Testing
> ---
> 
> Tested via scripts and network call timing in Chrome/Firefox.
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>