Re: Review Request 72156: ATLAS-3618 Entities with no guid appears in search result
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72156/ --- (Updated Feb. 25, 2020, 7:11 a.m.) Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes --- added method to check Nonentity vertices Bugs: ATLAS-3618 https://issues.apache.org/jira/browse/ATLAS-3618 Repository: atlas Description --- 1) Entities of struct types appears when ALL_ENTITY_TYPES is selected 2) Entities of internal types like AtlasGlossary etc appears when ALL_ENTITY_TYPES is selected Diffs (updated) - repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java c0a5a46dd repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java b5606d046 repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java bb1e9f633 Diff: https://reviews.apache.org/r/72156/diff/2/ Changes: https://reviews.apache.org/r/72156/diff/1-2/ Testing (updated) --- 1) typeName: ALL_ENTITY_TYPES returns all entities with no struct types(whoes guid isnotnull) and no internal types(whoes supertype is not _internal) 2) typeName: ALL_ENTITY_TYPES, filter: guid isnull, returns no result 3) typeName: ALL_ENTITY_TYPES, filter: typeName begins_with Atlas, returns no result Usecase: -> Added, term1 in Glossary -> added classification1 to term1 1) In search Panel(showing all entities) -> term1 shouln't appear 2) In classification Panel, showing all entities associated to classification1 -> term1 shouldn't appear Thanks, Pinal Shah
[jira] [Updated] (ATLAS-3628) Beta UI: Wildcard Search for classifications doesn't fire any search
[ https://issues.apache.org/jira/browse/ATLAS-3628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keval Bhatt updated ATLAS-3628: --- Attachment: ATLAS-3628-1.patch > Beta UI: Wildcard Search for classifications doesn't fire any search > > > Key: ATLAS-3628 > URL: https://issues.apache.org/jira/browse/ATLAS-3628 > Project: Atlas > Issue Type: Improvement >Reporter: Keval Bhatt >Assignee: Keval Bhatt >Priority: Major > Fix For: 2.1.0, 3.0.0 > > Attachments: ATLAS-3628-1.patch, ATLAS-3628.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3624) Beta UI : Allow user to add multi-valued attributes in namespaces
[ https://issues.apache.org/jira/browse/ATLAS-3624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keval Bhatt updated ATLAS-3624: --- Attachment: ATLAS-3624-1.patch > Beta UI : Allow user to add multi-valued attributes in namespaces > - > > Key: ATLAS-3624 > URL: https://issues.apache.org/jira/browse/ATLAS-3624 > Project: Atlas > Issue Type: Improvement >Reporter: Keval Bhatt >Assignee: Keval Bhatt >Priority: Major > Fix For: 2.1.0, 3.0.0 > > Attachments: ATLAS-3624-1.patch, ATLAS-3624.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ATLAS-3631) Make Server name header configurable.
Nixon Rodrigues created ATLAS-3631: -- Summary: Make Server name header configurable. Key: ATLAS-3631 URL: https://issues.apache.org/jira/browse/ATLAS-3631 Project: Atlas Issue Type: Improvement Affects Versions: 2.0.0 Reporter: Nixon Rodrigues Fix For: 2.1.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3628) Beta UI: Wildcard Search for classifications doesn't fire any search
[ https://issues.apache.org/jira/browse/ATLAS-3628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keval Bhatt updated ATLAS-3628: --- Attachment: ATLAS-3628.patch > Beta UI: Wildcard Search for classifications doesn't fire any search > > > Key: ATLAS-3628 > URL: https://issues.apache.org/jira/browse/ATLAS-3628 > Project: Atlas > Issue Type: Improvement >Reporter: Keval Bhatt >Assignee: Keval Bhatt >Priority: Major > Fix For: 2.1.0, 3.0.0 > > Attachments: ATLAS-3628.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3624) Beta UI : Allow user to add multi-valued attributes in namespaces
[ https://issues.apache.org/jira/browse/ATLAS-3624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keval Bhatt updated ATLAS-3624: --- Attachment: (was: ATLAS-3629.patch) > Beta UI : Allow user to add multi-valued attributes in namespaces > - > > Key: ATLAS-3624 > URL: https://issues.apache.org/jira/browse/ATLAS-3624 > Project: Atlas > Issue Type: Improvement >Reporter: Keval Bhatt >Assignee: Keval Bhatt >Priority: Major > Attachments: ATLAS-3624.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3624) Beta UI : Allow user to add multi-valued attributes in namespaces
[ https://issues.apache.org/jira/browse/ATLAS-3624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keval Bhatt updated ATLAS-3624: --- Attachment: ATLAS-3624.patch > Beta UI : Allow user to add multi-valued attributes in namespaces > - > > Key: ATLAS-3624 > URL: https://issues.apache.org/jira/browse/ATLAS-3624 > Project: Atlas > Issue Type: Improvement >Reporter: Keval Bhatt >Assignee: Keval Bhatt >Priority: Major > Attachments: ATLAS-3624.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3624) Beta UI : Allow user to add multi-valued attributes in namespaces
[ https://issues.apache.org/jira/browse/ATLAS-3624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keval Bhatt updated ATLAS-3624: --- Attachment: ATLAS-3629.patch > Beta UI : Allow user to add multi-valued attributes in namespaces > - > > Key: ATLAS-3624 > URL: https://issues.apache.org/jira/browse/ATLAS-3624 > Project: Atlas > Issue Type: Improvement >Reporter: Keval Bhatt >Assignee: Keval Bhatt >Priority: Major > Attachments: ATLAS-3624.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3624) Beta UI : Allow user to add multi-valued attributes in namespaces
[ https://issues.apache.org/jira/browse/ATLAS-3624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keval Bhatt updated ATLAS-3624: --- Fix Version/s: 3.0.0 2.1.0 > Beta UI : Allow user to add multi-valued attributes in namespaces > - > > Key: ATLAS-3624 > URL: https://issues.apache.org/jira/browse/ATLAS-3624 > Project: Atlas > Issue Type: Improvement >Reporter: Keval Bhatt >Assignee: Keval Bhatt >Priority: Major > Fix For: 2.1.0, 3.0.0 > > Attachments: ATLAS-3624.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ATLAS-3630) UI: Update node version to 12.x
[ https://issues.apache.org/jira/browse/ATLAS-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keval Bhatt resolved ATLAS-3630. Resolution: Fixed > UI: Update node version to 12.x > --- > > Key: ATLAS-3630 > URL: https://issues.apache.org/jira/browse/ATLAS-3630 > Project: Atlas > Issue Type: Improvement >Reporter: Keval Bhatt >Assignee: Keval Bhatt >Priority: Major > Fix For: 2.1.0, 3.0.0 > > Attachments: ATLAS-3630.1.patch, ATLAS-3630.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: Review Request 72127: ATLAS-3615 :- Basic Search : Search with _ALL_ENTITY_TYPES and classification doesn't not fetch any entity associated to that classification
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72127/#review219632 --- Ship it! Ship It! - Madhan Neethiraj On Feb. 21, 2020, 5:24 a.m., Pinal Shah wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72127/ > --- > > (Updated Feb. 21, 2020, 5:24 a.m.) > > > Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath > Subramanian. > > > Bugs: ATLAS-3615 > https://issues.apache.org/jira/browse/ATLAS-3615 > > > Repository: atlas > > > Description > --- > > Issues: > 1) Combination of typeName:_ALL_ENTITY_TYPES and classification doesn't > return result > Why? As _ALL_ENTITY_TYPES value is assigned as [* TO *] results show up when > searched from solr but not from graphdb > > 2) Combination of typeName:_ALL_ENTITY_TYPES, classification, > query(SearchByText) doesn't return result > Why? result from solr, thru "/freetext" is correct, but onsearching if > resulted entitytype is in typeAndSubtypes of given entityType, it breaks > because typeAndSubTypes of _ALL_ENTITY_TYPES is [* TO *] > > 3) Combination of typeName, classification:_ALL_CLASSIFICATION_TYPES doesn't > return result > > 4) Combination of typeName:_ALL_ENTITY_TYPES, > classification:_ALL_CLASSIFICATION_TYPES, query(SearchByText) doesn't return > correct result > why? query formed with above combination in solr /freetext is 'SAMPLEQUERY' > AND [* TO *] AND [* TO *] > > 5) Combination of classification:_ALL_CLASSIFICATION_TYPES and > classificationFilter doesn't return correct result > > > Diffs > - > > > repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java > c0a5a46dd > > repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java > b5606d046 > > repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java > d628f1352 > repository/src/main/java/org/apache/atlas/discovery/SearchContext.java > 353411363 > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java > 8c17a9044 > > > Diff: https://reviews.apache.org/r/72127/diff/4/ > > > Testing > --- > > For issue1: > 1) tested with values _ALL_ENTITY_TYPES + EntityFilter + classification -> > result fetches from gremlin and shows up correct result > 2) tested with values _ALL_ENTITY_TYPES + classification -> result fetches > from gremlin and shows up correct result > > For issue2: > 1) tested with values _ALL_ENTITY_TYPES + classification + > query(SearchByText) -> shows up correct result > > > Thanks, > > Pinal Shah > >
