[GitHub] [atlas] HeartSaVioR commented on issue #89: ATLAS-3646 Create new 'spark_ml_model_dataset', 'spark_ml_pipeline_dataset' relationship defs

[GitBox]

HeartSaVioR commented on issue #89: ATLAS-3646 Create new 
'spark_ml_model_dataset','spark_ml_pipeline_dataset' relationship defs
URL: https://github.com/apache/atlas/pull/89#issuecomment-598001082
 
 
   @sarathsubramanian Kindly reminder.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [DRAFT] Board report for Apache Atlas: March 2020

[Nixon Rodrigues]

Thanks Madhan for putting this together.

The draft looks good.  +1

Regards,
Nixon

On Thu, Mar 12, 2020 at 9:31 AM Madhan Neethiraj  wrote:

> Atlas team,
>
>
>
> Please review the draft board report below and send your feedback/comments.
>
>
>
> Thanks,
>
> Madhan
>
>
>
>
>
> ## Description:
>
>   Apache Atlas is a scalable and extensible set of core foundational
>
>   governance services that enables enterprises to effectively and
> efficiently
>
>   meet their compliance requirements within Hadoop and allows integration
> with
>
>   the complete enterprise data ecosystem
>
>
>
> ## Issues:
>
>   There are no issues requiring board attention at this time.
>
>
>
> ## Activity:
>
>   - performance improvements in lineage, tag-propagation
>
>   - new feature to support business metadata
>
>   - updated authorization model to support operations on labels,
> business-metadata
>
>   - performance improvements in import functionality
>
>   - updated JanusGraph version to 0.4.1, and Tinkerpop version to 3.4.4
>
>   - added updated entity models for AWS S3
>
>   - added entity models for ADLS-Gen2
>
>   - search enhancements to support system-attributes, business-attributes
>
>   - working towards release of Apache Atlas 2.1, by end of March-2020
>
>
>
> ## Health report:
>
>   - 2 new contributors added in last 3 months: Pinal Shah, Sourav Banerjee
>
>
>
> ## PMC changes:
>
>   - Currently 34 PMC members
>
>   - Last addition to PMC role was on 5/13/2019
>
>
>
> ## Committer base changes:
>
>   - Currently 38 committers
>
>   - No new committers added in last 3 months
>
>   - Last addition to committer role was on 10/15/2018
>
>
>
> ## Releases:
>
>   0.8.4was released on 06/21/2019
>
>   1.2.0was released on 06/12/2019
>
>   2.0.0was released on 05/14/2019
>
>   0.8.3was released on 10/31/2018
>
>   1.1.0was released on 09/17/2018
>
>   1.0.0was released on 06/02/2018
>
>   0.8.2was released on 02/05/2018
>
>   1.0.0-alpha  was released on 01/25/2018
>
>   0.8.1was released on 08/29/2017
>
>   0.8-incubating   was released on 03/16/2017
>
>   0.7.1-incubating was released on 01/26/2017
>
>   0.7-incubating   was released on 07/09/2016
>
>   0.6-incubating   was released on 12/31/2015
>
>   0.5-incubating   was released on 07/11/2015
>
>

[DRAFT] Board report for Apache Atlas: March 2020

[Madhan Neethiraj]

Atlas team,

 

Please review the draft board report below and send your feedback/comments.

 

Thanks,

Madhan

 

 

## Description:

  Apache Atlas is a scalable and extensible set of core foundational

  governance services that enables enterprises to effectively and efficiently

  meet their compliance requirements within Hadoop and allows integration with

  the complete enterprise data ecosystem

 

## Issues:

  There are no issues requiring board attention at this time.

 

## Activity:

  - performance improvements in lineage, tag-propagation

  - new feature to support business metadata

  - updated authorization model to support operations on labels, 
business-metadata

  - performance improvements in import functionality

  - updated JanusGraph version to 0.4.1, and Tinkerpop version to 3.4.4

  - added updated entity models for AWS S3

  - added entity models for ADLS-Gen2

  - search enhancements to support system-attributes, business-attributes

  - working towards release of Apache Atlas 2.1, by end of March-2020

 

## Health report:

  - 2 new contributors added in last 3 months: Pinal Shah, Sourav Banerjee

 

## PMC changes:

  - Currently 34 PMC members

  - Last addition to PMC role was on 5/13/2019

 

## Committer base changes:

  - Currently 38 committers

  - No new committers added in last 3 months

  - Last addition to committer role was on 10/15/2018

 

## Releases:

  0.8.4    was released on 06/21/2019

  1.2.0    was released on 06/12/2019

  2.0.0    was released on 05/14/2019

  0.8.3    was released on 10/31/2018

  1.1.0    was released on 09/17/2018

  1.0.0    was released on 06/02/2018

  0.8.2    was released on 02/05/2018

  1.0.0-alpha  was released on 01/25/2018

  0.8.1    was released on 08/29/2017

  0.8-incubating   was released on 03/16/2017

  0.7.1-incubating was released on 01/26/2017

  0.7-incubating   was released on 07/09/2016

  0.6-incubating   was released on 12/31/2015

  0.5-incubating   was released on 07/11/2015

[jira] [Commented] (ATLAS-3660) add models for ADLS-Gen2 types

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057434#comment-17057434
 ] 

ASF subversion and git services commented on ATLAS-3660:


Commit 7798f94883c91a962db4ed4fb6569588397a9e39 in atlas's branch 
refs/heads/branch-2.0 from Madhan Neethiraj
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=7798f94 ]

ATLAS-3660: added model for ADLS-Gen2

(cherry picked from commit e1b205c61583e0624286d83e539d9b06702a4388)


> add models for ADLS-Gen2 types
> --
>
> Key: ATLAS-3660
> URL: https://issues.apache.org/jira/browse/ATLAS-3660
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 2.1.0, 3.0.0
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3660.patch
>
>
> Add entity-types and relationships to model Azure Data Lake Store Gen2 
> (ADLS-Gen2) entities in Atlas. Addition of the following will enable 
> capturing of lineage with other datasets already present in Atlas:
> - ADLS-Gen2 Blob
> - ADLS-Gen2 Directory
> - ADLS-Gen2 Container (filesystem)
> - ADLS-Gen2 Account
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3660) add models for ADLS-Gen2 types

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057433#comment-17057433
 ] 

ASF subversion and git services commented on ATLAS-3660:


Commit e1b205c61583e0624286d83e539d9b06702a4388 in atlas's branch 
refs/heads/master from Madhan Neethiraj
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=e1b205c ]

ATLAS-3660: added model for ADLS-Gen2


> add models for ADLS-Gen2 types
> --
>
> Key: ATLAS-3660
> URL: https://issues.apache.org/jira/browse/ATLAS-3660
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 2.1.0, 3.0.0
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3660.patch
>
>
> Add entity-types and relationships to model Azure Data Lake Store Gen2 
> (ADLS-Gen2) entities in Atlas. Addition of the following will enable 
> capturing of lineage with other datasets already present in Atlas:
> - ADLS-Gen2 Blob
> - ADLS-Gen2 Directory
> - ADLS-Gen2 Container (filesystem)
> - ADLS-Gen2 Account
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3614) add a configuration to specify default classification-propagation flag

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057422#comment-17057422
 ] 

ASF subversion and git services commented on ATLAS-3614:


Commit b3abf70b44feced1ec760f3b3a51912a81ffdcd4 in atlas's branch 
refs/heads/branch-2.0 from Madhan Neethiraj
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=b3abf70 ]

ATLAS-3614: added configuration to specify default classification-propagation 
flag

(cherry picked from commit ba5b2dba53387b11707a073538e7b804be19e0b3)


> add a configuration to specify default classification-propagation flag
> --
>
> Key: ATLAS-3614
> URL: https://issues.apache.org/jira/browse/ATLAS-3614
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 1.0.0, 1.1.0, 1.2.0, 2.0.0
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3614.patch
>
>
> Propagation of classification was introduced in Atlas 1.0 (ATLAS-2456). A 
> flag in the classification, named {{propagate}}, determines whether it needs 
> to be propagated or not. If this flag is not specified while adding a 
> classification (like in calls from earlier version API clients), Atlas uses 
> default value of 'true', which results in the added classification to be 
> propagated. It will help to add a configuration in Atlas to control the 
> default value for this flag - like 
> {{atlas.classification.propagation.default}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3661) Create 'spark_column_lineage' type and relationship definition to add support of column level lineage

[Vladislav Glinskiy (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057421#comment-17057421
 ] 

Vladislav Glinskiy commented on ATLAS-3661:
---

cc [~kabhwan] [~sarath] 

> Create 'spark_column_lineage' type and relationship definition to add support 
> of column level lineage
> -
>
> Key: ATLAS-3661
> URL: https://issues.apache.org/jira/browse/ATLAS-3661
> Project: Atlas
>  Issue Type: Task
>Reporter: Vladislav Glinskiy
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Create 'spark_column_lineage' type and corresponding 
> 'spark_process_column_lineage' relationship definition to add support of 
> column-level lineage.
> Column level lineage refers to lineage created between the input and output 
> columns.
>  For example:
> {code:java}
> hive > create table employee_ctas as select id from employee;{code}
>  For the above query, lineage is created from 'employee' to 'employee_ctas',
>  and also from 'employee.id' to 'employee_ctas.id'.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3614) add a configuration to specify default classification-propagation flag

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057420#comment-17057420
 ] 

ASF subversion and git services commented on ATLAS-3614:


Commit ba5b2dba53387b11707a073538e7b804be19e0b3 in atlas's branch 
refs/heads/master from Madhan Neethiraj
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=ba5b2db ]

ATLAS-3614: added configuration to specify default classification-propagation 
flag


> add a configuration to specify default classification-propagation flag
> --
>
> Key: ATLAS-3614
> URL: https://issues.apache.org/jira/browse/ATLAS-3614
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 1.0.0, 1.1.0, 1.2.0, 2.0.0
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3614.patch
>
>
> Propagation of classification was introduced in Atlas 1.0 (ATLAS-2456). A 
> flag in the classification, named {{propagate}}, determines whether it needs 
> to be propagated or not. If this flag is not specified while adding a 
> classification (like in calls from earlier version API clients), Atlas uses 
> default value of 'true', which results in the added classification to be 
> propagated. It will help to add a configuration in Atlas to control the 
> default value for this flag - like 
> {{atlas.classification.propagation.default}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [atlas] vladhlinsky commented on issue #93: ATLAS-3661 Create 'spark_column_lineage' type and relationship definition

[GitBox]

vladhlinsky commented on issue #93: ATLAS-3661 Create 'spark_column_lineage' 
type and relationship definition
URL: https://github.com/apache/atlas/pull/93#issuecomment-597892210
 
 
   cc @HeartSaVioR @sarathsubramanian


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [atlas] vladhlinsky commented on issue #93: ATLAS-3661 Create 'spark_column_lineage' type and relationship definition

[GitBox]

vladhlinsky commented on issue #93: ATLAS-3661 Create 'spark_column_lineage' 
type and relationship definition
URL: https://github.com/apache/atlas/pull/93#issuecomment-597892124
 
 
   Attaching screenshots.
   ![Screenshot from 2020-03-11 
23-39-45](https://user-images.githubusercontent.com/61428392/76467148-a386a580-63f1-11ea-9df0-9507e015c7a6.png)
   ![Screenshot from 2020-03-10 
21-51-16](https://user-images.githubusercontent.com/61428392/76467046-66baae80-63f1-11ea-877c-cd64b874421d.png)
   ![Screenshot from 2020-03-10 
21-51-26](https://user-images.githubusercontent.com/61428392/76467051-69b59f00-63f1-11ea-8d22-f147c066a9e6.png)
   ![Screenshot from 2020-03-10 
21-51-47](https://user-images.githubusercontent.com/61428392/76467056-6de1bc80-63f1-11ea-8afd-7ce905b93797.png)
   ![Screenshot from 2020-03-11 
23-40-34](https://user-images.githubusercontent.com/61428392/76467202-bf8a4700-63f1-11ea-88c9-8320901a41b3.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [atlas] vladhlinsky opened a new pull request #93: ATLAS-3661 Create 'spark_column_lineage' type and relationship definition

[GitBox]

vladhlinsky opened a new pull request #93: ATLAS-3661 Create 
'spark_column_lineage' type and relationship definition
URL: https://github.com/apache/atlas/pull/93
 
 
   ## What changes were proposed in this pull request?
   
   Create `spark_column_lineage` type and relationship definition to add 
support of column level lineage for `CREATE TABLE AS SELECT ...` statements and 
views. Column level lineage refers to lineage created between the input and 
output columns.
   For example:
   ```
   hive > create table employee_ctas as select id from employee;
   ```
   For the above query, lineage is created from `employee` to `employee_ctas`, 
and also from `employee.id` to `employee_ctas.id`.
   
   ## How was this patch tested?
   
   Manually using modified version of Spark Atlas Connector:
   - Installed and started Atlas.
   - `1100-spark_model.json` is updated with proposed changes. Atlas is 
restarted.
   - Executed the next statements using spark-shell:
   
   ```
   spark.sql("create table sparkemployee_1_2(id int,name string)");
   spark.sql("create table sparkemployee_ctas_1_2 as select id from 
sparkemployee_1_2");
   ```
   - Verified that each table has column entities and `spark_column_lineage` 
entity is created.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Review Request 72223: ATLAS-3660: added model for ADLS-Gen2

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72223/#review219902
---


Ship it!




Ship It!

- Sarath Subramanian


On March 11, 2020, 1:23 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72223/
> ---
> 
> (Updated March 11, 2020, 1:23 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, keval bhatt, Nikhil Bonte, Nixon 
> Rodrigues, Pinal Shah, Sarath Subramanian, Sharmadha Sainath, Sidharth 
> Mishra, and Umesh Padashetty.
> 
> 
> Bugs: ATLAS-3660
> https://issues.apache.org/jira/browse/ATLAS-3660
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> added model for ADLS-Gen2
> 
> 
> Diffs
> -
> 
>   addons/models/3000-Cloud/3040-azure_adls_typedefs.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72223/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 72224: ATLAS-3614: added configuration to specify default classification-propagation flag

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72224/#review219903
---


Ship it!




Ship It!

- Sarath Subramanian


On March 11, 2020, 12:05 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72224/
> ---
> 
> (Updated March 11, 2020, 12:05 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, keval bhatt, Mehul Parikh, Nixon 
> Rodrigues, Pinal Shah, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3614
> https://issues.apache.org/jira/browse/ATLAS-3614
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> - added configuration atlas.classification.propagation.default, which decides 
> propagation when 'propagate' flag is not specified during addition of a 
> classification
> - default value is 'true' i.e. added classficaion will be propagated when 
> 'propagate' flag is now specified
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java c5bf50dca 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> 0d20622f4 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  d3ba18f38 
> 
> 
> Diff: https://reviews.apache.org/r/72224/diff/1/
> 
> 
> Testing
> ---
> 
> verified manually that this the default specified in the configuration is 
> used while adding a classification if 'propage' flag is not specified
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

[jira] [Created] (ATLAS-3661) Create 'spark_column_lineage' type and relationship definition to add support of column level lineage

[Vladislav Glinskiy (Jira)]

Vladislav Glinskiy created ATLAS-3661:
-

 Summary: Create 'spark_column_lineage' type and relationship 
definition to add support of column level lineage
 Key: ATLAS-3661
 URL: https://issues.apache.org/jira/browse/ATLAS-3661
 Project: Atlas
  Issue Type: Task
Reporter: Vladislav Glinskiy
 Fix For: 2.1.0, 3.0.0


Create 'spark_column_lineage' type and corresponding 
'spark_process_column_lineage' relationship definition to add support of 
column-level lineage.

Column level lineage refers to lineage created between the input and output 
columns.
 For example:
{code:java}
hive > create table employee_ctas as select id from employee;{code}

 For the above query, lineage is created from 'employee' to 'employee_ctas',
 and also from 'employee.id' to 'employee_ctas.id'.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 72223: ATLAS-3660: added model for ADLS-Gen2

[Madhan Neethiraj]

> On March 11, 2020, 8:36 p.m., Sarath Subramanian wrote:
> > addons/models/3000-Cloud/3040-azure_adls_typedefs.json
> > Lines 414 (patched)
> > 
> >
> > propagation turned ON by default? if account contains lot of container. 
> > 
> > account -> countainers and parent -> children

Yes, this is intentional. Having propagation ON is crucial to ensure that 
classifications at container/directory are considered while authorizing acceess 
to sub-dir/files. Atlas is likely to have only subset of ADLS-Gen2 entities 
i.e. which are part of data lineage with other entities, like hive_table. In 
such use, having propagation ON should not cause performance concerns.


- Madhan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72223/#review219898
---


On March 11, 2020, 8:23 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72223/
> ---
> 
> (Updated March 11, 2020, 8:23 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, keval bhatt, Nikhil Bonte, Nixon 
> Rodrigues, Pinal Shah, Sarath Subramanian, Sharmadha Sainath, Sidharth 
> Mishra, and Umesh Padashetty.
> 
> 
> Bugs: ATLAS-3660
> https://issues.apache.org/jira/browse/ATLAS-3660
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> added model for ADLS-Gen2
> 
> 
> Diffs
> -
> 
>   addons/models/3000-Cloud/3040-azure_adls_typedefs.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72223/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 72223: ATLAS-3660: added model for ADLS-Gen2

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72223/#review219898
---




addons/models/3000-Cloud/3040-azure_adls_typedefs.json
Lines 414 (patched)


propagation turned ON by default? if account contains lot of container. 

account -> countainers and parent -> children


- Sarath Subramanian


On March 11, 2020, 1:23 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72223/
> ---
> 
> (Updated March 11, 2020, 1:23 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, keval bhatt, Nikhil Bonte, Nixon 
> Rodrigues, Pinal Shah, Sarath Subramanian, Sharmadha Sainath, Sidharth 
> Mishra, and Umesh Padashetty.
> 
> 
> Bugs: ATLAS-3660
> https://issues.apache.org/jira/browse/ATLAS-3660
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> added model for ADLS-Gen2
> 
> 
> Diffs
> -
> 
>   addons/models/3000-Cloud/3040-azure_adls_typedefs.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72223/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 72223: ATLAS-3660: added model for ADLS-Gen2

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72223/#review219897
---


Ship it!




Ship It!

- Sarath Subramanian


On March 11, 2020, 1:23 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72223/
> ---
> 
> (Updated March 11, 2020, 1:23 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, keval bhatt, Nikhil Bonte, Nixon 
> Rodrigues, Pinal Shah, Sarath Subramanian, Sharmadha Sainath, Sidharth 
> Mishra, and Umesh Padashetty.
> 
> 
> Bugs: ATLAS-3660
> https://issues.apache.org/jira/browse/ATLAS-3660
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> added model for ADLS-Gen2
> 
> 
> Diffs
> -
> 
>   addons/models/3000-Cloud/3040-azure_adls_typedefs.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72223/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 72224: ATLAS-3614: added configuration to specify default classification-propagation flag

[Madhan Neethiraj]

> On March 11, 2020, 8:03 p.m., Sarath Subramanian wrote:
> > intg/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java
> > Lines 107 (patched)
> > 
> >
> > can we reuse isPropagate() ? if its serialization issue consider 
> > changing all references of isPropagate() to getPropagate()

To be consistent with other classes in model, added get*() method. However, 
left existing isPropagate() method, as this might be referenced by clients.


- Madhan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72224/#review219895
---


On March 11, 2020, 7:05 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72224/
> ---
> 
> (Updated March 11, 2020, 7:05 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, keval bhatt, Mehul Parikh, Nixon 
> Rodrigues, Pinal Shah, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3614
> https://issues.apache.org/jira/browse/ATLAS-3614
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> - added configuration atlas.classification.propagation.default, which decides 
> propagation when 'propagate' flag is not specified during addition of a 
> classification
> - default value is 'true' i.e. added classficaion will be propagated when 
> 'propagate' flag is now specified
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java c5bf50dca 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> 0d20622f4 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  d3ba18f38 
> 
> 
> Diff: https://reviews.apache.org/r/72224/diff/1/
> 
> 
> Testing
> ---
> 
> verified manually that this the default specified in the configuration is 
> used while adding a classification if 'propage' flag is not specified
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 72224: ATLAS-3614: added configuration to specify default classification-propagation flag

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72224/#review219895
---


Fix it, then Ship it!





intg/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java
Lines 107 (patched)


can we reuse isPropagate() ? if its serialization issue consider changing 
all references of isPropagate() to getPropagate()


- Sarath Subramanian


On March 11, 2020, 12:05 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72224/
> ---
> 
> (Updated March 11, 2020, 12:05 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, keval bhatt, Mehul Parikh, Nixon 
> Rodrigues, Pinal Shah, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3614
> https://issues.apache.org/jira/browse/ATLAS-3614
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> - added configuration atlas.classification.propagation.default, which decides 
> propagation when 'propagate' flag is not specified during addition of a 
> classification
> - default value is 'true' i.e. added classficaion will be propagated when 
> 'propagate' flag is now specified
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java c5bf50dca 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> 0d20622f4 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  d3ba18f38 
> 
> 
> Diff: https://reviews.apache.org/r/72224/diff/1/
> 
> 
> Testing
> ---
> 
> verified manually that this the default specified in the configuration is 
> used while adding a classification if 'propage' flag is not specified
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 71482: ATLAS-3423:-Import Glossary Terms CSV into a Glossary

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71482/#review219893
---




repository/src/main/java/org/apache/atlas/util/FileUtils.java
Lines 78 (patched)


CSVReader (line #99) reads from Reader; give this, consider avoiding 
creation of temporary file here. Instead directly read from 
uploadedInputStream, like this:

fileData = FileUtils.readCSV(uploadedInputStream);

  
  public static List readCSV(InputStream inputStream) throws 
IOException {
List ret = new ArrayList<>()
  
try (CSVReader csvReader = new CSVReader(new 
InputStreamReader(inputStream))) {
  ...
}

return ret;
  }
  
Once this refactoring is done, please remove unused methods from FileUtils.


- Madhan Neethiraj


On March 11, 2020, 12:05 p.m., mayank jain wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71482/
> ---
> 
> (Updated March 11, 2020, 12:05 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, keval bhatt, Madhan Neethiraj, 
> Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3423
> https://issues.apache.org/jira/browse/ATLAS-3423
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch consists implementation for 2 end points first for template 
> download and other for csv file upload with term details also the Unit Test 
> cases for both the end points.
> 
> * The 1st endpoint {glossary/template} return template file this would be 
> type of format of data that shows how the data needs to be populated by user 
> in the file.
> 
> http://localhost:21000/api/atlas/v2/glossary/importHeaderRow
> 
> Template structure:-
> 
> GlossaryName, TermName, ShortDescription, LongDescription, Examples, 
> Abbreviation, Usage, AdditionalAttributes, TranslationTerms, ValidValuesFor, 
> Synonyms, ReplacedBy, ValidValues, ReplacementTerms, SeeAlso, 
> TranslatedTerms, IsA, Antonyms, Classifies, PreferredToTerms, PreferredTerms
> Fruits,Apple5,SD4,LD4,"EXAMPLE","ABBREVIATION","USAGE",,"Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4"
> 
> 
> * The 2nd endpoint {glossary/importGlossaryData} (file upload) would actually 
> parse the Data into AtlasObjects and further create the AtlasGlossaryTerms 
> inside Glossary.
> 
> curl -v -g POST -u admin:admin -H "Content-Type: multipart/form-data" -H 
> "Cache-Control: no-cache" -F file=@template_6.csv 
> "http://localhost:21000/api/atlas/v2/glossary/import
> 
> 
> Note:-
> 
> While populating the data in the  csv file each record should be maintained 
> in single Line (enter command within the record would result in parsing the 
> second line as a new record).
> 
> The downloaded template needs to be saved as whateverTheFileNameIs.csv 
> explicitly.
> 
> If the file is been succefully uploaded then the AtlasGlossaryTerm would be 
> returned or else List of Errors would returned for user to rectify them 
> further.
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 7c0fd56 
>   dashboardv2/gruntfile.js fef4e08 
>   dashboardv2/package-lock.json 7f25b57 
>   dashboardv2/package.json e90040e 
>   dashboardv2/public/css/scss/theme.scss aad0dfa 
>   dashboardv2/public/index.html.tpl 7cd86bd 
>   dashboardv2/public/js/main.js 41af465 
>   dashboardv2/public/js/templates/glossary/GlossaryLayoutView_tmpl.html 
> 1fa1e35 
>   dashboardv2/public/js/templates/glossary/ImportGlossaryLayoutView_tmpl.html 
> PRE-CREATION 
>   dashboardv2/public/js/utils/UrlLinks.js 6c67e8c 
>   dashboardv2/public/js/views/glossary/GlossaryLayoutView.js 9b386f3 
>   dashboardv2/public/js/views/glossary/ImportGlossaryLayoutView.js 
> PRE-CREATION 
>   dashboardv3/gruntfile.js f55ff0d 
>   dashboardv3/package-lock.json 3918ecc 
>   dashboardv3/package.json 5dc0510 
>   dashboardv3/public/css/scss/leftsidebar.scss bbdc5fb 
>   dashboardv3/public/css/scss/theme.scss 2b0c45d 
>   dashboardv3/public/index.html.tpl 1baeb12 
>   dashboardv3/public/js/main.js 96ef7ae 
>   dashboardv3/public/js/templates/glossary/ImportGlossaryLayoutView_tmpl.html 
> PRE-CREATION 
>   
> dashboardv3/public/js/templates/search/tree/GlossaryTreeLayoutView_tmpl.html 
> 83da9c5 
>   dashboardv3/public/js/utils/UrlLinks.js 95ca065 
>   dashboardv3/public/js/views/glossary/ImportGlossaryLayoutView.js 
> PRE-CREATION 
>   dashboardv3/public/js/views/search/tree/GlossaryTreeLayoutView.js 28c6a9e 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java c5bf50d 
>   

Review Request 72224: ATLAS-3614: added configuration to specify default classification-propagation flag

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72224/
---

Review request for atlas, Ashutosh Mestry, keval bhatt, Mehul Parikh, Nixon 
Rodrigues, Pinal Shah, Sarath Subramanian, and Sidharth Mishra.


Bugs: ATLAS-3614
https://issues.apache.org/jira/browse/ATLAS-3614


Repository: atlas


Description
---

- added configuration atlas.classification.propagation.default, which decides 
propagation when 'propagate' flag is not specified during addition of a 
classification
- default value is 'true' i.e. added classficaion will be propagated when 
'propagate' flag is now specified


Diffs
-

  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java c5bf50dca 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
0d20622f4 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 d3ba18f38 


Diff: https://reviews.apache.org/r/72224/diff/1/


Testing
---

verified manually that this the default specified in the configuration is used 
while adding a classification if 'propage' flag is not specified


Thanks,

Madhan Neethiraj

[jira] [Assigned] (ATLAS-3614) add a configuration to specify default classification-propagation flag

[Madhan Neethiraj (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Madhan Neethiraj reassigned ATLAS-3614:
---

Assignee: Madhan Neethiraj

> add a configuration to specify default classification-propagation flag
> --
>
> Key: ATLAS-3614
> URL: https://issues.apache.org/jira/browse/ATLAS-3614
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 1.0.0, 1.1.0, 1.2.0, 2.0.0
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
>
> Propagation of classification was introduced in Atlas 1.0 (ATLAS-2456). A 
> flag in the classification, named {{propagate}}, determines whether it needs 
> to be propagated or not. If this flag is not specified while adding a 
> classification (like in calls from earlier version API clients), Atlas uses 
> default value of 'true', which results in the added classification to be 
> propagated. It will help to add a configuration in Atlas to control the 
> default value for this flag - like 
> {{atlas.classification.propagation.default}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 71482: ATLAS-3423:-Import Glossary Terms CSV into a Glossary

[mayank jain]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71482/
---

(Updated March 11, 2020, 12:05 p.m.)


Review request for atlas, Ashutosh Mestry, keval bhatt, Madhan Neethiraj, Nixon 
Rodrigues, and Sarath Subramanian.


Changes
---

This potch addresses the review comments.


Bugs: ATLAS-3423
https://issues.apache.org/jira/browse/ATLAS-3423


Repository: atlas


Description
---

This patch consists implementation for 2 end points first for template download 
and other for csv file upload with term details also the Unit Test cases for 
both the end points.

* The 1st endpoint {glossary/template} return template file this would be type 
of format of data that shows how the data needs to be populated by user in the 
file.

http://localhost:21000/api/atlas/v2/glossary/importHeaderRow

Template structure:-

GlossaryName, TermName, ShortDescription, LongDescription, Examples, 
Abbreviation, Usage, AdditionalAttributes, TranslationTerms, ValidValuesFor, 
Synonyms, ReplacedBy, ValidValues, ReplacementTerms, SeeAlso, TranslatedTerms, 
IsA, Antonyms, Classifies, PreferredToTerms, PreferredTerms
Fruits,Apple5,SD4,LD4,"EXAMPLE","ABBREVIATION","USAGE",,"Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4"


* The 2nd endpoint {glossary/importGlossaryData} (file upload) would actually 
parse the Data into AtlasObjects and further create the AtlasGlossaryTerms 
inside Glossary.

curl -v -g POST -u admin:admin -H "Content-Type: multipart/form-data" -H 
"Cache-Control: no-cache" -F file=@template_6.csv 
"http://localhost:21000/api/atlas/v2/glossary/import


Note:-

While populating the data in the  csv file each record should be maintained in 
single Line (enter command within the record would result in parsing the second 
line as a new record).

The downloaded template needs to be saved as whateverTheFileNameIs.csv 
explicitly.

If the file is been succefully uploaded then the AtlasGlossaryTerm would be 
returned or else List of Errors would returned for user to rectify them further.


Diffs (updated)
-

  common/src/main/java/org/apache/atlas/repository/Constants.java 7c0fd56 
  dashboardv2/gruntfile.js fef4e08 
  dashboardv2/package-lock.json 7f25b57 
  dashboardv2/package.json e90040e 
  dashboardv2/public/css/scss/theme.scss aad0dfa 
  dashboardv2/public/index.html.tpl 7cd86bd 
  dashboardv2/public/js/main.js 41af465 
  dashboardv2/public/js/templates/glossary/GlossaryLayoutView_tmpl.html 1fa1e35 
  dashboardv2/public/js/templates/glossary/ImportGlossaryLayoutView_tmpl.html 
PRE-CREATION 
  dashboardv2/public/js/utils/UrlLinks.js 6c67e8c 
  dashboardv2/public/js/views/glossary/GlossaryLayoutView.js 9b386f3 
  dashboardv2/public/js/views/glossary/ImportGlossaryLayoutView.js PRE-CREATION 
  dashboardv3/gruntfile.js f55ff0d 
  dashboardv3/package-lock.json 3918ecc 
  dashboardv3/package.json 5dc0510 
  dashboardv3/public/css/scss/leftsidebar.scss bbdc5fb 
  dashboardv3/public/css/scss/theme.scss 2b0c45d 
  dashboardv3/public/index.html.tpl 1baeb12 
  dashboardv3/public/js/main.js 96ef7ae 
  dashboardv3/public/js/templates/glossary/ImportGlossaryLayoutView_tmpl.html 
PRE-CREATION 
  dashboardv3/public/js/templates/search/tree/GlossaryTreeLayoutView_tmpl.html 
83da9c5 
  dashboardv3/public/js/utils/UrlLinks.js 95ca065 
  dashboardv3/public/js/views/glossary/ImportGlossaryLayoutView.js PRE-CREATION 
  dashboardv3/public/js/views/search/tree/GlossaryTreeLayoutView.js 28c6a9e 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java c5bf50d 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 1bd2fd0 
  
intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasGlossaryHeader.java
 660514b 
  pom.xml a6da9b8 
  repository/pom.xml 802d587 
  repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
9229d2d 
  repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 
cdc3f07 
  repository/src/main/java/org/apache/atlas/glossary/GlossaryUtils.java 9625f94 
  repository/src/main/java/org/apache/atlas/util/FileUtils.java PRE-CREATION 
  repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java 
759dcdf 
  repository/src/test/resources/csvFiles/empty.csv PRE-CREATION 
  repository/src/test/resources/csvFiles/incorrectFile.csv PRE-CREATION 
  repository/src/test/resources/csvFiles/template_1.csv PRE-CREATION 
  repository/src/test/resources/excelFiles/template_1.xlsx PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java 151aa6b 


Diff: https://reviews.apache.org/r/71482/diff/14/

Changes: https://reviews.apache.org/r/71482/diff/13-14/


Testing
---

Tested both the endpoint with curl call.

Tested upload term csv with around 100 records 

Review Request 72223: ATLAS-3660: added model for ADLS-Gen2

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72223/
---

Review request for atlas, Ashutosh Mestry, keval bhatt, Nikhil Bonte, Nixon 
Rodrigues, Pinal Shah, Sarath Subramanian, Sharmadha Sainath, Sidharth Mishra, 
and Umesh Padashetty.


Bugs: ATLAS-3660
https://issues.apache.org/jira/browse/ATLAS-3660


Repository: atlas


Description
---

added model for ADLS-Gen2


Diffs
-

  addons/models/3000-Cloud/3040-azure_adls_typedefs.json PRE-CREATION 


Diff: https://reviews.apache.org/r/72223/diff/1/


Testing
---


Thanks,

Madhan Neethiraj

[jira] [Created] (ATLAS-3660) add models for ADLS-Gen2 types

[Madhan Neethiraj (Jira)]

Madhan Neethiraj created ATLAS-3660:
---

 Summary: add models for ADLS-Gen2 types
 Key: ATLAS-3660
 URL: https://issues.apache.org/jira/browse/ATLAS-3660
 Project: Atlas
  Issue Type: Improvement
  Components:  atlas-core
Affects Versions: 2.1.0
Reporter: Madhan Neethiraj
Assignee: Madhan Neethiraj


Add entity-types and relationships to model Azure Data Lake Store Gen2 
(ADLS-Gen2) entities in Atlas. Addition of the following will enable capturing 
of lineage with other datasets already present in Atlas:
- ADLS-Gen2 Blob
- ADLS-Gen2 Directory
- ADLS-Gen2 Container (filesystem)
- ADLS-Gen2 Account

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3618) Entities with no guid appears in search result

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17056705#comment-17056705
 ] 

ASF subversion and git services commented on ATLAS-3618:


Commit d58c0572f5079b837f37e7ebe630e33363f25bb2 in atlas's branch 
refs/heads/branch-2.0 from Pinal Shah
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=d58c057 ]

ATLAS-3618 Entities with no guid appears in search result

Signed-off-by: nixonrodrigues 
(cherry picked from commit 2608d061bb6762ba60c9360f0f527790ef6344a7)


> Entities with no guid appears in search result
> --
>
> Key: ATLAS-3618
> URL: https://issues.apache.org/jira/browse/ATLAS-3618
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.0.0
>Reporter: Pinal
>Assignee: Pinal
>Priority: Major
> Fix For: 2.1.0
>
> Attachments: no_guid_entity.png
>
>
> entities with no guid is listed in search result, when _ALL_ENTITY_TYPES is 
> searched.
> !no_guid_entity.png!
> Also, Entites with internal type is listed in search result



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3647) System attribute search : isIncomplete attribute has 1,null as values

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17056706#comment-17056706
 ] 

ASF subversion and git services commented on ATLAS-3647:


Commit d1f6585f1279f0574902dd559eb0f844f9a56488 in atlas's branch 
refs/heads/branch-2.0 from mayanknj
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=d1f6585 ]

ATLAS-3647: Fix System attribute search when IsIncomplete Attribute has 1,null 
as values.

Signed-off-by: nixonrodrigues 
(cherry picked from commit c6cac0301707e0d5ac983902a0c2aeefb148c872)


> System attribute search : isIncomplete attribute has 1,null as values
> -
>
> Key: ATLAS-3647
> URL: https://issues.apache.org/jira/browse/ATLAS-3647
> Project: Atlas
>  Issue Type: Bug
>Reporter: Mayank Jain
>Assignee: Mayank Jain
>Priority: Major
> Attachments: ATLAS-3467-2.patch
>
>
> In entity definition , 
>  isIncomplete is null when is entity is complete
>  isIncomplete is 1 when is entity is incomplete (shell/ghost entities)
> when isIncomplete = false is expected to return all complete entities 
> (non-shell entities) but since isIncomplete is null , it doesn't return any 
> entity.
> In system attributes search,
>  isIncomplete takes conditions =, != , not null , null with values true , 
> false.
> IMHO , it could have only = , != with true,false
> Hence issues are :
>  1. Backend : IsIncomplete to have value as 0 when the entity is complete.
>  2. UI : Search attribute for IsIncomplete to remove "is null" and "is not 
> null" checks



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3618) Entities with no guid appears in search result

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17056703#comment-17056703
 ] 

ASF subversion and git services commented on ATLAS-3618:


Commit 6ecad6e57be5f880c98fc7fa7179fe3e61226382 in atlas's branch 
refs/heads/master from Pinal Shah
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=6ecad6e ]

ATLAS-3618 : Entities with no guid appears in search result

Signed-off-by: nixonrodrigues 


> Entities with no guid appears in search result
> --
>
> Key: ATLAS-3618
> URL: https://issues.apache.org/jira/browse/ATLAS-3618
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.0.0
>Reporter: Pinal
>Assignee: Pinal
>Priority: Major
> Fix For: 2.1.0
>
> Attachments: no_guid_entity.png
>
>
> entities with no guid is listed in search result, when _ALL_ENTITY_TYPES is 
> searched.
> !no_guid_entity.png!
> Also, Entites with internal type is listed in search result



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3647) System attribute search : isIncomplete attribute has 1,null as values

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17056704#comment-17056704
 ] 

ASF subversion and git services commented on ATLAS-3647:


Commit c6cac0301707e0d5ac983902a0c2aeefb148c872 in atlas's branch 
refs/heads/master from mayanknj
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=c6cac03 ]

ATLAS-3647: Fix System attribute search when IsIncomplete Attribute has 1,null 
as values.

Signed-off-by: nixonrodrigues 


> System attribute search : isIncomplete attribute has 1,null as values
> -
>
> Key: ATLAS-3647
> URL: https://issues.apache.org/jira/browse/ATLAS-3647
> Project: Atlas
>  Issue Type: Bug
>Reporter: Mayank Jain
>Assignee: Mayank Jain
>Priority: Major
> Attachments: ATLAS-3467-2.patch
>
>
> In entity definition , 
>  isIncomplete is null when is entity is complete
>  isIncomplete is 1 when is entity is incomplete (shell/ghost entities)
> when isIncomplete = false is expected to return all complete entities 
> (non-shell entities) but since isIncomplete is null , it doesn't return any 
> entity.
> In system attributes search,
>  isIncomplete takes conditions =, != , not null , null with values true , 
> false.
> IMHO , it could have only = , != with true,false
> Hence issues are :
>  1. Backend : IsIncomplete to have value as 0 when the entity is complete.
>  2. UI : Search attribute for IsIncomplete to remove "is null" and "is not 
> null" checks



--
This message was sent by Atlassian Jira
(v8.3.4#803005)