Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints

2020-07-17 Thread Jyoti Singh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72638/
---

(Updated July 17, 2020, 11:20 p.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath 
Subramanian, and Sidharth Mishra.


Changes
---

Adding code review related change


Bugs: ATLAS-3875
https://issues.apache.org/jira/browse/ATLAS-3875


Repository: atlas


Description
---

There are many missing API endpoints in AtlasClientV2. This solution is adding 
functions corresponding to those missing APIs for the following Rest endpoints.

1. TypeRest
2. EntityRest
3. LineageRest
4. DiscoveryRest
5. GlossaryRest
6. RelationshipRest

This will enable users to test and integrate with APIs more effectively via 
AtlasCient.


Diffs (updated)
-

  client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 7b6d1d0f3 
  client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 
  webapp/pom.xml 3c55b4dd4 
  webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d 
  webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 
680028892 
  webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 
808f62354 
  
webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java
 cc883d615 
  webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java 
PRE-CREATION 
  webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java 
PRE-CREATION 
  
webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java
 331ea2c47 
  webapp/src/test/resources/csvFiles/template.csv PRE-CREATION 
  webapp/src/test/resources/csvFiles/template_metadata.csv PRE-CREATION 
  webapp/src/test/resources/json/search-parameters/attribute-filters.json 
PRE-CREATION 


Diff: https://reviews.apache.org/r/72638/diff/7/

Changes: https://reviews.apache.org/r/72638/diff/6-7/


Testing
---

IT has been added for newly created functions in AtlasClientV2.
Validated by running IT on local system.


Thanks,

Jyoti Singh

Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints

2020-07-17 Thread Jyoti Singh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72638/
---

(Updated July 17, 2020, 10:27 p.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath 
Subramanian, and Sidharth Mishra.


Changes
---

Adding code review related change


Bugs: ATLAS-3875
https://issues.apache.org/jira/browse/ATLAS-3875


Repository: atlas


Description
---

There are many missing API endpoints in AtlasClientV2. This solution is adding 
functions corresponding to those missing APIs for the following Rest endpoints.

1. TypeRest
2. EntityRest
3. LineageRest
4. DiscoveryRest
5. GlossaryRest
6. RelationshipRest

This will enable users to test and integrate with APIs more effectively via 
AtlasCient.


Diffs (updated)
-

  client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 7b6d1d0f3 
  client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 
  webapp/pom.xml 3c55b4dd4 
  webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d 
  webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 
680028892 
  webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 
808f62354 
  
webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java
 cc883d615 
  webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java 
PRE-CREATION 
  webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java 
PRE-CREATION 
  
webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java
 331ea2c47 
  webapp/src/test/resources/csvFiles/template.csv PRE-CREATION 
  webapp/src/test/resources/csvFiles/template_metadata.csv PRE-CREATION 
  webapp/src/test/resources/json/search-parameters/attribute-filters.json 
PRE-CREATION 


Diff: https://reviews.apache.org/r/72638/diff/6/

Changes: https://reviews.apache.org/r/72638/diff/5-6/


Testing
---

IT has been added for newly created functions in AtlasClientV2.
Validated by running IT on local system.


Thanks,

Jyoti Singh

Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints

2020-07-17 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72638/#review221258
---




client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 472 (patched)


- please remove 'final' for method parameters
- partialUpdateEntityAttrByGuid() => partialUpdateEntityByGuid()



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 490 (patched)


removeEntityClassifications() => removeEntityClassification()



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 495 (patched)


deleteClassificationByGuid() => removeEntityClassification()



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 539 (patched)


importBMAttributes() => bulkUpdateBusinessAttributes()



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 547 (patched)


entityGuid => typeName? Please review and update.



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 551 (patched)


entityGuid => typeName? Please review and update.



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 556 (patched)


exportDataForEntity() => getTemplateForBulkUpdateBusinessAttributes()



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 562 (patched)


Please remove 'final' from method parameters - line #562, #570.



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 629 (patched)


For consistency with other methods, I suggest to reorder the parameters:
 - typeName, attrName, attrValuePrefix, limit, offset



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 775 (patched)


- please remove 'atlas' prefix from variable names
   atlasGlossary => glossary
- please make sure to leave a space before '{'; here and rest of the patch



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 831 (patched)


sort => sortByAttribute
 - lines #831, #842, #853, #863, #873, #884, #894



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 936 (patched)


importFileData() => importGlossary()



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 953 (patched)


importData() => importGlossary()



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 958 (patched)


performImportData() => importGlossary()



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 972 (patched)


getTemplateByStream() => readStreamContents()



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 1175 (patched)


GET_TEMPLATE => GET_IMPORT_GLOSSARY_TEMPLATE



client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 1176 (patched)


IMPORT_DATA => IMPORT_GLOSSARY



client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java
Lines 685 (patched)


- hardcoded path "/src/test/resources/" doesn't look right. is this a temp 
location? or is the user expected have contents under this directory?
- if this is needed only for testing, consider moving this to test code.


- Madhan Neethiraj


On July 16, 2020, 3:17 a.m., Jyoti Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72638/
> ---
> 
> (Updated July 16, 2020, 3:17 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath 
> Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3875
> https://issues.apache.org/jira/browse/ATLAS-3875
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> There are many missing API endpoints in AtlasClientV2. This solution is 
> adding functions corresponding to those missing APIs for the following Rest 
> endpoints.
> 
> 1. Ty

Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints

2020-07-17 Thread Jyoti Singh 


> On July 16, 2020, 7 a.m., Sarath Subramanian wrote:
> > client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java
> > Lines 685 (patched)
> > 
> >
> > this method is not used anywhere. review and revert  if not needed.

Using it in AtlasClient


- Jyoti


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72638/#review221235
---


On July 16, 2020, 3:17 a.m., Jyoti Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72638/
> ---
> 
> (Updated July 16, 2020, 3:17 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath 
> Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3875
> https://issues.apache.org/jira/browse/ATLAS-3875
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> There are many missing API endpoints in AtlasClientV2. This solution is 
> adding functions corresponding to those missing APIs for the following Rest 
> endpoints.
> 
> 1. TypeRest
> 2. EntityRest
> 3. LineageRest
> 4. DiscoveryRest
> 5. GlossaryRest
> 6. RelationshipRest
> 
> This will enable users to test and integrate with APIs more effectively via 
> AtlasCient.
> 
> 
> Diffs
> -
> 
>   client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 
> 7b6d1d0f3 
>   client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 
>   webapp/pom.xml 3c55b4dd4 
>   webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d 
>   webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 
> 680028892 
>   webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 
> 808f62354 
>   
> webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java
>  cc883d615 
>   
> webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java 
> PRE-CREATION 
>   
> webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java 
> PRE-CREATION 
>   
> webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java
>  331ea2c47 
>   webapp/src/test/resources/json/search-parameters/attribute-filters.json 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72638/diff/5/
> 
> 
> Testing
> ---
> 
> IT has been added for newly created functions in AtlasClientV2.
> Validated by running IT on local system.
> 
> 
> Thanks,
> 
> Jyoti Singh
> 
>

Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints

2020-07-17 Thread Jyoti Singh 


> On July 16, 2020, 7 a.m., Sarath Subramanian wrote:
> > client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
> > Lines 525 (patched)
> > 
> >
> > removeBusinessAttributes => removeBusinessAttributesByName

I have renamed it to removeBusinessAttributes as suggested by Madhan


- Jyoti


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72638/#review221235
---


On July 16, 2020, 3:17 a.m., Jyoti Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72638/
> ---
> 
> (Updated July 16, 2020, 3:17 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath 
> Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3875
> https://issues.apache.org/jira/browse/ATLAS-3875
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> There are many missing API endpoints in AtlasClientV2. This solution is 
> adding functions corresponding to those missing APIs for the following Rest 
> endpoints.
> 
> 1. TypeRest
> 2. EntityRest
> 3. LineageRest
> 4. DiscoveryRest
> 5. GlossaryRest
> 6. RelationshipRest
> 
> This will enable users to test and integrate with APIs more effectively via 
> AtlasCient.
> 
> 
> Diffs
> -
> 
>   client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 
> 7b6d1d0f3 
>   client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 
>   webapp/pom.xml 3c55b4dd4 
>   webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d 
>   webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 
> 680028892 
>   webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 
> 808f62354 
>   
> webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java
>  cc883d615 
>   
> webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java 
> PRE-CREATION 
>   
> webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java 
> PRE-CREATION 
>   
> webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java
>  331ea2c47 
>   webapp/src/test/resources/json/search-parameters/attribute-filters.json 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72638/diff/5/
> 
> 
> Testing
> ---
> 
> IT has been added for newly created functions in AtlasClientV2.
> Validated by running IT on local system.
> 
> 
> Thanks,
> 
> Jyoti Singh
> 
>

Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints

2020-07-17 Thread Jyoti Singh 


> On July 16, 2020, 7 a.m., Sarath Subramanian wrote:
> > client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
> > Lines 570 (patched)
> > 
> >
> > getLineageInfo => getLineageInfoByUniqueAttributes

This is an existing method.


- Jyoti


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72638/#review221235
---


On July 16, 2020, 3:17 a.m., Jyoti Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72638/
> ---
> 
> (Updated July 16, 2020, 3:17 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath 
> Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3875
> https://issues.apache.org/jira/browse/ATLAS-3875
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> There are many missing API endpoints in AtlasClientV2. This solution is 
> adding functions corresponding to those missing APIs for the following Rest 
> endpoints.
> 
> 1. TypeRest
> 2. EntityRest
> 3. LineageRest
> 4. DiscoveryRest
> 5. GlossaryRest
> 6. RelationshipRest
> 
> This will enable users to test and integrate with APIs more effectively via 
> AtlasCient.
> 
> 
> Diffs
> -
> 
>   client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 
> 7b6d1d0f3 
>   client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 
>   webapp/pom.xml 3c55b4dd4 
>   webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d 
>   webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 
> 680028892 
>   webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 
> 808f62354 
>   
> webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java
>  cc883d615 
>   
> webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java 
> PRE-CREATION 
>   
> webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java 
> PRE-CREATION 
>   
> webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java
>  331ea2c47 
>   webapp/src/test/resources/json/search-parameters/attribute-filters.json 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72638/diff/5/
> 
> 
> Testing
> ---
> 
> IT has been added for newly created functions in AtlasClientV2.
> Validated by running IT on local system.
> 
> 
> Thanks,
> 
> Jyoti Singh
> 
>

Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints

2020-07-17 Thread Jyoti Singh 


> On July 16, 2020, 7 a.m., Sarath Subramanian wrote:
> > client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
> > Lines 543 (patched)
> > 
> >
> > setLabels => setLabelsByUniqueAttributes
> > addLabels => addLabelsByUniqueAttributes
> > removeLabels => removeLabelsByUniqueAttributes

I have renamed it from setLabelsByTypeName() => setLabels() as comments given 
by Madhan


- Jyoti


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72638/#review221235
---


On July 16, 2020, 3:17 a.m., Jyoti Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72638/
> ---
> 
> (Updated July 16, 2020, 3:17 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath 
> Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3875
> https://issues.apache.org/jira/browse/ATLAS-3875
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> There are many missing API endpoints in AtlasClientV2. This solution is 
> adding functions corresponding to those missing APIs for the following Rest 
> endpoints.
> 
> 1. TypeRest
> 2. EntityRest
> 3. LineageRest
> 4. DiscoveryRest
> 5. GlossaryRest
> 6. RelationshipRest
> 
> This will enable users to test and integrate with APIs more effectively via 
> AtlasCient.
> 
> 
> Diffs
> -
> 
>   client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 
> 7b6d1d0f3 
>   client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 
>   webapp/pom.xml 3c55b4dd4 
>   webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d 
>   webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 
> 680028892 
>   webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 
> 808f62354 
>   
> webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java
>  cc883d615 
>   
> webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java 
> PRE-CREATION 
>   
> webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java 
> PRE-CREATION 
>   
> webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java
>  331ea2c47 
>   webapp/src/test/resources/json/search-parameters/attribute-filters.json 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72638/diff/5/
> 
> 
> Testing
> ---
> 
> IT has been added for newly created functions in AtlasClientV2.
> Validated by running IT on local system.
> 
> 
> Thanks,
> 
> Jyoti Singh
> 
>

[jira] [Updated] (ATLAS-3894) UI: User is able to add and remove business metadata from deleted entities

2020-07-17 Thread Keval Bhatt (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3894:
---
Attachment: ATLAS-3894.patch

> UI: User is able to add and remove business metadata from deleted entities
> --
>
> Key: ATLAS-3894
> URL: https://issues.apache.org/jira/browse/ATLAS-3894
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3894.patch
>
>
> User should not allow to add and remove the business metadata from the 
> deleted entity.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3894) UI: User is able to add and remove business metadata from deleted entities

2020-07-17 Thread Keval Bhatt (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3894:
---
Description: User should not allow to add and remove the 

> UI: User is able to add and remove business metadata from deleted entities
> --
>
> Key: ATLAS-3894
> URL: https://issues.apache.org/jira/browse/ATLAS-3894
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
>
> User should not allow to add and remove the 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3894) UI: User is able to add and remove business metadata from deleted entities

2020-07-17 Thread Keval Bhatt (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3894:
---
Description: User should not allow to add and remove the business metadata 
from the deleted entity.  (was: User should not allow to add and remove the 
business metadata from deleted entity.)

> UI: User is able to add and remove business metadata from deleted entities
> --
>
> Key: ATLAS-3894
> URL: https://issues.apache.org/jira/browse/ATLAS-3894
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
>
> User should not allow to add and remove the business metadata from the 
> deleted entity.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3894) UI: User is able to add and remove business metadata from deleted entities

2020-07-17 Thread Keval Bhatt (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3894:
---
Description: User should not allow to add and remove the business metadata 
from deleted entity.  (was: User should not allow to add and remove the )

> UI: User is able to add and remove business metadata from deleted entities
> --
>
> Key: ATLAS-3894
> URL: https://issues.apache.org/jira/browse/ATLAS-3894
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
>
> User should not allow to add and remove the business metadata from deleted 
> entity.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3897) UI: Normalize list of propagated classifications

2020-07-17 Thread Keval Bhatt (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-3897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3897:
---
Attachment: ATLAS-3897-1.patch

> UI: Normalize list of propagated classifications
> 
>
> Key: ATLAS-3897
> URL: https://issues.apache.org/jira/browse/ATLAS-3897
> Project: Atlas
>  Issue Type: Bug
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3897-1.patch, ATLAS-3897.patch, Screen Shot 
> 2020-07-17 at 6.13.04 PM.png
>
>
> When an entity has multiple instances of the same propagated classification 
> (e.g. via join of Hive tables), the lineage view will show each of them in 
> the list. The result may be a long list of classifications with identical 
> entries They don't seem to offer any additional information.
> I propose we normalize the list (think _uniq_ command in unix)
>  
> !Screen Shot 2020-07-17 at 6.13.04 PM.png|width=593,height=359!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3897) UI: Normalize list of propagated classifications

2020-07-17 Thread Keval Bhatt (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-3897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3897:
---
Attachment: ATLAS-3897.patch

> UI: Normalize list of propagated classifications
> 
>
> Key: ATLAS-3897
> URL: https://issues.apache.org/jira/browse/ATLAS-3897
> Project: Atlas
>  Issue Type: Bug
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3897.patch, Screen Shot 2020-07-17 at 6.13.04 
> PM.png
>
>
> When an entity has multiple instances of the same propagated classification 
> (e.g. via join of Hive tables), the lineage view will show each of them in 
> the list. The result may be a long list of classifications with identical 
> entries They don't seem to offer any additional information.
> I propose we normalize the list (think _uniq_ command in unix)
>  
> !Screen Shot 2020-07-17 at 6.13.04 PM.png|width=593,height=359!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3897) UI: Normalize list of propagated classifications

2020-07-17 Thread Keval Bhatt (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-3897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3897:
---
Attachment: Screen Shot 2020-07-17 at 6.13.04 PM.png

> UI: Normalize list of propagated classifications
> 
>
> Key: ATLAS-3897
> URL: https://issues.apache.org/jira/browse/ATLAS-3897
> Project: Atlas
>  Issue Type: Bug
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: Screen Shot 2020-07-17 at 6.13.04 PM.png
>
>
> When an entity has multiple instances of the same propagated classification 
> (e.g. via join of Hive tables), the lineage view will show each of them in 
> the list. The result may be a long list of classifications with identical 
> entries They don't seem to offer any additional information.
> I propose we normalize the list (think _uniq_ command in unix)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3897) UI: Normalize list of propagated classifications

2020-07-17 Thread Keval Bhatt (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-3897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3897:
---
Description: 
When an entity has multiple instances of the same propagated classification 
(e.g. via join of Hive tables), the lineage view will show each of them in the 
list. The result may be a long list of classifications with identical entries 
They don't seem to offer any additional information.

I propose we normalize the list (think _uniq_ command in unix)

 

!Screen Shot 2020-07-17 at 6.13.04 PM.png!

  was:
When an entity has multiple instances of the same propagated classification 
(e.g. via join of Hive tables), the lineage view will show each of them in the 
list. The result may be a long list of classifications with identical entries 
They don't seem to offer any additional information.

I propose we normalize the list (think _uniq_ command in unix)


> UI: Normalize list of propagated classifications
> 
>
> Key: ATLAS-3897
> URL: https://issues.apache.org/jira/browse/ATLAS-3897
> Project: Atlas
>  Issue Type: Bug
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: Screen Shot 2020-07-17 at 6.13.04 PM.png
>
>
> When an entity has multiple instances of the same propagated classification 
> (e.g. via join of Hive tables), the lineage view will show each of them in 
> the list. The result may be a long list of classifications with identical 
> entries They don't seem to offer any additional information.
> I propose we normalize the list (think _uniq_ command in unix)
>  
> !Screen Shot 2020-07-17 at 6.13.04 PM.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3897) UI: Normalize list of propagated classifications

2020-07-17 Thread Keval Bhatt (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-3897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3897:
---
Description: 
When an entity has multiple instances of the same propagated classification 
(e.g. via join of Hive tables), the lineage view will show each of them in the 
list. The result may be a long list of classifications with identical entries 
They don't seem to offer any additional information.

I propose we normalize the list (think _uniq_ command in unix)

 

!Screen Shot 2020-07-17 at 6.13.04 PM.png|width=593,height=359!

  was:
When an entity has multiple instances of the same propagated classification 
(e.g. via join of Hive tables), the lineage view will show each of them in the 
list. The result may be a long list of classifications with identical entries 
They don't seem to offer any additional information.

I propose we normalize the list (think _uniq_ command in unix)

 

!Screen Shot 2020-07-17 at 6.13.04 PM.png!


> UI: Normalize list of propagated classifications
> 
>
> Key: ATLAS-3897
> URL: https://issues.apache.org/jira/browse/ATLAS-3897
> Project: Atlas
>  Issue Type: Bug
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: Screen Shot 2020-07-17 at 6.13.04 PM.png
>
>
> When an entity has multiple instances of the same propagated classification 
> (e.g. via join of Hive tables), the lineage view will show each of them in 
> the list. The result may be a long list of classifications with identical 
> entries They don't seem to offer any additional information.
> I propose we normalize the list (think _uniq_ command in unix)
>  
> !Screen Shot 2020-07-17 at 6.13.04 PM.png|width=593,height=359!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ATLAS-3897) UI: Normalize list of propagated classifications

2020-07-17 Thread Keval Bhatt (Jira) 
Keval Bhatt created ATLAS-3897:
--

 Summary: UI: Normalize list of propagated classifications
 Key: ATLAS-3897
 URL: https://issues.apache.org/jira/browse/ATLAS-3897
 Project: Atlas
  Issue Type: Bug
Reporter: Keval Bhatt
Assignee: Keval Bhatt
 Fix For: 3.0.0, 2.2.0


When an entity has multiple instances of the same propagated classification 
(e.g. via join of Hive tables), the lineage view will show each of them in the 
list. The result may be a long list of classifications with identical entries 
They don't seem to offer any additional information.

I propose we normalize the list (think _uniq_ command in unix)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [atlas] dggs123 closed pull request #104: Qualified name in terms and category headers

2020-07-17 Thread GitBox 


dggs123 closed pull request #104:
URL: https://github.com/apache/atlas/pull/104


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [atlas] dggs123 opened a new pull request #104: Qualified name in terms and category headers

2020-07-17 Thread GitBox 


dggs123 opened a new pull request #104:
URL: https://github.com/apache/atlas/pull/104


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org