Re: Review Request 74061: ATLAS-4637: Import/Export Feature for MetricsStat

2022-07-28 Thread Beakal Lemeneh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74061/
---

(Updated July 28, 2022, 3:36 p.m.)


Review request for atlas, Disha Talreja, Farhan Khan, Jayendra Parab, Prasad 
Pawar, Radhika Kundam, and Sidharth Mishra.


Bugs: ATLAS-4637
https://issues.apache.org/jira/browse/ATLAS-4637


Repository: atlas


Description
---

1. Add new attribute - importLabel - to MetricsStat. It contains the 
name/identity of the user who is importing MetricsStat file from one machine to 
another machine. For some Machine A, importLabel is set to "self" for the 
already existing MetricsStat that collects the metrics info in Machine A, and 
has not been imported from another machine.

2. Update metricsId to contain both importLabel and collectionTime to continue 
holding its property of being a unique attribute.

3. Update MetricsService to implement REST APIs in AdminResource to realize api 
calls of:
  1. Post MetricsStat with a specific importLabel obtained from a another 
machine.
  2. Get MetricsStat with a specific importLabel found in some machine with 
a boolean flag that returns metrics with specific details, or with minimal 
information.
  3. Delete all existing MetricsStats entities in a given machine.
  4. Delete all existing MetricsStats entities in a given machine with a 
specific importLabel.
  5. Get all importLabels.

6. Update MetricsService to include helper methods of:
  1. Get a persisted metricsStat by importLabel.
  2. Get a persisted metricsStat by collectionTime and importLabel.

7. UI support enabled.


Diffs (updated)
-

  
addons/models/-Area0/patches/007-base_model_add_importLabel_attribute.json 
PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsStat.java 
5a30cad06 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
 9924b2e4c 
  
repository/src/main/java/org/apache/atlas/repository/ogm/metrics/AtlasMetricsStatDTO.java
 6af935ebb 
  repository/src/main/java/org/apache/atlas/services/MetricsService.java 
9ec2cd2cb 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
b19095b48 


Diff: https://reviews.apache.org/r/74061/diff/3/

Changes: https://reviews.apache.org/r/74061/diff/2-3/


Testing
---


File Attachments


0001-MetricsImportExportUI-ApacheMasterBranch.patch
  
https://reviews.apache.org/media/uploaded/files/2022/07/26/0eabb428-689a-4d59-bbae-55b76495c131__0001-MetricsImportExportUI-ApacheMasterBranch.patch


Thanks,

Beakal Lemeneh



[jira] [Created] (ATLAS-4651) Upgrade Apache ZooKeeper to 3.8.0

2022-07-28 Thread chaitali borole (Jira)
chaitali borole created ATLAS-4651:
--

 Summary: Upgrade Apache ZooKeeper to 3.8.0
 Key: ATLAS-4651
 URL: https://issues.apache.org/jira/browse/ATLAS-4651
 Project: Atlas
  Issue Type: Improvement
Affects Versions: 3.0.0
Reporter: chaitali borole
Assignee: chaitali borole


Current version of zookeeper is 3.5.7



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: Review Request 74074: ATLAS-4650 : Upgrade Apache Commons BeanUtils to 1.9.4

2022-07-28 Thread chaitali

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74074/
---

(Updated July 28, 2022, 11:06 a.m.)


Review request for atlas, Jayendra Parab and Pinal Shah.


Bugs: ATLAS-4650
https://issues.apache.org/jira/browse/ATLAS-4650


Repository: atlas


Description
---

Currently Commons BeanUtils version is 1.9.2,1.9.3,1.8.3


Diffs
-

  addons/hbase-bridge/pom.xml a6ed51421 
  addons/hbase-testing-util/pom.xml 982e9c85e 
  pom.xml 1e32e45f3 


Diff: https://reviews.apache.org/r/74074/diff/1/


Testing
---

mvn clean -DskipTests package -Pdist,embedded-hbase-solr
mvn clean install -Drat.skip
atlas server running successfully


Thanks,

chaitali



[jira] [Commented] (ATLAS-4607) UI improvements to support Atlas Lineage fetch on-demand

2022-07-28 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17572285#comment-17572285
 ] 

ASF subversion and git services commented on ATLAS-4607:


Commit ec00895d6b887fa4f482680982c32d38a3c87caa in atlas's branch 
refs/heads/branch-2.0 from Farhan Khan
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=ec00895d6 ]

ATLAS-4607: UI improvements to support Atlas Lineage fetch on-demand

Signed-off-by: Pinal Shah 
(cherry picked from commit 6a1f2ef5c1cdcbc001c6ea74f5cbcfdf9c98f448)


> UI improvements to support Atlas Lineage fetch on-demand
> 
>
> Key: ATLAS-4607
> URL: https://issues.apache.org/jira/browse/ATLAS-4607
> Project: Atlas
>  Issue Type: Improvement
>  Components: atlas-webui
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Radhika Kundam
>Assignee: Farhan Khan
>Priority: Major
> Attachments: 
> 0001-ATLAS-4607-UI-improvements-to-support-Atlas-Lineage-.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (ATLAS-4607) UI improvements to support Atlas Lineage fetch on-demand

2022-07-28 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17572284#comment-17572284
 ] 

ASF subversion and git services commented on ATLAS-4607:


Commit 6a1f2ef5c1cdcbc001c6ea74f5cbcfdf9c98f448 in atlas's branch 
refs/heads/master from Farhan Khan
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=6a1f2ef5c ]

ATLAS-4607: UI improvements to support Atlas Lineage fetch on-demand

Signed-off-by: Pinal Shah 


> UI improvements to support Atlas Lineage fetch on-demand
> 
>
> Key: ATLAS-4607
> URL: https://issues.apache.org/jira/browse/ATLAS-4607
> Project: Atlas
>  Issue Type: Improvement
>  Components: atlas-webui
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Radhika Kundam
>Assignee: Farhan Khan
>Priority: Major
> Attachments: 
> 0001-ATLAS-4607-UI-improvements-to-support-Atlas-Lineage-.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: Review Request 74012: UI improvements to support Atlas Lineage fetch on-demand

2022-07-28 Thread Prasad Pawar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74012/#review224589
---


Ship it!




Ship It!

- Prasad Pawar


On July 28, 2022, 7:17 a.m., Farhan Khan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74012/
> ---
> 
> (Updated July 28, 2022, 7:17 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab and Prasad Pawar.
> 
> 
> Bugs: ATLAS-4607
> https://issues.apache.org/jira/browse/ATLAS-4607
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Atlas lineage for an entity returns all the entities connected in a single 
> call, this is expensive if lineage is long and has multi-level. Lineage API 
> response is large and UI fails to render the response.
> 
> Note: All the lineage files are sync with the latest changes with 
> lineageOnDemand changes.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/img/entity-icon/expandBtn.svg PRE-CREATION 
>   dashboardv2/public/js/collection/VLineageList.js bda649220 
>   dashboardv2/public/js/external_lib/atlas-lineage/dist/index.js b31ee4911 
>   dashboardv2/public/js/external_lib/atlas-lineage/dist/styles.css 2d7f9d9de 
>   dashboardv2/public/js/external_lib/atlas-lineage/src/Utils/DataUtils.js 
> 1255eb070 
>   dashboardv2/public/js/external_lib/atlas-lineage/src/Utils/LineageUtils.js 
> 448a95ae6 
>   dashboardv2/public/js/external_lib/atlas-lineage/src/index.js 3ceb3d90a 
>   dashboardv2/public/js/external_lib/atlas-lineage/src/styles/graph.scss 
> ab1e82df3 
>   dashboardv2/public/js/main.js 603e5ec3d 
>   dashboardv2/public/js/templates/graph/LineageLayoutView_tmpl.html 5f90b096e 
>   dashboardv2/public/js/utils/Globals.js c30f840f7 
>   dashboardv2/public/js/utils/Helper.js f211bd055 
>   dashboardv2/public/js/views/graph/LineageLayoutView.js e989c4719 
>   dashboardv3/public/img/entity-icon/expandBtn.svg PRE-CREATION 
>   dashboardv3/public/js/collection/VLineageList.js bda649220 
>   dashboardv3/public/js/external_lib/atlas-lineage/dist/index.js b31ee4911 
>   dashboardv3/public/js/external_lib/atlas-lineage/dist/styles.css 2d7f9d9de 
>   dashboardv3/public/js/external_lib/atlas-lineage/src/Utils/DataUtils.js 
> 1255eb070 
>   dashboardv3/public/js/external_lib/atlas-lineage/src/Utils/LineageUtils.js 
> 448a95ae6 
>   dashboardv3/public/js/external_lib/atlas-lineage/src/index.js 3ceb3d90a 
>   dashboardv3/public/js/external_lib/atlas-lineage/src/styles/graph.scss 
> ab1e82df3 
>   dashboardv3/public/js/main.js 008fbb222 
>   dashboardv3/public/js/templates/graph/LineageLayoutView_tmpl.html 5f90b096e 
>   dashboardv3/public/js/utils/Globals.js 5bbc71a69 
>   dashboardv3/public/js/utils/Helper.js a242098b1 
>   dashboardv3/public/js/views/graph/LineageLayoutView.js e989c4719 
> 
> 
> Diff: https://reviews.apache.org/r/74012/diff/2/
> 
> 
> Testing
> ---
> 
> Manually tested on the local for various possible scenarios.
> 
> 
> Thanks,
> 
> Farhan Khan
> 
>



Re: Review Request 74012: UI improvements to support Atlas Lineage fetch on-demand

2022-07-28 Thread Farhan Khan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74012/
---

(Updated July 28, 2022, 7:17 a.m.)


Review request for atlas, Jayendra Parab and Prasad Pawar.


Bugs: ATLAS-4607
https://issues.apache.org/jira/browse/ATLAS-4607


Repository: atlas


Description (updated)
---

Atlas lineage for an entity returns all the entities connected in a single 
call, this is expensive if lineage is long and has multi-level. Lineage API 
response is large and UI fails to render the response.

Note: All the lineage files are sync with the latest changes with 
lineageOnDemand changes.


Diffs
-

  dashboardv2/public/img/entity-icon/expandBtn.svg PRE-CREATION 
  dashboardv2/public/js/collection/VLineageList.js bda649220 
  dashboardv2/public/js/external_lib/atlas-lineage/dist/index.js b31ee4911 
  dashboardv2/public/js/external_lib/atlas-lineage/dist/styles.css 2d7f9d9de 
  dashboardv2/public/js/external_lib/atlas-lineage/src/Utils/DataUtils.js 
1255eb070 
  dashboardv2/public/js/external_lib/atlas-lineage/src/Utils/LineageUtils.js 
448a95ae6 
  dashboardv2/public/js/external_lib/atlas-lineage/src/index.js 3ceb3d90a 
  dashboardv2/public/js/external_lib/atlas-lineage/src/styles/graph.scss 
ab1e82df3 
  dashboardv2/public/js/main.js 603e5ec3d 
  dashboardv2/public/js/templates/graph/LineageLayoutView_tmpl.html 5f90b096e 
  dashboardv2/public/js/utils/Globals.js c30f840f7 
  dashboardv2/public/js/utils/Helper.js f211bd055 
  dashboardv2/public/js/views/graph/LineageLayoutView.js e989c4719 
  dashboardv3/public/img/entity-icon/expandBtn.svg PRE-CREATION 
  dashboardv3/public/js/collection/VLineageList.js bda649220 
  dashboardv3/public/js/external_lib/atlas-lineage/dist/index.js b31ee4911 
  dashboardv3/public/js/external_lib/atlas-lineage/dist/styles.css 2d7f9d9de 
  dashboardv3/public/js/external_lib/atlas-lineage/src/Utils/DataUtils.js 
1255eb070 
  dashboardv3/public/js/external_lib/atlas-lineage/src/Utils/LineageUtils.js 
448a95ae6 
  dashboardv3/public/js/external_lib/atlas-lineage/src/index.js 3ceb3d90a 
  dashboardv3/public/js/external_lib/atlas-lineage/src/styles/graph.scss 
ab1e82df3 
  dashboardv3/public/js/main.js 008fbb222 
  dashboardv3/public/js/templates/graph/LineageLayoutView_tmpl.html 5f90b096e 
  dashboardv3/public/js/utils/Globals.js 5bbc71a69 
  dashboardv3/public/js/utils/Helper.js a242098b1 
  dashboardv3/public/js/views/graph/LineageLayoutView.js e989c4719 


Diff: https://reviews.apache.org/r/74012/diff/2/


Testing
---

Manually tested on the local for various possible scenarios.


Thanks,

Farhan Khan



[jira] [Updated] (ATLAS-4606) Improve Atlas Lineage API performance (fetch on-demand)

2022-07-28 Thread Radhika Kundam (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radhika Kundam updated ATLAS-4606:
--
Fix Version/s: 2.3.0
   (was: 2.2.0)

> Improve Atlas Lineage API performance (fetch on-demand)
> ---
>
> Key: ATLAS-4606
> URL: https://issues.apache.org/jira/browse/ATLAS-4606
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Reporter: Radhika Kundam
>Assignee: Radhika Kundam
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> Atlas lineage for an entity returns all the entities connected in a single 
> call, this is expensive if lineage is long and has multi-level. Lineage API 
> response is large and UI fails to render the response. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (ATLAS-4606) Improve Atlas Lineage API performance (fetch on-demand)

2022-07-28 Thread Radhika Kundam (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radhika Kundam resolved ATLAS-4606.
---
Fix Version/s: 3.0.0
   2.2.0
   Resolution: Fixed

> Improve Atlas Lineage API performance (fetch on-demand)
> ---
>
> Key: ATLAS-4606
> URL: https://issues.apache.org/jira/browse/ATLAS-4606
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Reporter: Radhika Kundam
>Assignee: Radhika Kundam
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
>
> Atlas lineage for an entity returns all the entities connected in a single 
> call, this is expensive if lineage is long and has multi-level. Lineage API 
> response is large and UI fails to render the response. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (ATLAS-4606) Improve Atlas Lineage API performance (fetch on-demand)

2022-07-28 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17572245#comment-17572245
 ] 

ASF subversion and git services commented on ATLAS-4606:


Commit 33d16202e5d67976eb71524c296a83ea10ae1808 in atlas's branch 
refs/heads/branch-2.0 from Radhika Kundam
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=33d16202e ]

ATLAS-4606: Improve Atlas Lineage API performance (fetch on-demand)

Signed-off-by: radhikakundam 
(cherry picked from commit 7ba5f191c5701f6fa850d18895951df6d20ab812)


> Improve Atlas Lineage API performance (fetch on-demand)
> ---
>
> Key: ATLAS-4606
> URL: https://issues.apache.org/jira/browse/ATLAS-4606
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Reporter: Radhika Kundam
>Assignee: Radhika Kundam
>Priority: Major
>
> Atlas lineage for an entity returns all the entities connected in a single 
> call, this is expensive if lineage is long and has multi-level. Lineage API 
> response is large and UI fails to render the response. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (ATLAS-4606) Improve Atlas Lineage API performance (fetch on-demand)

2022-07-28 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17572244#comment-17572244
 ] 

ASF subversion and git services commented on ATLAS-4606:


Commit 7ba5f191c5701f6fa850d18895951df6d20ab812 in atlas's branch 
refs/heads/master from Radhika Kundam
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=7ba5f191c ]

ATLAS-4606: Improve Atlas Lineage API performance (fetch on-demand)

Signed-off-by: radhikakundam 


> Improve Atlas Lineage API performance (fetch on-demand)
> ---
>
> Key: ATLAS-4606
> URL: https://issues.apache.org/jira/browse/ATLAS-4606
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Reporter: Radhika Kundam
>Assignee: Radhika Kundam
>Priority: Major
>
> Atlas lineage for an entity returns all the entities connected in a single 
> call, this is expensive if lineage is long and has multi-level. Lineage API 
> response is large and UI fails to render the response. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)