Re: Review Request 74093: ATLAS-4662 : Upgrade POI to 5.2.2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74093/#review224638 --- Ship it! Ship It! - Ashutosh Mestry On Aug. 23, 2022, 7:43 a.m., chaitali wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74093/ > --- > > (Updated Aug. 23, 2022, 7:43 a.m.) > > > Review request for atlas, Jayendra Parab and Pinal Shah. > > > Bugs: ATLAS-4662 > https://issues.apache.org/jira/browse/ATLAS-4662 > > > Repository: atlas > > > Description > --- > > POI and POI-ooxml version is 4.1.1 > > > Diffs > - > > pom.xml 548382446 > > > Diff: https://reviews.apache.org/r/74093/diff/1/ > > > Testing > --- > > mvn clean install > apache server running fine > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1198/console > > > Thanks, > > chaitali > >
[jira] [Commented] (ATLAS-4662) Upgrade POI to 5.2.2
[ https://issues.apache.org/jira/browse/ATLAS-4662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583548#comment-17583548 ] ASF subversion and git services commented on ATLAS-4662: Commit 71b6bf783bf7bb999ea30965f7e9d381803f7f28 in atlas's branch refs/heads/branch-2.0 from chaitali borole [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=71b6bf783 ] ATLAS-4662 : Upgrade POI to 5.2.2 Signed-off-by: Pinal Shah (cherry picked from commit 7ee310bd34fc7cbe7899d42f4dc563ef676cd046) > Upgrade POI to 5.2.2 > > > Key: ATLAS-4662 > URL: https://issues.apache.org/jira/browse/ATLAS-4662 > Project: Atlas > Issue Type: Improvement >Affects Versions: 2.0.0, 3.0.0 >Reporter: chaitali borole >Assignee: chaitali borole >Priority: Major > > POI and POI-ooxml version is 4.1.1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ATLAS-4662) Upgrade POI to 5.2.2
[ https://issues.apache.org/jira/browse/ATLAS-4662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583545#comment-17583545 ] ASF subversion and git services commented on ATLAS-4662: Commit 7ee310bd34fc7cbe7899d42f4dc563ef676cd046 in atlas's branch refs/heads/master from chaitali borole [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=7ee310bd3 ] ATLAS-4662 : Upgrade POI to 5.2.2 Signed-off-by: Pinal Shah > Upgrade POI to 5.2.2 > > > Key: ATLAS-4662 > URL: https://issues.apache.org/jira/browse/ATLAS-4662 > Project: Atlas > Issue Type: Improvement >Affects Versions: 2.0.0, 3.0.0 >Reporter: chaitali borole >Assignee: chaitali borole >Priority: Major > > POI and POI-ooxml version is 4.1.1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ATLAS-4611) Atlas UI: Add text-editor for string attribute value of Business Metadata and for "description" field while creating Classification and Business Metadata.
[ https://issues.apache.org/jira/browse/ATLAS-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Farhan Khan updated ATLAS-4611: --- Attachment: 0001-ATLAS-4611-UI-Add-text-editor-for-string-attribute-v.patch > Atlas UI: Add text-editor for string attribute value of Business Metadata and > for "description" field while creating Classification and Business Metadata. > -- > > Key: ATLAS-4611 > URL: https://issues.apache.org/jira/browse/ATLAS-4611 > Project: Atlas > Issue Type: Improvement >Reporter: Prasad P. Pawar >Assignee: Farhan Khan >Priority: Major > Attachments: > 0001-ATLAS-4611-UI-Add-text-editor-for-string-attribute-v.patch > > > 1) Business Metadata ( Entity Detail Page) > String attribute value should have text editor. > 2) Classification and Business Metadata > The "Description" field should have text editor as it has been implemented > for the Glossary section. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ATLAS-4611) Atlas UI: Add text-editor for string attribute value of Business Metadata and for "description" field while creating Classification and Business Metadata.
[ https://issues.apache.org/jira/browse/ATLAS-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Farhan Khan updated ATLAS-4611: --- Attachment: (was: 0001-ATLAS-4611-UI-Add-text-editor-for-string-attribute-v.patch) > Atlas UI: Add text-editor for string attribute value of Business Metadata and > for "description" field while creating Classification and Business Metadata. > -- > > Key: ATLAS-4611 > URL: https://issues.apache.org/jira/browse/ATLAS-4611 > Project: Atlas > Issue Type: Improvement >Reporter: Prasad P. Pawar >Assignee: Farhan Khan >Priority: Major > Attachments: > 0001-ATLAS-4611-UI-Add-text-editor-for-string-attribute-v.patch > > > 1) Business Metadata ( Entity Detail Page) > String attribute value should have text editor. > 2) Classification and Business Metadata > The "Description" field should have text editor as it has been implemented > for the Glossary section. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ATLAS-4611) Atlas UI: Add text-editor for string attribute value of Business Metadata and for "description" field while creating Classification and Business Metadata.
[ https://issues.apache.org/jira/browse/ATLAS-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583492#comment-17583492 ] Farhan Khan commented on ATLAS-4611: The patch has been updated, please review the same. > Atlas UI: Add text-editor for string attribute value of Business Metadata and > for "description" field while creating Classification and Business Metadata. > -- > > Key: ATLAS-4611 > URL: https://issues.apache.org/jira/browse/ATLAS-4611 > Project: Atlas > Issue Type: Improvement >Reporter: Prasad P. Pawar >Assignee: Farhan Khan >Priority: Major > Attachments: > 0001-ATLAS-4611-UI-Add-text-editor-for-string-attribute-v.patch > > > 1) Business Metadata ( Entity Detail Page) > String attribute value should have text editor. > 2) Classification and Business Metadata > The "Description" field should have text editor as it has been implemented > for the Glossary section. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ATLAS-4613) UI: After selecting checkboxes from Term page and then switching UI, page gets stuck in endless loading state.
[ https://issues.apache.org/jira/browse/ATLAS-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583488#comment-17583488 ] Rahul Kurup commented on ATLAS-4613: +1 > UI: After selecting checkboxes from Term page and then switching UI, page > gets stuck in endless loading state. > -- > > Key: ATLAS-4613 > URL: https://issues.apache.org/jira/browse/ATLAS-4613 > Project: Atlas > Issue Type: Sub-task >Reporter: Rahul Kurup >Assignee: Farhan Khan >Priority: Minor > Attachments: > 0001-ATLAS-4613-UI-After-selecting-checkboxes-from-Term-p.patch > > > Steps: > # In classic UI, Create a term > # Assign a term to any entity > # Go to the term page > # Mark all the checkboxes > # Perform switch to new UI > You will notice that the page gets stuck in endless loading accompanied by an > error : "expected type AtlasGlossaryCategory; found AtlasGlossaryTerm". -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ATLAS-4611) Atlas UI: Add text-editor for string attribute value of Business Metadata and for "description" field while creating Classification and Business Metadata.
[ https://issues.apache.org/jira/browse/ATLAS-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Farhan Khan updated ATLAS-4611: --- Attachment: (was: 0001-ATLAS-4611-UI-Add-text-editor-for-string-attribute-v.patch) > Atlas UI: Add text-editor for string attribute value of Business Metadata and > for "description" field while creating Classification and Business Metadata. > -- > > Key: ATLAS-4611 > URL: https://issues.apache.org/jira/browse/ATLAS-4611 > Project: Atlas > Issue Type: Improvement >Reporter: Prasad P. Pawar >Assignee: Farhan Khan >Priority: Major > Attachments: > 0001-ATLAS-4611-UI-Add-text-editor-for-string-attribute-v.patch > > > 1) Business Metadata ( Entity Detail Page) > String attribute value should have text editor. > 2) Classification and Business Metadata > The "Description" field should have text editor as it has been implemented > for the Glossary section. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ATLAS-4611) Atlas UI: Add text-editor for string attribute value of Business Metadata and for "description" field while creating Classification and Business Metadata.
[ https://issues.apache.org/jira/browse/ATLAS-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Farhan Khan updated ATLAS-4611: --- Attachment: 0001-ATLAS-4611-UI-Add-text-editor-for-string-attribute-v.patch > Atlas UI: Add text-editor for string attribute value of Business Metadata and > for "description" field while creating Classification and Business Metadata. > -- > > Key: ATLAS-4611 > URL: https://issues.apache.org/jira/browse/ATLAS-4611 > Project: Atlas > Issue Type: Improvement >Reporter: Prasad P. Pawar >Assignee: Farhan Khan >Priority: Major > Attachments: > 0001-ATLAS-4611-UI-Add-text-editor-for-string-attribute-v.patch > > > 1) Business Metadata ( Entity Detail Page) > String attribute value should have text editor. > 2) Classification and Business Metadata > The "Description" field should have text editor as it has been implemented > for the Glossary section. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: Review Request 74093: ATLAS-4662 : Upgrade POI to 5.2.2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74093/#review224637 --- Ship it! Ship It! - Jayendra Parab On Aug. 23, 2022, 7:43 a.m., chaitali wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74093/ > --- > > (Updated Aug. 23, 2022, 7:43 a.m.) > > > Review request for atlas, Jayendra Parab and Pinal Shah. > > > Bugs: ATLAS-4662 > https://issues.apache.org/jira/browse/ATLAS-4662 > > > Repository: atlas > > > Description > --- > > POI and POI-ooxml version is 4.1.1 > > > Diffs > - > > pom.xml 548382446 > > > Diff: https://reviews.apache.org/r/74093/diff/1/ > > > Testing > --- > > mvn clean install > apache server running fine > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1198/console > > > Thanks, > > chaitali > >
[jira] [Assigned] (ATLAS-4620) Remove EmbeddedKafkaServer from compile dependencies in Atlas notification module
[ https://issues.apache.org/jira/browse/ATLAS-4620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrik Márton reassigned ATLAS-4620: Assignee: Patrik Márton > Remove EmbeddedKafkaServer from compile dependencies in Atlas notification > module > - > > Key: ATLAS-4620 > URL: https://issues.apache.org/jira/browse/ATLAS-4620 > Project: Atlas > Issue Type: Bug > Components: atlas-core >Reporter: Patrik Márton >Assignee: Patrik Márton >Priority: Major > > Goal is to break the strong coupling between Atlas components and Kafka. > These dependencies include using server side libraries of Kafka (this couples > the Scala version and other non-public interfaces of Kafka). Any code using > server side libraries of Kafka should be refactored. > The notification module uses an EmbeddedKafkaServer which brings in the core > kafka dependency. Based on the usage in the source, it is only used during > testing, but pulled in as a compile dependency. > If there is a way to avoid using this embedded kafka server for other reasons > (eg. development), this can be moved to the test folder and pulled in as a > test scope dependency. > [https://github.com/apache/atlas/blob/master/notification/src/main/java/org/apache/atlas/kafka/EmbeddedKafkaServer.java] -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: Review Request 74093: ATLAS-4662 : Upgrade POI to 5.2.2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74093/ --- (Updated Aug. 23, 2022, 7:43 a.m.) Review request for atlas, Jayendra Parab and Pinal Shah. Bugs: ATLAS-4662 https://issues.apache.org/jira/browse/ATLAS-4662 Repository: atlas Description --- POI and POI-ooxml version is 4.1.1 Diffs - pom.xml 548382446 Diff: https://reviews.apache.org/r/74093/diff/1/ Testing (updated) --- mvn clean install apache server running fine https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1198/console Thanks, chaitali
Review Request 74093: ATLAS-4662 : Upgrade POI to 5.2.2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74093/ --- Review request for atlas, Jayendra Parab and Pinal Shah. Bugs: ATLAS-4662 https://issues.apache.org/jira/browse/ATLAS-4662 Repository: atlas Description --- POI and POI-ooxml version is 4.1.1 Diffs - pom.xml 548382446 Diff: https://reviews.apache.org/r/74093/diff/1/ Testing --- mvn clean install apache server running fine Thanks, chaitali
