[jira] [Commented] (ATLAS-4660) UI: Deleting businesss metadata attribute values with spaces in their key names results in unexpected behaviour

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602130#comment-17602130
 ] 

ASF subversion and git services commented on ATLAS-4660:


Commit c7496ffcd8122fa0f5ecd47f962b7b71fd7f3c52 in atlas's branch 
refs/heads/branch-2.0 from Farhan Khan
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=c7496ffcd ]

ATLAS-4660 : (UI)Deleting businesss metadata attribute values with spaces in 
their key names results in unexpected behaviour

Signed-off-by: Pinal Shah 
(cherry picked from commit 18aa87c0cffbe8e32483f8b88aae0cd9a11d2476)


> UI: Deleting businesss metadata attribute values with spaces in their key 
> names results in unexpected behaviour
> ---
>
> Key: ATLAS-4660
> URL: https://issues.apache.org/jira/browse/ATLAS-4660
> Project: Atlas
>  Issue Type: Bug
>Reporter: Rahul Kurup
>Assignee: Farhan Khan
>Priority: Minor
> Attachments: 
> 0001-ATLAS-4660-UI-Deleting-businesss-metadata-attribute-.patch
>
>
> # Create a business metadata with an attribute such that it has a space in 
> its name. (eg: 'testBusinessMetadata' with attribute 'test attribute1'). 
> Create at least two more attributes for the business metadata.
>  # Go to the entity details page for that entity with these business metadata 
> attributes and assign values to the above attributes.
>  # After the page refreshes, pick that attribute with the space with its name 
> and delete its value.
> You will notice that on clicking the delete button for the first time, 
> nothing happens. When the delete button is clicked again,then all of the 
> other assigned values are wiped out along with the targeted attribute.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (ATLAS-4660) UI: Deleting businesss metadata attribute values with spaces in their key names results in unexpected behaviour

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602129#comment-17602129
 ] 

ASF subversion and git services commented on ATLAS-4660:


Commit 18aa87c0cffbe8e32483f8b88aae0cd9a11d2476 in atlas's branch 
refs/heads/master from Farhan Khan
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=18aa87c0c ]

ATLAS-4660 : (UI)Deleting businesss metadata attribute values with spaces in 
their key names results in unexpected behaviour

Signed-off-by: Pinal Shah 


> UI: Deleting businesss metadata attribute values with spaces in their key 
> names results in unexpected behaviour
> ---
>
> Key: ATLAS-4660
> URL: https://issues.apache.org/jira/browse/ATLAS-4660
> Project: Atlas
>  Issue Type: Bug
>Reporter: Rahul Kurup
>Assignee: Farhan Khan
>Priority: Minor
> Attachments: 
> 0001-ATLAS-4660-UI-Deleting-businesss-metadata-attribute-.patch
>
>
> # Create a business metadata with an attribute such that it has a space in 
> its name. (eg: 'testBusinessMetadata' with attribute 'test attribute1'). 
> Create at least two more attributes for the business metadata.
>  # Go to the entity details page for that entity with these business metadata 
> attributes and assign values to the above attributes.
>  # After the page refreshes, pick that attribute with the space with its name 
> and delete its value.
> You will notice that on clicking the delete button for the first time, 
> nothing happens. When the delete button is clicked again,then all of the 
> other assigned values are wiped out along with the targeted attribute.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: Review Request 74107: UI: Deleting businesss metadata attribute values with spaces in their key names results in unexpected behaviour.

[Prasad Pawar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74107/#review224658
---


Ship it!




Ship It!

- Prasad Pawar


On Sept. 9, 2022, 4:15 a.m., Farhan Khan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74107/
> ---
> 
> (Updated Sept. 9, 2022, 4:15 a.m.)
> 
> 
> Review request for atlas and Prasad Pawar.
> 
> 
> Bugs: ATLAS-4660
> https://issues.apache.org/jira/browse/ATLAS-4660
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Create a business metadata with an attribute such that it has a space in its 
> name. (eg: 'testBusinessMetadata' with attribute 'test attribute1'). Create 
> at least two more attributes for the business metadata.
> Go to the entity details page for that entity with these business metadata 
> attributes and assign values to the above attributes.
> After the page refreshes, pick that attribute with the space with its name 
> and delete its value.
> You will notice that on clicking the delete button for the first time, 
> nothing happens. When the delete button is clicked again,then all of the 
> other assigned values are wiped out along with the targeted attribute.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/views/entity/EntityBusinessMetaDataItemView.js 
> ff285068d 
>   dashboardv3/public/js/views/entity/EntityBusinessMetaDataItemView.js 
> 913cc0faf 
> 
> 
> Diff: https://reviews.apache.org/r/74107/diff/1/
> 
> 
> Testing
> ---
> 
> Tested manually on both the UI's for the above mentioned scenario.
> 
> 
> Thanks,
> 
> Farhan Khan
> 
>

Review Request 74107: UI: Deleting businesss metadata attribute values with spaces in their key names results in unexpected behaviour.

[Farhan Khan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74107/
---

Review request for atlas and Prasad Pawar.


Bugs: ATLAS-4660
https://issues.apache.org/jira/browse/ATLAS-4660


Repository: atlas


Description
---

Create a business metadata with an attribute such that it has a space in its 
name. (eg: 'testBusinessMetadata' with attribute 'test attribute1'). Create at 
least two more attributes for the business metadata.
Go to the entity details page for that entity with these business metadata 
attributes and assign values to the above attributes.
After the page refreshes, pick that attribute with the space with its name and 
delete its value.
You will notice that on clicking the delete button for the first time, nothing 
happens. When the delete button is clicked again,then all of the other assigned 
values are wiped out along with the targeted attribute.


Diffs
-

  dashboardv2/public/js/views/entity/EntityBusinessMetaDataItemView.js 
ff285068d 
  dashboardv3/public/js/views/entity/EntityBusinessMetaDataItemView.js 
913cc0faf 


Diff: https://reviews.apache.org/r/74107/diff/1/


Testing
---

Tested manually on both the UI's for the above mentioned scenario.


Thanks,

Farhan Khan

Re: Review Request 74103: ATLAS-4669 : Atlas - Upgrade Junit to 4.13.2

[Pinal Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74103/#review224655
---


Ship it!




Ship It!

- Pinal Shah


On Sept. 8, 2022, 11:27 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74103/
> ---
> 
> (Updated Sept. 8, 2022, 11:27 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab and Pinal Shah.
> 
> 
> Bugs: ATLAS-4669
> https://issues.apache.org/jira/browse/ATLAS-4669
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> currently Junit version is 4.13.1
> 
> 
> Diffs
> -
> 
>   addons/hbase-bridge/pom.xml a6ed51421 
>   pom.xml a5d4b1f9e 
> 
> 
> Diff: https://reviews.apache.org/r/74103/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean -DskipTests package -Pdist,embedded-hbase-solr
> mvn clean install -DskipTests -Drat.skip
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1210/consoleFull
> 
> 
> Thanks,
> 
> chaitali
> 
>

[jira] [Commented] (ATLAS-4669) Atlas - Upgrade Junit to 4.13.2

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17601804#comment-17601804
 ] 

ASF subversion and git services commented on ATLAS-4669:


Commit 83e7d6279c884e479aaaebac8e25f4d68c778a6f in atlas's branch 
refs/heads/branch-2.0 from chaitali borole
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=83e7d6279 ]

ATLAS-4669 : Upgrade Junit to 4.13.2

Signed-off-by: Pinal Shah 
(cherry picked from commit 12fe912180ed9d98734a1ed1583c3e3f5f615b28)


> Atlas - Upgrade Junit to 4.13.2
> ---
>
> Key: ATLAS-4669
> URL: https://issues.apache.org/jira/browse/ATLAS-4669
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 2.0.0, 3.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
> Fix For: 2.0.0, 3.0.0
>
>
> currently Junit version is 4.13.1



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (ATLAS-4669) Atlas - Upgrade Junit to 4.13.2

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17601803#comment-17601803
 ] 

ASF subversion and git services commented on ATLAS-4669:


Commit 12fe912180ed9d98734a1ed1583c3e3f5f615b28 in atlas's branch 
refs/heads/master from chaitali borole
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=12fe91218 ]

ATLAS-4669 : Upgrade Junit to 4.13.2

Signed-off-by: Pinal Shah 


> Atlas - Upgrade Junit to 4.13.2
> ---
>
> Key: ATLAS-4669
> URL: https://issues.apache.org/jira/browse/ATLAS-4669
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 2.0.0, 3.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
> Fix For: 2.0.0, 3.0.0
>
>
> currently Junit version is 4.13.1



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: Review Request 74103: ATLAS-4669 : Atlas - Upgrade Junit to 4.13.2

[chaitali]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74103/
---

(Updated Sept. 8, 2022, 11:27 a.m.)


Review request for atlas, Jayendra Parab and Pinal Shah.


Bugs: ATLAS-4669
https://issues.apache.org/jira/browse/ATLAS-4669


Repository: atlas


Description
---

currently Junit version is 4.13.1


Diffs (updated)
-

  addons/hbase-bridge/pom.xml a6ed51421 
  pom.xml a5d4b1f9e 


Diff: https://reviews.apache.org/r/74103/diff/3/

Changes: https://reviews.apache.org/r/74103/diff/2-3/


Testing
---

mvn clean -DskipTests package -Pdist,embedded-hbase-solr
mvn clean install -DskipTests -Drat.skip
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1210/consoleFull


Thanks,

chaitali

Re: Review Request 74103: ATLAS-4669 : Atlas - Upgrade Junit to 4.13.2

[Pinal Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74103/#review224654
---




addons/hbase-bridge/pom.xml
Line 168 (original), 168 (patched)


Can we add placeholder of junit.version instead of 4.13.2?


- Pinal Shah


On Sept. 8, 2022, 10:01 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74103/
> ---
> 
> (Updated Sept. 8, 2022, 10:01 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab and Pinal Shah.
> 
> 
> Bugs: ATLAS-4669
> https://issues.apache.org/jira/browse/ATLAS-4669
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> currently Junit version is 4.13.1
> 
> 
> Diffs
> -
> 
>   addons/hbase-bridge/pom.xml a6ed51421 
>   pom.xml a5d4b1f9e 
> 
> 
> Diff: https://reviews.apache.org/r/74103/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean -DskipTests package -Pdist,embedded-hbase-solr
> mvn clean install -DskipTests -Drat.skip
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1210/consoleFull
> 
> 
> Thanks,
> 
> chaitali
> 
>

Re: Review Request 74103: ATLAS-4669 : Atlas - Upgrade Junit to 4.13.2

[Jayendra Parab]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74103/#review224653
---


Ship it!




Ship It!

- Jayendra Parab


On Sept. 8, 2022, 10:01 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74103/
> ---
> 
> (Updated Sept. 8, 2022, 10:01 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab and Pinal Shah.
> 
> 
> Bugs: ATLAS-4669
> https://issues.apache.org/jira/browse/ATLAS-4669
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> currently Junit version is 4.13.1
> 
> 
> Diffs
> -
> 
>   addons/hbase-bridge/pom.xml a6ed51421 
>   pom.xml a5d4b1f9e 
> 
> 
> Diff: https://reviews.apache.org/r/74103/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean -DskipTests package -Pdist,embedded-hbase-solr
> mvn clean install -DskipTests -Drat.skip
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1210/consoleFull
> 
> 
> Thanks,
> 
> chaitali
> 
>

Re: Review Request 74103: ATLAS-4669 : Atlas - Upgrade Junit to 4.13.2

[chaitali]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74103/
---

(Updated Sept. 8, 2022, 10:01 a.m.)


Review request for atlas, Jayendra Parab and Pinal Shah.


Bugs: ATLAS-4669
https://issues.apache.org/jira/browse/ATLAS-4669


Repository: atlas


Description
---

currently Junit version is 4.13.1


Diffs
-

  addons/hbase-bridge/pom.xml a6ed51421 
  pom.xml a5d4b1f9e 


Diff: https://reviews.apache.org/r/74103/diff/2/


Testing (updated)
---

mvn clean -DskipTests package -Pdist,embedded-hbase-solr
mvn clean install -DskipTests -Drat.skip
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1210/consoleFull


Thanks,

chaitali

Re: Review Request 74036: ATLAS-4627 :- Atlas - Delete Existing entity in Atlas which are not present in Hive, DB wise through Import-hive command.

[Paresh Devalia]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74036/
---

(Updated Sept. 8, 2022, 9:02 a.m.)


Review request for atlas, Jayendra Parab, Mandar Ambawane, and Pinal Shah.


Bugs: ATLAS-4627
https://issues.apache.org/jira/browse/ATLAS-4627


Repository: atlas


Description
---

PROBLEM STATEMENT

Created a DB_1 and DB_2 in Hive and disable the Atlas hook from hive and 
hive_tez.
Created tables with 10 record in DB_1 and DB_2 .
In Atlas UI we checked it has no entity created, so we ran import-hive.sh
bash import-hive.sh -d DB_1 -t table_1, so this command will only create one 
entity in atlas.
bash import-hive.sh -d DB_1, so this command will create all entity in atlas.

Drop table_1 from DB_1 and DB_2 in Hive, but will be present in atlas as hooks 
are disable, so we will ran import-hive command to delete from atlas .

bash import-hive.sh -d DB_1 -t table_1 -deleteNonExisting, this command will 
delete all the table from all DB which are present in Atlas and dropped from 
Hive.
As we have mention -d and -t argument in command for DB and table wise 
deleting, but still it ran for all DB and Tables.


Diffs
-

  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
 28365bc5c 
  
addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridgeTest.java
 ae7ab1a22 


Diff: https://reviews.apache.org/r/74036/diff/7/


Testing (updated)
---

Manual testing is done, also testcase running successfully.

1) mvn clean package -Pdist,embedded-hbase-solr
  Atlas server runnning
2) Quick started was passed successfully

Pre-commit : 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1209/console

Hive DB Testing 

1) Created a DB_1 and DB_2 in Hive and disable the Atlas hook from hive and 
hive_tez.
2) Created tables with 10 record in DB_1 and DB_2 .
3) In Atlas UI we checked it has no entity created, so we ran import-hive.sh
4) bash import-hive.sh -d DB_1 -t table_1, so this command will only create one 
entity in atlas.
5) bash import-hive.sh -d DB_1, so this command will create all entity in atlas.
6) Drop table_1 from DB_1 and DB_2 in Hive, but will be present in atlas as 
hooks are disable, so we will ran import-hive command to delete from atlas 
7) bash import-hive.sh -d DB_1 -t table_1 -deleteNonExisting, this command will 
delete only table_1 from DB_1 which are present in Atlas and dropped from Hive.
8) bash import-hive.sh -d DB_2 -t table_1 -deleteNonExisting, this command will 
delete only table_1 table from DB_2 which are present in Atlas and dropped from 
Hive.
9) bash import-hive.sh -d DB_1 -deleteNonExisting, this command will delete all 
table from DB_1 which are present in Atlas and dropped from Hive.
10) bash import-hive.sh -d DB_2 -deleteNonExisting, this command will delete 
all table from DB_2 which are present in Atlas and dropped from Hive.
11) Checked the deleted table on statistics page in Atlas UI.


Thanks,

Paresh Devalia

[jira] [Commented] (ATLAS-4627) Delete Existing entity in Atlas which are not present in Hive, DB wise through Import-hive command.

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17601728#comment-17601728
 ] 

ASF subversion and git services commented on ATLAS-4627:


Commit 4ac9ae6b2a2a858f811713aa7a268c81fe53471e in atlas's branch 
refs/heads/branch-2.0 from pareshD
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=4ac9ae6b2 ]

ATLAS-4627 : Delete Existing entity in Atlas which are not present in Hive, DB 
wise through Import-hive command.

Signed-off-by: Pinal Shah 
(cherry picked from commit 3a98f1fc98dfcfabf9a19b5d43c8d61e8e696390)


> Delete Existing entity in Atlas which are not present in Hive, DB wise 
> through Import-hive command.
> ---
>
> Key: ATLAS-4627
> URL: https://issues.apache.org/jira/browse/ATLAS-4627
> Project: Atlas
>  Issue Type: Bug
>Reporter: Paresh Devalia
>Assignee: Paresh Devalia
>Priority: Major
>
> PROBLEM STATEMENT
> Created a DB_1 and DB_2 in Hive and disable the Atlas hook from hive and 
> hive_tez.
> Created tables with 10 record in DB_1 and DB_2 .
> In Atlas UI we checked it has no entity created, so we ran import-hive.sh
> bash import-hive.sh -d DB_1 -t table_1, so this command will only create one 
> entity in atlas.
> bash import-hive.sh -d DB_1, so this command will create all entity in atlas.
> Drop table_1 from DB_1 and DB_2 in Hive, but will be present in atlas as 
> hooks are disable, so we will ran import-hive command to delete from atlas .
> bash import-hive.sh -d DB_1 -t table_1 -deleteNonExisting, this command will 
> delete all the table from all DB which are present in Atlas and dropped from 
> Hive.
> As we have mention -d and -t argument in command for DB and table wise 
> deleting, but still it ran for all DB and Tables.
> h4.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (ATLAS-4627) Delete Existing entity in Atlas which are not present in Hive, DB wise through Import-hive command.

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17601727#comment-17601727
 ] 

ASF subversion and git services commented on ATLAS-4627:


Commit 3a98f1fc98dfcfabf9a19b5d43c8d61e8e696390 in atlas's branch 
refs/heads/master from pareshD
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=3a98f1fc9 ]

ATLAS-4627 : Delete Existing entity in Atlas which are not present in Hive, DB 
wise through Import-hive command.

Signed-off-by: Pinal Shah 


> Delete Existing entity in Atlas which are not present in Hive, DB wise 
> through Import-hive command.
> ---
>
> Key: ATLAS-4627
> URL: https://issues.apache.org/jira/browse/ATLAS-4627
> Project: Atlas
>  Issue Type: Bug
>Reporter: Paresh Devalia
>Assignee: Paresh Devalia
>Priority: Major
>
> PROBLEM STATEMENT
> Created a DB_1 and DB_2 in Hive and disable the Atlas hook from hive and 
> hive_tez.
> Created tables with 10 record in DB_1 and DB_2 .
> In Atlas UI we checked it has no entity created, so we ran import-hive.sh
> bash import-hive.sh -d DB_1 -t table_1, so this command will only create one 
> entity in atlas.
> bash import-hive.sh -d DB_1, so this command will create all entity in atlas.
> Drop table_1 from DB_1 and DB_2 in Hive, but will be present in atlas as 
> hooks are disable, so we will ran import-hive command to delete from atlas .
> bash import-hive.sh -d DB_1 -t table_1 -deleteNonExisting, this command will 
> delete all the table from all DB which are present in Atlas and dropped from 
> Hive.
> As we have mention -d and -t argument in command for DB and table wise 
> deleting, but still it ran for all DB and Tables.
> h4.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: Review Request 74103: ATLAS-4669 : Atlas - Upgrade Junit to 4.13.2

[chaitali]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74103/
---

(Updated Sept. 8, 2022, 6:47 a.m.)


Review request for atlas, Jayendra Parab and Pinal Shah.


Bugs: ATLAS-4669
https://issues.apache.org/jira/browse/ATLAS-4669


Repository: atlas


Description
---

currently Junit version is 4.13.1


Diffs
-

  addons/hbase-bridge/pom.xml a6ed51421 
  pom.xml a5d4b1f9e 


Diff: https://reviews.apache.org/r/74103/diff/2/


Testing
---

mvn clean -DskipTests package -Pdist,embedded-hbase-solr
mvn clean install -DskipTests -Drat.skip


Thanks,

chaitali