Re: Review Request 74109: ATLAS-4671 : Basic Search : Exclude Header attributes of entities from the response

[Pinal Shah]

> On Sept. 14, 2022, 11:11 p.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
> > Lines 478 (patched)
> > 
> >
> > Use of HashSet here will eliminate duplicate rows. Is this by choice? 
> > Wouldn't this result in incorrect handling of pagination (offset)?

These elimination happens after handling pagination and getting the resultSet.

but yes, you are correct, from user end it will be confusing, that they have 
requested for 10, and have got less.


> On Sept. 14, 2022, 11:11 p.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
> > Lines 507 (patched)
> > 
> >
> > return here would result in skipping of scrubSearchResults() - which is 
> > incorrect. Please review and update.
> > 
> > Instead of introducing #471 - #509, consider updating existing for loop 
> > below at #549, like:
> > 
> > for (AtlasVertex atlasVertex : resultList) {
> >   if (searchContext.excludeHeaderAttributes()) {
> > // code from #475 - #506
> >   } else {
> > // existing code
> > ...
> >   }
> > }

Correct, but we are skipping many attributes, i.e classifications and also we 
don't have 'entities' (we just have the 'attributes') in AtlasSearchResult
I thought to align this with DSL search, Select Clause where AtlasSearchResult 
has only 'attributes' field.

If we add support to scrubSearchResult
- we need to create 'entities' from what information 
- we need to get 'guid' from the vertex
- we need to get 'classifications' 
- we need to add 'referredEntities'

getting classifications and referredEntities will reduce the performance which 
we are expecting with this improvement.
I will try implementing this once.
Any suugestions?


> On Sept. 14, 2022, 11:11 p.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
> > Line 1356 (original), 1356 (patched)
> > 
> >
> > Consider retaining getVertexAttribute() as private, based on comment in 
> > EntityDiscoveryService.java #494.

comment on #494, 
By entityRetriever.getVertexAttribute();
do you mean entityRetriever.getVertexAttribute(vertex, attribute); ?
We dont have any existing method, other than this which returns the value of 
attribute.

And to access this in EntityDiscoveryService, we need to make this as public


- Pinal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74109/#review224671
---


On Sept. 14, 2022, 12:11 p.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74109/
> ---
> 
> (Updated Sept. 14, 2022, 12:11 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Radhika Kundam, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-4671
> https://issues.apache.org/jira/browse/ATLAS-4671
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Issue** : Basic search has AtlasEntityHeader of each entity in the response.
> AtlasEntityHeader has many attributes including classification and terms. 
> hence for each attribute, it will request janusgraph
> 
> **Approach** : To overcome, we can add a flag to exclude other attributes and 
> add only selected attributes from 'attributes' field in the response
> 
> **Request**: {
>   "excludeDeletedEntities": true,
>   "includeSubClassifications": true,
>   "includeSubTypes": true,
>   "includeClassificationAttributes": true,
>   "limit": 25,
>   "offset": 0,
>   "typeName": "hdfs_path",
> "attributes": ["path", "name"],
>   "excludeHeaderAttributes": "true"
>}
>
> **Response**: {
>   "queryType": "BASIC",
>   "searchParameters": {
>   "typeName": "hdfs_path",
>   "excludeDeletedEntities": true,
>   "includeClassificationAttributes": true,
>   "includeSubTypes": true,
>   "includeSubClassifications": true,
>   "limit": 25,
>   "offset": 0,
>   "attributes": ["path", "name"]
>   },
>   "attributes": {
>   "name": ["path", "name"],
>   "values": [
>   ["/data/warehouse/customer", "customer"],
>   ["/data/warehouse/sales", "sales"]
>   ]
>   },
>   "approximateCount": 2
> }
> 
> 
> Diffs
> -
> 
>   
> intg/src/main/java/org/apache/atlas/model/discovery/QuickSearchParameters.

[jira] [Updated] (ATLAS-4673) Atlas UI- Upgrade jquery-ui to 1.13.2

[Farhan Khan (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Farhan Khan updated ATLAS-4673:
---
Fix Version/s: 2.3.0
   (was: 2.0.0)

> Atlas UI- Upgrade jquery-ui to 1.13.2
> -
>
> Key: ATLAS-4673
> URL: https://issues.apache.org/jira/browse/ATLAS-4673
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Farhan Khan
>Assignee: Farhan Khan
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: 0001-ATLAS-4673-UI-Upgrade-jquery-ui-to-1.13.2.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (ATLAS-4673) Atlas UI- Upgrade jquery-ui to 1.13.2

[Farhan Khan (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Farhan Khan updated ATLAS-4673:
---
Fix Version/s: 2.0.0
   (was: 2.3.0)

> Atlas UI- Upgrade jquery-ui to 1.13.2
> -
>
> Key: ATLAS-4673
> URL: https://issues.apache.org/jira/browse/ATLAS-4673
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Farhan Khan
>Assignee: Farhan Khan
>Priority: Major
> Fix For: 2.0.0, 3.0.0
>
> Attachments: 0001-ATLAS-4673-UI-Upgrade-jquery-ui-to-1.13.2.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (ATLAS-4673) Atlas UI- Upgrade jquery-ui to 1.13.2

[Farhan Khan (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Farhan Khan resolved ATLAS-4673.

Fix Version/s: 3.0.0
   2.3.0
   Resolution: Fixed

> Atlas UI- Upgrade jquery-ui to 1.13.2
> -
>
> Key: ATLAS-4673
> URL: https://issues.apache.org/jira/browse/ATLAS-4673
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Farhan Khan
>Assignee: Farhan Khan
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: 0001-ATLAS-4673-UI-Upgrade-jquery-ui-to-1.13.2.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (ATLAS-4673) Atlas UI- Upgrade jquery-ui to 1.13.2

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605347#comment-17605347
 ] 

ASF subversion and git services commented on ATLAS-4673:


Commit d15946baf6a754e9bf1d57261cde1da168403a69 in atlas's branch 
refs/heads/branch-2.0 from Farhan Khan
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=d15946baf ]

ATLAS-4673 : (UI) Upgrade jquery-ui to 1.13.2

Signed-off-by: Pinal Shah 
(cherry picked from commit 146835ef03158d87defa1ef082decf9e05becbb0)


> Atlas UI- Upgrade jquery-ui to 1.13.2
> -
>
> Key: ATLAS-4673
> URL: https://issues.apache.org/jira/browse/ATLAS-4673
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Farhan Khan
>Assignee: Farhan Khan
>Priority: Major
> Attachments: 0001-ATLAS-4673-UI-Upgrade-jquery-ui-to-1.13.2.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (ATLAS-4673) Atlas UI- Upgrade jquery-ui to 1.13.2

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605345#comment-17605345
 ] 

ASF subversion and git services commented on ATLAS-4673:


Commit 146835ef03158d87defa1ef082decf9e05becbb0 in atlas's branch 
refs/heads/master from Farhan Khan
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=146835ef0 ]

ATLAS-4673 : (UI) Upgrade jquery-ui to 1.13.2

Signed-off-by: Pinal Shah 


> Atlas UI- Upgrade jquery-ui to 1.13.2
> -
>
> Key: ATLAS-4673
> URL: https://issues.apache.org/jira/browse/ATLAS-4673
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Farhan Khan
>Assignee: Farhan Khan
>Priority: Major
> Attachments: 0001-ATLAS-4673-UI-Upgrade-jquery-ui-to-1.13.2.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (ATLAS-4675) Upgrade Guava Google Core Libraries to 31.1-jre

[VINAYAK MARRAIYA (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

VINAYAK MARRAIYA updated ATLAS-4675:

Summary: Upgrade Guava Google Core Libraries to 31.1-jre  (was: Upgrade 
Guava Google Core Libraries to 28.2/31.1-jre)

> Upgrade Guava Google Core Libraries to 31.1-jre
> ---
>
> Key: ATLAS-4675
> URL: https://issues.apache.org/jira/browse/ATLAS-4675
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 2.0.0, 3.0.0
>Reporter: VINAYAK MARRAIYA
>Assignee: VINAYAK MARRAIYA
>Priority: Major
> Fix For: 2.0.0, 3.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (ATLAS-4675) Upgrade Guava Google Core Libraries to 28.2/31.1-jre

[VINAYAK MARRAIYA (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

VINAYAK MARRAIYA updated ATLAS-4675:

Summary: Upgrade Guava Google Core Libraries to 28.2/31.1-jre  (was: 
Upgrade Guava: Google Core Libraries for Java to 28.2/31.1-jre)

> Upgrade Guava Google Core Libraries to 28.2/31.1-jre
> 
>
> Key: ATLAS-4675
> URL: https://issues.apache.org/jira/browse/ATLAS-4675
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 2.0.0, 3.0.0
>Reporter: VINAYAK MARRAIYA
>Assignee: VINAYAK MARRAIYA
>Priority: Major
> Fix For: 2.0.0, 3.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (ATLAS-4675) Upgrade Guava: Google Core Libraries for Java to 28.2/31.1-jre

[VINAYAK MARRAIYA (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

VINAYAK MARRAIYA updated ATLAS-4675:

Fix Version/s: 3.0.0
   2.0.0

> Upgrade Guava: Google Core Libraries for Java to 28.2/31.1-jre
> --
>
> Key: ATLAS-4675
> URL: https://issues.apache.org/jira/browse/ATLAS-4675
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 3.0.0, 2.2.0
>Reporter: VINAYAK MARRAIYA
>Priority: Major
> Fix For: 2.0.0, 3.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (ATLAS-4675) Upgrade Guava: Google Core Libraries for Java to 28.2/31.1-jre

[VINAYAK MARRAIYA (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

VINAYAK MARRAIYA reassigned ATLAS-4675:
---

Assignee: VINAYAK MARRAIYA

> Upgrade Guava: Google Core Libraries for Java to 28.2/31.1-jre
> --
>
> Key: ATLAS-4675
> URL: https://issues.apache.org/jira/browse/ATLAS-4675
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 2.0.0, 3.0.0
>Reporter: VINAYAK MARRAIYA
>Assignee: VINAYAK MARRAIYA
>Priority: Major
> Fix For: 2.0.0, 3.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (ATLAS-4675) Upgrade Guava: Google Core Libraries for Java to 28.2/31.1-jre

[VINAYAK MARRAIYA (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

VINAYAK MARRAIYA updated ATLAS-4675:

Affects Version/s: 3.0.0

> Upgrade Guava: Google Core Libraries for Java to 28.2/31.1-jre
> --
>
> Key: ATLAS-4675
> URL: https://issues.apache.org/jira/browse/ATLAS-4675
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 3.0.0, 2.2.0
>Reporter: VINAYAK MARRAIYA
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (ATLAS-4675) Upgrade Guava: Google Core Libraries for Java to 28.2/31.1-jre

[VINAYAK MARRAIYA (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

VINAYAK MARRAIYA updated ATLAS-4675:

Affects Version/s: 2.0.0
   (was: 2.2.0)

> Upgrade Guava: Google Core Libraries for Java to 28.2/31.1-jre
> --
>
> Key: ATLAS-4675
> URL: https://issues.apache.org/jira/browse/ATLAS-4675
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 2.0.0, 3.0.0
>Reporter: VINAYAK MARRAIYA
>Priority: Major
> Fix For: 2.0.0, 3.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (ATLAS-4675) Upgrade Guava: Google Core Libraries for Java to 28.2/31.1-jre

[VINAYAK MARRAIYA (Jira)]

VINAYAK MARRAIYA created ATLAS-4675:
---

 Summary: Upgrade Guava: Google Core Libraries for Java to 
28.2/31.1-jre
 Key: ATLAS-4675
 URL: https://issues.apache.org/jira/browse/ATLAS-4675
 Project: Atlas
  Issue Type: Improvement
  Components:  atlas-core
Affects Versions: 2.2.0
Reporter: VINAYAK MARRAIYA






--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: Review Request 74121: UI- Upgrade jquery-ui to 1.13.2

[Prasad Pawar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74121/#review224673
---


Ship it!




Ship It!

- Prasad Pawar


On Sept. 15, 2022, 4:49 a.m., Farhan Khan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74121/
> ---
> 
> (Updated Sept. 15, 2022, 4:49 a.m.)
> 
> 
> Review request for atlas and Prasad Pawar.
> 
> 
> Bugs: ATLAS-4673
> https://issues.apache.org/jira/browse/ATLAS-4673
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Upgrade Jquery-ui to the latest version.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/external_lib/jquery-ui/jquery-ui.min.css 1014f66d1 
>   dashboardv2/public/js/external_lib/jquery-ui/jquery-ui.min.js 3b7b15d21 
>   dashboardv3/public/js/external_lib/jquery-ui/jquery-ui.min.css 1014f66d1 
>   dashboardv3/public/js/external_lib/jquery-ui/jquery-ui.min.js 3b7b15d21 
> 
> 
> Diff: https://reviews.apache.org/r/74121/diff/1/
> 
> 
> Testing
> ---
> 
> Did functional testing for all the components present in Atlas(Both UI's).
> 
> 
> Thanks,
> 
> Farhan Khan
> 
>

[GitHub] [atlas] dolfinus commented on pull request #158: [ATLAS-4658] Simply if clauses in AtlasClient.call_api

[GitBox]

dolfinus commented on PR #158:
URL: https://github.com/apache/atlas/pull/158#issuecomment-1247727178

   Waiting for review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [atlas] dolfinus commented on pull request #157: [ATLAS-4657] Do not set root logging settings

[GitBox]

dolfinus commented on PR #157:
URL: https://github.com/apache/atlas/pull/157#issuecomment-1247718451

   @mneethiraj Could you please review?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org