[GitHub] [atlas] bdsoha opened a new pull request, #203: Remove os.path.join causing incorrect windows path

[GitBox]

bdsoha opened a new pull request, #203:
URL: https://github.com/apache/atlas/pull/203

   When running on *Windows* the `os.path.join` using the operating systems 
`os.sep=\` which causing the full url to be incorrect.
   
   Using `urllib.parse` might be a little bit slower, but is less error-prone.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (ATLAS-4674) Regression: Classification tagging is not sending appropriate notification to ATLAS_ENTITIES

[Disha Talreja (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Disha Talreja updated ATLAS-4674:
-
Attachment: ATLAS-4674.patch

> Regression: Classification tagging is not sending appropriate notification to 
> ATLAS_ENTITIES
> 
>
> Key: ATLAS-4674
> URL: https://issues.apache.org/jira/browse/ATLAS-4674
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Disha Talreja
>Assignee: Disha Talreja
>Priority: Major
> Attachments: ATLAS-4674.patch
>
>
> When we add/delete a classification from an entity, we send notification to 
> ATLAS_ENTITIES so ranger tag sync works appropriately to facilitate Tag-based 
> policy. This functionally seems to be broken and is a regression.
> On further investigation, it is seen that the issue is caused by deferred 
> action for classification propagation as the right notifications are sent 
> when deferred action is disabled. 
> Considering the following example:
> 1. Create two table as shown below at Hive:
> =
> create table parent_table(ssn varchar(100));
> create table child_table as select * from parent_table;
> 2. Created two classification: "PII" and "sensitive"
>  
> 3. Tagged PII to parent_table and notification received at ATLAS_ENTITIES 
> topic:
> ---
> {code:java}
> {
>   "source": {},
>   "version":
> {     "version": "1.0.0",     "versionParts": [       1     ]   }
> ,
>   "msgCompressionKind": "NONE",
>   "msgSplitIdx": 1,
>   "msgSplitCount": 1,
>   "msgSourceIP": "172.27.40.5",
>   "msgCreatedBy": "",
>   "msgCreationTime": 1662660308744,
>   "spooled": false,
>   "message": {
>     "type": "ENTITY_NOTIFICATION_V2",
>     "entity": {
>       "typeName": "hive_table",
>       "attributes":
> {         "owner": "admin",         "createTime": 1662602695000,         
> "qualifiedName": "default.parent_table@cm",         "name": "parent_table"    
>   }
> ,
>       "guid": "04ff79d7-b1ff-4354-ba75-a35b28d2f53f",
>       "status": "ACTIVE",
>       "displayText": "parent_table",
>       "classificationNames": [
>         "PII"      ],
>       "classifications": [
>        
> {           "typeName": "PII",           "entityGuid": 
> "04ff79d7-b1ff-4354-ba75-a35b28d2f53f",           "entityStatus": "ACTIVE",   
>         "propagate": true,           "validityPeriods": [],           
> "removePropagationsOnEntityDelete": false        }
>       ],
>       "isIncomplete": false    },
>     "operationType": "CLASSIFICATION_ADD",
>     "eventTime": 1662660307360
>   }
> }
> {
>   "source": {},
>   "version":
> {     "version": "1.0.0",     "versionParts": [       1     ]   }
> ,
>   "msgCompressionKind": "NONE",
>   "msgSplitIdx": 1,
>   "msgSplitCount": 1,
>   "msgSourceIP": "172.27.40.5",
>   "msgCreatedBy": "",
>   "msgCreationTime": 1662660309419,
>   "spooled": false,
>   "message": {
>     "type": "ENTITY_NOTIFICATION_V2",
>     "entity": {
>       "typeName": "hive_process",
>       "attributes":
> {         "qualifiedName": "default.child_table@cm:1662602726000",         
> "clusterName": "cm",         "name": "default.child_table@cm:1662602726000"   
>    }
> ,
>       "guid": "0e180d04-79ed-4cab-bbc3-76af4b876a5b",
>       "status": "ACTIVE",
>       "displayText": "default.child_table@cm:1662602726000",
>       "classificationNames": [
>         "PII"      ],
>       "classifications": [
>        
> {           "typeName": "PII",           "entityGuid": 
> "04ff79d7-b1ff-4354-ba75-a35b28d2f53f",           "entityStatus": "ACTIVE",   
>         "propagate": true,           "validityPeriods": [],           
> "removePropagationsOnEntityDelete": false        }
>       ],
>       "isIncomplete": false    },
>     "operationType": "CLASSIFICATION_ADD",
>     "eventTime": 1662660308935
>   }
> }
> {
>   "source": {},
>   "version":
> {     "version": "1.0.0",     "versionParts": [       1     ]   }
> ,
>   "msgCompressionKind": "NONE",
>   "msgSplitIdx": 1,
>   "msgSplitCount": 1,
>   "msgSourceIP": "172.27.40.5",
>   "msgCreatedBy": "",
>   "msgCreationTime": 1662660309419,
>   "spooled": false,
>   "message": {
>     "type": "ENTITY_NOTIFICATION_V2",
>     "entity": {
>       "typeName": "hive_table",
>       "attributes":
> {         "owner": "admin",         "createTime": 1662602726000,         
> "qualifiedName": "default.child_table@cm",         "name": "child_table"      
> }
> ,
>       "guid": "117bc1c5-748c-4cbd-a86f-8369b7167b1f",
>       "status": "ACTIVE",
>       "displayText": "child_table",
>       "classificationNames": [
>         "PII"      ],
>       "classifications": [
>        
> {           "

[jira] [Updated] (ATLAS-4674) Regression: Classification tagging is not sending appropriate notification to ATLAS_ENTITIES

[Disha Talreja (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Disha Talreja updated ATLAS-4674:
-
Attachment: (was: ATLAS-4674.patch)

> Regression: Classification tagging is not sending appropriate notification to 
> ATLAS_ENTITIES
> 
>
> Key: ATLAS-4674
> URL: https://issues.apache.org/jira/browse/ATLAS-4674
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Disha Talreja
>Assignee: Disha Talreja
>Priority: Major
> Attachments: ATLAS-4674.patch
>
>
> When we add/delete a classification from an entity, we send notification to 
> ATLAS_ENTITIES so ranger tag sync works appropriately to facilitate Tag-based 
> policy. This functionally seems to be broken and is a regression.
> On further investigation, it is seen that the issue is caused by deferred 
> action for classification propagation as the right notifications are sent 
> when deferred action is disabled. 
> Considering the following example:
> 1. Create two table as shown below at Hive:
> =
> create table parent_table(ssn varchar(100));
> create table child_table as select * from parent_table;
> 2. Created two classification: "PII" and "sensitive"
>  
> 3. Tagged PII to parent_table and notification received at ATLAS_ENTITIES 
> topic:
> ---
> {code:java}
> {
>   "source": {},
>   "version":
> {     "version": "1.0.0",     "versionParts": [       1     ]   }
> ,
>   "msgCompressionKind": "NONE",
>   "msgSplitIdx": 1,
>   "msgSplitCount": 1,
>   "msgSourceIP": "172.27.40.5",
>   "msgCreatedBy": "",
>   "msgCreationTime": 1662660308744,
>   "spooled": false,
>   "message": {
>     "type": "ENTITY_NOTIFICATION_V2",
>     "entity": {
>       "typeName": "hive_table",
>       "attributes":
> {         "owner": "admin",         "createTime": 1662602695000,         
> "qualifiedName": "default.parent_table@cm",         "name": "parent_table"    
>   }
> ,
>       "guid": "04ff79d7-b1ff-4354-ba75-a35b28d2f53f",
>       "status": "ACTIVE",
>       "displayText": "parent_table",
>       "classificationNames": [
>         "PII"      ],
>       "classifications": [
>        
> {           "typeName": "PII",           "entityGuid": 
> "04ff79d7-b1ff-4354-ba75-a35b28d2f53f",           "entityStatus": "ACTIVE",   
>         "propagate": true,           "validityPeriods": [],           
> "removePropagationsOnEntityDelete": false        }
>       ],
>       "isIncomplete": false    },
>     "operationType": "CLASSIFICATION_ADD",
>     "eventTime": 1662660307360
>   }
> }
> {
>   "source": {},
>   "version":
> {     "version": "1.0.0",     "versionParts": [       1     ]   }
> ,
>   "msgCompressionKind": "NONE",
>   "msgSplitIdx": 1,
>   "msgSplitCount": 1,
>   "msgSourceIP": "172.27.40.5",
>   "msgCreatedBy": "",
>   "msgCreationTime": 1662660309419,
>   "spooled": false,
>   "message": {
>     "type": "ENTITY_NOTIFICATION_V2",
>     "entity": {
>       "typeName": "hive_process",
>       "attributes":
> {         "qualifiedName": "default.child_table@cm:1662602726000",         
> "clusterName": "cm",         "name": "default.child_table@cm:1662602726000"   
>    }
> ,
>       "guid": "0e180d04-79ed-4cab-bbc3-76af4b876a5b",
>       "status": "ACTIVE",
>       "displayText": "default.child_table@cm:1662602726000",
>       "classificationNames": [
>         "PII"      ],
>       "classifications": [
>        
> {           "typeName": "PII",           "entityGuid": 
> "04ff79d7-b1ff-4354-ba75-a35b28d2f53f",           "entityStatus": "ACTIVE",   
>         "propagate": true,           "validityPeriods": [],           
> "removePropagationsOnEntityDelete": false        }
>       ],
>       "isIncomplete": false    },
>     "operationType": "CLASSIFICATION_ADD",
>     "eventTime": 1662660308935
>   }
> }
> {
>   "source": {},
>   "version":
> {     "version": "1.0.0",     "versionParts": [       1     ]   }
> ,
>   "msgCompressionKind": "NONE",
>   "msgSplitIdx": 1,
>   "msgSplitCount": 1,
>   "msgSourceIP": "172.27.40.5",
>   "msgCreatedBy": "",
>   "msgCreationTime": 1662660309419,
>   "spooled": false,
>   "message": {
>     "type": "ENTITY_NOTIFICATION_V2",
>     "entity": {
>       "typeName": "hive_table",
>       "attributes":
> {         "owner": "admin",         "createTime": 1662602726000,         
> "qualifiedName": "default.child_table@cm",         "name": "child_table"      
> }
> ,
>       "guid": "117bc1c5-748c-4cbd-a86f-8369b7167b1f",
>       "status": "ACTIVE",
>       "displayText": "child_table",
>       "classificationNames": [
>         "PII"      ],
>       "classifications": [
>        
> { 

[jira] [Commented] (ATLAS-4674) Regression: Classification tagging is not sending appropriate notification to ATLAS_ENTITIES

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17620002#comment-17620002
 ] 

ASF subversion and git services commented on ATLAS-4674:


Commit dbc3302ef3bcbf3b90aef156f99348d9de70c897 in atlas's branch 
refs/heads/branch-2.0 from Disha Talreja
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=dbc3302ef ]

ATLAS-4674 - Regression: Classification tagging is not sending appropriate 
notification to ATLAS_ENTITIES

Signed-off-by: radhikakundam 


> Regression: Classification tagging is not sending appropriate notification to 
> ATLAS_ENTITIES
> 
>
> Key: ATLAS-4674
> URL: https://issues.apache.org/jira/browse/ATLAS-4674
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Disha Talreja
>Assignee: Disha Talreja
>Priority: Major
> Attachments: ATLAS-4674.patch
>
>
> When we add/delete a classification from an entity, we send notification to 
> ATLAS_ENTITIES so ranger tag sync works appropriately to facilitate Tag-based 
> policy. This functionally seems to be broken and is a regression.
> On further investigation, it is seen that the issue is caused by deferred 
> action for classification propagation as the right notifications are sent 
> when deferred action is disabled. 
> Considering the following example:
> 1. Create two table as shown below at Hive:
> =
> create table parent_table(ssn varchar(100));
> create table child_table as select * from parent_table;
> 2. Created two classification: "PII" and "sensitive"
>  
> 3. Tagged PII to parent_table and notification received at ATLAS_ENTITIES 
> topic:
> ---
> {code:java}
> {
>   "source": {},
>   "version":
> {     "version": "1.0.0",     "versionParts": [       1     ]   }
> ,
>   "msgCompressionKind": "NONE",
>   "msgSplitIdx": 1,
>   "msgSplitCount": 1,
>   "msgSourceIP": "172.27.40.5",
>   "msgCreatedBy": "",
>   "msgCreationTime": 1662660308744,
>   "spooled": false,
>   "message": {
>     "type": "ENTITY_NOTIFICATION_V2",
>     "entity": {
>       "typeName": "hive_table",
>       "attributes":
> {         "owner": "admin",         "createTime": 1662602695000,         
> "qualifiedName": "default.parent_table@cm",         "name": "parent_table"    
>   }
> ,
>       "guid": "04ff79d7-b1ff-4354-ba75-a35b28d2f53f",
>       "status": "ACTIVE",
>       "displayText": "parent_table",
>       "classificationNames": [
>         "PII"      ],
>       "classifications": [
>        
> {           "typeName": "PII",           "entityGuid": 
> "04ff79d7-b1ff-4354-ba75-a35b28d2f53f",           "entityStatus": "ACTIVE",   
>         "propagate": true,           "validityPeriods": [],           
> "removePropagationsOnEntityDelete": false        }
>       ],
>       "isIncomplete": false    },
>     "operationType": "CLASSIFICATION_ADD",
>     "eventTime": 1662660307360
>   }
> }
> {
>   "source": {},
>   "version":
> {     "version": "1.0.0",     "versionParts": [       1     ]   }
> ,
>   "msgCompressionKind": "NONE",
>   "msgSplitIdx": 1,
>   "msgSplitCount": 1,
>   "msgSourceIP": "172.27.40.5",
>   "msgCreatedBy": "",
>   "msgCreationTime": 1662660309419,
>   "spooled": false,
>   "message": {
>     "type": "ENTITY_NOTIFICATION_V2",
>     "entity": {
>       "typeName": "hive_process",
>       "attributes":
> {         "qualifiedName": "default.child_table@cm:1662602726000",         
> "clusterName": "cm",         "name": "default.child_table@cm:1662602726000"   
>    }
> ,
>       "guid": "0e180d04-79ed-4cab-bbc3-76af4b876a5b",
>       "status": "ACTIVE",
>       "displayText": "default.child_table@cm:1662602726000",
>       "classificationNames": [
>         "PII"      ],
>       "classifications": [
>        
> {           "typeName": "PII",           "entityGuid": 
> "04ff79d7-b1ff-4354-ba75-a35b28d2f53f",           "entityStatus": "ACTIVE",   
>         "propagate": true,           "validityPeriods": [],           
> "removePropagationsOnEntityDelete": false        }
>       ],
>       "isIncomplete": false    },
>     "operationType": "CLASSIFICATION_ADD",
>     "eventTime": 1662660308935
>   }
> }
> {
>   "source": {},
>   "version":
> {     "version": "1.0.0",     "versionParts": [       1     ]   }
> ,
>   "msgCompressionKind": "NONE",
>   "msgSplitIdx": 1,
>   "msgSplitCount": 1,
>   "msgSourceIP": "172.27.40.5",
>   "msgCreatedBy": "",
>   "msgCreationTime": 1662660309419,
>   "spooled": false,
>   "message": {
>     "type": "ENTITY_NOTIFICATION_V2",
>     "entity": {
>       "typeName": "hive_table",
>       "attributes":
> {         "owner": "adm

[jira] [Commented] (ATLAS-4674) Regression: Classification tagging is not sending appropriate notification to ATLAS_ENTITIES

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17620001#comment-17620001
 ] 

ASF subversion and git services commented on ATLAS-4674:


Commit 17c78bac3bfd9c8e7c12548b044b9d747704a973 in atlas's branch 
refs/heads/master from Disha Talreja
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=17c78bac3 ]

ATLAS-4674 - Regression: Classification tagging is not sending appropriate 
notification to ATLAS_ENTITIES

Signed-off-by: radhikakundam 


> Regression: Classification tagging is not sending appropriate notification to 
> ATLAS_ENTITIES
> 
>
> Key: ATLAS-4674
> URL: https://issues.apache.org/jira/browse/ATLAS-4674
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Disha Talreja
>Assignee: Disha Talreja
>Priority: Major
> Attachments: ATLAS-4674.patch
>
>
> When we add/delete a classification from an entity, we send notification to 
> ATLAS_ENTITIES so ranger tag sync works appropriately to facilitate Tag-based 
> policy. This functionally seems to be broken and is a regression.
> On further investigation, it is seen that the issue is caused by deferred 
> action for classification propagation as the right notifications are sent 
> when deferred action is disabled. 
> Considering the following example:
> 1. Create two table as shown below at Hive:
> =
> create table parent_table(ssn varchar(100));
> create table child_table as select * from parent_table;
> 2. Created two classification: "PII" and "sensitive"
>  
> 3. Tagged PII to parent_table and notification received at ATLAS_ENTITIES 
> topic:
> ---
> {code:java}
> {
>   "source": {},
>   "version":
> {     "version": "1.0.0",     "versionParts": [       1     ]   }
> ,
>   "msgCompressionKind": "NONE",
>   "msgSplitIdx": 1,
>   "msgSplitCount": 1,
>   "msgSourceIP": "172.27.40.5",
>   "msgCreatedBy": "",
>   "msgCreationTime": 1662660308744,
>   "spooled": false,
>   "message": {
>     "type": "ENTITY_NOTIFICATION_V2",
>     "entity": {
>       "typeName": "hive_table",
>       "attributes":
> {         "owner": "admin",         "createTime": 1662602695000,         
> "qualifiedName": "default.parent_table@cm",         "name": "parent_table"    
>   }
> ,
>       "guid": "04ff79d7-b1ff-4354-ba75-a35b28d2f53f",
>       "status": "ACTIVE",
>       "displayText": "parent_table",
>       "classificationNames": [
>         "PII"      ],
>       "classifications": [
>        
> {           "typeName": "PII",           "entityGuid": 
> "04ff79d7-b1ff-4354-ba75-a35b28d2f53f",           "entityStatus": "ACTIVE",   
>         "propagate": true,           "validityPeriods": [],           
> "removePropagationsOnEntityDelete": false        }
>       ],
>       "isIncomplete": false    },
>     "operationType": "CLASSIFICATION_ADD",
>     "eventTime": 1662660307360
>   }
> }
> {
>   "source": {},
>   "version":
> {     "version": "1.0.0",     "versionParts": [       1     ]   }
> ,
>   "msgCompressionKind": "NONE",
>   "msgSplitIdx": 1,
>   "msgSplitCount": 1,
>   "msgSourceIP": "172.27.40.5",
>   "msgCreatedBy": "",
>   "msgCreationTime": 1662660309419,
>   "spooled": false,
>   "message": {
>     "type": "ENTITY_NOTIFICATION_V2",
>     "entity": {
>       "typeName": "hive_process",
>       "attributes":
> {         "qualifiedName": "default.child_table@cm:1662602726000",         
> "clusterName": "cm",         "name": "default.child_table@cm:1662602726000"   
>    }
> ,
>       "guid": "0e180d04-79ed-4cab-bbc3-76af4b876a5b",
>       "status": "ACTIVE",
>       "displayText": "default.child_table@cm:1662602726000",
>       "classificationNames": [
>         "PII"      ],
>       "classifications": [
>        
> {           "typeName": "PII",           "entityGuid": 
> "04ff79d7-b1ff-4354-ba75-a35b28d2f53f",           "entityStatus": "ACTIVE",   
>         "propagate": true,           "validityPeriods": [],           
> "removePropagationsOnEntityDelete": false        }
>       ],
>       "isIncomplete": false    },
>     "operationType": "CLASSIFICATION_ADD",
>     "eventTime": 1662660308935
>   }
> }
> {
>   "source": {},
>   "version":
> {     "version": "1.0.0",     "versionParts": [       1     ]   }
> ,
>   "msgCompressionKind": "NONE",
>   "msgSplitIdx": 1,
>   "msgSplitCount": 1,
>   "msgSourceIP": "172.27.40.5",
>   "msgCreatedBy": "",
>   "msgCreationTime": 1662660309419,
>   "spooled": false,
>   "message": {
>     "type": "ENTITY_NOTIFICATION_V2",
>     "entity": {
>       "typeName": "hive_table",
>       "attributes":
> {         "owner": "admin",

Re: Review Request 74176: ATLAS-4674 - Regression: Classification tagging is not sending appropriate notification to ATLAS_ENTITIES

[Jayendra Parab]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74176/#review224817
---


Ship it!




Ship It!

- Jayendra Parab


On Oct. 18, 2022, 7:57 p.m., Disha Talreja wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74176/
> ---
> 
> (Updated Oct. 18, 2022, 7:57 p.m.)
> 
> 
> Review request for atlas and Jayendra Parab.
> 
> 
> Bugs: ATLAS-4674
> https://issues.apache.org/jira/browse/ATLAS-4674
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> When we add/delete a classification from an entity, we send notification to 
> ATLAS_ENTITIES so ranger tag sync works appropriately to facilitate Tag-based 
> policy. This functionally seems to be broken and is a regression.
> 
> 
> On further investigation, it is seen that the issue is caused by deferred 
> action for classification propagation as the right notifications are sent 
> when deferred action is disabled. 
> 
> 
> Entity details for the notification messages are fetched from the entity 
> cache which is not updated and lacks the new classification mapping. Hence, 
> this patch clears the cache so that the entity is newly mapped from it's 
> vertex and contains all the information.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/ClassificationTask.java
>  74bed571f 
> 
> 
> Diff: https://reviews.apache.org/r/74176/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean -DskipTests install 
> mvn clean -DskipTests package -Pdist,embedded-hbase-solr 
> Atlas server running.
> Classification add, Classification delete: Verified appropriate messages 
> being received on ATLAS_ENTITIES.
> 
> 
> Thanks,
> 
> Disha Talreja
> 
>

Re: Review Request 74176: ATLAS-4674 - Regression: Classification tagging is not sending appropriate notification to ATLAS_ENTITIES

[Disha Talreja via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74176/
---

(Updated Oct. 18, 2022, 7:57 p.m.)


Review request for atlas and Jayendra Parab.


Bugs: ATLAS-4674
https://issues.apache.org/jira/browse/ATLAS-4674


Repository: atlas


Description
---

When we add/delete a classification from an entity, we send notification to 
ATLAS_ENTITIES so ranger tag sync works appropriately to facilitate Tag-based 
policy. This functionally seems to be broken and is a regression.


On further investigation, it is seen that the issue is caused by deferred 
action for classification propagation as the right notifications are sent when 
deferred action is disabled. 


Entity details for the notification messages are fetched from the entity cache 
which is not updated and lacks the new classification mapping. Hence, this 
patch clears the cache so that the entity is newly mapped from it's vertex and 
contains all the information.


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/ClassificationTask.java
 74bed571f 


Diff: https://reviews.apache.org/r/74176/diff/2/

Changes: https://reviews.apache.org/r/74176/diff/1-2/


Testing
---

mvn clean -DskipTests install 
mvn clean -DskipTests package -Pdist,embedded-hbase-solr 
Atlas server running.
Classification add, Classification delete: Verified appropriate messages being 
received on ATLAS_ENTITIES.


Thanks,

Disha Talreja

Re: Review Request 74176: ATLAS-4674 - Regression: Classification tagging is not sending appropriate notification to ATLAS_ENTITIES

[Jayendra Parab]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74176/#review224814
---




repository/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/ClassificationTask.java
Line 77 (original), 77 (patched)


Consider clearing the RequestContext at the start of the method, before its 
used anywhere.


- Jayendra Parab


On Oct. 18, 2022, 6:45 p.m., Disha Talreja wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74176/
> ---
> 
> (Updated Oct. 18, 2022, 6:45 p.m.)
> 
> 
> Review request for atlas and Jayendra Parab.
> 
> 
> Bugs: ATLAS-4674
> https://issues.apache.org/jira/browse/ATLAS-4674
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> When we add/delete a classification from an entity, we send notification to 
> ATLAS_ENTITIES so ranger tag sync works appropriately to facilitate Tag-based 
> policy. This functionally seems to be broken and is a regression.
> 
> 
> On further investigation, it is seen that the issue is caused by deferred 
> action for classification propagation as the right notifications are sent 
> when deferred action is disabled. 
> 
> 
> Entity details for the notification messages are fetched from the entity 
> cache which is not updated and lacks the new classification mapping. Hence, 
> this patch clears the cache so that the entity is newly mapped from it's 
> vertex and contains all the information.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/ClassificationTask.java
>  74bed571f 
> 
> 
> Diff: https://reviews.apache.org/r/74176/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean -DskipTests install 
> mvn clean -DskipTests package -Pdist,embedded-hbase-solr 
> Atlas server running.
> Classification add, Classification delete: Verified appropriate messages 
> being received on ATLAS_ENTITIES.
> 
> 
> Thanks,
> 
> Disha Talreja
> 
>

[jira] [Updated] (ATLAS-4674) Regression: Classification tagging is not sending appropriate notification to ATLAS_ENTITIES

[Disha Talreja (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Disha Talreja updated ATLAS-4674:
-
Attachment: (was: ATLAS-4674.patch)

> Regression: Classification tagging is not sending appropriate notification to 
> ATLAS_ENTITIES
> 
>
> Key: ATLAS-4674
> URL: https://issues.apache.org/jira/browse/ATLAS-4674
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Disha Talreja
>Assignee: Disha Talreja
>Priority: Major
> Attachments: ATLAS-4674.patch
>
>
> When we add/delete a classification from an entity, we send notification to 
> ATLAS_ENTITIES so ranger tag sync works appropriately to facilitate Tag-based 
> policy. This functionally seems to be broken and is a regression.
> On further investigation, it is seen that the issue is caused by deferred 
> action for classification propagation as the right notifications are sent 
> when deferred action is disabled. 
> Considering the following example:
> 1. Create two table as shown below at Hive:
> =
> create table parent_table(ssn varchar(100));
> create table child_table as select * from parent_table;
> 2. Created two classification: "PII" and "sensitive"
>  
> 3. Tagged PII to parent_table and notification received at ATLAS_ENTITIES 
> topic:
> ---
> {code:java}
> {
>   "source": {},
>   "version":
> {     "version": "1.0.0",     "versionParts": [       1     ]   }
> ,
>   "msgCompressionKind": "NONE",
>   "msgSplitIdx": 1,
>   "msgSplitCount": 1,
>   "msgSourceIP": "172.27.40.5",
>   "msgCreatedBy": "",
>   "msgCreationTime": 1662660308744,
>   "spooled": false,
>   "message": {
>     "type": "ENTITY_NOTIFICATION_V2",
>     "entity": {
>       "typeName": "hive_table",
>       "attributes":
> {         "owner": "admin",         "createTime": 1662602695000,         
> "qualifiedName": "default.parent_table@cm",         "name": "parent_table"    
>   }
> ,
>       "guid": "04ff79d7-b1ff-4354-ba75-a35b28d2f53f",
>       "status": "ACTIVE",
>       "displayText": "parent_table",
>       "classificationNames": [
>         "PII"      ],
>       "classifications": [
>        
> {           "typeName": "PII",           "entityGuid": 
> "04ff79d7-b1ff-4354-ba75-a35b28d2f53f",           "entityStatus": "ACTIVE",   
>         "propagate": true,           "validityPeriods": [],           
> "removePropagationsOnEntityDelete": false        }
>       ],
>       "isIncomplete": false    },
>     "operationType": "CLASSIFICATION_ADD",
>     "eventTime": 1662660307360
>   }
> }
> {
>   "source": {},
>   "version":
> {     "version": "1.0.0",     "versionParts": [       1     ]   }
> ,
>   "msgCompressionKind": "NONE",
>   "msgSplitIdx": 1,
>   "msgSplitCount": 1,
>   "msgSourceIP": "172.27.40.5",
>   "msgCreatedBy": "",
>   "msgCreationTime": 1662660309419,
>   "spooled": false,
>   "message": {
>     "type": "ENTITY_NOTIFICATION_V2",
>     "entity": {
>       "typeName": "hive_process",
>       "attributes":
> {         "qualifiedName": "default.child_table@cm:1662602726000",         
> "clusterName": "cm",         "name": "default.child_table@cm:1662602726000"   
>    }
> ,
>       "guid": "0e180d04-79ed-4cab-bbc3-76af4b876a5b",
>       "status": "ACTIVE",
>       "displayText": "default.child_table@cm:1662602726000",
>       "classificationNames": [
>         "PII"      ],
>       "classifications": [
>        
> {           "typeName": "PII",           "entityGuid": 
> "04ff79d7-b1ff-4354-ba75-a35b28d2f53f",           "entityStatus": "ACTIVE",   
>         "propagate": true,           "validityPeriods": [],           
> "removePropagationsOnEntityDelete": false        }
>       ],
>       "isIncomplete": false    },
>     "operationType": "CLASSIFICATION_ADD",
>     "eventTime": 1662660308935
>   }
> }
> {
>   "source": {},
>   "version":
> {     "version": "1.0.0",     "versionParts": [       1     ]   }
> ,
>   "msgCompressionKind": "NONE",
>   "msgSplitIdx": 1,
>   "msgSplitCount": 1,
>   "msgSourceIP": "172.27.40.5",
>   "msgCreatedBy": "",
>   "msgCreationTime": 1662660309419,
>   "spooled": false,
>   "message": {
>     "type": "ENTITY_NOTIFICATION_V2",
>     "entity": {
>       "typeName": "hive_table",
>       "attributes":
> {         "owner": "admin",         "createTime": 1662602726000,         
> "qualifiedName": "default.child_table@cm",         "name": "child_table"      
> }
> ,
>       "guid": "117bc1c5-748c-4cbd-a86f-8369b7167b1f",
>       "status": "ACTIVE",
>       "displayText": "child_table",
>       "classificationNames": [
>         "PII"      ],
>       "classifications": [
>        
> { 

Review Request 74176: ATLAS-4674 - Regression: Classification tagging is not sending appropriate notification to ATLAS_ENTITIES

[Disha Talreja via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74176/
---

Review request for atlas and Jayendra Parab.


Bugs: ATLAS-4674
https://issues.apache.org/jira/browse/ATLAS-4674


Repository: atlas


Description
---

When we add/delete a classification from an entity, we send notification to 
ATLAS_ENTITIES so ranger tag sync works appropriately to facilitate Tag-based 
policy. This functionally seems to be broken and is a regression.


On further investigation, it is seen that the issue is caused by deferred 
action for classification propagation as the right notifications are sent when 
deferred action is disabled. 


Entity details for the notification messages are fetched from the entity cache 
which is not updated and lacks the new classification mapping. Hence, this 
patch clears the cache so that the entity is newly mapped from it's vertex and 
contains all the information.


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/ClassificationTask.java
 74bed571f 


Diff: https://reviews.apache.org/r/74176/diff/1/


Testing
---

mvn clean -DskipTests install 
mvn clean -DskipTests package -Pdist,embedded-hbase-solr 
Atlas server running.
Classification add, Classification delete: Verified appropriate messages being 
received on ATLAS_ENTITIES.


Thanks,

Disha Talreja

[jira] [Updated] (ATLAS-4674) Regression: Classification tagging is not sending appropriate notification to ATLAS_ENTITIES

[Disha Talreja (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Disha Talreja updated ATLAS-4674:
-
Attachment: ATLAS-4674.patch

> Regression: Classification tagging is not sending appropriate notification to 
> ATLAS_ENTITIES
> 
>
> Key: ATLAS-4674
> URL: https://issues.apache.org/jira/browse/ATLAS-4674
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Disha Talreja
>Assignee: Disha Talreja
>Priority: Major
> Attachments: ATLAS-4674.patch
>
>
> When we add/delete a classification from an entity, we send notification to 
> ATLAS_ENTITIES so ranger tag sync works appropriately to facilitate Tag-based 
> policy. This functionally seems to be broken and is a regression.
> On further investigation, it is seen that the issue is caused by deferred 
> action for classification propagation as the right notifications are sent 
> when deferred action is disabled. 
> Considering the following example:
> 1. Create two table as shown below at Hive:
> =
> create table parent_table(ssn varchar(100));
> create table child_table as select * from parent_table;
> 2. Created two classification: "PII" and "sensitive"
>  
> 3. Tagged PII to parent_table and notification received at ATLAS_ENTITIES 
> topic:
> ---
> {code:java}
> {
>   "source": {},
>   "version":
> {     "version": "1.0.0",     "versionParts": [       1     ]   }
> ,
>   "msgCompressionKind": "NONE",
>   "msgSplitIdx": 1,
>   "msgSplitCount": 1,
>   "msgSourceIP": "172.27.40.5",
>   "msgCreatedBy": "",
>   "msgCreationTime": 1662660308744,
>   "spooled": false,
>   "message": {
>     "type": "ENTITY_NOTIFICATION_V2",
>     "entity": {
>       "typeName": "hive_table",
>       "attributes":
> {         "owner": "admin",         "createTime": 1662602695000,         
> "qualifiedName": "default.parent_table@cm",         "name": "parent_table"    
>   }
> ,
>       "guid": "04ff79d7-b1ff-4354-ba75-a35b28d2f53f",
>       "status": "ACTIVE",
>       "displayText": "parent_table",
>       "classificationNames": [
>         "PII"      ],
>       "classifications": [
>        
> {           "typeName": "PII",           "entityGuid": 
> "04ff79d7-b1ff-4354-ba75-a35b28d2f53f",           "entityStatus": "ACTIVE",   
>         "propagate": true,           "validityPeriods": [],           
> "removePropagationsOnEntityDelete": false        }
>       ],
>       "isIncomplete": false    },
>     "operationType": "CLASSIFICATION_ADD",
>     "eventTime": 1662660307360
>   }
> }
> {
>   "source": {},
>   "version":
> {     "version": "1.0.0",     "versionParts": [       1     ]   }
> ,
>   "msgCompressionKind": "NONE",
>   "msgSplitIdx": 1,
>   "msgSplitCount": 1,
>   "msgSourceIP": "172.27.40.5",
>   "msgCreatedBy": "",
>   "msgCreationTime": 1662660309419,
>   "spooled": false,
>   "message": {
>     "type": "ENTITY_NOTIFICATION_V2",
>     "entity": {
>       "typeName": "hive_process",
>       "attributes":
> {         "qualifiedName": "default.child_table@cm:1662602726000",         
> "clusterName": "cm",         "name": "default.child_table@cm:1662602726000"   
>    }
> ,
>       "guid": "0e180d04-79ed-4cab-bbc3-76af4b876a5b",
>       "status": "ACTIVE",
>       "displayText": "default.child_table@cm:1662602726000",
>       "classificationNames": [
>         "PII"      ],
>       "classifications": [
>        
> {           "typeName": "PII",           "entityGuid": 
> "04ff79d7-b1ff-4354-ba75-a35b28d2f53f",           "entityStatus": "ACTIVE",   
>         "propagate": true,           "validityPeriods": [],           
> "removePropagationsOnEntityDelete": false        }
>       ],
>       "isIncomplete": false    },
>     "operationType": "CLASSIFICATION_ADD",
>     "eventTime": 1662660308935
>   }
> }
> {
>   "source": {},
>   "version":
> {     "version": "1.0.0",     "versionParts": [       1     ]   }
> ,
>   "msgCompressionKind": "NONE",
>   "msgSplitIdx": 1,
>   "msgSplitCount": 1,
>   "msgSourceIP": "172.27.40.5",
>   "msgCreatedBy": "",
>   "msgCreationTime": 1662660309419,
>   "spooled": false,
>   "message": {
>     "type": "ENTITY_NOTIFICATION_V2",
>     "entity": {
>       "typeName": "hive_table",
>       "attributes":
> {         "owner": "admin",         "createTime": 1662602726000,         
> "qualifiedName": "default.child_table@cm",         "name": "child_table"      
> }
> ,
>       "guid": "117bc1c5-748c-4cbd-a86f-8369b7167b1f",
>       "status": "ACTIVE",
>       "displayText": "child_table",
>       "classificationNames": [
>         "PII"      ],
>       "classifications": [
>        
> {           "

Re: Review Request 74102: ATLAS-4666 : Intermittently, the audits for creation of hive_db registered are different than expected

[Sidharth Mishra]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74102/#review224813
---


Ship it!




Ship It!

- Sidharth Mishra


On Sept. 6, 2022, 5:16 a.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74102/
> ---
> 
> (Updated Sept. 6, 2022, 5:16 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Pinal Shah, Radhika Kundam, and 
> Sidharth Mishra.
> 
> 
> Bugs: ATLAS-4666
> https://issues.apache.org/jira/browse/ATLAS-4666
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Sometimes, when I create a hive database and then check for the same in 
> Atlas, the audits tab shows unexpected audit entries: it shows two audit 
> entries both marked as 'Entity Updated' rather than showing a 'Entity 
> Created' audit entry anywhere.
> 
> This patch will check for the Shell entities created and then assign the 
> Entity status to the Audit entry.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
>  d48c91709 
> 
> 
> Diff: https://reviews.apache.org/r/74102/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

[GitHub] [incubator-atlas] dependabot[bot] opened a new pull request, #58: Bump jettison from 1.3.7 to 1.5.1

[GitBox]

dependabot[bot] opened a new pull request, #58:
URL: https://github.com/apache/incubator-atlas/pull/58

   Bumps [jettison](https://github.com/jettison-json/jettison) from 1.3.7 to 
1.5.1.
   
   Release notes
   Sourced from https://github.com/jettison-json/jettison/releases";>jettison's 
releases.
   
   Jettison 1.5.1
   What's Changed
   
   Stack Overflow fix on malformed JSON by https://github.com/coheigea";>@​coheigea in https://github-redirect.dependabot.com/jettison-json/jettison/pull/48";>jettison-json/jettison#48
   Prevent infinite loop when a /* comment is not terminated by https://github.com/coheigea";>@​coheigea in https://github-redirect.dependabot.com/jettison-json/jettison/pull/49";>jettison-json/jettison#49
   
   Full Changelog: https://github.com/jettison-json/jettison/compare/jettison-1.5.0...jettison-1.5.1";>https://github.com/jettison-json/jettison/compare/jettison-1.5.0...jettison-1.5.1
   
   
   
   Commits
   
   https://github.com/jettison-json/jettison/commit/bdb3982aaea184c2143e41981e33877c2fd66292";>bdb3982
 [maven-release-plugin] prepare release jettison-1.5.1
   https://github.com/jettison-json/jettison/commit/1268b7558bad9b989687009a094466b64d4da533";>1268b75
 Prevent infinite loop when a /* comment is not terminated
   https://github.com/jettison-json/jettison/commit/cff9f2814ec8ae573e38f38abed039311bb7bfda";>cff9f28
 Create codeql-analysis.yml
   https://github.com/jettison-json/jettison/commit/395f8625bcf688743872c8e7f59360d372e77811";>395f862
 Stack Overflow fix on malformed JSON
   https://github.com/jettison-json/jettison/commit/a5d2223bafd4c5ec37723533fa5c4066ead4eaaa";>a5d2223
 [maven-release-plugin] prepare for next development iteration
   https://github.com/jettison-json/jettison/commit/e1bf5293d10af3ebfcd8763eb51a20a659b9047c";>e1bf529
 [maven-release-plugin] prepare release jettison-1.5.0
   https://github.com/jettison-json/jettison/commit/9ccf9d00fbae12fd10863c5b78d22bac6e5b87e4";>9ccf9d0
 Update some deps/plugin versions
   https://github.com/jettison-json/jettison/commit/cfc7382c4dab4e207d2db2f0a70f60ce565e477d";>cfc7382
 Performance improvement
   https://github.com/jettison-json/jettison/commit/d3714681f61581810680df8e45858a4d30a602da";>d371468
 Use BigDecimal instead of Double to avoid loss of precision
   https://github.com/jettison-json/jettison/commit/23a64eedf97e29b6562de8c3b024af414df9b900";>23a64ee
 Avoid NullPointerException when used with Axis2 1.5
   Additional commits viewable in https://github.com/jettison-json/jettison/compare/jettison-1.3.7...jettison-1.5.1";>compare
 view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.codehaus.jettison:jettison&package-manager=maven&previous-version=1.3.7&new-version=1.5.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   - `@dependabot use these labels` will set the current labels as the default 
for future PRs for this repo and language
   - `@dependabot use these reviewers` will set the current reviewers as the 
default for future PRs for this repo and language
   - `@dependabot use these assignees` will set the current assignees as the 
default for future PRs for this repo and language
   - `@dependabot use this milestone` will set the current milestone as the 
default for future PRs for this repo and language
   
   You can dis

Re: Review Request 74165: UI improvements to support Atlas Relationship Search

[Prasad Pawar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74165/#review224808
---


Ship it!




Ship It!

- Prasad Pawar


On Oct. 18, 2022, 11:25 a.m., Farhan Khan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74165/
> ---
> 
> (Updated Oct. 18, 2022, 11:25 a.m.)
> 
> 
> Review request for atlas and Prasad Pawar.
> 
> 
> Bugs: ATLAS-4686
> https://issues.apache.org/jira/browse/ATLAS-4686
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Current Working :
> 
> Atlas is entirely entity-based – it is not possible to search for 
> relationships.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/css/scss/common.scss 2fb6a3a79 
>   dashboardv2/public/css/scss/override.scss 7a14abf6d 
>   dashboardv2/public/css/scss/tab.scss c164b4744 
>   dashboardv2/public/css/scss/tag.scss c7bfb7e72 
>   dashboardv2/public/js/collection/VRelationshipSearchList.js PRE-CREATION 
>   dashboardv2/public/js/collection/VRelationshipSearchResultList.js 
> PRE-CREATION 
>   dashboardv2/public/js/main.js 0994c1b02 
>   dashboardv2/public/js/models/VRelationSearch.js PRE-CREATION 
>   dashboardv2/public/js/models/VRelationshipSearch.js PRE-CREATION 
>   dashboardv2/public/js/router/Router.js b3b0b961e 
>   
> dashboardv2/public/js/templates/detail_page/RelationshipDetailPageLayoutView_tmpl.html
>  PRE-CREATION 
>   
> dashboardv2/public/js/templates/entity/EntityDetailTableLayoutView_tmpl.html 
> 3fe0e95e5 
>   
> dashboardv2/public/js/templates/search/RelationSearchDetailLayoutView_tmpl.html
>  PRE-CREATION 
>   
> dashboardv2/public/js/templates/search/RelationSearchResultLayoutView_tmpl.html
>  PRE-CREATION 
>   dashboardv2/public/js/templates/search/RelationshipSearch_tmpl.html 
> PRE-CREATION 
>   dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html 3bc3121f4 
>   dashboardv2/public/js/utils/CommonViewFunction.js 4ce47a13d 
>   dashboardv2/public/js/utils/Enums.js ee80313c2 
>   dashboardv2/public/js/utils/Globals.js d2ce1a90f 
>   dashboardv2/public/js/utils/UrlLinks.js 243b459be 
>   dashboardv2/public/js/utils/Utils.js eb0588903 
>   dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js bb629b4e4 
>   dashboardv2/public/js/views/detail_page/RelationshipDetailPageLayoutView.js 
> PRE-CREATION 
>   dashboardv2/public/js/views/entity/EntityDetailTableLayoutView.js 5eee4d711 
>   dashboardv2/public/js/views/search/QueryBuilderView.js 983f8b759 
>   dashboardv2/public/js/views/search/RelationSearchDetailLayoutView.js 
> PRE-CREATION 
>   dashboardv2/public/js/views/search/RelationSearchLayoutView.js PRE-CREATION 
>   dashboardv2/public/js/views/search/RelationSearchResultLayoutView.js 
> PRE-CREATION 
>   dashboardv2/public/js/views/search/SearchLayoutView.js 675a521ce 
>   dashboardv2/public/js/views/search/SearchQueryView.js 69a35a54b 
>   dashboardv2/public/js/views/search/save/SaveModalLayoutView.js 350758874 
>   dashboardv2/public/js/views/search/save/SaveSearchItemView.js a86eff4e0 
>   dashboardv2/public/js/views/search/save/SaveSearchView.js 436d83db7 
>   dashboardv2/public/js/views/site/Header.js ffb582ed4 
>   dashboardv2/public/js/views/site/SideNavLayoutView.js e0f717a24 
>   dashboardv3/public/css/scss/common.scss 036d2cfcc 
>   dashboardv3/public/css/scss/leftsidebar.scss 68a6f79a1 
>   dashboardv3/public/js/collection/VRelationshipSearchList.js PRE-CREATION 
>   dashboardv3/public/js/collection/VRelationshipSearchResultList.js 
> PRE-CREATION 
>   dashboardv3/public/js/main.js b1aaec26b 
>   dashboardv3/public/js/models/VRelationSearch.js PRE-CREATION 
>   dashboardv3/public/js/models/VRelationshipSearch.js PRE-CREATION 
>   dashboardv3/public/js/router/Router.js 8e8cf1557 
>   
> dashboardv3/public/js/templates/detail_page/RelationshipDetailPageLayoutView_tmpl.html
>  PRE-CREATION 
>   
> dashboardv3/public/js/templates/entity/EntityDetailTableLayoutView_tmpl.html 
> 3fe0e95e5 
>   
> dashboardv3/public/js/templates/search/RelationSearchResultLayoutView_tmpl.html
>  PRE-CREATION 
>   dashboardv3/public/js/templates/search/SearchDefaultLayoutView_tmpl.html 
> 7a5a322c7 
>   
> dashboardv3/public/js/templates/search/SearchFilterBrowseLayoutView_tmpl.html 
> 9ca345539 
>   dashboardv3/public/js/templates/search/SearchResultLayoutView_tmpl.html 
> b16a4d28a 
>   
> dashboardv3/public/js/templates/search/tree/RelationshipLayoutView_tmpl.html 
> PRE-CREATION 
>   dashboardv3/public/js/utils/CommonViewFunction.js 7d8f03d2e 
>   dashboardv3/public/js/utils/Enums.js ee80313c2 
>   dashboardv3/public/js/utils/Globals.js 9a51c4dc4 
>   dashboardv3/public/js/utils/UrlLinks.js b9a9c8174 
>   dashboardv3/public/js/utils/Utils.js 0d8722fa9 
>   dashboardv3/public/js/views/deta

Re: Review Request 74126: ATLAS-4677 : Atlas - Upgrade commons-configuration to 2.8.0

[chaitali]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74126/
---

(Updated Oct. 18, 2022, 1:13 p.m.)


Review request for atlas, Jayendra Parab and Pinal Shah.


Bugs: ATLAS-4677
https://issues.apache.org/jira/browse/ATLAS-4677


Repository: atlas


Description
---

Current version for commons-configuration2 is 2.2


Diffs (updated)
-

  addons/falcon-bridge/pom.xml 1e2ce7c81 
  addons/hbase-bridge-shim/pom.xml eb1b2e949 
  addons/hbase-bridge/pom.xml 4ce228f7a 
  addons/hbase-testing-util/pom.xml 982e9c85e 
  addons/hdfs-model/pom.xml 05ba17368 
  addons/hive-bridge-shim/pom.xml 849ca2a8f 
  addons/hive-bridge/pom.xml 8c3636e5d 
  addons/impala-bridge/pom.xml 186251abe 
  addons/kafka-bridge/pom.xml d3d6a12c1 
  addons/sqoop-bridge/pom.xml 021e93f56 
  addons/storm-bridge/pom.xml e8106afce 
  atlas-examples/sample-app/pom.xml aa3c6374f 
  client/client-v1/pom.xml 7d017cfa6 
  common/pom.xml 616f66c53 
  distro/pom.xml 28b486c82 
  graphdb/api/pom.xml 0d8acc0dc 
  graphdb/janus-hbase2/pom.xml 883c3444e 
  graphdb/janus/pom.xml 69160977f 
  intg/pom.xml 40031cb70 
  pom.xml 309449a75 
  repository/pom.xml d9488afa1 
  server-api/pom.xml e0e939e83 
  test-tools/pom.xml 991fa14c9 
  webapp/pom.xml 37eeaf4bf 


Diff: https://reviews.apache.org/r/74126/diff/2/

Changes: https://reviews.apache.org/r/74126/diff/1-2/


Testing
---

Testcases passed
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1219/console


Thanks,

chaitali

[jira] [Created] (ATLAS-4690) 10 REKOMENDASI SLOT GACOR GAMPANG MENANG HARI INI TERBARU 2022 RESMI DAN TERPERCAYA

[Bengkel138 (Jira)]

Bengkel138 created ATLAS-4690:
-

 Summary: 10 REKOMENDASI SLOT GACOR GAMPANG MENANG HARI INI TERBARU 
2022 RESMI DAN TERPERCAYA
 Key: ATLAS-4690
 URL: https://issues.apache.org/jira/browse/ATLAS-4690
 Project: Atlas
  Issue Type: Bug
  Components: impala-integration
Affects Versions: 2.0.0
Reporter: Bengkel138


[Login](https://rebrand.ly/bengkel138)
[DAFTAR](https://rebrand.ly/daftarbengkelan)
[LINK RTP](https://rebrand.ly/RTPBengkel138)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (ATLAS-4686) UI improvements to support Atlas Relationship Search

[Rahul Kurup (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619460#comment-17619460
 ] 

Rahul Kurup commented on ATLAS-4686:


+1

> UI improvements to support Atlas Relationship Search
> 
>
> Key: ATLAS-4686
> URL: https://issues.apache.org/jira/browse/ATLAS-4686
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Farhan Khan
>Assignee: Farhan Khan
>Priority: Major
> Attachments: 
> 0001-ATLAS-4686-UI-improvements-to-support-Atlas-Relation.patch
>
>
> *Current Working :*
> Atlas is entirely entity-based – it is not possible to search for 
> relationships.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (ATLAS-4686) UI improvements to support Atlas Relationship Search

[Farhan Khan (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619459#comment-17619459
 ] 

Farhan Khan commented on ATLAS-4686:


The improvement to support Relationship Search has been added in the above 
patch.

> UI improvements to support Atlas Relationship Search
> 
>
> Key: ATLAS-4686
> URL: https://issues.apache.org/jira/browse/ATLAS-4686
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Farhan Khan
>Assignee: Farhan Khan
>Priority: Major
> Attachments: 
> 0001-ATLAS-4686-UI-improvements-to-support-Atlas-Relation.patch
>
>
> *Current Working :*
> Atlas is entirely entity-based – it is not possible to search for 
> relationships.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (ATLAS-4686) UI improvements to support Atlas Relationship Search

[Farhan Khan (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Farhan Khan updated ATLAS-4686:
---
Attachment: 0001-ATLAS-4686-UI-improvements-to-support-Atlas-Relation.patch

> UI improvements to support Atlas Relationship Search
> 
>
> Key: ATLAS-4686
> URL: https://issues.apache.org/jira/browse/ATLAS-4686
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Farhan Khan
>Assignee: Farhan Khan
>Priority: Major
> Attachments: 
> 0001-ATLAS-4686-UI-improvements-to-support-Atlas-Relation.patch
>
>
> *Current Working :*
> Atlas is entirely entity-based – it is not possible to search for 
> relationships.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: Review Request 74165: UI improvements to support Atlas Relationship Search

[Farhan Khan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74165/
---

(Updated Oct. 18, 2022, 11:25 a.m.)


Review request for atlas and Prasad Pawar.


Bugs: ATLAS-4686
https://issues.apache.org/jira/browse/ATLAS-4686


Repository: atlas


Description
---

Current Working :

Atlas is entirely entity-based – it is not possible to search for relationships.


Diffs (updated)
-

  dashboardv2/public/css/scss/common.scss 2fb6a3a79 
  dashboardv2/public/css/scss/override.scss 7a14abf6d 
  dashboardv2/public/css/scss/tab.scss c164b4744 
  dashboardv2/public/css/scss/tag.scss c7bfb7e72 
  dashboardv2/public/js/collection/VRelationshipSearchList.js PRE-CREATION 
  dashboardv2/public/js/collection/VRelationshipSearchResultList.js 
PRE-CREATION 
  dashboardv2/public/js/main.js 0994c1b02 
  dashboardv2/public/js/models/VRelationSearch.js PRE-CREATION 
  dashboardv2/public/js/models/VRelationshipSearch.js PRE-CREATION 
  dashboardv2/public/js/router/Router.js b3b0b961e 
  
dashboardv2/public/js/templates/detail_page/RelationshipDetailPageLayoutView_tmpl.html
 PRE-CREATION 
  dashboardv2/public/js/templates/entity/EntityDetailTableLayoutView_tmpl.html 
3fe0e95e5 
  
dashboardv2/public/js/templates/search/RelationSearchDetailLayoutView_tmpl.html 
PRE-CREATION 
  
dashboardv2/public/js/templates/search/RelationSearchResultLayoutView_tmpl.html 
PRE-CREATION 
  dashboardv2/public/js/templates/search/RelationshipSearch_tmpl.html 
PRE-CREATION 
  dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html 3bc3121f4 
  dashboardv2/public/js/utils/CommonViewFunction.js 4ce47a13d 
  dashboardv2/public/js/utils/Enums.js ee80313c2 
  dashboardv2/public/js/utils/Globals.js d2ce1a90f 
  dashboardv2/public/js/utils/UrlLinks.js 243b459be 
  dashboardv2/public/js/utils/Utils.js eb0588903 
  dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js bb629b4e4 
  dashboardv2/public/js/views/detail_page/RelationshipDetailPageLayoutView.js 
PRE-CREATION 
  dashboardv2/public/js/views/entity/EntityDetailTableLayoutView.js 5eee4d711 
  dashboardv2/public/js/views/search/QueryBuilderView.js 983f8b759 
  dashboardv2/public/js/views/search/RelationSearchDetailLayoutView.js 
PRE-CREATION 
  dashboardv2/public/js/views/search/RelationSearchLayoutView.js PRE-CREATION 
  dashboardv2/public/js/views/search/RelationSearchResultLayoutView.js 
PRE-CREATION 
  dashboardv2/public/js/views/search/SearchLayoutView.js 675a521ce 
  dashboardv2/public/js/views/search/SearchQueryView.js 69a35a54b 
  dashboardv2/public/js/views/search/save/SaveModalLayoutView.js 350758874 
  dashboardv2/public/js/views/search/save/SaveSearchItemView.js a86eff4e0 
  dashboardv2/public/js/views/search/save/SaveSearchView.js 436d83db7 
  dashboardv2/public/js/views/site/Header.js ffb582ed4 
  dashboardv2/public/js/views/site/SideNavLayoutView.js e0f717a24 
  dashboardv3/public/css/scss/common.scss 036d2cfcc 
  dashboardv3/public/css/scss/leftsidebar.scss 68a6f79a1 
  dashboardv3/public/js/collection/VRelationshipSearchList.js PRE-CREATION 
  dashboardv3/public/js/collection/VRelationshipSearchResultList.js 
PRE-CREATION 
  dashboardv3/public/js/main.js b1aaec26b 
  dashboardv3/public/js/models/VRelationSearch.js PRE-CREATION 
  dashboardv3/public/js/models/VRelationshipSearch.js PRE-CREATION 
  dashboardv3/public/js/router/Router.js 8e8cf1557 
  
dashboardv3/public/js/templates/detail_page/RelationshipDetailPageLayoutView_tmpl.html
 PRE-CREATION 
  dashboardv3/public/js/templates/entity/EntityDetailTableLayoutView_tmpl.html 
3fe0e95e5 
  
dashboardv3/public/js/templates/search/RelationSearchResultLayoutView_tmpl.html 
PRE-CREATION 
  dashboardv3/public/js/templates/search/SearchDefaultLayoutView_tmpl.html 
7a5a322c7 
  dashboardv3/public/js/templates/search/SearchFilterBrowseLayoutView_tmpl.html 
9ca345539 
  dashboardv3/public/js/templates/search/SearchResultLayoutView_tmpl.html 
b16a4d28a 
  dashboardv3/public/js/templates/search/tree/RelationshipLayoutView_tmpl.html 
PRE-CREATION 
  dashboardv3/public/js/utils/CommonViewFunction.js 7d8f03d2e 
  dashboardv3/public/js/utils/Enums.js ee80313c2 
  dashboardv3/public/js/utils/Globals.js 9a51c4dc4 
  dashboardv3/public/js/utils/UrlLinks.js b9a9c8174 
  dashboardv3/public/js/utils/Utils.js 0d8722fa9 
  dashboardv3/public/js/views/detail_page/DetailPageLayoutView.js 471be3bd7 
  dashboardv3/public/js/views/detail_page/RelationshipDetailPageLayoutView.js 
PRE-CREATION 
  dashboardv3/public/js/views/entity/EntityDetailTableLayoutView.js 5eee4d711 
  dashboardv3/public/js/views/search/QueryBuilderView.js 3b4a95317 
  dashboardv3/public/js/views/search/RelationSearchResultLayoutView.js 
PRE-CREATION 
  dashboardv3/public/js/views/search/SearchDefaultLayoutView.js b65f753d0 
  dashboardv3/public/js/views/search/SearchFilterBrowseLayoutView.js 86916f45d 
  dashboardv3/publ