[GitHub] [atlas] mneethiraj commented on pull request #202: Bump scss-tokenizer and node-sass in /dashboardv2
mneethiraj commented on PR #202: URL: https://github.com/apache/atlas/pull/202#issuecomment-1306742299 Filed [ATLAS-4707](https://issues.apache.org/jira/browse/ATLAS-4707) to track merging these updates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [atlas] mneethiraj commented on pull request #201: Bump scss-tokenizer and node-sass in /dashboardv3
mneethiraj commented on PR #201: URL: https://github.com/apache/atlas/pull/201#issuecomment-1306742106 Filed [ATLAS-4707](https://issues.apache.org/jira/browse/ATLAS-4707) to track merging these updates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Review Request 74193: ATLAS-4707: updated versions of scss-tokenizer 0.2.3 to 0.4.3, node-sass 4.13.1 to 7.0.3
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74193/ --- Review request for atlas, Ashutosh Mestry, Jayendra Parab, keval bhatt, Nikhil Bonte, Nixon Rodrigues, Pinal Shah, Prasad Pawar, Radhika Kundam, Sarath Subramanian, and Sidharth Mishra. Bugs: ATLAS-4707 https://issues.apache.org/jira/browse/ATLAS-4707 Repository: atlas Description --- Patch from following pull requests: - https://github.com/apache/atlas/pull/201 - https://github.com/apache/atlas/pull/202 Diffs - dashboardv2/package-lock.json 232376eab dashboardv2/package.json 393d4c319 dashboardv3/package-lock.json 35b46349b dashboardv3/package.json 8c0abc697 Diff: https://reviews.apache.org/r/74193/diff/1/ Testing --- - sanity testing of Atlas UI Thanks, Madhan Neethiraj
[jira] [Created] (ATLAS-4707) update UI component version for scss-tokenizer and node-sass
Madhan Neethiraj created ATLAS-4707: --- Summary: update UI component version for scss-tokenizer and node-sass Key: ATLAS-4707 URL: https://issues.apache.org/jira/browse/ATLAS-4707 Project: Atlas Issue Type: Improvement Components: atlas-webui Reporter: Madhan Neethiraj This Jira tracks version updates in following pull requests: - [pull request #202|https://github.com/apache/atlas/pull/202] - [pull request #201|https://github.com/apache/atlas/pull/201] -- This message was sent by Atlassian Jira (v8.20.10#820010)
Apache Atlas 2.3.0 release plan
All, I am excited to announce that Apache Atlas community has started on releasing Apache Atlas 2.3.0! Please review the following brief plan and let me know if you have any comments: 1. 2022-11-30, Wed: tentative release date 2. 2022-11-11, Fri: release branch will be closed for commits. After this date, commits will require approval from the release manager. 3. 2022-11-15, Tue, first release candidate out for vote 4. 2022-11-25: tentative vote completion 5. Release will be from branch-2.0 – the same branch used for earlier 2.x releases. Looking forward to your help in making 2.3.0 release as planned. Thanks, Madhan
Re: Apache Atlas 2.3.0 release
Thank you all for your vote to get started on Apache Atlas 2.3.0 release. I will send an email shortly with the release plan. Thanks, Madhan On 10/28/22, 3:55 PM, "Ramesh Mani" wrote: +1 for Apache Atlas 2.3.0 release Thanks, Ramesh On Wed, Oct 26, 2022 at 7:22 PM Madhan Neethiraj wrote: > Atlas community, > > > > It is more than a year since Apache Atlas 2.2.0 was released on Aug-2021. > During this time, the community has been busy in enhancing Apache Atlas > with several improvements and fixes. Here are few key items: > Search: introduced relationship search, added sorting capability to quick > search > Resiliency: improvements in handling of index update failures > Glossary: performance improvements in dealing with glossaries having large > number of terms and categories > Glossary: performance improvements in bulk creation of glossary terms > Observability: UI improvements to view metrics & stats, persistence of > metrics to enable historic data > Dependent component version upgrades: Elasticsearch, Kafka, Storm, > JanusGraph, TinkerPop, Gson, Spring Framework > UI: fixes and improvements in multiple areas like search, lineage, > business metadata > Hive hook: multiple fixes/improvements > Import Hive utility: multiple fixes/improvements > Impala hook: performance improvements > Log4j vulnerabilities: updated to version 2.17.2 > Audits: support for authentication enabled Cassandra > Performance: improved Atlas lineage API and UI performance > enhanced notification messages to include hook version and message source > refactored Atlas server to removed Kafka server dependency > addressed issues in applying type patches in HA environments > ability to run Atlas and hooks in docker containers > > > With these improvements in place, it is time now for the next maintenance > release of Apache Atlas! > > > > I propose to release Apache Atlas 2.3.0 by mid next month. Please review > and send your comments. > > > > Thanks, > > Madhan > > > > > > > >
[GitHub] [atlas] mneethiraj closed pull request #204: Branch 2.0
mneethiraj closed pull request #204: Branch 2.0 URL: https://github.com/apache/atlas/pull/204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [atlas] mneethiraj commented on pull request #204: Branch 2.0
mneethiraj commented on PR #204: URL: https://github.com/apache/atlas/pull/204#issuecomment-1305970169 @ruoyousi - the description refers to Apache Ranger code. It is not clear what this patch is about. Please add details and reopen if this is about an Apache Atlas issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [atlas] dolfinus closed pull request #197: ATLAS-4676: do not expect response body to be a valid JSON
dolfinus closed pull request #197: ATLAS-4676: do not expect response body to be a valid JSON URL: https://github.com/apache/atlas/pull/197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [atlas] dolfinus commented on pull request #197: ATLAS-4676: do not expect response body to be a valid JSON
dolfinus commented on PR #197: URL: https://github.com/apache/atlas/pull/197#issuecomment-1305296900 Merged: https://github.com/apache/atlas/commit/a43ed6c11d3ca3c8a63b86981c3241365eb60b79 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (ATLAS-4676) Atlas 401 response make Python client fail with JSON decode error
[
https://issues.apache.org/jira/browse/ATLAS-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Madhan Neethiraj resolved ATLAS-4676.
-
Fix Version/s: 3.0.0
2.3.0
Resolution: Fixed
> Atlas 401 response make Python client fail with JSON decode error
> -
>
> Key: ATLAS-4676
> URL: https://issues.apache.org/jira/browse/ATLAS-4676
> Project: Atlas
> Issue Type: Bug
> Components: atlas-intg
>Affects Versions: 2.1.0
>Reporter: Maxim Martynov
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I've tried to use apache-atlas Python client to get an entity via API, but
> passed wrong password. Instead of 401 HTTP error I've got:
> {code:java}
> ~/.local/lib/python3.7/site-packages/apache_atlas/client/entity.py in
> get_entity_by_attribute(self, type_name, uniq_attributes, min_ext_info,
> ignore_relationships)
> 123
> 124 return
> self.client.call_api(EntityClient.GET_ENTITY_BY_UNIQUE_ATTRIBUTE.format_path_with_params(type_name),
> --> 125 AtlasEntityWithExtInfo,
> query_params)
> 126
> 127 def get_entities_by_guids(self, guids, min_ext_info=False,
> ignore_relationships=False):
> ~/.local/lib/python3.7/site-packages/apache_atlas/client/base_client.py in
> call_api(self, api, response_type, query_params, request_obj)
> 116 return None
> 117 else:
> --> 118 raise AtlasServiceException(api, response)
> ~/.local/lib/python3.7/site-packages/apache_atlas/exceptions.py in
> __init__(self, api, response)
> 36 msg = "Metadata service API with url {url} and method
> {method} : failed with status {status} and " \
> 37 "Response Body is :{response}". \
> ---> 38 format(**{'url': response.url, 'method': api.method,
> 'status': status, 'response': response.json()})
> 39
> 40 Exception.__init__(self, msg)
> /opt/anaconda/envs/jh-py37-conda/lib/python3.7/site-packages/requests/models.py
> in json(self, **kwargs)
> 898 # used.
> 899 pass
> --> 900 return complexjson.loads(self.text, **kwargs)
> 901
> 902 @property
> /opt/anaconda/envs/jh-py37-conda/lib/python3.7/json/__init__.py in loads(s,
> encoding, cls, object_hook, parse_float, parse_int, parse_constant,
> object_pairs_hook, **kw)
> 346 parse_int is None and parse_float is None and
> 347 parse_constant is None and object_pairs_hook is None and
> not kw):
> --> 348 return _default_decoder.decode(s)
> 349 if cls is None:
> 350 cls = JSONDecoder
> /opt/anaconda/envs/jh-py37-conda/lib/python3.7/json/decoder.py in
> decode(self, s, _w)
> 335
> 336 """
> --> 337 obj, end = self.raw_decode(s, idx=_w(s, 0).end())
> 338 end = _w(s, end).end()
> 339 if end != len(s):
> /opt/anaconda/envs/jh-py37-conda/lib/python3.7/json/decoder.py in
> raw_decode(self, s, idx)
> 353 obj, end = self.scan_once(s, idx)
> 354 except StopIteration as err:
> --> 355 raise JSONDecodeError("Expecting value", s, err.value)
> from None
> 356 return obj, end
> JSONDecodeError: Expecting value: line 1 column 1 (char 0) {code}
> This is caused by this line:
> https://github.com/apache/atlas/blob/146835ef03158d87defa1ef082decf9e05becbb0/intg/src/main/python/apache_atlas/exceptions.py#L38
> Client can get not only JSON, but an empty string, or HTML page (if Atlas is
> running behind nginx as a reverse proxy).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (ATLAS-4705) Remove unnecessary single quote at the end of flink_model.json
[ https://issues.apache.org/jira/browse/ATLAS-4705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-4705: Reporter: Madhan Neethiraj (was: zhuangchong) > Remove unnecessary single quote at the end of flink_model.json > -- > > Key: ATLAS-4705 > URL: https://issues.apache.org/jira/browse/ATLAS-4705 > Project: Atlas > Issue Type: Bug > Components: atlas-intg >Reporter: Madhan Neethiraj >Priority: Minor > Fix For: 3.0.0, 2.3.0 > > > from [pull request #183|https://github.com/apache/atlas/pull/183]: Remove > unnecessary single quote at the end of flink_model.json -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ATLAS-4705) Remove unnecessary single quote at the end of flink_model.json
[ https://issues.apache.org/jira/browse/ATLAS-4705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629675#comment-17629675 ] Madhan Neethiraj commented on ATLAS-4705: - Commit 4774ed61d5de579d3c9bad9162115e8c6cbb57a6 in atlas's branch refs/heads/master from yanxu3 [ [https://gitbox.apache.org/repos/asf?p=atlas.git;h=4774ed61d] ] ATLAS-4705: Remove unnecessary single quote at the end of flink_model.json Signed-off-by: Madhan Neethiraj [Edit|https://issues.apache.org/jira/secure/EditComment!default.jspa?id=13498047=17629668] [Delete|https://issues.apache.org/jira/secure/DeleteComment!default.jspa?id=13498047=17629668] > Remove unnecessary single quote at the end of flink_model.json > -- > > Key: ATLAS-4705 > URL: https://issues.apache.org/jira/browse/ATLAS-4705 > Project: Atlas > Issue Type: Bug > Components: atlas-intg >Reporter: zhuangchong >Priority: Minor > Fix For: 3.0.0, 2.3.0 > > > from [pull request #183|https://github.com/apache/atlas/pull/183]: Remove > unnecessary single quote at the end of flink_model.json -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ATLAS-4706) avoid duplicate call to retrieve entity-type in AtlasEntityStoreV2.java
[ https://issues.apache.org/jira/browse/ATLAS-4706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629674#comment-17629674 ] ASF subversion and git services commented on ATLAS-4706: Commit 7cb38028564bdc4bb799e0c022504cbb574a562e in atlas's branch refs/heads/branch-2.0 from zhuangchong [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=7cb380285 ] ATLAS-4706: code clean in the entity store v2 class Signed-off-by: Madhan Neethiraj (cherry picked from commit f497d7224f5dd1fcb73c8523a800e2b6ae26c274) > avoid duplicate call to retrieve entity-type in AtlasEntityStoreV2.java > --- > > Key: ATLAS-4706 > URL: https://issues.apache.org/jira/browse/ATLAS-4706 > Project: Atlas > Issue Type: Improvement > Components: atlas-core >Reporter: zhuangchong >Priority: Major > Fix For: 3.0.0, 2.3.0 > > > from [pull request #178|https://github.com/apache/atlas/pull/178]: code clean > in the entity store v2 class -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ATLAS-4676) Atlas 401 response make Python client fail with JSON decode error
[
https://issues.apache.org/jira/browse/ATLAS-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629672#comment-17629672
]
ASF subversion and git services commented on ATLAS-4676:
Commit 0ccd96aa047a95fa754e0893d9b829c74c9a5e15 in atlas's branch
refs/heads/branch-2.0 from Maxim Martynov
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=0ccd96aa0 ]
ATLAS-4676: do not expect response body to be a valid JSON
Signed-off-by: Madhan Neethiraj
(cherry picked from commit a43ed6c11d3ca3c8a63b86981c3241365eb60b79)
> Atlas 401 response make Python client fail with JSON decode error
> -
>
> Key: ATLAS-4676
> URL: https://issues.apache.org/jira/browse/ATLAS-4676
> Project: Atlas
> Issue Type: Bug
> Components: atlas-intg
>Affects Versions: 2.1.0
>Reporter: Maxim Martynov
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I've tried to use apache-atlas Python client to get an entity via API, but
> passed wrong password. Instead of 401 HTTP error I've got:
> {code:java}
> ~/.local/lib/python3.7/site-packages/apache_atlas/client/entity.py in
> get_entity_by_attribute(self, type_name, uniq_attributes, min_ext_info,
> ignore_relationships)
> 123
> 124 return
> self.client.call_api(EntityClient.GET_ENTITY_BY_UNIQUE_ATTRIBUTE.format_path_with_params(type_name),
> --> 125 AtlasEntityWithExtInfo,
> query_params)
> 126
> 127 def get_entities_by_guids(self, guids, min_ext_info=False,
> ignore_relationships=False):
> ~/.local/lib/python3.7/site-packages/apache_atlas/client/base_client.py in
> call_api(self, api, response_type, query_params, request_obj)
> 116 return None
> 117 else:
> --> 118 raise AtlasServiceException(api, response)
> ~/.local/lib/python3.7/site-packages/apache_atlas/exceptions.py in
> __init__(self, api, response)
> 36 msg = "Metadata service API with url {url} and method
> {method} : failed with status {status} and " \
> 37 "Response Body is :{response}". \
> ---> 38 format(**{'url': response.url, 'method': api.method,
> 'status': status, 'response': response.json()})
> 39
> 40 Exception.__init__(self, msg)
> /opt/anaconda/envs/jh-py37-conda/lib/python3.7/site-packages/requests/models.py
> in json(self, **kwargs)
> 898 # used.
> 899 pass
> --> 900 return complexjson.loads(self.text, **kwargs)
> 901
> 902 @property
> /opt/anaconda/envs/jh-py37-conda/lib/python3.7/json/__init__.py in loads(s,
> encoding, cls, object_hook, parse_float, parse_int, parse_constant,
> object_pairs_hook, **kw)
> 346 parse_int is None and parse_float is None and
> 347 parse_constant is None and object_pairs_hook is None and
> not kw):
> --> 348 return _default_decoder.decode(s)
> 349 if cls is None:
> 350 cls = JSONDecoder
> /opt/anaconda/envs/jh-py37-conda/lib/python3.7/json/decoder.py in
> decode(self, s, _w)
> 335
> 336 """
> --> 337 obj, end = self.raw_decode(s, idx=_w(s, 0).end())
> 338 end = _w(s, end).end()
> 339 if end != len(s):
> /opt/anaconda/envs/jh-py37-conda/lib/python3.7/json/decoder.py in
> raw_decode(self, s, idx)
> 353 obj, end = self.scan_once(s, idx)
> 354 except StopIteration as err:
> --> 355 raise JSONDecodeError("Expecting value", s, err.value)
> from None
> 356 return obj, end
> JSONDecodeError: Expecting value: line 1 column 1 (char 0) {code}
> This is caused by this line:
> https://github.com/apache/atlas/blob/146835ef03158d87defa1ef082decf9e05becbb0/intg/src/main/python/apache_atlas/exceptions.py#L38
> Client can get not only JSON, but an empty string, or HTML page (if Atlas is
> running behind nginx as a reverse proxy).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ATLAS-4705) Remove unnecessary single quote at the end of flink_model.json
[ https://issues.apache.org/jira/browse/ATLAS-4705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629673#comment-17629673 ] ASF subversion and git services commented on ATLAS-4705: Commit 5c2434ca396108378bd6c04e9ab8efc07f02fca1 in atlas's branch refs/heads/branch-2.0 from yanxu3 [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=5c2434ca3 ] ATLAS-4705: Remove unnecessary single quote at the end of flink_model.json Signed-off-by: Madhan Neethiraj (cherry picked from commit 4774ed61d5de579d3c9bad9162115e8c6cbb57a6) > Remove unnecessary single quote at the end of flink_model.json > -- > > Key: ATLAS-4705 > URL: https://issues.apache.org/jira/browse/ATLAS-4705 > Project: Atlas > Issue Type: Bug > Components: atlas-intg >Reporter: zhuangchong >Priority: Minor > Fix For: 3.0.0, 2.3.0 > > > from [pull request #183|https://github.com/apache/atlas/pull/183]: Remove > unnecessary single quote at the end of flink_model.json -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ATLAS-4704) Remove os.path.join causing incorrect windows path
[ https://issues.apache.org/jira/browse/ATLAS-4704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629671#comment-17629671 ] ASF subversion and git services commented on ATLAS-4704: Commit 956cac4b783741f4db93ce9bbeea99c6e49e2806 in atlas's branch refs/heads/branch-2.0 from Dov Benyomin Sohacheski [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=956cac4b7 ] ATLAS-4704: Remove os.path.join causing incorrect windows path Signed-off-by: Madhan Neethiraj (cherry picked from commit b9ff08fee7646f10083da2f8672b932a34aa4a7f) > Remove os.path.join causing incorrect windows path > -- > > Key: ATLAS-4704 > URL: https://issues.apache.org/jira/browse/ATLAS-4704 > Project: Atlas > Issue Type: Bug > Components: atlas-intg >Affects Versions: 2.2.0 >Reporter: Madhan Neethiraj >Priority: Major > Fix For: 3.0.0, 2.3.0 > > > from [pull request #203|https://github.com/apache/atlas/pull/203]: > When running on Windows the os.path.join using the operating systems os.sep=\ > which causing the full url to be incorrect. > Using urllib.parse might be a little bit slower, but is less error-prone. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ATLAS-4706) avoid duplicate call to retrieve entity-type in AtlasEntityStoreV2.java
[ https://issues.apache.org/jira/browse/ATLAS-4706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629668#comment-17629668 ] ASF subversion and git services commented on ATLAS-4706: Commit 4774ed61d5de579d3c9bad9162115e8c6cbb57a6 in atlas's branch refs/heads/master from yanxu3 [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=4774ed61d ] ATLAS-4706: Remove unnecessary single quote at the end of flink_model.json Signed-off-by: Madhan Neethiraj > avoid duplicate call to retrieve entity-type in AtlasEntityStoreV2.java > --- > > Key: ATLAS-4706 > URL: https://issues.apache.org/jira/browse/ATLAS-4706 > Project: Atlas > Issue Type: Improvement > Components: atlas-core >Reporter: zhuangchong >Priority: Major > Fix For: 3.0.0, 2.3.0 > > > from [pull request #178|https://github.com/apache/atlas/pull/178]: code clean > in the entity store v2 class -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ATLAS-4706) avoid duplicate call to retrieve entity-type in AtlasEntityStoreV2.java
[ https://issues.apache.org/jira/browse/ATLAS-4706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629669#comment-17629669 ] ASF subversion and git services commented on ATLAS-4706: Commit f497d7224f5dd1fcb73c8523a800e2b6ae26c274 in atlas's branch refs/heads/master from zhuangchong [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=f497d7224 ] ATLAS-4706: code clean in the entity store v2 class Signed-off-by: Madhan Neethiraj > avoid duplicate call to retrieve entity-type in AtlasEntityStoreV2.java > --- > > Key: ATLAS-4706 > URL: https://issues.apache.org/jira/browse/ATLAS-4706 > Project: Atlas > Issue Type: Improvement > Components: atlas-core >Reporter: zhuangchong >Priority: Major > Fix For: 3.0.0, 2.3.0 > > > from [pull request #178|https://github.com/apache/atlas/pull/178]: code clean > in the entity store v2 class -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ATLAS-4676) Atlas 401 response make Python client fail with JSON decode error
[
https://issues.apache.org/jira/browse/ATLAS-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629667#comment-17629667
]
ASF subversion and git services commented on ATLAS-4676:
Commit a43ed6c11d3ca3c8a63b86981c3241365eb60b79 in atlas's branch
refs/heads/master from Maxim Martynov
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=a43ed6c11 ]
ATLAS-4676: do not expect response body to be a valid JSON
Signed-off-by: Madhan Neethiraj
> Atlas 401 response make Python client fail with JSON decode error
> -
>
> Key: ATLAS-4676
> URL: https://issues.apache.org/jira/browse/ATLAS-4676
> Project: Atlas
> Issue Type: Bug
> Components: atlas-intg
>Affects Versions: 2.1.0
>Reporter: Maxim Martynov
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I've tried to use apache-atlas Python client to get an entity via API, but
> passed wrong password. Instead of 401 HTTP error I've got:
> {code:java}
> ~/.local/lib/python3.7/site-packages/apache_atlas/client/entity.py in
> get_entity_by_attribute(self, type_name, uniq_attributes, min_ext_info,
> ignore_relationships)
> 123
> 124 return
> self.client.call_api(EntityClient.GET_ENTITY_BY_UNIQUE_ATTRIBUTE.format_path_with_params(type_name),
> --> 125 AtlasEntityWithExtInfo,
> query_params)
> 126
> 127 def get_entities_by_guids(self, guids, min_ext_info=False,
> ignore_relationships=False):
> ~/.local/lib/python3.7/site-packages/apache_atlas/client/base_client.py in
> call_api(self, api, response_type, query_params, request_obj)
> 116 return None
> 117 else:
> --> 118 raise AtlasServiceException(api, response)
> ~/.local/lib/python3.7/site-packages/apache_atlas/exceptions.py in
> __init__(self, api, response)
> 36 msg = "Metadata service API with url {url} and method
> {method} : failed with status {status} and " \
> 37 "Response Body is :{response}". \
> ---> 38 format(**{'url': response.url, 'method': api.method,
> 'status': status, 'response': response.json()})
> 39
> 40 Exception.__init__(self, msg)
> /opt/anaconda/envs/jh-py37-conda/lib/python3.7/site-packages/requests/models.py
> in json(self, **kwargs)
> 898 # used.
> 899 pass
> --> 900 return complexjson.loads(self.text, **kwargs)
> 901
> 902 @property
> /opt/anaconda/envs/jh-py37-conda/lib/python3.7/json/__init__.py in loads(s,
> encoding, cls, object_hook, parse_float, parse_int, parse_constant,
> object_pairs_hook, **kw)
> 346 parse_int is None and parse_float is None and
> 347 parse_constant is None and object_pairs_hook is None and
> not kw):
> --> 348 return _default_decoder.decode(s)
> 349 if cls is None:
> 350 cls = JSONDecoder
> /opt/anaconda/envs/jh-py37-conda/lib/python3.7/json/decoder.py in
> decode(self, s, _w)
> 335
> 336 """
> --> 337 obj, end = self.raw_decode(s, idx=_w(s, 0).end())
> 338 end = _w(s, end).end()
> 339 if end != len(s):
> /opt/anaconda/envs/jh-py37-conda/lib/python3.7/json/decoder.py in
> raw_decode(self, s, idx)
> 353 obj, end = self.scan_once(s, idx)
> 354 except StopIteration as err:
> --> 355 raise JSONDecodeError("Expecting value", s, err.value)
> from None
> 356 return obj, end
> JSONDecodeError: Expecting value: line 1 column 1 (char 0) {code}
> This is caused by this line:
> https://github.com/apache/atlas/blob/146835ef03158d87defa1ef082decf9e05becbb0/intg/src/main/python/apache_atlas/exceptions.py#L38
> Client can get not only JSON, but an empty string, or HTML page (if Atlas is
> running behind nginx as a reverse proxy).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ATLAS-4704) Remove os.path.join causing incorrect windows path
[ https://issues.apache.org/jira/browse/ATLAS-4704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629666#comment-17629666 ] ASF subversion and git services commented on ATLAS-4704: Commit b9ff08fee7646f10083da2f8672b932a34aa4a7f in atlas's branch refs/heads/master from Dov Benyomin Sohacheski [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=b9ff08fee ] ATLAS-4704: Remove os.path.join causing incorrect windows path Signed-off-by: Madhan Neethiraj > Remove os.path.join causing incorrect windows path > -- > > Key: ATLAS-4704 > URL: https://issues.apache.org/jira/browse/ATLAS-4704 > Project: Atlas > Issue Type: Bug > Components: atlas-intg >Affects Versions: 2.2.0 >Reporter: Madhan Neethiraj >Priority: Major > Fix For: 3.0.0, 2.3.0 > > > from [pull request #203|https://github.com/apache/atlas/pull/203]: > When running on Windows the os.path.join using the operating systems os.sep=\ > which causing the full url to be incorrect. > Using urllib.parse might be a little bit slower, but is less error-prone. -- This message was sent by Atlassian Jira (v8.20.10#820010)
