[jira] [Created] (ATLAS-4829) process/process_executions were getting created when there is no scope of lineage creation

2024-03-04 Thread Radhika Kundam (Jira)
Radhika Kundam created ATLAS-4829:
-

 Summary: process/process_executions were getting created when 
there is no scope of lineage creation
 Key: ATLAS-4829
 URL: https://issues.apache.org/jira/browse/ATLAS-4829
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Affects Versions: 2.3.0
Reporter: Radhika Kundam
Assignee: Radhika Kundam


Queries ran:
{code:java}
create table test_hive_lineage_4 (name string, id int) stored as orc;

insert into test_hive_lineage_4 values ('qwer', '2');

update test_hive_lineage_4 set name = 'vwxy' where id = 2; {code}
For every update query it created hive_process and hive_process_execution 
entities.

For same update query 100+ times, it created 100+ UNIQUE (timestamp delimited) 
hive_process_executions



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (ATLAS-4824) UI: Enable/Disable Propagation window usability needs improvement

2024-03-04 Thread Rahul Kurup (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823212#comment-17823212
 ] 

Rahul Kurup commented on ATLAS-4824:


+1

> UI:  Enable/Disable Propagation window usability needs improvement
> --
>
> Key: ATLAS-4824
> URL: https://issues.apache.org/jira/browse/ATLAS-4824
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Rahul Kurup
>Assignee: Brijesh Bhalala
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: 0001-ATLAS-4824.patch, 0002-ATLAS-4824.patch, 
> blocking_propagation2.png, image-2024-02-15-10-37-14-512.png
>
>
> In Atlas UI, the user has the ability to access a window that enables or 
> disables propagation of a classification in a lineage. It looks like the 
> attached screenshot. 
> !image-2024-02-15-10-37-14-512.png!
> The UI in the window could use improvement as it uses outdated UI.
> Edit: The alignment is improper in the "Selection Classification" pane as 
> seen in this screenshot below. Also as a suggestion, keep the title of the 
> modal box consistent.
> !blocking_propagation2.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (ATLAS-4225) Support for Chinese character in entity data.

2024-03-04 Thread chaitali borole (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823133#comment-17823133
 ] 

chaitali borole commented on ATLAS-4225:


creating a new RR with patch which is in sync with latest code.
https://reviews.apache.org/r/74925/




> Support for Chinese character in entity data.
> -
>
> Key: ATLAS-4225
> URL: https://issues.apache.org/jira/browse/ATLAS-4225
> Project: Atlas
>  Issue Type: New Feature
>Reporter: Mayank Jain
>Assignee: Mayank Jain
>Priority: Major
> Attachments: ATLAS-4225-3.patch
>
>
> Currently we only allow English characters to be used to adding entity data 
> that is labels , Custom Attributes and Business-Metadata.
>  
> We need to support for Chinese and other languages as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: Review Request 74925: ATLAS-4225 : Support for Chinese character in entity data.

2024-03-04 Thread chaitali

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74925/
---

(Updated March 4, 2024, 11:15 a.m.)


Review request for atlas, Jayendra Parab, Pinal Shah, and Sheetal Shah.


Bugs: ATLAS-4225
https://issues.apache.org/jira/browse/ATLAS-4225


Repository: atlas


Description
---

Updated latest patch with synchronized code 

Creating this review request to track and close 
https://reviews.apache.org/r/73256/diff/3#1 as the patch here is not in sync 
with latest code


Diffs
-

  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
9be6517e9 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 c670740c9 
  repository/src/test/java/org/apache/atlas/BasicTestSetup.java 593f8c19b 
  
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
 282a3fd4a 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
 1489b2760 


Diff: https://reviews.apache.org/r/74925/diff/1/


Testing (updated)
---

Testcases are added in the patch


Thanks,

chaitali



Review Request 74925: ATLAS-4225 : Support for Chinese character in entity data.

2024-03-04 Thread chaitali

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74925/
---

Review request for atlas, Jayendra Parab, Pinal Shah, and Sheetal Shah.


Bugs: ATLAS-4225
https://issues.apache.org/jira/browse/ATLAS-4225


Repository: atlas


Description
---

Updated latest patch with synchronized code 

Creating this review request to track and close 
https://reviews.apache.org/r/73256/diff/3#1 as the patch here is not in sync 
with latest code


Diffs
-

  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
9be6517e9 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 c670740c9 
  repository/src/test/java/org/apache/atlas/BasicTestSetup.java 593f8c19b 
  
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
 282a3fd4a 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
 1489b2760 


Diff: https://reviews.apache.org/r/74925/diff/1/


Testing
---


Thanks,

chaitali



Re: Review Request 74691: ATLAS-4802 : Atlas 'updateTime' parameter is not updated when business metadata is edited.

2024-03-04 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74691/#review226283
---


Ship it!




Ship It!

- Mandar Ambawane


On Jan. 2, 2024, 10:35 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74691/
> ---
> 
> (Updated Jan. 2, 2024, 10:35 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and 
> Sheetal Shah.
> 
> 
> Bugs: ATLAS-4802
> https://issues.apache.org/jira/browse/ATLAS-4802
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> When updating the business metadata and Labels on an atlas entity, the 
> 'updateTime' system attribute is not changed.
> 
> Updates to other aspects, such as technical properties and user defined 
> attributes does update the timestamp, but not the business metadata and 
> labels.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  c670740c9 
> 
> 
> Diff: https://reviews.apache.org/r/74691/diff/2/
> 
> 
> Testing
> ---
> 
> update time Without patch
> before business metadata update
> 
> "createTime": 1703221384530,
> "updateTime": 1703221386989,
> 
> after business metadata update
> 
> "createTime": 1703221384530,
> "updateTime": 1703221386989,
> 
> 
> after applying PATCH
> 
> before business metadata update
> "createTime": 1704190056433,
> "updateTime": 1704190059208,
> 
> after business metadata update
> "createTime": 1704190056433,
> "updateTime": 1704190523323,
> 
> Entire json for GET api on entity before applying patch :
> 
> http://localhost:21000/api/atlas/v2/entity/guid/dc1baa88-3a07-4577-9b6b-48982253aa3d
> 
> {
> "referredEntities": {
> "a1a27e35-aa0d-472d-8b94-2405d8001a84": {
> "typeName": "Column",
> "attributes": {
> "qualifiedName": "Sales.customer_dim.address@cl1",
> "name": "address",
> "comment": "customer address"
> },
> "guid": "a1a27e35-aa0d-472d-8b94-2405d8001a84",
> "isIncomplete": false,
> "status": "ACTIVE",
> "createdBy": "admin",
> "updatedBy": "admin",
> "createTime": 1704190056433,
> "updateTime": 1704190056433,
> "version": 0,
> "classifications": [
> {
> "typeName": "PII",
> "entityGuid": "a1a27e35-aa0d-472d-8b94-2405d8001a84",
> "entityStatus": "ACTIVE",
> "propagate": true,
> "removePropagationsOnEntityDelete": false
> }
> ],
> "labels": []
> },
> "834ba687-c8f1-4a48-a6a0-ef3ddeadf7ee": {
> "typeName": "Column",
> "attributes": {
> "qualifiedName": "Sales.customer_dim.name@cl1",
> "name": "name",
> "comment": "customer name"
> },
> "guid": "834ba687-c8f1-4a48-a6a0-ef3ddeadf7ee",
> "isIncomplete": false,
> "status": "ACTIVE",
> "createdBy": "admin",
> "updatedBy": "admin",
> "createTime": 1704190056433,
> "updateTime": 1704190056433,
> "version": 0,
> "classifications": [
> {
> "typeName": "PII",
> "entityGuid": "834ba687-c8f1-4a48-a6a0-ef3ddeadf7ee",
> "entityStatus": "ACTIVE",
> "propagate": true,
> "removePropagationsOnEntityDelete": false
> }
> ],
> "labels": []
> },
> "f8ded729-7bad-48dd-9969-c5b36a8d5b9c": {
> "typeName": "Column",
> "attributes": {
> "qualifiedName": "Sales.customer_dim.customer_id@cl1",
> "name": "customer_id",
> "comment": "customer id"
> },
> "guid": "f8ded729-7bad-48dd-9969-c5b36a8d5b9c",
> "isIncomplete": false,
> "status": "ACTIVE",
> "createdBy": "admin",
> "updatedBy": "admin",
> "createTime": 1704190056433,
> "updateTime": 1704190056433,
> "version": 0,
> "classifications": [
> {
> "typeName": "PII",
> "entityGuid": "f8ded729-7bad-48dd-9969-c5b36a8d5b9c",
> "entityStatus": "ACTIVE",
> "propagate": true,
> "removePropagationsOnEntityDelete": false
> }
>