Re: Review Request 74904: ATLAS-4824: UI: Enable/Disable Propagation window usability needs improvement

2024-03-06 Thread Brijesh Bhalala 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74904/
---

(Updated March 6, 2024, 2:48 p.m.)


Review request for atlas, Farhan Khan, Jayendra Parab, Madhan Neethiraj, and 
Prasad Pawar.


Bugs: ATLAS-4824
https://issues.apache.org/jira/browse/ATLAS-4824


Repository: atlas


Description
---

Improve the block propagation window UI.


Diffs
-

  dashboardv2/public/js/templates/graph/PropagationPropertyModalView_tmpl.html 
7dc4850ca 
  dashboardv2/public/js/views/graph/PropagationPropertyModal.js d9ef604b6 
  dashboardv3/public/js/templates/graph/PropagationPropertyModalView_tmpl.html 
7dc4850ca 
  dashboardv3/public/js/views/graph/PropagationPropertyModal.js d9ef604b6 


Diff: https://reviews.apache.org/r/74904/diff/2/


Testing (updated)
---

Tested the Block Proagation window Ui on Apache atlas local.


Thanks,

Brijesh Bhalala

[jira] [Comment Edited] (ATLAS-4824) UI: Enable/Disable Propagation window usability needs improvement

2024-03-06 Thread Brijesh Bhalala (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824040#comment-17824040
 ] 

Brijesh Bhalala edited comment on ATLAS-4824 at 3/6/24 2:46 PM:


commited  to [Apache 
master|https://github.com/apache/atlas/commit/73467212ff15e0e82006d8faa9b3601709d1d2b3]
 branch 


was (Author: JIRAUSER294659):
commited [Apache 
master|https://github.com/apache/atlas/commit/73467212ff15e0e82006d8faa9b3601709d1d2b3]
 branch 

> UI:  Enable/Disable Propagation window usability needs improvement
> --
>
> Key: ATLAS-4824
> URL: https://issues.apache.org/jira/browse/ATLAS-4824
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Rahul Kurup
>Assignee: Brijesh Bhalala
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: 0001-ATLAS-4824.patch, 0002-ATLAS-4824.patch, 
> blocking_propagation2.png, image-2024-02-15-10-37-14-512.png
>
>
> In Atlas UI, the user has the ability to access a window that enables or 
> disables propagation of a classification in a lineage. It looks like the 
> attached screenshot. 
> !image-2024-02-15-10-37-14-512.png!
> The UI in the window could use improvement as it uses outdated UI.
> Edit: The alignment is improper in the "Selection Classification" pane as 
> seen in this screenshot below. Also as a suggestion, keep the title of the 
> modal box consistent.
> !blocking_propagation2.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (ATLAS-4824) UI: Enable/Disable Propagation window usability needs improvement

2024-03-06 Thread Brijesh Bhalala (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824040#comment-17824040
 ] 

Brijesh Bhalala commented on ATLAS-4824:


commited [Apache 
master|https://github.com/apache/atlas/commit/73467212ff15e0e82006d8faa9b3601709d1d2b3]
 branch 

> UI:  Enable/Disable Propagation window usability needs improvement
> --
>
> Key: ATLAS-4824
> URL: https://issues.apache.org/jira/browse/ATLAS-4824
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Rahul Kurup
>Assignee: Brijesh Bhalala
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: 0001-ATLAS-4824.patch, 0002-ATLAS-4824.patch, 
> blocking_propagation2.png, image-2024-02-15-10-37-14-512.png
>
>
> In Atlas UI, the user has the ability to access a window that enables or 
> disables propagation of a classification in a lineage. It looks like the 
> attached screenshot. 
> !image-2024-02-15-10-37-14-512.png!
> The UI in the window could use improvement as it uses outdated UI.
> Edit: The alignment is improper in the "Selection Classification" pane as 
> seen in this screenshot below. Also as a suggestion, keep the title of the 
> modal box consistent.
> !blocking_propagation2.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (ATLAS-4824) UI: Enable/Disable Propagation window usability needs improvement

2024-03-06 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824027#comment-17824027
 ] 

ASF subversion and git services commented on ATLAS-4824:


Commit 1e64023e40d47c97a40c485640519a29eae58d07 in atlas's branch 
refs/heads/branch-2.0 from Brijesh Bhalala
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=1e64023e4 ]

ATLAS-4824: UI: Enable/Disable Propagation window usability needs improvement

Signed-off-by: Prasad Pawar 


> UI:  Enable/Disable Propagation window usability needs improvement
> --
>
> Key: ATLAS-4824
> URL: https://issues.apache.org/jira/browse/ATLAS-4824
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Rahul Kurup
>Assignee: Brijesh Bhalala
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: 0001-ATLAS-4824.patch, 0002-ATLAS-4824.patch, 
> blocking_propagation2.png, image-2024-02-15-10-37-14-512.png
>
>
> In Atlas UI, the user has the ability to access a window that enables or 
> disables propagation of a classification in a lineage. It looks like the 
> attached screenshot. 
> !image-2024-02-15-10-37-14-512.png!
> The UI in the window could use improvement as it uses outdated UI.
> Edit: The alignment is improper in the "Selection Classification" pane as 
> seen in this screenshot below. Also as a suggestion, keep the title of the 
> modal box consistent.
> !blocking_propagation2.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (ATLAS-4824) UI: Enable/Disable Propagation window usability needs improvement

2024-03-06 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824025#comment-17824025
 ] 

ASF subversion and git services commented on ATLAS-4824:


Commit 73467212ff15e0e82006d8faa9b3601709d1d2b3 in atlas's branch 
refs/heads/master from Brijesh Bhalala
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=73467212f ]

ATLAS-4824: UI: Enable/Disable Propagation window usability needs improvement

Signed-off-by: Prasad Pawar 


> UI:  Enable/Disable Propagation window usability needs improvement
> --
>
> Key: ATLAS-4824
> URL: https://issues.apache.org/jira/browse/ATLAS-4824
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Rahul Kurup
>Assignee: Brijesh Bhalala
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: 0001-ATLAS-4824.patch, 0002-ATLAS-4824.patch, 
> blocking_propagation2.png, image-2024-02-15-10-37-14-512.png
>
>
> In Atlas UI, the user has the ability to access a window that enables or 
> disables propagation of a classification in a lineage. It looks like the 
> attached screenshot. 
> !image-2024-02-15-10-37-14-512.png!
> The UI in the window could use improvement as it uses outdated UI.
> Edit: The alignment is improper in the "Selection Classification" pane as 
> seen in this screenshot below. Also as a suggestion, keep the title of the 
> modal box consistent.
> !blocking_propagation2.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: Review Request 74925: ATLAS-4225 : Support for Chinese character in entity data.

2024-03-06 Thread chaitali 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74925/
---

(Updated March 6, 2024, 12:11 p.m.)


Review request for atlas, Ashutosh Mestry, Deep Singh, Jayendra Parab, Pinal 
Shah, and Sheetal Shah.


Bugs: ATLAS-4225
https://issues.apache.org/jira/browse/ATLAS-4225


Repository: atlas


Description
---

Updated latest patch with synchronized code 

Creating this review request to track and close 
https://reviews.apache.org/r/73256/diff/3#1 as the patch here is not in sync 
with latest code


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
9be6517e9 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 c670740c9 
  repository/src/test/java/org/apache/atlas/BasicTestSetup.java 593f8c19b 
  
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
 282a3fd4a 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
 1489b2760 


Diff: https://reviews.apache.org/r/74925/diff/2/

Changes: https://reviews.apache.org/r/74925/diff/1-2/


Testing
---

Testcases are added in the patch


Thanks,

chaitali

Re: Review Request 74925: ATLAS-4225 : Support for Chinese character in entity data.

2024-03-06 Thread Mandar Ambawane 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74925/#review226291
---




repository/src/test/java/org/apache/atlas/BasicTestSetup.java
Lines 767 (patched)


Please use equals() method to compare two String objects.


- Mandar Ambawane


On March 4, 2024, 11:37 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74925/
> ---
> 
> (Updated March 4, 2024, 11:37 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Jayendra Parab, Pinal 
> Shah, and Sheetal Shah.
> 
> 
> Bugs: ATLAS-4225
> https://issues.apache.org/jira/browse/ATLAS-4225
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Updated latest patch with synchronized code 
> 
> Creating this review request to track and close 
> https://reviews.apache.org/r/73256/diff/3#1 as the patch here is not in sync 
> with latest code
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  9be6517e9 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  c670740c9 
>   repository/src/test/java/org/apache/atlas/BasicTestSetup.java 593f8c19b 
>   
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
>  282a3fd4a 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
>  1489b2760 
> 
> 
> Diff: https://reviews.apache.org/r/74925/diff/1/
> 
> 
> Testing
> ---
> 
> Testcases are added in the patch
> 
> 
> Thanks,
> 
> chaitali
> 
>