Re: Review Request 74925: ATLAS-4225 : Support for Chinese character in entity data.

2024-04-26 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74925/#review226403
---




intg/src/main/java/org/apache/atlas/type/AtlasStructType.java
Line 1078 (original), 1078 (patched)


This change doesn't seem correct. Did you mean the following:
  if (StringUtils.isNotBlank(value)) {
...
  }



intg/src/main/java/org/apache/atlas/type/AtlasStructType.java
Lines 1083 (patched)


All CJK characters are treated as tokenizeChar here. While 
hastokenizeChar() only treats specific characters as tokenizeChar. Consider 
adding unit tests for hastokenizeChar(String) with several inputs.


- Madhan Neethiraj


On April 26, 2024, 9:54 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74925/
> ---
> 
> (Updated April 26, 2024, 9:54 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Jayendra Parab, Pinal 
> Shah, and Sheetal Shah.
> 
> 
> Bugs: ATLAS-4225
> https://issues.apache.org/jira/browse/ATLAS-4225
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Updated latest patch with synchronized code 
> 
> Creating this review request to track and close 
> https://reviews.apache.org/r/73256/diff/3#1 as the patch here is not in sync 
> with latest code
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 591b31612 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  9be6517e9 
>   repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 
> 9a9a5512a 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  01b88eb2f 
>   repository/src/test/java/org/apache/atlas/BasicTestSetup.java 593f8c19b 
>   
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
>  282a3fd4a 
>   
> repository/src/test/java/org/apache/atlas/discovery/ClassificationSearchProcessorTest.java
>  121dca9f5 
>   
> repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java
>  3f9e74d11 
> 
> 
> Diff: https://reviews.apache.org/r/74925/diff/4/
> 
> 
> Testing
> ---
> 
> Testcases are added in the patch
> PC is successful : 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1561/consoleFull
> 
> 
> Thanks,
> 
> chaitali
> 
>

Re: Review Request 74925: ATLAS-4225 : Support for Chinese character in entity data.

2024-04-26 Thread chaitali 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74925/
---

(Updated April 26, 2024, 9:54 a.m.)


Review request for atlas, Ashutosh Mestry, Deep Singh, Jayendra Parab, Pinal 
Shah, and Sheetal Shah.


Bugs: ATLAS-4225
https://issues.apache.org/jira/browse/ATLAS-4225


Repository: atlas


Description
---

Updated latest patch with synchronized code 

Creating this review request to track and close 
https://reviews.apache.org/r/73256/diff/3#1 as the patch here is not in sync 
with latest code


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 591b31612 
  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
9be6517e9 
  repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 
9a9a5512a 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 01b88eb2f 
  repository/src/test/java/org/apache/atlas/BasicTestSetup.java 593f8c19b 
  
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
 282a3fd4a 
  
repository/src/test/java/org/apache/atlas/discovery/ClassificationSearchProcessorTest.java
 121dca9f5 
  
repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java
 3f9e74d11 


Diff: https://reviews.apache.org/r/74925/diff/4/

Changes: https://reviews.apache.org/r/74925/diff/3-4/


Testing
---

Testcases are added in the patch
PC is successful : 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1561/consoleFull


Thanks,

chaitali

[jira] [Updated] (ATLAS-4856) Parallel Atlas Import is failing with unexpected errors

2024-04-26 Thread Priyanshi Shah (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Priyanshi Shah updated ATLAS-4856:
--
Description: PermanentLockingException was thrown while running parallel 
imports.

> Parallel Atlas Import is failing with unexpected errors
> ---
>
> Key: ATLAS-4856
> URL: https://issues.apache.org/jira/browse/ATLAS-4856
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Priyanshi Shah
>Assignee: Priyanshi Shah
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> PermanentLockingException was thrown while running parallel imports.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Review Request 74965: ATLAS-4844 : Atlas - Upgrade Common Configuration2 to 2.10.1

2024-04-26 Thread Priyanshi Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74965/
---

Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and 
Sheetal Shah.


Bugs: ATLAS-4844
https://issues.apache.org/jira/browse/ATLAS-4844


Repository: atlas


Description
---

Currently Atlas is using common configuration2 version 2.8.0 upgrading it to 
2.10.1


Diffs
-

  pom.xml 6e6724275 


Diff: https://reviews.apache.org/r/74965/diff/1/


Testing
---


Thanks,

Priyanshi Shah

[jira] [Assigned] (ATLAS-4856) Parallel Atlas Import is failing with unexpected errors

2024-04-26 Thread Priyanshi Shah (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Priyanshi Shah reassigned ATLAS-4856:
-

Assignee: Priyanshi Shah

> Parallel Atlas Import is failing with unexpected errors
> ---
>
> Key: ATLAS-4856
> URL: https://issues.apache.org/jira/browse/ATLAS-4856
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Priyanshi Shah
>Assignee: Priyanshi Shah
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (ATLAS-4856) Parallel Atlas Import is failing with unexpected errors

2024-04-26 Thread Priyanshi Shah (Jira) 
Priyanshi Shah created ATLAS-4856:
-

 Summary: Parallel Atlas Import is failing with unexpected errors
 Key: ATLAS-4856
 URL: https://issues.apache.org/jira/browse/ATLAS-4856
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Reporter: Priyanshi Shah
 Fix For: 3.0.0, 2.3.0






--
This message was sent by Atlassian Jira
(v8.20.10#820010)