Re: Review Request 71982: ATLAS-3581:HBase hook converts qualifiedName to lowercase for namespace, table, column-family and column
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71982/#review219220 --- Ship it! Ship It! - Abhay Kulkarni On Jan. 10, 2020, 9:56 p.m., Ramesh Mani wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71982/ > --- > > (Updated Jan. 10, 2020, 9:56 p.m.) > > > Review request for atlas, Ashutosh Mestry, Abhay Kulkarni, Madhan Neethiraj, > and Sarath Subramanian. > > > Bugs: ATLAS-3581 > https://issues.apache.org/jira/browse/ATLAS-3581 > > > Repository: atlas > > > Description > --- > > ATLAS-3581:HBase hook converts qualifiedName to lowercase for namespace, > table, column-family and column > > > Diffs > - > > > addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java > 26be9b3 > > addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseBridge.java > fde70f1 > > > Diff: https://reviews.apache.org/r/71982/diff/1/ > > > Testing > --- > > Verified in local VM > > > Thanks, > > Ramesh Mani > >
Re: Review Request 68593: ATLAS-2856: added utility methods to RequestContext, to find number of active requests and earliest active request-time
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68593/#review208212 --- Ship it! Ship It! - Abhay Kulkarni On Aug. 31, 2018, 11:31 p.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68593/ > --- > > (Updated Aug. 31, 2018, 11:31 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Abhay Kulkarni, and > Sarath Subramanian. > > > Bugs: ATLAS-2856 > https://issues.apache.org/jira/browse/ATLAS-2856 > > > Repository: atlas > > > Description > --- > > added utility methods in RequestContext and RequestContextV1, to find number > of active requests and earliest active request-time > > > Diffs > - > > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java > 35d1a74da > server-api/src/main/java/org/apache/atlas/RequestContext.java 3b2b575a6 > server-api/src/main/java/org/apache/atlas/RequestContextV1.java 8506d1869 > > > Diff: https://reviews.apache.org/r/68593/diff/1/ > > > Testing > --- > > Pre-commit test run: > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/649 > > > Thanks, > > Madhan Neethiraj > >
[jira] [Created] (ATLAS-2794) Ensure that Atlas REST client uses JacksonJsonProvider from com.fasterxml.jackson package
Abhay Kulkarni created ATLAS-2794: - Summary: Ensure that Atlas REST client uses JacksonJsonProvider from com.fasterxml.jackson package Key: ATLAS-2794 URL: https://issues.apache.org/jira/browse/ATLAS-2794 Project: Atlas Issue Type: Bug Components: atlas-core Affects Versions: 1.0.0 Reporter: Abhay Kulkarni Fix For: trunk In order that Ranger REST client and Atlas REST client co-exist in tagsync process, each client needs to ensure that it explicitly uses JacksonJsonProvider of its choice when initializing respective REST clients. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: [VOTE] Release Apache Atlas version 1.0.0 - rc2
+1 -Abhay On 5/30/18, 12:31 AM, "Madhan Neethiraj" wrote: >Atlas team, > >Apache Atlas 1.0.0 release candidate #2 is now available for a vote >within dev community. > >Following commit went into branch-1.0 since the last release candidate, >#1, was sent yesterday. > ATLAS-2726: updated migration-import to add __name property to >classification edges > >Links to the release artifacts are given below. Please review and vote. > >The vote will be open for at least 72 hours or until necessary votes are >reached. > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove (and reason why) > >Thanks, >Madhan > > >List of issues addressed in this release: >https://issues.apache.org/jira/issues/?jql=project%20%3D%20Atlas%20AND%20r >esolution%20!%3D%20Unresolved%20%20AND%20fixVersion%20%3D%201.0.0%20ORDER% >20BY%20key%20DESC > >Git tag for the release: >https://github.com/apache/atlas/tree/release-1.0.0-rc2 > >Sources for the release: >https://dist.apache.org/repos/dist/dev/atlas/1.0.0-rc2/apache-atlas-1.0.0- >sources.tar.gz > >Documentation for the release: >http://atlas.apache.org/1.0.0-rc0/index.html > >Source release verification: > PGP Signature: >https://dist.apache.org/repos/dist/dev/atlas/1.0.0-rc2/apache-atlas-1.0.0- >sources.tar.gz.asc > SHA512 Hash: >https://dist.apache.org/repos/dist/dev/atlas/1.0.0-rc2/apache-atlas-1.0.0- >sources.tar.gz.sha512 > >Keys to verify the signature of the release artifacts are available at: >https://dist.apache.org/repos/dist/dev/atlas/KEYS > > >
Re: Review Request 62681: ATLAS-2075: notification enhancement to handle large messages, using compression and multi-part messages
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62681/#review186808 --- Ship it! - Abhay Kulkarni On Sept. 30, 2017, 9:58 p.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62681/ > --- > > (Updated Sept. 30, 2017, 9:58 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Abhay Kulkarni, > Sarath Subramanian, and Suma Shivaprasad. > > > Bugs: ATLAS-2075 > https://issues.apache.org/jira/browse/ATLAS-2075 > > > Repository: atlas > > > Description > --- > > Update notification module to compress and split large messages (> 1mb) that > can't be sent via Kafka. When such a message is sent, the message is first > compressed via GZip. If compressed message is within the size limit, the > message is sent via Kafka. If the compressed size is larger, then the message > is split into multiple small messages and sent via Kafka. > > Notification consumer is updated to merge and uncompress messages before the > message is processed further. > > > Diffs > - > > > notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java > 1f9404de > > notification/src/main/java/org/apache/atlas/notification/AtlasNotificationMessageDeserializer.java > b1ac2fa0 > > > Diff: https://reviews.apache.org/r/62681/diff/6/ > > > Testing > --- > > - verified that large messages are compressed and split by Atlas hook, before > sending to Kafka > - verified that Atlas server processes compressed, multi-part messages > correctly > > > Thanks, > > Madhan Neethiraj > >
Re: Review Request 62681: ATLAS-2075: notification enhancement to handle large messages, using compression and multi-part messages
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62681/#review186787 --- Fix it, then Ship it! notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java Line 198 (original), 193 (patched) <https://reviews.apache.org/r/62681/#comment263621> Consider using this instead. byte[] encodedBytes = MESSAGE_COMPRESSION_ENABLED ? msgBytes : AtlasNotificationBaseMessage.encodeBase64(msgBytes); - Abhay Kulkarni On Sept. 30, 2017, 11:51 a.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62681/ > --- > > (Updated Sept. 30, 2017, 11:51 a.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Abhay Kulkarni, > Sarath Subramanian, and Suma Shivaprasad. > > > Bugs: ATLAS-2075 > https://issues.apache.org/jira/browse/ATLAS-2075 > > > Repository: atlas > > > Description > --- > > Update notification module to compress and split large messages (> 1mb) that > can't be sent via Kafka. When such a message is sent, the message is first > compressed via GZip. If compressed message is within the size limit, the > message is sent via Kafka. If the compressed size is larger, then the message > is split into multiple small messages and sent via Kafka. > > Notification consumer is updated to merge and uncompress messages before the > message is processed further. > > > Diffs > - > > common/src/main/java/org/apache/atlas/AtlasConfiguration.java 9a9bb76a > notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaConsumer.java > d3b4e49e > notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java > 38889ef8 > > notification/src/main/java/org/apache/atlas/notification/AbstractMessageDeserializer.java > ec99372d > > notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java > cb44fc68 > > notification/src/main/java/org/apache/atlas/notification/AtlasNotificationBaseMessage.java > PRE-CREATION > > notification/src/main/java/org/apache/atlas/notification/AtlasNotificationMessageDeserializer.java > PRE-CREATION > > notification/src/main/java/org/apache/atlas/notification/AtlasNotificationStringMessage.java > PRE-CREATION > > notification/src/main/java/org/apache/atlas/notification/MessageVersion.java > 6ef407ac > > notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java > 956c85e0 > > notification/src/main/java/org/apache/atlas/notification/VersionedMessage.java > 1929eb46 > > notification/src/main/java/org/apache/atlas/notification/VersionedMessageDeserializer.java > cc2099e7 > notification/src/test/java/org/apache/atlas/kafka/KafkaConsumerTest.java > 9b712f44 > > notification/src/test/java/org/apache/atlas/kafka/KafkaNotificationMockTest.java > b7474a0e > > notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java > 3b2a093b > > notification/src/test/java/org/apache/atlas/notification/AbstractNotificationTest.java > 61107a9f > > notification/src/test/java/org/apache/atlas/notification/VersionedMessageTest.java > 587b7ebd > > notification/src/test/java/org/apache/atlas/notification/entity/EntityMessageDeserializerTest.java > be324277 > > notification/src/test/java/org/apache/atlas/notification/hook/HookMessageDeserializerTest.java > 3724fd5f > > > Diff: https://reviews.apache.org/r/62681/diff/5/ > > > Testing > --- > > - verified that large messages are compressed and split by Atlas hook, before > sending to Kafka > - verified that Atlas server processes compressed, multi-part messages > correctly > > > Thanks, > > Madhan Neethiraj > >
Re: Review Request 62681: ATLAS-2075: notification enhancement to handle large messages, using compression and multi-part messages
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62681/#review186757 --- notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java Lines 192 (patched) <https://reviews.apache.org/r/62681/#comment263567> Please base64 encode msgBytes if maxLengthExceedsLimit is true. - Abhay Kulkarni On Sept. 29, 2017, 10:32 p.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62681/ > --- > > (Updated Sept. 29, 2017, 10:32 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Abhay Kulkarni, > Sarath Subramanian, and Suma Shivaprasad. > > > Bugs: ATLAS-2075 > https://issues.apache.org/jira/browse/ATLAS-2075 > > > Repository: atlas > > > Description > --- > > Update notification module to compress and split large messages (> 1mb) that > can't be sent via Kafka. When such a message is sent, the message is first > compressed via GZip. If compressed message is within the size limit, the > message is sent via Kafka. If the compressed size is larger, then the message > is split into multiple small messages and sent via Kafka. > > Notification consumer is updated to merge and uncompress messages before the > message is processed further. > > > Diffs > - > > common/src/main/java/org/apache/atlas/AtlasConfiguration.java 9a9bb76a > notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaConsumer.java > d3b4e49e > notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java > 38889ef8 > > notification/src/main/java/org/apache/atlas/notification/AbstractMessageDeserializer.java > ec99372d > > notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java > cb44fc68 > > notification/src/main/java/org/apache/atlas/notification/AtlasNotificationBaseMessage.java > PRE-CREATION > > notification/src/main/java/org/apache/atlas/notification/AtlasNotificationMessageDeserializer.java > PRE-CREATION > > notification/src/main/java/org/apache/atlas/notification/AtlasNotificationStringMessage.java > PRE-CREATION > > notification/src/main/java/org/apache/atlas/notification/MessageVersion.java > 6ef407ac > > notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java > 956c85e0 > > notification/src/main/java/org/apache/atlas/notification/VersionedMessage.java > 1929eb46 > > notification/src/main/java/org/apache/atlas/notification/VersionedMessageDeserializer.java > cc2099e7 > notification/src/test/java/org/apache/atlas/kafka/KafkaConsumerTest.java > 9b712f44 > > notification/src/test/java/org/apache/atlas/kafka/KafkaNotificationMockTest.java > b7474a0e > > notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java > 3b2a093b > > notification/src/test/java/org/apache/atlas/notification/AbstractNotificationTest.java > 61107a9f > > notification/src/test/java/org/apache/atlas/notification/VersionedMessageTest.java > 587b7ebd > > notification/src/test/java/org/apache/atlas/notification/entity/EntityMessageDeserializerTest.java > be324277 > > notification/src/test/java/org/apache/atlas/notification/hook/HookMessageDeserializerTest.java > 3724fd5f > > > Diff: https://reviews.apache.org/r/62681/diff/4/ > > > Testing > --- > > - verified that large messages are compressed and split by Atlas hook, before > sending to Kafka > - verified that Atlas server processes compressed, multi-part messages > correctly > > > Thanks, > > Madhan Neethiraj > >
Re: Review Request 62681: ATLAS-2075: notification enhancement to handle large messages, using compression and multi-part messages
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62681/#review186683 --- common/src/main/java/org/apache/atlas/AtlasConfiguration.java Lines 36 (patched) <https://reviews.apache.org/r/62681/#comment263475> Consider if default value of this parameter can be directly referenced from some Kafka class. - Abhay Kulkarni On Sept. 29, 2017, 6:30 a.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62681/ > --- > > (Updated Sept. 29, 2017, 6:30 a.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Abhay Kulkarni, > Sarath Subramanian, and Suma Shivaprasad. > > > Bugs: ATLAS-2075 > https://issues.apache.org/jira/browse/ATLAS-2075 > > > Repository: atlas > > > Description > --- > > Update notification module to compress and split large messages (> 1mb) that > can't be sent via Kafka. When such a message is sent, the message is first > compressed via GZip. If compressed message is within the size limit, the > message is sent via Kafka. If the compressed size is larger, then the message > is split into multiple small messages and sent via Kafka. > > Notification consumer is updated to merge and uncompress messages before the > message is processed further. > > > Diffs > - > > common/src/main/java/org/apache/atlas/AtlasConfiguration.java 9a9bb76a > notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaConsumer.java > d3b4e49e > notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java > 38889ef8 > > notification/src/main/java/org/apache/atlas/notification/AbstractMessageDeserializer.java > ec99372d > > notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java > cb44fc68 > > notification/src/main/java/org/apache/atlas/notification/AtlasNotificationBaseMessage.java > PRE-CREATION > > notification/src/main/java/org/apache/atlas/notification/AtlasNotificationMessageDeserializer.java > PRE-CREATION > > notification/src/main/java/org/apache/atlas/notification/AtlasNotificationStringMessage.java > PRE-CREATION > > notification/src/main/java/org/apache/atlas/notification/MessageVersion.java > 6ef407ac > > notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java > 956c85e0 > > notification/src/main/java/org/apache/atlas/notification/VersionedMessage.java > 1929eb46 > > notification/src/main/java/org/apache/atlas/notification/VersionedMessageDeserializer.java > cc2099e7 > notification/src/test/java/org/apache/atlas/kafka/KafkaConsumerTest.java > 9b712f44 > > notification/src/test/java/org/apache/atlas/kafka/KafkaNotificationMockTest.java > b7474a0e > > notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java > 3b2a093b > > notification/src/test/java/org/apache/atlas/notification/AbstractNotificationTest.java > 61107a9f > > notification/src/test/java/org/apache/atlas/notification/VersionedMessageTest.java > 587b7ebd > > notification/src/test/java/org/apache/atlas/notification/entity/EntityMessageDeserializerTest.java > be324277 > > notification/src/test/java/org/apache/atlas/notification/hook/HookMessageDeserializerTest.java > 3724fd5f > > > Diff: https://reviews.apache.org/r/62681/diff/3/ > > > Testing > --- > > - verified that large messages are compressed and split by Atlas hook, before > sending to Kafka > - verified that Atlas server processes compressed, multi-part messages > correctly > > > Thanks, > > Madhan Neethiraj > >
Re: Review Request 62681: ATLAS-2075: notification enhancement to handle large messages, using compression and multi-part messages
> On Sept. 29, 2017, 3:15 a.m., Madhan Neethiraj wrote: > > notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java > > Lines 163 (patched) > > <https://reviews.apache.org/r/62681/diff/2/?file=1839348#file1839348line163> > > > > This call is already used in Atlas (and in Ranger as well) to generate > > GUIDs. Do you have suggestions/reference for a more efficient way? Please take a look at generateNextAuditEventId() in https://git-wip-us.apache.org/repos/asf?p=ranger.git;a=blob;f=agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java;h=0e124f1a65da05bec6ecbbb523907bfd3d2375ab;hb=refs/heads/master - Abhay --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62681/#review186630 --- On Sept. 29, 2017, 6:30 a.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62681/ > --- > > (Updated Sept. 29, 2017, 6:30 a.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Abhay Kulkarni, > Sarath Subramanian, and Suma Shivaprasad. > > > Bugs: ATLAS-2075 > https://issues.apache.org/jira/browse/ATLAS-2075 > > > Repository: atlas > > > Description > --- > > Update notification module to compress and split large messages (> 1mb) that > can't be sent via Kafka. When such a message is sent, the message is first > compressed via GZip. If compressed message is within the size limit, the > message is sent via Kafka. If the compressed size is larger, then the message > is split into multiple small messages and sent via Kafka. > > Notification consumer is updated to merge and uncompress messages before the > message is processed further. > > > Diffs > - > > common/src/main/java/org/apache/atlas/AtlasConfiguration.java 9a9bb76a > notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaConsumer.java > d3b4e49e > notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java > 38889ef8 > > notification/src/main/java/org/apache/atlas/notification/AbstractMessageDeserializer.java > ec99372d > > notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java > cb44fc68 > > notification/src/main/java/org/apache/atlas/notification/AtlasNotificationBaseMessage.java > PRE-CREATION > > notification/src/main/java/org/apache/atlas/notification/AtlasNotificationMessageDeserializer.java > PRE-CREATION > > notification/src/main/java/org/apache/atlas/notification/AtlasNotificationStringMessage.java > PRE-CREATION > > notification/src/main/java/org/apache/atlas/notification/MessageVersion.java > 6ef407ac > > notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java > 956c85e0 > > notification/src/main/java/org/apache/atlas/notification/VersionedMessage.java > 1929eb46 > > notification/src/main/java/org/apache/atlas/notification/VersionedMessageDeserializer.java > cc2099e7 > notification/src/test/java/org/apache/atlas/kafka/KafkaConsumerTest.java > 9b712f44 > > notification/src/test/java/org/apache/atlas/kafka/KafkaNotificationMockTest.java > b7474a0e > > notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java > 3b2a093b > > notification/src/test/java/org/apache/atlas/notification/AbstractNotificationTest.java > 61107a9f > > notification/src/test/java/org/apache/atlas/notification/VersionedMessageTest.java > 587b7ebd > > notification/src/test/java/org/apache/atlas/notification/entity/EntityMessageDeserializerTest.java > be324277 > > notification/src/test/java/org/apache/atlas/notification/hook/HookMessageDeserializerTest.java > 3724fd5f > > > Diff: https://reviews.apache.org/r/62681/diff/3/ > > > Testing > --- > > - verified that large messages are compressed and split by Atlas hook, before > sending to Kafka > - verified that Atlas server processes compressed, multi-part messages > correctly > > > Thanks, > > Madhan Neethiraj > >
Re: Review Request 62681: ATLAS-2075: notification enhancement to handle large messages, using compression and multi-part messages
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62681/#review186624 --- notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java Lines 163 (patched) <https://reviews.apache.org/r/62681/#comment263337> Consider using a more efficient way to generating msgId strings. notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java Lines 168 (patched) <https://reviews.apache.org/r/62681/#comment263339> Is it possible that compressedMsg will be longer than msgJson? If so, will it be better to send uncompressed msgJson? notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java Lines 177 (patched) <https://reviews.apache.org/r/62681/#comment263338> Consider more efficient way of generating msgId string. notification/src/main/java/org/apache/atlas/notification/AlasNotificationMessageDeserializer.java Lines 36 (patched) <https://reviews.apache.org/r/62681/#comment26> Please rename this class appropriately to AtlasNotificationMessageDeserializer. notification/src/main/java/org/apache/atlas/notification/AlasNotificationMessageDeserializer.java Lines 74 (patched) <https://reviews.apache.org/r/62681/#comment263336> Consider using a local variable to store store msgJson. Using formal argument to store changing value of msgJson is confusing to read. Is this API called in a thread-safe way? notification/src/main/java/org/apache/atlas/notification/AlasNotificationMessageDeserializer.java Lines 80 (patched) <https://reviews.apache.org/r/62681/#comment263334> Is there a specific test case for this? If not, please consider writing one. notification/src/main/java/org/apache/atlas/notification/AlasNotificationMessageDeserializer.java Lines 90 (patched) <https://reviews.apache.org/r/62681/#comment263335> Please consider logging this as ERROR. This should never happen! notification/src/main/java/org/apache/atlas/notification/AlasNotificationMessageDeserializer.java Lines 138 (patched) <https://reviews.apache.org/r/62681/#comment263340> Consider adding another validation to ensure that the msgStr's size is equal to or less than MESSAGE_MAX_LENGTH. - Abhay Kulkarni On Sept. 29, 2017, 12:26 a.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62681/ > --- > > (Updated Sept. 29, 2017, 12:26 a.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Abhay Kulkarni, > Sarath Subramanian, and Suma Shivaprasad. > > > Bugs: ATLAS-2075 > https://issues.apache.org/jira/browse/ATLAS-2075 > > > Repository: atlas > > > Description > --- > > Update notification module to compress and split large messages (> 1mb) that > can't be sent via Kafka. When such a message is sent, the message is first > compressed via GZip. If compressed message is within the size limit, the > message is sent via Kafka. If the compressed size is larger, then the message > is split into multiple small messages and sent via Kafka. > > Notification consumer is updated to merge and uncompress messages before the > message is processed further. > > > Diffs > - > > common/src/main/java/org/apache/atlas/AtlasConfiguration.java 9a9bb76a > notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaConsumer.java > d3b4e49e > notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java > 38889ef8 > > notification/src/main/java/org/apache/atlas/notification/AbstractMessageDeserializer.java > ec99372d > > notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java > cb44fc68 > > notification/src/main/java/org/apache/atlas/notification/AlasNotificationMessageDeserializer.java > PRE-CREATION > > notification/src/main/java/org/apache/atlas/notification/AtlasNotificationBaseMessage.java > PRE-CREATION > > notification/src/main/java/org/apache/atlas/notification/AtlasNotificationStringMessage.java > PRE-CREATION > > notification/src/main/java/org/apache/atlas/notification/MessageVersion.java > 6ef407ac > > notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java > 956c85e0 > > notification/src/main/java/org/apache/atlas/notification/VersionedMessage.java > 1929eb46 > > notification/src/main/java/org/apache/atlas/notification/VersionedMessageDeserializer.java > cc2099e7
