Re: Review Request 72730: ATLAS-3875: Introduce AtlasClient in Python
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72730/ --- (Updated Aug. 17, 2020, 4:13 a.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra. Bugs: ATLAS-3875 https://issues.apache.org/jira/browse/ATLAS-3875 Repository: atlas Description (updated) --- - Added basic structure for Python client - This includes all classes for Entity and TypeDef - Added all endpoints for typedef, Entity, Glossary, Lineage and Relationship - Added Python Sample project to test basic APIs and as a guideline - Added logging and readme file Diffs - .gitignore 90ca27646 atlas-examples/sample-app/src/main/python/README.md PRE-CREATION atlas-examples/sample-app/src/main/python/discovery_example.py PRE-CREATION atlas-examples/sample-app/src/main/python/entity_example.py PRE-CREATION atlas-examples/sample-app/src/main/python/glossary_example.py PRE-CREATION atlas-examples/sample-app/src/main/python/lineage_example.py PRE-CREATION atlas-examples/sample-app/src/main/python/request_json/entity_create_db.json PRE-CREATION atlas-examples/sample-app/src/main/python/request_json/entity_create_process.json PRE-CREATION atlas-examples/sample-app/src/main/python/request_json/entity_create_table_canada.json PRE-CREATION atlas-examples/sample-app/src/main/python/request_json/entity_create_table_us.json PRE-CREATION atlas-examples/sample-app/src/main/python/request_json/typedef_create.json PRE-CREATION atlas-examples/sample-app/src/main/python/sample_client.py PRE-CREATION atlas-examples/sample-app/src/main/python/typedef_example.py PRE-CREATION atlas-examples/sample-app/src/main/python/utils.py PRE-CREATION client/client-v2/src/main/python/LICENSE PRE-CREATION client/client-v2/src/main/python/README.md PRE-CREATION client/client-v2/src/main/python/atlas_client/__init__.py PRE-CREATION client/client-v2/src/main/python/atlas_client/base_client.py PRE-CREATION client/client-v2/src/main/python/atlas_client/client/__init__.py PRE-CREATION client/client-v2/src/main/python/atlas_client/client/discovery.py PRE-CREATION client/client-v2/src/main/python/atlas_client/client/entity.py PRE-CREATION client/client-v2/src/main/python/atlas_client/client/glossary.py PRE-CREATION client/client-v2/src/main/python/atlas_client/client/lineage.py PRE-CREATION client/client-v2/src/main/python/atlas_client/client/relationship.py PRE-CREATION client/client-v2/src/main/python/atlas_client/client/typedef.py PRE-CREATION client/client-v2/src/main/python/atlas_client/exceptions.py PRE-CREATION client/client-v2/src/main/python/atlas_client/model/__init__.py PRE-CREATION client/client-v2/src/main/python/atlas_client/model/discovery.py PRE-CREATION client/client-v2/src/main/python/atlas_client/model/entity.py PRE-CREATION client/client-v2/src/main/python/atlas_client/model/glossary.py PRE-CREATION client/client-v2/src/main/python/atlas_client/model/lineage.py PRE-CREATION client/client-v2/src/main/python/atlas_client/model/relationship.py PRE-CREATION client/client-v2/src/main/python/atlas_client/model/typedef.py PRE-CREATION client/client-v2/src/main/python/atlas_client/utils.py PRE-CREATION client/client-v2/src/main/python/requirements.txt PRE-CREATION client/client-v2/src/main/python/setup.py PRE-CREATION client/client-v2/src/main/python/tests/__init__.py PRE-CREATION client/client-v2/src/main/resources/logging.conf PRE-CREATION Diff: https://reviews.apache.org/r/72730/diff/5/ Testing --- Tested on local. Thanks, Jyoti Singh
Re: Review Request 72730: ATLAS-3875: Introduce AtlasClient in Python
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72730/ --- (Updated Aug. 17, 2020, 4:07 a.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra. Changes --- Code Review Related Change Bugs: ATLAS-3875 https://issues.apache.org/jira/browse/ATLAS-3875 Repository: atlas Description --- - Added basic structure for Python client - This includes all classes for Entity and TypeDef - Added all endpoints for typedef Diffs (updated) - .gitignore 90ca27646 atlas-examples/sample-app/src/main/python/README.md PRE-CREATION atlas-examples/sample-app/src/main/python/discovery_example.py PRE-CREATION atlas-examples/sample-app/src/main/python/entity_example.py PRE-CREATION atlas-examples/sample-app/src/main/python/glossary_example.py PRE-CREATION atlas-examples/sample-app/src/main/python/lineage_example.py PRE-CREATION atlas-examples/sample-app/src/main/python/request_json/entity_create_db.json PRE-CREATION atlas-examples/sample-app/src/main/python/request_json/entity_create_process.json PRE-CREATION atlas-examples/sample-app/src/main/python/request_json/entity_create_table_canada.json PRE-CREATION atlas-examples/sample-app/src/main/python/request_json/entity_create_table_us.json PRE-CREATION atlas-examples/sample-app/src/main/python/request_json/typedef_create.json PRE-CREATION atlas-examples/sample-app/src/main/python/sample_client.py PRE-CREATION atlas-examples/sample-app/src/main/python/typedef_example.py PRE-CREATION atlas-examples/sample-app/src/main/python/utils.py PRE-CREATION client/client-v2/src/main/python/LICENSE PRE-CREATION client/client-v2/src/main/python/README.md PRE-CREATION client/client-v2/src/main/python/atlas_client/__init__.py PRE-CREATION client/client-v2/src/main/python/atlas_client/base_client.py PRE-CREATION client/client-v2/src/main/python/atlas_client/client/__init__.py PRE-CREATION client/client-v2/src/main/python/atlas_client/client/discovery.py PRE-CREATION client/client-v2/src/main/python/atlas_client/client/entity.py PRE-CREATION client/client-v2/src/main/python/atlas_client/client/glossary.py PRE-CREATION client/client-v2/src/main/python/atlas_client/client/lineage.py PRE-CREATION client/client-v2/src/main/python/atlas_client/client/relationship.py PRE-CREATION client/client-v2/src/main/python/atlas_client/client/typedef.py PRE-CREATION client/client-v2/src/main/python/atlas_client/exceptions.py PRE-CREATION client/client-v2/src/main/python/atlas_client/model/__init__.py PRE-CREATION client/client-v2/src/main/python/atlas_client/model/discovery.py PRE-CREATION client/client-v2/src/main/python/atlas_client/model/entity.py PRE-CREATION client/client-v2/src/main/python/atlas_client/model/glossary.py PRE-CREATION client/client-v2/src/main/python/atlas_client/model/lineage.py PRE-CREATION client/client-v2/src/main/python/atlas_client/model/relationship.py PRE-CREATION client/client-v2/src/main/python/atlas_client/model/typedef.py PRE-CREATION client/client-v2/src/main/python/atlas_client/utils.py PRE-CREATION client/client-v2/src/main/python/requirements.txt PRE-CREATION client/client-v2/src/main/python/setup.py PRE-CREATION client/client-v2/src/main/python/tests/__init__.py PRE-CREATION client/client-v2/src/main/resources/logging.conf PRE-CREATION Diff: https://reviews.apache.org/r/72730/diff/5/ Changes: https://reviews.apache.org/r/72730/diff/4-5/ Testing --- Tested on local. Thanks, Jyoti Singh
Re: Review Request 72730: ATLAS-3875: Introduce AtlasClient in Python
> On Aug. 11, 2020, 6:50 p.m., Sidharth Mishra wrote: > > client/client-v2/src/main/python/atlas_client/discovery_model.py > > Lines 22 (patched) > > <https://reviews.apache.org/r/72730/diff/4/?file=2237707#file2237707line22> > > > > Please remove one extra blank line (we always keep one blank line as > > separator if needed) For Python classes we have to add 2 blank lines between imports and class name. https://www.python.org/dev/peps/pep-0008/#blank-lines - Jyoti --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72730/#review221546 ------- On Aug. 10, 2020, 5:26 p.m., Jyoti Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72730/ > --- > > (Updated Aug. 10, 2020, 5:26 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath > Subramanian, and Sidharth Mishra. > > > Bugs: ATLAS-3875 > https://issues.apache.org/jira/browse/ATLAS-3875 > > > Repository: atlas > > > Description > --- > > - Added basic structure for Python client > - This includes all classes for Entity and TypeDef > - Added all endpoints for typedef > > > Diffs > - > > atlas-examples/sample-app/src/main/python/discovery_example.py PRE-CREATION > atlas-examples/sample-app/src/main/python/entity_example.py PRE-CREATION > atlas-examples/sample-app/src/main/python/glossary_example.py PRE-CREATION > atlas-examples/sample-app/src/main/python/lineage_example.py PRE-CREATION > > atlas-examples/sample-app/src/main/python/request_json/entity_create_db.json > PRE-CREATION > > atlas-examples/sample-app/src/main/python/request_json/entity_create_process.json > PRE-CREATION > > atlas-examples/sample-app/src/main/python/request_json/entity_create_table_canada.json > PRE-CREATION > > atlas-examples/sample-app/src/main/python/request_json/entity_create_table_us.json > PRE-CREATION > atlas-examples/sample-app/src/main/python/request_json/typedef_create.json > PRE-CREATION > atlas-examples/sample-app/src/main/python/sample_client.py PRE-CREATION > atlas-examples/sample-app/src/main/python/typedef_example.py PRE-CREATION > atlas-examples/sample-app/src/main/python/utils.py PRE-CREATION > client/client-v2/src/main/python/LICENSE PRE-CREATION > client/client-v2/src/main/python/README.md PRE-CREATION > client/client-v2/src/main/python/atlas_client/__init__.py PRE-CREATION > client/client-v2/src/main/python/atlas_client/base_client.py PRE-CREATION > client/client-v2/src/main/python/atlas_client/discovery_client.py > PRE-CREATION > client/client-v2/src/main/python/atlas_client/discovery_model.py > PRE-CREATION > client/client-v2/src/main/python/atlas_client/entity_client.py PRE-CREATION > client/client-v2/src/main/python/atlas_client/entity_model.py PRE-CREATION > client/client-v2/src/main/python/atlas_client/glossary_client.py > PRE-CREATION > client/client-v2/src/main/python/atlas_client/glossary_model.py > PRE-CREATION > client/client-v2/src/main/python/atlas_client/lineage_client.py > PRE-CREATION > client/client-v2/src/main/python/atlas_client/lineage_model.py PRE-CREATION > client/client-v2/src/main/python/atlas_client/relationship_client.py > PRE-CREATION > client/client-v2/src/main/python/atlas_client/relationship_model.py > PRE-CREATION > client/client-v2/src/main/python/atlas_client/typedef_client.py > PRE-CREATION > client/client-v2/src/main/python/atlas_client/typedef_model.py PRE-CREATION > client/client-v2/src/main/python/atlas_client/utils.py PRE-CREATION > client/client-v2/src/main/python/requirements.txt PRE-CREATION > client/client-v2/src/main/python/setup.py PRE-CREATION > client/client-v2/src/main/python/tests/__init__.py PRE-CREATION > client/client-v2/src/main/resources/logging.conf PRE-CREATION > > > Diff: https://reviews.apache.org/r/72730/diff/4/ > > > Testing > --- > > Tested on local. > > > Thanks, > > Jyoti Singh > >
[jira] [Updated] (ATLAS-3875) Adding missing APIs in AtlasClient with test cases
[ https://issues.apache.org/jira/browse/ATLAS-3875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jyoti Singh updated ATLAS-3875: --- Attachment: ATLAS-3875-2.patch > Adding missing APIs in AtlasClient with test cases > -- > > Key: ATLAS-3875 > URL: https://issues.apache.org/jira/browse/ATLAS-3875 > Project: Atlas > Issue Type: Improvement > Components: atlas-core >Affects Versions: 2.0.0, 2.1.0 > Reporter: Jyoti Singh >Assignee: Jyoti Singh >Priority: Major > Labels: api, client > Fix For: 3.0.0, 2.2.0 > > Attachments: ATLAS-3875-1.patch, ATLAS-3875-2.patch, > ATLAS-3875-4.patch > > > 1. There are many new APIs added to Atlas Project but the corresponding APIs > are missing from AtlasClientv2. The aim of this task is to complete the gap > amongst existing APIs and their endpoints in Atls client. This will also > include adding test cases via integration testing. > There are functions from AtlasClient for the following REST endpoints > * TypeRest > * EntityRest > * LineageRest > * DiscoveryRest > * GlossaryRest > * RelationshipRest > 2. Added Sample-Project to showcase how to integrate with Atlas using > AtlasCleint. This helps the user to understand the basic rest functionality > of Atlas. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: Review Request 72730: ATLAS-3875: Introduce AtlasClient in Python
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72730/ --- (Updated Aug. 10, 2020, 5:26 p.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra. Bugs: ATLAS-3875 https://issues.apache.org/jira/browse/ATLAS-3875 Repository: atlas Description --- - Added basic structure for Python client - This includes all classes for Entity and TypeDef - Added all endpoints for typedef Diffs (updated) - atlas-examples/sample-app/src/main/python/discovery_example.py PRE-CREATION atlas-examples/sample-app/src/main/python/entity_example.py PRE-CREATION atlas-examples/sample-app/src/main/python/glossary_example.py PRE-CREATION atlas-examples/sample-app/src/main/python/lineage_example.py PRE-CREATION atlas-examples/sample-app/src/main/python/request_json/entity_create_db.json PRE-CREATION atlas-examples/sample-app/src/main/python/request_json/entity_create_process.json PRE-CREATION atlas-examples/sample-app/src/main/python/request_json/entity_create_table_canada.json PRE-CREATION atlas-examples/sample-app/src/main/python/request_json/entity_create_table_us.json PRE-CREATION atlas-examples/sample-app/src/main/python/request_json/typedef_create.json PRE-CREATION atlas-examples/sample-app/src/main/python/sample_client.py PRE-CREATION atlas-examples/sample-app/src/main/python/typedef_example.py PRE-CREATION atlas-examples/sample-app/src/main/python/utils.py PRE-CREATION client/client-v2/src/main/python/LICENSE PRE-CREATION client/client-v2/src/main/python/README.md PRE-CREATION client/client-v2/src/main/python/atlas_client/__init__.py PRE-CREATION client/client-v2/src/main/python/atlas_client/base_client.py PRE-CREATION client/client-v2/src/main/python/atlas_client/discovery_client.py PRE-CREATION client/client-v2/src/main/python/atlas_client/discovery_model.py PRE-CREATION client/client-v2/src/main/python/atlas_client/entity_client.py PRE-CREATION client/client-v2/src/main/python/atlas_client/entity_model.py PRE-CREATION client/client-v2/src/main/python/atlas_client/glossary_client.py PRE-CREATION client/client-v2/src/main/python/atlas_client/glossary_model.py PRE-CREATION client/client-v2/src/main/python/atlas_client/lineage_client.py PRE-CREATION client/client-v2/src/main/python/atlas_client/lineage_model.py PRE-CREATION client/client-v2/src/main/python/atlas_client/relationship_client.py PRE-CREATION client/client-v2/src/main/python/atlas_client/relationship_model.py PRE-CREATION client/client-v2/src/main/python/atlas_client/typedef_client.py PRE-CREATION client/client-v2/src/main/python/atlas_client/typedef_model.py PRE-CREATION client/client-v2/src/main/python/atlas_client/utils.py PRE-CREATION client/client-v2/src/main/python/requirements.txt PRE-CREATION client/client-v2/src/main/python/setup.py PRE-CREATION client/client-v2/src/main/python/tests/__init__.py PRE-CREATION client/client-v2/src/main/resources/logging.conf PRE-CREATION Diff: https://reviews.apache.org/r/72730/diff/4/ Changes: https://reviews.apache.org/r/72730/diff/3-4/ Testing --- Tested on local. Thanks, Jyoti Singh
Re: Review Request 72730: ATLAS-3875: Introduce AtlasClient in Python
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72730/ --- (Updated Aug. 6, 2020, 3:31 a.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra. Bugs: ATLAS-3875 https://issues.apache.org/jira/browse/ATLAS-3875 Repository: atlas Description --- - Added basic structure for Python client - This includes all classes for Entity and TypeDef - Added all endpoints for typedef Diffs (updated) - atlas-examples/sample-app/src/main/python/sample_client.py PRE-CREATION client/client-v2/src/main/python/LICENSE PRE-CREATION client/client-v2/src/main/python/README.md PRE-CREATION client/client-v2/src/main/python/atlas_client/__init__.py PRE-CREATION client/client-v2/src/main/python/atlas_client/atlas_discovery.py PRE-CREATION client/client-v2/src/main/python/atlas_client/atlas_entity.py PRE-CREATION client/client-v2/src/main/python/atlas_client/atlas_glossary.py PRE-CREATION client/client-v2/src/main/python/atlas_client/atlas_lineage.py PRE-CREATION client/client-v2/src/main/python/atlas_client/atlas_typedef.py PRE-CREATION client/client-v2/src/main/python/atlas_client/base_client.py PRE-CREATION client/client-v2/src/main/python/atlas_client/discovery_client.py PRE-CREATION client/client-v2/src/main/python/atlas_client/entity_client.py PRE-CREATION client/client-v2/src/main/python/atlas_client/glossary_client.py PRE-CREATION client/client-v2/src/main/python/atlas_client/lineage_client.py PRE-CREATION client/client-v2/src/main/python/atlas_client/relationship_client.py PRE-CREATION client/client-v2/src/main/python/atlas_client/typedef_client.py PRE-CREATION client/client-v2/src/main/python/atlas_client/utils.py PRE-CREATION client/client-v2/src/main/python/requirements.txt PRE-CREATION client/client-v2/src/main/python/setup.py PRE-CREATION client/client-v2/src/main/python/tests/__init__.py PRE-CREATION client/client-v2/src/main/resources/logging.conf PRE-CREATION Diff: https://reviews.apache.org/r/72730/diff/3/ Changes: https://reviews.apache.org/r/72730/diff/2-3/ Testing --- Tested on local. Thanks, Jyoti Singh
Re: Review Request 72698: ATLAS-3875: Introduce sample project for AtlasClient
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72698/ --- (Updated Aug. 4, 2020, 4:27 p.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra. Bugs: ATLAS-3875 https://issues.apache.org/jira/browse/ATLAS-3875 Repository: atlas Description --- Using this project users can get an idea as how to integrate with Atlas using AtlasCleint. This helps the user to understand the basic rest functionality of Atlas such as - EntityRest - TypeDefRest - DiscoveryRest - LineageRest - GlossaryRest Diffs (updated) - atlas-examples/pom.xml PRE-CREATION atlas-examples/sample-app/README.md PRE-CREATION atlas-examples/sample-app/pom.xml PRE-CREATION atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/DiscoveryExample.java PRE-CREATION atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/EntityExample.java PRE-CREATION atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/GlossaryExample.java PRE-CREATION atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/LineageExample.java PRE-CREATION atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleApp.java PRE-CREATION atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleAppConstants.java PRE-CREATION atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/TypeDefExample.java PRE-CREATION atlas-examples/sample-app/src/main/resources/atlas-application.properties PRE-CREATION pom.xml 5e0442ae5 Diff: https://reviews.apache.org/r/72698/diff/7/ Changes: https://reviews.apache.org/r/72698/diff/6-7/ Testing --- Thanks, Jyoti Singh
Re: Review Request 72698: ATLAS-3875: Introduce sample project for AtlasClient
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72698/ --- (Updated Aug. 4, 2020, 4:05 p.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra. Bugs: ATLAS-3875 https://issues.apache.org/jira/browse/ATLAS-3875 Repository: atlas Description --- Using this project users can get an idea as how to integrate with Atlas using AtlasCleint. This helps the user to understand the basic rest functionality of Atlas such as - EntityRest - TypeDefRest - DiscoveryRest - LineageRest - GlossaryRest Diffs (updated) - atlas-examples/pom.xml PRE-CREATION atlas-examples/sample-app/README.md PRE-CREATION atlas-examples/sample-app/pom.xml PRE-CREATION atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/DiscoveryExample.java PRE-CREATION atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/EntityExample.java PRE-CREATION atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/GlossaryExample.java PRE-CREATION atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/LineageExample.java PRE-CREATION atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleApp.java PRE-CREATION atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleAppConstants.java PRE-CREATION atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/TypeDefExample.java PRE-CREATION atlas-examples/sample-app/src/main/resources/atlas-application.properties PRE-CREATION Diff: https://reviews.apache.org/r/72698/diff/6/ Changes: https://reviews.apache.org/r/72698/diff/5-6/ Testing --- Thanks, Jyoti Singh
Re: Review Request 72730: ATLAS-3875: Introduce AtlasClient in Python
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72730/ --- (Updated Aug. 3, 2020, 6 p.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra. Bugs: ATLAS-3875 https://issues.apache.org/jira/browse/ATLAS-3875 Repository: atlas Description --- - Added basic structure for Python client - This includes all classes for Entity and TypeDef - Added all endpoints for typedef Diffs (updated) - client/client-v2/src/main/python/atlas_discovery.py PRE-CREATION client/client-v2/src/main/python/atlas_entity.py PRE-CREATION client/client-v2/src/main/python/atlas_typedef.py PRE-CREATION client/client-v2/src/main/python/base_client.py PRE-CREATION client/client-v2/src/main/python/entity_client.py PRE-CREATION client/client-v2/src/main/python/glossary.py PRE-CREATION client/client-v2/src/main/python/typedef_client.py PRE-CREATION client/client-v2/src/main/python/utils.py PRE-CREATION Diff: https://reviews.apache.org/r/72730/diff/2/ Changes: https://reviews.apache.org/r/72730/diff/1-2/ Testing --- Tested on local. Thanks, Jyoti Singh
Review Request 72730: ATLAS-3875: Introduce AtlasClient in Python
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72730/ --- Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra. Bugs: ATLAS-3875 https://issues.apache.org/jira/browse/ATLAS-3875 Repository: atlas Description --- - Added basic structure for Python client - This includes all classes for Entity and TypeDef - Added all endpoints for typedef Diffs - client/client-v2/src/main/python/atlas_discovery.py PRE-CREATION client/client-v2/src/main/python/atlas_entity.py PRE-CREATION client/client-v2/src/main/python/atlas_typedef.py PRE-CREATION client/client-v2/src/main/python/base_client.py PRE-CREATION client/client-v2/src/main/python/entity_client.py PRE-CREATION client/client-v2/src/main/python/glossary.py PRE-CREATION client/client-v2/src/main/python/typedef_client.py PRE-CREATION client/client-v2/src/main/python/utils.py PRE-CREATION Diff: https://reviews.apache.org/r/72730/diff/1/ Testing --- Tested on local. Thanks, Jyoti Singh
[jira] [Updated] (ATLAS-3875) Adding missing APIs in AtlasClient with test cases
[ https://issues.apache.org/jira/browse/ATLAS-3875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jyoti Singh updated ATLAS-3875: --- Description: 1. There are many new APIs added to Atlas Project but the corresponding APIs are missing from AtlasClientv2. The aim of this task is to complete the gap amongst existing APIs and their endpoints in Atls client. This will also include adding test cases via integration testing. There are functions from AtlasClient for the following REST endpoints * TypeRest * EntityRest * LineageRest * DiscoveryRest * GlossaryRest * RelationshipRest 2. Added Sample-Project to showcase how to integrate with Atlas using AtlasCleint. This helps the user to understand the basic rest functionality of Atlas. was: There are many new APIs added to Atlas Project but the corresponding APIs are missing from AtlasClientv2. The aim of this task is to complete the gap amongst existing APIs and their endpoints in Atls client. This will also include adding test cases via integration testing. There are functions from AtlasClient for the following REST endpoints * TypeRest * EntityRest * LineageRest * DiscoveryRest * GlossaryRest * RelationshipRest > Adding missing APIs in AtlasClient with test cases > -- > > Key: ATLAS-3875 > URL: https://issues.apache.org/jira/browse/ATLAS-3875 > Project: Atlas > Issue Type: Improvement > Components: atlas-core >Affects Versions: 2.0.0, 2.1.0 > Reporter: Jyoti Singh >Assignee: Jyoti Singh >Priority: Major > Labels: api, client > Fix For: 3.0.0, 2.2.0 > > Attachments: ATLAS-3875-1.patch, ATLAS-3875-4.patch > > > 1. There are many new APIs added to Atlas Project but the corresponding APIs > are missing from AtlasClientv2. The aim of this task is to complete the gap > amongst existing APIs and their endpoints in Atls client. This will also > include adding test cases via integration testing. > There are functions from AtlasClient for the following REST endpoints > * TypeRest > * EntityRest > * LineageRest > * DiscoveryRest > * GlossaryRest > * RelationshipRest > 2. Added Sample-Project to showcase how to integrate with Atlas using > AtlasCleint. This helps the user to understand the basic rest functionality > of Atlas. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3875) Adding missing APIs in AtlasClient with test cases
[ https://issues.apache.org/jira/browse/ATLAS-3875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jyoti Singh updated ATLAS-3875: --- Attachment: ATLAS-3875-4.patch > Adding missing APIs in AtlasClient with test cases > -- > > Key: ATLAS-3875 > URL: https://issues.apache.org/jira/browse/ATLAS-3875 > Project: Atlas > Issue Type: Improvement > Components: atlas-core >Affects Versions: 2.0.0, 2.1.0 > Reporter: Jyoti Singh >Assignee: Jyoti Singh >Priority: Major > Labels: api, client > Fix For: 3.0.0, 2.2.0 > > Attachments: ATLAS-3875-1.patch, ATLAS-3875-4.patch > > > There are many new APIs added to Atlas Project but the corresponding APIs > are missing from AtlasClientv2. The aim of this task is to complete the gap > amongst existing APIs and their endpoints in Atls client. This will also > include adding test cases via integration testing. > There are functions from AtlasClient for the following REST endpoints > * TypeRest > * EntityRest > * LineageRest > * DiscoveryRest > * GlossaryRest > * RelationshipRest -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: Review Request 72698: ATLAS-3875: Introduce sample project for AtlasClient
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72698/ --- (Updated July 27, 2020, 8:06 p.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra. Bugs: ATLAS-3875 https://issues.apache.org/jira/browse/ATLAS-3875 Repository: atlas Description --- Using this project users can get an idea as how to integrate with Atlas using AtlasCleint. This helps the user to understand the basic rest functionality of Atlas such as - EntityRest - TypeDefRest - DiscoveryRest - LineageRest - GlossaryRest Diffs (updated) - atlas-examples/pom.xml PRE-CREATION atlas-examples/sample-app/README.md PRE-CREATION atlas-examples/sample-app/pom.xml PRE-CREATION atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/DiscoveryExample.java PRE-CREATION atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/EntityExample.java PRE-CREATION atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/GlossaryExample.java PRE-CREATION atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/LineageExample.java PRE-CREATION atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleApp.java PRE-CREATION atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleAppConstants.java PRE-CREATION atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/TypeDefExample.java PRE-CREATION atlas-examples/sample-app/src/main/resources/atlas-application.properties PRE-CREATION pom.xml 5e0442ae5 Diff: https://reviews.apache.org/r/72698/diff/5/ Changes: https://reviews.apache.org/r/72698/diff/4-5/ Testing --- Thanks, Jyoti Singh
Re: Review Request 72698: ATLAS-3875: Introduce sample project for AtlasClient
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72698/ --- (Updated July 27, 2020, 7:57 p.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra. Bugs: ATLAS-3875 https://issues.apache.org/jira/browse/ATLAS-3875 Repository: atlas Description --- Using this project users can get an idea as how to integrate with Atlas using AtlasCleint. This helps the user to understand the basic rest functionality of Atlas such as - EntityRest - TypeDefRest - DiscoveryRest - LineageRest - GlossaryRest Diffs (updated) - atlas-examples/pom.xml PRE-CREATION atlas-examples/sample-app/README.md PRE-CREATION atlas-examples/sample-app/pom.xml PRE-CREATION atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/DiscoveryExample.java PRE-CREATION atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/EntityExample.java PRE-CREATION atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/GlossaryExample.java PRE-CREATION atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/LineageExample.java PRE-CREATION atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleApp.java PRE-CREATION atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleAppConstants.java PRE-CREATION atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/TypeDefExample.java PRE-CREATION atlas-examples/sample-app/src/main/resources/atlas-application.properties PRE-CREATION pom.xml 5e0442ae5 Diff: https://reviews.apache.org/r/72698/diff/4/ Changes: https://reviews.apache.org/r/72698/diff/3-4/ Testing --- Thanks, Jyoti Singh
Re: Review Request 72698: ATLAS-3875: Introduce sample project for AtlasClient
> On July 26, 2020, 8:15 p.m., Madhan Neethiraj wrote: > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/TypeDefExample.java > > Lines 94 (patched) > > <https://reviews.apache.org/r/72698/diff/3/?file=2236178#file2236178line94> > > > > getAllTypeDef() implies some return value. The implementation simply > > retrieves and prints type-defs. This function is an example to show how to use getAPI for TypeDef. It is just printing the GET Api result so renamed it to printAllTypeDefinitions. - Jyoti --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72698/#review221372 ------- On July 23, 2020, 6:10 p.m., Jyoti Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72698/ > --- > > (Updated July 23, 2020, 6:10 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath > Subramanian, and Sidharth Mishra. > > > Bugs: ATLAS-3875 > https://issues.apache.org/jira/browse/ATLAS-3875 > > > Repository: atlas > > > Description > --- > > Using this project users can get an idea as how to integrate with Atlas using > AtlasCleint. This helps the user to understand the basic rest functionality > of Atlas such as > > - EntityRest > - TypeDefRest > - DiscoveryRest > - LineageRest > - GlossaryRest > > > Diffs > - > > atlas-examples/pom.xml PRE-CREATION > atlas-examples/sample-app/README.md PRE-CREATION > atlas-examples/sample-app/pom.xml PRE-CREATION > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/DiscoveryExample.java > PRE-CREATION > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/EntityExample.java > PRE-CREATION > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/GlossaryExample.java > PRE-CREATION > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/LineageExample.java > PRE-CREATION > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleApp.java > PRE-CREATION > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleAppConstants.java > PRE-CREATION > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/TypeDefExample.java > PRE-CREATION > atlas-examples/sample-app/src/main/resources/atlas-application.properties > PRE-CREATION > pom.xml 5e0442ae5 > > > Diff: https://reviews.apache.org/r/72698/diff/3/ > > > Testing > --- > > > Thanks, > > Jyoti Singh > >
Re: Review Request 72698: ATLAS-3875: Introduce sample project for AtlasClient
> On July 22, 2020, 7:24 p.m., Sidharth Mishra wrote: > > atlas-examples/src/main/java/org/apache/atlas/AtlasClientBaseExample.java > > Lines 63 (patched) > > <https://reviews.apache.org/r/72698/diff/2/?file=2236103#file2236103line63> > > > > char[] is always preferred over String - check > > https://stackoverflow.com/questions/8881291/why-is-char-preferred-over-string-for-passwords#:~:text=Since%20Strings%20are%20immutable%20there,2. > > > > Please check if we can add a new contructor at client v2 and do this ow > > lets file a jira and track this for client v2 Need to change is seperate ticket as there is change in client also. - Jyoti --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72698/#review221321 --- On July 23, 2020, 6:10 p.m., Jyoti Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72698/ > --- > > (Updated July 23, 2020, 6:10 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath > Subramanian, and Sidharth Mishra. > > > Bugs: ATLAS-3875 > https://issues.apache.org/jira/browse/ATLAS-3875 > > > Repository: atlas > > > Description > --- > > Using this project users can get an idea as how to integrate with Atlas using > AtlasCleint. This helps the user to understand the basic rest functionality > of Atlas such as > > - EntityRest > - TypeDefRest > - DiscoveryRest > - LineageRest > - GlossaryRest > > > Diffs > - > > atlas-examples/pom.xml PRE-CREATION > atlas-examples/sample-app/README.md PRE-CREATION > atlas-examples/sample-app/pom.xml PRE-CREATION > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/DiscoveryExample.java > PRE-CREATION > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/EntityExample.java > PRE-CREATION > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/GlossaryExample.java > PRE-CREATION > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/LineageExample.java > PRE-CREATION > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleApp.java > PRE-CREATION > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleAppConstants.java > PRE-CREATION > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/TypeDefExample.java > PRE-CREATION > atlas-examples/sample-app/src/main/resources/atlas-application.properties > PRE-CREATION > pom.xml 5e0442ae5 > > > Diff: https://reviews.apache.org/r/72698/diff/3/ > > > Testing > --- > > > Thanks, > > Jyoti Singh > >
Re: Review Request 72698: ATLAS-3875: Introduce sample project for AtlasClient
> On July 22, 2020, 7:24 p.m., Sidharth Mishra wrote: > > atlas-examples/src/main/java/org/apache/atlas/AtlasClientBaseExample.java > > Lines 140 (patched) > > <https://reviews.apache.org/r/72698/diff/2/?file=2236103#file2236103line140> > > > > Please use Console.readPassword instead Not using this as it will throw exceptions in IDE. - Jyoti --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72698/#review221321 --- On July 23, 2020, 6:10 p.m., Jyoti Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72698/ > --- > > (Updated July 23, 2020, 6:10 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath > Subramanian, and Sidharth Mishra. > > > Bugs: ATLAS-3875 > https://issues.apache.org/jira/browse/ATLAS-3875 > > > Repository: atlas > > > Description > --- > > Using this project users can get an idea as how to integrate with Atlas using > AtlasCleint. This helps the user to understand the basic rest functionality > of Atlas such as > > - EntityRest > - TypeDefRest > - DiscoveryRest > - LineageRest > - GlossaryRest > > > Diffs > - > > atlas-examples/pom.xml PRE-CREATION > atlas-examples/sample-app/README.md PRE-CREATION > atlas-examples/sample-app/pom.xml PRE-CREATION > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/DiscoveryExample.java > PRE-CREATION > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/EntityExample.java > PRE-CREATION > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/GlossaryExample.java > PRE-CREATION > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/LineageExample.java > PRE-CREATION > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleApp.java > PRE-CREATION > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleAppConstants.java > PRE-CREATION > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/TypeDefExample.java > PRE-CREATION > atlas-examples/sample-app/src/main/resources/atlas-application.properties > PRE-CREATION > pom.xml 5e0442ae5 > > > Diff: https://reviews.apache.org/r/72698/diff/3/ > > > Testing > --- > > > Thanks, > > Jyoti Singh > >
Re: Review Request 72698: ATLAS-3875: Introduce sample project for AtlasClient
> On July 22, 2020, 7:24 p.m., Sidharth Mishra wrote: > > atlas-examples/src/main/java/org/apache/atlas/AtlasClientBaseExample.java > > Lines 86 (patched) > > <https://reviews.apache.org/r/72698/diff/2/?file=2236103#file2236103line86> > > > > Instead of commenting like typedef then entity examples etc. it would > > be good to move these to separate private functions. Please refer - > > > > FUNCTIONS SHOULD DO ONE THING. THEY SHOULD DO IT WELL. THEY SHOULD DO > > IT ONLY (more details - > > https://learning.oreilly.com/library/view/clean-code/9780136083238/chapter03.html#ch3) > > > > > > https://softwareengineering.stackexchange.com/questions/137941/should-a-method-do-one-thing-and-be-good-at-it We need to delete Type and entity at the end so not moving these inside function. - Jyoti --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72698/#review221321 --- On July 23, 2020, 6:10 p.m., Jyoti Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72698/ > --- > > (Updated July 23, 2020, 6:10 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath > Subramanian, and Sidharth Mishra. > > > Bugs: ATLAS-3875 > https://issues.apache.org/jira/browse/ATLAS-3875 > > > Repository: atlas > > > Description > --- > > Using this project users can get an idea as how to integrate with Atlas using > AtlasCleint. This helps the user to understand the basic rest functionality > of Atlas such as > > - EntityRest > - TypeDefRest > - DiscoveryRest > - LineageRest > - GlossaryRest > > > Diffs > - > > atlas-examples/pom.xml PRE-CREATION > atlas-examples/sample-app/README.md PRE-CREATION > atlas-examples/sample-app/pom.xml PRE-CREATION > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/DiscoveryExample.java > PRE-CREATION > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/EntityExample.java > PRE-CREATION > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/GlossaryExample.java > PRE-CREATION > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/LineageExample.java > PRE-CREATION > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleApp.java > PRE-CREATION > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleAppConstants.java > PRE-CREATION > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/TypeDefExample.java > PRE-CREATION > atlas-examples/sample-app/src/main/resources/atlas-application.properties > PRE-CREATION > pom.xml 5e0442ae5 > > > Diff: https://reviews.apache.org/r/72698/diff/3/ > > > Testing > --- > > > Thanks, > > Jyoti Singh > >
Re: Review Request 72698: ATLAS-3875: Introduce sample project for AtlasClient
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72698/ --- (Updated July 23, 2020, 6:10 p.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra. Changes --- adding code review change Bugs: ATLAS-3875 https://issues.apache.org/jira/browse/ATLAS-3875 Repository: atlas Description --- Using this project users can get an idea as how to integrate with Atlas using AtlasCleint. This helps the user to understand the basic rest functionality of Atlas such as - EntityRest - TypeDefRest - DiscoveryRest - LineageRest - GlossaryRest Diffs (updated) - atlas-examples/pom.xml PRE-CREATION atlas-examples/sample-app/README.md PRE-CREATION atlas-examples/sample-app/pom.xml PRE-CREATION atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/DiscoveryExample.java PRE-CREATION atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/EntityExample.java PRE-CREATION atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/GlossaryExample.java PRE-CREATION atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/LineageExample.java PRE-CREATION atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleApp.java PRE-CREATION atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleAppConstants.java PRE-CREATION atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/TypeDefExample.java PRE-CREATION atlas-examples/sample-app/src/main/resources/atlas-application.properties PRE-CREATION pom.xml 5e0442ae5 Diff: https://reviews.apache.org/r/72698/diff/3/ Changes: https://reviews.apache.org/r/72698/diff/2-3/ Testing --- Thanks, Jyoti Singh
Re: Review Request 72698: ATLAS-3875: Introduce sample project for AtlasClient
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72698/ --- (Updated July 21, 2020, 4:24 p.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra. Bugs: ATLAS-3875 https://issues.apache.org/jira/browse/ATLAS-3875 Repository: atlas Description --- Using this project users can get an idea as how to integrate with Atlas using AtlasCleint. This helps the user to understand the basic rest functionality of Atlas such as - EntityRest - TypeDefRest - DiscoveryRest - LineageRest - GlossaryRest Diffs (updated) - atlas-examples/pom.xml PRE-CREATION atlas-examples/src/main/java/org/apache/atlas/AtlasClientBaseExample.java PRE-CREATION atlas-examples/src/main/java/org/apache/atlas/DiscoveryExample.java PRE-CREATION atlas-examples/src/main/java/org/apache/atlas/EntityRestBaseExample.java PRE-CREATION atlas-examples/src/main/java/org/apache/atlas/GlossaryExample.java PRE-CREATION atlas-examples/src/main/java/org/apache/atlas/LineageExample.java PRE-CREATION atlas-examples/src/main/java/org/apache/atlas/TypeDefExample.java PRE-CREATION pom.xml 5e0442ae5 Diff: https://reviews.apache.org/r/72698/diff/2/ Changes: https://reviews.apache.org/r/72698/diff/1-2/ Testing --- Thanks, Jyoti Singh
Review Request 72698: ATLAS-3875: Introduce sample project for AtlasClient
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72698/ --- Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra. Bugs: ATLAS-3875 https://issues.apache.org/jira/browse/ATLAS-3875 Repository: atlas Description --- Using this project users can get an idea as how to integrate with Atlas using AtlasCleint. This helps the user to understand the basic rest functionality of Atlas such as - EntityRest - TypeDefRest - DiscoveryRest - LineageRest - GlossaryRest Diffs - atlas-examples/pom.xml PRE-CREATION atlas-examples/src/main/java/org/apache/atlas/AtlasClientBaseExample.java PRE-CREATION atlas-examples/src/main/java/org/apache/atlas/DiscoveryExample.java PRE-CREATION atlas-examples/src/main/java/org/apache/atlas/EntityRestBaseExample.java PRE-CREATION atlas-examples/src/main/java/org/apache/atlas/GlossaryExample.java PRE-CREATION atlas-examples/src/main/java/org/apache/atlas/LineageExample.java PRE-CREATION atlas-examples/src/main/java/org/apache/atlas/TypeDefExample.java PRE-CREATION pom.xml 5e0442ae5 Diff: https://reviews.apache.org/r/72698/diff/1/ Testing --- Thanks, Jyoti Singh
[jira] [Created] (ATLAS-3899) Not able to add or update businessAttributes using "/guid/{guid}/businessmetadata/{bmName}" API in EntityRest
Jyoti Singh created ATLAS-3899:
--
Summary: Not able to add or update businessAttributes using
"/guid/{guid}/businessmetadata/{bmName}" API in EntityRest
Key: ATLAS-3899
URL: https://issues.apache.org/jira/browse/ATLAS-3899
Project: Atlas
Issue Type: Bug
Components: atlas-core
Affects Versions: 2.1.0, 2.0.0
Reporter: Jyoti Singh
Assignee: Jyoti Singh
Attachments: businessmetadata.png
There is a bug in the following API.
POST *api/atlas/v2/entity/guid/\{guid}/businessmetadata/\{bmName}*
**This API is sending a multi-level map to the repository layer. Due to this,
it is not able to add or update given businessAttributes to the entity.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72638/ --- (Updated July 19, 2020, 9:12 p.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra. Changes --- Adding code review related change Bugs: ATLAS-3875 https://issues.apache.org/jira/browse/ATLAS-3875 Repository: atlas Description --- There are many missing API endpoints in AtlasClientV2. This solution is adding functions corresponding to those missing APIs for the following Rest endpoints. 1. TypeRest 2. EntityRest 3. LineageRest 4. DiscoveryRest 5. GlossaryRest 6. RelationshipRest This will enable users to test and integrate with APIs more effectively via AtlasCient. Diffs (updated) - client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 7b6d1d0f3 client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 webapp/pom.xml 3c55b4dd4 webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 680028892 webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 808f62354 webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java cc883d615 webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java PRE-CREATION webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java PRE-CREATION webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java 331ea2c47 webapp/src/test/resources/json/search-parameters/attribute-filters.json PRE-CREATION webapp/src/test/resources/template.csv PRE-CREATION webapp/src/test/resources/template_metadata.csv PRE-CREATION Diff: https://reviews.apache.org/r/72638/diff/8/ Changes: https://reviews.apache.org/r/72638/diff/7-8/ Testing --- IT has been added for newly created functions in AtlasClientV2. Validated by running IT on local system. Thanks, Jyoti Singh
Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72638/ --- (Updated July 17, 2020, 11:20 p.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra. Changes --- Adding code review related change Bugs: ATLAS-3875 https://issues.apache.org/jira/browse/ATLAS-3875 Repository: atlas Description --- There are many missing API endpoints in AtlasClientV2. This solution is adding functions corresponding to those missing APIs for the following Rest endpoints. 1. TypeRest 2. EntityRest 3. LineageRest 4. DiscoveryRest 5. GlossaryRest 6. RelationshipRest This will enable users to test and integrate with APIs more effectively via AtlasCient. Diffs (updated) - client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 7b6d1d0f3 client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 webapp/pom.xml 3c55b4dd4 webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 680028892 webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 808f62354 webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java cc883d615 webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java PRE-CREATION webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java PRE-CREATION webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java 331ea2c47 webapp/src/test/resources/csvFiles/template.csv PRE-CREATION webapp/src/test/resources/csvFiles/template_metadata.csv PRE-CREATION webapp/src/test/resources/json/search-parameters/attribute-filters.json PRE-CREATION Diff: https://reviews.apache.org/r/72638/diff/7/ Changes: https://reviews.apache.org/r/72638/diff/6-7/ Testing --- IT has been added for newly created functions in AtlasClientV2. Validated by running IT on local system. Thanks, Jyoti Singh
Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72638/ --- (Updated July 17, 2020, 10:27 p.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra. Changes --- Adding code review related change Bugs: ATLAS-3875 https://issues.apache.org/jira/browse/ATLAS-3875 Repository: atlas Description --- There are many missing API endpoints in AtlasClientV2. This solution is adding functions corresponding to those missing APIs for the following Rest endpoints. 1. TypeRest 2. EntityRest 3. LineageRest 4. DiscoveryRest 5. GlossaryRest 6. RelationshipRest This will enable users to test and integrate with APIs more effectively via AtlasCient. Diffs (updated) - client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 7b6d1d0f3 client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 webapp/pom.xml 3c55b4dd4 webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 680028892 webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 808f62354 webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java cc883d615 webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java PRE-CREATION webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java PRE-CREATION webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java 331ea2c47 webapp/src/test/resources/csvFiles/template.csv PRE-CREATION webapp/src/test/resources/csvFiles/template_metadata.csv PRE-CREATION webapp/src/test/resources/json/search-parameters/attribute-filters.json PRE-CREATION Diff: https://reviews.apache.org/r/72638/diff/6/ Changes: https://reviews.apache.org/r/72638/diff/5-6/ Testing --- IT has been added for newly created functions in AtlasClientV2. Validated by running IT on local system. Thanks, Jyoti Singh
Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints
> On July 16, 2020, 7 a.m., Sarath Subramanian wrote: > > client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java > > Lines 685 (patched) > > <https://reviews.apache.org/r/72638/diff/5/?file=2235885#file2235885line687> > > > > this method is not used anywhere. review and revert if not needed. Using it in AtlasClient - Jyoti --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72638/#review221235 --- On July 16, 2020, 3:17 a.m., Jyoti Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72638/ > --- > > (Updated July 16, 2020, 3:17 a.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath > Subramanian, and Sidharth Mishra. > > > Bugs: ATLAS-3875 > https://issues.apache.org/jira/browse/ATLAS-3875 > > > Repository: atlas > > > Description > --- > > There are many missing API endpoints in AtlasClientV2. This solution is > adding functions corresponding to those missing APIs for the following Rest > endpoints. > > 1. TypeRest > 2. EntityRest > 3. LineageRest > 4. DiscoveryRest > 5. GlossaryRest > 6. RelationshipRest > > This will enable users to test and integrate with APIs more effectively via > AtlasCient. > > > Diffs > - > > client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java > 7b6d1d0f3 > client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 > webapp/pom.xml 3c55b4dd4 > webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d > webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java > 680028892 > webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java > 808f62354 > > webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java > cc883d615 > > webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java > 331ea2c47 > webapp/src/test/resources/json/search-parameters/attribute-filters.json > PRE-CREATION > > > Diff: https://reviews.apache.org/r/72638/diff/5/ > > > Testing > --- > > IT has been added for newly created functions in AtlasClientV2. > Validated by running IT on local system. > > > Thanks, > > Jyoti Singh > >
Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints
> On July 16, 2020, 7 a.m., Sarath Subramanian wrote: > > client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java > > Lines 525 (patched) > > <https://reviews.apache.org/r/72638/diff/5/?file=2235884#file2235884line544> > > > > removeBusinessAttributes => removeBusinessAttributesByName I have renamed it to removeBusinessAttributes as suggested by Madhan - Jyoti --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72638/#review221235 --- On July 16, 2020, 3:17 a.m., Jyoti Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72638/ > --- > > (Updated July 16, 2020, 3:17 a.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath > Subramanian, and Sidharth Mishra. > > > Bugs: ATLAS-3875 > https://issues.apache.org/jira/browse/ATLAS-3875 > > > Repository: atlas > > > Description > --- > > There are many missing API endpoints in AtlasClientV2. This solution is > adding functions corresponding to those missing APIs for the following Rest > endpoints. > > 1. TypeRest > 2. EntityRest > 3. LineageRest > 4. DiscoveryRest > 5. GlossaryRest > 6. RelationshipRest > > This will enable users to test and integrate with APIs more effectively via > AtlasCient. > > > Diffs > - > > client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java > 7b6d1d0f3 > client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 > webapp/pom.xml 3c55b4dd4 > webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d > webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java > 680028892 > webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java > 808f62354 > > webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java > cc883d615 > > webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java > 331ea2c47 > webapp/src/test/resources/json/search-parameters/attribute-filters.json > PRE-CREATION > > > Diff: https://reviews.apache.org/r/72638/diff/5/ > > > Testing > --- > > IT has been added for newly created functions in AtlasClientV2. > Validated by running IT on local system. > > > Thanks, > > Jyoti Singh > >
Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints
> On July 16, 2020, 7 a.m., Sarath Subramanian wrote: > > client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java > > Lines 570 (patched) > > <https://reviews.apache.org/r/72638/diff/5/?file=2235884#file2235884line589> > > > > getLineageInfo => getLineageInfoByUniqueAttributes This is an existing method. - Jyoti --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72638/#review221235 --- On July 16, 2020, 3:17 a.m., Jyoti Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72638/ > --- > > (Updated July 16, 2020, 3:17 a.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath > Subramanian, and Sidharth Mishra. > > > Bugs: ATLAS-3875 > https://issues.apache.org/jira/browse/ATLAS-3875 > > > Repository: atlas > > > Description > --- > > There are many missing API endpoints in AtlasClientV2. This solution is > adding functions corresponding to those missing APIs for the following Rest > endpoints. > > 1. TypeRest > 2. EntityRest > 3. LineageRest > 4. DiscoveryRest > 5. GlossaryRest > 6. RelationshipRest > > This will enable users to test and integrate with APIs more effectively via > AtlasCient. > > > Diffs > - > > client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java > 7b6d1d0f3 > client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 > webapp/pom.xml 3c55b4dd4 > webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d > webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java > 680028892 > webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java > 808f62354 > > webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java > cc883d615 > > webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java > 331ea2c47 > webapp/src/test/resources/json/search-parameters/attribute-filters.json > PRE-CREATION > > > Diff: https://reviews.apache.org/r/72638/diff/5/ > > > Testing > --- > > IT has been added for newly created functions in AtlasClientV2. > Validated by running IT on local system. > > > Thanks, > > Jyoti Singh > >
Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints
> On July 16, 2020, 7 a.m., Sarath Subramanian wrote: > > client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java > > Lines 543 (patched) > > <https://reviews.apache.org/r/72638/diff/5/?file=2235884#file2235884line562> > > > > setLabels => setLabelsByUniqueAttributes > > addLabels => addLabelsByUniqueAttributes > > removeLabels => removeLabelsByUniqueAttributes I have renamed it from setLabelsByTypeName() => setLabels() as comments given by Madhan - Jyoti --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72638/#review221235 --- On July 16, 2020, 3:17 a.m., Jyoti Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72638/ > --- > > (Updated July 16, 2020, 3:17 a.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath > Subramanian, and Sidharth Mishra. > > > Bugs: ATLAS-3875 > https://issues.apache.org/jira/browse/ATLAS-3875 > > > Repository: atlas > > > Description > --- > > There are many missing API endpoints in AtlasClientV2. This solution is > adding functions corresponding to those missing APIs for the following Rest > endpoints. > > 1. TypeRest > 2. EntityRest > 3. LineageRest > 4. DiscoveryRest > 5. GlossaryRest > 6. RelationshipRest > > This will enable users to test and integrate with APIs more effectively via > AtlasCient. > > > Diffs > - > > client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java > 7b6d1d0f3 > client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 > webapp/pom.xml 3c55b4dd4 > webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d > webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java > 680028892 > webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java > 808f62354 > > webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java > cc883d615 > > webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java > 331ea2c47 > webapp/src/test/resources/json/search-parameters/attribute-filters.json > PRE-CREATION > > > Diff: https://reviews.apache.org/r/72638/diff/5/ > > > Testing > --- > > IT has been added for newly created functions in AtlasClientV2. > Validated by running IT on local system. > > > Thanks, > > Jyoti Singh > >
Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72638/ --- (Updated July 16, 2020, 3:17 a.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra. Changes --- Addressing review comments related change Bugs: ATLAS-3875 https://issues.apache.org/jira/browse/ATLAS-3875 Repository: atlas Description --- There are many missing API endpoints in AtlasClientV2. This solution is adding functions corresponding to those missing APIs for the following Rest endpoints. 1. TypeRest 2. EntityRest 3. LineageRest 4. DiscoveryRest 5. GlossaryRest 6. RelationshipRest This will enable users to test and integrate with APIs more effectively via AtlasCient. Diffs (updated) - client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 7b6d1d0f3 client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 webapp/pom.xml 3c55b4dd4 webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 680028892 webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 808f62354 webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java cc883d615 webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java PRE-CREATION webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java PRE-CREATION webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java 331ea2c47 webapp/src/test/resources/json/search-parameters/attribute-filters.json PRE-CREATION Diff: https://reviews.apache.org/r/72638/diff/5/ Changes: https://reviews.apache.org/r/72638/diff/4-5/ Testing --- IT has been added for newly created functions in AtlasClientV2. Validated by running IT on local system. Thanks, Jyoti Singh
Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72638/ --- (Updated July 10, 2020, 12:05 a.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra. Bugs: ATLAS-3875 https://issues.apache.org/jira/browse/ATLAS-3875 Repository: atlas Description --- There are many missing API endpoints in AtlasClientV2. This solution is adding functions corresponding to those missing APIs for the following Rest endpoints. 1. TypeRest 2. EntityRest 3. LineageRest 4. DiscoveryRest 5. GlossaryRest 6. RelationshipRest This will enable users to test and integrate with APIs more effectively via AtlasCient. Diffs (updated) - client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 7b6d1d0f3 client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 webapp/pom.xml 3c55b4dd4 webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 680028892 webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 808f62354 webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java cc883d615 webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java PRE-CREATION webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java PRE-CREATION webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java 331ea2c47 webapp/src/test/resources/json/search-parameters/attribute-filters.json PRE-CREATION Diff: https://reviews.apache.org/r/72638/diff/4/ Changes: https://reviews.apache.org/r/72638/diff/3-4/ Testing --- IT has been added for newly created functions in AtlasClientV2. Validated by running IT on local system. Thanks, Jyoti Singh
Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72638/ --- (Updated July 10, 2020, midnight) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra. Bugs: ATLAS-3875 https://issues.apache.org/jira/browse/ATLAS-3875 Repository: atlas Description --- There are many missing API endpoints in AtlasClientV2. This solution is adding functions corresponding to those missing APIs for the following Rest endpoints. 1. TypeRest 2. EntityRest 3. LineageRest 4. DiscoveryRest 5. GlossaryRest 6. RelationshipRest This will enable users to test and integrate with APIs more effectively via AtlasCient. Diffs (updated) - client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 7b6d1d0f3 client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 webapp/pom.xml 3c55b4dd4 webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 680028892 webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 808f62354 webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java cc883d615 webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java PRE-CREATION webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java PRE-CREATION webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java 331ea2c47 webapp/src/test/resources/json/search-parameters/attribute-filters.json PRE-CREATION Diff: https://reviews.apache.org/r/72638/diff/3/ Changes: https://reviews.apache.org/r/72638/diff/2-3/ Testing --- IT has been added for newly created functions in AtlasClientV2. Validated by running IT on local system. Thanks, Jyoti Singh
[jira] [Updated] (ATLAS-3875) Adding missing APIs in AtlasClient with test cases
[ https://issues.apache.org/jira/browse/ATLAS-3875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jyoti Singh updated ATLAS-3875: --- Attachment: ATLAS-3875-1.patch > Adding missing APIs in AtlasClient with test cases > -- > > Key: ATLAS-3875 > URL: https://issues.apache.org/jira/browse/ATLAS-3875 > Project: Atlas > Issue Type: Improvement > Components: atlas-core >Affects Versions: 2.0.0 > Reporter: Jyoti Singh >Assignee: Jyoti Singh >Priority: Major > Labels: api, client > Attachments: ATLAS-3875-1.patch > > > There are many new APIs added to Atlas Project but the corresponding APIs > are missing from AtlasClientv2. The aim of this task is to complete the gap > amongst existing APIs and their endpoints in Atls client. This will also > include adding test cases via integration testing. > There are functions from AtlasClient for the following REST endpoints > * TypeRest > * EntityRest > * LineageRest > * DiscoveryRest > * GlossaryRest > * RelationshipRest -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72638/ --- (Updated July 6, 2020, 5:53 p.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra. Bugs: ATLAS-3875 https://issues.apache.org/jira/browse/ATLAS-3875 Repository: atlas Description --- There are many missing API endpoints in AtlasClientV2. This solution is adding functions corresponding to those missing APIs for the following Rest endpoints. 1. TypeRest 2. EntityRest 3. LineageRest 4. DiscoveryRest 5. GlossaryRest 6. RelationshipRest This will enable users to test and integrate with APIs more effectively via AtlasCient. Diffs (updated) - client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 7b6d1d0f3 webapp/pom.xml 3c55b4dd4 webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 680028892 webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 808f62354 webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java cc883d615 webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java PRE-CREATION webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java PRE-CREATION webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java 331ea2c47 webapp/src/test/resources/json/search-parameters/attribute-filters.json PRE-CREATION Diff: https://reviews.apache.org/r/72638/diff/2/ Changes: https://reviews.apache.org/r/72638/diff/1-2/ Testing --- IT has been added for newly created functions in AtlasClientV2. Validated by running IT on local system. Thanks, Jyoti Singh
Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72638/ --- Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra. Bugs: ATLAS-3875 https://issues.apache.org/jira/browse/ATLAS-3875 Repository: atlas Description --- There are many missing API endpoints in AtlasClientV2. This solution is adding functions corresponding to those missing APIs for the following Rest endpoints. 1. TypeRest 2. EntityRest 3. LineageRest 4. DiscoveryRest 5. GlossaryRest 6. RelationshipRest This will enable users to test and integrate with APIs more effectively via AtlasCient. Diffs - client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 7b6d1d0f3 webapp/pom.xml 3c55b4dd4 webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 680028892 webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java cc883d615 webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java PRE-CREATION webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java PRE-CREATION webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java 331ea2c47 Diff: https://reviews.apache.org/r/72638/diff/1/ Testing --- IT has been added for newly created functions in AtlasClientV2. Validated by running IT on local system. Thanks, Jyoti Singh
[jira] [Updated] (ATLAS-3875) Adding missing APIs in AtlasClient with test cases
[ https://issues.apache.org/jira/browse/ATLAS-3875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jyoti Singh updated ATLAS-3875: --- Description: There are many new APIs added to Atlas Project but the corresponding APIs are missing from AtlasClientv2. The aim of this task is to complete the gap amongst existing APIs and their endpoints in Atls client. This will also include adding test cases via integration testing. There are functions from AtlasClient for the following REST endpoints * TypeRest * EntityRest * LineageRest * DiscoveryRest * GlossaryRest * RelationshipRest > Adding missing APIs in AtlasClient with test cases > -- > > Key: ATLAS-3875 > URL: https://issues.apache.org/jira/browse/ATLAS-3875 > Project: Atlas > Issue Type: Improvement > Reporter: Jyoti Singh > Assignee: Jyoti Singh >Priority: Major > > There are many new APIs added to Atlas Project but the corresponding APIs > are missing from AtlasClientv2. The aim of this task is to complete the gap > amongst existing APIs and their endpoints in Atls client. This will also > include adding test cases via integration testing. > There are functions from AtlasClient for the following REST endpoints > * TypeRest > * EntityRest > * LineageRest > * DiscoveryRest > * GlossaryRest > * RelationshipRest -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ATLAS-3875) Adding missing APIs in AtlasClient with test cases
Jyoti Singh created ATLAS-3875: -- Summary: Adding missing APIs in AtlasClient with test cases Key: ATLAS-3875 URL: https://issues.apache.org/jira/browse/ATLAS-3875 Project: Atlas Issue Type: Improvement Reporter: Jyoti Singh Assignee: Jyoti Singh -- This message was sent by Atlassian Jira (v8.3.4#803005)
Access to contribute
Hi, I have joined the Atlas team at Cloudera and would like to get access to contribute to this project. My Github userid is *jyoti0208*. Thanks, Jyoti
