Re: Review Request 74961: ATLAS-4854 : Atlas - Upgrade Spring Security to 5.8.11

2024-06-18 Thread Sheetal Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74961/#review226563
---


Ship it!




Ship It!

- Sheetal Shah


On June 17, 2024, 1:17 p.m., Priyanshi Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74961/
> ---
> 
> (Updated June 17, 2024, 1:17 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and 
> Sheetal Shah.
> 
> 
> Bugs: ATLAS-4854
> https://issues.apache.org/jira/browse/ATLAS-4854
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Currently Atlas is using Spring security version 5.8.5 upgrading it to 5.8.11
> 
> 
> Diffs
> -
> 
>   pom.xml 6e6724275 
> 
> 
> Diff: https://reviews.apache.org/r/74961/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing done and ran PC
> PC link: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1651/
> 
> 
> Thanks,
> 
> Priyanshi Shah
> 
>



Re: Review Request 74965: ATLAS-4844 : Atlas - Upgrade Common Configuration2 to 2.10.1

2024-06-18 Thread Sheetal Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74965/#review226562
---


Ship it!




Ship It!

- Sheetal Shah


On June 17, 2024, 1:16 p.m., Priyanshi Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74965/
> ---
> 
> (Updated June 17, 2024, 1:16 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and 
> Sheetal Shah.
> 
> 
> Bugs: ATLAS-4844
> https://issues.apache.org/jira/browse/ATLAS-4844
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Currently Atlas is using common configuration2 version 2.8.0 upgrading it to 
> 2.10.1
> 
> 
> Diffs
> -
> 
>   pom.xml 6e6724275 
> 
> 
> Diff: https://reviews.apache.org/r/74965/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing done and ran PC
> PC link: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1651/
> 
> 
> Thanks,
> 
> Priyanshi Shah
> 
>



Re: Review Request 74964: Atlas - Upgrade Nimbus-JOSE-JWT to 9.37.3

2024-06-18 Thread Sheetal Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74964/#review226561
---


Ship it!




Ship It!

- Sheetal Shah


On April 25, 2024, 12:40 a.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74964/
> ---
> 
> (Updated April 25, 2024, 12:40 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Priyanshi Shah, and Sheetal Shah.
> 
> 
> Bugs: ATLAS-4855
> https://issues.apache.org/jira/browse/ATLAS-4855
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Atlas is currently pulling in nimbus-jose-jwt 9.8.1. Upgrate it to 9.37.3
> 
> 
> Diffs
> -
> 
>   webapp/pom.xml 7d2d4c952 
> 
> 
> Diff: https://reviews.apache.org/r/74964/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>



Re: Review Request 74954: ATLAS-4846 : Source the atlas-env file in ATLAS import script to get all the argument

2024-05-23 Thread Sheetal Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74954/#review226488
---


Ship it!




Ship It!

- Sheetal Shah


On April 12, 2024, 11:31 a.m., Paresh Devalia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74954/
> ---
> 
> (Updated April 12, 2024, 11:31 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and 
> Sheetal Shah.
> 
> 
> Bugs: ATLAS-4846
> https://issues.apache.org/jira/browse/ATLAS-4846
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> User has to run manually export command to get all the argument which are 
> set, to run the Atlas import script.
> 
> The problem is not with the Atlas service itself but with these scripts:
> 
> /opt/cloudera/parcels/CDH/lib/atlas/hook-bin/import-kafka.sh
> /opt/cloudera/parcels/CDH/lib/atlas/hook-bin/import-hbase.sh
> /opt/cloudera/parcels/CDH/lib/atlas/hook-bin/import-hive.sh
> /opt/cloudera/parcels/CDH/lib/atlas/hook-bin/import-impala.sh
>  
> 
> Need to set argument before this script are being called.
> 
> 
> Diffs
> -
> 
>   addons/hbase-bridge/src/bin/import-hbase.sh 8ae735034 
>   addons/hive-bridge/src/bin/import-hive.sh 951be5ba2 
>   addons/impala-bridge/src/main/resources/import-impala.sh b440f2d05 
>   addons/kafka-bridge/src/bin/import-kafka.sh 8fe27748a 
> 
> 
> Diff: https://reviews.apache.org/r/74954/diff/3/
> 
> 
> Testing
> ---
> 
> Testing:- Manually create the cluster and ran the import script.
> 
> 
> Thanks,
> 
> Paresh Devalia
> 
>



[jira] [Assigned] (ATLAS-4858) Revisit the Atlas solr config like autoCommit, autoSoftCommit

2024-05-02 Thread Sheetal Shah (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sheetal Shah reassigned ATLAS-4858:
---

Assignee: Sheetal Shah

> Revisit the Atlas solr config like autoCommit, autoSoftCommit
> -
>
> Key: ATLAS-4858
> URL: https://issues.apache.org/jira/browse/ATLAS-4858
> Project: Atlas
>  Issue Type: Task
>  Components:  atlas-core
>    Reporter: Sheetal Shah
>Assignee: Sheetal Shah
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (ATLAS-4858) Revisit the Atlas solr config like autoCommit, autoSoftCommit

2024-05-02 Thread Sheetal Shah (Jira)
Sheetal Shah created ATLAS-4858:
---

 Summary: Revisit the Atlas solr config like autoCommit, 
autoSoftCommit
 Key: ATLAS-4858
 URL: https://issues.apache.org/jira/browse/ATLAS-4858
 Project: Atlas
  Issue Type: Task
  Components:  atlas-core
Reporter: Sheetal Shah






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (ATLAS-4857) Atlas - Upgrade Spring Framework to 6.1.6/6.0.19/5.3.34 due to CVE-2024-22243, CVE-2024-22259 and CVE-2024-22262

2024-05-02 Thread Sheetal Shah (Jira)
Sheetal Shah created ATLAS-4857:
---

 Summary: Atlas - Upgrade Spring Framework to 6.1.6/6.0.19/5.3.34 
due to CVE-2024-22243, CVE-2024-22259 and CVE-2024-22262
 Key: ATLAS-4857
 URL: https://issues.apache.org/jira/browse/ATLAS-4857
 Project: Atlas
  Issue Type: Task
  Components:  atlas-core
Reporter: Sheetal Shah






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: Review Request 74956: ATLAS-4847 : Export/Import : Atlas export fails and throws NullPointerException.

2024-04-11 Thread Sheetal Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74956/#review226387
---


Ship it!




Ship It!

- Sheetal Shah


On April 11, 2024, 4:03 p.m., Priyanshi Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74956/
> ---
> 
> (Updated April 11, 2024, 4:03 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and 
> Sheetal Shah.
> 
> 
> Bugs: ATLAS-4847
> https://issues.apache.org/jira/browse/ATLAS-4847
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Steps to reproduce:
> 
> 1. Create a hive_table entity and assign a term to it.
> 2. Perform 1st incremental export of that entity without using changeMarker.
> 3. Without any modification on that entity perform 2nd consecutive 
> incremental export with changeMarker from previous export.
> 
> Result is it that it throws NullPointerException and export is failed.
> 
> Problem:
> 
> When an entity which has termed assigned was exported with changeMarker value 
> greater than value of lastModified time of that entity it resulted in 
> throwing NullPointerException.
> 
> Solution:
> 
> 1. NullPointerException occured because it was trying to fetch referred 
> entities of AtlasGlossary Object while performing export operation and as 
> AtlasGlossary didn't have any referred entities it gave raise this exception.
> 2. This problem is solved by handling NullPointer before trying to fetch 
> referred entities.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
>  4615c6c2f 
> 
> 
> Diff: https://reviews.apache.org/r/74956/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing has been done for the same.
> 
> 
> Thanks,
> 
> Priyanshi Shah
> 
>



Re: Review Request 74608: ATLAS-4797 : Implement custom audit filters in Atlas

2024-04-03 Thread Sheetal Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74608/
---

(Updated April 4, 2024, 10:44 a.m.)


Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, Prasad 
Pawar, Radhika Kundam, and Sidharth Mishra.


Changes
---

corrected operator case sensitivity logic


Bugs: ATLAS-4797
https://issues.apache.org/jira/browse/ATLAS-4797


Repository: atlas


Description (updated)
---

Currently, Atlas has to persist all audit events without any constraints which 
can make audit data grow exponentially after some time.
 
This feature is specifically to reduce Atlas audit storage where generation of 
audit events can be controlled based on the user's use-case/criteria

Note: Audit data mentioned here is exclusive of Admin Audit Data which persists 
in atlas_janus table. Filtering will be applicable to the entity audit data 
which persists in ATLAS_ENTITY_AUDIT_EVENTS table.

Precommit details :
Latest PC build (PASSED) : 
build:https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1592/


Diffs (updated)
-

  addons/hbase-bridge/pom.xml 278b6c6d3 
  addons/hbase-testing-util/pom.xml c4f3a99ee 
  addons/hive-bridge-shim/pom.xml 39f16ceee 
  addons/hive-bridge/pom.xml 356ac9542 
  addons/kafka-bridge/pom.xml 093db7229 
  addons/models/-Area0/0010-base_model.json a4a9248ec 
  addons/sqoop-bridge/pom.xml 4b6eac98f 
  authorization/pom.xml 7a1108487 
  distro/src/conf/atlas-application.properties b5734d7a8 
  graphdb/api/pom.xml 4ba89b20f 
  graphdb/janus-hbase2/pom.xml 9ec087dbb 
  intg/pom.xml 43a172c1b 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 0868f8b6e 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 77a6fd8c3 
  intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 
3afd27e7d 
  repository/pom.xml 8fd744b44 
  
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
 9b011ab06 
  
repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
 b7f0dd5e2 
  repository/src/main/java/org/apache/atlas/repository/ogm/AtlasRuleDTO.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java 
e63152475 
  
repository/src/main/java/org/apache/atlas/rulesengine/AtlasEntityAuditFilterService.java
 PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/AtlasRule.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/AtlasRuleUtils.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/AtlasRulesEngine.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/RuleAction.java 
PRE-CREATION 
  server-api/pom.xml de311c329 
  test-tools/src/main/resources/solr/core-template/solrconfig.xml 7a0e8dd16 
  webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java 
e19beccb1 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
0025276bb 
  webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java 
268fca717 


Diff: https://reviews.apache.org/r/74608/diff/13/

Changes: https://reviews.apache.org/r/74608/diff/12-13/


Testing
---

Manual testing done


Thanks,

Sheetal Shah



Re: Review Request 74951: ATLAS-4845 : Atlas Import is failing with fetchType: Incremental if there are no changes between two consecutive runs

2024-04-03 Thread Sheetal Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74951/#review226374
---



As per the changes in this patch, in case if no entities are found in the 
export, the export service will respond with an empty zip file with no files 
within and status code 204.

Contradicting to this, behaviour as seen in the previous version for similar 
case of empty export is such :  The export API call returns 3 json files 
(atlas-typesdef.json, atlas-export-order.json and atlas-export-info.json) in 
the zip output response with response code 200 and operation status "FAIL"

Remark : Backward compatibility needs to be taken care of while handling empty 
export/zero delta for incremental export. Also,
Operation Status to be marked as SUCCESS for every successful execution (even 
if there are no entities found for any request) unless there occurs any 
exception/error in the flow

Suggestion : Make the changes based on a flag/setting which indicates an empty 
export; like so : omitZipResponseForEmptyExport ; the content-type in the 
response may also need to be set acccordingly

- Sheetal Shah


On April 2, 2024, 8:20 p.m., Priyanshi Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74951/
> ---
> 
> (Updated April 2, 2024, 8:20 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and 
> Sheetal Shah.
> 
> 
> Bugs: ATLAS-4845
> https://issues.apache.org/jira/browse/ATLAS-4845
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Steps:
> 
> 1. First export and import with changeMarker “0” - worked as expected.
> 2. Try to run 2nd export + import without any changes in atlas, 2nd export 
> also worked and gave differentchangeMarker in output as expected.
> 
> Expectation: 
> 
> a) Empty zip should be created if no entities is fetched.
> 
> Problem:
> 
> 2nd Import is getting failed.
> 
> Solution:
> 
> 1. Earlier export zip was created with default json files like 
> atlas-export-info.json, atlas-export-order.json and atlas-typesdef.json when 
> though no entities was fetched and hence, while performing import opertaion 
> failure was seen with Empty Zip File exception.
> 2. Now, the problem is fixed by returning empty zip files if no entities was 
> fetched and the status code is set to 204.
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/repository/impexp/ZipSink.java 
> 5cec39dd6 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> 3aa24 
> 
> 
> Diff: https://reviews.apache.org/r/74951/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing for the same has been performed.
> 
> PC is also successfull.
> 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1589/
> 
> 
> Thanks,
> 
> Priyanshi Shah
> 
>



Re: Review Request 74608: ATLAS-4797 : Implement custom audit filters in Atlas

2024-03-28 Thread Sheetal Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74608/
---

(Updated March 29, 2024, 8:01 a.m.)


Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, Prasad 
Pawar, Radhika Kundam, and Sidharth Mishra.


Bugs: ATLAS-4797
https://issues.apache.org/jira/browse/ATLAS-4797


Repository: atlas


Description
---

Currently, Atlas has to persist all audit events without any constraints which 
can make audit data grow exponentially after some time.
 
This feature is specifically to reduce Atlas audit storage where generation of 
audit events can be controlled based on the user's use-case/criteria

Note: Audit data mentioned here is exclusive of Admin Audit Data which persists 
in atlas_janus table. Filtering will be applicable to the entity audit data 
which persists in ATLAS_ENTITY_AUDIT_EVENTS table.

Precommit details :
Latest PC build: 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1473
Failed tests: EntityV2JerseyResourceIT.testSetLabelsByTypeName:986 expected [2] 
but found [1]


Diffs (updated)
-

  addons/hbase-bridge/pom.xml 278b6c6d3 
  addons/hbase-testing-util/pom.xml c4f3a99ee 
  addons/hive-bridge-shim/pom.xml 39f16ceee 
  addons/hive-bridge/pom.xml 356ac9542 
  addons/kafka-bridge/pom.xml 093db7229 
  addons/models/-Area0/0010-base_model.json a4a9248ec 
  addons/sqoop-bridge/pom.xml 4b6eac98f 
  authorization/pom.xml 7a1108487 
  distro/src/conf/atlas-application.properties b5734d7a8 
  graphdb/api/pom.xml 4ba89b20f 
  graphdb/janus-hbase2/pom.xml 9ec087dbb 
  intg/pom.xml 43a172c1b 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 0868f8b6e 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 77a6fd8c3 
  intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 
3afd27e7d 
  repository/pom.xml 8fd744b44 
  
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
 9b011ab06 
  
repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
 b7f0dd5e2 
  repository/src/main/java/org/apache/atlas/repository/ogm/AtlasRuleDTO.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java 
e63152475 
  
repository/src/main/java/org/apache/atlas/rulesengine/AtlasEntityAuditFilterService.java
 PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/AtlasRule.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/AtlasRuleUtils.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/AtlasRulesEngine.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/RuleAction.java 
PRE-CREATION 
  server-api/pom.xml de311c329 
  test-tools/src/main/resources/solr/core-template/solrconfig.xml 7a0e8dd16 
  webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java 
e19beccb1 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
0025276bb 
  webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java 
268fca717 


Diff: https://reviews.apache.org/r/74608/diff/11/

Changes: https://reviews.apache.org/r/74608/diff/10-11/


Testing
---

Manual testing done


Thanks,

Sheetal Shah



[jira] [Created] (ATLAS-4843) Revisit the Atlas solr config like autoCommit, autoSoftCommit

2024-03-22 Thread Sheetal Shah (Jira)
Sheetal Shah created ATLAS-4843:
---

 Summary: Revisit the Atlas solr config like autoCommit, 
autoSoftCommit
 Key: ATLAS-4843
 URL: https://issues.apache.org/jira/browse/ATLAS-4843
 Project: Atlas
  Issue Type: Improvement
  Components:  atlas-core
Reporter: Sheetal Shah






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (ATLAS-4842) Export/Import: fetchType as "incremental" does full export instead of connected

2024-03-19 Thread Sheetal Shah (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sheetal Shah reassigned ATLAS-4842:
---

Assignee: Priyanshi Shah

> Export/Import: fetchType as "incremental" does full export instead of 
> connected
> ---
>
> Key: ATLAS-4842
> URL: https://issues.apache.org/jira/browse/ATLAS-4842
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Sheetal Shah
>Assignee: Priyanshi Shah
>Priority: Major
>
> Create two hive_tables in same database:
>  # create table hive1(id int);
>  # create table hive2(name string);
> Perform incremental export of hive1 with changeMarker provided by previous 
> export.
> Import the zip.
> Expectation is only hive1 to be exported and imported, but it does full 
> export and hive2 is also imported.
>     



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (ATLAS-4842) Export/Import: fetchType as "incremental" does full export instead of connected

2024-03-19 Thread Sheetal Shah (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sheetal Shah updated ATLAS-4842:

Description: 
Create two hive_tables in same database:
 # create table hive1(id int);
 # create table hive2(name string);

Perform incremental export of hive1 with changeMarker provided by previous 
export.

Import the zip.

Expectation is only hive1 to be exported and imported, but it does full export 
and hive2 is also imported.
    

  was:
Create two hive_tables in same database:
 # create table hive1(id int);
 # create table hive2(name string);

Perform incremental export of hive1 with changeMarker provided by previous 
export.

Import the zip.

Expectation : only hive1 to be exported

Problem :  hive2 is also imported.
    


> Export/Import: fetchType as "incremental" does full export instead of 
> connected
> ---
>
> Key: ATLAS-4842
> URL: https://issues.apache.org/jira/browse/ATLAS-4842
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Sheetal Shah
>Priority: Major
>
> Create two hive_tables in same database:
>  # create table hive1(id int);
>  # create table hive2(name string);
> Perform incremental export of hive1 with changeMarker provided by previous 
> export.
> Import the zip.
> Expectation is only hive1 to be exported and imported, but it does full 
> export and hive2 is also imported.
>     



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (ATLAS-4842) Export/Import: fetchType as "incremental" does full export instead of connected

2024-03-19 Thread Sheetal Shah (Jira)
Sheetal Shah created ATLAS-4842:
---

 Summary: Export/Import: fetchType as "incremental" does full 
export instead of connected
 Key: ATLAS-4842
 URL: https://issues.apache.org/jira/browse/ATLAS-4842
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Reporter: Sheetal Shah


Create two hive_tables in same database:
 # create table hive1(id int);
 # create table hive2(name string);

Perform incremental export of hive1 with changeMarker provided by previous 
export.

Import the zip.

Expectation : only hive1 to be exported

Problem :  hive2 is also imported.
    



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: Review Request 74691: ATLAS-4802 : Atlas 'updateTime' parameter is not updated when business metadata is edited.

2024-03-03 Thread Sheetal Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74691/#review226281
---


Ship it!




Ship It!

- Sheetal Shah


On Jan. 2, 2024, 4:05 p.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74691/
> ---
> 
> (Updated Jan. 2, 2024, 4:05 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and 
> Sheetal Shah.
> 
> 
> Bugs: ATLAS-4802
> https://issues.apache.org/jira/browse/ATLAS-4802
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> When updating the business metadata and Labels on an atlas entity, the 
> 'updateTime' system attribute is not changed.
> 
> Updates to other aspects, such as technical properties and user defined 
> attributes does update the timestamp, but not the business metadata and 
> labels.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  c670740c9 
> 
> 
> Diff: https://reviews.apache.org/r/74691/diff/2/
> 
> 
> Testing
> ---
> 
> update time Without patch
> before business metadata update
> 
> "createTime": 1703221384530,
> "updateTime": 1703221386989,
> 
> after business metadata update
> 
> "createTime": 1703221384530,
> "updateTime": 1703221386989,
> 
> 
> after applying PATCH
> 
> before business metadata update
> "createTime": 1704190056433,
> "updateTime": 1704190059208,
> 
> after business metadata update
> "createTime": 1704190056433,
> "updateTime": 1704190523323,
> 
> Entire json for GET api on entity before applying patch :
> 
> http://localhost:21000/api/atlas/v2/entity/guid/dc1baa88-3a07-4577-9b6b-48982253aa3d
> 
> {
> "referredEntities": {
> "a1a27e35-aa0d-472d-8b94-2405d8001a84": {
> "typeName": "Column",
> "attributes": {
> "qualifiedName": "Sales.customer_dim.address@cl1",
> "name": "address",
> "comment": "customer address"
> },
> "guid": "a1a27e35-aa0d-472d-8b94-2405d8001a84",
> "isIncomplete": false,
> "status": "ACTIVE",
> "createdBy": "admin",
> "updatedBy": "admin",
> "createTime": 1704190056433,
> "updateTime": 1704190056433,
> "version": 0,
> "classifications": [
> {
> "typeName": "PII",
> "entityGuid": "a1a27e35-aa0d-472d-8b94-2405d8001a84",
> "entityStatus": "ACTIVE",
> "propagate": true,
> "removePropagationsOnEntityDelete": false
> }
> ],
> "labels": []
> },
> "834ba687-c8f1-4a48-a6a0-ef3ddeadf7ee": {
> "typeName": "Column",
> "attributes": {
> "qualifiedName": "Sales.customer_dim.name@cl1",
> "name": "name",
> "comment": "customer name"
> },
> "guid": "834ba687-c8f1-4a48-a6a0-ef3ddeadf7ee",
> "isIncomplete": false,
> "status": "ACTIVE",
> "createdBy": "admin",
> "updatedBy": "admin",
> "createTime": 1704190056433,
> "updateTime": 1704190056433,
> "version": 0,
> "classifications": [
> {
> "typeName": "PII",
> "entityGuid": "834ba687-c8f1-4a48-a6a0-ef3ddeadf7ee",
> "entityStatus": "ACTIVE",
> "propagate": true,
>  

[jira] [Created] (ATLAS-4821) Upgrade Guava to 32.0.1

2023-12-20 Thread Sheetal Shah (Jira)
Sheetal Shah created ATLAS-4821:
---

 Summary:  Upgrade Guava to 32.0.1
 Key: ATLAS-4821
 URL: https://issues.apache.org/jira/browse/ATLAS-4821
 Project: Atlas
  Issue Type: Task
  Components:  atlas-core
Affects Versions: 2.3.0
Reporter: Sheetal Shah


 Upgrade Guava to 32.0.1



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (ATLAS-4809) Atlas - Exclude amqp-client jar from janusgraph-core

2023-11-23 Thread Sheetal Shah (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sheetal Shah resolved ATLAS-4809.
-
Fix Version/s: 3.0.0
   2.3.0
 Assignee: (was: Sheetal Shah)
   Resolution: Fixed

> Atlas - Exclude amqp-client jar from janusgraph-core
> 
>
> Key: ATLAS-4809
> URL: https://issues.apache.org/jira/browse/ATLAS-4809
> Project: Atlas
>  Issue Type: Task
>  Components:  atlas-core
>Affects Versions: 2.3.0
>Reporter: Sheetal Shah
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> Exclude amqp-client jar from janusgraph-core
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: Review Request 74724: ATLAS-4809 : Atlas - Exclude amqp-client jar from janusgraph-core

2023-11-23 Thread Sheetal Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74724/
---

(Updated Nov. 23, 2023, 3:30 p.m.)


Review request for atlas, Jayendra Parab and Pinal Shah.


Summary (updated)
-

ATLAS-4809 : Atlas - Exclude amqp-client jar from janusgraph-core


Bugs: ATLAS-4809
https://issues.apache.org/jira/browse/ATLAS-4809


Repository: atlas


Description (updated)
---

Exclude amqp-client jar from janusgraph-core


Diffs
-

  graphdb/janus-hbase2/pom.xml c2a2e74f0 
  tools/atlas-index-repair/pom.xml ab55f4c7f 


Diff: https://reviews.apache.org/r/74724/diff/2/


Testing
---

1)mvn clean package -Pdist,embedded-hbase-solr -DskipTests -Drat.skip
  Atlas server runnning
2)Quick started was passed successfully


Precommit - 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1513/
This shows failures which are unrelated to the changes in this patch


Thanks,

Sheetal Shah



[jira] [Updated] (ATLAS-4809) Atlas - Exclude amqp-client jar from janusgraph-core

2023-11-22 Thread Sheetal Shah (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sheetal Shah updated ATLAS-4809:

Description: 
Exclude amqp-client jar from janusgraph-core

 

  was:
Upgrade amqp-client to 5.18.0+ 

 


> Atlas - Exclude amqp-client jar from janusgraph-core
> 
>
> Key: ATLAS-4809
> URL: https://issues.apache.org/jira/browse/ATLAS-4809
> Project: Atlas
>  Issue Type: Task
>  Components:  atlas-core
>Affects Versions: 2.3.0
>Reporter: Sheetal Shah
>    Assignee: Sheetal Shah
>Priority: Major
>
> Exclude amqp-client jar from janusgraph-core
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: Review Request 74724: ATLAS-4809 : Atlas - Exclude amqp-client from janusgraph-core

2023-11-22 Thread Sheetal Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74724/
---

(Updated Nov. 23, 2023, 12:59 p.m.)


Review request for atlas, Jayendra Parab and Pinal Shah.


Summary (updated)
-

ATLAS-4809 : Atlas - Exclude amqp-client from janusgraph-core


Bugs: ATLAS-4809
https://issues.apache.org/jira/browse/ATLAS-4809


Repository: atlas


Description
---

Upgrade amqp-client to 5.18.0+


Diffs
-

  graphdb/janus-hbase2/pom.xml c2a2e74f0 
  tools/atlas-index-repair/pom.xml ab55f4c7f 


Diff: https://reviews.apache.org/r/74724/diff/2/


Testing
---

1)mvn clean package -Pdist,embedded-hbase-solr -DskipTests -Drat.skip
  Atlas server runnning
2)Quick started was passed successfully


Precommit - 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1513/
This shows failures which are unrelated to the changes in this patch


Thanks,

Sheetal Shah



[jira] [Updated] (ATLAS-4809) Atlas - Exclude amqp-client jar from janusgraph-core

2023-11-22 Thread Sheetal Shah (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sheetal Shah updated ATLAS-4809:

Summary: Atlas - Exclude amqp-client jar from janusgraph-core  (was: Atlas 
- Upgrade amqp-client to 5.18.0+ )

> Atlas - Exclude amqp-client jar from janusgraph-core
> 
>
> Key: ATLAS-4809
> URL: https://issues.apache.org/jira/browse/ATLAS-4809
> Project: Atlas
>  Issue Type: Task
>  Components:  atlas-core
>Affects Versions: 2.3.0
>Reporter: Sheetal Shah
>    Assignee: Sheetal Shah
>Priority: Major
>
> Upgrade amqp-client to 5.18.0+ 
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: Review Request 74724: ATLAS-4809 : Atlas - Upgrade amqp-client to 5.18.0+

2023-11-21 Thread Sheetal Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74724/
---

(Updated Nov. 22, 2023, 10:06 a.m.)


Review request for atlas, Jayendra Parab and Pinal Shah.


Bugs: ATLAS-4809
https://issues.apache.org/jira/browse/ATLAS-4809


Repository: atlas


Description
---

Upgrade amqp-client to 5.18.0+


Diffs
-

  graphdb/janus-hbase2/pom.xml c2a2e74f0 
  tools/atlas-index-repair/pom.xml ab55f4c7f 


Diff: https://reviews.apache.org/r/74724/diff/2/


Testing (updated)
---

1)mvn clean package -Pdist,embedded-hbase-solr -DskipTests -Drat.skip
  Atlas server runnning
2)Quick started was passed successfully


Precommit - 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1513/
This shows failures which are unrelated to the changes in this patch


Thanks,

Sheetal Shah



Re: Review Request 74724: ATLAS-4809 : Atlas - Upgrade amqp-client to 5.18.0+

2023-11-17 Thread Sheetal Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74724/
---

(Updated Nov. 17, 2023, 2:38 p.m.)


Review request for atlas, Jayendra Parab and Pinal Shah.


Bugs: ATLAS-4809
https://issues.apache.org/jira/browse/ATLAS-4809


Repository: atlas


Description
---

Upgrade amqp-client to 5.18.0+


Diffs (updated)
-

  graphdb/janus-hbase2/pom.xml c2a2e74f0 
  tools/atlas-index-repair/pom.xml ab55f4c7f 


Diff: https://reviews.apache.org/r/74724/diff/2/

Changes: https://reviews.apache.org/r/74724/diff/1-2/


Testing
---

1)mvn clean package -Pdist,embedded-hbase-solr -DskipTests -Drat.skip
  Atlas server runnning
2)Quick started was passed successfully


Precommit - 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1502/


Thanks,

Sheetal Shah



Review Request 74724: ATLAS-4809 : Atlas - Upgrade amqp-client to 5.18.0+

2023-11-08 Thread Sheetal Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74724/
---

Review request for atlas, Jayendra Parab and Pinal Shah.


Bugs: ATLAS-4809
https://issues.apache.org/jira/browse/ATLAS-4809


Repository: atlas


Description
---

Upgrade amqp-client to 5.18.0+


Diffs
-

  graphdb/janus-hbase2/pom.xml c2a2e74f0 
  pom.xml c55bec763 
  tools/atlas-index-repair/pom.xml ab55f4c7f 


Diff: https://reviews.apache.org/r/74724/diff/1/


Testing
---

1)mvn clean package -Pdist,embedded-hbase-solr -DskipTests -Drat.skip
  Atlas server runnning
2)Quick started was passed successfully


Precommit - 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1502/


Thanks,

Sheetal Shah



[jira] [Updated] (ATLAS-4809) Atlas - Upgrade amqp-client to 5.18.0+

2023-11-07 Thread Sheetal Shah (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sheetal Shah updated ATLAS-4809:

Description: 
Upgrade amqp-client to 5.18.0+ 

 

  was:
Upgrade amqp-client to 5.18.0+ 

The RabbitMQ Java client library allows Java and JVM-based applications to 
connect to and interact with RabbitMQ nodes. `maxBodyLebgth` was not used when 
receiving Message objects. Attackers could send a very large Message causing a 
memory overflow and triggering an OOM Error. Users of RabbitMQ may suffer from 
DoS attacks from RabbitMQ Java client which will ultimately exhaust the memory 
of the consumer. This vulnerability was patched in version 5.18.0.


> Atlas - Upgrade amqp-client to 5.18.0+ 
> ---
>
> Key: ATLAS-4809
> URL: https://issues.apache.org/jira/browse/ATLAS-4809
> Project: Atlas
>  Issue Type: Task
>  Components:  atlas-core
>Affects Versions: 2.3.0
>Reporter: Sheetal Shah
>    Assignee: Sheetal Shah
>Priority: Major
>
> Upgrade amqp-client to 5.18.0+ 
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (ATLAS-4809) Atlas - Upgrade amqp-client to 5.18.0+

2023-11-07 Thread Sheetal Shah (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sheetal Shah reassigned ATLAS-4809:
---

Assignee: Sheetal Shah

> Atlas - Upgrade amqp-client to 5.18.0+ 
> ---
>
> Key: ATLAS-4809
> URL: https://issues.apache.org/jira/browse/ATLAS-4809
> Project: Atlas
>  Issue Type: Task
>  Components:  atlas-core
>Affects Versions: 2.3.0
>Reporter: Sheetal Shah
>    Assignee: Sheetal Shah
>Priority: Major
>
> Upgrade amqp-client to 5.18.0+ 
> The RabbitMQ Java client library allows Java and JVM-based applications to 
> connect to and interact with RabbitMQ nodes. `maxBodyLebgth` was not used 
> when receiving Message objects. Attackers could send a very large Message 
> causing a memory overflow and triggering an OOM Error. Users of RabbitMQ may 
> suffer from DoS attacks from RabbitMQ Java client which will ultimately 
> exhaust the memory of the consumer. This vulnerability was patched in version 
> 5.18.0.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (ATLAS-4809) Atlas - Upgrade amqp-client to 5.18.0+

2023-11-07 Thread Sheetal Shah (Jira)
Sheetal Shah created ATLAS-4809:
---

 Summary: Atlas - Upgrade amqp-client to 5.18.0+ 
 Key: ATLAS-4809
 URL: https://issues.apache.org/jira/browse/ATLAS-4809
 Project: Atlas
  Issue Type: Task
  Components:  atlas-core
Affects Versions: 2.3.0
Reporter: Sheetal Shah


Upgrade amqp-client to 5.18.0+ 

The RabbitMQ Java client library allows Java and JVM-based applications to 
connect to and interact with RabbitMQ nodes. `maxBodyLebgth` was not used when 
receiving Message objects. Attackers could send a very large Message causing a 
memory overflow and triggering an OOM Error. Users of RabbitMQ may suffer from 
DoS attacks from RabbitMQ Java client which will ultimately exhaust the memory 
of the consumer. This vulnerability was patched in version 5.18.0.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: Review Request 74608: ATLAS-4797 : Implement custom audit filters in Atlas

2023-10-09 Thread Sheetal Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74608/
---

(Updated Oct. 10, 2023, 9:16 a.m.)


Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, Prasad 
Pawar, and Radhika Kundam.


Changes
---

Code improvements done


Bugs: ATLAS-4797
https://issues.apache.org/jira/browse/ATLAS-4797


Repository: atlas


Description
---

Currently, Atlas has to persist all audit events without any constraints which 
can make audit data grow exponentially after some time.
 
This feature is specifically to reduce Atlas audit storage where generation of 
audit events can be controlled based on the user's use-case/criteria

Note: Audit data mentioned here is exclusive of Admin Audit Data which persists 
in atlas_janus table. Filtering will be applicable to the entity audit data 
which persists in ATLAS_ENTITY_AUDIT_EVENTS table.

Precommit details :
Latest PC build: 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1473
Failed tests: EntityV2JerseyResourceIT.testSetLabelsByTypeName:986 expected [2] 
but found [1]


Diffs (updated)
-

  addons/hbase-bridge/pom.xml 278b6c6d3 
  addons/hbase-testing-util/pom.xml c4f3a99ee 
  addons/hive-bridge-shim/pom.xml 39f16ceee 
  addons/hive-bridge/pom.xml 356ac9542 
  addons/kafka-bridge/pom.xml 093db7229 
  addons/models/-Area0/0010-base_model.json a4a9248ec 
  addons/sqoop-bridge/pom.xml 4b6eac98f 
  authorization/pom.xml 7a1108487 
  distro/src/conf/atlas-application.properties b5734d7a8 
  graphdb/api/pom.xml 4ba89b20f 
  graphdb/janus-hbase2/pom.xml c2a2e74f0 
  intg/pom.xml 43a172c1b 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java df886753f 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 77a6fd8c3 
  intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 
3afd27e7d 
  repository/pom.xml 8fd744b44 
  
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
 9b011ab06 
  
repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
 a99f9b383 
  repository/src/main/java/org/apache/atlas/repository/ogm/AtlasRuleDTO.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java 
e63152475 
  
repository/src/main/java/org/apache/atlas/rulesengine/AtlasEntityAuditFilterService.java
 PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/AtlasRule.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/AtlasRuleUtils.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/AtlasRulesEngine.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/RuleAction.java 
PRE-CREATION 
  server-api/pom.xml de311c329 
  test-tools/src/main/resources/solr/core-template/solrconfig.xml 1550052b4 
  webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java 
a25a51b5a 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
b19095b48 
  webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java 
a4d794615 


Diff: https://reviews.apache.org/r/74608/diff/10/

Changes: https://reviews.apache.org/r/74608/diff/9-10/


Testing
---

Manual testing done


Thanks,

Sheetal Shah



Re: Review Request 74608: ATLAS-4797 : Implement custom audit filters in Atlas

2023-10-04 Thread Sheetal Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74608/
---

(Updated Oct. 4, 2023, 1:21 p.m.)


Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, Prasad 
Pawar, and Radhika Kundam.


Bugs: ATLAS-4797
https://issues.apache.org/jira/browse/ATLAS-4797


Repository: atlas


Description (updated)
---

Currently, Atlas has to persist all audit events without any constraints which 
can make audit data grow exponentially after some time.
 
This feature is specifically to reduce Atlas audit storage where generation of 
audit events can be controlled based on the user's use-case/criteria

Note: Audit data mentioned here is exclusive of Admin Audit Data which persists 
in atlas_janus table. Filtering will be applicable to the entity audit data 
which persists in ATLAS_ENTITY_AUDIT_EVENTS table.

Precommit details :
Latest PC build: 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1473
Failed tests: EntityV2JerseyResourceIT.testSetLabelsByTypeName:986 expected [2] 
but found [1]


Diffs
-

  addons/hbase-bridge/pom.xml 278b6c6d3 
  addons/hbase-testing-util/pom.xml c4f3a99ee 
  addons/hive-bridge-shim/pom.xml 39f16ceee 
  addons/hive-bridge/pom.xml 356ac9542 
  addons/kafka-bridge/pom.xml 093db7229 
  addons/models/-Area0/0010-base_model.json a4a9248ec 
  addons/sqoop-bridge/pom.xml 4b6eac98f 
  authorization/pom.xml 7a1108487 
  distro/src/conf/atlas-application.properties b5734d7a8 
  graphdb/api/pom.xml 4ba89b20f 
  graphdb/janus-hbase2/pom.xml c2a2e74f0 
  intg/pom.xml 43a172c1b 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java df886753f 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 77a6fd8c3 
  intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 
3afd27e7d 
  repository/pom.xml 8fd744b44 
  
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
 9b011ab06 
  
repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
 a99f9b383 
  repository/src/main/java/org/apache/atlas/repository/ogm/AtlasRuleDTO.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java 
e63152475 
  
repository/src/main/java/org/apache/atlas/rulesengine/AtlasEntityAuditFilterService.java
 PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/AtlasRule.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/AtlasRuleUtils.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/AtlasRulesEngine.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/RuleAction.java 
PRE-CREATION 
  server-api/pom.xml de311c329 
  test-tools/src/main/resources/solr/core-template/solrconfig.xml 1550052b4 
  webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java 
a25a51b5a 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
b19095b48 
  webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java 
a4d794615 


Diff: https://reviews.apache.org/r/74608/diff/9/


Testing
---

Manual testing done


Thanks,

Sheetal Shah



Re: Review Request 74608: ATLAS-4797 : Implement custom audit filters in Atlas

2023-10-04 Thread Sheetal Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74608/
---

(Updated Oct. 4, 2023, 1:19 p.m.)


Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, Prasad 
Pawar, and Radhika Kundam.


Changes
---

Latest PC build: 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1473
Failed tests: EntityV2JerseyResourceIT.testSetLabelsByTypeName:986 expected [2] 
but found [1]


Bugs: ATLAS-4797
https://issues.apache.org/jira/browse/ATLAS-4797


Repository: atlas


Description
---

Currently, Atlas has to persist all audit events without any constraints which 
can make audit data grow exponentially after some time.
 
This feature is specifically to reduce Atlas audit storage where generation of 
audit events can be controlled based on the user's use-case/criteria

Note: Audit data mentioned here is exclusive of Admin Audit Data which persists 
in atlas_janus table. Filtering will be applicable to the entity audit data 
which persists in ATLAS_ENTITY_AUDIT_EVENTS table.


Diffs (updated)
-

  addons/hbase-bridge/pom.xml 278b6c6d3 
  addons/hbase-testing-util/pom.xml c4f3a99ee 
  addons/hive-bridge-shim/pom.xml 39f16ceee 
  addons/hive-bridge/pom.xml 356ac9542 
  addons/kafka-bridge/pom.xml 093db7229 
  addons/models/-Area0/0010-base_model.json a4a9248ec 
  addons/sqoop-bridge/pom.xml 4b6eac98f 
  authorization/pom.xml 7a1108487 
  distro/src/conf/atlas-application.properties b5734d7a8 
  graphdb/api/pom.xml 4ba89b20f 
  graphdb/janus-hbase2/pom.xml c2a2e74f0 
  intg/pom.xml 43a172c1b 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java df886753f 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 77a6fd8c3 
  intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 
3afd27e7d 
  repository/pom.xml 8fd744b44 
  
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
 9b011ab06 
  
repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
 a99f9b383 
  repository/src/main/java/org/apache/atlas/repository/ogm/AtlasRuleDTO.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java 
e63152475 
  
repository/src/main/java/org/apache/atlas/rulesengine/AtlasEntityAuditFilterService.java
 PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/AtlasRule.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/AtlasRuleUtils.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/AtlasRulesEngine.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/RuleAction.java 
PRE-CREATION 
  server-api/pom.xml de311c329 
  test-tools/src/main/resources/solr/core-template/solrconfig.xml 1550052b4 
  webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java 
a25a51b5a 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
b19095b48 
  webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java 
a4d794615 


Diff: https://reviews.apache.org/r/74608/diff/9/

Changes: https://reviews.apache.org/r/74608/diff/8-9/


Testing
---

Manual testing done


Thanks,

Sheetal Shah



Re: Review Request 74608: ATLAS-4797 : Implement custom audit filters in Atlas

2023-09-27 Thread Sheetal Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74608/
---

(Updated Sept. 27, 2023, 6:06 p.m.)


Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, Prasad 
Pawar, and Radhika Kundam.


Changes
---

changed catch exception mesage


Bugs: ATLAS-4797
https://issues.apache.org/jira/browse/ATLAS-4797


Repository: atlas


Description
---

Currently, Atlas has to persist all audit events without any constraints which 
can make audit data grow exponentially after some time.
 
This feature is specifically to reduce Atlas audit storage where generation of 
audit events can be controlled based on the user's use-case/criteria

Note: Audit data mentioned here is exclusive of Admin Audit Data which persists 
in atlas_janus table. Filtering will be applicable to the entity audit data 
which persists in ATLAS_ENTITY_AUDIT_EVENTS table.


Diffs (updated)
-

  addons/hbase-bridge/pom.xml 278b6c6d3 
  addons/hbase-testing-util/pom.xml c4f3a99ee 
  addons/hive-bridge-shim/pom.xml 39f16ceee 
  addons/hive-bridge/pom.xml 356ac9542 
  addons/kafka-bridge/pom.xml 093db7229 
  addons/models/-Area0/0010-base_model.json a4a9248ec 
  addons/sqoop-bridge/pom.xml 4b6eac98f 
  authorization/pom.xml 7a1108487 
  distro/src/conf/atlas-application.properties b5734d7a8 
  graphdb/api/pom.xml 4ba89b20f 
  graphdb/janus-hbase2/pom.xml c2a2e74f0 
  intg/pom.xml 43a172c1b 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java df886753f 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 77a6fd8c3 
  intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 
3afd27e7d 
  repository/pom.xml 8fd744b44 
  
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
 9b011ab06 
  
repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
 a99f9b383 
  repository/src/main/java/org/apache/atlas/repository/ogm/AtlasRuleDTO.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java 
e63152475 
  
repository/src/main/java/org/apache/atlas/rulesengine/AtlasEntityAuditFilterService.java
 PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/AtlasRule.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/AtlasRuleUtils.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/AtlasRulesEngine.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/RuleAction.java 
PRE-CREATION 
  server-api/pom.xml de311c329 
  test-tools/src/main/resources/solr/core-template/solrconfig.xml 1550052b4 
  webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java 
a25a51b5a 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
b19095b48 
  webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java 
a4d794615 


Diff: https://reviews.apache.org/r/74608/diff/8/

Changes: https://reviews.apache.org/r/74608/diff/7-8/


Testing
---

Manual testing done


Thanks,

Sheetal Shah



Re: Review Request 74608: ATLAS-4797 : Implement custom audit filters in Atlas

2023-09-27 Thread Sheetal Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74608/
---

(Updated Sept. 27, 2023, 2:26 p.m.)


Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, Prasad 
Pawar, and Radhika Kundam.


Changes
---

Continue evaluating remaining rules if error occurs in any rule execution


Bugs: ATLAS-4797
https://issues.apache.org/jira/browse/ATLAS-4797


Repository: atlas


Description
---

Currently, Atlas has to persist all audit events without any constraints which 
can make audit data grow exponentially after some time.
 
This feature is specifically to reduce Atlas audit storage where generation of 
audit events can be controlled based on the user's use-case/criteria

Note: Audit data mentioned here is exclusive of Admin Audit Data which persists 
in atlas_janus table. Filtering will be applicable to the entity audit data 
which persists in ATLAS_ENTITY_AUDIT_EVENTS table.


Diffs (updated)
-

  addons/hbase-bridge/pom.xml 278b6c6d3 
  addons/hbase-testing-util/pom.xml c4f3a99ee 
  addons/hive-bridge-shim/pom.xml 39f16ceee 
  addons/hive-bridge/pom.xml 356ac9542 
  addons/kafka-bridge/pom.xml 093db7229 
  addons/models/-Area0/0010-base_model.json a4a9248ec 
  addons/sqoop-bridge/pom.xml 4b6eac98f 
  authorization/pom.xml 7a1108487 
  distro/src/conf/atlas-application.properties b5734d7a8 
  graphdb/api/pom.xml 4ba89b20f 
  graphdb/janus-hbase2/pom.xml c2a2e74f0 
  intg/pom.xml 43a172c1b 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java df886753f 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 77a6fd8c3 
  intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 
3afd27e7d 
  repository/pom.xml 8fd744b44 
  
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
 9b011ab06 
  
repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
 a99f9b383 
  repository/src/main/java/org/apache/atlas/repository/ogm/AtlasRuleDTO.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java 
e63152475 
  
repository/src/main/java/org/apache/atlas/rulesengine/AtlasEntityAuditFilterService.java
 PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/AtlasRule.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/AtlasRuleUtils.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/AtlasRulesEngine.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/RuleAction.java 
PRE-CREATION 
  server-api/pom.xml de311c329 
  test-tools/src/main/resources/solr/core-template/solrconfig.xml 1550052b4 
  webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java 
a25a51b5a 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
b19095b48 
  webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java 
a4d794615 


Diff: https://reviews.apache.org/r/74608/diff/7/

Changes: https://reviews.apache.org/r/74608/diff/6-7/


Testing
---

Manual testing done


Thanks,

Sheetal Shah



Re: Review Request 74608: ATLAS-4797 : Implement custom audit filters in Atlas

2023-09-26 Thread Sheetal Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74608/
---

(Updated Sept. 26, 2023, 3:36 p.m.)


Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, Prasad 
Pawar, and Radhika Kundam.


Changes
---

isNull and notNull operations corrected


Bugs: ATLAS-4797
https://issues.apache.org/jira/browse/ATLAS-4797


Repository: atlas


Description
---

Currently, Atlas has to persist all audit events without any constraints which 
can make audit data grow exponentially after some time.
 
This feature is specifically to reduce Atlas audit storage where generation of 
audit events can be controlled based on the user's use-case/criteria

Note: Audit data mentioned here is exclusive of Admin Audit Data which persists 
in atlas_janus table. Filtering will be applicable to the entity audit data 
which persists in ATLAS_ENTITY_AUDIT_EVENTS table.


Diffs (updated)
-

  addons/hbase-bridge/pom.xml 278b6c6d3 
  addons/hbase-testing-util/pom.xml c4f3a99ee 
  addons/hive-bridge-shim/pom.xml 39f16ceee 
  addons/hive-bridge/pom.xml 356ac9542 
  addons/kafka-bridge/pom.xml 093db7229 
  addons/models/-Area0/0010-base_model.json a4a9248ec 
  addons/sqoop-bridge/pom.xml 4b6eac98f 
  authorization/pom.xml 7a1108487 
  distro/src/conf/atlas-application.properties b5734d7a8 
  graphdb/api/pom.xml 4ba89b20f 
  graphdb/janus-hbase2/pom.xml c2a2e74f0 
  intg/pom.xml 43a172c1b 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java df886753f 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 77a6fd8c3 
  intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 
3afd27e7d 
  repository/pom.xml 8fd744b44 
  
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
 9b011ab06 
  
repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
 a99f9b383 
  repository/src/main/java/org/apache/atlas/repository/ogm/AtlasRuleDTO.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java 
e63152475 
  
repository/src/main/java/org/apache/atlas/rulesengine/AtlasEntityAuditFilterService.java
 PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/AtlasRule.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/AtlasRuleUtils.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/AtlasRulesEngine.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/RuleAction.java 
PRE-CREATION 
  server-api/pom.xml de311c329 
  test-tools/src/main/resources/solr/core-template/solrconfig.xml 1550052b4 
  webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java 
a25a51b5a 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
b19095b48 
  webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java 
a4d794615 


Diff: https://reviews.apache.org/r/74608/diff/6/

Changes: https://reviews.apache.org/r/74608/diff/5-6/


Testing
---

Manual testing done


Thanks,

Sheetal Shah



Re: Review Request 74608: ATLAS-4797 : Implement custom audit filters in Atlas

2023-09-25 Thread Sheetal Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74608/
---

(Updated Sept. 26, 2023, 9:04 a.m.)


Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, Prasad 
Pawar, and Radhika Kundam.


Changes
---

solrconfig.xml corrected


Bugs: ATLAS-4797
https://issues.apache.org/jira/browse/ATLAS-4797


Repository: atlas


Description
---

Currently, Atlas has to persist all audit events without any constraints which 
can make audit data grow exponentially after some time.
 
This feature is specifically to reduce Atlas audit storage where generation of 
audit events can be controlled based on the user's use-case/criteria

Note: Audit data mentioned here is exclusive of Admin Audit Data which persists 
in atlas_janus table. Filtering will be applicable to the entity audit data 
which persists in ATLAS_ENTITY_AUDIT_EVENTS table.


Diffs (updated)
-

  addons/hbase-bridge/pom.xml 278b6c6d3 
  addons/hbase-testing-util/pom.xml c4f3a99ee 
  addons/hive-bridge-shim/pom.xml 39f16ceee 
  addons/hive-bridge/pom.xml 356ac9542 
  addons/kafka-bridge/pom.xml 093db7229 
  addons/models/-Area0/0010-base_model.json a4a9248ec 
  addons/sqoop-bridge/pom.xml 4b6eac98f 
  authorization/pom.xml 7a1108487 
  distro/src/conf/atlas-application.properties b5734d7a8 
  graphdb/api/pom.xml 4ba89b20f 
  graphdb/janus-hbase2/pom.xml c2a2e74f0 
  intg/pom.xml 43a172c1b 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java df886753f 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 77a6fd8c3 
  intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 
3afd27e7d 
  repository/pom.xml 8fd744b44 
  
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
 9b011ab06 
  
repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
 a99f9b383 
  repository/src/main/java/org/apache/atlas/repository/ogm/AtlasRuleDTO.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java 
e63152475 
  
repository/src/main/java/org/apache/atlas/rulesengine/AtlasEntityAuditFilterService.java
 PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/AtlasRule.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/AtlasRuleUtils.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/AtlasRulesEngine.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/RuleAction.java 
PRE-CREATION 
  server-api/pom.xml de311c329 
  test-tools/src/main/resources/solr/core-template/solrconfig.xml 1550052b4 
  webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java 
a25a51b5a 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
b19095b48 
  webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java 
a4d794615 


Diff: https://reviews.apache.org/r/74608/diff/5/

Changes: https://reviews.apache.org/r/74608/diff/4-5/


Testing
---

Manual testing done


Thanks,

Sheetal Shah



Re: Review Request 74608: ATLAS-4797 : Implement custom audit filters in Atlas

2023-09-25 Thread Sheetal Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74608/
---

(Updated Sept. 25, 2023, 6:07 p.m.)


Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, Prasad 
Pawar, and Radhika Kundam.


Changes
---

solrconfig.xml changed for FreeTextSearchProcessor; isIndexable set to false 
for ruleExpr


Bugs: ATLAS-4797
https://issues.apache.org/jira/browse/ATLAS-4797


Repository: atlas


Description
---

Currently, Atlas has to persist all audit events without any constraints which 
can make audit data grow exponentially after some time.
 
This feature is specifically to reduce Atlas audit storage where generation of 
audit events can be controlled based on the user's use-case/criteria

Note: Audit data mentioned here is exclusive of Admin Audit Data which persists 
in atlas_janus table. Filtering will be applicable to the entity audit data 
which persists in ATLAS_ENTITY_AUDIT_EVENTS table.


Diffs (updated)
-

  addons/hbase-bridge/pom.xml 278b6c6d3 
  addons/hbase-testing-util/pom.xml c4f3a99ee 
  addons/hive-bridge-shim/pom.xml 39f16ceee 
  addons/hive-bridge/pom.xml 356ac9542 
  addons/kafka-bridge/pom.xml 093db7229 
  addons/models/-Area0/0010-base_model.json a4a9248ec 
  addons/sqoop-bridge/pom.xml 4b6eac98f 
  authorization/pom.xml 7a1108487 
  distro/src/conf/atlas-application.properties b5734d7a8 
  graphdb/api/pom.xml 4ba89b20f 
  graphdb/janus-hbase2/pom.xml c2a2e74f0 
  intg/pom.xml 43a172c1b 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java df886753f 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 77a6fd8c3 
  intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 
3afd27e7d 
  repository/pom.xml 8fd744b44 
  
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
 9b011ab06 
  
repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
 a99f9b383 
  repository/src/main/java/org/apache/atlas/repository/ogm/AtlasRuleDTO.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java 
e63152475 
  
repository/src/main/java/org/apache/atlas/rulesengine/AtlasEntityAuditFilterService.java
 PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/AtlasRule.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/AtlasRuleUtils.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/AtlasRulesEngine.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/rulesengine/RuleAction.java 
PRE-CREATION 
  server-api/pom.xml de311c329 
  test-tools/src/main/resources/solr/core-template/solrconfig.xml 1550052b4 
  webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java 
a25a51b5a 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
b19095b48 
  webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java 
a4d794615 


Diff: https://reviews.apache.org/r/74608/diff/4/

Changes: https://reviews.apache.org/r/74608/diff/3-4/


Testing
---

Manual testing done


Thanks,

Sheetal Shah



[jira] [Created] (ATLAS-4797) Implement custom audit filters in Atlas

2023-09-10 Thread Sheetal Shah (Jira)
Sheetal Shah created ATLAS-4797:
---

 Summary: Implement custom audit filters in Atlas  
 Key: ATLAS-4797
 URL: https://issues.apache.org/jira/browse/ATLAS-4797
 Project: Atlas
  Issue Type: New Feature
  Components:  atlas-core
Affects Versions: 2.3.0
Reporter: Sheetal Shah
Assignee: Sheetal Shah


Currently, Atlas has to persist all audit events without any constraints which 
can make audit data grow exponentially after some time.

This feature is specifically to reduce Atlas audit storage where generation of 
audit events can be controlled based on the user's use-case/criteria

{*}Note{*}: Audit data mentioned here is exclusive of Admin Audit Data which 
persists in atlas_janus table. Filtering will be applicable to the entity audit 
data which persists in ATLAS_ENTITY_AUDIT_EVENTS table.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (ATLAS-4687) Atlas server doesn't come up due to circular dependency in TaskRegistry class

2023-04-27 Thread Sheetal Shah (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sheetal Shah resolved ATLAS-4687.
-
Resolution: Fixed

> Atlas server doesn't come up due to circular dependency in TaskRegistry class
> -
>
> Key: ATLAS-4687
> URL: https://issues.apache.org/jira/browse/ATLAS-4687
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>    Reporter: Sheetal Shah
>Assignee: Sheetal Shah
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> Following errors were found intermittently due to which Atlas server won’t 
> start up. These errors pointed to a circular dependency issue which was 
> caused by TaskRegistry 
> class(repository/src/main/java/org/apache/atlas/tasks/TaskRegistry.java) As a 
> resolution to this, @Lazy annotation is added on @Component definition of 
> this class.
> (FYI : A @Lazy bean is not initialised until referenced by another bean or 
> explicitly retrieved from BeanFactory . Beans that are not annotated with 
> @Lazy are initialise eagerly.)
>  
> org.springframework.beans.factory.BeanCurrentlyInCreationException: Error 
> creating bean with name 'taskRegistry': Bean with name 'taskRegistry' has 
> been injected into other beans [taskManagement] in its raw version as part of 
> a circular reference, but has eventually been wrapped. This means that said 
> other beans do not use the final version of the bean. This is often the 
> result of over-eager type matching - consider using 'getBeanNamesForType' 
> with the 'allowEagerInit' flag turned off, for example.
> at 
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:649)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:542)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:335)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:234)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:333)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:208)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:955)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:918)
>  ~[spring-context-5.3.21.jar:5.3.21]
> at 
> org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:583)
>  ~[spring-context-5.3.21.jar:5.3.21]
> at 
> org.springframework.web.context.ContextLoader.configureAndRefreshWebApplicationContext(ContextLoader.java:401)
>  ~[spring-web-5.3.21.jar:5.3.21]
> at 
> org.springframework.web.context.ContextLoader.initWebApplicationContext(ContextLoader.java:292)
>  [spring-web-5.3.21.jar:5.3.21]
> at 
> org.springframework.web.context.ContextLoaderListener.contextInitialized(ContextLoaderListener.java:103)
>  [spring-web-5.3.21.jar:5.3.21]
> at 
> org.apache.atlas.web.setup.KerberosAwareListener.contextInitialized(KerberosAwareListener.java:31)
>  [atlas-webapp-3.0.0-SNAPSHOT.jar:?]
> at 
> org.eclipse.jetty.server.handler.ContextHandler.callContextInitialized(ContextHandler.java:1013)
>  [jetty-server-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.servlet.ServletContextHandler.callContextInitialized(ServletContextHandler.java:553)
>  [jetty-servlet-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.server.handler.ContextHandler.contextInitialized(ContextHandler.java:942)
>  [jetty-server-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.servlet.ServletHandler.initialize(ServletHandler.java:782) 
> [jetty-servlet-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:360)
>  [jetty-servlet-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.webapp.WebAppContext.startWebapp(WebAppContext.java:1445)

[jira] [Reopened] (ATLAS-4687) Atlas server doesn't come up due to circular dependency in TaskRegistry class

2023-04-27 Thread Sheetal Shah (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sheetal Shah reopened ATLAS-4687:
-

> Atlas server doesn't come up due to circular dependency in TaskRegistry class
> -
>
> Key: ATLAS-4687
> URL: https://issues.apache.org/jira/browse/ATLAS-4687
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>    Reporter: Sheetal Shah
>Assignee: Sheetal Shah
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> Following errors were found intermittently due to which Atlas server won’t 
> start up. These errors pointed to a circular dependency issue which was 
> caused by TaskRegistry 
> class(repository/src/main/java/org/apache/atlas/tasks/TaskRegistry.java) As a 
> resolution to this, @Lazy annotation is added on @Component definition of 
> this class.
> (FYI : A @Lazy bean is not initialised until referenced by another bean or 
> explicitly retrieved from BeanFactory . Beans that are not annotated with 
> @Lazy are initialise eagerly.)
>  
> org.springframework.beans.factory.BeanCurrentlyInCreationException: Error 
> creating bean with name 'taskRegistry': Bean with name 'taskRegistry' has 
> been injected into other beans [taskManagement] in its raw version as part of 
> a circular reference, but has eventually been wrapped. This means that said 
> other beans do not use the final version of the bean. This is often the 
> result of over-eager type matching - consider using 'getBeanNamesForType' 
> with the 'allowEagerInit' flag turned off, for example.
> at 
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:649)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:542)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:335)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:234)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:333)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:208)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:955)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:918)
>  ~[spring-context-5.3.21.jar:5.3.21]
> at 
> org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:583)
>  ~[spring-context-5.3.21.jar:5.3.21]
> at 
> org.springframework.web.context.ContextLoader.configureAndRefreshWebApplicationContext(ContextLoader.java:401)
>  ~[spring-web-5.3.21.jar:5.3.21]
> at 
> org.springframework.web.context.ContextLoader.initWebApplicationContext(ContextLoader.java:292)
>  [spring-web-5.3.21.jar:5.3.21]
> at 
> org.springframework.web.context.ContextLoaderListener.contextInitialized(ContextLoaderListener.java:103)
>  [spring-web-5.3.21.jar:5.3.21]
> at 
> org.apache.atlas.web.setup.KerberosAwareListener.contextInitialized(KerberosAwareListener.java:31)
>  [atlas-webapp-3.0.0-SNAPSHOT.jar:?]
> at 
> org.eclipse.jetty.server.handler.ContextHandler.callContextInitialized(ContextHandler.java:1013)
>  [jetty-server-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.servlet.ServletContextHandler.callContextInitialized(ServletContextHandler.java:553)
>  [jetty-servlet-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.server.handler.ContextHandler.contextInitialized(ContextHandler.java:942)
>  [jetty-server-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.servlet.ServletHandler.initialize(ServletHandler.java:782) 
> [jetty-servlet-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:360)
>  [jetty-servlet-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.webapp.WebAppContext.startWebapp(WebAppContext.java:1445) 
> [jetty-webapp-9.4.31.v202007

[jira] [Updated] (ATLAS-4687) Atlas server doesn't come up due to circular dependency in TaskRegistry class

2023-04-27 Thread Sheetal Shah (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sheetal Shah updated ATLAS-4687:

Fix Version/s: 3.0.0
   2.3.0

> Atlas server doesn't come up due to circular dependency in TaskRegistry class
> -
>
> Key: ATLAS-4687
> URL: https://issues.apache.org/jira/browse/ATLAS-4687
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>    Reporter: Sheetal Shah
>Assignee: Sheetal Shah
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> Following errors were found intermittently due to which Atlas server won’t 
> start up. These errors pointed to a circular dependency issue which was 
> caused by TaskRegistry 
> class(repository/src/main/java/org/apache/atlas/tasks/TaskRegistry.java) As a 
> resolution to this, @Lazy annotation is added on @Component definition of 
> this class.
> (FYI : A @Lazy bean is not initialised until referenced by another bean or 
> explicitly retrieved from BeanFactory . Beans that are not annotated with 
> @Lazy are initialise eagerly.)
>  
> org.springframework.beans.factory.BeanCurrentlyInCreationException: Error 
> creating bean with name 'taskRegistry': Bean with name 'taskRegistry' has 
> been injected into other beans [taskManagement] in its raw version as part of 
> a circular reference, but has eventually been wrapped. This means that said 
> other beans do not use the final version of the bean. This is often the 
> result of over-eager type matching - consider using 'getBeanNamesForType' 
> with the 'allowEagerInit' flag turned off, for example.
> at 
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:649)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:542)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:335)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:234)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:333)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:208)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:955)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:918)
>  ~[spring-context-5.3.21.jar:5.3.21]
> at 
> org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:583)
>  ~[spring-context-5.3.21.jar:5.3.21]
> at 
> org.springframework.web.context.ContextLoader.configureAndRefreshWebApplicationContext(ContextLoader.java:401)
>  ~[spring-web-5.3.21.jar:5.3.21]
> at 
> org.springframework.web.context.ContextLoader.initWebApplicationContext(ContextLoader.java:292)
>  [spring-web-5.3.21.jar:5.3.21]
> at 
> org.springframework.web.context.ContextLoaderListener.contextInitialized(ContextLoaderListener.java:103)
>  [spring-web-5.3.21.jar:5.3.21]
> at 
> org.apache.atlas.web.setup.KerberosAwareListener.contextInitialized(KerberosAwareListener.java:31)
>  [atlas-webapp-3.0.0-SNAPSHOT.jar:?]
> at 
> org.eclipse.jetty.server.handler.ContextHandler.callContextInitialized(ContextHandler.java:1013)
>  [jetty-server-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.servlet.ServletContextHandler.callContextInitialized(ServletContextHandler.java:553)
>  [jetty-servlet-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.server.handler.ContextHandler.contextInitialized(ContextHandler.java:942)
>  [jetty-server-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.servlet.ServletHandler.initialize(ServletHandler.java:782) 
> [jetty-servlet-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:360)
>  [jetty-servlet-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclips

[jira] [Updated] (ATLAS-4687) Atlas server doesn't come up due to circular dependency in TaskRegistry class

2023-04-27 Thread Sheetal Shah (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sheetal Shah updated ATLAS-4687:

Component/s:  atlas-core

> Atlas server doesn't come up due to circular dependency in TaskRegistry class
> -
>
> Key: ATLAS-4687
> URL: https://issues.apache.org/jira/browse/ATLAS-4687
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>    Reporter: Sheetal Shah
>Assignee: Sheetal Shah
>Priority: Major
>
> Following errors were found intermittently due to which Atlas server won’t 
> start up. These errors pointed to a circular dependency issue which was 
> caused by TaskRegistry 
> class(repository/src/main/java/org/apache/atlas/tasks/TaskRegistry.java) As a 
> resolution to this, @Lazy annotation is added on @Component definition of 
> this class.
> (FYI : A @Lazy bean is not initialised until referenced by another bean or 
> explicitly retrieved from BeanFactory . Beans that are not annotated with 
> @Lazy are initialise eagerly.)
>  
> org.springframework.beans.factory.BeanCurrentlyInCreationException: Error 
> creating bean with name 'taskRegistry': Bean with name 'taskRegistry' has 
> been injected into other beans [taskManagement] in its raw version as part of 
> a circular reference, but has eventually been wrapped. This means that said 
> other beans do not use the final version of the bean. This is often the 
> result of over-eager type matching - consider using 'getBeanNamesForType' 
> with the 'allowEagerInit' flag turned off, for example.
> at 
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:649)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:542)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:335)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:234)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:333)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:208)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:955)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:918)
>  ~[spring-context-5.3.21.jar:5.3.21]
> at 
> org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:583)
>  ~[spring-context-5.3.21.jar:5.3.21]
> at 
> org.springframework.web.context.ContextLoader.configureAndRefreshWebApplicationContext(ContextLoader.java:401)
>  ~[spring-web-5.3.21.jar:5.3.21]
> at 
> org.springframework.web.context.ContextLoader.initWebApplicationContext(ContextLoader.java:292)
>  [spring-web-5.3.21.jar:5.3.21]
> at 
> org.springframework.web.context.ContextLoaderListener.contextInitialized(ContextLoaderListener.java:103)
>  [spring-web-5.3.21.jar:5.3.21]
> at 
> org.apache.atlas.web.setup.KerberosAwareListener.contextInitialized(KerberosAwareListener.java:31)
>  [atlas-webapp-3.0.0-SNAPSHOT.jar:?]
> at 
> org.eclipse.jetty.server.handler.ContextHandler.callContextInitialized(ContextHandler.java:1013)
>  [jetty-server-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.servlet.ServletContextHandler.callContextInitialized(ServletContextHandler.java:553)
>  [jetty-servlet-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.server.handler.ContextHandler.contextInitialized(ContextHandler.java:942)
>  [jetty-server-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.servlet.ServletHandler.initialize(ServletHandler.java:782) 
> [jetty-servlet-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:360)
>  [jetty-servlet-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.webapp.WebAppContext.startWebapp(WebAppContext.java:1445) 
> [jetty-webapp-9.4.31.v20200723.jar:9.4.31

[jira] [Resolved] (ATLAS-4687) Atlas server doesn't come up due to circular dependency in TaskRegistry class

2023-04-27 Thread Sheetal Shah (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sheetal Shah resolved ATLAS-4687.
-
Resolution: Resolved

Circular dependency issue caused by 
repository.src.main.java.org.apache.atlas.tasks.TaskRegistry class is resolved 
by adding @Lazy annotation on @Component definition of this class.

> Atlas server doesn't come up due to circular dependency in TaskRegistry class
> -
>
> Key: ATLAS-4687
> URL: https://issues.apache.org/jira/browse/ATLAS-4687
> Project: Atlas
>  Issue Type: Bug
>    Reporter: Sheetal Shah
>    Assignee: Sheetal Shah
>Priority: Major
>
> Following errors were found intermittently due to which Atlas server won’t 
> start up. These errors pointed to a circular dependency issue which was 
> caused by TaskRegistry 
> class(repository/src/main/java/org/apache/atlas/tasks/TaskRegistry.java) As a 
> resolution to this, @Lazy annotation is added on @Component definition of 
> this class.
> (FYI : A @Lazy bean is not initialised until referenced by another bean or 
> explicitly retrieved from BeanFactory . Beans that are not annotated with 
> @Lazy are initialise eagerly.)
>  
> org.springframework.beans.factory.BeanCurrentlyInCreationException: Error 
> creating bean with name 'taskRegistry': Bean with name 'taskRegistry' has 
> been injected into other beans [taskManagement] in its raw version as part of 
> a circular reference, but has eventually been wrapped. This means that said 
> other beans do not use the final version of the bean. This is often the 
> result of over-eager type matching - consider using 'getBeanNamesForType' 
> with the 'allowEagerInit' flag turned off, for example.
> at 
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:649)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:542)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:335)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:234)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:333)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:208)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:955)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:918)
>  ~[spring-context-5.3.21.jar:5.3.21]
> at 
> org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:583)
>  ~[spring-context-5.3.21.jar:5.3.21]
> at 
> org.springframework.web.context.ContextLoader.configureAndRefreshWebApplicationContext(ContextLoader.java:401)
>  ~[spring-web-5.3.21.jar:5.3.21]
> at 
> org.springframework.web.context.ContextLoader.initWebApplicationContext(ContextLoader.java:292)
>  [spring-web-5.3.21.jar:5.3.21]
> at 
> org.springframework.web.context.ContextLoaderListener.contextInitialized(ContextLoaderListener.java:103)
>  [spring-web-5.3.21.jar:5.3.21]
> at 
> org.apache.atlas.web.setup.KerberosAwareListener.contextInitialized(KerberosAwareListener.java:31)
>  [atlas-webapp-3.0.0-SNAPSHOT.jar:?]
> at 
> org.eclipse.jetty.server.handler.ContextHandler.callContextInitialized(ContextHandler.java:1013)
>  [jetty-server-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.servlet.ServletContextHandler.callContextInitialized(ServletContextHandler.java:553)
>  [jetty-servlet-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.server.handler.ContextHandler.contextInitialized(ContextHandler.java:942)
>  [jetty-server-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.servlet.ServletHandler.initialize(ServletHandler.java:782) 
> [jetty-servlet-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:360)
>  [jetty-servlet-9.4.31.v20200723.jar:9.4.31.v20200

[jira] [Updated] (ATLAS-4687) Atlas server doesn't come up due to circular dependency in TaskRegistry class

2023-04-27 Thread Sheetal Shah (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sheetal Shah updated ATLAS-4687:

Attachment: (was: ATLAS-4687.patch)

> Atlas server doesn't come up due to circular dependency in TaskRegistry class
> -
>
> Key: ATLAS-4687
> URL: https://issues.apache.org/jira/browse/ATLAS-4687
> Project: Atlas
>  Issue Type: Bug
>    Reporter: Sheetal Shah
>    Assignee: Sheetal Shah
>Priority: Major
>
> Following errors were found intermittently due to which Atlas server won’t 
> start up. These errors pointed to a circular dependency issue which was 
> caused by TaskRegistry 
> class(repository/src/main/java/org/apache/atlas/tasks/TaskRegistry.java) As a 
> resolution to this, @Lazy annotation is added on @Component definition of 
> this class.
> (FYI : A @Lazy bean is not initialised until referenced by another bean or 
> explicitly retrieved from BeanFactory . Beans that are not annotated with 
> @Lazy are initialise eagerly.)
>  
> org.springframework.beans.factory.BeanCurrentlyInCreationException: Error 
> creating bean with name 'taskRegistry': Bean with name 'taskRegistry' has 
> been injected into other beans [taskManagement] in its raw version as part of 
> a circular reference, but has eventually been wrapped. This means that said 
> other beans do not use the final version of the bean. This is often the 
> result of over-eager type matching - consider using 'getBeanNamesForType' 
> with the 'allowEagerInit' flag turned off, for example.
> at 
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:649)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:542)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:335)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:234)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:333)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:208)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:955)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:918)
>  ~[spring-context-5.3.21.jar:5.3.21]
> at 
> org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:583)
>  ~[spring-context-5.3.21.jar:5.3.21]
> at 
> org.springframework.web.context.ContextLoader.configureAndRefreshWebApplicationContext(ContextLoader.java:401)
>  ~[spring-web-5.3.21.jar:5.3.21]
> at 
> org.springframework.web.context.ContextLoader.initWebApplicationContext(ContextLoader.java:292)
>  [spring-web-5.3.21.jar:5.3.21]
> at 
> org.springframework.web.context.ContextLoaderListener.contextInitialized(ContextLoaderListener.java:103)
>  [spring-web-5.3.21.jar:5.3.21]
> at 
> org.apache.atlas.web.setup.KerberosAwareListener.contextInitialized(KerberosAwareListener.java:31)
>  [atlas-webapp-3.0.0-SNAPSHOT.jar:?]
> at 
> org.eclipse.jetty.server.handler.ContextHandler.callContextInitialized(ContextHandler.java:1013)
>  [jetty-server-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.servlet.ServletContextHandler.callContextInitialized(ServletContextHandler.java:553)
>  [jetty-servlet-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.server.handler.ContextHandler.contextInitialized(ContextHandler.java:942)
>  [jetty-server-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.servlet.ServletHandler.initialize(ServletHandler.java:782) 
> [jetty-servlet-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:360)
>  [jetty-servlet-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.webapp.WebAppContext.startWebapp(WebAppContext.java:1445) 
> [jetty-webapp-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
>

[jira] [Updated] (ATLAS-4687) Atlas server doesn't come up due to circular dependency in TaskRegistry class

2023-04-27 Thread Sheetal Shah (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sheetal Shah updated ATLAS-4687:

Attachment: ATLAS-4687.patch

> Atlas server doesn't come up due to circular dependency in TaskRegistry class
> -
>
> Key: ATLAS-4687
> URL: https://issues.apache.org/jira/browse/ATLAS-4687
> Project: Atlas
>  Issue Type: Bug
>    Reporter: Sheetal Shah
>    Assignee: Sheetal Shah
>Priority: Major
> Attachments: ATLAS-4687.patch
>
>
> Following errors were found intermittently due to which Atlas server won’t 
> start up. These errors pointed to a circular dependency issue which was 
> caused by TaskRegistry 
> class(repository/src/main/java/org/apache/atlas/tasks/TaskRegistry.java) As a 
> resolution to this, @Lazy annotation is added on @Component definition of 
> this class.
> (FYI : A @Lazy bean is not initialised until referenced by another bean or 
> explicitly retrieved from BeanFactory . Beans that are not annotated with 
> @Lazy are initialise eagerly.)
>  
> org.springframework.beans.factory.BeanCurrentlyInCreationException: Error 
> creating bean with name 'taskRegistry': Bean with name 'taskRegistry' has 
> been injected into other beans [taskManagement] in its raw version as part of 
> a circular reference, but has eventually been wrapped. This means that said 
> other beans do not use the final version of the bean. This is often the 
> result of over-eager type matching - consider using 'getBeanNamesForType' 
> with the 'allowEagerInit' flag turned off, for example.
> at 
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:649)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:542)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:335)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:234)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:333)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:208)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:955)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:918)
>  ~[spring-context-5.3.21.jar:5.3.21]
> at 
> org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:583)
>  ~[spring-context-5.3.21.jar:5.3.21]
> at 
> org.springframework.web.context.ContextLoader.configureAndRefreshWebApplicationContext(ContextLoader.java:401)
>  ~[spring-web-5.3.21.jar:5.3.21]
> at 
> org.springframework.web.context.ContextLoader.initWebApplicationContext(ContextLoader.java:292)
>  [spring-web-5.3.21.jar:5.3.21]
> at 
> org.springframework.web.context.ContextLoaderListener.contextInitialized(ContextLoaderListener.java:103)
>  [spring-web-5.3.21.jar:5.3.21]
> at 
> org.apache.atlas.web.setup.KerberosAwareListener.contextInitialized(KerberosAwareListener.java:31)
>  [atlas-webapp-3.0.0-SNAPSHOT.jar:?]
> at 
> org.eclipse.jetty.server.handler.ContextHandler.callContextInitialized(ContextHandler.java:1013)
>  [jetty-server-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.servlet.ServletContextHandler.callContextInitialized(ServletContextHandler.java:553)
>  [jetty-servlet-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.server.handler.ContextHandler.contextInitialized(ContextHandler.java:942)
>  [jetty-server-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.servlet.ServletHandler.initialize(ServletHandler.java:782) 
> [jetty-servlet-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:360)
>  [jetty-servlet-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.webapp.WebAppContext.startWebapp(WebAppContext.java:1445) 
> [jetty-webapp-9.4.31.v20200723.

Re: Review Request 74161: ATLAS-4687 : Atlas server doesn't come up due to circular dependency in TaskRegistry class

2023-04-27 Thread Sheetal Shah
 reproducing the issue but was successfully done; atlas got 
successfully restarted with the change and application worked fine


Thanks,

Sheetal Shah



Re: Review Request 74161: ATLAS-4687 : Atlas server doesn't come up due to circular dependency in TaskRegistry class

2023-04-27 Thread Sheetal Shah
 got 
successfully restarted with the change and application worked fine


Thanks,

Sheetal Shah



Re: Review Request 74161: ATLAS-4687 : Atlas server doesn't come up due to circular dependency in TaskRegistry class

2023-04-17 Thread Sheetal Shah
]

at 
org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:72)
 [jetty-util-9.4.31.v20200723.jar:9.4.31.v20200723]

at 
org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169)
 [jetty-util-9.4.31.v20200723.jar:9.4.31.v20200723]

at org.eclipse.jetty.server.Server.start(Server.java:408) 
[jetty-server-9.4.31.v20200723.jar:9.4.31.v20200723]

at 
org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:110)
 [jetty-util-9.4.31.v20200723.jar:9.4.31.v20200723]

at 
org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:97)
 [jetty-server-9.4.31.v20200723.jar:9.4.31.v20200723]

at org.eclipse.jetty.server.Server.doStart(Server.java:372) 
[jetty-server-9.4.31.v20200723.jar:9.4.31.v20200723]

at 
org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:72)
 [jetty-util-9.4.31.v20200723.jar:9.4.31.v20200723]

at org.apache.atlas.web.service.EmbeddedServer.start(EmbeddedServer.java:110) 
[atlas-webapp-3.0.0-SNAPSHOT.jar:?]

at org.apache.atlas.Atlas.main(Atlas.java:133) 
[atlas-webapp-3.0.0-SNAPSHOT.jar:?]

 

 

org.springframework.beans.factory.BeanCurrentlyInCreationException: Error 
creating bean with name 'taskRegistry': Bean with name 'taskRegistry' has been 
injected into other beans [taskManagement] in its raw version as part of a 
circular reference, but has eventually been wrapped. This means that said other 
beans do not use the final version of the bean. This is often the result of 
over-eager type matching - consider using 'getBeanNamesForType' with the 
'allowEagerInit' flag turned off, for example.

at 
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:649)

at 
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:542)

at 
org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:335)

at 
org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:234)

at 
org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:333)

at 
org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:208)

at 
org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:955)

at 
org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:918)

at 
org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:583)

at 
org.springframework.web.context.ContextLoader.configureAndRefreshWebApplicationContext(ContextLoader.java:401)

at 
org.springframework.web.context.ContextLoader.initWebApplicationContext(ContextLoader.java:292)

at 
org.springframework.web.context.ContextLoaderListener.contextInitialized(ContextLoaderListener.java:103)

at 
org.apache.atlas.web.setup.KerberosAwareListener.contextInitialized(KerberosAwareListener.java:31)

at 
org.eclipse.jetty.server.handler.ContextHandler.callContextInitialized(ContextHandler.java:1013)

at 
org.eclipse.jetty.servlet.ServletContextHandler.callContextInitialized(ServletContextHandler.java:553)

at 
org.eclipse.jetty.server.handler.ContextHandler.contextInitialized(ContextHandler.java:942)

at org.eclipse.jetty.servlet.ServletHandler.initialize(ServletHandler.java:782)

at 
org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:360)

at org.eclipse.jetty.webapp.WebAppContext.startWebapp(WebAppContext.java:1445)

at org.eclipse.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1409)

at 
org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:855)

at 
org.eclipse.jetty.servlet.ServletContextHandler.doStart(ServletContextHandler.java:275)

at org.eclipse.jetty.webapp.WebAppContext.doStart(WebAppContext.java:524)

at 
org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:72)

at 
org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169)

at org.eclipse.jetty.server.Server.start(Server.java:408)

at 
org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:110)

at 
org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:97)

at org.eclipse.jetty.server.Server.doStart(Server.java:372)

at 
org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:72)

at org.apache.atlas.web.service.EmbeddedServer.start(EmbeddedServer.java:110)

at org.apache.atlas.Atlas.main(Atlas.java:133)


Diffs
-

  repository/src/main/java/org/apache/atlas/tasks/TaskRegistry.java 6f770edb1 


Diff: https://reviews.apache.org/r/74161/diff/1/


Testing
---


Thanks,

Sheetal Shah



Re: Review Request 74161: ATLAS-4687 : Atlas server doesn't come up due to circular dependency in TaskRegistry class

2023-03-01 Thread Sheetal Shah
]

at 
org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169)
 [jetty-util-9.4.31.v20200723.jar:9.4.31.v20200723]

at org.eclipse.jetty.server.Server.start(Server.java:408) 
[jetty-server-9.4.31.v20200723.jar:9.4.31.v20200723]

at 
org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:110)
 [jetty-util-9.4.31.v20200723.jar:9.4.31.v20200723]

at 
org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:97)
 [jetty-server-9.4.31.v20200723.jar:9.4.31.v20200723]

at org.eclipse.jetty.server.Server.doStart(Server.java:372) 
[jetty-server-9.4.31.v20200723.jar:9.4.31.v20200723]

at 
org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:72)
 [jetty-util-9.4.31.v20200723.jar:9.4.31.v20200723]

at org.apache.atlas.web.service.EmbeddedServer.start(EmbeddedServer.java:110) 
[atlas-webapp-3.0.0-SNAPSHOT.jar:?]

at org.apache.atlas.Atlas.main(Atlas.java:133) 
[atlas-webapp-3.0.0-SNAPSHOT.jar:?]

 

 

org.springframework.beans.factory.BeanCurrentlyInCreationException: Error 
creating bean with name 'taskRegistry': Bean with name 'taskRegistry' has been 
injected into other beans [taskManagement] in its raw version as part of a 
circular reference, but has eventually been wrapped. This means that said other 
beans do not use the final version of the bean. This is often the result of 
over-eager type matching - consider using 'getBeanNamesForType' with the 
'allowEagerInit' flag turned off, for example.

at 
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:649)

at 
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:542)

at 
org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:335)

at 
org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:234)

at 
org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:333)

at 
org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:208)

at 
org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:955)

at 
org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:918)

at 
org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:583)

at 
org.springframework.web.context.ContextLoader.configureAndRefreshWebApplicationContext(ContextLoader.java:401)

at 
org.springframework.web.context.ContextLoader.initWebApplicationContext(ContextLoader.java:292)

at 
org.springframework.web.context.ContextLoaderListener.contextInitialized(ContextLoaderListener.java:103)

at 
org.apache.atlas.web.setup.KerberosAwareListener.contextInitialized(KerberosAwareListener.java:31)

at 
org.eclipse.jetty.server.handler.ContextHandler.callContextInitialized(ContextHandler.java:1013)

at 
org.eclipse.jetty.servlet.ServletContextHandler.callContextInitialized(ServletContextHandler.java:553)

at 
org.eclipse.jetty.server.handler.ContextHandler.contextInitialized(ContextHandler.java:942)

at org.eclipse.jetty.servlet.ServletHandler.initialize(ServletHandler.java:782)

at 
org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:360)

at org.eclipse.jetty.webapp.WebAppContext.startWebapp(WebAppContext.java:1445)

at org.eclipse.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1409)

at 
org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:855)

at 
org.eclipse.jetty.servlet.ServletContextHandler.doStart(ServletContextHandler.java:275)

at org.eclipse.jetty.webapp.WebAppContext.doStart(WebAppContext.java:524)

at 
org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:72)

at 
org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169)

at org.eclipse.jetty.server.Server.start(Server.java:408)

at 
org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:110)

at 
org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:97)

at org.eclipse.jetty.server.Server.doStart(Server.java:372)

at 
org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:72)

at org.apache.atlas.web.service.EmbeddedServer.start(EmbeddedServer.java:110)

at org.apache.atlas.Atlas.main(Atlas.java:133)


Diffs
-

  repository/src/main/java/org/apache/atlas/tasks/TaskRegistry.java 6f770edb1 


Diff: https://reviews.apache.org/r/74161/diff/1/


Testing
---


Thanks,

Sheetal Shah



[jira] [Commented] (ATLAS-4654) 'atlas.graph.index.search.max-result-set-size' doesn't map to a List object: 150

2023-01-16 Thread Sheetal Shah (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677409#comment-17677409
 ] 

Sheetal Shah commented on ATLAS-4654:
-

[~O.Tougui] , we ran the same sqoop import command mentioned in description and 
it ran successfully without producing any errors.
Following are the application versions with which we tested:
    • Sqoop 1.4.7
    • Postgresql 12
    • apache-atlas 2.3.0
    • sqoop hook required 
jar-atlas-plugin-classloader-3.0.0-SNAPSHOT.jar,atlas-sqoop-plugin-impl,sqoop-bridge-shim-3.0.0-SNAPSHOT.jar

The property value used in application.properties file to run this command:
{code:java}
# Solr-specific configuration property
atlas.graph.index.search.max-result-set-size=150 {code}
Stack-trace produced after running this command:
{code:java}
2023-01-12 09:46:39,755 INFO mapreduce.ImportJobBase: Transferred 0 bytes in 
2.2808 seconds (0 bytes/sec)
2023-01-12 09:46:39,756 INFO mapreduce.ImportJobBase: Retrieved 0 records.
2023-01-12 09:46:39,756 INFO mapreduce.ImportJobBase: Publishing Hive/Hcat 
import job data to Listeners for table supplies
2023-01-12 09:46:39,842 INFO atlas.ApplicationProperties: Looking for 
atlas-application.properties in classpath
2023-01-12 09:46:39,843 INFO atlas.ApplicationProperties: Loading 
atlas-application.properties from 
file:/usr/lib/sqoop-1.4.7.bin__hadoop-2.6.0/conf/atlas-application.properties
2023-01-12 09:46:39,883 INFO atlas.ApplicationProperties: Using graphdb backend 
'janus'
2023-01-12 09:46:39,883 INFO atlas.ApplicationProperties: Using storage backend 
'hbase2'
2023-01-12 09:46:39,883 INFO atlas.ApplicationProperties: Using index backend 
'solr5'
2023-01-12 09:46:39,883 INFO atlas.ApplicationProperties: Setting 
atlas.graph.index.search.max-result-set-size = 150
2023-01-12 09:46:39,885 INFO atlas.ApplicationProperties: Setting 
atlas.graph.index.search.solr.wait-searcher = false
2023-01-12 09:46:40,540 INFO notification.LogConfigUtils: Could not infer log 
path from this appender: org.apache.logging.log4j.core.appender.ConsoleAppender
2023-01-12 09:46:40,540 INFO notification.LogConfigUtils: 
getFileAppenderPath(): ret=
2023-01-12 09:46:40,541 INFO notification.LogConfigUtils: 
getFileAppenderPathApproach2(): ret=
2023-01-12 09:46:40,541 INFO notification.LogConfigUtils: getRootDir(): ret=null
 {code}
Kindly share your atlas-application.properties file and versions of 
applications that you are using.

CC : [~jayendrap] 

 

> 'atlas.graph.index.search.max-result-set-size' doesn't map to a List object: 
> 150
> 
>
> Key: ATLAS-4654
> URL: https://issues.apache.org/jira/browse/ATLAS-4654
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-intg
>Affects Versions: 2.3.0
>Reporter: Omar Tougui
>Priority: Blocker
>
> when I run the following sqoop command :
>  
>  
> {{sqoop import --connect jdbc:postgresql://server/db --username user -P 
> --table tab --hive-import --create-hive-table}}
> {{}}
> {{I get this error:}}
> {{}}
>  
> {{{}22/08/01 16:44:51 INFO atlas.ApplicationProperties: Setting 
> atlas.graph.index.search.max-result-set-size = 150
> 22/08/01 16:44:51 INFO atlas.ApplicationProperties: Setting 
> atlas.graph.index.search.solr.wait-searcher = false
> 22/08/01 16:44:51 INFO atlas.ApplicationProperties: Property (set to default) 
> atlas.graph.cache.db-cache = true
> 22/08/01 16:44:51 INFO atlas.ApplicationProperties: Property (set to default) 
> atlas.graph.cache.db-cache-clean-wait = 20
> 22/08/01 16:44:51 INFO atlas.ApplicationProperties: Property (set to default) 
> atlas.graph.cache.db-cache-size = 0.5
> 22/08/01 16:44:51 INFO atlas.ApplicationProperties: Property (set to default) 
> atlas.graph.cache.tx-cache-size = 15000
> 22/08/01 16:44:51 INFO atlas.ApplicationProperties: Property (set to default) 
> atlas.graph.cache.tx-dirty-size = 120
> 22/08/01 16:44:51 INFO hook.AtlasHook: Failed to load application properties
> org.apache.atlas.AtlasException: Failed to load application properties
> at 
> org.apache.atlas.ApplicationProperties.get(ApplicationProperties.java:155)
> at 
> org.apache.atlas.ApplicationProperties.get(ApplicationProperties.java:108)
> at org.apache.atlas.hook.AtlasHook.(AtlasHook.java:82)
> at org.apache.atlas.sqoop.hook.SqoopHook.(SqoopHook.java:86)
> at java.lang.Class.forName0(Native Method)
> at java.lang.Class.forName(Class.java:264)
> at 
> org.apache.sqoop.mapreduce.PublishJobData.publishJobData(PublishJobData.java:46)
> at 
> org.apache.sqoop.mapreduce.ImportJobBase.runImport(ImportJobBase.java:284)
> 

[jira] [Updated] (ATLAS-4679) Indexing of deleted relationship edges prolongs entity update time

2022-11-06 Thread Sheetal Shah (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sheetal Shah updated ATLAS-4679:

Fix Version/s: 3.0.0

> Indexing of deleted relationship edges prolongs entity update time
> --
>
> Key: ATLAS-4679
> URL: https://issues.apache.org/jira/browse/ATLAS-4679
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Reporter: VINAYAK MARRAIYA
>Assignee: Sheetal Shah
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (ATLAS-4679) Indexing of deleted relationship edges prolongs entity update time

2022-11-06 Thread Sheetal Shah (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sheetal Shah updated ATLAS-4679:

Fix Version/s: 2.3.0

> Indexing of deleted relationship edges prolongs entity update time
> --
>
> Key: ATLAS-4679
> URL: https://issues.apache.org/jira/browse/ATLAS-4679
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Reporter: VINAYAK MARRAIYA
>Assignee: Sheetal Shah
>Priority: Major
> Fix For: 2.3.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (ATLAS-4655) Add Glossary details in Entity - Basic search, DSL search, Entity details and Related terms

2022-10-11 Thread Sheetal Shah (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sheetal Shah updated ATLAS-4655:

Description: 
To show DSL and Basic search pages:
AtlasTermAssignmentHeader modified to include qualifiedName for associated 
term(s)

To show glossary details on entity search page : 
AtlasRelatedObjectId modified to include qualifiedName for associated term(s)

To show glossary details for related terms:
AtlasRelatedTermHeader modified to include qualifiedName for associated term(s)

  was:
Add "{*}glossaryDetails{*}" attribute in RelationshipTypeDef 
"{*}AtlasGlossarySemanticAssignment{*}".
This will help in showing the Glossary details of the associated Term in the 
Entity details page on UI.


> Add Glossary details in Entity - Basic search, DSL search, Entity details and 
> Related terms
> ---
>
> Key: ATLAS-4655
> URL: https://issues.apache.org/jira/browse/ATLAS-4655
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>    Reporter: Mandar Ambawane
>Assignee: Sheetal Shah
>Priority: Major
>
> To show DSL and Basic search pages:
> AtlasTermAssignmentHeader modified to include qualifiedName for associated 
> term(s)
> To show glossary details on entity search page : 
> AtlasRelatedObjectId modified to include qualifiedName for associated term(s)
> To show glossary details for related terms:
> AtlasRelatedTermHeader modified to include qualifiedName for associated 
> term(s)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (ATLAS-4655) Add Glossary details in Entity - Basic search, DSL search, Entity details and Related terms

2022-10-11 Thread Sheetal Shah (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sheetal Shah updated ATLAS-4655:

Summary: Add Glossary details in Entity - Basic search, DSL search, Entity 
details and Related terms  (was: Add Glossary details in Entity - Term 
Relationship attribute)

> Add Glossary details in Entity - Basic search, DSL search, Entity details and 
> Related terms
> ---
>
> Key: ATLAS-4655
> URL: https://issues.apache.org/jira/browse/ATLAS-4655
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Reporter: Mandar Ambawane
>    Assignee: Sheetal Shah
>Priority: Major
>
> Add "{*}glossaryDetails{*}" attribute in RelationshipTypeDef 
> "{*}AtlasGlossarySemanticAssignment{*}".
> This will help in showing the Glossary details of the associated Term in the 
> Entity details page on UI.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (ATLAS-4655) Add Glossary details in Entity - Term Relationship attribute

2022-10-11 Thread Sheetal Shah (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sheetal Shah reassigned ATLAS-4655:
---

Assignee: Sheetal Shah  (was: Mandar Ambawane)

> Add Glossary details in Entity - Term Relationship attribute
> 
>
> Key: ATLAS-4655
> URL: https://issues.apache.org/jira/browse/ATLAS-4655
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Reporter: Mandar Ambawane
>Assignee: Sheetal Shah
>Priority: Major
>
> Add "{*}glossaryDetails{*}" attribute in RelationshipTypeDef 
> "{*}AtlasGlossarySemanticAssignment{*}".
> This will help in showing the Glossary details of the associated Term in the 
> Entity details page on UI.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (ATLAS-4615) Not able to edit custom entity in Atlas

2022-10-11 Thread Sheetal Shah (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sheetal Shah reassigned ATLAS-4615:
---

Assignee: Sheetal Shah  (was: Paresh Devalia)

> Not able to edit custom entity in Atlas
> ---
>
> Key: ATLAS-4615
> URL: https://issues.apache.org/jira/browse/ATLAS-4615
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Paresh Devalia
>Assignee: Sheetal Shah
>Priority: Major
> Attachments: type.json
>
>
> PROBLEM STATEMENT
> Not able to edit custom entities in Atlas
> ~~
> ANALYSIS
> 1. Customer created a custom type and custom entity
> 2. If the custom type has attributes with datatype array then we are not able 
> to edit the entity
> example:
> { "name":"Master_Item", "dataTypeName":"array", 
> "multiplicity":"optional", "isComposite":false, "isUnique":false, 
> "isIndexable":true, "reverseAttributeName":null }
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (ATLAS-4687) Atlas server doesn't come up due to circular dependency in TaskRegistry class

2022-10-11 Thread Sheetal Shah (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sheetal Shah updated ATLAS-4687:

Description: 
Following errors were found intermittently due to which Atlas server won’t 
start up. These errors pointed to a circular dependency issue which was caused 
by TaskRegistry 
class(repository/src/main/java/org/apache/atlas/tasks/TaskRegistry.java) As a 
resolution to this, @Lazy annotation is added on @Component definition of this 
class.
(FYI : A @Lazy bean is not initialised until referenced by another bean or 
explicitly retrieved from BeanFactory . Beans that are not annotated with @Lazy 
are initialise eagerly.)

 

org.springframework.beans.factory.BeanCurrentlyInCreationException: Error 
creating bean with name 'taskRegistry': Bean with name 'taskRegistry' has been 
injected into other beans [taskManagement] in its raw version as part of a 
circular reference, but has eventually been wrapped. This means that said other 
beans do not use the final version of the bean. This is often the result of 
over-eager type matching - consider using 'getBeanNamesForType' with the 
'allowEagerInit' flag turned off, for example.

at 
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:649)
 ~[spring-beans-5.3.21.jar:5.3.21]

at 
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:542)
 ~[spring-beans-5.3.21.jar:5.3.21]

at 
org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:335)
 ~[spring-beans-5.3.21.jar:5.3.21]

at 
org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:234)
 ~[spring-beans-5.3.21.jar:5.3.21]

at 
org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:333)
 ~[spring-beans-5.3.21.jar:5.3.21]

at 
org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:208)
 ~[spring-beans-5.3.21.jar:5.3.21]

at 
org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:955)
 ~[spring-beans-5.3.21.jar:5.3.21]

at 
org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:918)
 ~[spring-context-5.3.21.jar:5.3.21]

at 
org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:583)
 ~[spring-context-5.3.21.jar:5.3.21]

at 
org.springframework.web.context.ContextLoader.configureAndRefreshWebApplicationContext(ContextLoader.java:401)
 ~[spring-web-5.3.21.jar:5.3.21]

at 
org.springframework.web.context.ContextLoader.initWebApplicationContext(ContextLoader.java:292)
 [spring-web-5.3.21.jar:5.3.21]

at 
org.springframework.web.context.ContextLoaderListener.contextInitialized(ContextLoaderListener.java:103)
 [spring-web-5.3.21.jar:5.3.21]

at 
org.apache.atlas.web.setup.KerberosAwareListener.contextInitialized(KerberosAwareListener.java:31)
 [atlas-webapp-3.0.0-SNAPSHOT.jar:?]

at 
org.eclipse.jetty.server.handler.ContextHandler.callContextInitialized(ContextHandler.java:1013)
 [jetty-server-9.4.31.v20200723.jar:9.4.31.v20200723]

at 
org.eclipse.jetty.servlet.ServletContextHandler.callContextInitialized(ServletContextHandler.java:553)
 [jetty-servlet-9.4.31.v20200723.jar:9.4.31.v20200723]

at 
org.eclipse.jetty.server.handler.ContextHandler.contextInitialized(ContextHandler.java:942)
 [jetty-server-9.4.31.v20200723.jar:9.4.31.v20200723]

at org.eclipse.jetty.servlet.ServletHandler.initialize(ServletHandler.java:782) 
[jetty-servlet-9.4.31.v20200723.jar:9.4.31.v20200723]

at 
org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:360)
 [jetty-servlet-9.4.31.v20200723.jar:9.4.31.v20200723]

at org.eclipse.jetty.webapp.WebAppContext.startWebapp(WebAppContext.java:1445) 
[jetty-webapp-9.4.31.v20200723.jar:9.4.31.v20200723]

at org.eclipse.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1409) 
[jetty-webapp-9.4.31.v20200723.jar:9.4.31.v20200723]

at 
org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:855)
 [jetty-server-9.4.31.v20200723.jar:9.4.31.v20200723]

at 
org.eclipse.jetty.servlet.ServletContextHandler.doStart(ServletContextHandler.java:275)
 [jetty-servlet-9.4.31.v20200723.jar:9.4.31.v20200723]

at org.eclipse.jetty.webapp.WebAppContext.doStart(WebAppContext.java:524) 
[jetty-webapp-9.4.31.v20200723.jar:9.4.31.v20200723]

at 
org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:72)
 [jetty-util-9.4.31.v20200723.jar:9.4.31.v20200723]

at 
org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169)
 [jetty-util-9.4.31.v20200723.jar:9.4.31.v20200723

Review Request 74161: ATLAS-4687 Atlas server doesn't come up due to circular dependency in TaskRegistry class

2022-10-11 Thread Sheetal Shah
]

at 
org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169)
 [jetty-util-9.4.31.v20200723.jar:9.4.31.v20200723]

at org.eclipse.jetty.server.Server.start(Server.java:408) 
[jetty-server-9.4.31.v20200723.jar:9.4.31.v20200723]

at 
org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:110)
 [jetty-util-9.4.31.v20200723.jar:9.4.31.v20200723]

at 
org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:97)
 [jetty-server-9.4.31.v20200723.jar:9.4.31.v20200723]

at org.eclipse.jetty.server.Server.doStart(Server.java:372) 
[jetty-server-9.4.31.v20200723.jar:9.4.31.v20200723]

at 
org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:72)
 [jetty-util-9.4.31.v20200723.jar:9.4.31.v20200723]

at org.apache.atlas.web.service.EmbeddedServer.start(EmbeddedServer.java:110) 
[atlas-webapp-3.0.0-SNAPSHOT.jar:?]

at org.apache.atlas.Atlas.main(Atlas.java:133) 
[atlas-webapp-3.0.0-SNAPSHOT.jar:?]

 

 

org.springframework.beans.factory.BeanCurrentlyInCreationException: Error 
creating bean with name 'taskRegistry': Bean with name 'taskRegistry' has been 
injected into other beans [taskManagement] in its raw version as part of a 
circular reference, but has eventually been wrapped. This means that said other 
beans do not use the final version of the bean. This is often the result of 
over-eager type matching - consider using 'getBeanNamesForType' with the 
'allowEagerInit' flag turned off, for example.

at 
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:649)

at 
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:542)

at 
org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:335)

at 
org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:234)

at 
org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:333)

at 
org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:208)

at 
org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:955)

at 
org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:918)

at 
org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:583)

at 
org.springframework.web.context.ContextLoader.configureAndRefreshWebApplicationContext(ContextLoader.java:401)

at 
org.springframework.web.context.ContextLoader.initWebApplicationContext(ContextLoader.java:292)

at 
org.springframework.web.context.ContextLoaderListener.contextInitialized(ContextLoaderListener.java:103)

at 
org.apache.atlas.web.setup.KerberosAwareListener.contextInitialized(KerberosAwareListener.java:31)

at 
org.eclipse.jetty.server.handler.ContextHandler.callContextInitialized(ContextHandler.java:1013)

at 
org.eclipse.jetty.servlet.ServletContextHandler.callContextInitialized(ServletContextHandler.java:553)

at 
org.eclipse.jetty.server.handler.ContextHandler.contextInitialized(ContextHandler.java:942)

at org.eclipse.jetty.servlet.ServletHandler.initialize(ServletHandler.java:782)

at 
org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:360)

at org.eclipse.jetty.webapp.WebAppContext.startWebapp(WebAppContext.java:1445)

at org.eclipse.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1409)

at 
org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:855)

at 
org.eclipse.jetty.servlet.ServletContextHandler.doStart(ServletContextHandler.java:275)

at org.eclipse.jetty.webapp.WebAppContext.doStart(WebAppContext.java:524)

at 
org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:72)

at 
org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169)

at org.eclipse.jetty.server.Server.start(Server.java:408)

at 
org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:110)

at 
org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:97)

at org.eclipse.jetty.server.Server.doStart(Server.java:372)

at 
org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:72)

at org.apache.atlas.web.service.EmbeddedServer.start(EmbeddedServer.java:110)

at org.apache.atlas.Atlas.main(Atlas.java:133)


Diffs
-

  repository/src/main/java/org/apache/atlas/tasks/TaskRegistry.java 6f770edb1 


Diff: https://reviews.apache.org/r/74161/diff/1/


Testing
---


Thanks,

Sheetal Shah



[jira] [Assigned] (ATLAS-4687) Atlas server doesn't come up due to circular dependency in TaskRegistry class

2022-10-11 Thread Sheetal Shah (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sheetal Shah reassigned ATLAS-4687:
---

Assignee: Sheetal Shah

> Atlas server doesn't come up due to circular dependency in TaskRegistry class
> -
>
> Key: ATLAS-4687
> URL: https://issues.apache.org/jira/browse/ATLAS-4687
> Project: Atlas
>  Issue Type: Bug
>    Reporter: Sheetal Shah
>    Assignee: Sheetal Shah
>Priority: Major
>
> Following errors were consistently found intermittently due to which Atlas 
> server won’t start up. These errors pointed to a circular dependency issue 
> which was caused by TaskRegistry 
> class(repository/src/main/java/org/apache/atlas/tasks/TaskRegistry.java) As a 
> resolution to this, @Lazy annotation is added on @Component definition of 
> this class.
> (FYI : A @Lazy bean is not initialised until referenced by another bean or 
> explicitly retrieved from BeanFactory . Beans that are not annotated with 
> @Lazy are initialise eagerly.)
>  
> org.springframework.beans.factory.BeanCurrentlyInCreationException: Error 
> creating bean with name 'taskRegistry': Bean with name 'taskRegistry' has 
> been injected into other beans [taskManagement] in its raw version as part of 
> a circular reference, but has eventually been wrapped. This means that said 
> other beans do not use the final version of the bean. This is often the 
> result of over-eager type matching - consider using 'getBeanNamesForType' 
> with the 'allowEagerInit' flag turned off, for example.
> at 
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:649)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:542)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:335)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:234)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:333)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:208)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:955)
>  ~[spring-beans-5.3.21.jar:5.3.21]
> at 
> org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:918)
>  ~[spring-context-5.3.21.jar:5.3.21]
> at 
> org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:583)
>  ~[spring-context-5.3.21.jar:5.3.21]
> at 
> org.springframework.web.context.ContextLoader.configureAndRefreshWebApplicationContext(ContextLoader.java:401)
>  ~[spring-web-5.3.21.jar:5.3.21]
> at 
> org.springframework.web.context.ContextLoader.initWebApplicationContext(ContextLoader.java:292)
>  [spring-web-5.3.21.jar:5.3.21]
> at 
> org.springframework.web.context.ContextLoaderListener.contextInitialized(ContextLoaderListener.java:103)
>  [spring-web-5.3.21.jar:5.3.21]
> at 
> org.apache.atlas.web.setup.KerberosAwareListener.contextInitialized(KerberosAwareListener.java:31)
>  [atlas-webapp-3.0.0-SNAPSHOT.jar:?]
> at 
> org.eclipse.jetty.server.handler.ContextHandler.callContextInitialized(ContextHandler.java:1013)
>  [jetty-server-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.servlet.ServletContextHandler.callContextInitialized(ServletContextHandler.java:553)
>  [jetty-servlet-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.server.handler.ContextHandler.contextInitialized(ContextHandler.java:942)
>  [jetty-server-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.servlet.ServletHandler.initialize(ServletHandler.java:782) 
> [jetty-servlet-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:360)
>  [jetty-servlet-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
> org.eclipse.jetty.webapp.WebAppContext.startWebapp(WebAppContext.java:1445) 
> [jetty-webapp-9.4.31.v20200723.jar:9.4.31.v20200723]
> at 
>

[jira] [Created] (ATLAS-4687) Atlas server doesn't come up due to circular dependency in TaskRegistry class

2022-10-11 Thread Sheetal Shah (Jira)
Sheetal Shah created ATLAS-4687:
---

 Summary: Atlas server doesn't come up due to circular dependency 
in TaskRegistry class
 Key: ATLAS-4687
 URL: https://issues.apache.org/jira/browse/ATLAS-4687
 Project: Atlas
  Issue Type: Bug
Reporter: Sheetal Shah


Following errors were consistently found intermittently due to which Atlas 
server won’t start up. These errors pointed to a circular dependency issue 
which was caused by TaskRegistry 
class(repository/src/main/java/org/apache/atlas/tasks/TaskRegistry.java) As a 
resolution to this, @Lazy annotation is added on @Component definition of this 
class.
(FYI : A @Lazy bean is not initialised until referenced by another bean or 
explicitly retrieved from BeanFactory . Beans that are not annotated with @Lazy 
are initialise eagerly.)

 

org.springframework.beans.factory.BeanCurrentlyInCreationException: Error 
creating bean with name 'taskRegistry': Bean with name 'taskRegistry' has been 
injected into other beans [taskManagement] in its raw version as part of a 
circular reference, but has eventually been wrapped. This means that said other 
beans do not use the final version of the bean. This is often the result of 
over-eager type matching - consider using 'getBeanNamesForType' with the 
'allowEagerInit' flag turned off, for example.

at 
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:649)
 ~[spring-beans-5.3.21.jar:5.3.21]

at 
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:542)
 ~[spring-beans-5.3.21.jar:5.3.21]

at 
org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:335)
 ~[spring-beans-5.3.21.jar:5.3.21]

at 
org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:234)
 ~[spring-beans-5.3.21.jar:5.3.21]

at 
org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:333)
 ~[spring-beans-5.3.21.jar:5.3.21]

at 
org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:208)
 ~[spring-beans-5.3.21.jar:5.3.21]

at 
org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:955)
 ~[spring-beans-5.3.21.jar:5.3.21]

at 
org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:918)
 ~[spring-context-5.3.21.jar:5.3.21]

at 
org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:583)
 ~[spring-context-5.3.21.jar:5.3.21]

at 
org.springframework.web.context.ContextLoader.configureAndRefreshWebApplicationContext(ContextLoader.java:401)
 ~[spring-web-5.3.21.jar:5.3.21]

at 
org.springframework.web.context.ContextLoader.initWebApplicationContext(ContextLoader.java:292)
 [spring-web-5.3.21.jar:5.3.21]

at 
org.springframework.web.context.ContextLoaderListener.contextInitialized(ContextLoaderListener.java:103)
 [spring-web-5.3.21.jar:5.3.21]

at 
org.apache.atlas.web.setup.KerberosAwareListener.contextInitialized(KerberosAwareListener.java:31)
 [atlas-webapp-3.0.0-SNAPSHOT.jar:?]

at 
org.eclipse.jetty.server.handler.ContextHandler.callContextInitialized(ContextHandler.java:1013)
 [jetty-server-9.4.31.v20200723.jar:9.4.31.v20200723]

at 
org.eclipse.jetty.servlet.ServletContextHandler.callContextInitialized(ServletContextHandler.java:553)
 [jetty-servlet-9.4.31.v20200723.jar:9.4.31.v20200723]

at 
org.eclipse.jetty.server.handler.ContextHandler.contextInitialized(ContextHandler.java:942)
 [jetty-server-9.4.31.v20200723.jar:9.4.31.v20200723]

at org.eclipse.jetty.servlet.ServletHandler.initialize(ServletHandler.java:782) 
[jetty-servlet-9.4.31.v20200723.jar:9.4.31.v20200723]

at 
org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:360)
 [jetty-servlet-9.4.31.v20200723.jar:9.4.31.v20200723]

at org.eclipse.jetty.webapp.WebAppContext.startWebapp(WebAppContext.java:1445) 
[jetty-webapp-9.4.31.v20200723.jar:9.4.31.v20200723]

at org.eclipse.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1409) 
[jetty-webapp-9.4.31.v20200723.jar:9.4.31.v20200723]

at 
org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:855)
 [jetty-server-9.4.31.v20200723.jar:9.4.31.v20200723]

at 
org.eclipse.jetty.servlet.ServletContextHandler.doStart(ServletContextHandler.java:275)
 [jetty-servlet-9.4.31.v20200723.jar:9.4.31.v20200723]

at org.eclipse.jetty.webapp.WebAppContext.doStart(WebAppContext.java:524) 
[jetty-webapp-9.4.31.v20200723.jar:9.4.31.v20200723]

at 
org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:72)
 [jetty-util-9.4.31.v20200723.jar:9.4.31

Re: Review Request 74130: ATLAS-4679 : Indexing of deleted relationship edges prolongs entity update time

2022-09-22 Thread Sheetal Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74130/
---

(Updated Sept. 22, 2022, 11:47 p.m.)


Review request for atlas, Jayendra Parab, Mandar Ambawane, and Pinal Shah.


Repository: atlas


Description (updated)
---

Problem statement : While working with a kafka dump which contained messages 
from spark streaming applications, 
it was observed that when an application is getting updated, it takes longest 
time while
re-indexing the edges and that "deleted" relationship edges were also being
re-indexed every-time an application was getting updated for an incoming 
process message.
This takes a few minutes to process for 35k processes, average time was 135 
seconds; this time would increase as new processes enter the system.

Changes have been made to consider only active edges to process the 
relationship edges which always ends up
considering only new additional edges for processing/indexing leading to a 
significant difference in processing time when number of deleted edges are too 
high for an updating entity


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 68d331dfd 


Diff: https://reviews.apache.org/r/74130/diff/1/


Testing (updated)
---

We tested the same kafka dump for the changes and the time taken to process 
messages was significantly less. Running the dump with the fix showed a drastic 
improvement in that it considered only non-deleted edges for 
processing/re-indexing leading to a consistent processing time of around 1 to 2 
seconds.


Thanks,

Sheetal Shah



Re: Review Request 74130: ATLAS-4679 : Indexing of deleted relationship edges prolongs entity update time

2022-09-22 Thread Sheetal Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74130/
---

(Updated Sept. 22, 2022, 11:14 p.m.)


Review request for atlas, Jayendra Parab, Mandar Ambawane, and Pinal Shah.


Repository: atlas


Description
---

Problem statement : While working with a kafka dump which contained messages 
from spark streaming applications, 
it was observed that when an application is getting updated, it takes longest 
time while
re-indexing the edges and that "deleted" relationship edges were also being
re-indexed every-time an application was getting updated for an incoming 
process message.

Changes made to consider only active edges to process the relationship edges 
which always ends up
considering only new additional edges for processing/indexing leading to a 
significant difference in processing time when number of deleted edges are too 
high for an updating entity


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 68d331dfd 


Diff: https://reviews.apache.org/r/74130/diff/1/


Testing
---


Thanks,

Sheetal Shah



Request to join Apache Atlas project

2022-09-21 Thread Sheetal Shah
Hi team,

I would like to contribute to the Atlas project, Can you please add me as a
contributor. My Apache JIRA id is : sheetal.shah

Regards,

Sheetal


Re: Review Request 74065: ATLAS-4615 :- Not able to edit custom entity in Atlas

2022-08-01 Thread Sheetal Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74065/
---

(Updated Aug. 1, 2022, 12:30 p.m.)


Review request for atlas, Jayendra Parab and Pinal Shah.


Bugs: ATLAS-4615
https://issues.apache.org/jira/browse/ATLAS-4615


Repository: atlas


Description
---

Problem Statement : Given a custom entity that defines an array attribute of 
another custom type, any removed elements always appear in the array


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
 a8fe5a762 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/InverseReferenceUpdateSoftDeleteV2Test.java
 afa1c5991 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/InverseReferenceUpdateV2Test.java
 d01ea3043 
  webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 
6a00c1764 


Diff: https://reviews.apache.org/r/74065/diff/3/


Testing
---

Manual testing done as follows:
created a custom type "Tab"
created 4 entities of this type : tab1,tab2,tab3 and tab4
created another custom type "Alphatab" having an attribute "tabArray" of type 
array
created entity ATEntity of type Alphatab with tabArray = {tab1, tab2}
//add an element and remove an element from array
updated ATEntity with tabArray = {tab1, tab3}
// add back removed element to array
updated ATEntity with tabArray = {tab1, tab2, tab3}
// delete an entity in the array by its guid
deleted tab2; size of array doesnt change yet (tab2 is soft deleted)
//removed 2 and added 1 element
updated ATEntity with tabArray = {tab3, tab4}
//remove one add 2 elements 
updated ATEntity with tabArray = {tab1, tab2, tab3}
//elements returned by getById(guid) mwthod will return an array of only ACTIVE 
edges (DELETEd edges will be ignored)
size of array = number of active edges


Note : Following test cases have been edited to accomodate the feature 
change(set ignoreInactive=true as default)
1.org.apache.atlas.repository.store.graph.v2.InverseReferenceUpdateV2Test
2.org.apache.atlas.repository.store.graph.v2.InverseReferenceUpdateSoftDeleteV2Test


Thanks,

Sheetal Shah