[jira] [Commented] (ATLAS-2265) Update jackson library to newer version

2017-11-26 Thread Madhan Neethiraj (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266061#comment-16266061
 ] 

Madhan Neethiraj commented on ATLAS-2265:
-

[~davidrad] - each model class that is serialized/deserialized via REST is 
annotated with '@JsonIgnoreProperties(ignoreUnknown=true)', which makes calling 
 mapper.configure(DeserializationConfig.Feature.FAIL_ON_UNKNOWN_PROPERTIES, 
false) unnecessary.

> Update jackson library to newer version
> ---
>
> Key: ATLAS-2265
> URL: https://issues.apache.org/jira/browse/ATLAS-2265
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core, atlas-intg, atlas-webui
>Affects Versions: 1.0.0
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
> Fix For: 1.0.0
>
>
> Currently Atlas uses jackson library version 1.9.13, which is more than 4 
> years old. This usage should be updated to use latest jackson library 2.9.2. 
> Since version 2, jackson renamed package from org.codehaus.jackson to 
> com.fasterxml.jackson. This would require updates to sources that reference 
> org.codehause.jackson classes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (ATLAS-2265) Update jackson library to newer version

2017-11-21 Thread David Radley (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260451#comment-16260451
 ] 

David Radley commented on ATLAS-2265:
-

[~madhan.neethiraj] I am not in a position to test this in a runtijme Atlas, 
but from some testing I did deserialising the models files notice that   


ObjectMapper mapper = new ObjectMapper()

.configure(DeserializationConfig.Feature.USE_BIG_DECIMAL_FOR_FLOATS, true);
to deserialise json.
then
   AtlasTypesDef typedDef = mapper.readValue(file, AtlasTypesDef.class);

Errors for unrecogised content. From what I understood, Atlas should ignore 
unrecognised json content by design. Please can you confirm whether after the 
library upgrade whether we tolerate unrecognised content or not and what the 
implications of a change here. It seems to me that we may need to add :
  mapper.configure(DeserializationConfig.Feature.FAIL_ON_UNKNOWN_PROPERTIES, 
false);
to ensure we tolerate unrecognised fields as we did before. 








> Update jackson library to newer version
> ---
>
> Key: ATLAS-2265
> URL: https://issues.apache.org/jira/browse/ATLAS-2265
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core, atlas-intg, atlas-webui
>Affects Versions: 1.0.0
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
> Fix For: 1.0.0
>
>
> Currently Atlas uses jackson library version 1.9.13, which is more than 4 
> years old. This usage should be updated to use latest jackson library 2.9.2. 
> Since version 2, jackson renamed package from org.codehaus.jackson to 
> com.fasterxml.jackson. This would require updates to sources that reference 
> org.codehause.jackson classes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)