Re: Review Request 66791: Import: Fix for Glossary Terms

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66791/#review201951
---


Ship it!




Ship It!

- Madhan Neethiraj


On April 25, 2018, 5:49 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66791/
> ---
> 
> (Updated April 25, 2018, 5:49 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2602
> https://issues.apache.org/jira/browse/ATLAS-2602
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Background**
> During entity creation, has a pre-create phase that discovers entities that 
> need to be created within _AtlasEntity_. For import, this discovery was 
> ignoring the entities present within relationship attribute.
> 
> **Fix**
> The fix removes the condition.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java
>  f092d1847 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/BulkImporterImpl.java
>  af310954f 
>   
> repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java
>  91d56ab80 
>   repository/src/test/resources/stocks-glossary.zip PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66791/diff/3/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> - New unit tests cover this case.
> - Additional checks added using EntityDiscovery to query the Graph with known 
> guids after import succeeds.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 66791: Import: Fix for Glossary Terms

[Ashutosh Mestry]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66791/
---

(Updated April 25, 2018, 5:49 p.m.)


Review request for atlas, Madhan Neethiraj and Sarath Subramanian.


Changes
---

Updates include: Addressed review comments.


Bugs: ATLAS-2602
https://issues.apache.org/jira/browse/ATLAS-2602


Repository: atlas


Description
---

**Background**
During entity creation, has a pre-create phase that discovers entities that 
need to be created within _AtlasEntity_. For import, this discovery was 
ignoring the entities present within relationship attribute.

**Fix**
The fix removes the condition.


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java
 f092d1847 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/BulkImporterImpl.java
 af310954f 
  
repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java
 91d56ab80 
  repository/src/test/resources/stocks-glossary.zip PRE-CREATION 


Diff: https://reviews.apache.org/r/66791/diff/3/

Changes: https://reviews.apache.org/r/66791/diff/2-3/


Testing
---

**Unit tests**
- New unit tests cover this case.
- Additional checks added using EntityDiscovery to query the Graph with known 
guids after import succeeds.


Thanks,

Ashutosh Mestry

Re: Review Request 66791: Import: Fix for Glossary Terms

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66791/#review201946
---


Fix it, then Ship it!





repository/src/main/java/org/apache/atlas/repository/store/graph/v1/BulkImporterImpl.java
Lines 78 (patched)


Consider moving line #78 before line #76.


- Madhan Neethiraj


On April 25, 2018, 4:35 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66791/
> ---
> 
> (Updated April 25, 2018, 4:35 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2602
> https://issues.apache.org/jira/browse/ATLAS-2602
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Background**
> During entity creation, has a pre-create phase that discovers entities that 
> need to be created within _AtlasEntity_. For import, this discovery was 
> ignoring the entities present within relationship attribute.
> 
> **Fix**
> The fix removes the condition.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java
>  f092d1847 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/BulkImporterImpl.java
>  af310954f 
>   
> repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java
>  91d56ab80 
>   repository/src/test/resources/stocks-glossary.zip PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66791/diff/2/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> - New unit tests cover this case.
> - Additional checks added using EntityDiscovery to query the Graph with known 
> guids after import succeeds.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 66791: Import: Fix for Glossary Terms

[Ashutosh Mestry]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66791/
---

(Updated April 25, 2018, 4:35 p.m.)


Review request for atlas, Madhan Neethiraj and Sarath Subramanian.


Changes
---

Updates include: Addressed review comment.


Bugs: ATLAS-2602
https://issues.apache.org/jira/browse/ATLAS-2602


Repository: atlas


Description
---

**Background**
During entity creation, has a pre-create phase that discovers entities that 
need to be created within _AtlasEntity_. For import, this discovery was 
ignoring the entities present within relationship attribute.

**Fix**
The fix removes the condition.


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java
 f092d1847 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/BulkImporterImpl.java
 af310954f 
  
repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java
 91d56ab80 
  repository/src/test/resources/stocks-glossary.zip PRE-CREATION 


Diff: https://reviews.apache.org/r/66791/diff/2/

Changes: https://reviews.apache.org/r/66791/diff/1-2/


Testing
---

**Unit tests**
- New unit tests cover this case.
- Additional checks added using EntityDiscovery to query the Graph with known 
guids after import succeeds.


Thanks,

Ashutosh Mestry

Re: Review Request 66791: Import: Fix for Glossary Terms

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66791/#review201884
---




repository/src/main/java/org/apache/atlas/repository/store/graph/v1/BulkImporterImpl.java
Line 76 (original)


if 'entity == null', line #79 will result in NPE. It will be safe to 
'continue' in this case.


- Madhan Neethiraj


On April 24, 2018, 11:15 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66791/
> ---
> 
> (Updated April 24, 2018, 11:15 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2602
> https://issues.apache.org/jira/browse/ATLAS-2602
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Background**
> During entity creation, has a pre-create phase that discovers entities that 
> need to be created within _AtlasEntity_. For import, this discovery was 
> ignoring the entities present within relationship attribute.
> 
> **Fix**
> The fix removes the condition.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java
>  f092d1847 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/BulkImporterImpl.java
>  af310954f 
>   
> repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java
>  91d56ab80 
>   repository/src/test/resources/stocks-glossary.zip PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66791/diff/1/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> - New unit tests cover this case.
> - Additional checks added using EntityDiscovery to query the Graph with known 
> guids after import succeeds.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>