Re: Review Request 68377: ATLAS-2826: fix for failure in authorizing save-search operation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68377/#review207400 --- Ship it! Ship It! - Nixon Rodrigues On Aug. 16, 2018, 11:44 a.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68377/ > --- > > (Updated Aug. 16, 2018, 11:44 a.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Nixon Rodrigues, and > Sarath Subramanian. > > > Bugs: ATLAS-2826 > https://issues.apache.org/jira/browse/ATLAS-2826 > > > Repository: atlas > > > Description > --- > > updated the logic to get entity-id for authorization, to support entities > that may not have qualifiedName as unique attribute > > > Diffs > - > > > authorization/src/main/java/org/apache/atlas/authorize/AtlasAccessRequest.java > 8cdd6768a > > authorization/src/main/java/org/apache/atlas/authorize/AtlasEntityAccessRequest.java > d87c8300b > > authorization/src/main/java/org/apache/atlas/authorize/AtlasRelationshipAccessRequest.java > 87e9b59fc > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 8ab41a31d > intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java > 5abae95f7 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java > c8adcf153 > > > Diff: https://reviews.apache.org/r/68377/diff/2/ > > > Testing > --- > > - verified that save-search succeeds with this fix > - pre-commit test run - > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/587/ > > > Thanks, > > Madhan Neethiraj > >
Re: Review Request 68377: ATLAS-2826: fix for failure in authorizing save-search operation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68377/ --- (Updated Aug. 16, 2018, 11:44 a.m.) Review request for atlas, Apoorv Naik, Ashutosh Mestry, Nixon Rodrigues, and Sarath Subramanian. Changes --- updated add-relationship authorization, to skip if an end is a legacy attribute - as this case would be covered in entity-update authorization Bugs: ATLAS-2826 https://issues.apache.org/jira/browse/ATLAS-2826 Repository: atlas Description --- updated the logic to get entity-id for authorization, to support entities that may not have qualifiedName as unique attribute Diffs (updated) - authorization/src/main/java/org/apache/atlas/authorize/AtlasAccessRequest.java 8cdd6768a authorization/src/main/java/org/apache/atlas/authorize/AtlasEntityAccessRequest.java d87c8300b authorization/src/main/java/org/apache/atlas/authorize/AtlasRelationshipAccessRequest.java 87e9b59fc intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 8ab41a31d intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 5abae95f7 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java c8adcf153 Diff: https://reviews.apache.org/r/68377/diff/2/ Changes: https://reviews.apache.org/r/68377/diff/1-2/ Testing (updated) --- - verified that save-search succeeds with this fix - pre-commit test run - https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/587/ Thanks, Madhan Neethiraj
Re: Review Request 68377: ATLAS-2826: fix for failure in authorizing save-search operation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68377/#review207396 --- Ship it! Ship It! - Nixon Rodrigues On Aug. 16, 2018, 10:30 a.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68377/ > --- > > (Updated Aug. 16, 2018, 10:30 a.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Nixon Rodrigues, and > Sarath Subramanian. > > > Bugs: ATLAS-2826 > https://issues.apache.org/jira/browse/ATLAS-2826 > > > Repository: atlas > > > Description > --- > > updated the logic to get entity-id for authorization, to support entities > that may not have qualifiedName as unique attribute > > > Diffs > - > > > authorization/src/main/java/org/apache/atlas/authorize/AtlasAccessRequest.java > 8cdd6768a > > authorization/src/main/java/org/apache/atlas/authorize/AtlasEntityAccessRequest.java > d87c8300b > > authorization/src/main/java/org/apache/atlas/authorize/AtlasRelationshipAccessRequest.java > 87e9b59fc > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 8ab41a31d > > > Diff: https://reviews.apache.org/r/68377/diff/1/ > > > Testing > --- > > - verified that save-search succeeds with this fix > - pre-commit test run - > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/586/ > > > Thanks, > > Madhan Neethiraj > >
