subject:"Re\: Review Request 70605\: ATLAS\-3197 Add QueryText for hive_table and hive

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

2019-05-13 Thread Le Ma



> On May 13, 2019, 6:06 p.m., Ashutosh Mestry wrote:
> > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java
> > Line 205 (original), 205 (patched)
> > 
> >
> > This is a disabled test. Should this be enabled?

Hello Ashutosh, thanks for reviewing this patch. i've ran this test. It seems 
it has not been fixed yet. It shows some errors on my local env. It would be 
better to leave it there for now. Thanks


- Le


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70605/#review215224
---


On May 13, 2019, 5:38 p.m., Le Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70605/
> ---
> 
> (Updated May 13, 2019, 5:38 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan 
> Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3197
> https://issues.apache.org/jira/browse/ATLAS-3197
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch introduced a model called Hive_table_ddl and hive_db_ddl which are 
> used to track commands that are executed either on a table entity or bd 
> entity. DDL entities will be added to a table/db entity through 
> relationshipAttribute call HIVE_DB_TO_DDL and hive_tb_to_ddl. Every time when 
> a new command is executed, a new ddl entity will be created, it will append 
> to the existing DDLQueries field if a table/db has already been created. Once 
> a table/db is deleted, all these relationship attribute will be deleted as 
> well.
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRename.java
>  67ea5275a 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java
>  d1511c0d9 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateTable.java
>  ef4e6874d 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> 28c600e28 
>   
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveMetastoreHookIT.java
>  fdd65eb33 
> 
> 
> Diff: https://reviews.apache.org/r/70605/diff/6/
> 
> 
> Testing
> ---
> 
> 1. table : 
> 
> CREATE TABLE IF NOT EXISTS testDDL (d int, n string);
> 
> 
> ALTER TABLE testDDL RENAME TO renameTestDDL;
> 
> ALTER TABLE renameTestDDL CHANGE n changedCol string;
> 
> ALTER TABLE renameTestDDL ADD COLUMNS(addedCol int);
> 
> DROP TABLE renameTestDDL;
> 
> 
> 2. db 
> 
> create database testdb;
> 
> ALTER DATABASE database SET OWNER USER changedOwner;
> 
> DROP DATABSE testdb;
> 
> 
> File Attachments
> 
> 
> CREATE TABLE IF NOT EXISTS testDDL.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/5047d461-f288-4776-a843-556e45217fef__CREATE_TABLE_IF_NOT_EXISTS_testDDL.png
> ALTER TABLE testDDL RENAME TO renameTestDDL; .png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/373a656d-8ab3-4710-b9a1-3eac20adc947__ALTER_TABLE_testDDL_RENAME_TO_renameTestDDL_.png
> ALTER TABLE renameTestDDL CHANGE n changedCol string; - ddl.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/c9f57d67-c16b-4142-a6b4-9d372e7fd765__ALTER_TABLE_renameTestDDL_CHANGE_n_changedCol_string_-_ddl.png
> ALTER TABLE renameTestDDL CHANGE n changedCol string;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/42612eb6-83c2-4825-8601-5a1629c9de6f__ALTER_TABLE_renameTestDDL_CHANGE_n_changedCol_string.png
> ALTER TABLE renameTestDDL ADD COLUMNS(addedCol int);.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/f5d3522d-17b6-4227-8072-6fc07d88d515__ALTER_TABLE_renameTestDDL_ADD_COLUMNSaddedCol_int.png
> ALTER TABLE renameTestDDL ADD COLUMNS.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/73b9046a-2667-4049-9e11-c5c2b375e9ca__ALTER_TABLE_renameTestDDL_ADD_COLUMNS.png
> DROP TABLE renameTestDDL;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/ebfa01f2-e886-4f94-aa75-ff45bb519ca0__DROP_TABLE_renameTestDDL.png
> ddl - relationship.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/7b30282b-6419-4791-b107-f938918e1cfd__ddl_-_relationship.png
> ALTER DATABASE testdb SET OWNER USER changedOwner;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/388e7ffa-6691-4c2b-bcd9-d8755dc13e3e__ALTER_DATABASE_testdb_SET_OWNER_USER_changedOwner.png
> ALTER DATABASE testdb SET OWNER USER changedOwner; - db entity.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/fd22b6a5-6cb9-40eb-aa10-5389f6f74792__ALTER_DATABASE_testdb_SET_OWNER_USER_changedOwner_-_db_entity.png
> drop database

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

2019-05-13 Thread Madhan Neethiraj



> On May 13, 2019, 5:46 p.m., Madhan Neethiraj wrote:
> > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateTable.java
> > Lines 120 (patched)
> > 
> >
> > Consider adding this condition in line #117 above.
> 
> Le Ma wrote:
> Hello Madhan, thanks for viewing it. If we move the HMS check above #117, 
> none of the table enities will be created for HMS, because table entity will 
> be added to AtlasEntitiesWithExtInfo ret inside the toTableEntity function. 
> Will conbine the hookcheck with #122. Thanks.

You are right. I missed that.


- Madhan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70605/#review215222
---


On May 13, 2019, 5:38 p.m., Le Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70605/
> ---
> 
> (Updated May 13, 2019, 5:38 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan 
> Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3197
> https://issues.apache.org/jira/browse/ATLAS-3197
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch introduced a model called Hive_table_ddl and hive_db_ddl which are 
> used to track commands that are executed either on a table entity or bd 
> entity. DDL entities will be added to a table/db entity through 
> relationshipAttribute call HIVE_DB_TO_DDL and hive_tb_to_ddl. Every time when 
> a new command is executed, a new ddl entity will be created, it will append 
> to the existing DDLQueries field if a table/db has already been created. Once 
> a table/db is deleted, all these relationship attribute will be deleted as 
> well.
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRename.java
>  67ea5275a 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java
>  d1511c0d9 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateTable.java
>  ef4e6874d 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> 28c600e28 
>   
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveMetastoreHookIT.java
>  fdd65eb33 
> 
> 
> Diff: https://reviews.apache.org/r/70605/diff/6/
> 
> 
> Testing
> ---
> 
> 1. table : 
> 
> CREATE TABLE IF NOT EXISTS testDDL (d int, n string);
> 
> 
> ALTER TABLE testDDL RENAME TO renameTestDDL;
> 
> ALTER TABLE renameTestDDL CHANGE n changedCol string;
> 
> ALTER TABLE renameTestDDL ADD COLUMNS(addedCol int);
> 
> DROP TABLE renameTestDDL;
> 
> 
> 2. db 
> 
> create database testdb;
> 
> ALTER DATABASE database SET OWNER USER changedOwner;
> 
> DROP DATABSE testdb;
> 
> 
> File Attachments
> 
> 
> CREATE TABLE IF NOT EXISTS testDDL.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/5047d461-f288-4776-a843-556e45217fef__CREATE_TABLE_IF_NOT_EXISTS_testDDL.png
> ALTER TABLE testDDL RENAME TO renameTestDDL; .png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/373a656d-8ab3-4710-b9a1-3eac20adc947__ALTER_TABLE_testDDL_RENAME_TO_renameTestDDL_.png
> ALTER TABLE renameTestDDL CHANGE n changedCol string; - ddl.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/c9f57d67-c16b-4142-a6b4-9d372e7fd765__ALTER_TABLE_renameTestDDL_CHANGE_n_changedCol_string_-_ddl.png
> ALTER TABLE renameTestDDL CHANGE n changedCol string;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/42612eb6-83c2-4825-8601-5a1629c9de6f__ALTER_TABLE_renameTestDDL_CHANGE_n_changedCol_string.png
> ALTER TABLE renameTestDDL ADD COLUMNS(addedCol int);.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/f5d3522d-17b6-4227-8072-6fc07d88d515__ALTER_TABLE_renameTestDDL_ADD_COLUMNSaddedCol_int.png
> ALTER TABLE renameTestDDL ADD COLUMNS.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/73b9046a-2667-4049-9e11-c5c2b375e9ca__ALTER_TABLE_renameTestDDL_ADD_COLUMNS.png
> DROP TABLE renameTestDDL;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/ebfa01f2-e886-4f94-aa75-ff45bb519ca0__DROP_TABLE_renameTestDDL.png
> ddl - relationship.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/7b30282b-6419-4791-b107-f938918e1cfd__ddl_-_relationship.png
> ALTER DATABASE testdb SET OWNER USER changedOwner;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/388e7ffa-6691-4c2b-bcd9-d8755dc13e3e__ALTER_DATABASE_testdb_SET_OWNER_USER_changedOwner.png
> ALTER DATABASE testdb SET OWNER USER changedOwner; - db entity.png
>   
>

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

2019-05-13 Thread Le Ma



> On May 13, 2019, 5:46 p.m., Madhan Neethiraj wrote:
> > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateTable.java
> > Lines 120 (patched)
> > 
> >
> > Consider adding this condition in line #117 above.

Hello Madhan, thanks for viewing it. If we move the HMS check above #117, none 
of the table enities will be created for HMS, because table entity will be 
added to AtlasEntitiesWithExtInfo ret inside the toTableEntity function. Will 
conbine the hookcheck with #122. Thanks.


- Le


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70605/#review215222
---


On May 13, 2019, 5:38 p.m., Le Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70605/
> ---
> 
> (Updated May 13, 2019, 5:38 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan 
> Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3197
> https://issues.apache.org/jira/browse/ATLAS-3197
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch introduced a model called Hive_table_ddl and hive_db_ddl which are 
> used to track commands that are executed either on a table entity or bd 
> entity. DDL entities will be added to a table/db entity through 
> relationshipAttribute call HIVE_DB_TO_DDL and hive_tb_to_ddl. Every time when 
> a new command is executed, a new ddl entity will be created, it will append 
> to the existing DDLQueries field if a table/db has already been created. Once 
> a table/db is deleted, all these relationship attribute will be deleted as 
> well.
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRename.java
>  67ea5275a 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java
>  d1511c0d9 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateTable.java
>  ef4e6874d 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> 28c600e28 
>   
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveMetastoreHookIT.java
>  fdd65eb33 
> 
> 
> Diff: https://reviews.apache.org/r/70605/diff/6/
> 
> 
> Testing
> ---
> 
> 1. table : 
> 
> CREATE TABLE IF NOT EXISTS testDDL (d int, n string);
> 
> 
> ALTER TABLE testDDL RENAME TO renameTestDDL;
> 
> ALTER TABLE renameTestDDL CHANGE n changedCol string;
> 
> ALTER TABLE renameTestDDL ADD COLUMNS(addedCol int);
> 
> DROP TABLE renameTestDDL;
> 
> 
> 2. db 
> 
> create database testdb;
> 
> ALTER DATABASE database SET OWNER USER changedOwner;
> 
> DROP DATABSE testdb;
> 
> 
> File Attachments
> 
> 
> CREATE TABLE IF NOT EXISTS testDDL.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/5047d461-f288-4776-a843-556e45217fef__CREATE_TABLE_IF_NOT_EXISTS_testDDL.png
> ALTER TABLE testDDL RENAME TO renameTestDDL; .png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/373a656d-8ab3-4710-b9a1-3eac20adc947__ALTER_TABLE_testDDL_RENAME_TO_renameTestDDL_.png
> ALTER TABLE renameTestDDL CHANGE n changedCol string; - ddl.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/c9f57d67-c16b-4142-a6b4-9d372e7fd765__ALTER_TABLE_renameTestDDL_CHANGE_n_changedCol_string_-_ddl.png
> ALTER TABLE renameTestDDL CHANGE n changedCol string;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/42612eb6-83c2-4825-8601-5a1629c9de6f__ALTER_TABLE_renameTestDDL_CHANGE_n_changedCol_string.png
> ALTER TABLE renameTestDDL ADD COLUMNS(addedCol int);.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/f5d3522d-17b6-4227-8072-6fc07d88d515__ALTER_TABLE_renameTestDDL_ADD_COLUMNSaddedCol_int.png
> ALTER TABLE renameTestDDL ADD COLUMNS.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/73b9046a-2667-4049-9e11-c5c2b375e9ca__ALTER_TABLE_renameTestDDL_ADD_COLUMNS.png
> DROP TABLE renameTestDDL;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/ebfa01f2-e886-4f94-aa75-ff45bb519ca0__DROP_TABLE_renameTestDDL.png
> ddl - relationship.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/7b30282b-6419-4791-b107-f938918e1cfd__ddl_-_relationship.png
> ALTER DATABASE testdb SET OWNER USER changedOwner;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/388e7ffa-6691-4c2b-bcd9-d8755dc13e3e__ALTER_DATABASE_testdb_SET_OWNER_USER_changedOwner.png
> ALTER DATABASE testdb SET OWNER USER changedOwner; - db entity.png
>   
>

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

2019-05-13 Thread Ashutosh Mestry via Review Board


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70605/#review215224
---




addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateTable.java
Lines 120 (patched)


Consider splitting into appropriately named methods.



addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java
Line 205 (original), 205 (patched)


This is a disabled test. Should this be enabled?



addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java
Line 386 (original), 391 (patched)


Delay of 100ms is not sufficient (based on some experimentation). Consider 
5000ms.


- Ashutosh Mestry


On May 13, 2019, 5:38 p.m., Le Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70605/
> ---
> 
> (Updated May 13, 2019, 5:38 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan 
> Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3197
> https://issues.apache.org/jira/browse/ATLAS-3197
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch introduced a model called Hive_table_ddl and hive_db_ddl which are 
> used to track commands that are executed either on a table entity or bd 
> entity. DDL entities will be added to a table/db entity through 
> relationshipAttribute call HIVE_DB_TO_DDL and hive_tb_to_ddl. Every time when 
> a new command is executed, a new ddl entity will be created, it will append 
> to the existing DDLQueries field if a table/db has already been created. Once 
> a table/db is deleted, all these relationship attribute will be deleted as 
> well.
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRename.java
>  67ea5275a 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java
>  d1511c0d9 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateTable.java
>  ef4e6874d 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> 28c600e28 
>   
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveMetastoreHookIT.java
>  fdd65eb33 
> 
> 
> Diff: https://reviews.apache.org/r/70605/diff/6/
> 
> 
> Testing
> ---
> 
> 1. table : 
> 
> CREATE TABLE IF NOT EXISTS testDDL (d int, n string);
> 
> 
> ALTER TABLE testDDL RENAME TO renameTestDDL;
> 
> ALTER TABLE renameTestDDL CHANGE n changedCol string;
> 
> ALTER TABLE renameTestDDL ADD COLUMNS(addedCol int);
> 
> DROP TABLE renameTestDDL;
> 
> 
> 2. db 
> 
> create database testdb;
> 
> ALTER DATABASE database SET OWNER USER changedOwner;
> 
> DROP DATABSE testdb;
> 
> 
> File Attachments
> 
> 
> CREATE TABLE IF NOT EXISTS testDDL.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/5047d461-f288-4776-a843-556e45217fef__CREATE_TABLE_IF_NOT_EXISTS_testDDL.png
> ALTER TABLE testDDL RENAME TO renameTestDDL; .png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/373a656d-8ab3-4710-b9a1-3eac20adc947__ALTER_TABLE_testDDL_RENAME_TO_renameTestDDL_.png
> ALTER TABLE renameTestDDL CHANGE n changedCol string; - ddl.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/c9f57d67-c16b-4142-a6b4-9d372e7fd765__ALTER_TABLE_renameTestDDL_CHANGE_n_changedCol_string_-_ddl.png
> ALTER TABLE renameTestDDL CHANGE n changedCol string;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/42612eb6-83c2-4825-8601-5a1629c9de6f__ALTER_TABLE_renameTestDDL_CHANGE_n_changedCol_string.png
> ALTER TABLE renameTestDDL ADD COLUMNS(addedCol int);.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/f5d3522d-17b6-4227-8072-6fc07d88d515__ALTER_TABLE_renameTestDDL_ADD_COLUMNSaddedCol_int.png
> ALTER TABLE renameTestDDL ADD COLUMNS.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/73b9046a-2667-4049-9e11-c5c2b375e9ca__ALTER_TABLE_renameTestDDL_ADD_COLUMNS.png
> DROP TABLE renameTestDDL;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/ebfa01f2-e886-4f94-aa75-ff45bb519ca0__DROP_TABLE_renameTestDDL.png
> ddl - relationship.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/7b30282b-6419-4791-b107-f938918e1cfd__ddl_-_relationship.png
> ALTER DATABASE testdb SET OWNER USER changedOwner;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/388e7ffa-6691-4c2b-bcd9-d8755dc13e3e__ALTER_DATABASE_testdb_SET_OWNER_USER_changedOwner.png
> ALTER DATABASE testdb SET OWNER USER changedOwner; - db

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

2019-05-13 Thread Madhan Neethiraj


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70605/#review215222
---




addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRename.java
Line 146 (original), 146 (patched)


Instead of an explicit argument 'isMetastoreHook', why not use 
context.isMetastoreHook()?



addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateTable.java
Lines 120 (patched)


Consider adding this condition in line #117 above.


- Madhan Neethiraj


On May 13, 2019, 5:38 p.m., Le Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70605/
> ---
> 
> (Updated May 13, 2019, 5:38 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan 
> Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3197
> https://issues.apache.org/jira/browse/ATLAS-3197
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch introduced a model called Hive_table_ddl and hive_db_ddl which are 
> used to track commands that are executed either on a table entity or bd 
> entity. DDL entities will be added to a table/db entity through 
> relationshipAttribute call HIVE_DB_TO_DDL and hive_tb_to_ddl. Every time when 
> a new command is executed, a new ddl entity will be created, it will append 
> to the existing DDLQueries field if a table/db has already been created. Once 
> a table/db is deleted, all these relationship attribute will be deleted as 
> well.
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRename.java
>  67ea5275a 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java
>  d1511c0d9 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateTable.java
>  ef4e6874d 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> 28c600e28 
>   
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveMetastoreHookIT.java
>  fdd65eb33 
> 
> 
> Diff: https://reviews.apache.org/r/70605/diff/6/
> 
> 
> Testing
> ---
> 
> 1. table : 
> 
> CREATE TABLE IF NOT EXISTS testDDL (d int, n string);
> 
> 
> ALTER TABLE testDDL RENAME TO renameTestDDL;
> 
> ALTER TABLE renameTestDDL CHANGE n changedCol string;
> 
> ALTER TABLE renameTestDDL ADD COLUMNS(addedCol int);
> 
> DROP TABLE renameTestDDL;
> 
> 
> 2. db 
> 
> create database testdb;
> 
> ALTER DATABASE database SET OWNER USER changedOwner;
> 
> DROP DATABSE testdb;
> 
> 
> File Attachments
> 
> 
> CREATE TABLE IF NOT EXISTS testDDL.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/5047d461-f288-4776-a843-556e45217fef__CREATE_TABLE_IF_NOT_EXISTS_testDDL.png
> ALTER TABLE testDDL RENAME TO renameTestDDL; .png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/373a656d-8ab3-4710-b9a1-3eac20adc947__ALTER_TABLE_testDDL_RENAME_TO_renameTestDDL_.png
> ALTER TABLE renameTestDDL CHANGE n changedCol string; - ddl.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/c9f57d67-c16b-4142-a6b4-9d372e7fd765__ALTER_TABLE_renameTestDDL_CHANGE_n_changedCol_string_-_ddl.png
> ALTER TABLE renameTestDDL CHANGE n changedCol string;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/42612eb6-83c2-4825-8601-5a1629c9de6f__ALTER_TABLE_renameTestDDL_CHANGE_n_changedCol_string.png
> ALTER TABLE renameTestDDL ADD COLUMNS(addedCol int);.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/f5d3522d-17b6-4227-8072-6fc07d88d515__ALTER_TABLE_renameTestDDL_ADD_COLUMNSaddedCol_int.png
> ALTER TABLE renameTestDDL ADD COLUMNS.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/73b9046a-2667-4049-9e11-c5c2b375e9ca__ALTER_TABLE_renameTestDDL_ADD_COLUMNS.png
> DROP TABLE renameTestDDL;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/ebfa01f2-e886-4f94-aa75-ff45bb519ca0__DROP_TABLE_renameTestDDL.png
> ddl - relationship.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/7b30282b-6419-4791-b107-f938918e1cfd__ddl_-_relationship.png
> ALTER DATABASE testdb SET OWNER USER changedOwner;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/388e7ffa-6691-4c2b-bcd9-d8755dc13e3e__ALTER_DATABASE_testdb_SET_OWNER_USER_changedOwner.png
> ALTER DATABASE testdb SET OWNER USER changedOwner; - db entity.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/fd22b6a5-6cb9-40eb-aa10-5389f6f74792__ALTER_DATABASE_testdb_SET_OWNER_USER_changedOwner_-_db_entity.png
> drop database testdb;.png

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

2019-05-13 Thread Le Ma


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70605/
---

(Updated May 13, 2019, 5:38 p.m.)


Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan 
Neethiraj, and Sarath Subramanian.


Changes
---

Handle HMS for process/processExe/DDL


Bugs: ATLAS-3197
https://issues.apache.org/jira/browse/ATLAS-3197


Repository: atlas


Description
---

This patch introduced a model called Hive_table_ddl and hive_db_ddl which are 
used to track commands that are executed either on a table entity or bd entity. 
DDL entities will be added to a table/db entity through relationshipAttribute 
call HIVE_DB_TO_DDL and hive_tb_to_ddl. Every time when a new command is 
executed, a new ddl entity will be created, it will append to the existing 
DDLQueries field if a table/db has already been created. Once a table/db is 
deleted, all these relationship attribute will be deleted as well.


Diffs (updated)
-

  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRename.java
 67ea5275a 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java
 d1511c0d9 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateTable.java
 ef4e6874d 
  addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
28c600e28 
  
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveMetastoreHookIT.java
 fdd65eb33 


Diff: https://reviews.apache.org/r/70605/diff/6/

Changes: https://reviews.apache.org/r/70605/diff/5-6/


Testing
---

1. table : 

CREATE TABLE IF NOT EXISTS testDDL (d int, n string);


ALTER TABLE testDDL RENAME TO renameTestDDL;

ALTER TABLE renameTestDDL CHANGE n changedCol string;

ALTER TABLE renameTestDDL ADD COLUMNS(addedCol int);

DROP TABLE renameTestDDL;


2. db 

create database testdb;

ALTER DATABASE database SET OWNER USER changedOwner;

DROP DATABSE testdb;


File Attachments


CREATE TABLE IF NOT EXISTS testDDL.png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/5047d461-f288-4776-a843-556e45217fef__CREATE_TABLE_IF_NOT_EXISTS_testDDL.png
ALTER TABLE testDDL RENAME TO renameTestDDL; .png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/373a656d-8ab3-4710-b9a1-3eac20adc947__ALTER_TABLE_testDDL_RENAME_TO_renameTestDDL_.png
ALTER TABLE renameTestDDL CHANGE n changedCol string; - ddl.png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/c9f57d67-c16b-4142-a6b4-9d372e7fd765__ALTER_TABLE_renameTestDDL_CHANGE_n_changedCol_string_-_ddl.png
ALTER TABLE renameTestDDL CHANGE n changedCol string;.png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/42612eb6-83c2-4825-8601-5a1629c9de6f__ALTER_TABLE_renameTestDDL_CHANGE_n_changedCol_string.png
ALTER TABLE renameTestDDL ADD COLUMNS(addedCol int);.png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/f5d3522d-17b6-4227-8072-6fc07d88d515__ALTER_TABLE_renameTestDDL_ADD_COLUMNSaddedCol_int.png
ALTER TABLE renameTestDDL ADD COLUMNS.png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/73b9046a-2667-4049-9e11-c5c2b375e9ca__ALTER_TABLE_renameTestDDL_ADD_COLUMNS.png
DROP TABLE renameTestDDL;.png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/ebfa01f2-e886-4f94-aa75-ff45bb519ca0__DROP_TABLE_renameTestDDL.png
ddl - relationship.png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/7b30282b-6419-4791-b107-f938918e1cfd__ddl_-_relationship.png
ALTER DATABASE testdb SET OWNER USER changedOwner;.png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/388e7ffa-6691-4c2b-bcd9-d8755dc13e3e__ALTER_DATABASE_testdb_SET_OWNER_USER_changedOwner.png
ALTER DATABASE testdb SET OWNER USER changedOwner; - db entity.png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/fd22b6a5-6cb9-40eb-aa10-5389f6f74792__ALTER_DATABASE_testdb_SET_OWNER_USER_changedOwner_-_db_entity.png
drop database testdb;.png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/7c889d62-66c8-4c26-bf94-257bd01cdb70__drop_database_testdb.png
drop database testdb;.png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/4163043b-c2f1-42ee-9e5c-cfffbc589fb3__drop_database_testdb.png


Thanks,

Le Ma

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

2019-05-09 Thread Le Ma


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70605/
---

(Updated May 9, 2019, 10:30 p.m.)


Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan 
Neethiraj, and Sarath Subramanian.


Changes
---

Address Aadarsh's comment and add corresponding test.


Bugs: ATLAS-3197
https://issues.apache.org/jira/browse/ATLAS-3197


Repository: atlas


Description
---

This patch introduced a model called Hive_table_ddl and hive_db_ddl which are 
used to track commands that are executed either on a table entity or bd entity. 
DDL entities will be added to a table/db entity through relationshipAttribute 
call HIVE_DB_TO_DDL and hive_tb_to_ddl. Every time when a new command is 
executed, a new ddl entity will be created, it will append to the existing 
DDLQueries field if a table/db has already been created. Once a table/db is 
deleted, all these relationship attribute will be deleted as well.


Diffs (updated)
-

  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRename.java
 d3d83490f 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java
 de8de63b6 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateDatabase.java
 b01f61f76 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java
 d1511c0d9 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateTable.java
 b5ce09332 
  addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
24de30f5a 
  addons/models/1000-Hadoop/1030-hive_model.json ee6945a77 


Diff: https://reviews.apache.org/r/70605/diff/5/

Changes: https://reviews.apache.org/r/70605/diff/4-5/


Testing
---

1. table : 

CREATE TABLE IF NOT EXISTS testDDL (d int, n string);


ALTER TABLE testDDL RENAME TO renameTestDDL;

ALTER TABLE renameTestDDL CHANGE n changedCol string;

ALTER TABLE renameTestDDL ADD COLUMNS(addedCol int);

DROP TABLE renameTestDDL;


2. db 

create database testdb;

ALTER DATABASE database SET OWNER USER changedOwner;

DROP DATABSE testdb;


File Attachments


CREATE TABLE IF NOT EXISTS testDDL.png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/5047d461-f288-4776-a843-556e45217fef__CREATE_TABLE_IF_NOT_EXISTS_testDDL.png
ALTER TABLE testDDL RENAME TO renameTestDDL; .png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/373a656d-8ab3-4710-b9a1-3eac20adc947__ALTER_TABLE_testDDL_RENAME_TO_renameTestDDL_.png
ALTER TABLE renameTestDDL CHANGE n changedCol string; - ddl.png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/c9f57d67-c16b-4142-a6b4-9d372e7fd765__ALTER_TABLE_renameTestDDL_CHANGE_n_changedCol_string_-_ddl.png
ALTER TABLE renameTestDDL CHANGE n changedCol string;.png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/42612eb6-83c2-4825-8601-5a1629c9de6f__ALTER_TABLE_renameTestDDL_CHANGE_n_changedCol_string.png
ALTER TABLE renameTestDDL ADD COLUMNS(addedCol int);.png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/f5d3522d-17b6-4227-8072-6fc07d88d515__ALTER_TABLE_renameTestDDL_ADD_COLUMNSaddedCol_int.png
ALTER TABLE renameTestDDL ADD COLUMNS.png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/73b9046a-2667-4049-9e11-c5c2b375e9ca__ALTER_TABLE_renameTestDDL_ADD_COLUMNS.png
DROP TABLE renameTestDDL;.png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/ebfa01f2-e886-4f94-aa75-ff45bb519ca0__DROP_TABLE_renameTestDDL.png
ddl - relationship.png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/7b30282b-6419-4791-b107-f938918e1cfd__ddl_-_relationship.png
ALTER DATABASE testdb SET OWNER USER changedOwner;.png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/388e7ffa-6691-4c2b-bcd9-d8755dc13e3e__ALTER_DATABASE_testdb_SET_OWNER_USER_changedOwner.png
ALTER DATABASE testdb SET OWNER USER changedOwner; - db entity.png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/fd22b6a5-6cb9-40eb-aa10-5389f6f74792__ALTER_DATABASE_testdb_SET_OWNER_USER_changedOwner_-_db_entity.png
drop database testdb;.png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/7c889d62-66c8-4c26-bf94-257bd01cdb70__drop_database_testdb.png
drop database testdb;.png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/4163043b-c2f1-42ee-9e5c-cfffbc589fb3__drop_database_testdb.png


Thanks,

Le Ma

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

2019-05-08 Thread Aadarsh Jajodia


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70605/#review215147
---



If i run a CTAS query, does the newly created table get any hive_ddl 
attritbutes?

- Aadarsh Jajodia


On May 8, 2019, 11:22 p.m., Le Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70605/
> ---
> 
> (Updated May 8, 2019, 11:22 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan 
> Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3197
> https://issues.apache.org/jira/browse/ATLAS-3197
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch introduced a model called Hive_table_ddl and hive_db_ddl which are 
> used to track commands that are executed either on a table entity or bd 
> entity. DDL entities will be added to a table/db entity through 
> relationshipAttribute call HIVE_DB_TO_DDL and hive_tb_to_ddl. Every time when 
> a new command is executed, a new ddl entity will be created, it will append 
> to the existing DDLQueries field if a table/db has already been created. Once 
> a table/db is deleted, all these relationship attribute will be deleted as 
> well.
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRename.java
>  d3d83490f 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java
>  de8de63b6 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateDatabase.java
>  b01f61f76 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateTable.java
>  b5ce09332 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> 24de30f5a 
>   addons/models/1000-Hadoop/1030-hive_model.json ee6945a77 
> 
> 
> Diff: https://reviews.apache.org/r/70605/diff/4/
> 
> 
> Testing
> ---
> 
> 1. table : 
> 
> CREATE TABLE IF NOT EXISTS testDDL (d int, n string);
> 
> 
> ALTER TABLE testDDL RENAME TO renameTestDDL;
> 
> ALTER TABLE renameTestDDL CHANGE n changedCol string;
> 
> ALTER TABLE renameTestDDL ADD COLUMNS(addedCol int);
> 
> DROP TABLE renameTestDDL;
> 
> 
> 2. db 
> 
> create database testdb;
> 
> ALTER DATABASE database SET OWNER USER changedOwner;
> 
> DROP DATABSE testdb;
> 
> 
> File Attachments
> 
> 
> CREATE TABLE IF NOT EXISTS testDDL.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/5047d461-f288-4776-a843-556e45217fef__CREATE_TABLE_IF_NOT_EXISTS_testDDL.png
> ALTER TABLE testDDL RENAME TO renameTestDDL; .png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/373a656d-8ab3-4710-b9a1-3eac20adc947__ALTER_TABLE_testDDL_RENAME_TO_renameTestDDL_.png
> ALTER TABLE renameTestDDL CHANGE n changedCol string; - ddl.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/c9f57d67-c16b-4142-a6b4-9d372e7fd765__ALTER_TABLE_renameTestDDL_CHANGE_n_changedCol_string_-_ddl.png
> ALTER TABLE renameTestDDL CHANGE n changedCol string;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/42612eb6-83c2-4825-8601-5a1629c9de6f__ALTER_TABLE_renameTestDDL_CHANGE_n_changedCol_string.png
> ALTER TABLE renameTestDDL ADD COLUMNS(addedCol int);.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/f5d3522d-17b6-4227-8072-6fc07d88d515__ALTER_TABLE_renameTestDDL_ADD_COLUMNSaddedCol_int.png
> ALTER TABLE renameTestDDL ADD COLUMNS.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/73b9046a-2667-4049-9e11-c5c2b375e9ca__ALTER_TABLE_renameTestDDL_ADD_COLUMNS.png
> DROP TABLE renameTestDDL;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/ebfa01f2-e886-4f94-aa75-ff45bb519ca0__DROP_TABLE_renameTestDDL.png
> ddl - relationship.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/7b30282b-6419-4791-b107-f938918e1cfd__ddl_-_relationship.png
> ALTER DATABASE testdb SET OWNER USER changedOwner;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/388e7ffa-6691-4c2b-bcd9-d8755dc13e3e__ALTER_DATABASE_testdb_SET_OWNER_USER_changedOwner.png
> ALTER DATABASE testdb SET OWNER USER changedOwner; - db entity.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/fd22b6a5-6cb9-40eb-aa10-5389f6f74792__ALTER_DATABASE_testdb_SET_OWNER_USER_changedOwner_-_db_entity.png
> drop database testdb;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/7c889d62-66c8-4c26-bf94-257bd01cdb70__drop_database_testdb.png
> drop database testdb;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/4163043b-c2f1-42ee-9e5c-cfffbc589fb3__drop_database_testdb.png
> 
> 
> Thanks,
> 
> Le Ma
> 
>

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

2019-05-08 Thread Madhan Neethiraj


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70605/#review215146
---




addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java
Lines 149 (patched)


Model file has this attribute as 'execTime'; ATTRIBUTE_TIMESTAMP should be 
updated for this change. I will update and merge.


- Madhan Neethiraj


On May 8, 2019, 11:22 p.m., Le Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70605/
> ---
> 
> (Updated May 8, 2019, 11:22 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan 
> Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3197
> https://issues.apache.org/jira/browse/ATLAS-3197
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch introduced a model called Hive_table_ddl and hive_db_ddl which are 
> used to track commands that are executed either on a table entity or bd 
> entity. DDL entities will be added to a table/db entity through 
> relationshipAttribute call HIVE_DB_TO_DDL and hive_tb_to_ddl. Every time when 
> a new command is executed, a new ddl entity will be created, it will append 
> to the existing DDLQueries field if a table/db has already been created. Once 
> a table/db is deleted, all these relationship attribute will be deleted as 
> well.
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRename.java
>  d3d83490f 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java
>  de8de63b6 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateDatabase.java
>  b01f61f76 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateTable.java
>  b5ce09332 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> 24de30f5a 
>   addons/models/1000-Hadoop/1030-hive_model.json ee6945a77 
> 
> 
> Diff: https://reviews.apache.org/r/70605/diff/4/
> 
> 
> Testing
> ---
> 
> 1. table : 
> 
> CREATE TABLE IF NOT EXISTS testDDL (d int, n string);
> 
> 
> ALTER TABLE testDDL RENAME TO renameTestDDL;
> 
> ALTER TABLE renameTestDDL CHANGE n changedCol string;
> 
> ALTER TABLE renameTestDDL ADD COLUMNS(addedCol int);
> 
> DROP TABLE renameTestDDL;
> 
> 
> 2. db 
> 
> create database testdb;
> 
> ALTER DATABASE database SET OWNER USER changedOwner;
> 
> DROP DATABSE testdb;
> 
> 
> File Attachments
> 
> 
> CREATE TABLE IF NOT EXISTS testDDL.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/5047d461-f288-4776-a843-556e45217fef__CREATE_TABLE_IF_NOT_EXISTS_testDDL.png
> ALTER TABLE testDDL RENAME TO renameTestDDL; .png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/373a656d-8ab3-4710-b9a1-3eac20adc947__ALTER_TABLE_testDDL_RENAME_TO_renameTestDDL_.png
> ALTER TABLE renameTestDDL CHANGE n changedCol string; - ddl.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/c9f57d67-c16b-4142-a6b4-9d372e7fd765__ALTER_TABLE_renameTestDDL_CHANGE_n_changedCol_string_-_ddl.png
> ALTER TABLE renameTestDDL CHANGE n changedCol string;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/42612eb6-83c2-4825-8601-5a1629c9de6f__ALTER_TABLE_renameTestDDL_CHANGE_n_changedCol_string.png
> ALTER TABLE renameTestDDL ADD COLUMNS(addedCol int);.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/f5d3522d-17b6-4227-8072-6fc07d88d515__ALTER_TABLE_renameTestDDL_ADD_COLUMNSaddedCol_int.png
> ALTER TABLE renameTestDDL ADD COLUMNS.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/73b9046a-2667-4049-9e11-c5c2b375e9ca__ALTER_TABLE_renameTestDDL_ADD_COLUMNS.png
> DROP TABLE renameTestDDL;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/ebfa01f2-e886-4f94-aa75-ff45bb519ca0__DROP_TABLE_renameTestDDL.png
> ddl - relationship.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/7b30282b-6419-4791-b107-f938918e1cfd__ddl_-_relationship.png
> ALTER DATABASE testdb SET OWNER USER changedOwner;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/388e7ffa-6691-4c2b-bcd9-d8755dc13e3e__ALTER_DATABASE_testdb_SET_OWNER_USER_changedOwner.png
> ALTER DATABASE testdb SET OWNER USER changedOwner; - db entity.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/fd22b6a5-6cb9-40eb-aa10-5389f6f74792__ALTER_DATABASE_testdb_SET_OWNER_USER_changedOwner_-_db_entity.png
> drop database testdb;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/7c889d62-66c8-4c26-bf94-257bd01cdb70__drop_database_testdb.png
> drop

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

2019-05-08 Thread Madhan Neethiraj


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70605/#review215144
---


Ship it!




Ship It!

- Madhan Neethiraj


On May 8, 2019, 11:22 p.m., Le Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70605/
> ---
> 
> (Updated May 8, 2019, 11:22 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan 
> Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3197
> https://issues.apache.org/jira/browse/ATLAS-3197
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch introduced a model called Hive_table_ddl and hive_db_ddl which are 
> used to track commands that are executed either on a table entity or bd 
> entity. DDL entities will be added to a table/db entity through 
> relationshipAttribute call HIVE_DB_TO_DDL and hive_tb_to_ddl. Every time when 
> a new command is executed, a new ddl entity will be created, it will append 
> to the existing DDLQueries field if a table/db has already been created. Once 
> a table/db is deleted, all these relationship attribute will be deleted as 
> well.
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRename.java
>  d3d83490f 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java
>  de8de63b6 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateDatabase.java
>  b01f61f76 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateTable.java
>  b5ce09332 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> 24de30f5a 
>   addons/models/1000-Hadoop/1030-hive_model.json ee6945a77 
> 
> 
> Diff: https://reviews.apache.org/r/70605/diff/4/
> 
> 
> Testing
> ---
> 
> 1. table : 
> 
> CREATE TABLE IF NOT EXISTS testDDL (d int, n string);
> 
> 
> ALTER TABLE testDDL RENAME TO renameTestDDL;
> 
> ALTER TABLE renameTestDDL CHANGE n changedCol string;
> 
> ALTER TABLE renameTestDDL ADD COLUMNS(addedCol int);
> 
> DROP TABLE renameTestDDL;
> 
> 
> 2. db 
> 
> create database testdb;
> 
> ALTER DATABASE database SET OWNER USER changedOwner;
> 
> DROP DATABSE testdb;
> 
> 
> File Attachments
> 
> 
> CREATE TABLE IF NOT EXISTS testDDL.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/5047d461-f288-4776-a843-556e45217fef__CREATE_TABLE_IF_NOT_EXISTS_testDDL.png
> ALTER TABLE testDDL RENAME TO renameTestDDL; .png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/373a656d-8ab3-4710-b9a1-3eac20adc947__ALTER_TABLE_testDDL_RENAME_TO_renameTestDDL_.png
> ALTER TABLE renameTestDDL CHANGE n changedCol string; - ddl.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/c9f57d67-c16b-4142-a6b4-9d372e7fd765__ALTER_TABLE_renameTestDDL_CHANGE_n_changedCol_string_-_ddl.png
> ALTER TABLE renameTestDDL CHANGE n changedCol string;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/42612eb6-83c2-4825-8601-5a1629c9de6f__ALTER_TABLE_renameTestDDL_CHANGE_n_changedCol_string.png
> ALTER TABLE renameTestDDL ADD COLUMNS(addedCol int);.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/f5d3522d-17b6-4227-8072-6fc07d88d515__ALTER_TABLE_renameTestDDL_ADD_COLUMNSaddedCol_int.png
> ALTER TABLE renameTestDDL ADD COLUMNS.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/73b9046a-2667-4049-9e11-c5c2b375e9ca__ALTER_TABLE_renameTestDDL_ADD_COLUMNS.png
> DROP TABLE renameTestDDL;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/ebfa01f2-e886-4f94-aa75-ff45bb519ca0__DROP_TABLE_renameTestDDL.png
> ddl - relationship.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/7b30282b-6419-4791-b107-f938918e1cfd__ddl_-_relationship.png
> ALTER DATABASE testdb SET OWNER USER changedOwner;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/388e7ffa-6691-4c2b-bcd9-d8755dc13e3e__ALTER_DATABASE_testdb_SET_OWNER_USER_changedOwner.png
> ALTER DATABASE testdb SET OWNER USER changedOwner; - db entity.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/fd22b6a5-6cb9-40eb-aa10-5389f6f74792__ALTER_DATABASE_testdb_SET_OWNER_USER_changedOwner_-_db_entity.png
> drop database testdb;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/7c889d62-66c8-4c26-bf94-257bd01cdb70__drop_database_testdb.png
> drop database testdb;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/4163043b-c2f1-42ee-9e5c-cfffbc589fb3__drop_database_testdb.png
> 
> 
> Thanks,
> 
> Le Ma
> 
>

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

2019-05-08 Thread Le Ma


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70605/
---

(Updated May 8, 2019, 11:22 p.m.)


Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan 
Neethiraj, and Sarath Subramanian.


Changes
---

Thank you all for reviewing it. Addressed comments. Re-run end-2-end tests and 
unit tests. it works good.


Bugs: ATLAS-3197
https://issues.apache.org/jira/browse/ATLAS-3197


Repository: atlas


Description
---

This patch introduced a model called Hive_table_ddl and hive_db_ddl which are 
used to track commands that are executed either on a table entity or bd entity. 
DDL entities will be added to a table/db entity through relationshipAttribute 
call HIVE_DB_TO_DDL and hive_tb_to_ddl. Every time when a new command is 
executed, a new ddl entity will be created, it will append to the existing 
DDLQueries field if a table/db has already been created. Once a table/db is 
deleted, all these relationship attribute will be deleted as well.


Diffs (updated)
-

  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRename.java
 d3d83490f 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java
 de8de63b6 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateDatabase.java
 b01f61f76 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateTable.java
 b5ce09332 
  addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
24de30f5a 
  addons/models/1000-Hadoop/1030-hive_model.json ee6945a77 


Diff: https://reviews.apache.org/r/70605/diff/4/

Changes: https://reviews.apache.org/r/70605/diff/3-4/


Testing
---

1. table : 

CREATE TABLE IF NOT EXISTS testDDL (d int, n string);


ALTER TABLE testDDL RENAME TO renameTestDDL;

ALTER TABLE renameTestDDL CHANGE n changedCol string;

ALTER TABLE renameTestDDL ADD COLUMNS(addedCol int);

DROP TABLE renameTestDDL;


2. db 

create database testdb;

ALTER DATABASE database SET OWNER USER changedOwner;

DROP DATABSE testdb;


File Attachments


CREATE TABLE IF NOT EXISTS testDDL.png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/5047d461-f288-4776-a843-556e45217fef__CREATE_TABLE_IF_NOT_EXISTS_testDDL.png
ALTER TABLE testDDL RENAME TO renameTestDDL; .png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/373a656d-8ab3-4710-b9a1-3eac20adc947__ALTER_TABLE_testDDL_RENAME_TO_renameTestDDL_.png
ALTER TABLE renameTestDDL CHANGE n changedCol string; - ddl.png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/c9f57d67-c16b-4142-a6b4-9d372e7fd765__ALTER_TABLE_renameTestDDL_CHANGE_n_changedCol_string_-_ddl.png
ALTER TABLE renameTestDDL CHANGE n changedCol string;.png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/42612eb6-83c2-4825-8601-5a1629c9de6f__ALTER_TABLE_renameTestDDL_CHANGE_n_changedCol_string.png
ALTER TABLE renameTestDDL ADD COLUMNS(addedCol int);.png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/f5d3522d-17b6-4227-8072-6fc07d88d515__ALTER_TABLE_renameTestDDL_ADD_COLUMNSaddedCol_int.png
ALTER TABLE renameTestDDL ADD COLUMNS.png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/73b9046a-2667-4049-9e11-c5c2b375e9ca__ALTER_TABLE_renameTestDDL_ADD_COLUMNS.png
DROP TABLE renameTestDDL;.png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/ebfa01f2-e886-4f94-aa75-ff45bb519ca0__DROP_TABLE_renameTestDDL.png
ddl - relationship.png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/7b30282b-6419-4791-b107-f938918e1cfd__ddl_-_relationship.png
ALTER DATABASE testdb SET OWNER USER changedOwner;.png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/388e7ffa-6691-4c2b-bcd9-d8755dc13e3e__ALTER_DATABASE_testdb_SET_OWNER_USER_changedOwner.png
ALTER DATABASE testdb SET OWNER USER changedOwner; - db entity.png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/fd22b6a5-6cb9-40eb-aa10-5389f6f74792__ALTER_DATABASE_testdb_SET_OWNER_USER_changedOwner_-_db_entity.png
drop database testdb;.png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/7c889d62-66c8-4c26-bf94-257bd01cdb70__drop_database_testdb.png
drop database testdb;.png
  
https://reviews.apache.org/media/uploaded/files/2019/05/07/4163043b-c2f1-42ee-9e5c-cfffbc589fb3__drop_database_testdb.png


Thanks,

Le Ma

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

2019-05-07 Thread Madhan Neethiraj


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70605/#review215117
---




addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRename.java
Lines 154 (patched)


Since 'renamedTableEntity' was included in the previous notification (line 
#148), it is not necessary to include the same entity as a referredEntity. 
Please see more comments in getHiveDDLEntity(). Consider the following 
optimization:

  AtlasEntity ddlEntity = getHiveDDLEntity(renamedTableEntity.getEntity(), 
true);
  
  if (ddlEntity != null) {
   ret.add(new EntityCreateRequestV2(getUserName(), new 
AtlasEntitiesWithExtInfo(ddlEntity);
  }

Please review other such occurrence of entity-update.



addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java
Lines 675 (patched)


By adding unique-attributes to object-id created here, we can avoid sending 
'dbOrTable' as referred entity for 'alter' statements. Consider the following:

protected AtlasEntity getHiveDDLEntity(AtlasEntity dbOrTable) {
  return getHiveDDLEntity(dbOrTable, false);
}

protected AtlasEntity getHiveDDLEntity(AtlasEntity dbOrTable, boolean 
excludeEntityGuid) {
 AtlasObjectId objId = BaseHiveEvent.getObjectId(dbOrTable);

 if (excludeEntityGuid) {
   objId.setGuid(null);
 }

 final AtlasEntity hiveDDL;

 if (StringUtils.equals(objId.getTypeName(), HIVE_TYPE_DB)) {
   hiveDDL = new AtlasEntity(HIVE_DB_DDL, ATTRIBUTE_DB, objId);
 } else if (StringUtils.equals(objId.getTypeName(), HIVE_TYPE_TABLE))
   hiveDDL = new AtlasEntity(HIVE_TB_DDL, ATTRIBUTE_TABLE, objId);
 } else {
   hiveDDL = null;
 }

 if (hiveDDL != null) {
   ...
 }

With this change, the notification doesn't need to include 'dbOrTable' 
entity as a referred entity.



addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java
Lines 681 (patched)


handle 'hiveDDL == null' here.



addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java
Lines 684 (patched)


Consider setting ATTRIBUTE_QUALIFIED_NAME to same value as ATTRIBUTE_NAME 
below:

  hiveDDL.setAttribute(ATTRIBUTE_NAME, getQueryString() + QNAME_SEP_PROCESS 
+ getQueryStartTime().toString());
  hiveDDL.setAttribute(ATTRIBUTE_QUALIFIED_NAME, 
hiveDDL.getAttribute(ATTRIBUTE_NAME);



addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java
Lines 778 (patched)


getAttributeQualifiedName() method is not needed, per  suggested changes in 
#685.


- Madhan Neethiraj


On May 7, 2019, 6:35 p.m., Le Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70605/
> ---
> 
> (Updated May 7, 2019, 6:35 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan 
> Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3197
> https://issues.apache.org/jira/browse/ATLAS-3197
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch introduced a model called Hive_table_ddl and hive_db_ddl which are 
> used to track commands that are executed either on a table entity or bd 
> entity. DDL entities will be added to a table/db entity through 
> relationshipAttribute call HIVE_DB_TO_DDL and hive_tb_to_ddl. Every time when 
> a new command is executed, a new ddl entity will be created, it will append 
> to the existing DDLQueries field if a table/db has already been created. Once 
> a table/db is deleted, all these relationship attribute will be deleted as 
> well.
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRename.java
>  d3d83490f 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java
>  de8de63b6 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateDatabase.java
>  b01f61f76 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateTable.java
>  b5ce09332 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> 24de30f5a 
>   addons/models/1000-Hadoop/1030-hive_model.json ee6945a77 
> 
> 
> Diff: https://reviews.apache.org/r/70605/diff/3/
> 
> 
> Testing
> ---
> 
> 1. table : 
> 
> CREATE TABLE IF NOT EXISTS testDDL (d int, n string);
> 
> 
> ALTER TABLE testDDL

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

2019-05-07 Thread Le Ma



> On May 8, 2019, 12:40 a.m., Sarath Subramanian wrote:
> > DDL queries needs to be captured for the following events as well. Please 
> > review.
> > 
> > AlterDatabase
> > AlterTableRenameCol

Hello Sarath, thanks for reviewing it. AlterDatabase re-uses getHiveEntities() 
method in CreateDatabase and same for AlterTableRenameCol, it calls 
getNotificationMessages() form its super class which is inside createTable.And 
changes are already made for these two classes.

- Le


- Le


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70605/#review215111
---


On May 7, 2019, 6:35 p.m., Le Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70605/
> ---
> 
> (Updated May 7, 2019, 6:35 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan 
> Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3197
> https://issues.apache.org/jira/browse/ATLAS-3197
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch introduced a model called Hive_table_ddl and hive_db_ddl which are 
> used to track commands that are executed either on a table entity or bd 
> entity. DDL entities will be added to a table/db entity through 
> relationshipAttribute call HIVE_DB_TO_DDL and hive_tb_to_ddl. Every time when 
> a new command is executed, a new ddl entity will be created, it will append 
> to the existing DDLQueries field if a table/db has already been created. Once 
> a table/db is deleted, all these relationship attribute will be deleted as 
> well.
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRename.java
>  d3d83490f 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java
>  de8de63b6 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateDatabase.java
>  b01f61f76 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateTable.java
>  b5ce09332 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> 24de30f5a 
>   addons/models/1000-Hadoop/1030-hive_model.json ee6945a77 
> 
> 
> Diff: https://reviews.apache.org/r/70605/diff/3/
> 
> 
> Testing
> ---
> 
> 1. table : 
> 
> CREATE TABLE IF NOT EXISTS testDDL (d int, n string);
> 
> 
> ALTER TABLE testDDL RENAME TO renameTestDDL;
> 
> ALTER TABLE renameTestDDL CHANGE n changedCol string;
> 
> ALTER TABLE renameTestDDL ADD COLUMNS(addedCol int);
> 
> DROP TABLE renameTestDDL;
> 
> 
> 2. db 
> 
> create database testdb;
> 
> ALTER DATABASE database SET OWNER USER changedOwner;
> 
> DROP DATABSE testdb;
> 
> 
> File Attachments
> 
> 
> CREATE TABLE IF NOT EXISTS testDDL.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/5047d461-f288-4776-a843-556e45217fef__CREATE_TABLE_IF_NOT_EXISTS_testDDL.png
> ALTER TABLE testDDL RENAME TO renameTestDDL; .png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/373a656d-8ab3-4710-b9a1-3eac20adc947__ALTER_TABLE_testDDL_RENAME_TO_renameTestDDL_.png
> ALTER TABLE renameTestDDL CHANGE n changedCol string; - ddl.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/c9f57d67-c16b-4142-a6b4-9d372e7fd765__ALTER_TABLE_renameTestDDL_CHANGE_n_changedCol_string_-_ddl.png
> ALTER TABLE renameTestDDL CHANGE n changedCol string;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/42612eb6-83c2-4825-8601-5a1629c9de6f__ALTER_TABLE_renameTestDDL_CHANGE_n_changedCol_string.png
> ALTER TABLE renameTestDDL ADD COLUMNS(addedCol int);.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/f5d3522d-17b6-4227-8072-6fc07d88d515__ALTER_TABLE_renameTestDDL_ADD_COLUMNSaddedCol_int.png
> ALTER TABLE renameTestDDL ADD COLUMNS.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/73b9046a-2667-4049-9e11-c5c2b375e9ca__ALTER_TABLE_renameTestDDL_ADD_COLUMNS.png
> DROP TABLE renameTestDDL;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/ebfa01f2-e886-4f94-aa75-ff45bb519ca0__DROP_TABLE_renameTestDDL.png
> ddl - relationship.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/7b30282b-6419-4791-b107-f938918e1cfd__ddl_-_relationship.png
> ALTER DATABASE testdb SET OWNER USER changedOwner;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/388e7ffa-6691-4c2b-bcd9-d8755dc13e3e__ALTER_DATABASE_testdb_SET_OWNER_USER_changedOwner.png
> ALTER DATABASE testdb SET OWNER USER changedOwner; - db entity.png
>   
>

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

2019-05-07 Thread Sarath Subramanian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70605/#review215111
---



DDL queries needs to be captured for the following events as well. Please 
review.

AlterDatabase
AlterTableRenameCol


addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateTable.java
Lines 154 (patched)


why add tableDDLEntity at both entity and referredEntity? add only to 
entity.



addons/models/1000-Hadoop/1030-hive_model.json
Lines 536 (patched)


create a common supertype for "hive_db_ddl" and "hive_tb_ddl" => "hive_ddl" 
(with supertype - "Referenceable" and attributes queryText, timeStamp, and 
userName) and have "hive_db_ddl" and "hive_tb_ddl" use supertype "hive_ddl"

consider renaming hive_tb_ddl => hive_table_ddl



addons/models/1000-Hadoop/1030-hive_model.json
Lines 732 (patched)


hive_tb_to_ddl => hive_table_ddl_queries



addons/models/1000-Hadoop/1030-hive_model.json
Lines 751 (patched)


hive_db_to_ddl => hive_db_ddl_queries


- Sarath Subramanian


On May 7, 2019, 11:35 a.m., Le Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70605/
> ---
> 
> (Updated May 7, 2019, 11:35 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan 
> Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3197
> https://issues.apache.org/jira/browse/ATLAS-3197
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch introduced a model called Hive_table_ddl and hive_db_ddl which are 
> used to track commands that are executed either on a table entity or bd 
> entity. DDL entities will be added to a table/db entity through 
> relationshipAttribute call HIVE_DB_TO_DDL and hive_tb_to_ddl. Every time when 
> a new command is executed, a new ddl entity will be created, it will append 
> to the existing DDLQueries field if a table/db has already been created. Once 
> a table/db is deleted, all these relationship attribute will be deleted as 
> well.
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRename.java
>  d3d83490f 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java
>  de8de63b6 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateDatabase.java
>  b01f61f76 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateTable.java
>  b5ce09332 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> 24de30f5a 
>   addons/models/1000-Hadoop/1030-hive_model.json ee6945a77 
> 
> 
> Diff: https://reviews.apache.org/r/70605/diff/3/
> 
> 
> Testing
> ---
> 
> 1. table : 
> 
> CREATE TABLE IF NOT EXISTS testDDL (d int, n string);
> 
> 
> ALTER TABLE testDDL RENAME TO renameTestDDL;
> 
> ALTER TABLE renameTestDDL CHANGE n changedCol string;
> 
> ALTER TABLE renameTestDDL ADD COLUMNS(addedCol int);
> 
> DROP TABLE renameTestDDL;
> 
> 
> 2. db 
> 
> create database testdb;
> 
> ALTER DATABASE database SET OWNER USER changedOwner;
> 
> DROP DATABSE testdb;
> 
> 
> File Attachments
> 
> 
> CREATE TABLE IF NOT EXISTS testDDL.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/5047d461-f288-4776-a843-556e45217fef__CREATE_TABLE_IF_NOT_EXISTS_testDDL.png
> ALTER TABLE testDDL RENAME TO renameTestDDL; .png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/373a656d-8ab3-4710-b9a1-3eac20adc947__ALTER_TABLE_testDDL_RENAME_TO_renameTestDDL_.png
> ALTER TABLE renameTestDDL CHANGE n changedCol string; - ddl.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/c9f57d67-c16b-4142-a6b4-9d372e7fd765__ALTER_TABLE_renameTestDDL_CHANGE_n_changedCol_string_-_ddl.png
> ALTER TABLE renameTestDDL CHANGE n changedCol string;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/42612eb6-83c2-4825-8601-5a1629c9de6f__ALTER_TABLE_renameTestDDL_CHANGE_n_changedCol_string.png
> ALTER TABLE renameTestDDL ADD COLUMNS(addedCol int);.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/f5d3522d-17b6-4227-8072-6fc07d88d515__ALTER_TABLE_renameTestDDL_ADD_COLUMNSaddedCol_int.png
> ALTER TABLE renameTestDDL ADD COLUMNS.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/73b9046a-2667-4049-9e11-c5c2b375e9ca__ALTER_TABLE_renameTestDDL_ADD_COLUMNS.png
> DROP TABLE renameTestDDL;.png
>   
>

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

2019-05-07 Thread Sridhar K


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70605/#review215114
---




addons/models/1000-Hadoop/1030-hive_model.json
Lines 535 (patched)


Thanks for moving it to right file.


- Sridhar K


On May 7, 2019, 6:35 p.m., Le Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70605/
> ---
> 
> (Updated May 7, 2019, 6:35 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan 
> Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3197
> https://issues.apache.org/jira/browse/ATLAS-3197
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch introduced a model called Hive_table_ddl and hive_db_ddl which are 
> used to track commands that are executed either on a table entity or bd 
> entity. DDL entities will be added to a table/db entity through 
> relationshipAttribute call HIVE_DB_TO_DDL and hive_tb_to_ddl. Every time when 
> a new command is executed, a new ddl entity will be created, it will append 
> to the existing DDLQueries field if a table/db has already been created. Once 
> a table/db is deleted, all these relationship attribute will be deleted as 
> well.
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRename.java
>  d3d83490f 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java
>  de8de63b6 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateDatabase.java
>  b01f61f76 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateTable.java
>  b5ce09332 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> 24de30f5a 
>   addons/models/1000-Hadoop/1030-hive_model.json ee6945a77 
> 
> 
> Diff: https://reviews.apache.org/r/70605/diff/3/
> 
> 
> Testing
> ---
> 
> 1. table : 
> 
> CREATE TABLE IF NOT EXISTS testDDL (d int, n string);
> 
> 
> ALTER TABLE testDDL RENAME TO renameTestDDL;
> 
> ALTER TABLE renameTestDDL CHANGE n changedCol string;
> 
> ALTER TABLE renameTestDDL ADD COLUMNS(addedCol int);
> 
> DROP TABLE renameTestDDL;
> 
> 
> 2. db 
> 
> create database testdb;
> 
> ALTER DATABASE database SET OWNER USER changedOwner;
> 
> DROP DATABSE testdb;
> 
> 
> File Attachments
> 
> 
> CREATE TABLE IF NOT EXISTS testDDL.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/5047d461-f288-4776-a843-556e45217fef__CREATE_TABLE_IF_NOT_EXISTS_testDDL.png
> ALTER TABLE testDDL RENAME TO renameTestDDL; .png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/373a656d-8ab3-4710-b9a1-3eac20adc947__ALTER_TABLE_testDDL_RENAME_TO_renameTestDDL_.png
> ALTER TABLE renameTestDDL CHANGE n changedCol string; - ddl.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/c9f57d67-c16b-4142-a6b4-9d372e7fd765__ALTER_TABLE_renameTestDDL_CHANGE_n_changedCol_string_-_ddl.png
> ALTER TABLE renameTestDDL CHANGE n changedCol string;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/42612eb6-83c2-4825-8601-5a1629c9de6f__ALTER_TABLE_renameTestDDL_CHANGE_n_changedCol_string.png
> ALTER TABLE renameTestDDL ADD COLUMNS(addedCol int);.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/f5d3522d-17b6-4227-8072-6fc07d88d515__ALTER_TABLE_renameTestDDL_ADD_COLUMNSaddedCol_int.png
> ALTER TABLE renameTestDDL ADD COLUMNS.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/73b9046a-2667-4049-9e11-c5c2b375e9ca__ALTER_TABLE_renameTestDDL_ADD_COLUMNS.png
> DROP TABLE renameTestDDL;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/ebfa01f2-e886-4f94-aa75-ff45bb519ca0__DROP_TABLE_renameTestDDL.png
> ddl - relationship.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/7b30282b-6419-4791-b107-f938918e1cfd__ddl_-_relationship.png
> ALTER DATABASE testdb SET OWNER USER changedOwner;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/388e7ffa-6691-4c2b-bcd9-d8755dc13e3e__ALTER_DATABASE_testdb_SET_OWNER_USER_changedOwner.png
> ALTER DATABASE testdb SET OWNER USER changedOwner; - db entity.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/fd22b6a5-6cb9-40eb-aa10-5389f6f74792__ALTER_DATABASE_testdb_SET_OWNER_USER_changedOwner_-_db_entity.png
> drop database testdb;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/7c889d62-66c8-4c26-bf94-257bd01cdb70__drop_database_testdb.png
> drop database testdb;.png
>   
>

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

2019-05-07 Thread Sridhar K


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70605/#review215113
---




addons/models/1000-Hadoop/1030-hive_model.json
Lines 586 (patched)


Too generic name. Can we get a btter name here. I suggest execTime. Or is 
it one of those name consistency issue?


- Sridhar K


On May 7, 2019, 6:35 p.m., Le Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70605/
> ---
> 
> (Updated May 7, 2019, 6:35 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan 
> Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3197
> https://issues.apache.org/jira/browse/ATLAS-3197
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch introduced a model called Hive_table_ddl and hive_db_ddl which are 
> used to track commands that are executed either on a table entity or bd 
> entity. DDL entities will be added to a table/db entity through 
> relationshipAttribute call HIVE_DB_TO_DDL and hive_tb_to_ddl. Every time when 
> a new command is executed, a new ddl entity will be created, it will append 
> to the existing DDLQueries field if a table/db has already been created. Once 
> a table/db is deleted, all these relationship attribute will be deleted as 
> well.
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRename.java
>  d3d83490f 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java
>  de8de63b6 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateDatabase.java
>  b01f61f76 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateTable.java
>  b5ce09332 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> 24de30f5a 
>   addons/models/1000-Hadoop/1030-hive_model.json ee6945a77 
> 
> 
> Diff: https://reviews.apache.org/r/70605/diff/3/
> 
> 
> Testing
> ---
> 
> 1. table : 
> 
> CREATE TABLE IF NOT EXISTS testDDL (d int, n string);
> 
> 
> ALTER TABLE testDDL RENAME TO renameTestDDL;
> 
> ALTER TABLE renameTestDDL CHANGE n changedCol string;
> 
> ALTER TABLE renameTestDDL ADD COLUMNS(addedCol int);
> 
> DROP TABLE renameTestDDL;
> 
> 
> 2. db 
> 
> create database testdb;
> 
> ALTER DATABASE database SET OWNER USER changedOwner;
> 
> DROP DATABSE testdb;
> 
> 
> File Attachments
> 
> 
> CREATE TABLE IF NOT EXISTS testDDL.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/5047d461-f288-4776-a843-556e45217fef__CREATE_TABLE_IF_NOT_EXISTS_testDDL.png
> ALTER TABLE testDDL RENAME TO renameTestDDL; .png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/373a656d-8ab3-4710-b9a1-3eac20adc947__ALTER_TABLE_testDDL_RENAME_TO_renameTestDDL_.png
> ALTER TABLE renameTestDDL CHANGE n changedCol string; - ddl.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/c9f57d67-c16b-4142-a6b4-9d372e7fd765__ALTER_TABLE_renameTestDDL_CHANGE_n_changedCol_string_-_ddl.png
> ALTER TABLE renameTestDDL CHANGE n changedCol string;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/42612eb6-83c2-4825-8601-5a1629c9de6f__ALTER_TABLE_renameTestDDL_CHANGE_n_changedCol_string.png
> ALTER TABLE renameTestDDL ADD COLUMNS(addedCol int);.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/f5d3522d-17b6-4227-8072-6fc07d88d515__ALTER_TABLE_renameTestDDL_ADD_COLUMNSaddedCol_int.png
> ALTER TABLE renameTestDDL ADD COLUMNS.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/73b9046a-2667-4049-9e11-c5c2b375e9ca__ALTER_TABLE_renameTestDDL_ADD_COLUMNS.png
> DROP TABLE renameTestDDL;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/ebfa01f2-e886-4f94-aa75-ff45bb519ca0__DROP_TABLE_renameTestDDL.png
> ddl - relationship.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/7b30282b-6419-4791-b107-f938918e1cfd__ddl_-_relationship.png
> ALTER DATABASE testdb SET OWNER USER changedOwner;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/388e7ffa-6691-4c2b-bcd9-d8755dc13e3e__ALTER_DATABASE_testdb_SET_OWNER_USER_changedOwner.png
> ALTER DATABASE testdb SET OWNER USER changedOwner; - db entity.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/fd22b6a5-6cb9-40eb-aa10-5389f6f74792__ALTER_DATABASE_testdb_SET_OWNER_USER_changedOwner_-_db_entity.png
> drop database testdb;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/7c889d62-66c8-4c26-bf94-257bd01cdb70__drop_database_testdb.png
> drop database testdb;.png
>   
>

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

2019-05-07 Thread Sridhar K


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70605/#review215107
---




addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java
Lines 669 (patched)


Can we call it createHiveDDLEntity() instead? We are creating an object 
here? :-)



addons/models/-Area0/0010-base_model.json
Lines 388 (patched)


Can we give more meaningful name?



addons/models/-Area0/0010-base_model.json
Lines 471 (patched)


Your model is right from semantics of our ddl entitites. You are modeling 
this as composition. I am a bit concerned with this idea. Do we know how 
atlas/janus would treat the semantic violations? I am looking at already 
created databases/tables. We don't have ddls linked for them? So, will Janus be 
alright with data inconsistency like this.

Something to watch out for.

The scenario I am talking about is "upgrade scenario".


- Sridhar K


On May 7, 2019, 6:35 p.m., Le Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70605/
> ---
> 
> (Updated May 7, 2019, 6:35 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan 
> Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3197
> https://issues.apache.org/jira/browse/ATLAS-3197
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch introduced a model called Hive_table_ddl and hive_db_ddl which are 
> used to track commands that are executed either on a table entity or bd 
> entity. DDL entities will be added to a table/db entity through 
> relationshipAttribute call HIVE_DB_TO_DDL and hive_tb_to_ddl. Every time when 
> a new command is executed, a new ddl entity will be created, it will append 
> to the existing DDLQueries field if a table/db has already been created. Once 
> a table/db is deleted, all these relationship attribute will be deleted as 
> well.
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRename.java
>  d3d83490f 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java
>  de8de63b6 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateDatabase.java
>  b01f61f76 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateTable.java
>  b5ce09332 
>   addons/models/-Area0/0010-base_model.json d14b2270e 
> 
> 
> Diff: https://reviews.apache.org/r/70605/diff/1/
> 
> 
> Testing
> ---
> 
> 1. table : 
> 
> CREATE TABLE IF NOT EXISTS testDDL (d int, n string);
> 
> 
> ALTER TABLE testDDL RENAME TO renameTestDDL;
> 
> ALTER TABLE renameTestDDL CHANGE n changedCol string;
> 
> ALTER TABLE renameTestDDL ADD COLUMNS(addedCol int);
> 
> DROP TABLE renameTestDDL;
> 
> 
> 2. db 
> 
> create database testdb;
> 
> ALTER DATABASE database SET OWNER USER changedOwner;
> 
> DROP DATABSE testdb;
> 
> 
> File Attachments
> 
> 
> CREATE TABLE IF NOT EXISTS testDDL.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/5047d461-f288-4776-a843-556e45217fef__CREATE_TABLE_IF_NOT_EXISTS_testDDL.png
> ALTER TABLE testDDL RENAME TO renameTestDDL; .png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/373a656d-8ab3-4710-b9a1-3eac20adc947__ALTER_TABLE_testDDL_RENAME_TO_renameTestDDL_.png
> ALTER TABLE renameTestDDL CHANGE n changedCol string; - ddl.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/c9f57d67-c16b-4142-a6b4-9d372e7fd765__ALTER_TABLE_renameTestDDL_CHANGE_n_changedCol_string_-_ddl.png
> ALTER TABLE renameTestDDL CHANGE n changedCol string;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/42612eb6-83c2-4825-8601-5a1629c9de6f__ALTER_TABLE_renameTestDDL_CHANGE_n_changedCol_string.png
> ALTER TABLE renameTestDDL ADD COLUMNS(addedCol int);.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/f5d3522d-17b6-4227-8072-6fc07d88d515__ALTER_TABLE_renameTestDDL_ADD_COLUMNSaddedCol_int.png
> ALTER TABLE renameTestDDL ADD COLUMNS.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/73b9046a-2667-4049-9e11-c5c2b375e9ca__ALTER_TABLE_renameTestDDL_ADD_COLUMNS.png
> DROP TABLE renameTestDDL;.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/ebfa01f2-e886-4f94-aa75-ff45bb519ca0__DROP_TABLE_renameTestDDL.png
> ddl - relationship.png
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/7b30282b-6419-4791-b107-f938918e1cfd__ddl_-_relationship.png
> ALTER DATABASE testdb SET

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

17 matches

Site Navigation

Mail list logo

Footer information