Re: Review Request 73151: ATLAS-4107 :- Atlas not picking the ldap bind password from the correct jceks file.

2021-01-28 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73151/#review222538
---


Ship it!




Ship It!

- Sarath Subramanian


On Jan. 28, 2021, 7:11 a.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73151/
> ---
> 
> (Updated Jan. 28, 2021, 7:11 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> Nikhil Bonte, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4107
> https://issues.apache.org/jira/browse/ATLAS-4107
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Atlas not picking the ldap bind password from the correct jceks file.
> 
> There are two jceks file in Atlas configured from CM, ldap bind password 
> should be retrieved from hadoop.security.credential.provider.path instead 
> cert.stores.credential.provider.path.
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/ApplicationProperties.java e662c8fae 
>   intg/src/main/java/org/apache/atlas/security/SecurityProperties.java 
> 2147cd17c 
>   intg/src/main/java/org/apache/atlas/security/SecurityUtil.java 082c6378c 
> 
> 
> Diff: https://reviews.apache.org/r/73151/diff/2/
> 
> 
> Testing
> ---
> 
> Tested on normal cluster with password stored in jceks file and TLS cluster 
> with password stored in jceks file in Atlas.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

Re: Review Request 73151: ATLAS-4107 :- Atlas not picking the ldap bind password from the correct jceks file.

2021-01-28 Thread Nixon Rodrigues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73151/
---

(Updated Jan. 28, 2021, 3:11 p.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
Nikhil Bonte, and Sarath Subramanian.


Changes
---

Addressed Review comments from Sarath


Bugs: ATLAS-4107
https://issues.apache.org/jira/browse/ATLAS-4107


Repository: atlas


Description
---

Atlas not picking the ldap bind password from the correct jceks file.

There are two jceks file in Atlas configured from CM, ldap bind password should 
be retrieved from hadoop.security.credential.provider.path instead 
cert.stores.credential.provider.path.


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/ApplicationProperties.java e662c8fae 
  intg/src/main/java/org/apache/atlas/security/SecurityProperties.java 
2147cd17c 
  intg/src/main/java/org/apache/atlas/security/SecurityUtil.java 082c6378c 


Diff: https://reviews.apache.org/r/73151/diff/2/

Changes: https://reviews.apache.org/r/73151/diff/1-2/


Testing
---

Tested on normal cluster with password stored in jceks file and TLS cluster 
with password stored in jceks file in Atlas.


Thanks,

Nixon Rodrigues

Re: Review Request 73151: ATLAS-4107 :- Atlas not picking the ldap bind password from the correct jceks file.

2021-01-27 Thread Ashutosh Mestry via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73151/#review222532
---




intg/src/main/java/org/apache/atlas/ApplicationProperties.java
Line 281 (original), 283 (patched)


Extract to private static final String.



intg/src/main/java/org/apache/atlas/ApplicationProperties.java
Line 288 (original), 290 (patched)


Can you create static private constants for the 2 strings.



notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java
Line 126 (original), 127 (patched)


Extract to private static final String


- Ashutosh Mestry


On Jan. 21, 2021, 3:58 p.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73151/
> ---
> 
> (Updated Jan. 21, 2021, 3:58 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> Nikhil Bonte, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4107
> https://issues.apache.org/jira/browse/ATLAS-4107
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Atlas not picking the ldap bind password from the correct jceks file.
> 
> There are two jceks file in Atlas configured from CM, ldap bind password 
> should be retrieved from hadoop.security.credential.provider.path instead 
> cert.stores.credential.provider.path.
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/ApplicationProperties.java e662c8fae 
>   intg/src/main/java/org/apache/atlas/security/SecurityProperties.java 
> 2147cd17c 
>   intg/src/main/java/org/apache/atlas/security/SecurityUtil.java 082c6378c 
>   notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 
> 3d1b3ccf1 
>   webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java 
> 7a045749f 
> 
> 
> Diff: https://reviews.apache.org/r/73151/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on normal cluster with password stored in jceks file and TLS cluster 
> with password stored in jceks file in Atlas.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

Re: Review Request 73151: ATLAS-4107 :- Atlas not picking the ldap bind password from the correct jceks file.

2021-01-26 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73151/#review222534
---


Ship it!




Ship It!

- Sarath Subramanian


On Jan. 21, 2021, 7:58 a.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73151/
> ---
> 
> (Updated Jan. 21, 2021, 7:58 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> Nikhil Bonte, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4107
> https://issues.apache.org/jira/browse/ATLAS-4107
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Atlas not picking the ldap bind password from the correct jceks file.
> 
> There are two jceks file in Atlas configured from CM, ldap bind password 
> should be retrieved from hadoop.security.credential.provider.path instead 
> cert.stores.credential.provider.path.
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/ApplicationProperties.java e662c8fae 
>   intg/src/main/java/org/apache/atlas/security/SecurityProperties.java 
> 2147cd17c 
>   intg/src/main/java/org/apache/atlas/security/SecurityUtil.java 082c6378c 
>   notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 
> 3d1b3ccf1 
>   webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java 
> 7a045749f 
> 
> 
> Diff: https://reviews.apache.org/r/73151/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on normal cluster with password stored in jceks file and TLS cluster 
> with password stored in jceks file in Atlas.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

Re: Review Request 73151: ATLAS-4107 :- Atlas not picking the ldap bind password from the correct jceks file.

2021-01-26 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73151/#review222533
---




intg/src/main/java/org/apache/atlas/security/SecurityUtil.java
Line 42 (original), 43 (patched)


consider retaining existing getPassword() method which internally calls the 
new method. If providerPath not specified will fetch creds from cred_store path.

something like:

public static String 
getPassword(org.apache.commons.configuration.Configuration config, String key) 
throws IOException { 
   return getPassword(org.apache.commons.configuration.Configuration 
config, String key , CERT_STORES_CREDENTIAL_PROVIDER_PATH)
}

This will avoid changes to existing usage of this method (which needs 
credstore provider path).

For fetching LDAP creds, you can pass the hadoop provider path explicitly.


- Sarath Subramanian


On Jan. 21, 2021, 7:58 a.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73151/
> ---
> 
> (Updated Jan. 21, 2021, 7:58 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> Nikhil Bonte, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4107
> https://issues.apache.org/jira/browse/ATLAS-4107
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Atlas not picking the ldap bind password from the correct jceks file.
> 
> There are two jceks file in Atlas configured from CM, ldap bind password 
> should be retrieved from hadoop.security.credential.provider.path instead 
> cert.stores.credential.provider.path.
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/ApplicationProperties.java e662c8fae 
>   intg/src/main/java/org/apache/atlas/security/SecurityProperties.java 
> 2147cd17c 
>   intg/src/main/java/org/apache/atlas/security/SecurityUtil.java 082c6378c 
>   notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 
> 3d1b3ccf1 
>   webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java 
> 7a045749f 
> 
> 
> Diff: https://reviews.apache.org/r/73151/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on normal cluster with password stored in jceks file and TLS cluster 
> with password stored in jceks file in Atlas.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>