Re: Review Request 73388: ATLAS-4174 : [Atlas: Glossary Term Bulk Import] When the file size is large (5 mb) bulk import times out

2021-05-27 Thread Prasad Pawar


> On May 27, 2021, 3:03 p.m., Ashutosh Mestry wrote:
> > Does 'timeout' of 0 indicate that no timeout is specified?

yes, timeout 0 means no timeout


- Prasad


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73388/#review223066
---


On May 27, 2021, 7:06 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73388/
> ---
> 
> (Updated May 27, 2021, 7:06 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4174
> https://issues.apache.org/jira/browse/ATLAS-4174
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch has set timeout to 0 or we can say disabled the timeout which will 
> no longer throw the exception for request timeout
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/views/import/ImportLayoutView.js 8f7524e34 
>   dashboardv3/public/js/views/import/ImportLayoutView.js 8f7524e34 
> 
> 
> Diff: https://reviews.apache.org/r/73388/diff/1/
> 
> 
> Testing
> ---
> 
> Atlas server runs successfully
> mvn clean package -Pdist,embedded-hbase-solr -DskipTests -Drat.skip
> mvn clean install
> Checked with file 50 kb to 100kb no timeout error was seen.
> 
> 
> Thanks,
> 
> chaitali
> 
>



Re: Review Request 73388: ATLAS-4174 : [Atlas: Glossary Term Bulk Import] When the file size is large (5 mb) bulk import times out

2021-05-27 Thread Ashutosh Mestry via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73388/#review223066
---



Does 'timeout' of 0 indicate that no timeout is specified?

- Ashutosh Mestry


On May 27, 2021, 7:06 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73388/
> ---
> 
> (Updated May 27, 2021, 7:06 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4174
> https://issues.apache.org/jira/browse/ATLAS-4174
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch has set timeout to 0 or we can say disabled the timeout which will 
> no longer throw the exception for request timeout
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/views/import/ImportLayoutView.js 8f7524e34 
>   dashboardv3/public/js/views/import/ImportLayoutView.js 8f7524e34 
> 
> 
> Diff: https://reviews.apache.org/r/73388/diff/1/
> 
> 
> Testing
> ---
> 
> Atlas server runs successfully
> mvn clean package -Pdist,embedded-hbase-solr -DskipTests -Drat.skip
> mvn clean install
> Checked with file 50 kb to 100kb no timeout error was seen.
> 
> 
> Thanks,
> 
> chaitali
> 
>



Re: Review Request 73388: ATLAS-4174 : [Atlas: Glossary Term Bulk Import] When the file size is large (5 mb) bulk import times out

2021-05-27 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73388/#review223063
---


Ship it!




Ship It!

- Nixon Rodrigues


On May 27, 2021, 7:06 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73388/
> ---
> 
> (Updated May 27, 2021, 7:06 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4174
> https://issues.apache.org/jira/browse/ATLAS-4174
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch has set timeout to 0 or we can say disabled the timeout which will 
> no longer throw the exception for request timeout
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/views/import/ImportLayoutView.js 8f7524e34 
>   dashboardv3/public/js/views/import/ImportLayoutView.js 8f7524e34 
> 
> 
> Diff: https://reviews.apache.org/r/73388/diff/1/
> 
> 
> Testing
> ---
> 
> Atlas server runs successfully
> mvn clean package -Pdist,embedded-hbase-solr -DskipTests -Drat.skip
> mvn clean install
> Checked with file 50 kb to 100kb no timeout error was seen.
> 
> 
> Thanks,
> 
> chaitali
> 
>



Re: Review Request 73388: ATLAS-4174 : [Atlas: Glossary Term Bulk Import] When the file size is large (5 mb) bulk import times out

2021-05-27 Thread Prasad Pawar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73388/#review223062
---


Ship it!




Ship It!

- Prasad Pawar


On May 27, 2021, 7:06 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73388/
> ---
> 
> (Updated May 27, 2021, 7:06 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4174
> https://issues.apache.org/jira/browse/ATLAS-4174
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch has set timeout to 0 or we can say disabled the timeout which will 
> no longer throw the exception for request timeout
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/views/import/ImportLayoutView.js 8f7524e34 
>   dashboardv3/public/js/views/import/ImportLayoutView.js 8f7524e34 
> 
> 
> Diff: https://reviews.apache.org/r/73388/diff/1/
> 
> 
> Testing
> ---
> 
> Atlas server runs successfully
> mvn clean package -Pdist,embedded-hbase-solr -DskipTests -Drat.skip
> mvn clean install
> Checked with file 50 kb to 100kb no timeout error was seen.
> 
> 
> Thanks,
> 
> chaitali
> 
>