Re: Review Request 62560: ATLAS-2130 : Call made to fetch tables of a database doesn't have exlcudeDeletedEntities parameter

2017-09-26 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62560/#review186243
---


Ship it!




Ship It!

- Nixon Rodrigues


On Sept. 26, 2017, 7:15 a.m., keval bhatt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62560/
> ---
> 
> (Updated Sept. 26, 2017, 7:15 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, 
> and Sharmadha Sainath.
> 
> 
> Bugs: ATLAS-2130
> https://issues.apache.org/jira/browse/ATLAS-2130
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Following is the query fired to fetch the tables in a db :
> 
> ```
> http://localhost:21000/api/atlas/v2/search/relationship?limit=25=8b110b04-b5ad-4738-b7f7-576cc85b2fd4=__hive_table.db=name=ASCENDING&_=1505280717115
> ```
> 
> Since exlcudeDeletedEntities=true is not set in the param , deleted tables 
> are also shown in the Tables tab of a hive_database's detailPage.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/router/Router.js 64eb3f3 
>   dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 480e9e3 
>   dashboardv2/public/js/views/profile/ProfileLayoutView.js 6b640d9 
>   dashboardv2/public/js/views/search/SearchResultLayoutView.js f20dc6e 
> 
> 
> Diff: https://reviews.apache.org/r/62560/diff/1/
> 
> 
> Testing
> ---
> 
> Tested DB tables tab its working as expected
> 
> 
> Thanks,
> 
> keval bhatt
> 
>



Review Request 62560: ATLAS-2130 : Call made to fetch tables of a database doesn't have exlcudeDeletedEntities parameter

2017-09-26 Thread keval bhatt

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62560/
---

Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, 
and Sharmadha Sainath.


Bugs: ATLAS-2130
https://issues.apache.org/jira/browse/ATLAS-2130


Repository: atlas


Description
---

Following is the query fired to fetch the tables in a db :

```
http://localhost:21000/api/atlas/v2/search/relationship?limit=25=8b110b04-b5ad-4738-b7f7-576cc85b2fd4=__hive_table.db=name=ASCENDING&_=1505280717115
```

Since exlcudeDeletedEntities=true is not set in the param , deleted tables are 
also shown in the Tables tab of a hive_database's detailPage.


Diffs
-

  dashboardv2/public/js/router/Router.js 64eb3f3 
  dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 480e9e3 
  dashboardv2/public/js/views/profile/ProfileLayoutView.js 6b640d9 
  dashboardv2/public/js/views/search/SearchResultLayoutView.js f20dc6e 


Diff: https://reviews.apache.org/r/62560/diff/1/


Testing
---

Tested DB tables tab its working as expected


Thanks,

keval bhatt