Re: Review Request 62568: ATLAS-2174:- Code Improvement & Validations

2017-09-26 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62568/#review186273
---




client/src/main/java/org/apache/atlas/AtlasBaseClient.java
Line 272 (original), 273 (patched)


It will be useful to add getNormalizedPath() to APIInfo class and call it 
from here.



repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
Lines 142 (patched)


Consider moving these length checks to REST layer.


- Madhan Neethiraj


On Sept. 26, 2017, 12:01 p.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62568/
> ---
> 
> (Updated Sept. 26, 2017, 12:01 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, keval bhatt, Madhan 
> Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2174
> https://issues.apache.org/jira/browse/ATLAS-2174
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch includes changes to
> 
> Add validation for query length.
> Add normalized api path.
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/atlas/AtlasBaseClient.java 602831a 
>   common/src/main/java/org/apache/atlas/repository/Constants.java d5283c1 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java d205faf 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  40c66dd 
> 
> 
> Diff: https://reviews.apache.org/r/62568/diff/1/
> 
> 
> Testing
> ---
> 
> Testing cases working.
> Run Quick Start script and loaded sample data, UI is loading fine.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

Re: Review Request 62568: ATLAS-2174:- Code Improvement & Validations

2017-09-26 Thread Apoorv Naik 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62568/#review186270
---


Ship it!




Ship It!

- Apoorv Naik


On Sept. 26, 2017, 12:01 p.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62568/
> ---
> 
> (Updated Sept. 26, 2017, 12:01 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, keval bhatt, Madhan 
> Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2174
> https://issues.apache.org/jira/browse/ATLAS-2174
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch includes changes to
> 
> Add validation for query length.
> Add normalized api path.
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/atlas/AtlasBaseClient.java 602831a 
>   common/src/main/java/org/apache/atlas/repository/Constants.java d5283c1 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java d205faf 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  40c66dd 
> 
> 
> Diff: https://reviews.apache.org/r/62568/diff/1/
> 
> 
> Testing
> ---
> 
> Testing cases working.
> Run Quick Start script and loaded sample data, UI is loading fine.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

Re: Review Request 62568: ATLAS-2174:- Code Improvement & Validations

2017-09-26 Thread Nixon Rodrigues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62568/
---

(Updated Sept. 26, 2017, 12:01 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, keval bhatt, Madhan 
Neethiraj, and Sarath Subramanian.


Bugs: ATLAS-2174
https://issues.apache.org/jira/browse/ATLAS-2174


Repository: atlas


Description
---

This patch includes changes to

Add validation for query length.
Add normalized api path.


Diffs
-

  client/src/main/java/org/apache/atlas/AtlasBaseClient.java 602831a 
  common/src/main/java/org/apache/atlas/repository/Constants.java d5283c1 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java d205faf 
  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
40c66dd 


Diff: https://reviews.apache.org/r/62568/diff/1/


Testing
---

Testing cases working.
Run Quick Start script and loaded sample data, UI is loading fine.


Thanks,

Nixon Rodrigues

Review Request 62568: ATLAS-2174:- Code Improvement & Validations

2017-09-26 Thread Nixon Rodrigues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62568/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, keval bhatt, Madhan 
Neethiraj, and Sarath Subramanian.


Repository: atlas


Description
---

This patch includes changes to

Add validation for query length.
Add normalized api path.


Diffs
-

  client/src/main/java/org/apache/atlas/AtlasBaseClient.java 602831a 
  common/src/main/java/org/apache/atlas/repository/Constants.java d5283c1 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java d205faf 
  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
40c66dd 


Diff: https://reviews.apache.org/r/62568/diff/1/


Testing
---

Testing cases working.
Run Quick Start script and loaded sample data, UI is loading fine.


Thanks,

Nixon Rodrigues