Re: Review Request 65678: ATLAS-2444: Fix for appending cluster name only for HDFS paths

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65678/#review197653
---


Ship it!




Ship It!

- Madhan Neethiraj


On Feb. 16, 2018, 12:10 a.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65678/
> ---
> 
> (Updated Feb. 16, 2018, 12:10 a.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2444
> https://issues.apache.org/jira/browse/ATLAS-2444
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Update the HiveMetastoreBridge code and some test logic. 
> 
> HiveHookIT runs successfully after this patch
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
>  3a775b60e 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/HiveITBase.java 
> 01418cf30 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> 1b1ebec27 
>   common/src/main/java/org/apache/atlas/utils/HdfsNameServiceResolver.java 
> 60e192597 
> 
> 
> Diff: https://reviews.apache.org/r/65678/diff/2/
> 
> 
> Testing
> ---
> 
> mvn verify -pl addons/hive-bridge -am -Dit.test=HiveHookIT was successful
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 65678: ATLAS-2444: Fix for appending cluster name only for HDFS paths

[Apoorv Naik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65678/
---

(Updated Feb. 16, 2018, 12:10 a.m.)


Review request for atlas and Madhan Neethiraj.


Changes
---

Addressed review comments


Bugs: ATLAS-2444
https://issues.apache.org/jira/browse/ATLAS-2444


Repository: atlas


Description
---

Update the HiveMetastoreBridge code and some test logic. 

HiveHookIT runs successfully after this patch


Diffs (updated)
-

  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
 3a775b60e 
  addons/hive-bridge/src/test/java/org/apache/atlas/hive/HiveITBase.java 
01418cf30 
  addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
1b1ebec27 
  common/src/main/java/org/apache/atlas/utils/HdfsNameServiceResolver.java 
60e192597 


Diff: https://reviews.apache.org/r/65678/diff/2/

Changes: https://reviews.apache.org/r/65678/diff/1-2/


Testing
---

mvn verify -pl addons/hive-bridge -am -Dit.test=HiveHookIT was successful


Thanks,

Apoorv Naik

Re: Review Request 65678: ATLAS-2444: Fix for appending cluster name only for HDFS paths

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65678/#review197647
---


Fix it, then Ship it!





addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
Lines 211 (patched)


Consider updating hdfsNameServiceResolver.getPathWithNameServiceID() to 
handle null parameter value.


- Madhan Neethiraj


On Feb. 15, 2018, 10:40 p.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65678/
> ---
> 
> (Updated Feb. 15, 2018, 10:40 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2444
> https://issues.apache.org/jira/browse/ATLAS-2444
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Update the HiveMetastoreBridge code and some test logic. 
> 
> HiveHookIT runs successfully after this patch
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
>  3a775b60e 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/HiveITBase.java 
> 01418cf30 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> 1b1ebec27 
>   common/src/main/java/org/apache/atlas/utils/HdfsNameServiceResolver.java 
> 60e192597 
> 
> 
> Diff: https://reviews.apache.org/r/65678/diff/1/
> 
> 
> Testing
> ---
> 
> mvn verify -pl addons/hive-bridge -am -Dit.test=HiveHookIT was successful
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Review Request 65678: ATLAS-2444: Fix for appending cluster name only for HDFS paths

[Apoorv Naik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65678/
---

Review request for atlas and Madhan Neethiraj.


Bugs: ATLAS-2444
https://issues.apache.org/jira/browse/ATLAS-2444


Repository: atlas


Description
---

Update the HiveMetastoreBridge code and some test logic. 

HiveHookIT runs successfully after this patch


Diffs
-

  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
 3a775b60e 
  addons/hive-bridge/src/test/java/org/apache/atlas/hive/HiveITBase.java 
01418cf30 
  addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
1b1ebec27 
  common/src/main/java/org/apache/atlas/utils/HdfsNameServiceResolver.java 
60e192597 


Diff: https://reviews.apache.org/r/65678/diff/1/


Testing
---

mvn verify -pl addons/hive-bridge -am -Dit.test=HiveHookIT was successful


Thanks,

Apoorv Naik