Re: Review Request 66501: ATLAS-2531 : Lineage display is causing "Maximum call stack size reached" in underscore.js

2018-04-09 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66501/#review200723
---


Ship it!




Ship It!

- Nixon Rodrigues


On April 9, 2018, 8:11 a.m., keval bhatt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66501/
> ---
> 
> (Updated April 9, 2018, 8:11 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, 
> Nixon Rodrigues, pratik pandey, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2531
> https://issues.apache.org/jira/browse/ATLAS-2531
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> getting this console error when I to display a Dataset entity with lineage:
> 
> ```
> Uncaught RangeError: Maximum call stack size exceeded
>  at underscore-min.js?bust=1519685834833:1
>  at underscore-min.js?bust=1519685834833:1
>  at Function.s.each.s.forEach (underscore-min.js?bust=1519685834833:1)
>  at Function.s.filter.s.select (underscore-min.js?bust=1519685834833:1)
>  at Function.s.where (underscore-min.js?bust=1519685834833:1)
>  at N.d.checkForLineageOrImpactFlag 
> (LineageLayoutView.js?bust=1519685834833:80)
>  at LineageLayoutView.js?bust=1519685834833:94
>  at Function.s.each.s.forEach (underscore-min.js?bust=1519685834833:1)
>  at N.d.checkForLineageOrImpactFlag 
> (LineageLayoutView.js?bust=1519685834833:83)
>  at LineageLayoutView.js?bust=1519685834833:94
> ```
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/views/graph/LineageLayoutView.js f17de839 
> 
> 
> Diff: https://reviews.apache.org/r/66501/diff/1/
> 
> 
> Testing
> ---
> 
> Done one round of testing with cyclic data
> 
> 
> Thanks,
> 
> keval bhatt
> 
>



Review Request 66501: ATLAS-2531 : Lineage display is causing "Maximum call stack size reached" in underscore.js

2018-04-09 Thread keval bhatt

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66501/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Nixon 
Rodrigues, pratik pandey, and Sarath Subramanian.


Bugs: ATLAS-2531
https://issues.apache.org/jira/browse/ATLAS-2531


Repository: atlas


Description
---

getting this console error when I to display a Dataset entity with lineage:

```
Uncaught RangeError: Maximum call stack size exceeded
 at underscore-min.js?bust=1519685834833:1
 at underscore-min.js?bust=1519685834833:1
 at Function.s.each.s.forEach (underscore-min.js?bust=1519685834833:1)
 at Function.s.filter.s.select (underscore-min.js?bust=1519685834833:1)
 at Function.s.where (underscore-min.js?bust=1519685834833:1)
 at N.d.checkForLineageOrImpactFlag (LineageLayoutView.js?bust=1519685834833:80)
 at LineageLayoutView.js?bust=1519685834833:94
 at Function.s.each.s.forEach (underscore-min.js?bust=1519685834833:1)
 at N.d.checkForLineageOrImpactFlag (LineageLayoutView.js?bust=1519685834833:83)
 at LineageLayoutView.js?bust=1519685834833:94
```


Diffs
-

  dashboardv2/public/js/views/graph/LineageLayoutView.js f17de839 


Diff: https://reviews.apache.org/r/66501/diff/1/


Testing
---

Done one round of testing with cyclic data


Thanks,

keval bhatt