Re: Review Request 68188: ATLAS-2808: Enable Atlas to support entity proxies

2018-08-17 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68188/#review207499
---


Ship it!




Ship It!

- Madhan Neethiraj


On Aug. 17, 2018, 12:03 p.m., Graham Wallis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68188/
> ---
> 
> (Updated Aug. 17, 2018, 12:03 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS_2808: Support for entity proxies
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java a892551f7 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> dc2be412b 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> 9c4b9f232 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  2153a5a9e 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
>  52c374564 
> 
> 
> Diff: https://reviews.apache.org/r/68188/diff/3/
> 
> 
> Testing
> ---
> 
> Tested with saveRelationshipReferenceCopy between entities that do not exist 
> in the Atlas repository.
> 
> 
> Thanks,
> 
> Graham Wallis
> 
>

Re: Review Request 68188: ATLAS-2808: Enable Atlas to support entity proxies

2018-08-17 Thread David Radley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68188/#review207487
---


Ship it!




Ship It!

- David Radley


On Aug. 17, 2018, 12:03 p.m., Graham Wallis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68188/
> ---
> 
> (Updated Aug. 17, 2018, 12:03 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS_2808: Support for entity proxies
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java a892551f7 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> dc2be412b 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> 9c4b9f232 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  2153a5a9e 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
>  52c374564 
> 
> 
> Diff: https://reviews.apache.org/r/68188/diff/3/
> 
> 
> Testing
> ---
> 
> Tested with saveRelationshipReferenceCopy between entities that do not exist 
> in the Atlas repository.
> 
> 
> Thanks,
> 
> Graham Wallis
> 
>

Re: Review Request 68188: ATLAS-2808: Enable Atlas to support entity proxies

2018-08-17 Thread Graham Wallis 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68188/
---

(Updated Aug. 17, 2018, 12:03 p.m.)


Review request for atlas.


Changes
---

Fixed typo in comment and rationalised use of Boolean


Repository: atlas


Description
---

ATLAS_2808: Support for entity proxies


Diffs (updated)
-

  common/src/main/java/org/apache/atlas/repository/Constants.java a892551f7 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java dc2be412b 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
9c4b9f232 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 2153a5a9e 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
 52c374564 


Diff: https://reviews.apache.org/r/68188/diff/3/

Changes: https://reviews.apache.org/r/68188/diff/2-3/


Testing
---

Tested with saveRelationshipReferenceCopy between entities that do not exist in 
the Atlas repository.


Thanks,

Graham Wallis

Re: Review Request 68188: ATLAS-2808: Enable Atlas to support entity proxies

2018-08-16 Thread Graham Wallis 


> On Aug. 9, 2018, 10:51 a.m., David Radley wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
> > Lines 174 (patched)
> > 
> >
> > I am wondering what your thoughts are on validation in Atlas. 
> > Specifically for cases like:
> > - the entity is a proxy but has no homeid. 
> > - the entity is a proxy but has none manditory attributes set which 
> > should not be returned
> > - the entity is a proxy so should not be in search results
> > 
> > As coded the caller is responsible for this sort of validation.

Thanks David - good suggestions.
There is already validation (in addEntityProxy) that the metadataCollectionId 
is non null - this will prevent creation of a proxy with a null homeId.
I have added filtering out of proxy entities from search methods (using DSL or 
searchParameters).


- Graham


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68188/#review207015
---


On Aug. 16, 2018, 1:56 p.m., Graham Wallis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68188/
> ---
> 
> (Updated Aug. 16, 2018, 1:56 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS_2808: Support for entity proxies
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 
> a892551f789cb2a4b21a4f0124a4b6b94bfecd1c 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> dc2be412b9ec1b07d7c7befc722810273464cd3f 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> 9c4b9f2323cae76ed226b3980086c2b331d521d2 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  2153a5a9e62ecf3e4a4c847b64edc29c1fb8eafc 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
>  52c3745642f3eb2af00cb61e10d710c781b100b7 
> 
> 
> Diff: https://reviews.apache.org/r/68188/diff/2/
> 
> 
> Testing
> ---
> 
> Tested with saveRelationshipReferenceCopy between entities that do not exist 
> in the Atlas repository.
> 
> 
> Thanks,
> 
> Graham Wallis
> 
>

Re: Review Request 68188: ATLAS-2808: Enable Atlas to support entity proxies

2018-08-16 Thread Graham Wallis 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68188/
---

(Updated Aug. 16, 2018, 1:56 p.m.)


Review request for atlas.


Repository: atlas


Description
---

ATLAS_2808: Support for entity proxies


Diffs (updated)
-

  common/src/main/java/org/apache/atlas/repository/Constants.java 
a892551f789cb2a4b21a4f0124a4b6b94bfecd1c 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
dc2be412b9ec1b07d7c7befc722810273464cd3f 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
9c4b9f2323cae76ed226b3980086c2b331d521d2 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 2153a5a9e62ecf3e4a4c847b64edc29c1fb8eafc 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
 52c3745642f3eb2af00cb61e10d710c781b100b7 


Diff: https://reviews.apache.org/r/68188/diff/2/

Changes: https://reviews.apache.org/r/68188/diff/1-2/


Testing
---

Tested with saveRelationshipReferenceCopy between entities that do not exist in 
the Atlas repository.


Thanks,

Graham Wallis

Re: Review Request 68188: ATLAS-2808: Enable Atlas to support entity proxies

2018-08-09 Thread David Radley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68188/#review207015
---




common/src/main/java/org/apache/atlas/repository/Constants.java
Lines 96 (patched)


I suggest a comment to document what the flag is. In the style of the 
homeId comment.



repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
Lines 174 (patched)


I am wondering what your thoughts are on validation in Atlas. Specifically 
for cases like:
- the entity is a proxy but has no homeid. 
- the entity is a proxy but has none manditory attributes set which should 
not be returned
- the entity is a proxy so should not be in search results

As coded the caller is responsible for this sort of validation.


- David Radley


On Aug. 3, 2018, 1:33 p.m., Graham Wallis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68188/
> ---
> 
> (Updated Aug. 3, 2018, 1:33 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS_2808: Support for entity proxies
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 
> 7988d1d81595eb3d65ecca2480c0e67d17f53573 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> dc2be412b9ec1b07d7c7befc722810273464cd3f 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> d328873f1f2695954d79e476a40166f48ffda482 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  f57ce99f764a5c779f1cfa4325849c15ac804b2d 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
>  448d03bc069869db85cd86e14021a3fa59b57e33 
> 
> 
> Diff: https://reviews.apache.org/r/68188/diff/1/
> 
> 
> Testing
> ---
> 
> Tested with saveRelationshipReferenceCopy between entities that do not exist 
> in the Atlas repository.
> 
> 
> Thanks,
> 
> Graham Wallis
> 
>

Re: Review Request 68188: ATLAS-2808: Enable Atlas to support entity proxies

2018-08-07 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68188/#review206967
---




intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java
Lines 79 (patched)


I think 'isProxy' is a better name than 'proxyFlag'. Consider renaming this 
attribute and rest of similar references (PROXY_FLAG_KEY, KEY_PROXY_FLAG, ..).


- Madhan Neethiraj


On Aug. 3, 2018, 1:33 p.m., Graham Wallis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68188/
> ---
> 
> (Updated Aug. 3, 2018, 1:33 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS_2808: Support for entity proxies
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 
> 7988d1d81595eb3d65ecca2480c0e67d17f53573 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> dc2be412b9ec1b07d7c7befc722810273464cd3f 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> d328873f1f2695954d79e476a40166f48ffda482 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  f57ce99f764a5c779f1cfa4325849c15ac804b2d 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
>  448d03bc069869db85cd86e14021a3fa59b57e33 
> 
> 
> Diff: https://reviews.apache.org/r/68188/diff/1/
> 
> 
> Testing
> ---
> 
> Tested with saveRelationshipReferenceCopy between entities that do not exist 
> in the Atlas repository.
> 
> 
> Thanks,
> 
> Graham Wallis
> 
>

Review Request 68188: ATLAS-2808: Enable Atlas to support entity proxies

2018-08-03 Thread Graham Wallis 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68188/
---

Review request for atlas.


Repository: atlas


Description
---

ATLAS_2808: Support for entity proxies


Diffs
-

  common/src/main/java/org/apache/atlas/repository/Constants.java 
7988d1d81595eb3d65ecca2480c0e67d17f53573 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
dc2be412b9ec1b07d7c7befc722810273464cd3f 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
d328873f1f2695954d79e476a40166f48ffda482 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 f57ce99f764a5c779f1cfa4325849c15ac804b2d 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
 448d03bc069869db85cd86e14021a3fa59b57e33 


Diff: https://reviews.apache.org/r/68188/diff/1/


Testing
---

Tested with saveRelationshipReferenceCopy between entities that do not exist in 
the Atlas repository.


Thanks,

Graham Wallis