Re: Review Request 68368: ATLAS-2823: updated hooks to support asynchronous notifications (branch-0.8)

2018-08-16 Thread Sarath Subramanian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68368/#review207437
---


Ship it!




Ship It!

- Sarath Subramanian


On Aug. 16, 2018, 2:33 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68368/
> ---
> 
> (Updated Aug. 16, 2018, 2:33 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Nixon Rodrigues, 
> Ramesh Mani, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2823
> https://issues.apache.org/jira/browse/ATLAS-2823
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> updated hooks to support asynchronous notifications (branch-0.8)
> 
> 
> Diffs
> -
> 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java
>  188b7543c 
>   
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
>  314ff68e6 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
> e001a06d6 
>   
> addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java 
> 666ec13c0 
>   
> addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java
>  c3df8fcdf 
>   notification/src/main/java/org/apache/atlas/hook/AtlasHook.java 38f320826 
>   notification/src/test/java/org/apache/atlas/hook/AtlasHookTest.java 
> d59cb1cf8 
> 
> 
> Diff: https://reviews.apache.org/r/68368/diff/4/
> 
> 
> Testing
> ---
> 
> Pre-commit test run - 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/593
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>



Re: Review Request 68368: ATLAS-2823: updated hooks to support asynchronous notifications (branch-0.8)

2018-08-16 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68368/
---

(Updated Aug. 16, 2018, 9:33 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Nixon Rodrigues, Ramesh 
Mani, and Sarath Subramanian.


Changes
---

moved unit test fixes to a separate patch/commit


Bugs: ATLAS-2823
https://issues.apache.org/jira/browse/ATLAS-2823


Repository: atlas


Description
---

updated hooks to support asynchronous notifications (branch-0.8)


Diffs (updated)
-

  
addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java 
188b7543c 
  
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
 314ff68e6 
  addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
e001a06d6 
  addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java 
666ec13c0 
  
addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java
 c3df8fcdf 
  notification/src/main/java/org/apache/atlas/hook/AtlasHook.java 38f320826 
  notification/src/test/java/org/apache/atlas/hook/AtlasHookTest.java d59cb1cf8 


Diff: https://reviews.apache.org/r/68368/diff/4/

Changes: https://reviews.apache.org/r/68368/diff/3-4/


Testing
---

Pre-commit test run - 
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/580


Thanks,

Madhan Neethiraj



Re: Review Request 68368: ATLAS-2823: updated hooks to support asynchronous notifications (branch-0.8)

2018-08-16 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68368/
---

(Updated Aug. 16, 2018, 6:38 a.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Nixon Rodrigues, Ramesh 
Mani, and Sarath Subramanian.


Changes
---

More unit test fixes


Bugs: ATLAS-2823
https://issues.apache.org/jira/browse/ATLAS-2823


Repository: atlas


Description
---

updated hooks to support asynchronous notifications (branch-0.8)


Diffs (updated)
-

  
addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java 
188b7543c 
  
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
 314ff68e6 
  addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
e001a06d6 
  addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java 
666ec13c0 
  
addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java
 c3df8fcdf 
  notification/src/main/java/org/apache/atlas/hook/AtlasHook.java 38f320826 
  notification/src/test/java/org/apache/atlas/hook/AtlasHookTest.java d59cb1cf8 
  webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 
5806a10d6 
  
webapp/src/test/java/org/apache/atlas/web/integration/EntityJerseyResourceIT.java
 f2a78010a 
  webapp/src/test/resources/json/search-parameters/entity-filters.json 
67b0b51f5 


Diff: https://reviews.apache.org/r/68368/diff/3/

Changes: https://reviews.apache.org/r/68368/diff/2-3/


Testing
---

Pre-commit test run - 
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/580


Thanks,

Madhan Neethiraj



Re: Review Request 68368: ATLAS-2823: updated hooks to support asynchronous notifications (branch-0.8)

2018-08-15 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68368/
---

(Updated Aug. 16, 2018, 2:29 a.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Nixon Rodrigues, Ramesh 
Mani, and Sarath Subramanian.


Changes
---

updated for unit test failures


Bugs: ATLAS-2823
https://issues.apache.org/jira/browse/ATLAS-2823


Repository: atlas


Description
---

updated hooks to support asynchronous notifications (branch-0.8)


Diffs (updated)
-

  
addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java 
188b7543c 
  
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
 314ff68e6 
  addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
e001a06d6 
  addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java 
666ec13c0 
  
addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java
 c3df8fcdf 
  notification/src/main/java/org/apache/atlas/hook/AtlasHook.java 38f320826 
  notification/src/test/java/org/apache/atlas/hook/AtlasHookTest.java d59cb1cf8 
  webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 
5806a10d6 
  
webapp/src/test/java/org/apache/atlas/web/integration/EntityJerseyResourceIT.java
 f2a78010a 
  webapp/src/test/resources/json/search-parameters/entity-filters.json 
67b0b51f5 


Diff: https://reviews.apache.org/r/68368/diff/2/

Changes: https://reviews.apache.org/r/68368/diff/1-2/


Testing (updated)
---

Pre-commit test run - 
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/580


Thanks,

Madhan Neethiraj



Review Request 68368: ATLAS-2823: updated hooks to support asynchronous notifications (branch-0.8)

2018-08-15 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68368/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, Nixon Rodrigues, Ramesh 
Mani, and Sarath Subramanian.


Bugs: ATLAS-2823
https://issues.apache.org/jira/browse/ATLAS-2823


Repository: atlas


Description
---

updated hooks to support asynchronous notifications (branch-0.8)


Diffs
-

  
addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java 
188b7543c 
  
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
 314ff68e6 
  addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
e001a06d6 
  addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java 
666ec13c0 
  
addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java
 c3df8fcdf 
  notification/src/main/java/org/apache/atlas/hook/AtlasHook.java 38f320826 
  notification/src/test/java/org/apache/atlas/hook/AtlasHookTest.java d59cb1cf8 


Diff: https://reviews.apache.org/r/68368/diff/1/


Testing
---

Pre-commit test run - 
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/577


Thanks,

Madhan Neethiraj