Re: Review Request 71089: ATLAS-3338: avoid repeated calls to get index-field name during startup

2019-07-18 Thread Sridhar K 


> On July 18, 2019, 8:10 a.m., Sridhar K wrote:
> > Ship It!

Thanks for fixing it.


- Sridhar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71089/#review216713
---


On July 17, 2019, 6:45 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71089/
> ---
> 
> (Updated July 17, 2019, 6:45 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, keval bhatt, 
> Sridhar K, Le Ma, Mandar Ambawane, mayank jain, Nikhil Bonte, Nixon 
> Rodrigues, Saqeeb Shaikh, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3338
> https://issues.apache.org/jira/browse/ATLAS-3338
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> updated resolveIndexFieldName() to check the attribute instance in super-type 
> i.e. the type where the attribute is defined-in; only when this instance 
> doesn't have index-field name set, graph API is called to retrieve the value
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  95ae5049e 
> 
> 
> Diff: https://reviews.apache.org/r/71089/diff/2/
> 
> 
> Testing
> ---
> 
> - manaully verified that only one call is made to graph API during 
> type-system initialization/update
> - pre-commit tests run: 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1271
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 71089: ATLAS-3338: avoid repeated calls to get index-field name during startup

2019-07-18 Thread Sridhar K 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71089/#review216713
---


Ship it!




Ship It!

- Sridhar K


On July 17, 2019, 6:45 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71089/
> ---
> 
> (Updated July 17, 2019, 6:45 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, keval bhatt, 
> Sridhar K, Le Ma, Mandar Ambawane, mayank jain, Nikhil Bonte, Nixon 
> Rodrigues, Saqeeb Shaikh, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3338
> https://issues.apache.org/jira/browse/ATLAS-3338
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> updated resolveIndexFieldName() to check the attribute instance in super-type 
> i.e. the type where the attribute is defined-in; only when this instance 
> doesn't have index-field name set, graph API is called to retrieve the value
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  95ae5049e 
> 
> 
> Diff: https://reviews.apache.org/r/71089/diff/2/
> 
> 
> Testing
> ---
> 
> - manaully verified that only one call is made to graph API during 
> type-system initialization/update
> - pre-commit tests run: 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1271
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 71089: ATLAS-3338: avoid repeated calls to get index-field name during startup

2019-07-16 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71089/#review216680
---


Ship it!




Ship It!

- Sarath Subramanian


On July 16, 2019, 11:45 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71089/
> ---
> 
> (Updated July 16, 2019, 11:45 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, keval bhatt, 
> Sridhar K, Le Ma, Mandar Ambawane, mayank jain, Nikhil Bonte, Nixon 
> Rodrigues, Saqeeb Shaikh, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3338
> https://issues.apache.org/jira/browse/ATLAS-3338
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> updated resolveIndexFieldName() to check the attribute instance in super-type 
> i.e. the type where the attribute is defined-in; only when this instance 
> doesn't have index-field name set, graph API is called to retrieve the value
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  95ae5049e 
> 
> 
> Diff: https://reviews.apache.org/r/71089/diff/2/
> 
> 
> Testing
> ---
> 
> - manaully verified that only one call is made to graph API during 
> type-system initialization/update
> - pre-commit tests run: 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1271
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 71089: ATLAS-3338: avoid repeated calls to get index-field name during startup

2019-07-16 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71089/
---

(Updated July 17, 2019, 6:45 a.m.)


Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, keval bhatt, 
Sridhar K, Le Ma, Mandar Ambawane, mayank jain, Nikhil Bonte, Nixon Rodrigues, 
Saqeeb Shaikh, and Sarath Subramanian.


Changes
---

Fix to address the issue flagged in review.


Bugs: ATLAS-3338
https://issues.apache.org/jira/browse/ATLAS-3338


Repository: atlas


Description
---

updated resolveIndexFieldName() to check the attribute instance in super-type 
i.e. the type where the attribute is defined-in; only when this instance 
doesn't have index-field name set, graph API is called to retrieve the value


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
 95ae5049e 


Diff: https://reviews.apache.org/r/71089/diff/2/

Changes: https://reviews.apache.org/r/71089/diff/1-2/


Testing
---

- manaully verified that only one call is made to graph API during type-system 
initialization/update
- pre-commit tests run: 
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1271


Thanks,

Madhan Neethiraj

Re: Review Request 71089: ATLAS-3338: avoid repeated calls to get index-field name during startup

2019-07-16 Thread Madhan Neethiraj 


> On July 17, 2019, 6:22 a.m., Sarath Subramanian wrote:
> > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
> > Lines 394 (patched)
> > 
> >
> > should this be =>
> > 
> > AtlasPropertyKey propertyKey = 
> > managementSystem.getPropertyKey(attribute.getVertexPropertyName());

Good catch! Update to correct this.


- Madhan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71089/#review216676
---


On July 17, 2019, 12:22 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71089/
> ---
> 
> (Updated July 17, 2019, 12:22 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, keval bhatt, 
> Sridhar K, Le Ma, Mandar Ambawane, mayank jain, Nikhil Bonte, Nixon 
> Rodrigues, Saqeeb Shaikh, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3338
> https://issues.apache.org/jira/browse/ATLAS-3338
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> updated resolveIndexFieldName() to check the attribute instance in super-type 
> i.e. the type where the attribute is defined-in; only when this instance 
> doesn't have index-field name set, graph API is called to retrieve the value
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  95ae5049e 
> 
> 
> Diff: https://reviews.apache.org/r/71089/diff/1/
> 
> 
> Testing
> ---
> 
> - manaully verified that only one call is made to graph API during 
> type-system initialization/update
> - pre-commit tests run: 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1271
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 71089: ATLAS-3338: avoid repeated calls to get index-field name during startup

2019-07-16 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71089/#review216676
---


Fix it, then Ship it!





repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
Lines 394 (patched)


should this be =>

AtlasPropertyKey propertyKey = 
managementSystem.getPropertyKey(attribute.getVertexPropertyName());


- Sarath Subramanian


On July 16, 2019, 5:22 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71089/
> ---
> 
> (Updated July 16, 2019, 5:22 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, keval bhatt, 
> Sridhar K, Le Ma, Mandar Ambawane, mayank jain, Nikhil Bonte, Nixon 
> Rodrigues, Saqeeb Shaikh, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3338
> https://issues.apache.org/jira/browse/ATLAS-3338
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> updated resolveIndexFieldName() to check the attribute instance in super-type 
> i.e. the type where the attribute is defined-in; only when this instance 
> doesn't have index-field name set, graph API is called to retrieve the value
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  95ae5049e 
> 
> 
> Diff: https://reviews.apache.org/r/71089/diff/1/
> 
> 
> Testing
> ---
> 
> - manaully verified that only one call is made to graph API during 
> type-system initialization/update
> - pre-commit tests run: 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1271
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Review Request 71089: ATLAS-3338: avoid repeated calls to get index-field name during startup

2019-07-16 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71089/
---

Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, keval bhatt, 
Sridhar K, Le Ma, Mandar Ambawane, mayank jain, Nikhil Bonte, Nixon Rodrigues, 
Saqeeb Shaikh, and Sarath Subramanian.


Bugs: ATLAS-3338
https://issues.apache.org/jira/browse/ATLAS-3338


Repository: atlas


Description
---

updated resolveIndexFieldName() to check the attribute instance in super-type 
i.e. the type where the attribute is defined-in; only when this instance 
doesn't have index-field name set, graph API is called to retrieve the value


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
 95ae5049e 


Diff: https://reviews.apache.org/r/71089/diff/1/


Testing
---

- manaully verified that only one call is made to graph API during type-system 
initialization/update
- pre-commit tests run: 
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1271


Thanks,

Madhan Neethiraj