Re: Review Request 72021: ATLAS-3590: Hive hook should ignore capturing lineage for temporary tables in CTAS queries

2020-01-21 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72021/#review219340
---


Ship it!




Ship It!

- Madhan Neethiraj


On Jan. 17, 2020, 12:54 a.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72021/
> ---
> 
> (Updated Jan. 17, 2020, 12:54 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Mandar Ambawane, 
> mayank jain, Nixon Rodrigues, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3590
> https://issues.apache.org/jira/browse/ATLAS-3590
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Atlas hive hook ignores capturing metadata for temporary tables in CREATE 
> queries. Similarly it should ignore capturing lineage for temporary tables in 
> CTAS queries
> 
> 
> Diffs
> -
> 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
> 5b1f61b63 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java
>  425be5952 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java
>  82df57650 
> 
> 
> Diff: https://reviews.apache.org/r/72021/diff/1/
> 
> 
> Testing
> ---
> 
> validated manually hive hook is not sending lineage for temporary table.
> 
> Precommit: 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1606/console
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>



Re: Review Request 72021: ATLAS-3590: Hive hook should ignore capturing lineage for temporary tables in CTAS queries

2020-01-17 Thread Ashutosh Mestry via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72021/#review219325
---


Ship it!




Ship It!

- Ashutosh Mestry


On Jan. 17, 2020, 12:54 a.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72021/
> ---
> 
> (Updated Jan. 17, 2020, 12:54 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Mandar Ambawane, 
> mayank jain, Nixon Rodrigues, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3590
> https://issues.apache.org/jira/browse/ATLAS-3590
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Atlas hive hook ignores capturing metadata for temporary tables in CREATE 
> queries. Similarly it should ignore capturing lineage for temporary tables in 
> CTAS queries
> 
> 
> Diffs
> -
> 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
> 5b1f61b63 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java
>  425be5952 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java
>  82df57650 
> 
> 
> Diff: https://reviews.apache.org/r/72021/diff/1/
> 
> 
> Testing
> ---
> 
> validated manually hive hook is not sending lineage for temporary table.
> 
> Precommit: 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1606/console
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>



Review Request 72021: ATLAS-3590: Hive hook should ignore capturing lineage for temporary tables in CTAS queries

2020-01-16 Thread Sarath Subramanian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72021/
---

Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Mandar Ambawane, 
mayank jain, Nixon Rodrigues, and Sidharth Mishra.


Bugs: ATLAS-3590
https://issues.apache.org/jira/browse/ATLAS-3590


Repository: atlas


Description
---

Atlas hive hook ignores capturing metadata for temporary tables in CREATE 
queries. Similarly it should ignore capturing lineage for temporary tables in 
CTAS queries


Diffs
-

  addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
5b1f61b63 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java
 425be5952 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java
 82df57650 


Diff: https://reviews.apache.org/r/72021/diff/1/


Testing
---

validated manually hive hook is not sending lineage for temporary table.

Precommit: 
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1606/console


Thanks,

Sarath Subramanian