Re: Review Request 73046: ATLAS-4055 Basic search doesn't work if the search text has special characters
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73046/#review43
---
Ship it!
Ship It!
- Nikhil Bonte
On Nov. 26, 2020, 9:46 a.m., Jayendra Parab wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73046/
> ---
>
> (Updated Nov. 26, 2020, 9:46 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath
> Subramanian.
>
>
> Bugs: ATLAS-4055
> https://issues.apache.org/jira/browse/ATLAS-4055
>
>
> Repository: atlas
>
>
> Description
> ---
>
> If the search text has a special character (i.e, one of + - & | ! ( ) { } [ ]
> ^ " ~ * ? : \ /), then we need to enclose the search text in double quotes.
> This change is required in addition to the changes provided in ATLAS-3983
>
>
> Diffs
> -
>
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 28d2e23c4
>
>
> Diff: https://reviews.apache.org/r/73046/diff/2/
>
>
> Testing
> ---
>
> - Created entities with all the special characters in the name and qualified
> name attribute
> - Tried basic search with attributes to search the name and qualified name
> - The search result included the appropriate entity that was matching the
> search criteria
>
>
> Thanks,
>
> Jayendra Parab
>
>
Re: Review Request 73046: ATLAS-4055 Basic search doesn't work if the search text has special characters
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73046/
---
(Updated Nov. 26, 2020, 9:46 a.m.)
Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath
Subramanian.
Changes
---
Fixed a testcase failure, removed * from the list of special characters for
which we need to enclose in double quotes. The * char is used in the search
string for wildcard search, so removing it
Bugs: ATLAS-4055
https://issues.apache.org/jira/browse/ATLAS-4055
Repository: atlas
Description
---
If the search text has a special character (i.e, one of + - & | ! ( ) { } [ ] ^
" ~ * ? : \ /), then we need to enclose the search text in double quotes. This
change is required in addition to the changes provided in ATLAS-3983
Diffs (updated)
-
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 28d2e23c4
Diff: https://reviews.apache.org/r/73046/diff/2/
Changes: https://reviews.apache.org/r/73046/diff/1-2/
Testing
---
- Created entities with all the special characters in the name and qualified
name attribute
- Tried basic search with attributes to search the name and qualified name
- The search result included the appropriate entity that was matching the
search criteria
Thanks,
Jayendra Parab
Re: Review Request 73046: ATLAS-4055 Basic search doesn't work if the search text has special characters
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73046/#review42
---
Ship it!
Ship It!
- Sarath Subramanian
On Nov. 25, 2020, 10 p.m., Jayendra Parab wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73046/
> ---
>
> (Updated Nov. 25, 2020, 10 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath
> Subramanian.
>
>
> Bugs: ATLAS-4055
> https://issues.apache.org/jira/browse/ATLAS-4055
>
>
> Repository: atlas
>
>
> Description
> ---
>
> If the search text has a special character (i.e, one of + - & | ! ( ) { } [ ]
> ^ " ~ * ? : \ /), then we need to enclose the search text in double quotes.
> This change is required in addition to the changes provided in ATLAS-3983
>
>
> Diffs
> -
>
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 28d2e23c4
>
>
> Diff: https://reviews.apache.org/r/73046/diff/1/
>
>
> Testing
> ---
>
> - Created entities with all the special characters in the name and qualified
> name attribute
> - Tried basic search with attributes to search the name and qualified name
> - The search result included the appropriate entity that was matching the
> search criteria
>
>
> Thanks,
>
> Jayendra Parab
>
>
Re: Review Request 73046: ATLAS-4055 Basic search doesn't work if the search text has special characters
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73046/
---
(Updated Nov. 26, 2020, 6 a.m.)
Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath
Subramanian.
Summary (updated)
-
ATLAS-4055 Basic search doesn't work if the search text has special characters
Bugs: ATLAS-4055
https://issues.apache.org/jira/browse/ATLAS-4055
Repository: atlas
Description
---
If the search text has a special character (i.e, one of + - & | ! ( ) { } [ ] ^
" ~ * ? : \ /), then we need to enclose the search text in double quotes. This
change is required in addition to the changes provided in ATLAS-3983
Diffs
-
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 28d2e23c4
Diff: https://reviews.apache.org/r/73046/diff/1/
Testing
---
- Created entities with all the special characters in the name and qualified
name attribute
- Tried basic search with attributes to search the name and qualified name
- The search result included the appropriate entity that was matching the
search criteria
Thanks,
Jayendra Parab
