Re: Review Request 73228: Fix the missing properties of Atlas Entity

2021-03-16 Thread Madhan Neethiraj 
Verdan,

Apache Atlas Python client 0.11 is now available at 
https://pypi.org/project/apache-atlas/.

Thanks,
Madhan


On 3/15/21, 9:59 AM, "Verdan Mahmood"  wrote:

and a new release to PyPi too, please. 

Re: Review Request 73228: Fix the missing properties of Atlas Entity

2021-03-15 Thread Verdan Mahmood 
and a new release to PyPi too, please. 

Re: Review Request 73228: Fix the missing properties of Atlas Entity

2021-03-15 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73228/#review222685
---


Ship it!




Ship It!

- Madhan Neethiraj


On March 15, 2021, 3:35 p.m., Verdan Mahmood wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73228/
> ---
> 
> (Updated March 15, 2021, 3:35 p.m.)
> 
> 
> Review request for atlas, Jyoti Singh, Madhan Neethiraj, Pinal Shah, and 
> Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Fixes the missing properties of Atlas Entity, and matches with the 
> AtlasEntity object: https://atlas.apache.org/api/v2/json_AtlasEntity.html
> 
> 
> Diffs
> -
> 
>   intg/src/main/python/apache_atlas/model/instance.py 
> 3b2edc435fb27d57e289ec3cef4c1682f460f4fe 
>   intg/src/main/python/setup.py 0a4c2c23ffed709c84ae6a129512aaac36b6347e 
> 
> 
> Diff: https://reviews.apache.org/r/73228/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Verdan Mahmood
> 
>

Re: Review Request 73228: Fix the missing properties of Atlas Entity

2021-03-15 Thread Verdan Mahmood 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73228/
---

(Updated March 15, 2021, 3:35 p.m.)


Review request for atlas, Jyoti Singh, Madhan Neethiraj, Pinal Shah, and Sarath 
Subramanian.


Repository: atlas


Description
---

Fixes the missing properties of Atlas Entity, and matches with the AtlasEntity 
object: https://atlas.apache.org/api/v2/json_AtlasEntity.html


Diffs (updated)
-

  intg/src/main/python/apache_atlas/model/instance.py 
3b2edc435fb27d57e289ec3cef4c1682f460f4fe 
  intg/src/main/python/setup.py 0a4c2c23ffed709c84ae6a129512aaac36b6347e 


Diff: https://reviews.apache.org/r/73228/diff/3/

Changes: https://reviews.apache.org/r/73228/diff/2-3/


Testing
---


Thanks,

Verdan Mahmood

Re: Review Request 73228: Fix the missing properties of Atlas Entity

2021-03-15 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73228/#review222682
---




intg/src/main/python/apache_atlas/model/instance.py
Lines 63 (patched)


I suggest to add the missing attributes directly in AtlasEntity class, 
instead of removing from AtlasRelationship and AtlasBaseTypeDef, and 
consolidating via CreateUpdateTimestamps as base class. This will help keep 
Python classes consistent with Java equivalent.


- Madhan Neethiraj


On March 15, 2021, 10:39 a.m., Verdan Mahmood wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73228/
> ---
> 
> (Updated March 15, 2021, 10:39 a.m.)
> 
> 
> Review request for atlas, Jyoti Singh, Madhan Neethiraj, Pinal Shah, and 
> Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Fixes the missing properties of Atlas Entity, and matches with the 
> AtlasEntity object: https://atlas.apache.org/api/v2/json_AtlasEntity.html
> 
> 
> Diffs
> -
> 
>   intg/src/main/python/apache_atlas/model/instance.py 
> 3b2edc435fb27d57e289ec3cef4c1682f460f4fe 
>   intg/src/main/python/apache_atlas/model/misc.py 
> f4d9c1c3018321c0d37e8ee9470dd3141f0f90f0 
>   intg/src/main/python/apache_atlas/model/relationship.py 
> 2a328110dc2f7d5d9d3af5d74425e48c2cc4be65 
>   intg/src/main/python/apache_atlas/model/typedef.py 
> 079f714da044632fdf14dd220586a1512f295278 
>   intg/src/main/python/setup.py 0a4c2c23ffed709c84ae6a129512aaac36b6347e 
> 
> 
> Diff: https://reviews.apache.org/r/73228/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Verdan Mahmood
> 
>

Re: Review Request 73228: Fix the missing properties of Atlas Entity

2021-03-15 Thread Verdan Mahmood 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73228/
---

(Updated March 15, 2021, 10:39 a.m.)


Review request for atlas, Jyoti Singh, Madhan Neethiraj, Pinal Shah, and Sarath 
Subramanian.


Repository: atlas


Description
---

Fixes the missing properties of Atlas Entity, and matches with the AtlasEntity 
object: https://atlas.apache.org/api/v2/json_AtlasEntity.html


Diffs (updated)
-

  intg/src/main/python/apache_atlas/model/instance.py 
3b2edc435fb27d57e289ec3cef4c1682f460f4fe 
  intg/src/main/python/apache_atlas/model/misc.py 
f4d9c1c3018321c0d37e8ee9470dd3141f0f90f0 
  intg/src/main/python/apache_atlas/model/relationship.py 
2a328110dc2f7d5d9d3af5d74425e48c2cc4be65 
  intg/src/main/python/apache_atlas/model/typedef.py 
079f714da044632fdf14dd220586a1512f295278 
  intg/src/main/python/setup.py 0a4c2c23ffed709c84ae6a129512aaac36b6347e 


Diff: https://reviews.apache.org/r/73228/diff/2/

Changes: https://reviews.apache.org/r/73228/diff/1-2/


Testing
---


Thanks,

Verdan Mahmood

Re: Review Request 73228: Fix the missing properties of Atlas Entity

2021-03-15 Thread Mariusz Górski 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73228/#review222681
---


Ship it!




Ship It!

- Mariusz Górski


On March 15, 2021, 10:21 a.m., Verdan Mahmood wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73228/
> ---
> 
> (Updated March 15, 2021, 10:21 a.m.)
> 
> 
> Review request for atlas, Jyoti Singh, Madhan Neethiraj, Pinal Shah, and 
> Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Fixes the missing properties of Atlas Entity, and matches with the 
> AtlasEntity object: https://atlas.apache.org/api/v2/json_AtlasEntity.html
> 
> 
> Diffs
> -
> 
>   intg/src/main/python/apache_atlas/model/instance.py 
> 3b2edc435fb27d57e289ec3cef4c1682f460f4fe 
>   intg/src/main/python/apache_atlas/model/misc.py 
> f4d9c1c3018321c0d37e8ee9470dd3141f0f90f0 
>   intg/src/main/python/apache_atlas/model/relationship.py 
> 2a328110dc2f7d5d9d3af5d74425e48c2cc4be65 
>   intg/src/main/python/apache_atlas/model/typedef.py 
> 079f714da044632fdf14dd220586a1512f295278 
>   intg/src/main/python/setup.py 0a4c2c23ffed709c84ae6a129512aaac36b6347e 
> 
> 
> Diff: https://reviews.apache.org/r/73228/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Verdan Mahmood
> 
>

Review Request 73228: Fix the missing properties of Atlas Entity

2021-03-15 Thread Verdan Mahmood 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73228/
---

Review request for atlas, Jyoti Singh, Madhan Neethiraj, Pinal Shah, and Sarath 
Subramanian.


Repository: atlas


Description
---

Fixes the missing properties of Atlas Entity, and matches with the AtlasEntity 
object: https://atlas.apache.org/api/v2/json_AtlasEntity.html


Diffs
-

  intg/src/main/python/apache_atlas/model/instance.py 
3b2edc435fb27d57e289ec3cef4c1682f460f4fe 
  intg/src/main/python/apache_atlas/model/misc.py 
f4d9c1c3018321c0d37e8ee9470dd3141f0f90f0 
  intg/src/main/python/apache_atlas/model/relationship.py 
2a328110dc2f7d5d9d3af5d74425e48c2cc4be65 
  intg/src/main/python/apache_atlas/model/typedef.py 
079f714da044632fdf14dd220586a1512f295278 
  intg/src/main/python/setup.py 0a4c2c23ffed709c84ae6a129512aaac36b6347e 


Diff: https://reviews.apache.org/r/73228/diff/1/


Testing
---


Thanks,

Verdan Mahmood