Re: Review Request 73271: ATLAS-4238 : Quick Search: handle special characters to get correct results

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73271/#review222849
---


Ship it!




Ship It!

- Nixon Rodrigues


On April 14, 2021, 6:40 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73271/
> ---
> 
> (Updated April 14, 2021, 6:40 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4238
> https://issues.apache.org/jira/browse/ATLAS-4238
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Current working:** During freetext/quick search, wildcard '*' is appended 
> after the search string from UI.
> Whenever attribute search value has "**+-&|!(){}[]^"~?:**"  special 
> characters, then '*' will not be appended to get the correct result.
> 
> ('*' is removed because for TEXT type attribute, it tokenize the value on 
> special characters)
> 
> **Issue:** '@' or 'digit+.' etc there are many other special characters which 
> gets tokenize for 'TEXT' type attribute. hence if the search value has these 
> special characters which are not added in above list, it doesn't give results.
> 
> **Solution:** We need to handle all the special characters which tokenize the 
> string
> 
> **Note:** This patch doesn't handle escaping special characters when search 
> as part of freetext search
>  
>  - Whenever user tends to search for **'STRING'** type attribute example: 
> 'name'
>i.  **Client has to escape 'space'**
>ii.**For the partial search, client has to append '*' **
> 
>Example: to search string with name = sales department@hdfc, user has 
> to search like sales\ department*
>
>  - Whenever user tends to search for **'TEXT'** type attribute example: 
> 'qualifiedName'
>i.  **No Need of escape 'space'**. If it is escaped partial search will 
> not work
>ii.**For partial search, no need of appending '*' **
> 
>Example: to search string with qualifiedName = sales department@hdfc, 
> user has to search like sales department or sales\ department@hdfc
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  4ae2d1279 
>   
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
>  c2778063c 
> 
> 
> Diff: https://reviews.apache.org/r/73271/diff/4/
> 
> 
> Testing
> ---
> 
> added test cases
> Precommit: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/487/console
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 73271: ATLAS-4238 : Quick Search: handle special characters to get correct results

[Pinal Shah]

> On April 14, 2021, 5:18 a.m., Sidharth Mishra wrote:
> > The precommit has failed. Please chck before merge.

it failed at Hive-bridge module, which is not related to this patch


- Pinal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73271/#review222818
---


On April 14, 2021, 6:40 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73271/
> ---
> 
> (Updated April 14, 2021, 6:40 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4238
> https://issues.apache.org/jira/browse/ATLAS-4238
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Current working:** During freetext/quick search, wildcard '*' is appended 
> after the search string from UI.
> Whenever attribute search value has "**+-&|!(){}[]^"~?:**"  special 
> characters, then '*' will not be appended to get the correct result.
> 
> ('*' is removed because for TEXT type attribute, it tokenize the value on 
> special characters)
> 
> **Issue:** '@' or 'digit+.' etc there are many other special characters which 
> gets tokenize for 'TEXT' type attribute. hence if the search value has these 
> special characters which are not added in above list, it doesn't give results.
> 
> **Solution:** We need to handle all the special characters which tokenize the 
> string
> 
> **Note:** This patch doesn't handle escaping special characters when search 
> as part of freetext search
>  
>  - Whenever user tends to search for **'STRING'** type attribute example: 
> 'name'
>i.  **Client has to escape 'space'**
>ii.**For the partial search, client has to append '*' **
> 
>Example: to search string with name = sales department@hdfc, user has 
> to search like sales\ department*
>
>  - Whenever user tends to search for **'TEXT'** type attribute example: 
> 'qualifiedName'
>i.  **No Need of escape 'space'**. If it is escaped partial search will 
> not work
>ii.**For partial search, no need of appending '*' **
> 
>Example: to search string with qualifiedName = sales department@hdfc, 
> user has to search like sales department or sales\ department@hdfc
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  4ae2d1279 
>   
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
>  9846d4310 
> 
> 
> Diff: https://reviews.apache.org/r/73271/diff/3/
> 
> 
> Testing
> ---
> 
> added test cases
> Precommit: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/487/console
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 73271: ATLAS-4238 : Quick Search: handle special characters to get correct results

[Pinal Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73271/
---

(Updated April 14, 2021, 6:40 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Changes
---

addressed comments


Bugs: ATLAS-4238
https://issues.apache.org/jira/browse/ATLAS-4238


Repository: atlas


Description
---

**Current working:** During freetext/quick search, wildcard '*' is appended 
after the search string from UI.
Whenever attribute search value has "**+-&|!(){}[]^"~?:**"  special characters, 
then '*' will not be appended to get the correct result.

('*' is removed because for TEXT type attribute, it tokenize the value on 
special characters)

**Issue:** '@' or 'digit+.' etc there are many other special characters which 
gets tokenize for 'TEXT' type attribute. hence if the search value has these 
special characters which are not added in above list, it doesn't give results.

**Solution:** We need to handle all the special characters which tokenize the 
string

**Note:** This patch doesn't handle escaping special characters when search as 
part of freetext search
 
 - Whenever user tends to search for **'STRING'** type attribute example: 'name'
   i.  **Client has to escape 'space'**
   ii.**For the partial search, client has to append '*' **

   Example: to search string with name = sales department@hdfc, user has to 
search like sales\ department*
   
 - Whenever user tends to search for **'TEXT'** type attribute example: 
'qualifiedName'
   i.  **No Need of escape 'space'**. If it is escaped partial search will not 
work
   ii.**For partial search, no need of appending '*' **

   Example: to search string with qualifiedName = sales department@hdfc, 
user has to search like sales department or sales\ department@hdfc


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
4ae2d1279 
  
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
 9846d4310 


Diff: https://reviews.apache.org/r/73271/diff/3/

Changes: https://reviews.apache.org/r/73271/diff/2-3/


Testing
---

added test cases
Precommit: 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/487/console


Thanks,

Pinal Shah

Re: Review Request 73271: ATLAS-4238 : Quick Search: handle special characters to get correct results

[Sidharth Mishra]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73271/#review222820
---




repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
Line 58 (original), 58 (patched)


Please avoid using import *. Revert the changes


- Sidharth Mishra


On April 14, 2021, 4:10 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73271/
> ---
> 
> (Updated April 14, 2021, 4:10 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4238
> https://issues.apache.org/jira/browse/ATLAS-4238
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Current working:** During freetext/quick search, wildcard '*' is appended 
> after the search string from UI.
> Whenever attribute search value has "**+-&|!(){}[]^"~?:**"  special 
> characters, then '*' will not be appended to get the correct result.
> 
> ('*' is removed because for TEXT type attribute, it tokenize the value on 
> special characters)
> 
> **Issue:** '@' or 'digit+.' etc there are many other special characters which 
> gets tokenize for 'TEXT' type attribute. hence if the search value has these 
> special characters which are not added in above list, it doesn't give results.
> 
> **Solution:** We need to handle all the special characters which tokenize the 
> string
> 
> **Note:** This patch doesn't handle escaping special characters when search 
> as part of freetext search
>  
>  - Whenever user tends to search for **'STRING'** type attribute example: 
> 'name'
>i.  **Client has to escape 'space'**
>ii.**For the partial search, client has to append '*' **
> 
>Example: to search string with name = sales department@hdfc, user has 
> to search like sales\ department*
>
>  - Whenever user tends to search for **'TEXT'** type attribute example: 
> 'qualifiedName'
>i.  **No Need of escape 'space'**. If it is escaped partial search will 
> not work
>ii.**For partial search, no need of appending '*' **
> 
>Example: to search string with qualifiedName = sales department@hdfc, 
> user has to search like sales department or sales\ department@hdfc
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  4ae2d1279 
>   
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
>  9846d4310 
> 
> 
> Diff: https://reviews.apache.org/r/73271/diff/2/
> 
> 
> Testing
> ---
> 
> added test cases
> Precommit: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/487/console
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 73271: ATLAS-4238 : Quick Search: handle special characters to get correct results

[Ashutosh Mestry via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73271/#review222819
---




repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
Lines 405 (patched)


This statement could be combined in single if clause.



repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
Lines 581 (patched)


Good!


- Ashutosh Mestry


On April 14, 2021, 4:10 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73271/
> ---
> 
> (Updated April 14, 2021, 4:10 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4238
> https://issues.apache.org/jira/browse/ATLAS-4238
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Current working:** During freetext/quick search, wildcard '*' is appended 
> after the search string from UI.
> Whenever attribute search value has "**+-&|!(){}[]^"~?:**"  special 
> characters, then '*' will not be appended to get the correct result.
> 
> ('*' is removed because for TEXT type attribute, it tokenize the value on 
> special characters)
> 
> **Issue:** '@' or 'digit+.' etc there are many other special characters which 
> gets tokenize for 'TEXT' type attribute. hence if the search value has these 
> special characters which are not added in above list, it doesn't give results.
> 
> **Solution:** We need to handle all the special characters which tokenize the 
> string
> 
> **Note:** This patch doesn't handle escaping special characters when search 
> as part of freetext search
>  
>  - Whenever user tends to search for **'STRING'** type attribute example: 
> 'name'
>i.  **Client has to escape 'space'**
>ii.**For the partial search, client has to append '*' **
> 
>Example: to search string with name = sales department@hdfc, user has 
> to search like sales\ department*
>
>  - Whenever user tends to search for **'TEXT'** type attribute example: 
> 'qualifiedName'
>i.  **No Need of escape 'space'**. If it is escaped partial search will 
> not work
>ii.**For partial search, no need of appending '*' **
> 
>Example: to search string with qualifiedName = sales department@hdfc, 
> user has to search like sales department or sales\ department@hdfc
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  4ae2d1279 
>   
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
>  9846d4310 
> 
> 
> Diff: https://reviews.apache.org/r/73271/diff/2/
> 
> 
> Testing
> ---
> 
> added test cases
> Precommit: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/487/console
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 73271: ATLAS-4238 : Quick Search: handle special characters to get correct results

[Sidharth Mishra]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73271/#review222818
---


Ship it!




The precommit has failed. Please chck before merge.

- Sidharth Mishra


On April 14, 2021, 4:10 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73271/
> ---
> 
> (Updated April 14, 2021, 4:10 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4238
> https://issues.apache.org/jira/browse/ATLAS-4238
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Current working:** During freetext/quick search, wildcard '*' is appended 
> after the search string from UI.
> Whenever attribute search value has "**+-&|!(){}[]^"~?:**"  special 
> characters, then '*' will not be appended to get the correct result.
> 
> ('*' is removed because for TEXT type attribute, it tokenize the value on 
> special characters)
> 
> **Issue:** '@' or 'digit+.' etc there are many other special characters which 
> gets tokenize for 'TEXT' type attribute. hence if the search value has these 
> special characters which are not added in above list, it doesn't give results.
> 
> **Solution:** We need to handle all the special characters which tokenize the 
> string
> 
> **Note:** This patch doesn't handle escaping special characters when search 
> as part of freetext search
>  
>  - Whenever user tends to search for **'STRING'** type attribute example: 
> 'name'
>i.  **Client has to escape 'space'**
>ii.**For the partial search, client has to append '*' **
> 
>Example: to search string with name = sales department@hdfc, user has 
> to search like sales\ department*
>
>  - Whenever user tends to search for **'TEXT'** type attribute example: 
> 'qualifiedName'
>i.  **No Need of escape 'space'**. If it is escaped partial search will 
> not work
>ii.**For partial search, no need of appending '*' **
> 
>Example: to search string with qualifiedName = sales department@hdfc, 
> user has to search like sales department or sales\ department@hdfc
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  4ae2d1279 
>   
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
>  9846d4310 
> 
> 
> Diff: https://reviews.apache.org/r/73271/diff/2/
> 
> 
> Testing
> ---
> 
> added test cases
> Precommit: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/487/console
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 73271: ATLAS-4238 : Quick Search: handle special characters to get correct results

[Pinal Shah]

> On April 13, 2021, 11:22 p.m., Sidharth Mishra wrote:
> > repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
> > Lines 614 (patched)
> > 
> >
> > Please let me know in that case how the "search_name_with\ nameblank*" 
> > retunring one result where as "search_qf_with\ qfblank*" returning 0 result.

Can you refer 'note' in the description


- Pinal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73271/#review222816
---


On April 14, 2021, 4:10 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73271/
> ---
> 
> (Updated April 14, 2021, 4:10 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4238
> https://issues.apache.org/jira/browse/ATLAS-4238
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Current working:** During freetext/quick search, wildcard '*' is appended 
> after the search string from UI.
> Whenever attribute search value has "**+-&|!(){}[]^"~?:**"  special 
> characters, then '*' will not be appended to get the correct result.
> 
> ('*' is removed because for TEXT type attribute, it tokenize the value on 
> special characters)
> 
> **Issue:** '@' or 'digit+.' etc there are many other special characters which 
> gets tokenize for 'TEXT' type attribute. hence if the search value has these 
> special characters which are not added in above list, it doesn't give results.
> 
> **Solution:** We need to handle all the special characters which tokenize the 
> string
> 
> **Note:** This patch doesn't handle escaping special characters when search 
> as part of freetext search
>  
>  - Whenever user tends to search for **'STRING'** type attribute example: 
> 'name'
>i.  **Client has to escape 'space'**
>ii.**For the partial search, client has to append '*' **
> 
>Example: to search string with name = sales department@hdfc, user has 
> to search like sales\ department*
>
>  - Whenever user tends to search for **'TEXT'** type attribute example: 
> 'qualifiedName'
>i.  **No Need of escape 'space'**. If it is escaped partial search will 
> not work
>ii.**For partial search, no need of appending '*' **
> 
>Example: to search string with qualifiedName = sales department@hdfc, 
> user has to search like sales department or sales\ department@hdfc
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  4ae2d1279 
>   
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
>  9846d4310 
> 
> 
> Diff: https://reviews.apache.org/r/73271/diff/2/
> 
> 
> Testing
> ---
> 
> added test cases
> Precommit: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/487/console
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 73271: ATLAS-4238 : Quick Search: handle special characters to get correct results

[Pinal Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73271/
---

(Updated April 14, 2021, 4:10 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Changes
---

added formatting


Bugs: ATLAS-4238
https://issues.apache.org/jira/browse/ATLAS-4238


Repository: atlas


Description (updated)
---

**Current working:** During freetext/quick search, wildcard '*' is appended 
after the search string from UI.
Whenever attribute search value has "**+-&|!(){}[]^"~?:**"  special characters, 
then '*' will not be appended to get the correct result.

('*' is removed because for TEXT type attribute, it tokenize the value on 
special characters)

**Issue:** '@' or 'digit+.' etc there are many other special characters which 
gets tokenize for 'TEXT' type attribute. hence if the search value has these 
special characters which are not added in above list, it doesn't give results.

**Solution:** We need to handle all the special characters which tokenize the 
string

**Note:** This patch doesn't handle escaping special characters when search as 
part of freetext search
 
 - Whenever user tends to search for **'STRING'** type attribute example: 'name'
   i.  **Client has to escape 'space'**
   ii.**For the partial search, client has to append '*' **

   Example: to search string with name = sales department@hdfc, user has to 
search like sales\ department*
   
 - Whenever user tends to search for **'TEXT'** type attribute example: 
'qualifiedName'
   i.  **No Need of escape 'space'**. If it is escaped partial search will not 
work
   ii.**For partial search, no need of appending '*' **

   Example: to search string with qualifiedName = sales department@hdfc, 
user has to search like sales department or sales\ department@hdfc


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
4ae2d1279 
  
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
 9846d4310 


Diff: https://reviews.apache.org/r/73271/diff/2/

Changes: https://reviews.apache.org/r/73271/diff/1-2/


Testing
---

added test cases
Precommit: 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/487/console


Thanks,

Pinal Shah

Re: Review Request 73271: ATLAS-4238 : Quick Search: handle special characters to get correct results

[Sidharth Mishra]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73271/#review222816
---




repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
Lines 614 (patched)


Please let me know in that case how the "search_name_with\ nameblank*" 
retunring one result where as "search_qf_with\ qfblank*" returning 0 result.



repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
Lines 706 (patched)


nit: Please add one space after searchResult.getSearchResults(). Similarly 
please do other places.


- Sidharth Mishra


On April 8, 2021, 4:13 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73271/
> ---
> 
> (Updated April 8, 2021, 4:13 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4238
> https://issues.apache.org/jira/browse/ATLAS-4238
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Current working:** During freetext/quick search, wildcard '*' is appended 
> after the search string from UI.
> Whenever attribute search value has "**+-&|!(){}[]^"~?:**"  special 
> characters, then '*' will not be appended to get the correct result.
> 
> ('*' is removed because for TEXT type attribute, it tokenize the value on 
> special characters)
> 
> **Issue:** '@' or 'digit+.' etc there are many other special characters which 
> gets tokenize for 'TEXT' type attribute. hence if the search value has these 
> special characters which are not added in above list, it doesn't give results.
> 
> **Solution:** We need to handle all the special characters which tokenize the 
> string
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  4ae2d1279 
>   
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
>  9846d4310 
> 
> 
> Diff: https://reviews.apache.org/r/73271/diff/1/
> 
> 
> Testing
> ---
> 
> added test cases
> Precommit: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/487/console
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 73271: ATLAS-4238 : Quick Search: handle special characters to get correct results

[Pinal Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73271/
---

(Updated April 8, 2021, 4:13 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Changes
---

added Precommit


Bugs: ATLAS-4238
https://issues.apache.org/jira/browse/ATLAS-4238


Repository: atlas


Description
---

**Current working:** During freetext/quick search, wildcard '*' is appended 
after the search string from UI.
Whenever attribute search value has "**+-&|!(){}[]^"~?:**"  special characters, 
then '*' will not be appended to get the correct result.

('*' is removed because for TEXT type attribute, it tokenize the value on 
special characters)

**Issue:** '@' or 'digit+.' etc there are many other special characters which 
gets tokenize for 'TEXT' type attribute. hence if the search value has these 
special characters which are not added in above list, it doesn't give results.

**Solution:** We need to handle all the special characters which tokenize the 
string


Diffs
-

  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
4ae2d1279 
  
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
 9846d4310 


Diff: https://reviews.apache.org/r/73271/diff/1/


Testing (updated)
---

added test cases
Precommit: 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/487/console


Thanks,

Pinal Shah

Review Request 73271: ATLAS-4238 : Quick Search: handle special characters to get correct results

[Pinal Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73271/
---

Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Bugs: ATLAS-4238
https://issues.apache.org/jira/browse/ATLAS-4238


Repository: atlas


Description
---

**Current working:** During freetext/quick search, wildcard '*' is appended 
after the search string from UI.
Whenever attribute search value has "**+-&|!(){}[]^"~?:**"  special characters, 
then '*' will not be appended to get the correct result.

('*' is removed because for TEXT type attribute, it tokenize the value on 
special characters)

**Issue:** '@' or 'digit+.' etc there are many other special characters which 
gets tokenize for 'TEXT' type attribute. hence if the search value has these 
special characters which are not added in above list, it doesn't give results.

**Solution:** We need to handle all the special characters which tokenize the 
string


Diffs
-

  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
4ae2d1279 
  
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
 9846d4310 


Diff: https://reviews.apache.org/r/73271/diff/1/


Testing
---

added test cases
Precommit:


Thanks,

Pinal Shah