Re: Review Request 73317: ATLAS-3812: Add schema for Apache Flink

2021-06-03 Thread Nixon Rodrigues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73317/#review223102
---


Ship it!




Ship It!

- Nixon Rodrigues


On June 1, 2021, 6:59 p.m., Josh Yeh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73317/
> ---
> 
> (Updated June 1, 2021, 6:59 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Pinal Shah, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-3812: Add schema for Apache Flink
> 
> 
> Diffs
> -
> 
>   addons/models/1000-Hadoop/1110-flink_model.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73317/diff/4/
> 
> 
> Testing
> ---
> 
> Tested on my CDH cluster with flink example wordcount streaming job.
> 
> 
> File Attachments
> 
> 
> Screen Shot 2021-04-30 at 12.38.27 AM.png
>   
> https://reviews.apache.org/media/uploaded/files/2021/04/30/2ff59445-7237-4be1-a1a0-b6db70bc7827__Screen_Shot_2021-04-30_at_12.38.27_AM.png
> 
> 
> Thanks,
> 
> Josh Yeh
> 
>

Re: Review Request 73317: ATLAS-3812: Add schema for Apache Flink

2021-06-03 Thread Ashutosh Mestry via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73317/#review223094
---


Ship it!




Ship It!

- Ashutosh Mestry


On June 1, 2021, 6:59 p.m., Josh Yeh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73317/
> ---
> 
> (Updated June 1, 2021, 6:59 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Pinal Shah, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-3812: Add schema for Apache Flink
> 
> 
> Diffs
> -
> 
>   addons/models/1000-Hadoop/1110-flink_model.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73317/diff/4/
> 
> 
> Testing
> ---
> 
> Tested on my CDH cluster with flink example wordcount streaming job.
> 
> 
> File Attachments
> 
> 
> Screen Shot 2021-04-30 at 12.38.27 AM.png
>   
> https://reviews.apache.org/media/uploaded/files/2021/04/30/2ff59445-7237-4be1-a1a0-b6db70bc7827__Screen_Shot_2021-04-30_at_12.38.27_AM.png
> 
> 
> Thanks,
> 
> Josh Yeh
> 
>

Re: Review Request 73317: ATLAS-3812: Add schema for Apache Flink

2021-06-02 Thread Ashutosh Mestry via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73317/#review223088
---



Thanks for the patch. The model looks good.
Can you please attach a screen shot (like you did before) that create entities 
using the new model? That will provide us with a good reference.
It will also help if you can attach the JSON that is used to create the 
entities.

- Ashutosh Mestry


On June 1, 2021, 6:59 p.m., Josh Yeh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73317/
> ---
> 
> (Updated June 1, 2021, 6:59 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Pinal Shah, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-3812: Add schema for Apache Flink
> 
> 
> Diffs
> -
> 
>   addons/models/1000-Hadoop/1110-flink_model.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73317/diff/4/
> 
> 
> Testing
> ---
> 
> Tested on my CDH cluster with flink example wordcount streaming job.
> 
> 
> File Attachments
> 
> 
> Screen Shot 2021-04-30 at 12.38.27 AM.png
>   
> https://reviews.apache.org/media/uploaded/files/2021/04/30/2ff59445-7237-4be1-a1a0-b6db70bc7827__Screen_Shot_2021-04-30_at_12.38.27_AM.png
> 
> 
> Thanks,
> 
> Josh Yeh
> 
>

Re: Review Request 73317: ATLAS-3812: Add schema for Apache Flink

2021-06-01 Thread Josh Yeh via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73317/
---

(Updated June 1, 2021, 6:59 p.m.)


Review request for atlas, Ashutosh Mestry, Pinal Shah, and Sarath Subramanian.


Repository: atlas


Description
---

ATLAS-3812: Add schema for Apache Flink


Diffs (updated)
-

  addons/models/1000-Hadoop/1110-flink_model.json PRE-CREATION 


Diff: https://reviews.apache.org/r/73317/diff/4/

Changes: https://reviews.apache.org/r/73317/diff/3-4/


Testing
---

Tested on my CDH cluster with flink example wordcount streaming job.


File Attachments


Screen Shot 2021-04-30 at 12.38.27 AM.png
  
https://reviews.apache.org/media/uploaded/files/2021/04/30/2ff59445-7237-4be1-a1a0-b6db70bc7827__Screen_Shot_2021-04-30_at_12.38.27_AM.png


Thanks,

Josh Yeh

Re: Review Request 73317: ATLAS-3812: Add schema for Apache Flink

2021-06-01 Thread Josh Yeh via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73317/
---

(Updated June 1, 2021, 6:55 p.m.)


Review request for atlas, Ashutosh Mestry, Pinal Shah, and Sarath Subramanian.


Repository: atlas


Description
---

ATLAS-3812: Add schema for Apache Flink


Diffs (updated)
-

  
addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java
 f9548244364a8f79f346411739348d0d53298c99 
  addons/models/1000-Hadoop/1110-flink_model.json PRE-CREATION 
  build-tools/src/main/resources/ui-dist/index.html 
653c38b1614680ea58d7a72aa0a3a9370ec28e31 
  build-tools/src/main/resources/ui-dist/index.js 
3ae40764c6cde3ee13a0fcb94e9e0a437ac530bc 
  common/src/main/java/org/apache/atlas/CommonConfiguration.java 
edea42ba8b92722c7a90af690c409cb648bb4255 
  common/src/main/java/org/apache/atlas/annotation/Timed.java 
b892a16c743ba6747b51bb849f3d9f2164e33d9c 
  common/src/main/java/org/apache/atlas/repository/Constants.java 
aea0c13111b1928a4ac3b687dcc904e729e4deaa 
  common/src/main/java/org/apache/atlas/utils/KafkaUtils.java 
16744225977088e86fa81649a1413182fdc0ffb8 
  common/src/test/java/org/apache/atlas/utils/KafkaUtilsTest.java 
562e28ae1e6d992ea03babe2200185d8aae076c9 
  dashboardv2/package-lock.json 61fd944c6223985efaff10f25a69f590da30d7d6 
  dashboardv2/public/css/scss/override.scss 
c51a23c3f684f1944b960cfe3888bc3b7ccaf1a7 
  dashboardv2/public/css/scss/tab.scss c164b47440d35482ce222e95408b0b29c514c7de 
  dashboardv2/public/css/scss/table.scss 
121769b18c57df2c74b211e563b17d373860f4b4 
  dashboardv2/public/css/scss/theme.scss 
4838ca3afb91830084dfd83ad9fd5cb6d26c7f2a 
  dashboardv2/public/js/external_lib/atlas-lineage/dist/index.js 
1ff212838e284cbdee092f325f4dad2a6a4c2a33 
  dashboardv2/public/js/main.js 7c8bbb48768382bee8df53cd72d0b995b0a152d6 
  dashboardv2/public/js/router/Router.js 
ea26bf5c08eb3dae14dd26cfe11b794a58f279b9 
  dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 
ee4b9431fdf3d8bda3ed9db16abe1c19eaa04aae 
  
dashboardv2/public/js/templates/detail_page/PendingTaskTableLayoutView_tmpl.html
 059c42f69090ba8e90570927a9d1b958ccdfb862 
  dashboardv2/public/js/templates/dev_debug/DebugMetricsLayoutView_tmpl.html 
78d91bf13c8f51a12cda4215b030418cb67f92c6 
  dashboardv2/public/js/templates/site/DebugMetricsTableLayoutView_tmpl.html 
8b543680a2a61a22060ac141a9ffd1d9544fc6f5 
  dashboardv2/public/js/templates/site/Header.html 
572e39e7804a97102c60e7e980ed309e8662c24a 
  dashboardv2/public/js/templates/site/MetricsUIInfoView_tmpl.html 
837c3b5bf9c1fd160d7ab49a109bff4a8f6937a5 
  dashboardv2/public/js/utils/CommonViewFunction.js 
bb3fa3fecd9ee2949cf3a9b27646190f5ab66133 
  dashboardv2/public/js/utils/Globals.js 
b0dc5cd77506ed19b1f2338bf9ea7868e027fd72 
  dashboardv2/public/js/utils/UrlLinks.js 
eb2980c11850f4ec2ab4c9bd6774d755de87a78b 
  dashboardv2/public/js/utils/Utils.js f426b6c98aa1cb89d8f06196c765830ba0e7285f 
  dashboardv2/public/js/views/audit/AuditTableLayoutView.js 
625ae87c5d86280e53d390ed28dd08897b43ffe5 
  dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 
d8e10cce02b1a68fdbf54ae0535a83b0aa2cc5b2 
  dashboardv2/public/js/views/detail_page/PendingTaskTableLayoutView.js 
0e32ebe7a34062f1e525daccc6ddda59705035f0 
  dashboardv2/public/js/views/dev_debug/DebugMetricsLayoutView.js 
375d551c2f6629ae454226437595a4021a0a8b43 
  dashboardv2/public/js/views/graph/LineageLayoutView.js 
5ad657e2552247b263c9bd5b2d10f4304de72b95 
  dashboardv2/public/js/views/import/ImportLayoutView.js 
88d553c6f0f2d9fed2823e39f7260e0b390cfc8c 
  dashboardv2/public/js/views/site/DebugMetricsTableLayoutView.js 
407e489adb93599e54af4bc51a36cb583c3706f1 
  dashboardv2/public/js/views/site/Header.js 
ffb582ed4bbf80775c15a52a56f3231bebd0e5a8 
  dashboardv2/public/js/views/site/MetricsUIInfoView.js 
f46b5b84f57b5018e5d4b1d1a675907e933e0c43 
  dashboardv2/public/js/views/site/SideNavLayoutView.js 
e0f717a24cff8fda6c634f4d0e56784d526528c1 
  dashboardv2/public/js/views/tag/TagAttributeDetailLayoutView.js 
9b8b90fc63a98c5d9b0a13541d7c28afff16378b 
  dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js 
c780deb7d33ee2ee60714ba908fea21c1a032262 
  dashboardv2/public/js/views/tag/TagLayoutView.js 
f40846953913531d13b0272ab68fe19d91dd60c4 
  dashboardv3/package-lock.json 2b00b159e41246e9033466472e69e217cb3a7349 
  dashboardv3/public/css/scss/override.scss 
280afd694d4559cd7cd7a2d0dc6e7cb35071e15a 
  dashboardv3/public/css/scss/tab.scss c164b47440d35482ce222e95408b0b29c514c7de 
  dashboardv3/public/css/scss/table.scss 
121769b18c57df2c74b211e563b17d373860f4b4 
  dashboardv3/public/js/external_lib/atlas-lineage/dist/index.js 
1ff212838e284cbdee092f325f4dad2a6a4c2a33 
  dashboardv3/public/js/main.js 374641ee01b697f9b74d7cc3888fb4e885f1a88e 
  dashboardv3/public/js/router/Router.js 
bd50715576e6084bd0bb71f3a6da6095fa754b17

Re: Review Request 73317: ATLAS-3812: Add schema for Apache Flink

2021-05-14 Thread Josh Yeh via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73317/
---

(Updated May 14, 2021, 3:03 p.m.)


Review request for atlas, Ashutosh Mestry, Pinal Shah, and Sarath Subramanian.


Repository: atlas


Description
---

ATLAS-3812: Add schema for Apache Flink


Diffs (updated)
-

  addons/models/1000-Hadoop/1110-flink_model.json PRE-CREATION 
  dev-support/atlas-docker/scripts/atlas-build.sh 
e53ebbba98b7392e8b33cd55d2c5caa3628338f6 


Diff: https://reviews.apache.org/r/73317/diff/2/

Changes: https://reviews.apache.org/r/73317/diff/1-2/


Testing
---

Tested on my CDH cluster with flink example wordcount streaming job.


File Attachments


Screen Shot 2021-04-30 at 12.38.27 AM.png
  
https://reviews.apache.org/media/uploaded/files/2021/04/30/2ff59445-7237-4be1-a1a0-b6db70bc7827__Screen_Shot_2021-04-30_at_12.38.27_AM.png


Thanks,

Josh Yeh

Re: Review Request 73317: ATLAS-3812: Add schema for Apache Flink

2021-05-14 Thread Nixon Rodrigues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73317/#review222994
---




addons/models/1000-Hadoop/1110-flink_model.json
Lines 9 (patched)


no need to remove SuperType Process,
remove inputs and outputs attributes from attributeDefs since they are 
inherited from Process Type. 
https://github.com/apache/atlas/blob/master/addons/models/-Area0/0010-base_model.json#L194


- Nixon Rodrigues


On April 30, 2021, 7:39 a.m., Josh Yeh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73317/
> ---
> 
> (Updated April 30, 2021, 7:39 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-3812: Add schema for Apache Flink
> 
> 
> Diffs
> -
> 
>   addons/models/1000-Hadoop/1110-flink_model.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73317/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on my CDH cluster with flink example wordcount streaming job.
> 
> 
> File Attachments
> 
> 
> Screen Shot 2021-04-30 at 12.38.27 AM.png
>   
> https://reviews.apache.org/media/uploaded/files/2021/04/30/2ff59445-7237-4be1-a1a0-b6db70bc7827__Screen_Shot_2021-04-30_at_12.38.27_AM.png
> 
> 
> Thanks,
> 
> Josh Yeh
> 
>

Re: Review Request 73317: ATLAS-3812: Add schema for Apache Flink

2021-05-13 Thread Josh Yeh via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73317/#review222993
---




addons/models/1000-Hadoop/1110-flink_model.json
Lines 9 (patched)


With https://github.com/apache/atlas/commit/92fdf29, we need to remove this 
field


- Josh Yeh


On April 30, 2021, 7:39 a.m., Josh Yeh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73317/
> ---
> 
> (Updated April 30, 2021, 7:39 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-3812: Add schema for Apache Flink
> 
> 
> Diffs
> -
> 
>   addons/models/1000-Hadoop/1110-flink_model.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73317/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on my CDH cluster with flink example wordcount streaming job.
> 
> 
> File Attachments
> 
> 
> Screen Shot 2021-04-30 at 12.38.27 AM.png
>   
> https://reviews.apache.org/media/uploaded/files/2021/04/30/2ff59445-7237-4be1-a1a0-b6db70bc7827__Screen_Shot_2021-04-30_at_12.38.27_AM.png
> 
> 
> Thanks,
> 
> Josh Yeh
> 
>

Re: Review Request 73317: ATLAS-3812: Add schema for Apache Flink

2021-05-10 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73317/#review222974
---




addons/models/1000-Hadoop/1110-flink_model.json
Lines 2 (patched)


remove empty entity types - enumDefs, structDefs, classificationDefs, 
relationshipDefs



addons/models/1000-Hadoop/1110-flink_model.json
Lines 47 (patched)


parent supertype already contains inputs/outputs as relationship attribute. 
This will possibly conflict with those attribute. Consider renaming 
inputs/outputs


- Sarath Subramanian


On April 30, 2021, 12:39 a.m., Josh Yeh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73317/
> ---
> 
> (Updated April 30, 2021, 12:39 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-3812: Add schema for Apache Flink
> 
> 
> Diffs
> -
> 
>   addons/models/1000-Hadoop/1110-flink_model.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73317/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on my CDH cluster with flink example wordcount streaming job.
> 
> 
> File Attachments
> 
> 
> Screen Shot 2021-04-30 at 12.38.27 AM.png
>   
> https://reviews.apache.org/media/uploaded/files/2021/04/30/2ff59445-7237-4be1-a1a0-b6db70bc7827__Screen_Shot_2021-04-30_at_12.38.27_AM.png
> 
> 
> Thanks,
> 
> Josh Yeh
> 
>

Re: Review Request 73317: ATLAS-3812: Add schema for Apache Flink

2021-05-10 Thread Ashutosh Mestry via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73317/#review222968
---




addons/models/1000-Hadoop/1110-flink_model.json
Lines 46 (patched)


Please split this model in 2 different entities. One could be application 
and other should be process. This will help with rendering of linage and other 
features.


- Ashutosh Mestry


On April 30, 2021, 7:39 a.m., Josh Yeh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73317/
> ---
> 
> (Updated April 30, 2021, 7:39 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-3812: Add schema for Apache Flink
> 
> 
> Diffs
> -
> 
>   addons/models/1000-Hadoop/1110-flink_model.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73317/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on my CDH cluster with flink example wordcount streaming job.
> 
> 
> File Attachments
> 
> 
> Screen Shot 2021-04-30 at 12.38.27 AM.png
>   
> https://reviews.apache.org/media/uploaded/files/2021/04/30/2ff59445-7237-4be1-a1a0-b6db70bc7827__Screen_Shot_2021-04-30_at_12.38.27_AM.png
> 
> 
> Thanks,
> 
> Josh Yeh
> 
>

Review Request 73317: ATLAS-3812: Add schema for Apache Flink

2021-04-30 Thread Josh Yeh via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73317/
---

Review request for atlas, Ashutosh Mestry and Sarath Subramanian.


Repository: atlas


Description
---

ATLAS-3812: Add schema for Apache Flink


Diffs
-

  addons/models/1000-Hadoop/1110-flink_model.json PRE-CREATION 


Diff: https://reviews.apache.org/r/73317/diff/1/


Testing
---

Tested on my CDH cluster with flink example wordcount streaming job.


File Attachments


Screen Shot 2021-04-30 at 12.38.27 AM.png
  
https://reviews.apache.org/media/uploaded/files/2021/04/30/2ff59445-7237-4be1-a1a0-b6db70bc7827__Screen_Shot_2021-04-30_at_12.38.27_AM.png


Thanks,

Josh Yeh