Re: Review Request 73358: ATLAS-4288: [Atlas: Glossary Term Bulk Import] Will all the data populated, while performing bulk import, PreferredToTerms relationship alone is not created

2021-05-18 Thread Dharshana MK 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73358/#review223007
---


Ship it!




Ship It!

- Dharshana MK


On May 18, 2021, 6:11 a.m., Sidharth Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73358/
> ---
> 
> (Updated May 18, 2021, 6:11 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4288
> https://issues.apache.org/jira/browse/ATLAS-4288
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-4288: Added code to create PreferredToTerms relationships when it 
> exists alone
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 
> ee306c6b0 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 
> fa02c8eb9 
> 
> 
> Diff: https://reviews.apache.org/r/73358/diff/2/
> 
> 
> Testing
> ---
> 
> Manually tested. Changed code to take care of preferredToTerms relation when 
> it exists without any other relations. Below it has also self-reference so 
> now its throwing error for self reference and then creating the remaining 
> relations successfully. Check below error messages and response json.
> 
> 
> Response json:
> 
> {
> "failedImportInfoList": [
> 
> { "parentObjectName": "dharshmk_11", "childObjectName": "term_1", 
> "importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant 
> have a relationship with self" }
> ,
> 
> { "parentObjectName": "dharshmk_11", "childObjectName": "term_2", 
> "importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant 
> have a relationship with self" }
> ,
> 
> { "parentObjectName": "dharshmk_11", "childObjectName": "term_3", 
> "importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant 
> have a relationship with self" }
> ,
> 
> { "parentObjectName": "dharshmk_11", "childObjectName": "term_4", 
> "importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant 
> have a relationship with self" }
> ,
> 
> { "parentObjectName": "dharshmk_11", "childObjectName": "term_5", 
> "importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant 
> have a relationship with self" }
> ,
> 
> { "parentObjectName": "dharshmk_11", "childObjectName": "term_6", 
> "importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant 
> have a relationship with self" }
> ,
> 
> { "parentObjectName": "dharshmk_11", "childObjectName": "term_7", 
> "importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant 
> have a relationship with self" }
> ,
> 
> { "parentObjectName": "dharshmk_11", "childObjectName": "term_8", 
> "importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant 
> have a relationship with self" }
> ,
> 
> { "parentObjectName": "dharshmk_11", "childObjectName": "term_9", 
> "importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant 
> have a relationship with self" }
> ,
> 
> { "parentObjectName": "dharshmk_11", "childObjectName": "term_10", 
> "importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant 
> have a relationship with self" }
> ,
> 
> { "parentObjectName": "dharshmk_11", "childObjectName": "term_11", 
> "importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant 
> have a relationship with self" }
> ,
> 
> { "parentObjectName": "dharshmk_11", "childObjectName": "term_12", 
> "importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant 
> have a relationship with self" }
> ,
> 
> { "parentObjectName": "dharshmk_11", "childObjectName": "term_13", 
> "importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant 
> have a relationship with self" }
> ],
> "successImportInfoList": [
> 
> { "parentObjectName": "dharshmk_11", "childObjectName": "term_1", 
> "importStatus": "SUCCESS", "remarks": 
> "{\"termGuid\":\"a83cf35d-22f5-4b4c-8d4f-1d658c85b0ae\",\"qualifiedName\":\"term_1@dharshmk_11\"}
> "
> },
> 
> { "parentObjectName": "dharshmk_11", "childObjectName": "term_2", 
> "importStatus": "SUCCESS", "remarks": 
> "{\"termGuid\":\"77d08bd2-9cff-489e-9240-50f2c0f68d89\",\"qualifiedName\":\"term_2@dharshmk_11\"}
> "
> },
> 
> { "parentObjectName": "dharshmk_11", "childObjectName": "term_3", 
> "importStatus": "SUCCESS", "remarks": 
> "{\"termGuid\":\"10563ed5-c1fb-438e-bead-b6f0ccbd4d44\",\"qualifiedName\":\"term_3@dharshmk_11\"}
> "
> },
> 
> { "parentObjectName": "dharshmk_11", "childObjectName": "term_4", 
> "importStatus": "SUCCESS", "remarks": 
> "{\"termGuid\":\"0f1ec608-4692-4041-b7d4-e270032f2bac\",\"qualifiedName\":\"term_4@dharshmk_11\"}
> "
> },
> 
> { "parentObjectName": "dharshmk

Re: Review Request 73358: ATLAS-4288: [Atlas: Glossary Term Bulk Import] Will all the data populated, while performing bulk import, PreferredToTerms relationship alone is not created

2021-05-17 Thread Sidharth Mishra 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73358/
---

(Updated May 18, 2021, 6:11 a.m.)


Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and 
Sarath Subramanian.


Bugs: ATLAS-4288
https://issues.apache.org/jira/browse/ATLAS-4288


Repository: atlas


Description
---

ATLAS-4288: Added code to create PreferredToTerms relationships when it exists 
alone


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 
ee306c6b0 
  repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 
fa02c8eb9 


Diff: https://reviews.apache.org/r/73358/diff/2/

Changes: https://reviews.apache.org/r/73358/diff/1-2/


Testing
---

Manually tested. Changed code to take care of preferredToTerms relation when it 
exists without any other relations. Below it has also self-reference so now its 
throwing error for self reference and then creating the remaining relations 
successfully. Check below error messages and response json.


Response json:

{
"failedImportInfoList": [

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_1", 
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have 
a relationship with self" }
,

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_2", 
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have 
a relationship with self" }
,

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_3", 
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have 
a relationship with self" }
,

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_4", 
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have 
a relationship with self" }
,

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_5", 
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have 
a relationship with self" }
,

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_6", 
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have 
a relationship with self" }
,

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_7", 
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have 
a relationship with self" }
,

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_8", 
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have 
a relationship with self" }
,

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_9", 
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have 
a relationship with self" }
,

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_10", 
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have 
a relationship with self" }
,

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_11", 
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have 
a relationship with self" }
,

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_12", 
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have 
a relationship with self" }
,

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_13", 
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have 
a relationship with self" }
],
"successImportInfoList": [

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_1", 
"importStatus": "SUCCESS", "remarks": 
"{\"termGuid\":\"a83cf35d-22f5-4b4c-8d4f-1d658c85b0ae\",\"qualifiedName\":\"term_1@dharshmk_11\"}
"
},

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_2", 
"importStatus": "SUCCESS", "remarks": 
"{\"termGuid\":\"77d08bd2-9cff-489e-9240-50f2c0f68d89\",\"qualifiedName\":\"term_2@dharshmk_11\"}
"
},

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_3", 
"importStatus": "SUCCESS", "remarks": 
"{\"termGuid\":\"10563ed5-c1fb-438e-bead-b6f0ccbd4d44\",\"qualifiedName\":\"term_3@dharshmk_11\"}
"
},

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_4", 
"importStatus": "SUCCESS", "remarks": 
"{\"termGuid\":\"0f1ec608-4692-4041-b7d4-e270032f2bac\",\"qualifiedName\":\"term_4@dharshmk_11\"}
"
},

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_5", 
"importStatus": "SUCCESS", "remarks": 
"{\"termGuid\":\"30728c5b-99f6-4f69-a54a-2b0d4d49acef\",\"qualifiedName\":\"term_5@dharshmk_11\"}
"
},

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_6", 
"importStatus": "SUCCESS", "remarks": 
"{\"termGuid\":\"b075398a-f845-42ca-90b0-e1362c5757c4\",\"qualifiedName\":\"term_6@dharshmk_11\"}
"
},

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_7", 
"importStatus": "SUCCESS", "remarks": 
"{\"termGuid\":\"0c75f006-9d29-49db-96bb-b9c7738eb1

Re: Review Request 73358: ATLAS-4288: [Atlas: Glossary Term Bulk Import] Will all the data populated, while performing bulk import, PreferredToTerms relationship alone is not created

2021-05-17 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73358/#review223004
---


Fix it, then Ship it!





repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
Lines 729 (patched)


"Invalid relationship specified for Term. Term cannot have a relationship 
with self"


- Sarath Subramanian


On May 17, 2021, 10:45 p.m., Sidharth Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73358/
> ---
> 
> (Updated May 17, 2021, 10:45 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4288
> https://issues.apache.org/jira/browse/ATLAS-4288
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-4288: Added code to create PreferredToTerms relationships when it 
> exists alone
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 
> ee306c6b0 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 
> fa02c8eb9 
> 
> 
> Diff: https://reviews.apache.org/r/73358/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested. Changed code to take care of preferredToTerms relation when 
> it exists without any other relations. Below it has also self-reference so 
> now its throwing error for self reference and then creating the remaining 
> relations successfully. Check below error messages and response json.
> 
> 
> Response json:
> 
> {
> "failedImportInfoList": [
> 
> { "parentObjectName": "dharshmk_11", "childObjectName": "term_1", 
> "importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant 
> have a relationship with self" }
> ,
> 
> { "parentObjectName": "dharshmk_11", "childObjectName": "term_2", 
> "importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant 
> have a relationship with self" }
> ,
> 
> { "parentObjectName": "dharshmk_11", "childObjectName": "term_3", 
> "importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant 
> have a relationship with self" }
> ,
> 
> { "parentObjectName": "dharshmk_11", "childObjectName": "term_4", 
> "importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant 
> have a relationship with self" }
> ,
> 
> { "parentObjectName": "dharshmk_11", "childObjectName": "term_5", 
> "importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant 
> have a relationship with self" }
> ,
> 
> { "parentObjectName": "dharshmk_11", "childObjectName": "term_6", 
> "importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant 
> have a relationship with self" }
> ,
> 
> { "parentObjectName": "dharshmk_11", "childObjectName": "term_7", 
> "importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant 
> have a relationship with self" }
> ,
> 
> { "parentObjectName": "dharshmk_11", "childObjectName": "term_8", 
> "importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant 
> have a relationship with self" }
> ,
> 
> { "parentObjectName": "dharshmk_11", "childObjectName": "term_9", 
> "importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant 
> have a relationship with self" }
> ,
> 
> { "parentObjectName": "dharshmk_11", "childObjectName": "term_10", 
> "importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant 
> have a relationship with self" }
> ,
> 
> { "parentObjectName": "dharshmk_11", "childObjectName": "term_11", 
> "importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant 
> have a relationship with self" }
> ,
> 
> { "parentObjectName": "dharshmk_11", "childObjectName": "term_12", 
> "importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant 
> have a relationship with self" }
> ,
> 
> { "parentObjectName": "dharshmk_11", "childObjectName": "term_13", 
> "importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant 
> have a relationship with self" }
> ],
> "successImportInfoList": [
> 
> { "parentObjectName": "dharshmk_11", "childObjectName": "term_1", 
> "importStatus": "SUCCESS", "remarks": 
> "{\"termGuid\":\"a83cf35d-22f5-4b4c-8d4f-1d658c85b0ae\",\"qualifiedName\":\"term_1@dharshmk_11\"}
> "
> },
> 
> { "parentObjectName": "dharshmk_11", "childObjectName": "term_2", 
> "importStatus": "SUCCESS", "remarks": 
> "{\"termGuid\":\"77d08bd2-9cff-489e-9240-50f2c0f68d89\",\"qualifiedName\":\"term_2@dharshmk_11\"}
> "
> },
> 
> { "parentObjectName": "dharshmk_11", "childObjectName": "term_3", 
> "importStatus": "SUCCESS", "remarks": 
> "{\"termGuid\":\"10563ed5-c1fb-438e-bead-b6f0ccbd4d44\",\"qualifiedName\":\"term_3@dharshmk_11\"}
> "
> },
> 
> {

Review Request 73358: ATLAS-4288: [Atlas: Glossary Term Bulk Import] Will all the data populated, while performing bulk import, PreferredToTerms relationship alone is not created

2021-05-17 Thread Sidharth Mishra 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73358/
---

Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and 
Sarath Subramanian.


Bugs: ATLAS-4288
https://issues.apache.org/jira/browse/ATLAS-4288


Repository: atlas


Description
---

ATLAS-4288: Added code to create PreferredToTerms relationships when it exists 
alone


Diffs
-

  intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 
ee306c6b0 
  repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 
fa02c8eb9 


Diff: https://reviews.apache.org/r/73358/diff/1/


Testing
---

Manually tested. Changed code to take care of preferredToTerms relation when it 
exists without any other relations. Below it has also self-reference so now its 
throwing error for self reference and then creating the remaining relations 
successfully. Check below error messages and response json.


Response json:

{
"failedImportInfoList": [

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_1", 
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have 
a relationship with self" }
,

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_2", 
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have 
a relationship with self" }
,

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_3", 
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have 
a relationship with self" }
,

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_4", 
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have 
a relationship with self" }
,

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_5", 
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have 
a relationship with self" }
,

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_6", 
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have 
a relationship with self" }
,

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_7", 
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have 
a relationship with self" }
,

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_8", 
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have 
a relationship with self" }
,

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_9", 
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have 
a relationship with self" }
,

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_10", 
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have 
a relationship with self" }
,

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_11", 
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have 
a relationship with self" }
,

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_12", 
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have 
a relationship with self" }
,

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_13", 
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have 
a relationship with self" }
],
"successImportInfoList": [

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_1", 
"importStatus": "SUCCESS", "remarks": 
"{\"termGuid\":\"a83cf35d-22f5-4b4c-8d4f-1d658c85b0ae\",\"qualifiedName\":\"term_1@dharshmk_11\"}
"
},

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_2", 
"importStatus": "SUCCESS", "remarks": 
"{\"termGuid\":\"77d08bd2-9cff-489e-9240-50f2c0f68d89\",\"qualifiedName\":\"term_2@dharshmk_11\"}
"
},

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_3", 
"importStatus": "SUCCESS", "remarks": 
"{\"termGuid\":\"10563ed5-c1fb-438e-bead-b6f0ccbd4d44\",\"qualifiedName\":\"term_3@dharshmk_11\"}
"
},

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_4", 
"importStatus": "SUCCESS", "remarks": 
"{\"termGuid\":\"0f1ec608-4692-4041-b7d4-e270032f2bac\",\"qualifiedName\":\"term_4@dharshmk_11\"}
"
},

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_5", 
"importStatus": "SUCCESS", "remarks": 
"{\"termGuid\":\"30728c5b-99f6-4f69-a54a-2b0d4d49acef\",\"qualifiedName\":\"term_5@dharshmk_11\"}
"
},

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_6", 
"importStatus": "SUCCESS", "remarks": 
"{\"termGuid\":\"b075398a-f845-42ca-90b0-e1362c5757c4\",\"qualifiedName\":\"term_6@dharshmk_11\"}
"
},

{ "parentObjectName": "dharshmk_11", "childObjectName": "term_7", 
"importStatus": "SUCCESS", "remarks": 
"{\"termGuid\":\"0c75f006-9d29-49db-96bb-b9c7738eb155\",\"qualifiedName\":\"term_7@dharshmk_11\"}
"
},

{ "parentObjectName": "dharshmk_11", "childObjec