Re: Review Request 74075: UI: Add classification button appears for deleted hive_columns in Schema Tab of hive_table entity details page.

2022-08-03 Thread Prasad Pawar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74075/#review224595
---


Ship it!




Ship It!

- Prasad Pawar


On Aug. 3, 2022, 8:23 a.m., Farhan Khan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74075/
> ---
> 
> (Updated Aug. 3, 2022, 8:23 a.m.)
> 
> 
> Review request for atlas and Prasad Pawar.
> 
> 
> Bugs: ATLAS-4600
> https://issues.apache.org/jira/browse/ATLAS-4600
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> If user navigate to a deleted hive_table entity's Schema tab, it is possible 
> to get an 'add classification' button.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/views/schema/SchemaLayoutView.js ab776e9cf 
>   dashboardv3/public/js/views/schema/SchemaLayoutView.js 79ddc573b 
> 
> 
> Diff: https://reviews.apache.org/r/74075/diff/2/
> 
> 
> Testing
> ---
> 
> Manually tested on local for the above mentioned scenario.
> 
> 
> Thanks,
> 
> Farhan Khan
> 
>



Re: Review Request 74075: UI: Add classification button appears for deleted hive_columns in Schema Tab of hive_table entity details page.

2022-08-03 Thread Farhan Khan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74075/
---

(Updated Aug. 3, 2022, 8:23 a.m.)


Review request for atlas and Prasad Pawar.


Bugs: ATLAS-4600
https://issues.apache.org/jira/browse/ATLAS-4600


Repository: atlas


Description
---

If user navigate to a deleted hive_table entity's Schema tab, it is possible to 
get an 'add classification' button.


Diffs (updated)
-

  dashboardv2/public/js/views/schema/SchemaLayoutView.js ab776e9cf 
  dashboardv3/public/js/views/schema/SchemaLayoutView.js 79ddc573b 


Diff: https://reviews.apache.org/r/74075/diff/2/

Changes: https://reviews.apache.org/r/74075/diff/1-2/


Testing
---

Manually tested on local for the above mentioned scenario.


Thanks,

Farhan Khan



Review Request 74075: UI: Add classification button appears for deleted hive_columns in Schema Tab of hive_table entity details page.

2022-08-01 Thread Farhan Khan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74075/
---

Review request for atlas and Prasad Pawar.


Bugs: ATLAS-4600
https://issues.apache.org/jira/browse/ATLAS-4600


Repository: atlas


Description
---

If user navigate to a deleted hive_table entity's Schema tab, it is possible to 
get an 'add classification' button.


Diffs
-

  dashboardv2/public/js/views/schema/SchemaLayoutView.js ab776e9cf 
  dashboardv3/public/js/views/schema/SchemaLayoutView.js 79ddc573b 


Diff: https://reviews.apache.org/r/74075/diff/1/


Testing
---

Manually tested on local for the above mentioned scenario.


Thanks,

Farhan Khan