Re: Review Request 74103: ATLAS-4669 : Atlas - Upgrade Junit to 4.13.2

2022-09-08 Thread Pinal Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74103/#review224655
---


Ship it!




Ship It!

- Pinal Shah


On Sept. 8, 2022, 11:27 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74103/
> ---
> 
> (Updated Sept. 8, 2022, 11:27 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab and Pinal Shah.
> 
> 
> Bugs: ATLAS-4669
> https://issues.apache.org/jira/browse/ATLAS-4669
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> currently Junit version is 4.13.1
> 
> 
> Diffs
> -
> 
>   addons/hbase-bridge/pom.xml a6ed51421 
>   pom.xml a5d4b1f9e 
> 
> 
> Diff: https://reviews.apache.org/r/74103/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean -DskipTests package -Pdist,embedded-hbase-solr
> mvn clean install -DskipTests -Drat.skip
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1210/consoleFull
> 
> 
> Thanks,
> 
> chaitali
> 
>

Re: Review Request 74103: ATLAS-4669 : Atlas - Upgrade Junit to 4.13.2

2022-09-08 Thread chaitali 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74103/
---

(Updated Sept. 8, 2022, 11:27 a.m.)


Review request for atlas, Jayendra Parab and Pinal Shah.


Bugs: ATLAS-4669
https://issues.apache.org/jira/browse/ATLAS-4669


Repository: atlas


Description
---

currently Junit version is 4.13.1


Diffs (updated)
-

  addons/hbase-bridge/pom.xml a6ed51421 
  pom.xml a5d4b1f9e 


Diff: https://reviews.apache.org/r/74103/diff/3/

Changes: https://reviews.apache.org/r/74103/diff/2-3/


Testing
---

mvn clean -DskipTests package -Pdist,embedded-hbase-solr
mvn clean install -DskipTests -Drat.skip
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1210/consoleFull


Thanks,

chaitali

Re: Review Request 74103: ATLAS-4669 : Atlas - Upgrade Junit to 4.13.2

2022-09-08 Thread Pinal Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74103/#review224654
---




addons/hbase-bridge/pom.xml
Line 168 (original), 168 (patched)


Can we add placeholder of junit.version instead of 4.13.2?


- Pinal Shah


On Sept. 8, 2022, 10:01 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74103/
> ---
> 
> (Updated Sept. 8, 2022, 10:01 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab and Pinal Shah.
> 
> 
> Bugs: ATLAS-4669
> https://issues.apache.org/jira/browse/ATLAS-4669
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> currently Junit version is 4.13.1
> 
> 
> Diffs
> -
> 
>   addons/hbase-bridge/pom.xml a6ed51421 
>   pom.xml a5d4b1f9e 
> 
> 
> Diff: https://reviews.apache.org/r/74103/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean -DskipTests package -Pdist,embedded-hbase-solr
> mvn clean install -DskipTests -Drat.skip
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1210/consoleFull
> 
> 
> Thanks,
> 
> chaitali
> 
>

Re: Review Request 74103: ATLAS-4669 : Atlas - Upgrade Junit to 4.13.2

2022-09-08 Thread Jayendra Parab 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74103/#review224653
---


Ship it!




Ship It!

- Jayendra Parab


On Sept. 8, 2022, 10:01 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74103/
> ---
> 
> (Updated Sept. 8, 2022, 10:01 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab and Pinal Shah.
> 
> 
> Bugs: ATLAS-4669
> https://issues.apache.org/jira/browse/ATLAS-4669
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> currently Junit version is 4.13.1
> 
> 
> Diffs
> -
> 
>   addons/hbase-bridge/pom.xml a6ed51421 
>   pom.xml a5d4b1f9e 
> 
> 
> Diff: https://reviews.apache.org/r/74103/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean -DskipTests package -Pdist,embedded-hbase-solr
> mvn clean install -DskipTests -Drat.skip
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1210/consoleFull
> 
> 
> Thanks,
> 
> chaitali
> 
>

Re: Review Request 74103: ATLAS-4669 : Atlas - Upgrade Junit to 4.13.2

2022-09-08 Thread chaitali 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74103/
---

(Updated Sept. 8, 2022, 10:01 a.m.)


Review request for atlas, Jayendra Parab and Pinal Shah.


Bugs: ATLAS-4669
https://issues.apache.org/jira/browse/ATLAS-4669


Repository: atlas


Description
---

currently Junit version is 4.13.1


Diffs
-

  addons/hbase-bridge/pom.xml a6ed51421 
  pom.xml a5d4b1f9e 


Diff: https://reviews.apache.org/r/74103/diff/2/


Testing (updated)
---

mvn clean -DskipTests package -Pdist,embedded-hbase-solr
mvn clean install -DskipTests -Drat.skip
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1210/consoleFull


Thanks,

chaitali

Re: Review Request 74103: ATLAS-4669 : Atlas - Upgrade Junit to 4.13.2

2022-09-08 Thread chaitali 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74103/
---

(Updated Sept. 8, 2022, 6:47 a.m.)


Review request for atlas, Jayendra Parab and Pinal Shah.


Bugs: ATLAS-4669
https://issues.apache.org/jira/browse/ATLAS-4669


Repository: atlas


Description
---

currently Junit version is 4.13.1


Diffs
-

  addons/hbase-bridge/pom.xml a6ed51421 
  pom.xml a5d4b1f9e 


Diff: https://reviews.apache.org/r/74103/diff/2/


Testing
---

mvn clean -DskipTests package -Pdist,embedded-hbase-solr
mvn clean install -DskipTests -Drat.skip


Thanks,

chaitali