Re: Review Request 74691: ATLAS-4802 : Atlas 'updateTime' parameter is not updated when business metadata is edited.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74691/#review226283
---
Ship it!
Ship It!
- Mandar Ambawane
On Jan. 2, 2024, 10:35 a.m., chaitali wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74691/
> ---
>
> (Updated Jan. 2, 2024, 10:35 a.m.)
>
>
> Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and
> Sheetal Shah.
>
>
> Bugs: ATLAS-4802
> https://issues.apache.org/jira/browse/ATLAS-4802
>
>
> Repository: atlas
>
>
> Description
> ---
>
> When updating the business metadata and Labels on an atlas entity, the
> 'updateTime' system attribute is not changed.
>
> Updates to other aspects, such as technical properties and user defined
> attributes does update the timestamp, but not the business metadata and
> labels.
>
>
> Diffs
> -
>
>
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
> c670740c9
>
>
> Diff: https://reviews.apache.org/r/74691/diff/2/
>
>
> Testing
> ---
>
> update time Without patch
> before business metadata update
>
> "createTime": 1703221384530,
> "updateTime": 1703221386989,
>
> after business metadata update
>
> "createTime": 1703221384530,
> "updateTime": 1703221386989,
>
>
> after applying PATCH
>
> before business metadata update
> "createTime": 1704190056433,
> "updateTime": 1704190059208,
>
> after business metadata update
> "createTime": 1704190056433,
> "updateTime": 1704190523323,
>
> Entire json for GET api on entity before applying patch :
>
> http://localhost:21000/api/atlas/v2/entity/guid/dc1baa88-3a07-4577-9b6b-48982253aa3d
>
> {
> "referredEntities": {
> "a1a27e35-aa0d-472d-8b94-2405d8001a84": {
> "typeName": "Column",
> "attributes": {
> "qualifiedName": "Sales.customer_dim.address@cl1",
> "name": "address",
> "comment": "customer address"
> },
> "guid": "a1a27e35-aa0d-472d-8b94-2405d8001a84",
> "isIncomplete": false,
> "status": "ACTIVE",
> "createdBy": "admin",
> "updatedBy": "admin",
> "createTime": 1704190056433,
> "updateTime": 1704190056433,
> "version": 0,
> "classifications": [
> {
> "typeName": "PII",
> "entityGuid": "a1a27e35-aa0d-472d-8b94-2405d8001a84",
> "entityStatus": "ACTIVE",
> "propagate": true,
> "removePropagationsOnEntityDelete": false
> }
> ],
> "labels": []
> },
> "834ba687-c8f1-4a48-a6a0-ef3ddeadf7ee": {
> "typeName": "Column",
> "attributes": {
> "qualifiedName": "Sales.customer_dim.name@cl1",
> "name": "name",
> "comment": "customer name"
> },
> "guid": "834ba687-c8f1-4a48-a6a0-ef3ddeadf7ee",
> "isIncomplete": false,
> "status": "ACTIVE",
> "createdBy": "admin",
> "updatedBy": "admin",
> "createTime": 1704190056433,
> "updateTime": 1704190056433,
> "version": 0,
> "classifications": [
> {
> "typeName": "PII",
> "entityGuid": "834ba687-c8f1-4a48-a6a0-ef3ddeadf7ee",
> "entityStatus": "ACTIVE",
> "propagate": true,
> "removePropagationsOnEntityDelete": false
> }
> ],
> "labels": []
> },
> "f8ded729-7bad-48dd-9969-c5b36a8d5b9c": {
> "typeName": "Column",
> "attributes": {
> "qualifiedName": "Sales.customer_dim.customer_id@cl1",
> "name": "customer_id",
> "comment": "customer id"
> },
> "guid": "f8ded729-7bad-48dd-9969-c5b36a8d5b9c",
> "isIncomplete": false,
> "status": "ACTIVE",
> "createdBy": "admin",
> "updatedBy": "admin",
> "createTime": 1704190056433,
> "updateTime": 1704190056433,
> "version": 0,
> "classifications": [
> {
> "typeName": "PII",
> "entityGuid": "f8ded729-7bad-48dd-9969-c5b36a8d5b9c",
> "entityStatus": "ACTIVE",
> "propagate": true,
> "removePropagationsOnEntityDelete": false
> }
>
Re: Review Request 74691: ATLAS-4802 : Atlas 'updateTime' parameter is not updated when business metadata is edited.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74691/#review226281
---
Ship it!
Ship It!
- Sheetal Shah
On Jan. 2, 2024, 4:05 p.m., chaitali wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74691/
> ---
>
> (Updated Jan. 2, 2024, 4:05 p.m.)
>
>
> Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and
> Sheetal Shah.
>
>
> Bugs: ATLAS-4802
> https://issues.apache.org/jira/browse/ATLAS-4802
>
>
> Repository: atlas
>
>
> Description
> ---
>
> When updating the business metadata and Labels on an atlas entity, the
> 'updateTime' system attribute is not changed.
>
> Updates to other aspects, such as technical properties and user defined
> attributes does update the timestamp, but not the business metadata and
> labels.
>
>
> Diffs
> -
>
>
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
> c670740c9
>
>
> Diff: https://reviews.apache.org/r/74691/diff/2/
>
>
> Testing
> ---
>
> update time Without patch
> before business metadata update
>
> "createTime": 1703221384530,
> "updateTime": 1703221386989,
>
> after business metadata update
>
> "createTime": 1703221384530,
> "updateTime": 1703221386989,
>
>
> after applying PATCH
>
> before business metadata update
> "createTime": 1704190056433,
> "updateTime": 1704190059208,
>
> after business metadata update
> "createTime": 1704190056433,
> "updateTime": 1704190523323,
>
> Entire json for GET api on entity before applying patch :
>
> http://localhost:21000/api/atlas/v2/entity/guid/dc1baa88-3a07-4577-9b6b-48982253aa3d
>
> {
> "referredEntities": {
> "a1a27e35-aa0d-472d-8b94-2405d8001a84": {
> "typeName": "Column",
> "attributes": {
> "qualifiedName": "Sales.customer_dim.address@cl1",
> "name": "address",
> "comment": "customer address"
> },
> "guid": "a1a27e35-aa0d-472d-8b94-2405d8001a84",
> "isIncomplete": false,
> "status": "ACTIVE",
> "createdBy": "admin",
> "updatedBy": "admin",
> "createTime": 1704190056433,
> "updateTime": 1704190056433,
> "version": 0,
> "classifications": [
> {
> "typeName": "PII",
> "entityGuid": "a1a27e35-aa0d-472d-8b94-2405d8001a84",
> "entityStatus": "ACTIVE",
> "propagate": true,
> "removePropagationsOnEntityDelete": false
> }
> ],
> "labels": []
> },
> "834ba687-c8f1-4a48-a6a0-ef3ddeadf7ee": {
> "typeName": "Column",
> "attributes": {
> "qualifiedName": "Sales.customer_dim.name@cl1",
> "name": "name",
> "comment": "customer name"
> },
> "guid": "834ba687-c8f1-4a48-a6a0-ef3ddeadf7ee",
> "isIncomplete": false,
> "status": "ACTIVE",
> "createdBy": "admin",
> "updatedBy": "admin",
> "createTime": 1704190056433,
> "updateTime": 1704190056433,
> "version": 0,
> "classifications": [
> {
> "typeName": "PII",
> "entityGuid": "834ba687-c8f1-4a48-a6a0-ef3ddeadf7ee",
> "entityStatus": "ACTIVE",
> "propagate": true,
> "removePropagationsOnEntityDelete": false
> }
> ],
> "labels": []
> },
> "f8ded729-7bad-48dd-9969-c5b36a8d5b9c": {
> "typeName": "Column",
> "attributes": {
> "qualifiedName": "Sales.customer_dim.customer_id@cl1",
> "name": "customer_id",
> "comment": "customer id"
> },
> "guid": "f8ded729-7bad-48dd-9969-c5b36a8d5b9c",
> "isIncomplete": false,
> "status": "ACTIVE",
> "createdBy": "admin",
> "updatedBy": "admin",
> "createTime": 1704190056433,
> "updateTime": 1704190056433,
> "version": 0,
> "classifications": [
> {
> "typeName": "PII",
> "entityGuid": "f8ded729-7bad-48dd-9969-c5b36a8d5b9c",
> "entityStatus": "ACTIVE",
> "propagate": true,
> "removePropagationsOnEntityDelete": false
> }
> ],
Re: Review Request 74691: ATLAS-4802 : Atlas 'updateTime' parameter is not updated when business metadata is edited.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74691/
---
(Updated Jan. 2, 2024, 10:35 a.m.)
Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and
Sheetal Shah.
Bugs: ATLAS-4802
https://issues.apache.org/jira/browse/ATLAS-4802
Repository: atlas
Description
---
When updating the business metadata and Labels on an atlas entity, the
'updateTime' system attribute is not changed.
Updates to other aspects, such as technical properties and user defined
attributes does update the timestamp, but not the business metadata and labels.
Diffs
-
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
c670740c9
Diff: https://reviews.apache.org/r/74691/diff/2/
Testing (updated)
---
update time Without patch
before business metadata update
"createTime": 1703221384530,
"updateTime": 1703221386989,
after business metadata update
"createTime": 1703221384530,
"updateTime": 1703221386989,
after applying PATCH
before business metadata update
"createTime": 1704190056433,
"updateTime": 1704190059208,
after business metadata update
"createTime": 1704190056433,
"updateTime": 1704190523323,
Entire json for GET api on entity before applying patch :
http://localhost:21000/api/atlas/v2/entity/guid/dc1baa88-3a07-4577-9b6b-48982253aa3d
{
"referredEntities": {
"a1a27e35-aa0d-472d-8b94-2405d8001a84": {
"typeName": "Column",
"attributes": {
"qualifiedName": "Sales.customer_dim.address@cl1",
"name": "address",
"comment": "customer address"
},
"guid": "a1a27e35-aa0d-472d-8b94-2405d8001a84",
"isIncomplete": false,
"status": "ACTIVE",
"createdBy": "admin",
"updatedBy": "admin",
"createTime": 1704190056433,
"updateTime": 1704190056433,
"version": 0,
"classifications": [
{
"typeName": "PII",
"entityGuid": "a1a27e35-aa0d-472d-8b94-2405d8001a84",
"entityStatus": "ACTIVE",
"propagate": true,
"removePropagationsOnEntityDelete": false
}
],
"labels": []
},
"834ba687-c8f1-4a48-a6a0-ef3ddeadf7ee": {
"typeName": "Column",
"attributes": {
"qualifiedName": "Sales.customer_dim.name@cl1",
"name": "name",
"comment": "customer name"
},
"guid": "834ba687-c8f1-4a48-a6a0-ef3ddeadf7ee",
"isIncomplete": false,
"status": "ACTIVE",
"createdBy": "admin",
"updatedBy": "admin",
"createTime": 1704190056433,
"updateTime": 1704190056433,
"version": 0,
"classifications": [
{
"typeName": "PII",
"entityGuid": "834ba687-c8f1-4a48-a6a0-ef3ddeadf7ee",
"entityStatus": "ACTIVE",
"propagate": true,
"removePropagationsOnEntityDelete": false
}
],
"labels": []
},
"f8ded729-7bad-48dd-9969-c5b36a8d5b9c": {
"typeName": "Column",
"attributes": {
"qualifiedName": "Sales.customer_dim.customer_id@cl1",
"name": "customer_id",
"comment": "customer id"
},
"guid": "f8ded729-7bad-48dd-9969-c5b36a8d5b9c",
"isIncomplete": false,
"status": "ACTIVE",
"createdBy": "admin",
"updatedBy": "admin",
"createTime": 1704190056433,
"updateTime": 1704190056433,
"version": 0,
"classifications": [
{
"typeName": "PII",
"entityGuid": "f8ded729-7bad-48dd-9969-c5b36a8d5b9c",
"entityStatus": "ACTIVE",
"propagate": true,
"removePropagationsOnEntityDelete": false
}
],
"labels": []
},
"06f3f56c-8ed7-4930-93b3-8a4b6f81c505": {
"typeName": "StorageDesc",
"attributes": {
"qualifiedName": "sd:hdfs://host:8000/apps/warehouse/sales@cl1",
"name": "sd:hdfs://host:8000/apps/warehouse/sales"
},
"guid": "06f3f56c-8ed7-4930-93b3-8a4b6f81c505",
"isIncomplete": false,
"status": "ACTIVE",
"createdBy": "admin",
"updatedBy": "admin",
"createTime": 1704190055353,
"updateTime": 1704190058427,
Re: Review Request 74691: ATLAS-4802 : Atlas 'updateTime' parameter is not updated when business metadata is edited.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74691/ --- (Updated Jan. 2, 2024, 8:35 a.m.) Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and Sheetal Shah. Bugs: ATLAS-4802 https://issues.apache.org/jira/browse/ATLAS-4802 Repository: atlas Description --- When updating the business metadata and Labels on an atlas entity, the 'updateTime' system attribute is not changed. Updates to other aspects, such as technical properties and user defined attributes does update the timestamp, but not the business metadata and labels. Diffs - repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java c670740c9 Diff: https://reviews.apache.org/r/74691/diff/2/ Testing (updated) --- PC successful Thanks, chaitali
Re: Review Request 74691: ATLAS-4802 : Atlas 'updateTime' parameter is not updated when business metadata is edited.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74691/ --- (Updated Jan. 2, 2024, 8:33 a.m.) Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and Sheetal Shah. Bugs: ATLAS-4802 https://issues.apache.org/jira/browse/ATLAS-4802 Repository: atlas Description --- When updating the business metadata and Labels on an atlas entity, the 'updateTime' system attribute is not changed. Updates to other aspects, such as technical properties and user defined attributes does update the timestamp, but not the business metadata and labels. Diffs (updated) - repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java c670740c9 Diff: https://reviews.apache.org/r/74691/diff/2/ Changes: https://reviews.apache.org/r/74691/diff/1-2/ Testing --- Thanks, chaitali
Re: Review Request 74691: ATLAS-4802 : Atlas 'updateTime' parameter is not updated when business metadata is edited.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74691/ --- (Updated Jan. 2, 2024, 8:28 a.m.) Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and Sheetal Shah. Bugs: ATLAS-4802 https://issues.apache.org/jira/browse/ATLAS-4802 Repository: atlas Description --- When updating the business metadata and Labels on an atlas entity, the 'updateTime' system attribute is not changed. Updates to other aspects, such as technical properties and user defined attributes does update the timestamp, but not the business metadata and labels. Diffs - repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java c670740c9 Diff: https://reviews.apache.org/r/74691/diff/1/ Testing --- Thanks, chaitali
