----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36724/#review93087 -----------------------------------------------------------
client/src/main/java/org/apache/atlas/ApplicationProperties.java (line 99) <https://reviews.apache.org/r/36724/#comment147345> +1. LGTM. Minor nit. Please correct indentation in the substituteVars function - Suma Shivaprasad On July 24, 2015, 5:52 a.m., Shwetha GS wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36724/ > ----------------------------------------------------------- > > (Updated July 24, 2015, 5:52 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-80 > https://issues.apache.org/jira/browse/ATLAS-80 > > > Repository: atlas > > > Description > ------- > > Adds support for system variables in properties file. It also adds support > for re-using already defined variable. For example: > atlas.data=/var/data/${user.name}/atlas > atlas.graph.data=${atlas.data}/graph > > Also made sure application.properties is loaded just once > > > Diffs > ----- > > > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/NegativeSSLAndKerberosHiveHookIT.java > 072c36b > > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/SSLAndKerberosHiveHookIT.java > 6fab2ee > client/src/main/java/org/apache/atlas/ApplicationProperties.java > PRE-CREATION > client/src/main/java/org/apache/atlas/AtlasClient.java ff03bc1 > client/src/main/java/org/apache/atlas/PropertiesUtil.java bc56cbf > client/src/main/java/org/apache/atlas/security/SecureClientUtils.java > eb55b4a > client/src/main/java/org/apache/atlas/security/SecurityProperties.java > e03ffcc > client/src/test/java/org/apache/atlas/ApplicationPropertiesTest.java > PRE-CREATION > client/src/test/resources/application.properties PRE-CREATION > docs/pom.xml 55f5f8d > pom.xml a8afcc3 > repository/src/main/java/org/apache/atlas/discovery/HiveLineageService.java > 76d94a3 > > repository/src/main/java/org/apache/atlas/repository/graph/TitanGraphProvider.java > d7ed1f1 > src/bin/atlas_start.py 0ad188c > src/conf/application.properties 5c8c59a > src/test/python/scripts/TestMetadata.py 9ca346d > webapp/src/main/java/org/apache/atlas/Main.java 6cdeca8 > > webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java > 80d586b > webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java > b643f13 > webapp/src/main/java/org/apache/atlas/web/listeners/LoginProcessor.java > 5f180f5 > webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java > 16591d8 > webapp/src/test/java/org/apache/atlas/web/listeners/LoginProcessorIT.java > 2148fe2 > > Diff: https://reviews.apache.org/r/36724/diff/ > > > Testing > ------- > > UTs and end to end test > > > Thanks, > > Shwetha GS > >
