[jira] [Commented] (ATLAS-834) Handle exceptions from HiveHook executor.submit()

[Shwetha G S (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15305126#comment-15305126
 ] 

Shwetha G S commented on ATLAS-834:
---

+1

> Handle exceptions from HiveHook executor.submit()
> -
>
> Key: ATLAS-834
> URL: https://issues.apache.org/jira/browse/ATLAS-834
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.6-incubating, 0.7-incubating
>Reporter: Shwetha G S
>Assignee: Suma Shivaprasad
>Priority: Critical
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-834.patch
>
>
> Atlas hive hook uses threadpool with fixed queue size(to restrict memory). In 
> cases of high load, all threads may be busy and queue may be full in which 
> case, threadpool.submit() fails and hive command execution fails. We should 
> ignore this failure(will result in loss of data for atlas, but we don't have 
> any store forward solution) and let the hive command execution complete.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (ATLAS-834) Handle exceptions from HiveHook executor.submit()

[Shwetha G S (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15305126#comment-15305126
 ] 

Shwetha G S edited comment on ATLAS-834 at 5/28/16 2:56 AM:


+1. Thanks Suma


was (Author: shwethags):
+1

> Handle exceptions from HiveHook executor.submit()
> -
>
> Key: ATLAS-834
> URL: https://issues.apache.org/jira/browse/ATLAS-834
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.6-incubating, 0.7-incubating
>Reporter: Shwetha G S
>Assignee: Suma Shivaprasad
>Priority: Critical
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-834.patch
>
>
> Atlas hive hook uses threadpool with fixed queue size(to restrict memory). In 
> cases of high load, all threads may be busy and queue may be full in which 
> case, threadpool.submit() fails and hive command execution fails. We should 
> ignore this failure(will result in loss of data for atlas, but we don't have 
> any store forward solution) and let the hive command execution complete.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-793) Business Catalog Delete

[ATLAS QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304920#comment-15304920
 ] 

ATLAS QA commented on ATLAS-793:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12806733/ATLAS-793-2.patch
  against master revision 56c13aa.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 5 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

+1 checkstyle.  The patch generated 0 code style errors.

{color:red}-1 findbugs{color}.  The patch appears to introduce 379 new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 core tests{color}.  The patch failed these unit tests in :
   
org.apache.atlas.repository.typestore.GraphBackedTypeStoreTest

Test results: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/264//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/264//artifact/patchprocess/newPatchFindbugsWarningsrepository.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/264//artifact/patchprocess/newPatchFindbugsWarningscommon.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/264//artifact/patchprocess/newPatchFindbugsWarningsnotification.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/264//artifact/patchprocess/newPatchFindbugsWarningswebapp.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/264//artifact/patchprocess/newPatchFindbugsWarningsclient.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/264//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/264//artifact/patchprocess/newPatchFindbugsWarningsfalcon-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/264//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/264//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/264//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/264//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/264//artifact/patchprocess/newPatchFindbugsWarningsauthorization.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/264//artifact/patchprocess/newPatchFindbugsWarningscatalog.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/264//artifact/patchprocess/newPatchFindbugsWarningstitan.html
Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/264//console

This message is automatically generated.

> Business Catalog Delete
> ---
>
> Key: ATLAS-793
> URL: https://issues.apache.org/jira/browse/ATLAS-793
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 0.7-incubating
>Reporter: Erik Bergenholtz
>Assignee: John Speidel
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-793-2.patch, ATLAS-793.patch
>
>
> Business Catalog API should support deletion of Terms.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-837) Enhance Sqoop addon to handle export operation

[ATLAS QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304805#comment-15304805
 ] 

ATLAS QA commented on ATLAS-837:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12806697/ATLAS-837.patch
  against master revision 0143486.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

+1 checkstyle.  The patch generated 0 code style errors.

{color:red}-1 findbugs{color}.  The patch appears to introduce 379 new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 core tests{color}.  The patch failed these unit tests in :
   
org.apache.atlas.repository.typestore.GraphBackedTypeStoreTest

Test results: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/263//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/263//artifact/patchprocess/newPatchFindbugsWarningsrepository.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/263//artifact/patchprocess/newPatchFindbugsWarningscommon.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/263//artifact/patchprocess/newPatchFindbugsWarningsnotification.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/263//artifact/patchprocess/newPatchFindbugsWarningswebapp.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/263//artifact/patchprocess/newPatchFindbugsWarningsclient.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/263//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/263//artifact/patchprocess/newPatchFindbugsWarningsfalcon-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/263//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/263//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/263//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/263//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/263//artifact/patchprocess/newPatchFindbugsWarningsauthorization.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/263//artifact/patchprocess/newPatchFindbugsWarningscatalog.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/263//artifact/patchprocess/newPatchFindbugsWarningstitan.html
Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/263//console

This message is automatically generated.

> Enhance Sqoop addon to handle export operation
> --
>
> Key: ATLAS-837
> URL: https://issues.apache.org/jira/browse/ATLAS-837
> Project: Atlas
>  Issue Type: Bug
>Reporter: Venkat Ranganathan
>Assignee: Venkat Ranganathan
> Attachments: ATLAS-837.patch
>
>
> Sqoop is adding change to publish hcatalog export data in SQOOP-2936.   
> Enhancing the Sqoop Hook to support it.   No change in Sqoop proces model but 
> based on operation the inputs/outputs will be swapped



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-793) Business Catalog Delete

[John Speidel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Speidel updated ATLAS-793:
---
Attachment: ATLAS-793-2.patch

Uploaded new patch 'ATLAS-793-2.patch' which contains changes for all review 
issues unless otherwise noted in the review.  Also, doesn't address the 
comments included in this Jira as described in my comments.

> Business Catalog Delete
> ---
>
> Key: ATLAS-793
> URL: https://issues.apache.org/jira/browse/ATLAS-793
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 0.7-incubating
>Reporter: Erik Bergenholtz
>Assignee: John Speidel
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-793-2.patch, ATLAS-793.patch
>
>
> Business Catalog API should support deletion of Terms.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Build failed in Jenkins: apache-atlas-nightly #292

[Apache Jenkins Server]

See 

Changes:

[sumasai.shivaprasad] ATLAS-635 Process showing old entity name where as actual 
entity is

--
[...truncated 5870 lines...]
[INFO] Copying 3 resources
[INFO] Copying 2 resources to META-INF
[INFO] Copying 3 resources
[INFO] 
[INFO] --- scala-maven-plugin:3.2.0:compile (scala-compile-first) @ 
atlas-webapp ---
[WARNING] Zinc server is not available at port 3030 - reverting to normal 
incremental compile
[INFO] Using incremental compilation
[INFO] Compiling 55 Java sources to 

[WARNING] Note: 

 uses or overrides a deprecated API.
[WARNING] Note: Recompile with -Xlint:deprecation for details.
[WARNING] Note: Some input files use unchecked or unsafe operations.
[WARNING] Note: Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ atlas-webapp 
---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 55 source files to 

[WARNING] 
:
 

 uses or overrides a deprecated API.
[WARNING] 
:
 Recompile with -Xlint:deprecation for details.
[WARNING] 
:
 Some input files use unchecked or unsafe operations.
[WARNING] 
:
 Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-resources-plugin:2.7:testResources (default-testResources) @ 
atlas-webapp ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- scala-maven-plugin:3.2.0:testCompile (scala-test-compile-first) @ 
atlas-webapp ---
[WARNING] Zinc server is not available at port 3030 - reverting to normal 
incremental compile
[INFO] Using incremental compilation
[INFO] Compiling 40 Java sources to 

[WARNING] Note: Some input files use unchecked or unsafe operations.
[WARNING] Note: Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @ 
atlas-webapp ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 40 source files to 

[WARNING] 
:
 Some input files use unchecked or unsafe operations.
[WARNING] 
:
 Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-war-plugin:2.6:war (default-war) @ atlas-webapp ---
[INFO] Packaging webapp
[INFO] Assembling webapp [atlas-webapp] in 
[
[INFO] Processing overlay [ id org.apache.atlas:atlas-dashboardv2]
[INFO] Processing war project
[INFO] Copying webapp resources 
[
[INFO] Building jar: 

[INFO] Webapp assembled in [3237 msecs]
[INFO] Building war: 

[INFO] 
[INFO] --- maven-site-plugin:3.4:attach-descriptor (attach-descriptor) @ 
atlas-webapp ---
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ atlas-webapp ---
[WARNING] The parameter forkMode is deprecated since version 2.14. Use 
forkCount and reuseForks instead.
[INFO] Surefire report directory: 

[INFO] Using configured provider org.apache.maven.surefire.testng.TestNGProvider
[WARNING] 

Re: Review Request 47898: Implement Business Catalog Delete

[John Speidel]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47898/
---

(Updated May 27, 2016, 9:18 p.m.)


Review request for atlas and Hemanth Yamijala.


Changes
---

Uploaded new patch which contains fixes for all issue except those where I have 
noted otherwise in the comments.


Bugs: ATLAS-793
https://issues.apache.org/jira/browse/ATLAS-793


Repository: atlas


Description
---

Provide support for deletion of taxonomies, terms and tags


Diffs (updated)
-

  catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java 6f2e0be 
  catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java f3376b0 
  catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java 
517eaf6 
  catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java f71c061 
  catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java 
dc4ab0d 
  catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java 4c4319c 
  catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java 
7a46f5d 
  catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java 
431b06d 
  catalog/src/main/java/org/apache/atlas/catalog/projection/BaseRelation.java 
PRE-CREATION 
  
catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java 
5f59bea 
  catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java 
a5e15c6 
  catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java 
5f11474 
  catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java 
e2bc597 
  catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java 
013bb8a 
  catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java 
787f734 
  catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java 
0065101 
  catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java c2eabf7 
  
catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java
 a95b966 
  
catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java
 9cf3d12 
  catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java 
34222ca 
  
catalog/src/test/java/org/apache/atlas/catalog/projection/TagRelationTest.java 
PRE-CREATION 
  
catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java 
838d4c1 
  server-api/src/main/java/org/apache/atlas/services/MetadataService.java 
6bca3df 
  webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java 3982df8 
  webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java 
0e3f4c4 
  webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java 
ccd0b62 

Diff: https://reviews.apache.org/r/47898/diff/


Testing
---

- Added new unit tests
- Ran all existing unit tests
- Manual functional testing of all new functionality


Thanks,

John Speidel

Re: Review Request 47898: Implement Business Catalog Delete

[John Speidel]

> On May 27, 2016, 7:17 a.m., Hemanth Yamijala wrote:
> > catalog/src/main/java/org/apache/atlas/catalog/projection/BaseRelation.java,
> >  line 28
> > 
> >
> > Is it possible to fold this into the search criteria itself, so that we 
> > would not get these properties back.

Yes, I agree that this would be better but is a bit involved and I would like 
to get this merged prior to making these changes if possible.
The relation/projection query code is an area that I didn't really get cleaned 
up like I wanted to.  Making this change will involve generating sub-pipelines 
instead of the current implementation of manually iterating across the vertices.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47898/#review135174
---


On May 26, 2016, 3:52 p.m., John Speidel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47898/
> ---
> 
> (Updated May 26, 2016, 3:52 p.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-793
> https://issues.apache.org/jira/browse/ATLAS-793
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Provide support for deletion of taxonomies, terms and tags
> 
> 
> Diffs
> -
> 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java 6f2e0be 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java f3376b0 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java 
> 517eaf6 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java 
> f71c061 
>   
> catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java 
> dc4ab0d 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java 
> 4c4319c 
>   
> catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java 
> 7a46f5d 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java 
> 431b06d 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/BaseRelation.java 
> PRE-CREATION 
>   
> catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java
>  5f59bea 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java 
> a5e15c6 
>   
> catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java 
> 5f11474 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java 
> e2bc597 
>   
> catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java 
> 013bb8a 
>   
> catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java 
> 787f734 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java 
> 0065101 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java c2eabf7 
>   
> catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java
>  a95b966 
>   
> catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java
>  9cf3d12 
>   
> catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java 
> 34222ca 
>   
> catalog/src/test/java/org/apache/atlas/catalog/projection/TagRelationTest.java
>  PRE-CREATION 
>   
> catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java
>  838d4c1 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 
> 6bca3df 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java 
> 3982df8 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java 
> 0e3f4c4 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java 
> ccd0b62 
> 
> Diff: https://reviews.apache.org/r/47898/diff/
> 
> 
> Testing
> ---
> 
> - Added new unit tests
> - Ran all existing unit tests
> - Manual functional testing of all new functionality
> 
> 
> Thanks,
> 
> John Speidel
> 
>

[jira] [Commented] (ATLAS-834) Handle exceptions from HiveHook executor.submit()

[ATLAS QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304708#comment-15304708
 ] 

ATLAS QA commented on ATLAS-834:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12806691/ATLAS-834.patch
  against master revision 0143486.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

+1 checkstyle.  The patch generated 0 code style errors.

{color:red}-1 findbugs{color}.  The patch appears to introduce 379 new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 core tests{color}.  The patch failed these unit tests in :
   
org.apache.atlas.repository.typestore.GraphBackedTypeStoreTest

Test results: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/262//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/262//artifact/patchprocess/newPatchFindbugsWarningswebapp.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/262//artifact/patchprocess/newPatchFindbugsWarningsauthorization.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/262//artifact/patchprocess/newPatchFindbugsWarningscommon.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/262//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/262//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/262//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/262//artifact/patchprocess/newPatchFindbugsWarningsfalcon-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/262//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/262//artifact/patchprocess/newPatchFindbugsWarningsrepository.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/262//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/262//artifact/patchprocess/newPatchFindbugsWarningscatalog.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/262//artifact/patchprocess/newPatchFindbugsWarningsclient.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/262//artifact/patchprocess/newPatchFindbugsWarningsnotification.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/262//artifact/patchprocess/newPatchFindbugsWarningstitan.html
Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/262//console

This message is automatically generated.

> Handle exceptions from HiveHook executor.submit()
> -
>
> Key: ATLAS-834
> URL: https://issues.apache.org/jira/browse/ATLAS-834
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.6-incubating, 0.7-incubating
>Reporter: Shwetha G S
>Assignee: Suma Shivaprasad
>Priority: Critical
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-834.patch
>
>
> Atlas hive hook uses threadpool with fixed queue size(to restrict memory). In 
> cases of high load, all threads may be busy and queue may be full in which 
> case, threadpool.submit() fails and hive command execution fails. We should 
> ignore this failure(will result in loss of data for atlas, but we don't have 
> any store forward solution) and let the hive command execution complete.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Review Request 47980: Make default build profile for External HBase and Solr

[Tom Beerbower]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47980/
---

Review request for atlas.


Bugs: ATLAS-833
https://issues.apache.org/jira/browse/ATLAS-833


Repository: atlas


Description
---

The default build profile should set the distribution configuration to be 
external HBase and Solr.


The profile external-hbase-solr will not package HBase and Solr with the Atlas 
distribution but will configure atlas-application.properties for and external 
HBase and Solr.


Diffs
-

  distro/pom.xml 22f70ae 
  distro/src/conf/atlas-application.properties bb12538 
  distro/src/conf/atlas-env.sh c671c45 
  docs/src/site/twiki/Configuration.twiki f532a73 
  docs/src/site/twiki/InstallationSteps.twiki fe6b4a7 

Diff: https://reviews.apache.org/r/47980/diff/


Testing
---

Tested all profiles to verify desired configuration and packaging.  Verified 
that the default is for external HBase and Solr.


Thanks,

Tom Beerbower

[jira] [Commented] (ATLAS-835) Falcon Integration with Atlas

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304669#comment-15304669
 ] 

ASF GitHub Bot commented on ATLAS-835:
--

GitHub user sowmyaramesh opened a pull request:

https://github.com/apache/incubator-atlas/pull/26

ATLAS-835: Falcon Integration with Atlas



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sowmyaramesh/incubator-atlas ATLAS-835

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-atlas/pull/26.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #26


commit 6b31a442c89f0f00b4836bfcd521667d378d8338
Author: Sowmya Ramesh 
Date:   2016-04-05T23:25:12Z

Atlas Falcon Integration

commit f0074948a3baffc795c4b9b91330a619361911ac
Author: Sowmya Ramesh 
Date:   2016-04-20T21:01:53Z

Merge remote-tracking branch 'upstream/master'

commit 85b3837a3417c95833d7b52fe3bbc28c7fc4e38c
Author: Sowmya Ramesh 
Date:   2016-05-03T22:25:54Z

Merge remote-tracking branch 'upstream/master'

commit 7971770bf662bd3b31a3142e00b71c754485e68b
Author: Sowmya Ramesh 
Date:   2016-05-18T22:56:00Z

Merged master fixed conflict.

commit f049dc858451636aaa46cbba638c6e7dbec996be
Author: Sowmya Ramesh 
Date:   2016-05-24T00:06:18Z

Merge remote-tracking branch 'upstream/master'

commit 5c5612205f579e5ed42fe00658f00379515b62cc
Author: Sowmya Ramesh 
Date:   2016-05-24T00:43:52Z

Falcon Integration with altest Atlas

commit b9aeb07d8221ec26717298104861d90a867b68cb
Author: Sowmya Ramesh 
Date:   2016-05-27T19:43:24Z

Merge remote-tracking branch 'upstream/master'

commit d1c4bdbf6024ce45e4cfa42081198e93f4b85158
Author: Sowmya Ramesh 
Date:   2016-05-27T19:56:57Z

ATLAS-835: Falcon Integration with Atlas




> Falcon Integration with Atlas
> -
>
> Key: ATLAS-835
> URL: https://issues.apache.org/jira/browse/ATLAS-835
> Project: Atlas
>  Issue Type: New Feature
>Reporter: Sowmya Ramesh
>Assignee: Sowmya Ramesh
> Fix For: trunk
>
>
> Currently only Falcon process registration is supported in Atlas. Extend this 
> to support Falcon feed, replication feed, cluster entity addition and updates.
> Here are the types to be defined:
> {noformat}
> falcon_cluster - models falcon cluster
> falcon_feed - extends Dataset - models falcon feed
> falcon_process - extends Process - models falcon process with inputs and 
> outputs as falcon_feed
> falcon_feed_creation - extends Process - input as hive_table or hdfs_path, 
> output as falcon_feed
> falcon_replication - extends Process - input as falcon_feed in source 
> cluster, output as falcon_feed in target cluster
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ATLAS-837) Enhance Sqoop addon to handle export operation

[Venkat Ranganathan (JIRA)]

Venkat Ranganathan created ATLAS-837:


 Summary: Enhance Sqoop addon to handle export operation
 Key: ATLAS-837
 URL: https://issues.apache.org/jira/browse/ATLAS-837
 Project: Atlas
  Issue Type: Bug
Reporter: Venkat Ranganathan


Sqoop is adding change to publish hcatalog export data in SQOOP-2936.   
Enhancing the Sqoop Hook to support it.   No change in Sqoop proces model but 
based on operation the inputs/outputs will be swapped



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-834) Handle exceptions from HiveHook executor.submit()

[Suma Shivaprasad (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suma Shivaprasad updated ATLAS-834:
---
Attachment: ATLAS-834.patch

> Handle exceptions from HiveHook executor.submit()
> -
>
> Key: ATLAS-834
> URL: https://issues.apache.org/jira/browse/ATLAS-834
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.6-incubating, 0.7-incubating
>Reporter: Shwetha G S
>Assignee: Suma Shivaprasad
>Priority: Critical
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-834.patch
>
>
> Atlas hive hook uses threadpool with fixed queue size(to restrict memory). In 
> cases of high load, all threads may be busy and queue may be full in which 
> case, threadpool.submit() fails and hive command execution fails. We should 
> ignore this failure(will result in loss of data for atlas, but we don't have 
> any store forward solution) and let the hive command execution complete.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-694) Update Atlas code to use abstraction layer

[ATLAS QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304592#comment-15304592
 ] 

ATLAS QA commented on ATLAS-694:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12806681/rb47810.patch
  against master revision 0143486.

{color:red}-1 @author{color}.  The patch appears to contain 1 @author tags 
which the Atlas community has agreed to not allow in code contributions.

{color:green}+1 tests included{color}.  The patch appears to include 35 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

+1 checkstyle.  The patch generated 0 code style errors.

{color:red}-1 findbugs{color}.  The patch appears to introduce 385 new 
Findbugs (version 2.0.3) warnings.

{color:red}-1 release audit{color}.  The applied patch generated 3 
release audit warnings.

{color:red}-1 core tests{color}.  The test build failed in  

Test results: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/261//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/261//artifact/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/261//artifact/patchprocess/newPatchFindbugsWarningsrepository.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/261//artifact/patchprocess/newPatchFindbugsWarningscommon.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/261//artifact/patchprocess/newPatchFindbugsWarningsnotification.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/261//artifact/patchprocess/newPatchFindbugsWarningswebapp.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/261//artifact/patchprocess/newPatchFindbugsWarningsclient.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/261//artifact/patchprocess/newPatchFindbugsWarningstitan0.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/261//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/261//artifact/patchprocess/newPatchFindbugsWarningsfalcon-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/261//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/261//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/261//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/261//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/261//artifact/patchprocess/newPatchFindbugsWarningsauthorization.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/261//artifact/patchprocess/newPatchFindbugsWarningscatalog.html
Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/261//console

This message is automatically generated.

> Update Atlas code to use abstraction layer
> --
>
> Key: ATLAS-694
> URL: https://issues.apache.org/jira/browse/ATLAS-694
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: Jeffrey Hagelberg
>Assignee: Jeffrey Hagelberg
> Attachments: rb47810.patch
>
>
> In this task, we will update Atlas to replace the direct usage of titan 
> classes with usage of the equivalent interfaces in the abstraction layer.  At 
> this point, there will be no options to configure the abstraction layer 
> implementation that gets used.  Atlas will be hard-coded to use the titan 
> 0.5.4 implementation.  It will also continue to have a compile time 
> dependency on the titan 0.5.4 graph database implementation.  When this task 
> is complete, Atlas will only be accessing titan through the abstraction layer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-793) Business Catalog Delete

[John Speidel (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304581#comment-15304581
 ] 

John Speidel commented on ATLAS-793:


[~yhemanth] At this time I don't know why the above transaction timeout message 
occurs.
I will post a new patch with changes for the issues raised in the review and 
will then investigate this message.
Perhaps we file a new Jira for this issue so that we can make the delete 
functionality available while I am investigating?

> Business Catalog Delete
> ---
>
> Key: ATLAS-793
> URL: https://issues.apache.org/jira/browse/ATLAS-793
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 0.7-incubating
>Reporter: Erik Bergenholtz
>Assignee: John Speidel
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-793.patch
>
>
> Business Catalog API should support deletion of Terms.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-793) Business Catalog Delete

[John Speidel (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304570#comment-15304570
 ] 

John Speidel commented on ATLAS-793:


[~yhemanth] The reason for this log message is because I added a clause to all 
queries to return only non-deleted (active) vertices.
This clause is basically (Constants.STATE_PROPERTY_KEY:ACTIVE).
At this time, this property isn't indexed by Atlas which results in a 
non-indexed vertex scan.
This clause is required in the query to ensure that deleted vertices aren't 
returned.

Let me know if you would like me to add this index in 
GraphBackedSearchIndexer.java.


> Business Catalog Delete
> ---
>
> Key: ATLAS-793
> URL: https://issues.apache.org/jira/browse/ATLAS-793
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 0.7-incubating
>Reporter: Erik Bergenholtz
>Assignee: John Speidel
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-793.patch
>
>
> Business Catalog API should support deletion of Terms.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-835) Falcon Integration with Atlas

[Suma Shivaprasad (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suma Shivaprasad updated ATLAS-835:
---
Assignee: Sowmya Ramesh

> Falcon Integration with Atlas
> -
>
> Key: ATLAS-835
> URL: https://issues.apache.org/jira/browse/ATLAS-835
> Project: Atlas
>  Issue Type: New Feature
>Reporter: Sowmya Ramesh
>Assignee: Sowmya Ramesh
> Fix For: trunk
>
>
> Currently only Falcon process registration is supported in Atlas. Extend this 
> to support Falcon feed, replication feed, cluster entity addition and updates.
> Here are the types to be defined:
> {noformat}
> falcon_cluster - models falcon cluster
> falcon_feed - extends Dataset - models falcon feed
> falcon_process - extends Process - models falcon process with inputs and 
> outputs as falcon_feed
> falcon_feed_creation - extends Process - input as hive_table or hdfs_path, 
> output as falcon_feed
> falcon_replication - extends Process - input as falcon_feed in source 
> cluster, output as falcon_feed in target cluster
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ATLAS-836) Add timeout for kafka notifications

[Shwetha G S (JIRA)]

Shwetha G S created ATLAS-836:
-

 Summary: Add timeout for kafka notifications
 Key: ATLAS-836
 URL: https://issues.apache.org/jira/browse/ATLAS-836
 Project: Atlas
  Issue Type: Bug
Reporter: Shwetha G S
 Fix For: 0.7-incubating


In atlas conf, we don't have timeout for calls to kafka and have seen cases 
where the kafka calls get stuck for a long time. We should have reasonable 
timeouts



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ATLAS-834) Handle exceptions from HiveHook executor.submit()

[Shwetha G S (JIRA)]

Shwetha G S created ATLAS-834:
-

 Summary: Handle exceptions from HiveHook executor.submit()
 Key: ATLAS-834
 URL: https://issues.apache.org/jira/browse/ATLAS-834
 Project: Atlas
  Issue Type: Bug
Reporter: Shwetha G S
Priority: Critical


Atlas hive hook uses threadpool with fixed queue size(to restrict memory). In 
cases of high load, all threads may be busy and queue may be full in which 
case, threadpool.submit() fails and hive command execution fails. We should 
ignore this failure(will result in loss of data for atlas, but we don't have 
any store forward solution) and let the hive command execution complete.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-834) Handle exceptions from HiveHook executor.submit()

[Shwetha G S (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shwetha G S updated ATLAS-834:
--
Assignee: Suma Shivaprasad

> Handle exceptions from HiveHook executor.submit()
> -
>
> Key: ATLAS-834
> URL: https://issues.apache.org/jira/browse/ATLAS-834
> Project: Atlas
>  Issue Type: Bug
>Reporter: Shwetha G S
>Assignee: Suma Shivaprasad
>Priority: Critical
> Fix For: 0.7-incubating
>
>
> Atlas hive hook uses threadpool with fixed queue size(to restrict memory). In 
> cases of high load, all threads may be busy and queue may be full in which 
> case, threadpool.submit() fails and hive command execution fails. We should 
> ignore this failure(will result in loss of data for atlas, but we don't have 
> any store forward solution) and let the hive command execution complete.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-694) Update Atlas code to use abstraction layer

[Jeffrey Hagelberg (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeffrey Hagelberg updated ATLAS-694:

Attachment: rb47810.patch

> Update Atlas code to use abstraction layer
> --
>
> Key: ATLAS-694
> URL: https://issues.apache.org/jira/browse/ATLAS-694
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: Jeffrey Hagelberg
>Assignee: Jeffrey Hagelberg
> Attachments: rb47810.patch
>
>
> In this task, we will update Atlas to replace the direct usage of titan 
> classes with usage of the equivalent interfaces in the abstraction layer.  At 
> this point, there will be no options to configure the abstraction layer 
> implementation that gets used.  Atlas will be hard-coded to use the titan 
> 0.5.4 implementation.  It will also continue to have a compile time 
> dependency on the titan 0.5.4 graph database implementation.  When this task 
> is complete, Atlas will only be accessing titan through the abstraction layer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ATLAS-833) Make default build profile for External HBase and Solr

[Tom Beerbower (JIRA)]

Tom Beerbower created ATLAS-833:
---

 Summary: Make default build profile for External HBase and Solr
 Key: ATLAS-833
 URL: https://issues.apache.org/jira/browse/ATLAS-833
 Project: Atlas
  Issue Type: Bug
Reporter: Tom Beerbower
Assignee: Tom Beerbower


The default build profile should set the distribution configuration to be 
external HBase and Solr. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-694) Update Atlas code to use abstraction layer

[Jeffrey Hagelberg (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeffrey Hagelberg updated ATLAS-694:

Attachment: (was: rb47810.patch)

> Update Atlas code to use abstraction layer
> --
>
> Key: ATLAS-694
> URL: https://issues.apache.org/jira/browse/ATLAS-694
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: Jeffrey Hagelberg
>Assignee: Jeffrey Hagelberg
>
> In this task, we will update Atlas to replace the direct usage of titan 
> classes with usage of the equivalent interfaces in the abstraction layer.  At 
> this point, there will be no options to configure the abstraction layer 
> implementation that gets used.  Atlas will be hard-coded to use the titan 
> 0.5.4 implementation.  It will also continue to have a compile time 
> dependency on the titan 0.5.4 graph database implementation.  When this task 
> is complete, Atlas will only be accessing titan through the abstraction layer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

[Jeff Hagelberg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47810/
---

(Updated May 27, 2016, 6:20 p.m.)


Review request for atlas, David Kantor and Neeru Gupta.


Changes
---

Fixed checkstyle issues.


Bugs: ATLAS-694
https://issues.apache.org/jira/browse/ATLAS-694


Repository: atlas


Description
---

ATLAS-694: Update Atlas to use abstraction layer.  All of the Atlas code (with 
the exception of the catalog, which was only updated minimally) has been 
updated to use the graph database abstraction layer.  In addition, there is now 
a required Atlas configuration property that specifies the class of the 
abstraction layer database to use.  I basically put all of the changes in here 
with the exception of the actual Titan 1 implementation of code.  This includes 
the changes to support Tinkerpop 3 syntax.  This is mostly to expedite getting 
the changes into Atlas.  Originally the TP3 changes were going to be brought in 
as part of the Titan 1 implementation task.

Change Summary:

   - change Atlas classes to use AtlasGraph,AtlasVertex,AtlasEdge, etc instead 
of TitanGraph/Vertex/Edge, etc
   - compile time dependency on titan 0.5.4/TP 2 removed (except in Catalog, 
which was only changed to use AtlasGraphProvider/AtlasGraph)
   - updated DSL translation to generate Gremlin that is compliant with TP3 
when TP3 is being used
   - TitanGraphProvider replaced by AtlasGraphProvider.  Graph database 
implementation is determined from a new required configuration property
   - search indexer enhanced to wait for all indices to be enabled
   - HiveTitanSample is no longer used by tests.  It has been replaced by 
hive-instances.json (which uses normal Atlas json syntax).  The data is saved 
with a new JSONImporter class.  This was needed because the graphson syntax 
used by HiveTitanSample is not compatible with TP3.  
   - RepositoryMetaModule - GraphBackedSearchIndexer changed to an eager 
singleton to force index creation to happen before we execute any gremlin 
queries (which happens during the type system restoration triggered by the 
DefaultMetadataService constructor)
   - atlas_config.py - minor change to allow Atlas to use a non-default JVM.  
It now supports having the java home in ATLAS_JAVA_HOME.  If that is not set, 
we fall back to the previous behavior looking for JAVA_HOME and then checking 
the path.
   
Note - the diff here is cumulative and includes the changes from ATLAS-693.  I 
could not figure out how to remove those.

Last rebase: 5/27/2016


Diffs (updated)
-

  addons/falcon-bridge/pom.xml 14c60901a6f194497ca0fb7929a032d2261f85fa 
  addons/hdfs-model/pom.xml f4033bce0fe3ea5a33cfd32ebccd47c01207dc35 
  addons/hdfs-model/src/test/java/org/apache/atlas/fs/model/HDFSModelTest.java 
ac60294e328835ba0340e150799ddfb348ccdb52 
  addons/hive-bridge/pom.xml 47e72e814a421f03b00a9b7c6a13163e1b67ca14 
  addons/sqoop-bridge/pom.xml 343bb4eeae93031ab24cd48ed7b535769150d6c7 
  addons/storm-bridge/pom.xml b1a7a9b1a88442d9e65db4a01b8388c8d3522bfe 
  authorization/pom.xml 74c433bf740a346d1d907a868605e9ab457151bb 
  catalog/pom.xml 8a49d3d673a5936613d45e53479aa99a5a14517d 
  catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java 
c2eabf70de57f2893a4c30a045fa8f10aaf0b837 
  
catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java 
838d4c16579efcc2519d668149610edfe78f83c5 
  distro/pom.xml 22f70ae970d3ee4ce3d56d15f0e9df5a3fa21b94 
  distro/src/bin/atlas_config.py fab4046345e05e0b7749ca75834c8bdcb0d01752 
  distro/src/conf/atlas-application.properties 
bb12538197ea47aad0cad013529c6821e1b1a766 
  graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasEdge.java 
71b577b5c2e8aee8fec816b9224672ebc2cad5b3 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasEdgeDirection.java
 e7da1c9a5075004973ba68b8a36a2c95756e0e62 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasElement.java 
3c41693e531eb523f04a5c5781f1f123ab38ef07 
  graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java 
f312117af9cb6ae8de21d565bfcf3b10d9bdfcc6 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphIndex.java
 PRE-CREATION 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java
 2776b2242c4469dcae344616ccfe100633a79432 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java
 f0dca9a28eebd8996d55d71dcc3254cce9cd4098 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java
 7ee6b2831a7610e7d5b1d36ae69282a9315dc06b 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasPropertyKey.java
 PRE-CREATION 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasSchemaViolationException.java
 fda83b807f3640c04a660001941376f41be6d9be 
 

Re: Review Request 47898: Implement Business Catalog Delete

[John Speidel]

> On May 27, 2016, 7:11 a.m., Hemanth Yamijala wrote:
> > catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java, 
> > line 130
> > 
> >
> > Would it help if the term subtree is sorted from leaf nodes upwards, so 
> > that if there is a failure in the interim, at least we will not have 
> > dangling terms.

Yeah, I had thought of this also but didn't implement it due to the added 
overhead for all delete calls.
The real problem here is the inability for the catalog call to control 
transaction demarcation because of the way that transactions are handled in the 
Atlas Repository layer.  The bottom line is that ordering of the terms bottom 
up is just a band-aid for the real transactional issue described above that 
would introduce overhead even for non failure scenarios. 

Let me know if you would still like me to make this change or whether we should 
file a Jira for a proper fix.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47898/#review135172
---


On May 26, 2016, 3:52 p.m., John Speidel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47898/
> ---
> 
> (Updated May 26, 2016, 3:52 p.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-793
> https://issues.apache.org/jira/browse/ATLAS-793
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Provide support for deletion of taxonomies, terms and tags
> 
> 
> Diffs
> -
> 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java 6f2e0be 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java f3376b0 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java 
> 517eaf6 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java 
> f71c061 
>   
> catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java 
> dc4ab0d 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java 
> 4c4319c 
>   
> catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java 
> 7a46f5d 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java 
> 431b06d 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/BaseRelation.java 
> PRE-CREATION 
>   
> catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java
>  5f59bea 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java 
> a5e15c6 
>   
> catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java 
> 5f11474 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java 
> e2bc597 
>   
> catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java 
> 013bb8a 
>   
> catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java 
> 787f734 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java 
> 0065101 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java c2eabf7 
>   
> catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java
>  a95b966 
>   
> catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java
>  9cf3d12 
>   
> catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java 
> 34222ca 
>   
> catalog/src/test/java/org/apache/atlas/catalog/projection/TagRelationTest.java
>  PRE-CREATION 
>   
> catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java
>  838d4c1 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 
> 6bca3df 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java 
> 3982df8 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java 
> 0e3f4c4 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java 
> ccd0b62 
> 
> Diff: https://reviews.apache.org/r/47898/diff/
> 
> 
> Testing
> ---
> 
> - Added new unit tests
> - Ran all existing unit tests
> - Manual functional testing of all new functionality
> 
> 
> Thanks,
> 
> John Speidel
> 
>

[jira] [Commented] (ATLAS-694) Update Atlas code to use abstraction layer

[ATLAS QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304323#comment-15304323
 ] 

ATLAS QA commented on ATLAS-694:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12806654/rb47810.patch
  against master revision 0143486.

{color:red}-1 @author{color}.  The patch appears to contain 1 @author tags 
which the Atlas community has agreed to not allow in code contributions.

{color:green}+1 tests included{color}.  The patch appears to include 35 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

+1 checkstyle.  The patch generated 0 code style errors.

{color:red}-1 findbugs{color}.  The patch appears to introduce 385 new 
Findbugs (version 2.0.3) warnings.

{color:red}-1 release audit{color}.  The applied patch generated 3 
release audit warnings.

{color:red}-1 core tests{color}.  The test build failed in  

Test results: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/260//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/260//artifact/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/260//artifact/patchprocess/newPatchFindbugsWarningsrepository.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/260//artifact/patchprocess/newPatchFindbugsWarningscommon.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/260//artifact/patchprocess/newPatchFindbugsWarningsnotification.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/260//artifact/patchprocess/newPatchFindbugsWarningswebapp.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/260//artifact/patchprocess/newPatchFindbugsWarningsclient.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/260//artifact/patchprocess/newPatchFindbugsWarningstitan0.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/260//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/260//artifact/patchprocess/newPatchFindbugsWarningsfalcon-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/260//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/260//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/260//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/260//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/260//artifact/patchprocess/newPatchFindbugsWarningsauthorization.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/260//artifact/patchprocess/newPatchFindbugsWarningscatalog.html
Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/260//console

This message is automatically generated.

> Update Atlas code to use abstraction layer
> --
>
> Key: ATLAS-694
> URL: https://issues.apache.org/jira/browse/ATLAS-694
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: Jeffrey Hagelberg
>Assignee: Jeffrey Hagelberg
> Attachments: rb47810.patch
>
>
> In this task, we will update Atlas to replace the direct usage of titan 
> classes with usage of the equivalent interfaces in the abstraction layer.  At 
> this point, there will be no options to configure the abstraction layer 
> implementation that gets used.  Atlas will be hard-coded to use the titan 
> 0.5.4 implementation.  It will also continue to have a compile time 
> dependency on the titan 0.5.4 graph database implementation.  When this task 
> is complete, Atlas will only be accessing titan through the abstraction layer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

[Jeff Hagelberg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47810/
---

(Updated May 27, 2016, 4:07 p.m.)


Review request for atlas, David Kantor and Neeru Gupta.


Bugs: ATLAS-694
https://issues.apache.org/jira/browse/ATLAS-694


Repository: atlas


Description (updated)
---

ATLAS-694: Update Atlas to use abstraction layer.  All of the Atlas code (with 
the exception of the catalog, which was only updated minimally) has been 
updated to use the graph database abstraction layer.  In addition, there is now 
a required Atlas configuration property that specifies the class of the 
abstraction layer database to use.  I basically put all of the changes in here 
with the exception of the actual Titan 1 implementation of code.  This includes 
the changes to support Tinkerpop 3 syntax.  This is mostly to expedite getting 
the changes into Atlas.  Originally the TP3 changes were going to be brought in 
as part of the Titan 1 implementation task.

Change Summary:

   - change Atlas classes to use AtlasGraph,AtlasVertex,AtlasEdge, etc instead 
of TitanGraph/Vertex/Edge, etc
   - compile time dependency on titan 0.5.4/TP 2 removed (except in Catalog, 
which was only changed to use AtlasGraphProvider/AtlasGraph)
   - updated DSL translation to generate Gremlin that is compliant with TP3 
when TP3 is being used
   - TitanGraphProvider replaced by AtlasGraphProvider.  Graph database 
implementation is determined from a new required configuration property
   - search indexer enhanced to wait for all indices to be enabled
   - HiveTitanSample is no longer used by tests.  It has been replaced by 
hive-instances.json (which uses normal Atlas json syntax).  The data is saved 
with a new JSONImporter class.  This was needed because the graphson syntax 
used by HiveTitanSample is not compatible with TP3.  
   - RepositoryMetaModule - GraphBackedSearchIndexer changed to an eager 
singleton to force index creation to happen before we execute any gremlin 
queries (which happens during the type system restoration triggered by the 
DefaultMetadataService constructor)
   - atlas_config.py - minor change to allow Atlas to use a non-default JVM.  
It now supports having the java home in ATLAS_JAVA_HOME.  If that is not set, 
we fall back to the previous behavior looking for JAVA_HOME and then checking 
the path.
   
Note - the diff here is cumulative and includes the changes from ATLAS-693.  I 
could not figure out how to remove those.

Last rebase: 5/27/2016


Diffs
-

  addons/falcon-bridge/pom.xml 14c60901a6f194497ca0fb7929a032d2261f85fa 
  addons/hdfs-model/pom.xml f4033bce0fe3ea5a33cfd32ebccd47c01207dc35 
  addons/hdfs-model/src/test/java/org/apache/atlas/fs/model/HDFSModelTest.java 
ac60294e328835ba0340e150799ddfb348ccdb52 
  addons/hive-bridge/pom.xml 47e72e814a421f03b00a9b7c6a13163e1b67ca14 
  addons/sqoop-bridge/pom.xml 343bb4eeae93031ab24cd48ed7b535769150d6c7 
  addons/storm-bridge/pom.xml b1a7a9b1a88442d9e65db4a01b8388c8d3522bfe 
  authorization/pom.xml 74c433bf740a346d1d907a868605e9ab457151bb 
  catalog/pom.xml 8a49d3d673a5936613d45e53479aa99a5a14517d 
  catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java 
c2eabf70de57f2893a4c30a045fa8f10aaf0b837 
  
catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java 
838d4c16579efcc2519d668149610edfe78f83c5 
  distro/pom.xml 22f70ae970d3ee4ce3d56d15f0e9df5a3fa21b94 
  distro/src/bin/atlas_config.py fab4046345e05e0b7749ca75834c8bdcb0d01752 
  distro/src/conf/atlas-application.properties 
bb12538197ea47aad0cad013529c6821e1b1a766 
  graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasEdge.java 
71b577b5c2e8aee8fec816b9224672ebc2cad5b3 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasEdgeDirection.java
 e7da1c9a5075004973ba68b8a36a2c95756e0e62 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasElement.java 
3c41693e531eb523f04a5c5781f1f123ab38ef07 
  graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java 
f312117af9cb6ae8de21d565bfcf3b10d9bdfcc6 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphIndex.java
 PRE-CREATION 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java
 2776b2242c4469dcae344616ccfe100633a79432 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java
 f0dca9a28eebd8996d55d71dcc3254cce9cd4098 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java
 7ee6b2831a7610e7d5b1d36ae69282a9315dc06b 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasPropertyKey.java
 PRE-CREATION 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasSchemaViolationException.java
 fda83b807f3640c04a660001941376f41be6d9be 
  

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

[Jeff Hagelberg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47810/
---

(Updated May 27, 2016, 4:04 p.m.)


Review request for atlas, David Kantor and Neeru Gupta.


Bugs: ATLAS-694
https://issues.apache.org/jira/browse/ATLAS-694


Repository: atlas


Description (updated)
---

ATLAS-694: Update Atlas to use abstraction layer.  All of the Atlas code (with 
the exception of the catalog, which was only updated minimally) has been 
updated to use the graph database abstraction layer.  In addition, there is now 
a required Atlas configuration property that specifies the class of the 
abstraction layer database to use.  I basically put all of the changes in here 
with the exception of the actual Titan 1 implementation of code.  This includes 
the changes to support Tinkerpop 3 syntax.  This is mostly to expedite getting 
the changes into Atlas.  Originally the TP3 changes were going to be brought in 
as part of the Titan 1 implementation task.

Change Summary:

   - change Atlas classes to use AtlasGraph,AtlasVertex,AtlasEdge, etc instead 
of TitanGraph/Vertex/Edge, etc
   - compile time dependency on titan 0.5.4/TP 2 removed (except in Catalog, 
which was only changed to use AtlasGraphProvider/AtlasGraph)
   - updated DSL translation to generate Gremlin that is compliant with TP3 
when TP3 is being used
   - TitanGraphProvider replaced by AtlasGraphProvider.  Graph database 
implementation is determined from a new required configuration property
   - search indexer enhanced to wait for all indices to be enabled
   - HiveTitanSample is no longer used by tests.  It has been replaced by 
hive-instances.json (which uses normal Atlas json syntax).  The data is saved 
with a new JSONImporter class.  This was needed because the graphson syntax 
used by HiveTitanSample is not compatible with TP3.  
   - RepositoryMetaModule - GraphBackedSearchIndexer changed to an eager 
singleton to force index creation to happen before we execute any gremlin 
queries (which happens during the type system restoration triggered by the 
DefaultMetadataService constructor)
   - atlas_config.py - minor change to allow Atlas to use a non-default JVM.  
It now supports having the java home in ATLAS_JAVA_HOME.  If that is not set, 
we fall back to the previous behavior looking for JAVA_HOME and then checking 
the path.
   
Note - the diff here is cumulative and includes the changes from ATLAS-693.  I 
could not figure out how to remove those.


Diffs
-

  addons/falcon-bridge/pom.xml 14c60901a6f194497ca0fb7929a032d2261f85fa 
  addons/hdfs-model/pom.xml f4033bce0fe3ea5a33cfd32ebccd47c01207dc35 
  addons/hdfs-model/src/test/java/org/apache/atlas/fs/model/HDFSModelTest.java 
ac60294e328835ba0340e150799ddfb348ccdb52 
  addons/hive-bridge/pom.xml 47e72e814a421f03b00a9b7c6a13163e1b67ca14 
  addons/sqoop-bridge/pom.xml 343bb4eeae93031ab24cd48ed7b535769150d6c7 
  addons/storm-bridge/pom.xml b1a7a9b1a88442d9e65db4a01b8388c8d3522bfe 
  authorization/pom.xml 74c433bf740a346d1d907a868605e9ab457151bb 
  catalog/pom.xml 8a49d3d673a5936613d45e53479aa99a5a14517d 
  catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java 
c2eabf70de57f2893a4c30a045fa8f10aaf0b837 
  
catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java 
838d4c16579efcc2519d668149610edfe78f83c5 
  distro/pom.xml 22f70ae970d3ee4ce3d56d15f0e9df5a3fa21b94 
  distro/src/bin/atlas_config.py fab4046345e05e0b7749ca75834c8bdcb0d01752 
  distro/src/conf/atlas-application.properties 
bb12538197ea47aad0cad013529c6821e1b1a766 
  graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasEdge.java 
71b577b5c2e8aee8fec816b9224672ebc2cad5b3 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasEdgeDirection.java
 e7da1c9a5075004973ba68b8a36a2c95756e0e62 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasElement.java 
3c41693e531eb523f04a5c5781f1f123ab38ef07 
  graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java 
f312117af9cb6ae8de21d565bfcf3b10d9bdfcc6 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphIndex.java
 PRE-CREATION 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java
 2776b2242c4469dcae344616ccfe100633a79432 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java
 f0dca9a28eebd8996d55d71dcc3254cce9cd4098 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java
 7ee6b2831a7610e7d5b1d36ae69282a9315dc06b 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasPropertyKey.java
 PRE-CREATION 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasSchemaViolationException.java
 fda83b807f3640c04a660001941376f41be6d9be 
  

[jira] [Updated] (ATLAS-694) Update Atlas code to use abstraction layer

[Jeffrey Hagelberg (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeffrey Hagelberg updated ATLAS-694:

Attachment: rb47810.patch

Updated patch to fix checkstyle issues in ATLAS-693

> Update Atlas code to use abstraction layer
> --
>
> Key: ATLAS-694
> URL: https://issues.apache.org/jira/browse/ATLAS-694
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: Jeffrey Hagelberg
>Assignee: Jeffrey Hagelberg
> Attachments: rb47810.patch
>
>
> In this task, we will update Atlas to replace the direct usage of titan 
> classes with usage of the equivalent interfaces in the abstraction layer.  At 
> this point, there will be no options to configure the abstraction layer 
> implementation that gets used.  Atlas will be hard-coded to use the titan 
> 0.5.4 implementation.  It will also continue to have a compile time 
> dependency on the titan 0.5.4 graph database implementation.  When this task 
> is complete, Atlas will only be accessing titan through the abstraction layer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

[Jeff Hagelberg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47810/
---

(Updated May 27, 2016, 4:01 p.m.)


Review request for atlas, David Kantor and Neeru Gupta.


Changes
---

Fix checkstyle violations from ATLAS-693.


Bugs: ATLAS-694
https://issues.apache.org/jira/browse/ATLAS-694


Repository: atlas


Description
---

ATLAS-694: Update Atlas to use abstraction layer.  All of the Atlas code (with 
the exception of the catalog, which was only updated minimally) has been 
updated to use the graph database abstraction layer.  In addition, there is now 
a required Atlas configuration property that specifies the class of the 
abstraction layer database to use.  I basically put all of the changes in here 
with the exception of the actual Titan 1 implementation of code.  This includes 
the changes to support Tinkerpop 3 syntax.  This is mostly to expedite getting 
the changes into Atlas.  Originally the TP3 changes were going to be brought in 
as part of the Titan 1 implementation task.

Change Summary:

   - change Atlas classes to use AtlasGraph,AtlasVertex,AtlasEdge, etc instead 
of TitanGraph/Vertex/Edge, etc
   - compile time dependency on titan 0.5.4/TP 2 removed (except in Catalog, 
which was only changed to use AtlasGraphProvider/AtlasGraph)
   - updated DSL translation to generate Gremlin that is compliant with TP3 
when TP3 is being used
   - TitanGraphProvider replaced by AtlasGraphProvider.  Graph database 
implementation is determined from a new required configuration property
   - search indexer enhanced to wait for all indices to be enabled
   - HiveTitanSample is no longer used by tests.  It has been replaced by 
hive-instances.json (which uses normal Atlas json syntax).  The data is saved 
with a new JSONImporter class.  This was needed because the graphson syntax 
used by HiveTitanSample is not compatible with TP3.  
   - RepositoryMetaModule - GraphBackedSearchIndexer changed to an eager 
singleton to force index creation to happen before we execute any gremlin 
queries (which happens during the type system restoration triggered by the 
DefaultMetadataService constructor)
   - atlas_config.py - minor change to allow Atlas to use a non-default JVM.  
It now supports having the java home in ATLAS_JAVA_HOME.  If that is not set, 
we fall back to the previous behavior looking for JAVA_HOME and then checking 
the path.
   -
Note - I did remove the spurious whitespace.  So far I have not figured out how 
to update the diff.  It's kind of trickly since I only want the commits since 
the last diff generated for ATLAS-693.


Diffs (updated)
-

  addons/falcon-bridge/pom.xml 14c60901a6f194497ca0fb7929a032d2261f85fa 
  addons/hdfs-model/pom.xml f4033bce0fe3ea5a33cfd32ebccd47c01207dc35 
  addons/hdfs-model/src/test/java/org/apache/atlas/fs/model/HDFSModelTest.java 
ac60294e328835ba0340e150799ddfb348ccdb52 
  addons/hive-bridge/pom.xml 47e72e814a421f03b00a9b7c6a13163e1b67ca14 
  addons/sqoop-bridge/pom.xml 343bb4eeae93031ab24cd48ed7b535769150d6c7 
  addons/storm-bridge/pom.xml b1a7a9b1a88442d9e65db4a01b8388c8d3522bfe 
  authorization/pom.xml 74c433bf740a346d1d907a868605e9ab457151bb 
  catalog/pom.xml 8a49d3d673a5936613d45e53479aa99a5a14517d 
  catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java 
c2eabf70de57f2893a4c30a045fa8f10aaf0b837 
  
catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java 
838d4c16579efcc2519d668149610edfe78f83c5 
  distro/pom.xml 22f70ae970d3ee4ce3d56d15f0e9df5a3fa21b94 
  distro/src/bin/atlas_config.py fab4046345e05e0b7749ca75834c8bdcb0d01752 
  distro/src/conf/atlas-application.properties 
bb12538197ea47aad0cad013529c6821e1b1a766 
  graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasEdge.java 
71b577b5c2e8aee8fec816b9224672ebc2cad5b3 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasEdgeDirection.java
 e7da1c9a5075004973ba68b8a36a2c95756e0e62 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasElement.java 
3c41693e531eb523f04a5c5781f1f123ab38ef07 
  graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java 
f312117af9cb6ae8de21d565bfcf3b10d9bdfcc6 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphIndex.java
 PRE-CREATION 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java
 2776b2242c4469dcae344616ccfe100633a79432 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java
 f0dca9a28eebd8996d55d71dcc3254cce9cd4098 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java
 7ee6b2831a7610e7d5b1d36ae69282a9315dc06b 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasPropertyKey.java
 PRE-CREATION 
  

[jira] [Updated] (ATLAS-694) Update Atlas code to use abstraction layer

[Jeffrey Hagelberg (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeffrey Hagelberg updated ATLAS-694:

Attachment: (was: rb47810.patch)

> Update Atlas code to use abstraction layer
> --
>
> Key: ATLAS-694
> URL: https://issues.apache.org/jira/browse/ATLAS-694
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: Jeffrey Hagelberg
>Assignee: Jeffrey Hagelberg
>
> In this task, we will update Atlas to replace the direct usage of titan 
> classes with usage of the equivalent interfaces in the abstraction layer.  At 
> this point, there will be no options to configure the abstraction layer 
> implementation that gets used.  Atlas will be hard-coded to use the titan 
> 0.5.4 implementation.  It will also continue to have a compile time 
> dependency on the titan 0.5.4 graph database implementation.  When this task 
> is complete, Atlas will only be accessing titan through the abstraction layer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-693) Add titan 0.5.4 implemenation of graph database abstraction layer

[Jeffrey Hagelberg (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304241#comment-15304241
 ] 

Jeffrey Hagelberg commented on ATLAS-693:
-

Looks like I missed 2 checkstyle violations:

/home/jenkins/jenkins-slave/workspace/PreCommit-ATLAS-Build/common/src/main/java/org/apache/atlas/repository/Constants.java:21:
 Missing a Javadoc comment.
/home/jenkins/jenkins-slave/workspace/PreCommit-ATLAS-Build/common/src/main/java/org/apache/atlas/repository/Constants.java:46:
 First sentence should end with a period.

I thought those were fixed...

> Add titan 0.5.4 implemenation of graph database abstraction layer
> -
>
> Key: ATLAS-693
> URL: https://issues.apache.org/jira/browse/ATLAS-693
> Project: Atlas
>  Issue Type: Sub-task
>Affects Versions: 0.6-incubating
>Reporter: Jeffrey Hagelberg
>Assignee: Jeffrey Hagelberg
> Fix For: trunk
>
> Attachments: rb47466.patch
>
>
> In this task, we put in place the titan 0.5.4 implementation of the graph 
> database abstraction layer.  As part of this effort, the existing "titan" 
> maven project will be merged into this new project, since it is specific to 
> titan 0.5.4.  The maven projects in Atlas that depend on the "titan" will be 
> changed to depend on the new project.  Direct dependencies on titan 0.5.4 
> will be removed from all of the atlas projects.  These projects will be 
> changed to depend on this new project instead.  They will transitively obtain 
> the dependencies on titan 0.5.4 that they need.  For this task, very little 
> of the existing Atlas java / scala code will be changed.  The classes from in 
> the titan project will be moved verbatim into the new project.  The only 
> other changes will be the addition of the new classes that implement the 
> abstraction layer interfaces.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-694) Update Atlas code to use abstraction layer

[Jeffrey Hagelberg (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeffrey Hagelberg updated ATLAS-694:

Attachment: rb47810.patch

> Update Atlas code to use abstraction layer
> --
>
> Key: ATLAS-694
> URL: https://issues.apache.org/jira/browse/ATLAS-694
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: Jeffrey Hagelberg
>Assignee: Jeffrey Hagelberg
> Attachments: rb47810.patch
>
>
> In this task, we will update Atlas to replace the direct usage of titan 
> classes with usage of the equivalent interfaces in the abstraction layer.  At 
> this point, there will be no options to configure the abstraction layer 
> implementation that gets used.  Atlas will be hard-coded to use the titan 
> 0.5.4 implementation.  It will also continue to have a compile time 
> dependency on the titan 0.5.4 graph database implementation.  When this task 
> is complete, Atlas will only be accessing titan through the abstraction layer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

[Jeff Hagelberg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47810/
---

(Updated May 27, 2016, 3:48 p.m.)


Review request for atlas, David Kantor and Neeru Gupta.


Bugs: ATLAS-694
https://issues.apache.org/jira/browse/ATLAS-694


Repository: atlas


Description
---

ATLAS-694: Update Atlas to use abstraction layer.  All of the Atlas code (with 
the exception of the catalog, which was only updated minimally) has been 
updated to use the graph database abstraction layer.  In addition, there is now 
a required Atlas configuration property that specifies the class of the 
abstraction layer database to use.  I basically put all of the changes in here 
with the exception of the actual Titan 1 implementation of code.  This includes 
the changes to support Tinkerpop 3 syntax.  This is mostly to expedite getting 
the changes into Atlas.  Originally the TP3 changes were going to be brought in 
as part of the Titan 1 implementation task.

Change Summary:

   - change Atlas classes to use AtlasGraph,AtlasVertex,AtlasEdge, etc instead 
of TitanGraph/Vertex/Edge, etc
   - compile time dependency on titan 0.5.4/TP 2 removed (except in Catalog, 
which was only changed to use AtlasGraphProvider/AtlasGraph)
   - updated DSL translation to generate Gremlin that is compliant with TP3 
when TP3 is being used
   - TitanGraphProvider replaced by AtlasGraphProvider.  Graph database 
implementation is determined from a new required configuration property
   - search indexer enhanced to wait for all indices to be enabled
   - HiveTitanSample is no longer used by tests.  It has been replaced by 
hive-instances.json (which uses normal Atlas json syntax).  The data is saved 
with a new JSONImporter class.  This was needed because the graphson syntax 
used by HiveTitanSample is not compatible with TP3.  
   - RepositoryMetaModule - GraphBackedSearchIndexer changed to an eager 
singleton to force index creation to happen before we execute any gremlin 
queries (which happens during the type system restoration triggered by the 
DefaultMetadataService constructor)
   - atlas_config.py - minor change to allow Atlas to use a non-default JVM.  
It now supports having the java home in ATLAS_JAVA_HOME.  If that is not set, 
we fall back to the previous behavior looking for JAVA_HOME and then checking 
the path.
   -
Note - I did remove the spurious whitespace.  So far I have not figured out how 
to update the diff.  It's kind of trickly since I only want the commits since 
the last diff generated for ATLAS-693.


Diffs (updated)
-

  addons/falcon-bridge/pom.xml 14c60901a6f194497ca0fb7929a032d2261f85fa 
  addons/hdfs-model/pom.xml f4033bce0fe3ea5a33cfd32ebccd47c01207dc35 
  addons/hdfs-model/src/test/java/org/apache/atlas/fs/model/HDFSModelTest.java 
ac60294e328835ba0340e150799ddfb348ccdb52 
  addons/hive-bridge/pom.xml 47e72e814a421f03b00a9b7c6a13163e1b67ca14 
  addons/sqoop-bridge/pom.xml 343bb4eeae93031ab24cd48ed7b535769150d6c7 
  addons/storm-bridge/pom.xml b1a7a9b1a88442d9e65db4a01b8388c8d3522bfe 
  authorization/pom.xml 74c433bf740a346d1d907a868605e9ab457151bb 
  catalog/pom.xml 8a49d3d673a5936613d45e53479aa99a5a14517d 
  catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java 
c2eabf70de57f2893a4c30a045fa8f10aaf0b837 
  
catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java 
838d4c16579efcc2519d668149610edfe78f83c5 
  distro/pom.xml 22f70ae970d3ee4ce3d56d15f0e9df5a3fa21b94 
  distro/src/bin/atlas_config.py fab4046345e05e0b7749ca75834c8bdcb0d01752 
  distro/src/conf/atlas-application.properties 
bb12538197ea47aad0cad013529c6821e1b1a766 
  graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasEdge.java 
71b577b5c2e8aee8fec816b9224672ebc2cad5b3 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasEdgeDirection.java
 e7da1c9a5075004973ba68b8a36a2c95756e0e62 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasElement.java 
3c41693e531eb523f04a5c5781f1f123ab38ef07 
  graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java 
f312117af9cb6ae8de21d565bfcf3b10d9bdfcc6 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphIndex.java
 PRE-CREATION 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java
 2776b2242c4469dcae344616ccfe100633a79432 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java
 f0dca9a28eebd8996d55d71dcc3254cce9cd4098 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java
 7ee6b2831a7610e7d5b1d36ae69282a9315dc06b 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasPropertyKey.java
 PRE-CREATION 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasSchemaViolationException.java
 

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

[Jeff Hagelberg]

> On May 25, 2016, 5:03 p.m., David Kantor wrote:
> > distro/src/bin/atlas_config.py, line 162
> > 
> >
> > Perhaps add comments here explaining the need/motivation for 
> > ATLAS_JAVA_HOME.

I added an ATLAS_JAVA_HOME as a convenient way to configure only Atlas to use a 
specific JVM.  Many environments have multiple JVMs installed, and different 
software has different JVM requirements.  In environments where the default JVM 
is not compatible with Atlas, this provides a way to configure Atlas to use a 
specific JVM without affecting other applications.  This is also a convenient 
way for developers to test Atlas with a specific JVM as well.


> On May 25, 2016, 5:03 p.m., David Kantor wrote:
> > repository/src/main/java/org/apache/atlas/repository/graph/AtlasGraphProvider.java,
> >  line 18
> > 
> >
> > Please rename this, as plugin is an overloaded term.

plugin_ was renamed to graph_


> On May 25, 2016, 5:03 p.m., David Kantor wrote:
> > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java,
> >  line 470
> > 
> >
> > What is the use case for this method?

This was refactored out of DefaultMetadataService.  It is used when converting 
the json received from clients into ITypedReferenceableInstances.  I refactored 
it so that it could be reused by the JSONImporter class that I added.


- Jeff


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47810/#review134773
---


On May 27, 2016, 3:30 p.m., Jeff Hagelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47810/
> ---
> 
> (Updated May 27, 2016, 3:30 p.m.)
> 
> 
> Review request for atlas, David Kantor and Neeru Gupta.
> 
> 
> Bugs: ATLAS-694
> https://issues.apache.org/jira/browse/ATLAS-694
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-694: Update Atlas to use abstraction layer.  All of the Atlas code 
> (with the exception of the catalog, which was only updated minimally) has 
> been updated to use the graph database abstraction layer.  In addition, there 
> is now a required Atlas configuration property that specifies the class of 
> the abstraction layer database to use.  I basically put all of the changes in 
> here with the exception of the actual Titan 1 implementation of code.  This 
> includes the changes to support Tinkerpop 3 syntax.  This is mostly to 
> expedite getting the changes into Atlas.  Originally the TP3 changes were 
> going to be brought in as part of the Titan 1 implementation task.
> 
> Change Summary:
> 
>- change Atlas classes to use AtlasGraph,AtlasVertex,AtlasEdge, etc 
> instead of TitanGraph/Vertex/Edge, etc
>- compile time dependency on titan 0.5.4/TP 2 removed (except in Catalog, 
> which was only changed to use AtlasGraphProvider/AtlasGraph)
>- updated DSL translation to generate Gremlin that is compliant with TP3 
> when TP3 is being used
>- TitanGraphProvider replaced by AtlasGraphProvider.  Graph database 
> implementation is determined from a new required configuration property
>- search indexer enhanced to wait for all indices to be enabled
>- HiveTitanSample is no longer used by tests.  It has been replaced by 
> hive-instances.json (which uses normal Atlas json syntax).  The data is saved 
> with a new JSONImporter class.  This was needed because the graphson syntax 
> used by HiveTitanSample is not compatible with TP3.  
>- RepositoryMetaModule - GraphBackedSearchIndexer changed to an eager 
> singleton to force index creation to happen before we execute any gremlin 
> queries (which happens during the type system restoration triggered by the 
> DefaultMetadataService constructor)
>- atlas_config.py - minor change to allow Atlas to use a non-default JVM.  
> It now supports having the java home in ATLAS_JAVA_HOME.  If that is not set, 
> we fall back to the previous behavior looking for JAVA_HOME and then checking 
> the path.
>-
> Note - I did remove the spurious whitespace.  So far I have not figured out 
> how to update the diff.  It's kind of trickly since I only want the commits 
> since the last diff generated for ATLAS-693.
> 
> 
> Diffs
> -
> 
>   addons/falcon-bridge/pom.xml 14c60901a6f194497ca0fb7929a032d2261f85fa 
>   addons/hdfs-model/pom.xml f4033bce0fe3ea5a33cfd32ebccd47c01207dc35 
>   
> addons/hdfs-model/src/test/java/org/apache/atlas/fs/model/HDFSModelTest.java 
> ac60294e328835ba0340e150799ddfb348ccdb52 
>   addons/hive-bridge/pom.xml 

Re: Review Request 47898: Implement Business Catalog Delete

[John Speidel]

> On May 27, 2016, 7:06 a.m., Hemanth Yamijala wrote:
> > catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java,
> >  line 32
> > 
> >
> > Trying to understand why we are lazy-initializing this? It doesn't seem 
> > to be a costly resource to initialize at construction time, no? Would 
> > remove the need for synchronization.

Yeah, lazy initialization is no longer beneficial. I will change.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47898/#review135171
---


On May 26, 2016, 3:52 p.m., John Speidel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47898/
> ---
> 
> (Updated May 26, 2016, 3:52 p.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-793
> https://issues.apache.org/jira/browse/ATLAS-793
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Provide support for deletion of taxonomies, terms and tags
> 
> 
> Diffs
> -
> 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java 6f2e0be 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java f3376b0 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java 
> 517eaf6 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java 
> f71c061 
>   
> catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java 
> dc4ab0d 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java 
> 4c4319c 
>   
> catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java 
> 7a46f5d 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java 
> 431b06d 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/BaseRelation.java 
> PRE-CREATION 
>   
> catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java
>  5f59bea 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java 
> a5e15c6 
>   
> catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java 
> 5f11474 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java 
> e2bc597 
>   
> catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java 
> 013bb8a 
>   
> catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java 
> 787f734 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java 
> 0065101 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java c2eabf7 
>   
> catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java
>  a95b966 
>   
> catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java
>  9cf3d12 
>   
> catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java 
> 34222ca 
>   
> catalog/src/test/java/org/apache/atlas/catalog/projection/TagRelationTest.java
>  PRE-CREATION 
>   
> catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java
>  838d4c1 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 
> 6bca3df 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java 
> 3982df8 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java 
> 0e3f4c4 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java 
> ccd0b62 
> 
> Diff: https://reviews.apache.org/r/47898/diff/
> 
> 
> Testing
> ---
> 
> - Added new unit tests
> - Ran all existing unit tests
> - Manual functional testing of all new functionality
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

[Jeff Hagelberg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47810/
---

(Updated May 27, 2016, 3:30 p.m.)


Review request for atlas, David Kantor and Neeru Gupta.


Changes
---

Updated diff.  Note: this diff is cumulative.  I could not figure out how to 
get it to only show the changes since ATLAS-693 (which has not been committed).


Bugs: ATLAS-694
https://issues.apache.org/jira/browse/ATLAS-694


Repository: atlas


Description
---

ATLAS-694: Update Atlas to use abstraction layer.  All of the Atlas code (with 
the exception of the catalog, which was only updated minimally) has been 
updated to use the graph database abstraction layer.  In addition, there is now 
a required Atlas configuration property that specifies the class of the 
abstraction layer database to use.  I basically put all of the changes in here 
with the exception of the actual Titan 1 implementation of code.  This includes 
the changes to support Tinkerpop 3 syntax.  This is mostly to expedite getting 
the changes into Atlas.  Originally the TP3 changes were going to be brought in 
as part of the Titan 1 implementation task.

Change Summary:

   - change Atlas classes to use AtlasGraph,AtlasVertex,AtlasEdge, etc instead 
of TitanGraph/Vertex/Edge, etc
   - compile time dependency on titan 0.5.4/TP 2 removed (except in Catalog, 
which was only changed to use AtlasGraphProvider/AtlasGraph)
   - updated DSL translation to generate Gremlin that is compliant with TP3 
when TP3 is being used
   - TitanGraphProvider replaced by AtlasGraphProvider.  Graph database 
implementation is determined from a new required configuration property
   - search indexer enhanced to wait for all indices to be enabled
   - HiveTitanSample is no longer used by tests.  It has been replaced by 
hive-instances.json (which uses normal Atlas json syntax).  The data is saved 
with a new JSONImporter class.  This was needed because the graphson syntax 
used by HiveTitanSample is not compatible with TP3.  
   - RepositoryMetaModule - GraphBackedSearchIndexer changed to an eager 
singleton to force index creation to happen before we execute any gremlin 
queries (which happens during the type system restoration triggered by the 
DefaultMetadataService constructor)
   - atlas_config.py - minor change to allow Atlas to use a non-default JVM.  
It now supports having the java home in ATLAS_JAVA_HOME.  If that is not set, 
we fall back to the previous behavior looking for JAVA_HOME and then checking 
the path.
   -
Note - I did remove the spurious whitespace.  So far I have not figured out how 
to update the diff.  It's kind of trickly since I only want the commits since 
the last diff generated for ATLAS-693.


Diffs (updated)
-

  addons/falcon-bridge/pom.xml 14c60901a6f194497ca0fb7929a032d2261f85fa 
  addons/hdfs-model/pom.xml f4033bce0fe3ea5a33cfd32ebccd47c01207dc35 
  addons/hdfs-model/src/test/java/org/apache/atlas/fs/model/HDFSModelTest.java 
ac60294e328835ba0340e150799ddfb348ccdb52 
  addons/hive-bridge/pom.xml 47e72e814a421f03b00a9b7c6a13163e1b67ca14 
  addons/sqoop-bridge/pom.xml 343bb4eeae93031ab24cd48ed7b535769150d6c7 
  addons/storm-bridge/pom.xml b1a7a9b1a88442d9e65db4a01b8388c8d3522bfe 
  authorization/pom.xml 74c433bf740a346d1d907a868605e9ab457151bb 
  catalog/pom.xml 8a49d3d673a5936613d45e53479aa99a5a14517d 
  catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java 
c2eabf70de57f2893a4c30a045fa8f10aaf0b837 
  
catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java 
838d4c16579efcc2519d668149610edfe78f83c5 
  distro/pom.xml 22f70ae970d3ee4ce3d56d15f0e9df5a3fa21b94 
  distro/src/bin/atlas_config.py fab4046345e05e0b7749ca75834c8bdcb0d01752 
  distro/src/conf/atlas-application.properties 
bb12538197ea47aad0cad013529c6821e1b1a766 
  graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasEdge.java 
71b577b5c2e8aee8fec816b9224672ebc2cad5b3 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasEdgeDirection.java
 e7da1c9a5075004973ba68b8a36a2c95756e0e62 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasElement.java 
3c41693e531eb523f04a5c5781f1f123ab38ef07 
  graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java 
f312117af9cb6ae8de21d565bfcf3b10d9bdfcc6 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphIndex.java
 PRE-CREATION 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java
 2776b2242c4469dcae344616ccfe100633a79432 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java
 f0dca9a28eebd8996d55d71dcc3254cce9cd4098 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java
 7ee6b2831a7610e7d5b1d36ae69282a9315dc06b 
  

Re: Review Request 47898: Implement Business Catalog Delete

[John Speidel]

> On May 27, 2016, 7:01 a.m., Hemanth Yamijala wrote:
> > catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java,
> >  line 102
> > 
> >
> > Do we need this call? The call to deleteTag seems to be throwing an 
> > EntityNotFoundException if the entity is not found. That can be caught and 
> > handled. This will help avoid an additional lookup call to the entity.

Yeah, that would be better. It looks like I can catch TraitNotFoundException in 
DefaultTypeSystem.deleteTrait() and change the signature to throw 
ResourceNotFound and avoid this overhead as you stated.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47898/#review135170
---


On May 26, 2016, 3:52 p.m., John Speidel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47898/
> ---
> 
> (Updated May 26, 2016, 3:52 p.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-793
> https://issues.apache.org/jira/browse/ATLAS-793
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Provide support for deletion of taxonomies, terms and tags
> 
> 
> Diffs
> -
> 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java 6f2e0be 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java f3376b0 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java 
> 517eaf6 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java 
> f71c061 
>   
> catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java 
> dc4ab0d 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java 
> 4c4319c 
>   
> catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java 
> 7a46f5d 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java 
> 431b06d 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/BaseRelation.java 
> PRE-CREATION 
>   
> catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java
>  5f59bea 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java 
> a5e15c6 
>   
> catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java 
> 5f11474 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java 
> e2bc597 
>   
> catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java 
> 013bb8a 
>   
> catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java 
> 787f734 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java 
> 0065101 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java c2eabf7 
>   
> catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java
>  a95b966 
>   
> catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java
>  9cf3d12 
>   
> catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java 
> 34222ca 
>   
> catalog/src/test/java/org/apache/atlas/catalog/projection/TagRelationTest.java
>  PRE-CREATION 
>   
> catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java
>  838d4c1 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 
> 6bca3df 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java 
> 3982df8 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java 
> 0e3f4c4 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java 
> ccd0b62 
> 
> Diff: https://reviews.apache.org/r/47898/diff/
> 
> 
> Testing
> ---
> 
> - Added new unit tests
> - Ran all existing unit tests
> - Manual functional testing of all new functionality
> 
> 
> Thanks,
> 
> John Speidel
> 
>

[jira] [Issue Comment Deleted] (ATLAS-829) When moved from embedded to standalone hbase, HBASE_CONF_DIR should point to the standalone instance of hbase, otherwise atlas fails to comeup

[Ayub Khan (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ayub Khan updated ATLAS-829:

Comment: was deleted

(was: [~madhan.neethiraj] Yes, I have manually updated HBASE_CONF_DIR when 
moved from embedded to external hbase. 
My expectation from this jira is, 
1) The above should be documented.
2) Also, I remember there was discussion around, if HBase standalone is 
installed as part of cluster deployment through ambari/blueprint, Atlas should 
be configured to use the standalone hbase. In this case as well, HBASE_CONF_DIR 
should be updated.)

> When moved from embedded to standalone hbase, HBASE_CONF_DIR should point to 
> the standalone instance of hbase, otherwise atlas fails to comeup
> --
>
> Key: ATLAS-829
> URL: https://issues.apache.org/jira/browse/ATLAS-829
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Ayub Khan
> Fix For: 0.7-incubating
>
>
> When moved from embedded to standalone hbase, HBASE_CONF_DIR in atlas-env.sh 
> should point to the standalone instance of hbase, otherwise atlas fails to 
> comeup.
> {noformat}
> 2016-05-26 08:35:13,642 INFO  - 
> [main-SendThread(os-r7-wbucju-atlas-re-1.openstacklocal:2181):] ~ Session 
> establishment complete on server 
> os-r7-wbucju-atlas-re-1.openstacklocal/172.22.90.58:2181, sessionid = 
> 0x154e76760e90022, negotiated timeout = 4 (ClientCnxn:1279)
> 2016-05-26 08:35:13,661 INFO  - [main:] ~ ClusterId read in ZooKeeper is null 
> (ZooKeeperRegistry:107)
> 2016-05-26 08:35:13,853 WARN  - [main:] ~ Unexpected exception during 
> getDeployment() (HBaseStoreManager:397)
> java.lang.RuntimeException: java.lang.NullPointerException
> at 
> org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithoutRetries(RpcRetryingCaller.java:208)
> at 
> org.apache.hadoop.hbase.client.ClientScanner.call(ClientScanner.java:326)
> at 
> org.apache.hadoop.hbase.client.ClientScanner.nextScanner(ClientScanner.java:301)
> at 
> org.apache.hadoop.hbase.client.ClientScanner.initializeScannerInConstruction(ClientScanner.java:166)
> at 
> org.apache.hadoop.hbase.client.ClientScanner.(ClientScanner.java:161)
> at org.apache.hadoop.hbase.client.HTable.getScanner(HTable.java:821)
> at 
> org.apache.hadoop.hbase.MetaTableAccessor.fullScan(MetaTableAccessor.java:602)
> at 
> org.apache.hadoop.hbase.MetaTableAccessor.tableExists(MetaTableAccessor.java:366)
> at 
> org.apache.hadoop.hbase.client.HBaseAdmin.tableExists(HBaseAdmin.java:397)
> at 
> com.thinkaurelius.titan.diskstorage.hbase.HBaseAdmin1_0.tableExists(HBaseAdmin1_0.java:78)
> at 
> com.thinkaurelius.titan.diskstorage.hbase.HBaseStoreManager.ensureTableExists(HBaseStoreManager.java:708)
> at 
> com.thinkaurelius.titan.diskstorage.hbase.HBaseStoreManager.getLocalKeyPartition(HBaseStoreManager.java:511)
> at 
> com.thinkaurelius.titan.diskstorage.hbase.HBaseStoreManager.getDeployment(HBaseStoreManager.java:352)
> at 
> com.thinkaurelius.titan.diskstorage.hbase.HBaseStoreManager.getFeatures(HBaseStoreManager.java:395)
> at 
> com.thinkaurelius.titan.graphdb.configuration.GraphDatabaseConfiguration.(GraphDatabaseConfiguration.java:1276)
> at 
> com.thinkaurelius.titan.core.TitanFactory.open(TitanFactory.java:93)
> at 
> com.thinkaurelius.titan.core.TitanFactory.open(TitanFactory.java:73)
> at 
> org.apache.atlas.repository.graph.TitanGraphProvider.getGraphInstance(TitanGraphProvider.java:105)
> at 
> org.apache.atlas.repository.graph.GraphHelper.(GraphHelper.java:64)
> at 
> org.apache.atlas.repository.graph.DeleteHandler.(DeleteHandler.java:50)
> at java.lang.Class.forName0(Native Method)
> at java.lang.Class.forName(Class.java:190)
> at 
> org.apache.atlas.ApplicationProperties.getClass(ApplicationProperties.java:102)
> at 
> org.apache.atlas.RepositoryMetadataModule.getDeleteHandler(RepositoryMetadataModule.java:115)
> at 
> org.apache.atlas.RepositoryMetadataModule.configure(RepositoryMetadataModule.java:90)
> at com.google.inject.AbstractModule.configure(AbstractModule.java:62)
> at 
> com.google.inject.spi.Elements$RecordingBinder.install(Elements.java:340)
> at com.google.inject.spi.Elements.getElements(Elements.java:110)
> at 
> com.google.inject.internal.InjectorShell$Builder.build(InjectorShell.java:138)
> at 
> com.google.inject.internal.InternalInjectorCreator.build(InternalInjectorCreator.java:104)
> at com.google.inject.Guice.createInjector(Guice.java:96)
> at 

[jira] [Commented] (ATLAS-829) When moved from embedded to standalone hbase, HBASE_CONF_DIR should point to the standalone instance of hbase, otherwise atlas fails to comeup

[Ayub Khan (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304084#comment-15304084
 ] 

Ayub Khan commented on ATLAS-829:
-

[~madhan.neethiraj] Yes, I have manually updated HBASE_CONF_DIR when moved from 
embedded to external hbase. 
My expectation from this jira is, 
1) The above should be documented.
2) Also, I remember there was discussion around, if HBase standalone is 
installed as part of cluster deployment through ambari/blueprint, Atlas should 
be configured to use the standalone hbase. In this case as well, HBASE_CONF_DIR 
should be updated.

> When moved from embedded to standalone hbase, HBASE_CONF_DIR should point to 
> the standalone instance of hbase, otherwise atlas fails to comeup
> --
>
> Key: ATLAS-829
> URL: https://issues.apache.org/jira/browse/ATLAS-829
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Ayub Khan
> Fix For: 0.7-incubating
>
>
> When moved from embedded to standalone hbase, HBASE_CONF_DIR in atlas-env.sh 
> should point to the standalone instance of hbase, otherwise atlas fails to 
> comeup.
> {noformat}
> 2016-05-26 08:35:13,642 INFO  - 
> [main-SendThread(os-r7-wbucju-atlas-re-1.openstacklocal:2181):] ~ Session 
> establishment complete on server 
> os-r7-wbucju-atlas-re-1.openstacklocal/172.22.90.58:2181, sessionid = 
> 0x154e76760e90022, negotiated timeout = 4 (ClientCnxn:1279)
> 2016-05-26 08:35:13,661 INFO  - [main:] ~ ClusterId read in ZooKeeper is null 
> (ZooKeeperRegistry:107)
> 2016-05-26 08:35:13,853 WARN  - [main:] ~ Unexpected exception during 
> getDeployment() (HBaseStoreManager:397)
> java.lang.RuntimeException: java.lang.NullPointerException
> at 
> org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithoutRetries(RpcRetryingCaller.java:208)
> at 
> org.apache.hadoop.hbase.client.ClientScanner.call(ClientScanner.java:326)
> at 
> org.apache.hadoop.hbase.client.ClientScanner.nextScanner(ClientScanner.java:301)
> at 
> org.apache.hadoop.hbase.client.ClientScanner.initializeScannerInConstruction(ClientScanner.java:166)
> at 
> org.apache.hadoop.hbase.client.ClientScanner.(ClientScanner.java:161)
> at org.apache.hadoop.hbase.client.HTable.getScanner(HTable.java:821)
> at 
> org.apache.hadoop.hbase.MetaTableAccessor.fullScan(MetaTableAccessor.java:602)
> at 
> org.apache.hadoop.hbase.MetaTableAccessor.tableExists(MetaTableAccessor.java:366)
> at 
> org.apache.hadoop.hbase.client.HBaseAdmin.tableExists(HBaseAdmin.java:397)
> at 
> com.thinkaurelius.titan.diskstorage.hbase.HBaseAdmin1_0.tableExists(HBaseAdmin1_0.java:78)
> at 
> com.thinkaurelius.titan.diskstorage.hbase.HBaseStoreManager.ensureTableExists(HBaseStoreManager.java:708)
> at 
> com.thinkaurelius.titan.diskstorage.hbase.HBaseStoreManager.getLocalKeyPartition(HBaseStoreManager.java:511)
> at 
> com.thinkaurelius.titan.diskstorage.hbase.HBaseStoreManager.getDeployment(HBaseStoreManager.java:352)
> at 
> com.thinkaurelius.titan.diskstorage.hbase.HBaseStoreManager.getFeatures(HBaseStoreManager.java:395)
> at 
> com.thinkaurelius.titan.graphdb.configuration.GraphDatabaseConfiguration.(GraphDatabaseConfiguration.java:1276)
> at 
> com.thinkaurelius.titan.core.TitanFactory.open(TitanFactory.java:93)
> at 
> com.thinkaurelius.titan.core.TitanFactory.open(TitanFactory.java:73)
> at 
> org.apache.atlas.repository.graph.TitanGraphProvider.getGraphInstance(TitanGraphProvider.java:105)
> at 
> org.apache.atlas.repository.graph.GraphHelper.(GraphHelper.java:64)
> at 
> org.apache.atlas.repository.graph.DeleteHandler.(DeleteHandler.java:50)
> at java.lang.Class.forName0(Native Method)
> at java.lang.Class.forName(Class.java:190)
> at 
> org.apache.atlas.ApplicationProperties.getClass(ApplicationProperties.java:102)
> at 
> org.apache.atlas.RepositoryMetadataModule.getDeleteHandler(RepositoryMetadataModule.java:115)
> at 
> org.apache.atlas.RepositoryMetadataModule.configure(RepositoryMetadataModule.java:90)
> at com.google.inject.AbstractModule.configure(AbstractModule.java:62)
> at 
> com.google.inject.spi.Elements$RecordingBinder.install(Elements.java:340)
> at com.google.inject.spi.Elements.getElements(Elements.java:110)
> at 
> com.google.inject.internal.InjectorShell$Builder.build(InjectorShell.java:138)
> at 
> com.google.inject.internal.InternalInjectorCreator.build(InternalInjectorCreator.java:104)
> at com.google.inject.Guice.createInjector(Guice.java:96)
> at 

[jira] [Commented] (ATLAS-832) atlas_start should start embedded hbase and solr with -Pembedded_services

[Tom Beerbower (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304022#comment-15304022
 ] 

Tom Beerbower commented on ATLAS-832:
-

building with embedded_services profile does start the services but you need to 
run atlas-env.sh first ...

{code}
>>source ./conf/atlas-env.sh 
>>echo $MANAGE_LOCAL_HBASE
true
>>echo $MANAGE_LOCAL_SOLR
true
>>bin/atlas_start.py 
configured for local hbase.
hbase started.
configured for local solr.
solr started.
setting up solr collections...
Apache Atlas Server started!!!
{code}

> atlas_start should start embedded hbase and solr with -Pembedded_services
> -
>
> Key: ATLAS-832
> URL: https://issues.apache.org/jira/browse/ATLAS-832
> Project: Atlas
>  Issue Type: Bug
>Reporter: Shwetha G S
>Assignee: Tom Beerbower
> Fix For: 0.7-incubating
>
>
> As part of ATLAS-823, embedded hbase and solr was moved to profile 
> 'embedded_services'. After the package is built using '-Pembedded_services', 
> the package configuration points to local hbase and solr, but atlas_start 
> doesn't start embedded hbase and solr



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 47782: Atlas should use external HBase and SOLR

[Tom Beerbower]

On May 26, 2016, 6:04 p.m., Tom Beerbower wrote:
> > In the package built using  '-Pdist,embedded_services', atlas_start doesn't 
> > start embedded hbase and solr. is that expected?
> 
> Tom Beerbower wrote:
> You have to run atlas-env.sh first.
> 
> Shwetha GS wrote:
> Can't atlas_start.py and atlas_stop.py in trun run atlas-env.sh, instead 
> of adding this as an extra manual step?
> 
> Tom Beerbower wrote:
> I guess that it could but atlas-env.sh isn't new.  It has always been a 
> requirement to run it first.
> 
> Shwetha GS wrote:
> From InstallationSteps.twiki:
> atlas-env.sh has been added to the Atlas conf. This file can be used to 
> set various environment
> variables that you need for you services. In addition you can set any 
> other environment
> variables you might need. This file will be sourced by atlas scripts 
> before any commands are
> executed.
> 
> I think the intention was to run atlas-env.sh as part of atlas_start 
> always, but was missed. Thats how it is even in hive:
> bin$ grep -r hive-env.sh *
> hive:if [ -f "${HIVE_CONF_DIR}/hive-env.sh" ]; then
> hive:  . "${HIVE_CONF_DIR}/hive-env.sh"
> 
> Your call if you want to address that as part of another jira
> 
> Shwetha GS wrote:
> Running atlas-env.sh before atlas_start didn't start hbase and solr:
> apache-atlas-0.7-incubating-SNAPSHOT$ ./conf/atlas-env.sh
> apache-atlas-0.7-incubating-SNAPSHOT$ ./bin/atlas_start.py
> Apache Atlas Server started!!!

This works ...

>>source ./conf/atlas-env.sh 
>>echo $MANAGE_LOCAL_HBASE
true
>>echo $MANAGE_LOCAL_SOLR
true
>>bin/atlas_start.py 
configured for local hbase.
hbase started.
configured for local solr.
solr started.
setting up solr collections...
Apache Atlas Server started!!!


- Tom


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47782/#review135028
---


On May 26, 2016, 7:14 p.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47782/
> ---
> 
> (Updated May 26, 2016, 7:14 p.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-823
> https://issues.apache.org/jira/browse/ATLAS-823
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Use of embedded HBase and SOLR is not preferred due to multiple concerns, 
> including:
> 
> 1. lack of support by Ambari makes it difficult to handle kerberization, 
> upgrade/migration, start/stop
> 2. not suitable for production use - no HA, local-storage
> 
> Atlas should remove support for embedded HBase and SOLR. Instead Atlas should 
> be updated to use external HBase and SOLR.
> 
> 
> Diffs
> -
> 
>   distro/pom.xml 1ab092d 
>   distro/src/bin/atlas_config.py 8f3479c 
>   distro/src/bin/atlas_start.py cb869bb 
>   distro/src/conf/atlas-application.properties 26f84e9 
>   distro/src/conf/atlas-env.sh 4f1f46c 
>   distro/src/main/assemblies/standalone-package.xml 09ff47d 
>   docs/src/site/twiki/Configuration.twiki 879c06c 
>   docs/src/site/twiki/InstallationSteps.twiki 006e1e8 
> 
> Diff: https://reviews.apache.org/r/47782/diff/
> 
> 
> Testing
> ---
> 
> updated unit test
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>

Build failed in Jenkins: apache-atlas-nightly #291

[Apache Jenkins Server]

See 

Changes:

[sshivalingamurthy] ATLAS-823 Atlas should use external HBase and SOLR 
(tbeerbower via

--
[...truncated 5870 lines...]
[INFO] Copying 3 resources
[INFO] Copying 2 resources to META-INF
[INFO] Copying 3 resources
[INFO] 
[INFO] --- scala-maven-plugin:3.2.0:compile (scala-compile-first) @ 
atlas-webapp ---
[WARNING] Zinc server is not available at port 3030 - reverting to normal 
incremental compile
[INFO] Using incremental compilation
[INFO] Compiling 55 Java sources to 

[WARNING] Note: 

 uses or overrides a deprecated API.
[WARNING] Note: Recompile with -Xlint:deprecation for details.
[WARNING] Note: Some input files use unchecked or unsafe operations.
[WARNING] Note: Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ atlas-webapp 
---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 55 source files to 

[WARNING] 
:
 

 uses or overrides a deprecated API.
[WARNING] 
:
 Recompile with -Xlint:deprecation for details.
[WARNING] 
:
 Some input files use unchecked or unsafe operations.
[WARNING] 
:
 Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-resources-plugin:2.7:testResources (default-testResources) @ 
atlas-webapp ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- scala-maven-plugin:3.2.0:testCompile (scala-test-compile-first) @ 
atlas-webapp ---
[WARNING] Zinc server is not available at port 3030 - reverting to normal 
incremental compile
[INFO] Using incremental compilation
[INFO] Compiling 40 Java sources to 

[WARNING] Note: Some input files use unchecked or unsafe operations.
[WARNING] Note: Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @ 
atlas-webapp ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 40 source files to 

[WARNING] 
:
 Some input files use unchecked or unsafe operations.
[WARNING] 
:
 Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-war-plugin:2.6:war (default-war) @ atlas-webapp ---
[INFO] Packaging webapp
[INFO] Assembling webapp [atlas-webapp] in 
[
[INFO] Processing overlay [ id org.apache.atlas:atlas-dashboardv2]
[INFO] Processing war project
[INFO] Copying webapp resources 
[
[INFO] Building jar: 

[INFO] Webapp assembled in [584 msecs]
[INFO] Building war: 

[INFO] 
[INFO] --- maven-site-plugin:3.4:attach-descriptor (attach-descriptor) @ 
atlas-webapp ---
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ atlas-webapp ---
[WARNING] The parameter forkMode is deprecated since version 2.14. Use 
forkCount and reuseForks instead.
[INFO] Surefire report directory: 

[INFO] Using configured provider org.apache.maven.surefire.testng.TestNGProvider
[WARNING] 

[jira] [Created] (ATLAS-832) atlas_start should start embedded hbase and solr with -Pembedded_services

[Shwetha G S (JIRA)]

Shwetha G S created ATLAS-832:
-

 Summary: atlas_start should start embedded hbase and solr with 
-Pembedded_services
 Key: ATLAS-832
 URL: https://issues.apache.org/jira/browse/ATLAS-832
 Project: Atlas
  Issue Type: Bug
Reporter: Shwetha G S
Assignee: Tom Beerbower
 Fix For: 0.7-incubating


As part of ATLAS-823, embedded hbase and solr was moved to profile 
'embedded_services'. After the package is built using '-Pembedded_services', 
the package configuration points to local hbase and solr, but atlas_start 
doesn't start embedded hbase and solr



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 47782: Atlas should use external HBase and SOLR

[Shwetha GS]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47782/#review135220
---


Ship it!




Since the default build works, committing this. Filed 
https://issues.apache.org/jira/browse/ATLAS-832 to track starting hbase and 
solr with atlas_start with 'embedded-services' profile

- Shwetha GS


On May 26, 2016, 7:14 p.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47782/
> ---
> 
> (Updated May 26, 2016, 7:14 p.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-823
> https://issues.apache.org/jira/browse/ATLAS-823
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Use of embedded HBase and SOLR is not preferred due to multiple concerns, 
> including:
> 
> 1. lack of support by Ambari makes it difficult to handle kerberization, 
> upgrade/migration, start/stop
> 2. not suitable for production use - no HA, local-storage
> 
> Atlas should remove support for embedded HBase and SOLR. Instead Atlas should 
> be updated to use external HBase and SOLR.
> 
> 
> Diffs
> -
> 
>   distro/pom.xml 1ab092d 
>   distro/src/bin/atlas_config.py 8f3479c 
>   distro/src/bin/atlas_start.py cb869bb 
>   distro/src/conf/atlas-application.properties 26f84e9 
>   distro/src/conf/atlas-env.sh 4f1f46c 
>   distro/src/main/assemblies/standalone-package.xml 09ff47d 
>   docs/src/site/twiki/Configuration.twiki 879c06c 
>   docs/src/site/twiki/InstallationSteps.twiki 006e1e8 
> 
> Diff: https://reviews.apache.org/r/47782/diff/
> 
> 
> Testing
> ---
> 
> updated unit test
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>

Re: Review Request 47782: Atlas should use external HBase and SOLR

[Shwetha GS]

On May 26, 2016, 6:04 p.m., Tom Beerbower wrote:
> > In the package built using  '-Pdist,embedded_services', atlas_start doesn't 
> > start embedded hbase and solr. is that expected?
> 
> Tom Beerbower wrote:
> You have to run atlas-env.sh first.
> 
> Shwetha GS wrote:
> Can't atlas_start.py and atlas_stop.py in trun run atlas-env.sh, instead 
> of adding this as an extra manual step?
> 
> Tom Beerbower wrote:
> I guess that it could but atlas-env.sh isn't new.  It has always been a 
> requirement to run it first.
> 
> Shwetha GS wrote:
> From InstallationSteps.twiki:
> atlas-env.sh has been added to the Atlas conf. This file can be used to 
> set various environment
> variables that you need for you services. In addition you can set any 
> other environment
> variables you might need. This file will be sourced by atlas scripts 
> before any commands are
> executed.
> 
> I think the intention was to run atlas-env.sh as part of atlas_start 
> always, but was missed. Thats how it is even in hive:
> bin$ grep -r hive-env.sh *
> hive:if [ -f "${HIVE_CONF_DIR}/hive-env.sh" ]; then
> hive:  . "${HIVE_CONF_DIR}/hive-env.sh"
> 
> Your call if you want to address that as part of another jira

Running atlas-env.sh before atlas_start didn't start hbase and solr:
apache-atlas-0.7-incubating-SNAPSHOT$ ./conf/atlas-env.sh
apache-atlas-0.7-incubating-SNAPSHOT$ ./bin/atlas_start.py
Apache Atlas Server started!!!


- Shwetha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47782/#review135028
---


On May 26, 2016, 7:14 p.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47782/
> ---
> 
> (Updated May 26, 2016, 7:14 p.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-823
> https://issues.apache.org/jira/browse/ATLAS-823
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Use of embedded HBase and SOLR is not preferred due to multiple concerns, 
> including:
> 
> 1. lack of support by Ambari makes it difficult to handle kerberization, 
> upgrade/migration, start/stop
> 2. not suitable for production use - no HA, local-storage
> 
> Atlas should remove support for embedded HBase and SOLR. Instead Atlas should 
> be updated to use external HBase and SOLR.
> 
> 
> Diffs
> -
> 
>   distro/pom.xml 1ab092d 
>   distro/src/bin/atlas_config.py 8f3479c 
>   distro/src/bin/atlas_start.py cb869bb 
>   distro/src/conf/atlas-application.properties 26f84e9 
>   distro/src/conf/atlas-env.sh 4f1f46c 
>   distro/src/main/assemblies/standalone-package.xml 09ff47d 
>   docs/src/site/twiki/Configuration.twiki 879c06c 
>   docs/src/site/twiki/InstallationSteps.twiki 006e1e8 
> 
> Diff: https://reviews.apache.org/r/47782/diff/
> 
> 
> Testing
> ---
> 
> updated unit test
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>

Build failed in Jenkins: apache-atlas-nightly #290

[Apache Jenkins Server]

See 

Changes:

[sshivalingamurthy] ATLAS-752 Column renames should retain traits/tags 
(svimal2106 via

--
[...truncated 5870 lines...]
[INFO] Copying 3 resources
[INFO] Copying 2 resources to META-INF
[INFO] Copying 3 resources
[INFO] 
[INFO] --- scala-maven-plugin:3.2.0:compile (scala-compile-first) @ 
atlas-webapp ---
[WARNING] Zinc server is not available at port 3030 - reverting to normal 
incremental compile
[INFO] Using incremental compilation
[INFO] Compiling 55 Java sources to 

[WARNING] Note: 

 uses or overrides a deprecated API.
[WARNING] Note: Recompile with -Xlint:deprecation for details.
[WARNING] Note: Some input files use unchecked or unsafe operations.
[WARNING] Note: Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ atlas-webapp 
---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 55 source files to 

[WARNING] 
:
 

 uses or overrides a deprecated API.
[WARNING] 
:
 Recompile with -Xlint:deprecation for details.
[WARNING] 
:
 Some input files use unchecked or unsafe operations.
[WARNING] 
:
 Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-resources-plugin:2.7:testResources (default-testResources) @ 
atlas-webapp ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- scala-maven-plugin:3.2.0:testCompile (scala-test-compile-first) @ 
atlas-webapp ---
[WARNING] Zinc server is not available at port 3030 - reverting to normal 
incremental compile
[INFO] Using incremental compilation
[INFO] Compiling 40 Java sources to 

[WARNING] Note: Some input files use unchecked or unsafe operations.
[WARNING] Note: Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @ 
atlas-webapp ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 40 source files to 

[WARNING] 
:
 Some input files use unchecked or unsafe operations.
[WARNING] 
:
 Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-war-plugin:2.6:war (default-war) @ atlas-webapp ---
[INFO] Packaging webapp
[INFO] Assembling webapp [atlas-webapp] in 
[
[INFO] Processing overlay [ id org.apache.atlas:atlas-dashboardv2]
[INFO] Processing war project
[INFO] Copying webapp resources 
[
[INFO] Building jar: 

[INFO] Webapp assembled in [614 msecs]
[INFO] Building war: 

[INFO] 
[INFO] --- maven-site-plugin:3.4:attach-descriptor (attach-descriptor) @ 
atlas-webapp ---
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ atlas-webapp ---
[WARNING] The parameter forkMode is deprecated since version 2.14. Use 
forkCount and reuseForks instead.
[INFO] Surefire report directory: 

[INFO] Using configured provider org.apache.maven.surefire.testng.TestNGProvider
[WARNING] 

[jira] [Commented] (ATLAS-752) Column renames should retain traits/tags

[ATLAS QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15303856#comment-15303856
 ] 

ATLAS QA commented on ATLAS-752:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12806597/ATLAS-752-v5.patch
  against master revision 70f7157.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

+1 checkstyle.  The patch generated 0 code style errors.

{color:red}-1 findbugs{color}.  The patch appears to introduce 379 new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 core tests{color}.  The patch failed these unit tests in :
   
org.apache.atlas.repository.typestore.GraphBackedTypeStoreTest

Test results: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/259//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/259//artifact/patchprocess/newPatchFindbugsWarningsrepository.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/259//artifact/patchprocess/newPatchFindbugsWarningscommon.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/259//artifact/patchprocess/newPatchFindbugsWarningsnotification.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/259//artifact/patchprocess/newPatchFindbugsWarningswebapp.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/259//artifact/patchprocess/newPatchFindbugsWarningsclient.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/259//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/259//artifact/patchprocess/newPatchFindbugsWarningsfalcon-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/259//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/259//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/259//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/259//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/259//artifact/patchprocess/newPatchFindbugsWarningsauthorization.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/259//artifact/patchprocess/newPatchFindbugsWarningscatalog.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/259//artifact/patchprocess/newPatchFindbugsWarningstitan.html
Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/259//console

This message is automatically generated.

> Column renames should retain traits/tags
> 
>
> Key: ATLAS-752
> URL: https://issues.apache.org/jira/browse/ATLAS-752
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Suma Shivaprasad
>Assignee: Vimal Sharma
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-752-v2.patch, ATLAS-752-v5.patch, ATLAS-752.patch
>
>
> Currently ALTER TABLE REPLACE COLUMNS which renames a column, recreates the 
> columns since the name has changed. Instead it should just update column name 
> and qualifiedName



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 47782: Atlas should use external HBase and SOLR

[Shwetha GS]

On May 26, 2016, 6:04 p.m., Tom Beerbower wrote:
> > In the package built using  '-Pdist,embedded_services', atlas_start doesn't 
> > start embedded hbase and solr. is that expected?
> 
> Tom Beerbower wrote:
> You have to run atlas-env.sh first.
> 
> Shwetha GS wrote:
> Can't atlas_start.py and atlas_stop.py in trun run atlas-env.sh, instead 
> of adding this as an extra manual step?
> 
> Tom Beerbower wrote:
> I guess that it could but atlas-env.sh isn't new.  It has always been a 
> requirement to run it first.

>From InstallationSteps.twiki:
atlas-env.sh has been added to the Atlas conf. This file can be used to set 
various environment
variables that you need for you services. In addition you can set any other 
environment
variables you might need. This file will be sourced by atlas scripts before any 
commands are
executed.

I think the intention was to run atlas-env.sh as part of atlas_start always, 
but was missed. Thats how it is even in hive:
bin$ grep -r hive-env.sh *
hive:if [ -f "${HIVE_CONF_DIR}/hive-env.sh" ]; then
hive:  . "${HIVE_CONF_DIR}/hive-env.sh"

Your call if you want to address that as part of another jira


- Shwetha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47782/#review135028
---


On May 26, 2016, 7:14 p.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47782/
> ---
> 
> (Updated May 26, 2016, 7:14 p.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-823
> https://issues.apache.org/jira/browse/ATLAS-823
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Use of embedded HBase and SOLR is not preferred due to multiple concerns, 
> including:
> 
> 1. lack of support by Ambari makes it difficult to handle kerberization, 
> upgrade/migration, start/stop
> 2. not suitable for production use - no HA, local-storage
> 
> Atlas should remove support for embedded HBase and SOLR. Instead Atlas should 
> be updated to use external HBase and SOLR.
> 
> 
> Diffs
> -
> 
>   distro/pom.xml 1ab092d 
>   distro/src/bin/atlas_config.py 8f3479c 
>   distro/src/bin/atlas_start.py cb869bb 
>   distro/src/conf/atlas-application.properties 26f84e9 
>   distro/src/conf/atlas-env.sh 4f1f46c 
>   distro/src/main/assemblies/standalone-package.xml 09ff47d 
>   docs/src/site/twiki/Configuration.twiki 879c06c 
>   docs/src/site/twiki/InstallationSteps.twiki 006e1e8 
> 
> Diff: https://reviews.apache.org/r/47782/diff/
> 
> 
> Testing
> ---
> 
> updated unit test
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>

Re: Review Request 47782: Atlas should use external HBase and SOLR

[Tom Beerbower]

On May 26, 2016, 6:04 p.m., Tom Beerbower wrote:
> > In the package built using  '-Pdist,embedded_services', atlas_start doesn't 
> > start embedded hbase and solr. is that expected?
> 
> Tom Beerbower wrote:
> You have to run atlas-env.sh first.
> 
> Shwetha GS wrote:
> Can't atlas_start.py and atlas_stop.py in trun run atlas-env.sh, instead 
> of adding this as an extra manual step?

I guess that it could but atlas-env.sh isn't new.  It has always been a 
requirement to run it first.


- Tom


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47782/#review135028
---


On May 26, 2016, 7:14 p.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47782/
> ---
> 
> (Updated May 26, 2016, 7:14 p.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-823
> https://issues.apache.org/jira/browse/ATLAS-823
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Use of embedded HBase and SOLR is not preferred due to multiple concerns, 
> including:
> 
> 1. lack of support by Ambari makes it difficult to handle kerberization, 
> upgrade/migration, start/stop
> 2. not suitable for production use - no HA, local-storage
> 
> Atlas should remove support for embedded HBase and SOLR. Instead Atlas should 
> be updated to use external HBase and SOLR.
> 
> 
> Diffs
> -
> 
>   distro/pom.xml 1ab092d 
>   distro/src/bin/atlas_config.py 8f3479c 
>   distro/src/bin/atlas_start.py cb869bb 
>   distro/src/conf/atlas-application.properties 26f84e9 
>   distro/src/conf/atlas-env.sh 4f1f46c 
>   distro/src/main/assemblies/standalone-package.xml 09ff47d 
>   docs/src/site/twiki/Configuration.twiki 879c06c 
>   docs/src/site/twiki/InstallationSteps.twiki 006e1e8 
> 
> Diff: https://reviews.apache.org/r/47782/diff/
> 
> 
> Testing
> ---
> 
> updated unit test
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>

Re: Review Request 47782: Atlas should use external HBase and SOLR

[Shwetha GS]

On May 26, 2016, 6:04 p.m., Tom Beerbower wrote:
> > In the package built using  '-Pdist,embedded_services', atlas_start doesn't 
> > start embedded hbase and solr. is that expected?
> 
> Tom Beerbower wrote:
> You have to run atlas-env.sh first.

Can't atlas_start.py and atlas_stop.py in trun run atlas-env.sh, instead of 
adding this as an extra manual step?


- Shwetha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47782/#review135028
---


On May 26, 2016, 7:14 p.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47782/
> ---
> 
> (Updated May 26, 2016, 7:14 p.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-823
> https://issues.apache.org/jira/browse/ATLAS-823
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Use of embedded HBase and SOLR is not preferred due to multiple concerns, 
> including:
> 
> 1. lack of support by Ambari makes it difficult to handle kerberization, 
> upgrade/migration, start/stop
> 2. not suitable for production use - no HA, local-storage
> 
> Atlas should remove support for embedded HBase and SOLR. Instead Atlas should 
> be updated to use external HBase and SOLR.
> 
> 
> Diffs
> -
> 
>   distro/pom.xml 1ab092d 
>   distro/src/bin/atlas_config.py 8f3479c 
>   distro/src/bin/atlas_start.py cb869bb 
>   distro/src/conf/atlas-application.properties 26f84e9 
>   distro/src/conf/atlas-env.sh 4f1f46c 
>   distro/src/main/assemblies/standalone-package.xml 09ff47d 
>   docs/src/site/twiki/Configuration.twiki 879c06c 
>   docs/src/site/twiki/InstallationSteps.twiki 006e1e8 
> 
> Diff: https://reviews.apache.org/r/47782/diff/
> 
> 
> Testing
> ---
> 
> updated unit test
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>

[jira] [Commented] (ATLAS-793) Business Catalog Delete

[Hemanth Yamijala (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15303815#comment-15303815
 ] 

Hemanth Yamijala commented on ATLAS-793:


Actually, I verified once with master, and the warning on query requiring 
iteration over all vertices *does not* come with it. So, it is introduced by 
changes in this patch. So, I am not filing a JIRA - please take this as a 
review comment.

> Business Catalog Delete
> ---
>
> Key: ATLAS-793
> URL: https://issues.apache.org/jira/browse/ATLAS-793
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 0.7-incubating
>Reporter: Erik Bergenholtz
>Assignee: John Speidel
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-793.patch
>
>
> Business Catalog API should support deletion of Terms.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-793) Business Catalog Delete

[Hemanth Yamijala (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15303782#comment-15303782
 ] 

Hemanth Yamijala commented on ATLAS-793:


I have reviewed the patch attached to review board and raised some comments.

In addition, I tested the patch using the current UI to add & search for terms, 
and a REST client to delete them. A few issues that I see:

* For every GET call made to the term name, I see the following printed in the 
log:
{code}
Query requires iterating over all vertices [()]. For better performance, use 
indexes (StandardTitanTx:1238)
{code}
I don't think this is introduced by the delete patch. Hence, will file a 
separate JIRA for this.

* A couple of times, I saw this line:
{code}
Evicted [23@c0a8010822410-hemanthijalambp-home1] from cache but waiting too 
long for transactions to close. Stale transaction alert on: 
[standardtitantx[null], standardtitantx[null], standardtitantx[null], 
standardtitantx[null], standardtitantx[null], standardtitantx[null], 
standardtitantx[null], standardtitantx[null]] (ManagementLogger:189)
{code}
I did raise a comment on review board about issues with missing to close 
transactions in Titan. I suspect this may be related to changes done in this 
patch. I tried to replicate this by trying out specific scenarios - 
unfortunately, I couldn't do that. I will upload the application.log to the 
file in case it helps (although, it is too verbose to be useful, I suspect).

* Search for entities associated with a tag is using the same search pipeline 
as v1 search for entities, and so may suffer from the same performance 
limitations. Although in this case, I am not entirely sure if search via the v0 
API i.e. ISA DSL search is any more optimized than this. Can try and resolve 
this as part of ATLAS-807.


> Business Catalog Delete
> ---
>
> Key: ATLAS-793
> URL: https://issues.apache.org/jira/browse/ATLAS-793
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 0.7-incubating
>Reporter: Erik Bergenholtz
>Assignee: John Speidel
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-793.patch
>
>
> Business Catalog API should support deletion of Terms.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-752) Column renames should retain traits/tags

[Shwetha G S (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shwetha G S updated ATLAS-752:
--
Attachment: ATLAS-752-v5.patch

Re-based patch

> Column renames should retain traits/tags
> 
>
> Key: ATLAS-752
> URL: https://issues.apache.org/jira/browse/ATLAS-752
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Suma Shivaprasad
>Assignee: Vimal Sharma
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-752-v2.patch, ATLAS-752-v5.patch, ATLAS-752.patch
>
>
> Currently ALTER TABLE REPLACE COLUMNS which renames a column, recreates the 
> columns since the name has changed. Instead it should just update column name 
> and qualifiedName



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-635) Process showing old entity name where as actual entity is renamed.

[ATLAS QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15303743#comment-15303743
 ] 

ATLAS QA commented on ATLAS-635:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12806585/ATLAS-635-v2.patch
  against master revision 70f7157.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

+1 checkstyle.  The patch generated 0 code style errors.

{color:red}-1 findbugs{color}.  The patch appears to introduce 379 new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 core tests{color}.  The patch failed these unit tests in :
 
./webapp/test-output/junitreports/TEST-org.apache.atlas.web.resources.EntityJerseyResourceIT
./webapp/test-output/junitreports/TEST-org.apache.atlas.web.resources.MetadataDiscoveryJerseyResourceIT
./webapp/test-output/junitreports/TEST-org.apache.atlas.web.resources.RexsterGraphJerseyResourceIT
./webapp/test-output/junitreports/TEST-org.apache.atlas.web.resources.AdminJerseyResourceIT
./webapp/test-output/junitreports/TEST-org.apache.atlas.web.resources.TypesJerseyResourceIT
  
org.apache.atlas.notification.NotificationHookConsumerKafkaTest
./webapp/target/surefire-reports/junitreports/TEST-org.apache.atlas.notification.NotificationHookConsumerKafkaTest

Test results: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/258//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/258//artifact/patchprocess/newPatchFindbugsWarningsnotification.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/258//artifact/patchprocess/newPatchFindbugsWarningscatalog.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/258//artifact/patchprocess/newPatchFindbugsWarningscommon.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/258//artifact/patchprocess/newPatchFindbugsWarningsclient.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/258//artifact/patchprocess/newPatchFindbugsWarningsauthorization.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/258//artifact/patchprocess/newPatchFindbugsWarningstitan.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/258//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/258//artifact/patchprocess/newPatchFindbugsWarningsrepository.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/258//artifact/patchprocess/newPatchFindbugsWarningswebapp.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/258//artifact/patchprocess/newPatchFindbugsWarningsfalcon-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/258//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/258//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/258//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/258//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html
Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/258//console

This message is automatically generated.

> Process showing old entity name where as actual entity is renamed.
> --
>
> Key: ATLAS-635
> URL: https://issues.apache.org/jira/browse/ATLAS-635
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Ayub Khan
>Assignee: Vimal Sharma
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-635-v2.patch, ATLAS-635-v2.patch, screenshot-1.png
>
>
> Process showing old entity name where as actual entity is renamed.
> Example:
> 1. Create table as select.
> 2. Rename the target table to new name.
> 3. Now check the lineage: The process is still showing the old table name 
> where as the target table is changed. This is confusing from customer 
> perspective.
> One possible solution is:
> Source >   Process(with old name) > Target(old entity name + marked 
> as delete) ---> 

Re: Review Request 47898: Implement Business Catalog Delete

[Hemanth Yamijala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47898/#review135175
---




webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java (line 47)


Is this being done mainly as a defensive safeguard? If there is any 
exception, then I guess that transaction will remain open until any of these 
calls are made. I have seen long opened transactions cause problems and leaks 
in Titan. Preferable to ensure transactions are closed.


- Hemanth Yamijala


On May 26, 2016, 3:52 p.m., John Speidel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47898/
> ---
> 
> (Updated May 26, 2016, 3:52 p.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-793
> https://issues.apache.org/jira/browse/ATLAS-793
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Provide support for deletion of taxonomies, terms and tags
> 
> 
> Diffs
> -
> 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java 6f2e0be 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java f3376b0 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java 
> 517eaf6 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java 
> f71c061 
>   
> catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java 
> dc4ab0d 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java 
> 4c4319c 
>   
> catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java 
> 7a46f5d 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java 
> 431b06d 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/BaseRelation.java 
> PRE-CREATION 
>   
> catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java
>  5f59bea 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java 
> a5e15c6 
>   
> catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java 
> 5f11474 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java 
> e2bc597 
>   
> catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java 
> 013bb8a 
>   
> catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java 
> 787f734 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java 
> 0065101 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java c2eabf7 
>   
> catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java
>  a95b966 
>   
> catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java
>  9cf3d12 
>   
> catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java 
> 34222ca 
>   
> catalog/src/test/java/org/apache/atlas/catalog/projection/TagRelationTest.java
>  PRE-CREATION 
>   
> catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java
>  838d4c1 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 
> 6bca3df 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java 
> 3982df8 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java 
> 0e3f4c4 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java 
> ccd0b62 
> 
> Diff: https://reviews.apache.org/r/47898/diff/
> 
> 
> Testing
> ---
> 
> - Added new unit tests
> - Ran all existing unit tests
> - Manual functional testing of all new functionality
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47898: Implement Business Catalog Delete

[Hemanth Yamijala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47898/#review135174
---




catalog/src/main/java/org/apache/atlas/catalog/projection/BaseRelation.java 
(line 28)


Is it possible to fold this into the search criteria itself, so that we 
would not get these properties back.


- Hemanth Yamijala


On May 26, 2016, 3:52 p.m., John Speidel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47898/
> ---
> 
> (Updated May 26, 2016, 3:52 p.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-793
> https://issues.apache.org/jira/browse/ATLAS-793
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Provide support for deletion of taxonomies, terms and tags
> 
> 
> Diffs
> -
> 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java 6f2e0be 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java f3376b0 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java 
> 517eaf6 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java 
> f71c061 
>   
> catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java 
> dc4ab0d 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java 
> 4c4319c 
>   
> catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java 
> 7a46f5d 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java 
> 431b06d 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/BaseRelation.java 
> PRE-CREATION 
>   
> catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java
>  5f59bea 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java 
> a5e15c6 
>   
> catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java 
> 5f11474 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java 
> e2bc597 
>   
> catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java 
> 013bb8a 
>   
> catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java 
> 787f734 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java 
> 0065101 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java c2eabf7 
>   
> catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java
>  a95b966 
>   
> catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java
>  9cf3d12 
>   
> catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java 
> 34222ca 
>   
> catalog/src/test/java/org/apache/atlas/catalog/projection/TagRelationTest.java
>  PRE-CREATION 
>   
> catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java
>  838d4c1 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 
> 6bca3df 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java 
> 3982df8 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java 
> 0e3f4c4 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java 
> ccd0b62 
> 
> Diff: https://reviews.apache.org/r/47898/diff/
> 
> 
> Testing
> ---
> 
> - Added new unit tests
> - Ran all existing unit tests
> - Manual functional testing of all new functionality
> 
> 
> Thanks,
> 
> John Speidel
> 
>

[jira] [Commented] (ATLAS-635) Process showing old entity name where as actual entity is renamed.

[Vimal Sharma (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15303678#comment-15303678
 ] 

Vimal Sharma commented on ATLAS-635:


Made changes suggested by Suma and uploaded the patch

> Process showing old entity name where as actual entity is renamed.
> --
>
> Key: ATLAS-635
> URL: https://issues.apache.org/jira/browse/ATLAS-635
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Ayub Khan
>Assignee: Vimal Sharma
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-635-v2.patch, ATLAS-635-v2.patch, screenshot-1.png
>
>
> Process showing old entity name where as actual entity is renamed.
> Example:
> 1. Create table as select.
> 2. Rename the target table to new name.
> 3. Now check the lineage: The process is still showing the old table name 
> where as the target table is changed. This is confusing from customer 
> perspective.
> One possible solution is:
> Source >   Process(with old name) > Target(old entity name + marked 
> as delete) ---> Process(rename from old to new) ---> Target(with new entity 
> name).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-635) Process showing old entity name where as actual entity is renamed.

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-635:
---
Attachment: ATLAS-635-v2.patch

> Process showing old entity name where as actual entity is renamed.
> --
>
> Key: ATLAS-635
> URL: https://issues.apache.org/jira/browse/ATLAS-635
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Ayub Khan
>Assignee: Vimal Sharma
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-635-v2.patch, ATLAS-635-v2.patch, screenshot-1.png
>
>
> Process showing old entity name where as actual entity is renamed.
> Example:
> 1. Create table as select.
> 2. Rename the target table to new name.
> 3. Now check the lineage: The process is still showing the old table name 
> where as the target table is changed. This is confusing from customer 
> perspective.
> One possible solution is:
> Source >   Process(with old name) > Target(old entity name + marked 
> as delete) ---> Process(rename from old to new) ---> Target(with new entity 
> name).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 47898: Implement Business Catalog Delete

[Hemanth Yamijala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47898/#review135171
---




catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java 
(line 32)


Trying to understand why we are lazy-initializing this? It doesn't seem to 
be a costly resource to initialize at construction time, no? Would remove the 
need for synchronization.


- Hemanth Yamijala


On May 26, 2016, 3:52 p.m., John Speidel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47898/
> ---
> 
> (Updated May 26, 2016, 3:52 p.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-793
> https://issues.apache.org/jira/browse/ATLAS-793
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Provide support for deletion of taxonomies, terms and tags
> 
> 
> Diffs
> -
> 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java 6f2e0be 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java f3376b0 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java 
> 517eaf6 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java 
> f71c061 
>   
> catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java 
> dc4ab0d 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java 
> 4c4319c 
>   
> catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java 
> 7a46f5d 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java 
> 431b06d 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/BaseRelation.java 
> PRE-CREATION 
>   
> catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java
>  5f59bea 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java 
> a5e15c6 
>   
> catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java 
> 5f11474 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java 
> e2bc597 
>   
> catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java 
> 013bb8a 
>   
> catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java 
> 787f734 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java 
> 0065101 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java c2eabf7 
>   
> catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java
>  a95b966 
>   
> catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java
>  9cf3d12 
>   
> catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java 
> 34222ca 
>   
> catalog/src/test/java/org/apache/atlas/catalog/projection/TagRelationTest.java
>  PRE-CREATION 
>   
> catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java
>  838d4c1 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 
> 6bca3df 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java 
> 3982df8 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java 
> 0e3f4c4 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java 
> ccd0b62 
> 
> Diff: https://reviews.apache.org/r/47898/diff/
> 
> 
> Testing
> ---
> 
> - Added new unit tests
> - Ran all existing unit tests
> - Manual functional testing of all new functionality
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47898: Implement Business Catalog Delete

[Hemanth Yamijala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47898/#review135170
---




catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java 
(line 102)


Do we need this call? The call to deleteTag seems to be throwing an 
EntityNotFoundException if the entity is not found. That can be caught and 
handled. This will help avoid an additional lookup call to the entity.


- Hemanth Yamijala


On May 26, 2016, 3:52 p.m., John Speidel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47898/
> ---
> 
> (Updated May 26, 2016, 3:52 p.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-793
> https://issues.apache.org/jira/browse/ATLAS-793
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Provide support for deletion of taxonomies, terms and tags
> 
> 
> Diffs
> -
> 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java 6f2e0be 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java f3376b0 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java 
> 517eaf6 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java 
> f71c061 
>   
> catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java 
> dc4ab0d 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java 
> 4c4319c 
>   
> catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java 
> 7a46f5d 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java 
> 431b06d 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/BaseRelation.java 
> PRE-CREATION 
>   
> catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java
>  5f59bea 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java 
> a5e15c6 
>   
> catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java 
> 5f11474 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java 
> e2bc597 
>   
> catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java 
> 013bb8a 
>   
> catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java 
> 787f734 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java 
> 0065101 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java c2eabf7 
>   
> catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java
>  a95b966 
>   
> catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java
>  9cf3d12 
>   
> catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java 
> 34222ca 
>   
> catalog/src/test/java/org/apache/atlas/catalog/projection/TagRelationTest.java
>  PRE-CREATION 
>   
> catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java
>  838d4c1 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 
> 6bca3df 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java 
> 3982df8 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java 
> 0e3f4c4 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java 
> ccd0b62 
> 
> Diff: https://reviews.apache.org/r/47898/diff/
> 
> 
> Testing
> ---
> 
> - Added new unit tests
> - Ran all existing unit tests
> - Manual functional testing of all new functionality
> 
> 
> Thanks,
> 
> John Speidel
> 
>

[jira] [Commented] (ATLAS-635) Process showing old entity name where as actual entity is renamed.

[ATLAS QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15303623#comment-15303623
 ] 

ATLAS QA commented on ATLAS-635:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12806565/ATLAS-635-v2.patch
  against master revision 70f7157.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

+1 checkstyle.  The patch generated 0 code style errors.

{color:red}-1 findbugs{color}.  The patch appears to introduce 379 new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 core tests{color}.  The patch failed these unit tests in :
   
org.apache.atlas.repository.typestore.GraphBackedTypeStoreTest

Test results: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/257//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/257//artifact/patchprocess/newPatchFindbugsWarningswebapp.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/257//artifact/patchprocess/newPatchFindbugsWarningsauthorization.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/257//artifact/patchprocess/newPatchFindbugsWarningscommon.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/257//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/257//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/257//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/257//artifact/patchprocess/newPatchFindbugsWarningsfalcon-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/257//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/257//artifact/patchprocess/newPatchFindbugsWarningsrepository.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/257//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/257//artifact/patchprocess/newPatchFindbugsWarningscatalog.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/257//artifact/patchprocess/newPatchFindbugsWarningsclient.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/257//artifact/patchprocess/newPatchFindbugsWarningsnotification.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/257//artifact/patchprocess/newPatchFindbugsWarningstitan.html
Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/257//console

This message is automatically generated.

> Process showing old entity name where as actual entity is renamed.
> --
>
> Key: ATLAS-635
> URL: https://issues.apache.org/jira/browse/ATLAS-635
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Ayub Khan
>Assignee: Vimal Sharma
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-635-v2.patch, screenshot-1.png
>
>
> Process showing old entity name where as actual entity is renamed.
> Example:
> 1. Create table as select.
> 2. Rename the target table to new name.
> 3. Now check the lineage: The process is still showing the old table name 
> where as the target table is changed. This is confusing from customer 
> perspective.
> One possible solution is:
> Source >   Process(with old name) > Target(old entity name + marked 
> as delete) ---> Process(rename from old to new) ---> Target(with new entity 
> name).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 47638: ATLAS-752 Column rename in Hive should retain traits/tags associated with it

[Suma Shivaprasad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47638/#review135160
---


Ship it!




Ship It!

- Suma Shivaprasad


On May 26, 2016, 6:04 p.m., Vimal Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47638/
> ---
> 
> (Updated May 26, 2016, 6:04 p.m.)
> 
> 
> Review request for atlas and Shwetha GS.
> 
> 
> Bugs: ATLAS-752
> https://issues.apache.org/jira/browse/ATLAS-752
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-752 When a column is renamed, the traits associted with it are lost. 
> The traits should be retained with the new column
> 
> 
> Diffs
> -
> 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
> 418e755 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> 70100f1 
> 
> Diff: https://reviews.apache.org/r/47638/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Revised Patch
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/20/a3ab9b8c-4ffc-4ec6-92d7-1f84db246c6a__ATLAS-752-v3.patch
> 
> 
> Thanks,
> 
> Vimal Sharma
> 
>