[jira] [Created] (ATLAS-1107) Continuation timeout detection in cxf-rt-transports-http-jetty

2016-08-08 Thread onder sezgin (JIRA)
onder sezgin created ATLAS-1107:
---

 Summary: Continuation timeout detection in 
cxf-rt-transports-http-jetty
 Key: ATLAS-1107
 URL: https://issues.apache.org/jira/browse/ATLAS-1107
 Project: Atlas
  Issue Type: Improvement
Reporter: onder sezgin


CAMEL-10171 has memory leak, and before avoiding memory leak, i want to 
implement some missing methods to propagate the continuation timeout by adding 
some methods like isExpired in 
org.apache.cxf.transport.http_jetty.continuations.JettyContinuationWrapper



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ATLAS-991) Lower bound checking not always disabled for Entities being deleted

2016-08-08 Thread David Kantor (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Kantor updated ATLAS-991:
---
Attachment: rb49869.patch

Rebased and addressed review comments. [~shwethags]  Kindly review latest 
changes on review board.  If there are no further comments, please commit the 
patch.  Thanks...

> Lower bound checking not always disabled for Entities being deleted
> ---
>
> Key: ATLAS-991
> URL: https://issues.apache.org/jira/browse/ATLAS-991
> Project: Atlas
>  Issue Type: Bug
>Reporter: Jeffrey Hagelberg
>Assignee: David Kantor
> Attachments: rb49869.patch
>
>
> It is often the case multiple entities get deleted at the same time.  The 
> current delete logic does not compute the delete closure up front, so it is 
> possible for the processing of a particular Entity to trigger a lower bound 
> violation in an entity that will be deleted but has not been processed yet.
> This issue is specific to hard delete.  It does not happen when soft delete 
> is being used.
> Here's a simple test that can be added to 
> GraphBackedMetadataRepositoryDeleteTestBase to reproduce the issue:
> {noformat}
> @Test
> public void testLowerBoundsIgnoredOnDeletedEntities() throws Exception {
> 
> String hrDeptGuid = createHrDeptGraph();
> ITypedReferenceableInstance hrDept = 
> repositoryService.getEntityDefinition(hrDeptGuid);
> Map nameGuidMap = getEmployeeNameGuidMap(hrDept);
> ITypedReferenceableInstance john = 
> repositoryService.getEntityDefinition(nameGuidMap.get("John"));
> String johnGuid = john.getId()._getId();
> ITypedReferenceableInstance max = 
> repositoryService.getEntityDefinition(nameGuidMap.get("Max"));
> String maxGuid = max.getId()._getId();
> 
> ITypedReferenceableInstance jane = 
> repositoryService.getEntityDefinition(nameGuidMap.get("Jane"));
> String janeGuid = jane.getId()._getId();
> 
> //the lower bound constraint on jane.subordinates should not be 
> enforced since jane is being deleted
> deleteEntities(johnGuid, maxGuid, janeGuid);
> 
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ATLAS-991) Lower bound checking not always disabled for Entities being deleted

2016-08-08 Thread David Kantor (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Kantor updated ATLAS-991:
---
Attachment: (was: rb49869.patch)

> Lower bound checking not always disabled for Entities being deleted
> ---
>
> Key: ATLAS-991
> URL: https://issues.apache.org/jira/browse/ATLAS-991
> Project: Atlas
>  Issue Type: Bug
>Reporter: Jeffrey Hagelberg
>Assignee: David Kantor
>
> It is often the case multiple entities get deleted at the same time.  The 
> current delete logic does not compute the delete closure up front, so it is 
> possible for the processing of a particular Entity to trigger a lower bound 
> violation in an entity that will be deleted but has not been processed yet.
> This issue is specific to hard delete.  It does not happen when soft delete 
> is being used.
> Here's a simple test that can be added to 
> GraphBackedMetadataRepositoryDeleteTestBase to reproduce the issue:
> {noformat}
> @Test
> public void testLowerBoundsIgnoredOnDeletedEntities() throws Exception {
> 
> String hrDeptGuid = createHrDeptGraph();
> ITypedReferenceableInstance hrDept = 
> repositoryService.getEntityDefinition(hrDeptGuid);
> Map nameGuidMap = getEmployeeNameGuidMap(hrDept);
> ITypedReferenceableInstance john = 
> repositoryService.getEntityDefinition(nameGuidMap.get("John"));
> String johnGuid = john.getId()._getId();
> ITypedReferenceableInstance max = 
> repositoryService.getEntityDefinition(nameGuidMap.get("Max"));
> String maxGuid = max.getId()._getId();
> 
> ITypedReferenceableInstance jane = 
> repositoryService.getEntityDefinition(nameGuidMap.get("Jane"));
> String janeGuid = jane.getId()._getId();
> 
> //the lower bound constraint on jane.subordinates should not be 
> enforced since jane is being deleted
> deleteEntities(johnGuid, maxGuid, janeGuid);
> 
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ATLAS-1104) Get outgoing edges by label doesn't work in some cases

2016-08-08 Thread Suma Shivaprasad (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412721#comment-15412721
 ] 

Suma Shivaprasad commented on ATLAS-1104:
-

+1 based on above 

> Get outgoing edges by label doesn't work in some cases
> --
>
> Key: ATLAS-1104
> URL: https://issues.apache.org/jira/browse/ATLAS-1104
> Project: Atlas
>  Issue Type: Bug
>Reporter: Shwetha G S
>Assignee: Shwetha G S
>Priority: Critical
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1104.1.patch, ATLAS-1104.patch
>
>
> In one of the concurrent API scenario of add trait APIs and search API, the 
> edge for add trait was added, but get edge by label doesn't return the edge. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 49869: ATLAS-991: avoid enforcing required attributes on deleted entities

2016-08-08 Thread David Kantor

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49869/
---

(Updated Aug. 9, 2016, 12:36 a.m.)


Review request for atlas.


Bugs: ATLAS-991
https://issues.apache.org/jira/browse/ATLAS-991


Repository: atlas


Description
---

When deleting entities, avoid enforcing lower bound constraints (i.e. required 
attributes) on all entities being deleted.  Previously, only the entities that 
were specifically requested for deletion were skipped when enforcing required 
attributes, but any composite entities that were owned by 'root' deletion 
candidates were not skipped, causing NullRequiredAttributeException to be 
thrown unnecessarily.


Diffs (updated)
-

  repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 
8d31c1b079a11291a87569fde6f2cb21d4258ca9 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
 e301a00b16ad316a85714cbda4af43d01f11f4ad 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
0a90bda72e90569c1d9d8fdef2c9df9827742874 
  
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java
 34842c3dc2904b123fecb5087aee357678b00156 
  
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositoryHardDeleteTest.java
 cc6026461bcd38b83dde0bcec2e835f5824e894f 
  
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositorySoftDeleteTest.java
 90bb635126a02cd38c045bd5332499c4481d3751 
  
repository/src/test/java/org/apache/atlas/repository/graph/GraphHelperTest.java 
8a0a6bc60818c3dd58e12386c55a471de2508b5e 

Diff: https://reviews.apache.org/r/49869/diff/


Testing
---

Ran all unit and integration tests with no regressions.


Thanks,

David Kantor



[jira] [Commented] (ATLAS-1106) Fix Build failure due to wrong version in graphdb/common pom

2016-08-08 Thread David Kantor (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412675#comment-15412675
 ] 

David Kantor commented on ATLAS-1106:
-

+1 for the patch

> Fix Build failure due to wrong version in graphdb/common pom
> 
>
> Key: ATLAS-1106
> URL: https://issues.apache.org/jira/browse/ATLAS-1106
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.8-incubating
>Reporter: Suma Shivaprasad
>Assignee: Suma Shivaprasad
>Priority: Blocker
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1106.patch
>
>
> {noformat}
>  mvn clean install
> [INFO] Scanning for projects...
> [ERROR] [ERROR] Some problems were encountered while processing the POMs:
> [FATAL] Non-resolvable parent POM for 
> org.apache.atlas:atlas-graphdb-common:[unknown-version]: Could not find 
> artifact org.apache.atlas:atlas-graphdb:pom:0.8-incubator-SNAPSHOT and 
> 'parent.relativePath' points at wrong local POM @ line 18, column 13
> [WARNING] 'build.plugins.plugin.version' for 
> org.codehaus.mojo:keytool-maven-plugin is missing. @ 
> org.apache.atlas:atlas-webapp:[unknown-version], 
> /Users/sshivaprasad/workspace-latest/incubator-atlas-ws1/webapp/pom.xml, line 
> 361, column 21
>  @
> [ERROR] The build could not read 1 project -> [Help 1]
> [ERROR]
> [ERROR]   The project org.apache.atlas:atlas-graphdb-common:[unknown-version] 
> (/Users/sshivaprasad/workspace-latest/incubator-atlas-ws1/graphdb/common/pom.xml)
>  has 1 error
> [ERROR] Non-resolvable parent POM for 
> org.apache.atlas:atlas-graphdb-common:[unknown-version]: Could not find 
> artifact org.apache.atlas:atlas-graphdb:pom:0.8-incubator-SNAPSHOT and 
> 'parent.relativePath' points at wrong local POM @ line 18, column 13 -> [Help 
> 2]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
> [ERROR] [Help 2] 
> http://cwiki.apache.org/confluence/display/MAVEN/UnresolvableModelException
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ATLAS-1106) Fix Build failure due to wrong version in graphdb/common pom

2016-08-08 Thread Suma Shivaprasad (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suma Shivaprasad updated ATLAS-1106:

Priority: Blocker  (was: Major)

> Fix Build failure due to wrong version in graphdb/common pom
> 
>
> Key: ATLAS-1106
> URL: https://issues.apache.org/jira/browse/ATLAS-1106
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.8-incubating
>Reporter: Suma Shivaprasad
>Assignee: Suma Shivaprasad
>Priority: Blocker
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1106.patch
>
>
> {noformat}
>  mvn clean install
> [INFO] Scanning for projects...
> [ERROR] [ERROR] Some problems were encountered while processing the POMs:
> [FATAL] Non-resolvable parent POM for 
> org.apache.atlas:atlas-graphdb-common:[unknown-version]: Could not find 
> artifact org.apache.atlas:atlas-graphdb:pom:0.8-incubator-SNAPSHOT and 
> 'parent.relativePath' points at wrong local POM @ line 18, column 13
> [WARNING] 'build.plugins.plugin.version' for 
> org.codehaus.mojo:keytool-maven-plugin is missing. @ 
> org.apache.atlas:atlas-webapp:[unknown-version], 
> /Users/sshivaprasad/workspace-latest/incubator-atlas-ws1/webapp/pom.xml, line 
> 361, column 21
>  @
> [ERROR] The build could not read 1 project -> [Help 1]
> [ERROR]
> [ERROR]   The project org.apache.atlas:atlas-graphdb-common:[unknown-version] 
> (/Users/sshivaprasad/workspace-latest/incubator-atlas-ws1/graphdb/common/pom.xml)
>  has 1 error
> [ERROR] Non-resolvable parent POM for 
> org.apache.atlas:atlas-graphdb-common:[unknown-version]: Could not find 
> artifact org.apache.atlas:atlas-graphdb:pom:0.8-incubator-SNAPSHOT and 
> 'parent.relativePath' points at wrong local POM @ line 18, column 13 -> [Help 
> 2]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
> [ERROR] [Help 2] 
> http://cwiki.apache.org/confluence/display/MAVEN/UnresolvableModelException
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ATLAS-1106) Fix Build failure due to wrong version in graphdb/common pom

2016-08-08 Thread Suma Shivaprasad (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suma Shivaprasad updated ATLAS-1106:

Description: 
{noformat}
 mvn clean install
[INFO] Scanning for projects...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[FATAL] Non-resolvable parent POM for 
org.apache.atlas:atlas-graphdb-common:[unknown-version]: Could not find 
artifact org.apache.atlas:atlas-graphdb:pom:0.8-incubator-SNAPSHOT and 
'parent.relativePath' points at wrong local POM @ line 18, column 13
[WARNING] 'build.plugins.plugin.version' for 
org.codehaus.mojo:keytool-maven-plugin is missing. @ 
org.apache.atlas:atlas-webapp:[unknown-version], 
/Users/sshivaprasad/workspace-latest/incubator-atlas-ws1/webapp/pom.xml, line 
361, column 21
 @
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]
[ERROR]   The project org.apache.atlas:atlas-graphdb-common:[unknown-version] 
(/Users/sshivaprasad/workspace-latest/incubator-atlas-ws1/graphdb/common/pom.xml)
 has 1 error
[ERROR] Non-resolvable parent POM for 
org.apache.atlas:atlas-graphdb-common:[unknown-version]: Could not find 
artifact org.apache.atlas:atlas-graphdb:pom:0.8-incubator-SNAPSHOT and 
'parent.relativePath' points at wrong local POM @ line 18, column 13 -> [Help 2]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
[ERROR] [Help 2] 
http://cwiki.apache.org/confluence/display/MAVEN/UnresolvableModelException
{noformat}

> Fix Build failure due to wrong version in graphdb/common pom
> 
>
> Key: ATLAS-1106
> URL: https://issues.apache.org/jira/browse/ATLAS-1106
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.8-incubating
>Reporter: Suma Shivaprasad
>Assignee: Suma Shivaprasad
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1106.patch
>
>
> {noformat}
>  mvn clean install
> [INFO] Scanning for projects...
> [ERROR] [ERROR] Some problems were encountered while processing the POMs:
> [FATAL] Non-resolvable parent POM for 
> org.apache.atlas:atlas-graphdb-common:[unknown-version]: Could not find 
> artifact org.apache.atlas:atlas-graphdb:pom:0.8-incubator-SNAPSHOT and 
> 'parent.relativePath' points at wrong local POM @ line 18, column 13
> [WARNING] 'build.plugins.plugin.version' for 
> org.codehaus.mojo:keytool-maven-plugin is missing. @ 
> org.apache.atlas:atlas-webapp:[unknown-version], 
> /Users/sshivaprasad/workspace-latest/incubator-atlas-ws1/webapp/pom.xml, line 
> 361, column 21
>  @
> [ERROR] The build could not read 1 project -> [Help 1]
> [ERROR]
> [ERROR]   The project org.apache.atlas:atlas-graphdb-common:[unknown-version] 
> (/Users/sshivaprasad/workspace-latest/incubator-atlas-ws1/graphdb/common/pom.xml)
>  has 1 error
> [ERROR] Non-resolvable parent POM for 
> org.apache.atlas:atlas-graphdb-common:[unknown-version]: Could not find 
> artifact org.apache.atlas:atlas-graphdb:pom:0.8-incubator-SNAPSHOT and 
> 'parent.relativePath' points at wrong local POM @ line 18, column 13 -> [Help 
> 2]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
> [ERROR] [Help 2] 
> http://cwiki.apache.org/confluence/display/MAVEN/UnresolvableModelException
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (ATLAS-1106) Fix Build failure due to wrong version in graphdb/common pom

2016-08-08 Thread Suma Shivaprasad (JIRA)
Suma Shivaprasad created ATLAS-1106:
---

 Summary: Fix Build failure due to wrong version in graphdb/common 
pom
 Key: ATLAS-1106
 URL: https://issues.apache.org/jira/browse/ATLAS-1106
 Project: Atlas
  Issue Type: Bug
Affects Versions: 0.8-incubating
Reporter: Suma Shivaprasad
Assignee: Suma Shivaprasad
 Fix For: 0.8-incubating






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 49869: ATLAS-991: avoid enforcing required attributes on deleted entities

2016-08-08 Thread David Kantor

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49869/
---

(Updated Aug. 8, 2016, 10:39 p.m.)


Review request for atlas.


Changes
---

Added test case per Shwetha's review comment.


Bugs: ATLAS-991
https://issues.apache.org/jira/browse/ATLAS-991


Repository: atlas


Description
---

When deleting entities, avoid enforcing lower bound constraints (i.e. required 
attributes) on all entities being deleted.  Previously, only the entities that 
were specifically requested for deletion were skipped when enforcing required 
attributes, but any composite entities that were owned by 'root' deletion 
candidates were not skipped, causing NullRequiredAttributeException to be 
thrown unnecessarily.


Diffs (updated)
-

  repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 
8d31c1b079a11291a87569fde6f2cb21d4258ca9 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
 e301a00b16ad316a85714cbda4af43d01f11f4ad 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
0a90bda72e90569c1d9d8fdef2c9df9827742874 
  
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java
 34842c3dc2904b123fecb5087aee357678b00156 
  
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositoryHardDeleteTest.java
 cc6026461bcd38b83dde0bcec2e835f5824e894f 
  
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositorySoftDeleteTest.java
 90bb635126a02cd38c045bd5332499c4481d3751 
  
repository/src/test/java/org/apache/atlas/repository/graph/GraphHelperTest.java 
8a0a6bc60818c3dd58e12386c55a471de2508b5e 

Diff: https://reviews.apache.org/r/49869/diff/


Testing
---

Ran all unit and integration tests with no regressions.


Thanks,

David Kantor



[jira] [Commented] (ATLAS-1105) Disable HiveLiteralRewriterTest since its not used currently

2016-08-08 Thread Suma Shivaprasad (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412484#comment-15412484
 ] 

Suma Shivaprasad commented on ATLAS-1105:
-

Committed. Thanks for the review [~madhan.neethiraj]

> Disable HiveLiteralRewriterTest since its not used currently
> 
>
> Key: ATLAS-1105
> URL: https://issues.apache.org/jira/browse/ATLAS-1105
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Suma Shivaprasad
>Assignee: Suma Shivaprasad
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1105.patch
>
>
> Disable test since HiveLiteralRewriter is no longer used in 
> HiveHook.getProcessQualifiedName



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ATLAS-1105) Disable HiveLiteralRewriterTest since its not used currently

2016-08-08 Thread Madhan Neethiraj (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412478#comment-15412478
 ] 

Madhan Neethiraj commented on ATLAS-1105:
-

+1 for the patch

> Disable HiveLiteralRewriterTest since its not used currently
> 
>
> Key: ATLAS-1105
> URL: https://issues.apache.org/jira/browse/ATLAS-1105
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Suma Shivaprasad
>Assignee: Suma Shivaprasad
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1105.patch
>
>
> Disable test since HiveLiteralRewriter is no longer used in 
> HiveHook.getProcessQualifiedName



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 50892: ATLAS - 1103 : UI: Search type list is not refreshed.

2016-08-08 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50892/#review145139
---


Ship it!




Ship It!

- Madhan Neethiraj


On Aug. 8, 2016, 12:04 p.m., Kalyani Kashikar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50892/
> ---
> 
> (Updated Aug. 8, 2016, 12:04 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1103
> https://issues.apache.org/jira/browse/ATLAS-1103
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> The list of types fetched for DSL search is done on main page rendering and 
> not when the drop down is clicked. So, if a type is created after the main UI 
> page is opened, the type list is not refreshed
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html 3596732 
>   dashboardv2/public/js/utils/CommonViewFunction.js b8c8dea 
>   dashboardv2/public/js/views/business_catalog/AddTermToEntityLayoutView.js 
> e35186c 
>   dashboardv2/public/js/views/graph/LineageLayoutView.js acf0d8e 
>   dashboardv2/public/js/views/search/SearchLayoutView.js 6469c62 
>   dashboardv2/public/js/views/search/SearchResultLayoutView.js 865167d 
>   dashboardv2/public/js/views/tag/addTagModalView.js c29ad25 
> 
> Diff: https://reviews.apache.org/r/50892/diff/
> 
> 
> Testing
> ---
> 
> ** Verified following scenario : **
> 
> * Added refresh button for DSL search which refresh the type dropdown.
> * In multiple tag/term assign fetch search api get called after all tag/term 
> response are came.
> 
> 
> Thanks,
> 
> Kalyani Kashikar
> 
>



[jira] [Commented] (ATLAS-1104) Get outgoing edges by label doesn't work in some cases

2016-08-08 Thread Suma Shivaprasad (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412420#comment-15412420
 ] 

Suma Shivaprasad commented on ATLAS-1104:
-

Verified with updated patch that quickstart and tag deletion works from UI for 
the parallel execution scenarios when addTrait , dsl search  are done in 
parallel with subsequent deleteTrait operation.

> Get outgoing edges by label doesn't work in some cases
> --
>
> Key: ATLAS-1104
> URL: https://issues.apache.org/jira/browse/ATLAS-1104
> Project: Atlas
>  Issue Type: Bug
>Reporter: Shwetha G S
>Assignee: Shwetha G S
>Priority: Critical
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1104.1.patch, ATLAS-1104.patch
>
>
> In one of the concurrent API scenario of add trait APIs and search API, the 
> edge for add trait was added, but get edge by label doesn't return the edge. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ATLAS-1104) Get outgoing edges by label doesn't work in some cases

2016-08-08 Thread Suma Shivaprasad (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suma Shivaprasad updated ATLAS-1104:

Attachment: ATLAS-1104.1.patch

Uploaded patch after fixing review comment for GraphHelper.getOrCreateEdge

> Get outgoing edges by label doesn't work in some cases
> --
>
> Key: ATLAS-1104
> URL: https://issues.apache.org/jira/browse/ATLAS-1104
> Project: Atlas
>  Issue Type: Bug
>Reporter: Shwetha G S
>Assignee: Shwetha G S
>Priority: Critical
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1104.1.patch, ATLAS-1104.patch
>
>
> In one of the concurrent API scenario of add trait APIs and search API, the 
> edge for add trait was added, but get edge by label doesn't return the edge. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 50890: ATLAS-1104 Get outgoing edges by label doesn't work in some cases

2016-08-08 Thread Suma Shivaprasad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50890/#review145131
---




repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
(line 198)


Will have to make similiar changes to change method calls to 
GraphHelper.getOutgoingEdgesByLabel in

1. public Edge getOrCreateEdge(Vertex outVertex, Vertex inVertex, String 
edgeLabel) {
Iterable edges = inVertex.getEdges(Direction.IN, edgeLabel);

2. Titan0Vertex.getEdges(AtlasEdgeDirection dir, String edgeLabel)


- Suma Shivaprasad


On Aug. 8, 2016, 10:59 a.m., Shwetha GS wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50890/
> ---
> 
> (Updated Aug. 8, 2016, 10:59 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1104
> https://issues.apache.org/jira/browse/ATLAS-1104
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Get edges by label replaced with traverse through get edges
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/graph/GraphBackedDiscoveryService.java
>  351bd12 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> 81fb76e 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java
>  69223f5 
>   
> repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java
>  3a5829b 
>   
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java
>  9bd3682 
>   
> repository/src/test/java/org/apache/atlas/repository/graph/GraphHelperTest.java
>  8a0a6bc 
> 
> Diff: https://reviews.apache.org/r/50890/diff/
> 
> 
> Testing
> ---
> 
> UTs
> 
> 
> Thanks,
> 
> Shwetha GS
> 
>



[jira] [Updated] (ATLAS-1105) Disable HiveLiteralRewriterTest since its not used currently

2016-08-08 Thread Suma Shivaprasad (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suma Shivaprasad updated ATLAS-1105:

Attachment: (was: ATLAS-1105.patch)

> Disable HiveLiteralRewriterTest since its not used currently
> 
>
> Key: ATLAS-1105
> URL: https://issues.apache.org/jira/browse/ATLAS-1105
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Suma Shivaprasad
>Assignee: Suma Shivaprasad
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1105.patch
>
>
> Disable test since HiveLiteralRewriter is no longer used in 
> HiveHook.getProcessQualifiedName



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ATLAS-1105) Disable HiveLiteralRewriterTest since its not used currently

2016-08-08 Thread Suma Shivaprasad (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suma Shivaprasad updated ATLAS-1105:

Attachment: ATLAS-1105.patch

> Disable HiveLiteralRewriterTest since its not used currently
> 
>
> Key: ATLAS-1105
> URL: https://issues.apache.org/jira/browse/ATLAS-1105
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Suma Shivaprasad
>Assignee: Suma Shivaprasad
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1105.patch
>
>
> Disable test since HiveLiteralRewriter is no longer used in 
> HiveHook.getProcessQualifiedName



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 50890: ATLAS-1104 Get outgoing edges by label doesn't work in some cases

2016-08-08 Thread Suma Shivaprasad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50890/#review145130
---




repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java
 (line 285)


Will have to make similiar changes to change method calls to 
GraphHelper.getOutgoingEdgesByLabel in

1. GraphToTypedInstanceMapper.mapVertexToTraitInstance
for (Edge edge : instanceVertex.getEdges(Direction.OUT, relationshipLabel)) 
{

2.  GraphHelper.getOrCreateEdge

   public Edge getOrCreateEdge(Vertex outVertex, Vertex inVertex, String 
edgeLabel) {
Iterable edges = inVertex.getEdges(Direction.IN, edgeLabel);

3. Titan0Vertex.getEdges(AtlasEdgeDirection dir, String edgeLabel)


- Suma Shivaprasad


On Aug. 8, 2016, 10:59 a.m., Shwetha GS wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50890/
> ---
> 
> (Updated Aug. 8, 2016, 10:59 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1104
> https://issues.apache.org/jira/browse/ATLAS-1104
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Get edges by label replaced with traverse through get edges
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/graph/GraphBackedDiscoveryService.java
>  351bd12 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> 81fb76e 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java
>  69223f5 
>   
> repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java
>  3a5829b 
>   
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java
>  9bd3682 
>   
> repository/src/test/java/org/apache/atlas/repository/graph/GraphHelperTest.java
>  8a0a6bc 
> 
> Diff: https://reviews.apache.org/r/50890/diff/
> 
> 
> Testing
> ---
> 
> UTs
> 
> 
> Thanks,
> 
> Shwetha GS
> 
>



[jira] [Updated] (ATLAS-1105) Disable HiveLiteralRewriterTest since its not used currently

2016-08-08 Thread Suma Shivaprasad (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suma Shivaprasad updated ATLAS-1105:

Summary: Disable HiveLiteralRewriterTest since its not used currently  
(was: Disable HiveLiteralRewriterTest.java since its not used currently)

> Disable HiveLiteralRewriterTest since its not used currently
> 
>
> Key: ATLAS-1105
> URL: https://issues.apache.org/jira/browse/ATLAS-1105
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Suma Shivaprasad
>Assignee: Suma Shivaprasad
> Fix For: 0.8-incubating
>
>
> Disable test since HiveLiteralRewriter is no longer used in 
> HiveHook.getProcessQualifiedName



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (ATLAS-1105) Disable HiveLiteralRewriterTest.java since its not used currently

2016-08-08 Thread Suma Shivaprasad (JIRA)
Suma Shivaprasad created ATLAS-1105:
---

 Summary: Disable HiveLiteralRewriterTest.java since its not used 
currently
 Key: ATLAS-1105
 URL: https://issues.apache.org/jira/browse/ATLAS-1105
 Project: Atlas
  Issue Type: Bug
Affects Versions: 0.7-incubating
Reporter: Suma Shivaprasad
Assignee: Suma Shivaprasad
 Fix For: 0.8-incubating


Disable test since HiveLiteralRewriter is no longer used in 
HiveHook.getProcessQualifiedName



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ATLAS-1105) Disable HiveLiteralRewriterTest since its not used currently

2016-08-08 Thread Suma Shivaprasad (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suma Shivaprasad updated ATLAS-1105:

Attachment: ATLAS-1105.patch

> Disable HiveLiteralRewriterTest since its not used currently
> 
>
> Key: ATLAS-1105
> URL: https://issues.apache.org/jira/browse/ATLAS-1105
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Suma Shivaprasad
>Assignee: Suma Shivaprasad
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1105.patch
>
>
> Disable test since HiveLiteralRewriter is no longer used in 
> HiveHook.getProcessQualifiedName



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Review Request 50892: ATLAS - 1103 : UI: Search type list is not refreshed.

2016-08-08 Thread Kalyani Kashikar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50892/
---

Review request for atlas, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.


Bugs: ATLAS-1103
https://issues.apache.org/jira/browse/ATLAS-1103


Repository: atlas


Description
---

The list of types fetched for DSL search is done on main page rendering and not 
when the drop down is clicked. So, if a type is created after the main UI page 
is opened, the type list is not refreshed


Diffs
-

  dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html 3596732 
  dashboardv2/public/js/utils/CommonViewFunction.js b8c8dea 
  dashboardv2/public/js/views/business_catalog/AddTermToEntityLayoutView.js 
e35186c 
  dashboardv2/public/js/views/graph/LineageLayoutView.js acf0d8e 
  dashboardv2/public/js/views/search/SearchLayoutView.js 6469c62 
  dashboardv2/public/js/views/search/SearchResultLayoutView.js 865167d 
  dashboardv2/public/js/views/tag/addTagModalView.js c29ad25 

Diff: https://reviews.apache.org/r/50892/diff/


Testing
---

** Verified following scenario : **

* Added refresh button for DSL search which refresh the type dropdown.
* In multiple tag/term assign fetch search api get called after all tag/term 
response are came.


Thanks,

Kalyani Kashikar



[jira] [Updated] (ATLAS-1103) UI: Search type list is not refreshed

2016-08-08 Thread Kalyani Kashikar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kalyani Kashikar updated ATLAS-1103:

Attachment: ATLAS-1103.patch

Handled following scenario : 

* Added refresh button for DSL search which refresh the type dropdown.
* In multiple tag/term assign fetch search api get called after all tag/term 
response are came.


> UI: Search type list is not refreshed
> -
>
> Key: ATLAS-1103
> URL: https://issues.apache.org/jira/browse/ATLAS-1103
> Project: Atlas
>  Issue Type: Bug
>Reporter: Shwetha G S
>Assignee: Kalyani Kashikar
> Attachments: ATLAS-1103.patch
>
>
> The list of types fetched for DSL search is done on main page rendering and 
> not when the drop down is clicked. So, if a type is created after the main UI 
> page is opened, the type list is not refreshed



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (ATLAS-1104) Get outgoing edges by label doesn't work in some cases

2016-08-08 Thread Shwetha G S (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411658#comment-15411658
 ] 

Shwetha G S edited comment on ATLAS-1104 at 8/8/16 11:00 AM:
-

This looks like a titan issue. The patch attached traverses all the edges for 
now. I will follow up with titan community with an example 


was (Author: shwethags):
This looks like a titan issue. The patch attached traverses all the edges for 
now. I will follow up with titan community

> Get outgoing edges by label doesn't work in some cases
> --
>
> Key: ATLAS-1104
> URL: https://issues.apache.org/jira/browse/ATLAS-1104
> Project: Atlas
>  Issue Type: Bug
>Reporter: Shwetha G S
>Assignee: Shwetha G S
>Priority: Critical
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1104.patch
>
>
> In one of the concurrent API scenario of add trait APIs and search API, the 
> edge for add trait was added, but get edge by label doesn't return the edge. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ATLAS-1104) Get outgoing edges by label doesn't work in some cases

2016-08-08 Thread Shwetha G S (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shwetha G S updated ATLAS-1104:
---
Attachment: ATLAS-1104.patch

> Get outgoing edges by label doesn't work in some cases
> --
>
> Key: ATLAS-1104
> URL: https://issues.apache.org/jira/browse/ATLAS-1104
> Project: Atlas
>  Issue Type: Bug
>Reporter: Shwetha G S
>Assignee: Shwetha G S
>Priority: Critical
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1104.patch
>
>
> In one of the concurrent API scenario of add trait APIs and search API, the 
> edge for add trait was added, but get edge by label doesn't return the edge. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ATLAS-1104) Get outgoing edges by label doesn't work in some cases

2016-08-08 Thread Shwetha G S (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shwetha G S updated ATLAS-1104:
---
Attachment: ATLAS-1104.patch

This looks like a titan issue. The patch attached traverses all the edges for 
now. I will follow up with titan community

> Get outgoing edges by label doesn't work in some cases
> --
>
> Key: ATLAS-1104
> URL: https://issues.apache.org/jira/browse/ATLAS-1104
> Project: Atlas
>  Issue Type: Bug
>Reporter: Shwetha G S
>Assignee: Shwetha G S
>Priority: Critical
> Attachments: ATLAS-1104.patch
>
>
> In one of the concurrent API scenario of add trait APIs and search API, the 
> edge for add trait was added, but get edge by label doesn't return the edge. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (ATLAS-1104) Get outgoing edges by label doesn't work in some cases

2016-08-08 Thread Shwetha G S (JIRA)
Shwetha G S created ATLAS-1104:
--

 Summary: Get outgoing edges by label doesn't work in some cases
 Key: ATLAS-1104
 URL: https://issues.apache.org/jira/browse/ATLAS-1104
 Project: Atlas
  Issue Type: Bug
Reporter: Shwetha G S
Assignee: Shwetha G S
Priority: Critical


In one of the concurrent API scenario of add trait APIs and search API, the 
edge for add trait was added, but get edge by label doesn't return the edge. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (ATLAS-1103) UI: Search type list is not refreshed

2016-08-08 Thread Kalyani Kashikar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kalyani Kashikar reassigned ATLAS-1103:
---

Assignee: Kalyani Kashikar

> UI: Search type list is not refreshed
> -
>
> Key: ATLAS-1103
> URL: https://issues.apache.org/jira/browse/ATLAS-1103
> Project: Atlas
>  Issue Type: Bug
>Reporter: Shwetha G S
>Assignee: Kalyani Kashikar
>
> The list of types fetched for DSL search is done on main page rendering and 
> not when the drop down is clicked. So, if a type is created after the main UI 
> page is opened, the type list is not refreshed



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (ATLAS-1103) UI: Search type list is not refreshed

2016-08-08 Thread Shwetha G S (JIRA)
Shwetha G S created ATLAS-1103:
--

 Summary: UI: Search type list is not refreshed
 Key: ATLAS-1103
 URL: https://issues.apache.org/jira/browse/ATLAS-1103
 Project: Atlas
  Issue Type: Bug
Reporter: Shwetha G S


The list of types fetched for DSL search is done on main page rendering and not 
when the drop down is clicked. So, if a type is created after the main UI page 
is opened, the type list is not refreshed



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)